[jira] [Comment Edited] (PHOENIX-4579) Add a config to conditionally create Phoenix meta tables on first client connection
[ https://issues.apache.org/jira/browse/PHOENIX-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403082#comment-16403082 ] Chinmay Kulkarni edited comment on PHOENIX-4579 at 3/19/18 5:30 PM: [~tdsilva] [~jamestaylor] when going over _ConnectionQueryServicesImpl.ensureTableCreated()_, I see that we modify the table descriptor with newDesc.setValue(HTableDescriptor.SPLIT_POLICY, MetaDataSplitPolicy.class.getName()), however we already have this mentioned in the create statement DDL for system tables. The comments mention that this is done as as a workaround for handling HBASE-12570 which causes the cluster to be brought down. Do we still need to do this? was (Author: ckulkarni): [~tdsilva] [~jamestaylor] when going over _ConnectionQueryServicesImpl._ensureTableCreated(), I see that we modify the table descriptor with newDesc.setValue(HTableDescriptor.SPLIT_POLICY, MetaDataSplitPolicy.class.getName()), however we already have this mentioned in the create statement DDL for system tables. The comments mention that this is done as as a workaround for handling HBASE-12570 which causes the cluster to be brought down. Do we still need to do this? > Add a config to conditionally create Phoenix meta tables on first client > connection > --- > > Key: PHOENIX-4579 > URL: https://issues.apache.org/jira/browse/PHOENIX-4579 > Project: Phoenix > Issue Type: New Feature >Reporter: Mujtaba Chohan >Assignee: Chinmay Kulkarni >Priority: Major > Attachments: PHOENIX-4579.patch > > > Currently we create/modify Phoenix meta tables on first client connection. > Adding a property to make it configurable (with default true as it is > currently implemented). > With this property set to false, it will avoid lockstep upgrade requirement > for all clients when changing meta properties using PHOENIX-4575 as this > property can be flipped back on once all the clients are upgraded. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (PHOENIX-4579) Add a config to conditionally create Phoenix meta tables on first client connection
[ https://issues.apache.org/jira/browse/PHOENIX-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398045#comment-16398045 ] Thomas D'Silva edited comment on PHOENIX-4579 at 3/14/18 3:31 AM: -- [~jamestaylor] Whenever a client connects we try to create SYSTEM.CATALOG, but on the server if the current table timestamp matches the timestamp of the mutations sent from the client we return a newer table found and don't change the table properties. I was trying to understand how when we set KEEP_DELETED_CELLS to false (manually using sqline or HBase shell) it was getting set back to true. Do you know how that happened? was (Author: tdsilva): [~jamestaylor] Whenever a client connect we try to create SYSTEM.CATALOG, but on the server if the current table timestamp matches the timestamp of the mutations sent from the client we return a newer table found and don't change the table properties. I was trying to understand how when we set KEEP_DELETED_CELLS to false (manually using sqline or HBase shell) it was getting set back to true. Do you know how that happened? > Add a config to conditionally create Phoenix meta tables on first client > connection > --- > > Key: PHOENIX-4579 > URL: https://issues.apache.org/jira/browse/PHOENIX-4579 > Project: Phoenix > Issue Type: New Feature >Reporter: Mujtaba Chohan >Assignee: Mujtaba Chohan >Priority: Major > Attachments: PHOENIX-4579.patch > > > Currently we create/modify Phoenix meta tables on first client connection. > Adding a property to make it configurable (with default true as it is > currently implemented). > With this property set to false, it will avoid lockstep upgrade requirement > for all clients when changing meta properties using PHOENIX-4575 as this > property can be flipped back on once all the clients are upgraded. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
