[jira] [Commented] (OMID-249) Improve default network address logic

2024-01-23 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/OMID-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809811#comment-17809811
 ] 

ASF GitHub Bot commented on OMID-249:
-

stoty closed pull request #154: OMID-249 Improve default network address logic
URL: https://github.com/apache/phoenix-omid/pull/154




> Improve default network address logic
> -
>
> Key: OMID-249
> URL: https://issues.apache.org/jira/browse/OMID-249
> Project: Phoenix Omid
>  Issue Type: Improvement
>Affects Versions: 1.1.0
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
>
> NetworkUtils.getNetworkInterface() seems to be only used for determining the 
> host and port when registering TSO to ZK for HA.
> We should get the TSO public IP from the ZK TCP connection on demand, and not 
> worry about the default network interface at all.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OMID-249) Improve default network address logic

2024-01-23 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/OMID-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809812#comment-17809812
 ] 

ASF GitHub Bot commented on OMID-249:
-

stoty commented on PR #154:
URL: https://github.com/apache/phoenix-omid/pull/154#issuecomment-1905593916

   merged manually




> Improve default network address logic
> -
>
> Key: OMID-249
> URL: https://issues.apache.org/jira/browse/OMID-249
> Project: Phoenix Omid
>  Issue Type: Improvement
>Affects Versions: 1.1.0
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
>
> NetworkUtils.getNetworkInterface() seems to be only used for determining the 
> host and port when registering TSO to ZK for HA.
> We should get the TSO public IP from the ZK TCP connection on demand, and not 
> worry about the default network interface at all.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OMID-249) Improve default network address logic

2024-01-19 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/OMID-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808656#comment-17808656
 ] 

ASF GitHub Bot commented on OMID-249:
-

stoty opened a new pull request, #154:
URL: https://github.com/apache/phoenix-omid/pull/154

   (no comment)




> Improve default network address logic
> -
>
> Key: OMID-249
> URL: https://issues.apache.org/jira/browse/OMID-249
> Project: Phoenix Omid
>  Issue Type: Improvement
>Affects Versions: 1.1.0
>Reporter: Istvan Toth
>Priority: Major
>
> NetworkUtils.getNetworkInterface() seems to be only used for determining the 
> host and port when registering TSO to ZK for HA.
> We should get the TSO public IP from the ZK TCP connection on demand, and not 
> worry about the default network interface at all.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)