[jira] [Commented] (PHOENIX-3242) Support UDF in Phoenix-Calcite Integration

2016-10-28 Thread Maryann Xue (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616656#comment-15616656
 ] 

Maryann Xue commented on PHOENIX-3242:
--

Done, [~rajeshbabu]. Please go ahead and commit for this issue. Thanks again!

> Support UDF in Phoenix-Calcite Integration
> --
>
> Key: PHOENIX-3242
> URL: https://issues.apache.org/jira/browse/PHOENIX-3242
> Project: Phoenix
>  Issue Type: Task
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>  Labels: calcite
> Attachments: PHOENIX-3242-WIP-2.patch, PHOENIX-3242-wip.patch, 
> PHOENIX-3242_addendum.patch, PHOENIX-3242_select-wip.patch, 
> PHOENIX-3242_v1.patch, PHOENIX-3242_v2.patch, PHOENIX-3242_v3.patch, 
> PHOENIX-3242_v4.patch, PHOENIX-3242_v5.patch, PHOENIX-3242_v6.patch, 
> PHOENIX-3242_v7.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3242) Support UDF in Phoenix-Calcite Integration

2016-10-28 Thread Rajeshbabu Chintaguntla (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614533#comment-15614533
 ] 

Rajeshbabu Chintaguntla commented on PHOENIX-3242:
--

[~maryannxue] Pushed PHOENIX-3417 to master. Let me know once you sync calcite 
branch with master so that I will rebase the addendum patch. Thanks.

> Support UDF in Phoenix-Calcite Integration
> --
>
> Key: PHOENIX-3242
> URL: https://issues.apache.org/jira/browse/PHOENIX-3242
> Project: Phoenix
>  Issue Type: Task
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>  Labels: calcite
> Attachments: PHOENIX-3242-WIP-2.patch, PHOENIX-3242-wip.patch, 
> PHOENIX-3242_addendum.patch, PHOENIX-3242_select-wip.patch, 
> PHOENIX-3242_v1.patch, PHOENIX-3242_v2.patch, PHOENIX-3242_v3.patch, 
> PHOENIX-3242_v4.patch, PHOENIX-3242_v5.patch, PHOENIX-3242_v6.patch, 
> PHOENIX-3242_v7.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3242) Support UDF in Phoenix-Calcite Integration

2016-10-27 Thread Rajeshbabu Chintaguntla (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611071#comment-15611071
 ] 

Rajeshbabu Chintaguntla commented on PHOENIX-3242:
--

Thanks [~maryannxue] for review.
bq. So UDF support is complete with this patch, right? 
Yes. It's complete.
Raised PHOENIX-3417 for refactoring in master branch.
Going to commit this patch to calcite.

> Support UDF in Phoenix-Calcite Integration
> --
>
> Key: PHOENIX-3242
> URL: https://issues.apache.org/jira/browse/PHOENIX-3242
> Project: Phoenix
>  Issue Type: Task
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>  Labels: calcite
> Attachments: PHOENIX-3242-WIP-2.patch, PHOENIX-3242-wip.patch, 
> PHOENIX-3242_addendum.patch, PHOENIX-3242_select-wip.patch, 
> PHOENIX-3242_v1.patch, PHOENIX-3242_v2.patch, PHOENIX-3242_v3.patch, 
> PHOENIX-3242_v4.patch, PHOENIX-3242_v5.patch, PHOENIX-3242_v6.patch, 
> PHOENIX-3242_v7.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3242) Support UDF in Phoenix-Calcite Integration

2016-10-26 Thread Maryann Xue (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15609844#comment-15609844
 ] 

Maryann Xue commented on PHOENIX-3242:
--

Thank you very much for the patch, [~rajeshbabu]! I looks good to me. So UDF 
support is complete with this patch, right? I see part of this patch is 
refactoring of FunctionParseNode and extract some logic into 
{{validateFunctionArguement()}}, so you think it should made into master 
branch, [~rajeshbabu] and [~jamestaylor]?

> Support UDF in Phoenix-Calcite Integration
> --
>
> Key: PHOENIX-3242
> URL: https://issues.apache.org/jira/browse/PHOENIX-3242
> Project: Phoenix
>  Issue Type: Task
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>  Labels: calcite
> Attachments: PHOENIX-3242-WIP-2.patch, PHOENIX-3242-wip.patch, 
> PHOENIX-3242_addendum.patch, PHOENIX-3242_select-wip.patch, 
> PHOENIX-3242_v1.patch, PHOENIX-3242_v2.patch, PHOENIX-3242_v3.patch, 
> PHOENIX-3242_v4.patch, PHOENIX-3242_v5.patch, PHOENIX-3242_v6.patch, 
> PHOENIX-3242_v7.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3242) Support UDF in Phoenix-Calcite Integration

2016-10-10 Thread Maryann Xue (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563673#comment-15563673
 ] 

Maryann Xue commented on PHOENIX-3242:
--

BTW, would you mind completing the default parameter support before doing other 
patches? That way we can close this issue.

> Support UDF in Phoenix-Calcite Integration
> --
>
> Key: PHOENIX-3242
> URL: https://issues.apache.org/jira/browse/PHOENIX-3242
> Project: Phoenix
>  Issue Type: Task
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>  Labels: calcite
> Attachments: PHOENIX-3242-WIP-2.patch, PHOENIX-3242-wip.patch, 
> PHOENIX-3242_select-wip.patch, PHOENIX-3242_v1.patch, PHOENIX-3242_v2.patch, 
> PHOENIX-3242_v3.patch, PHOENIX-3242_v4.patch, PHOENIX-3242_v5.patch, 
> PHOENIX-3242_v6.patch, PHOENIX-3242_v7.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3242) Support UDF in Phoenix-Calcite Integration

2016-10-10 Thread Maryann Xue (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563670#comment-15563670
 ] 

Maryann Xue commented on PHOENIX-3242:
--

Thanks, [~rajeshbabu]! Just wanted to double check if we need to more work for 
PHOENIX-3355. But not sure which takes precedence, built-in or UDF. Let's 
continue this discussion on that JIRA then.

> Support UDF in Phoenix-Calcite Integration
> --
>
> Key: PHOENIX-3242
> URL: https://issues.apache.org/jira/browse/PHOENIX-3242
> Project: Phoenix
>  Issue Type: Task
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>  Labels: calcite
> Attachments: PHOENIX-3242-WIP-2.patch, PHOENIX-3242-wip.patch, 
> PHOENIX-3242_select-wip.patch, PHOENIX-3242_v1.patch, PHOENIX-3242_v2.patch, 
> PHOENIX-3242_v3.patch, PHOENIX-3242_v4.patch, PHOENIX-3242_v5.patch, 
> PHOENIX-3242_v6.patch, PHOENIX-3242_v7.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)