[jira] [Commented] (PHOENIX-3376) Physical table for indexes on views isn't use same schema as table
[ https://issues.apache.org/jira/browse/PHOENIX-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15699897#comment-15699897 ] James Taylor commented on PHOENIX-3376: --- Yes, this is still an issue, I believe, [~an...@apache.org]. Let's get rid of any usages of the util func mentioned in the description and add a couple of unit tests. > Physical table for indexes on views isn't use same schema as table > -- > > Key: PHOENIX-3376 > URL: https://issues.apache.org/jira/browse/PHOENIX-3376 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor >Assignee: Ankit Singhal > Fix For: 4.10.0 > > > See this code in ConnectionQueryServicesImpl: > {code} > private void ensureViewIndexTableCreated(byte[] physicalTableName, > Map tableProps, > List>> families, byte[][] > splits, long timestamp, > boolean isNamespaceMapped) throws SQLException { > byte[] physicalIndexName = > MetaDataUtil.getViewIndexPhysicalName(physicalTableName); > {code} > We should get rid of the {{MetaDataUtil.getViewIndexPhysicalName()}} function > and use the appropriate one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-3376) Physical table for indexes on views isn't use same schema as table
[ https://issues.apache.org/jira/browse/PHOENIX-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15699230#comment-15699230 ] Ankit Singhal commented on PHOENIX-3376: [~jamestaylor] , is still this needs a fix? > Physical table for indexes on views isn't use same schema as table > -- > > Key: PHOENIX-3376 > URL: https://issues.apache.org/jira/browse/PHOENIX-3376 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor >Assignee: Ankit Singhal > Fix For: 4.10.0 > > > See this code in ConnectionQueryServicesImpl: > {code} > private void ensureViewIndexTableCreated(byte[] physicalTableName, > Map tableProps, > List>> families, byte[][] > splits, long timestamp, > boolean isNamespaceMapped) throws SQLException { > byte[] physicalIndexName = > MetaDataUtil.getViewIndexPhysicalName(physicalTableName); > {code} > We should get rid of the {{MetaDataUtil.getViewIndexPhysicalName()}} function > and use the appropriate one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-3376) Physical table for indexes on views isn't use same schema as table
[ https://issues.apache.org/jira/browse/PHOENIX-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571882#comment-15571882 ] Ankit Singhal commented on PHOENIX-3376: [~jamestaylor], you mean if we have a view in a schema(S_V) and data table in schema (S) and if namespace is enabled,then physical table for indexes on a view should also reside in namespace(S_V:_IDX_)? > Physical table for indexes on views isn't use same schema as table > -- > > Key: PHOENIX-3376 > URL: https://issues.apache.org/jira/browse/PHOENIX-3376 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor > Fix For: 4.9.0 > > > See this code in ConnectionQueryServicesImpl: > {code} > private void ensureViewIndexTableCreated(byte[] physicalTableName, > Map tableProps, > List>> families, byte[][] > splits, long timestamp, > boolean isNamespaceMapped) throws SQLException { > byte[] physicalIndexName = > MetaDataUtil.getViewIndexPhysicalName(physicalTableName); > {code} > We should get rid of the {{MetaDataUtil.getViewIndexPhysicalName()}} function > and use the appropriate one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-3376) Physical table for indexes on views isn't use same schema as table
[ https://issues.apache.org/jira/browse/PHOENIX-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570514#comment-15570514 ] James Taylor commented on PHOENIX-3376: --- [~an...@apache.org] - do you think you could take a look? We have to be a bit careful about backward compatibility. Perhaps we can keep the existing behavior when namespaces is off, but use the correct one when it's on? > Physical table for indexes on views isn't use same schema as table > -- > > Key: PHOENIX-3376 > URL: https://issues.apache.org/jira/browse/PHOENIX-3376 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor > Fix For: 4.9.0 > > > See this code in ConnectionQueryServicesImpl: > {code} > private void ensureViewIndexTableCreated(byte[] physicalTableName, > Map tableProps, > List>> families, byte[][] > splits, long timestamp, > boolean isNamespaceMapped) throws SQLException { > byte[] physicalIndexName = > MetaDataUtil.getViewIndexPhysicalName(physicalTableName); > {code} > We should get rid of the {{MetaDataUtil.getViewIndexPhysicalName()}} function > and use the appropriate one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)