[jira] [Commented] (PHOENIX-3710) Cannot use lowername data table name with indextool
[
https://issues.apache.org/jira/browse/PHOENIX-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982772#comment-15982772
]
Hadoop QA commented on PHOENIX-3710:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12864835/PHOENIX-3710.patch
against master branch at commit 92b951e5387768e084ed09729884a59160cd81d3.
ATTACHMENT ID: 12864835
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
47 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+? SchemaUtil.getQualifiedTableName(schemaName,
indexTable) : SchemaUtil.normalizeIdentifier(indexTable));
+IndexToolUtil.updateIndexState(connection, dataTableName,
indexTable, PIndexState.ACTIVE);
+final String schemaName =
SchemaUtil.normalizeIdentifier(SchemaUtil.getSchemaNameFromFullName(masterTable));
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolForPartialBuildWithNamespaceEnabledIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/839//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/839//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/839//console
This message is automatically generated.
> Cannot use lowername data table name with indextool
> ---
>
> Key: PHOENIX-3710
> URL: https://issues.apache.org/jira/browse/PHOENIX-3710
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.8.0
>Reporter: Matthew Shipton
>Assignee: Sergey Soldatov
>Priority: Minor
> Attachments: PHOENIX-3710.patch, test.sh, test.sql
>
>
> {code}
> hbase org.apache.phoenix.mapreduce.index.IndexTool --data-table
> \"my_lowcase_table\" --index-table INDEX_TABLE --output-path /tmp/some_path
> {code}
> results in:
> {code}
> java.lang.IllegalArgumentException: INDEX_TABLE is not an index table for
> MY_LOWCASE_TABLE
> {code}
> This is despite the data table being explictly lowercased.
> Appears to be referring to the lowcase table, not the uppercase version.
> Workaround exists by changing the tablename, but this is not always feasible.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (PHOENIX-3710) Cannot use lowername data table name with indextool
[
https://issues.apache.org/jira/browse/PHOENIX-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982460#comment-15982460
]
Ankit Singhal commented on PHOENIX-3710:
Thanks [~sergey.soldatov], changes look good. But at least to avoid regression,
if we can include below two test cases as
IT(IndexExtendedIT.testSecondaryIndex() can be reused for this)
* IndexTool with both tablename and indexname in lowercase
* To check whether the normalisation is correct for phoenix tableName of type
\"S:T\"
> Cannot use lowername data table name with indextool
> ---
>
> Key: PHOENIX-3710
> URL: https://issues.apache.org/jira/browse/PHOENIX-3710
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.8.0
>Reporter: Matthew Shipton
>Assignee: Sergey Soldatov
>Priority: Minor
> Attachments: PHOENIX-3710.patch, test.sh, test.sql
>
>
> {code}
> hbase org.apache.phoenix.mapreduce.index.IndexTool --data-table
> \"my_lowcase_table\" --index-table INDEX_TABLE --output-path /tmp/some_path
> {code}
> results in:
> {code}
> java.lang.IllegalArgumentException: INDEX_TABLE is not an index table for
> MY_LOWCASE_TABLE
> {code}
> This is despite the data table being explictly lowercased.
> Appears to be referring to the lowcase table, not the uppercase version.
> Workaround exists by changing the tablename, but this is not always feasible.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (PHOENIX-3710) Cannot use lowername data table name with indextool
[
https://issues.apache.org/jira/browse/PHOENIX-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982204#comment-15982204
]
James Taylor commented on PHOENIX-3710:
---
Thanks for the patch, [~sergey.soldatov]. Who would be the best person to
review this? Maybe [~an...@apache.org] or [~maghamravikiran]?
> Cannot use lowername data table name with indextool
> ---
>
> Key: PHOENIX-3710
> URL: https://issues.apache.org/jira/browse/PHOENIX-3710
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.8.0
>Reporter: Matthew Shipton
>Assignee: Sergey Soldatov
>Priority: Minor
> Attachments: PHOENIX-3710.patch, test.sh, test.sql
>
>
> {code}
> hbase org.apache.phoenix.mapreduce.index.IndexTool --data-table
> \"my_lowcase_table\" --index-table INDEX_TABLE --output-path /tmp/some_path
> {code}
> results in:
> {code}
> java.lang.IllegalArgumentException: INDEX_TABLE is not an index table for
> MY_LOWCASE_TABLE
> {code}
> This is despite the data table being explictly lowercased.
> Appears to be referring to the lowcase table, not the uppercase version.
> Workaround exists by changing the tablename, but this is not always feasible.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (PHOENIX-3710) Cannot use lowername data table name with indextool
[
https://issues.apache.org/jira/browse/PHOENIX-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981928#comment-15981928
]
Sergey Soldatov commented on PHOENIX-3710:
--
Actually index tool has problems with low case names for indexes, data tables,
schemas. I tried to cover all possible combinations (attached test.sql &
test.sh). Creating a IT would be quite painful for all of those combinations
and not sure whether it worth to do that.
> Cannot use lowername data table name with indextool
> ---
>
> Key: PHOENIX-3710
> URL: https://issues.apache.org/jira/browse/PHOENIX-3710
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.8.0
>Reporter: Matthew Shipton
>Assignee: Sergey Soldatov
>Priority: Minor
> Attachments: PHOENIX-3710.patch, test.sh, test.sql
>
>
> {code}
> hbase org.apache.phoenix.mapreduce.index.IndexTool --data-table
> \"my_lowcase_table\" --index-table INDEX_TABLE --output-path /tmp/some_path
> {code}
> results in:
> {code}
> java.lang.IllegalArgumentException: INDEX_TABLE is not an index table for
> MY_LOWCASE_TABLE
> {code}
> This is despite the data table being explictly lowercased.
> Appears to be referring to the lowcase table, not the uppercase version.
> Workaround exists by changing the tablename, but this is not always feasible.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (PHOENIX-3710) Cannot use lowername data table name with indextool
[
https://issues.apache.org/jira/browse/PHOENIX-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981088#comment-15981088
]
Csaba Skrabak commented on PHOENIX-3710:
Workaround should work:
{noformat}
--data-table \"\"my_lowcase_table\"\"
{noformat}
Backslashes prevent bash from interpreting the quotation marks. The outmost
pair of double quotes will be swallowed by the commons-cli but one pair of
double quotes remain there. Then Phoenix code comes to interpret the thing as a
case sensitive table name.
> Cannot use lowername data table name with indextool
> ---
>
> Key: PHOENIX-3710
> URL: https://issues.apache.org/jira/browse/PHOENIX-3710
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.8.0
>Reporter: Matthew Shipton
>Priority: Minor
>
> {code}
> hbase org.apache.phoenix.mapreduce.index.IndexTool --data-table
> \"my_lowcase_table\" --index-table INDEX_TABLE --output-path /tmp/some_path
> {code}
> results in:
> {code}
> java.lang.IllegalArgumentException: INDEX_TABLE is not an index table for
> MY_LOWCASE_TABLE
> {code}
> This is despite the data table being explictly lowercased.
> Appears to be referring to the lowcase table, not the uppercase version.
> Workaround exists by changing the tablename, but this is not always feasible.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (PHOENIX-3710) Cannot use lowername data table name with indextool
[
https://issues.apache.org/jira/browse/PHOENIX-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979096#comment-15979096
]
Csaba Skrabak commented on PHOENIX-3710:
It's because commons-cli cannot pass over quoted arguments. Phoenix depends on
commons-cli version 1.2, where the issue is present and not even addressed. 1.3
version already addresses the quote issue with a fix for CLI-185 but still not
good enough for this case. Opened bug CLI-275.
> Cannot use lowername data table name with indextool
> ---
>
> Key: PHOENIX-3710
> URL: https://issues.apache.org/jira/browse/PHOENIX-3710
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.8.0
>Reporter: Matthew Shipton
>Priority: Minor
>
> {code}
> hbase org.apache.phoenix.mapreduce.index.IndexTool --data-table
> \"my_lowcase_table\" --index-table INDEX_TABLE --output-path /tmp/some_path
> {code}
> results in:
> {code}
> java.lang.IllegalArgumentException: INDEX_TABLE is not an index table for
> MY_LOWCASE_TABLE
> {code}
> This is despite the data table being explictly lowercased.
> Appears to be referring to the lowcase table, not the uppercase version.
> Workaround exists by changing the tablename, but this is not always feasible.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
