[jira] [Commented] (PHOENIX-4138) Create a hard limit on number of indexes per table
[ https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181896#comment-16181896 ] Hudson commented on PHOENIX-4138: - FAILURE: Integrated in Jenkins build Phoenix-master #1812 (See [https://builds.apache.org/job/Phoenix-master/1812/]) PHOENIX-4138 Create a hard limit on number of indexes per table (Churro (jamestaylor: rev 4969794bf0c91305d01c8f016abe95039642d46e) * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/CreateTableIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java * (add) phoenix-core/src/it/java/org/apache/phoenix/coprocessor/MetaDataEndpointImplTest.java > Create a hard limit on number of indexes per table > -- > > Key: PHOENIX-4138 > URL: https://issues.apache.org/jira/browse/PHOENIX-4138 > Project: Phoenix > Issue Type: Bug >Reporter: Rahul Shrivastava >Assignee: churro morales > Fix For: 4.12.0 > > Attachments: PHOENIX-4138.patch, PHOENIX-4138.v1.patch, > PHOENIX-4138.v2.patch, PHOENIX-4138_v3.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > There should be a config parameter to impose a hard limit on number of > indexes per table. There is a SQL Exception > https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260 > , but it gets triggered on the server side > (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589) > . > We need a client side limit that can be configured via Phoenix config > parameter. Something like if user create more than lets say 30 indexes per > table, it would not allow more index creation for the that specific table. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4138) Create a hard limit on number of indexes per table
[
https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181882#comment-16181882
]
Hadoop QA commented on PHOENIX-4138:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12889178/PHOENIX-4138_v3.patch
against master branch at commit 5d9572736a991f19121477a0822d4b8bf26b4c69.
ATTACHMENT ID: 12889178
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+
assertFalse(MetaDataEndpointImpl.execeededIndexQuota(PTableType.INDEX,
parentTable, configuration));
+assertTrue(MetaDataEndpointImpl.execeededIndexQuota(PTableType.INDEX,
parentTable, configuration));
+conn.createStatement().execute("CREATE LOCAL INDEX I_" + i +
tableName + " ON " + tableName + "(COL1) INCLUDE (COL2,COL3,COL4)");
+conn.createStatement().execute("CREATE LOCAL INDEX I_" +
maxIndexes + tableName + " ON " + tableName + "(COL1) INCLUDE
(COL2,COL3,COL4)");
+static boolean execeededIndexQuota(PTableType tableType, PTable
parentTable, Configuration configuration) {
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpsertValuesIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.PartialIndexRebuilderIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.hbase.index.FailForUnsupportedHBaseVersionsIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1486//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1486//console
This message is automatically generated.
> Create a hard limit on number of indexes per table
> --
>
> Key: PHOENIX-4138
> URL: https://issues.apache.org/jira/browse/PHOENIX-4138
> Project: Phoenix
> Issue Type: Bug
>Reporter: Rahul Shrivastava
>Assignee: churro morales
> Fix For: 4.12.0
>
> Attachments: PHOENIX-4138.patch, PHOENIX-4138.v1.patch,
> PHOENIX-4138.v2.patch, PHOENIX-4138_v3.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There should be a config parameter to impose a hard limit on number of
> indexes per table. There is a SQL Exception
> https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260
> , but it gets triggered on the server side
> (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589)
> .
> We need a client side limit that can be configured via Phoenix config
> parameter. Something like if user create more than lets say 30 indexes per
> table, it would not allow more index creation for the that specific table.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PHOENIX-4138) Create a hard limit on number of indexes per table
[
https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181779#comment-16181779
]
Hadoop QA commented on PHOENIX-4138:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12889159/PHOENIX-4138.v2.patch
against master branch at commit 5d9572736a991f19121477a0822d4b8bf26b4c69.
ATTACHMENT ID: 12889159
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+
assertFalse(MetaDataEndpointImpl.execeededIndexQuota(PTableType.INDEX,
parentTable, configuration));
+assertTrue(MetaDataEndpointImpl.execeededIndexQuota(PTableType.INDEX,
parentTable, configuration));
+conn1.createStatement().execute("CREATE INDEX " + indexTableNameOne +
" ON " + tableName + "(COL1) INCLUDE (COL2,COL3,COL4)");
+// here we ensure we get a too many indexes error since we are only
allowed a max of one index.
+conn1.createStatement().execute("CREATE INDEX " +
indexTableNameTwo + " ON " + tableName + "(COL2) INCLUDE (COL1,COL3,COL4)");
+assertEquals("ERROR 1047 (43A04): Too many indexes have already
been created on the physical table. tableName=T01", e.getMessage());
+static boolean execeededIndexQuota(PTableType tableType, PTable
parentTable, Configuration configuration) {
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.PartialIndexRebuilderIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpsertValuesIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1484//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1484//console
This message is automatically generated.
> Create a hard limit on number of indexes per table
> --
>
> Key: PHOENIX-4138
> URL: https://issues.apache.org/jira/browse/PHOENIX-4138
> Project: Phoenix
> Issue Type: Bug
>Reporter: Rahul Shrivastava
>Assignee: churro morales
> Attachments: PHOENIX-4138.patch, PHOENIX-4138.v1.patch,
> PHOENIX-4138.v2.patch, PHOENIX-4138_v3.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There should be a config parameter to impose a hard limit on number of
> indexes per table. There is a SQL Exception
> https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260
> , but it gets triggered on the server side
> (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589)
> .
> We need a client side limit that can be configured via Phoenix config
> parameter. Something like if user create more than lets say 30 indexes per
> table, it would not allow more index creation for the that specific table.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PHOENIX-4138) Create a hard limit on number of indexes per table
[ https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181062#comment-16181062 ] James Taylor commented on PHOENIX-4138: --- Need this today if it's going to make 4.12, [~churromorales]. > Create a hard limit on number of indexes per table > -- > > Key: PHOENIX-4138 > URL: https://issues.apache.org/jira/browse/PHOENIX-4138 > Project: Phoenix > Issue Type: Bug >Reporter: Rahul Shrivastava >Assignee: churro morales > Attachments: PHOENIX-4138.patch, PHOENIX-4138.v1.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > There should be a config parameter to impose a hard limit on number of > indexes per table. There is a SQL Exception > https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260 > , but it gets triggered on the server side > (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589) > . > We need a client side limit that can be configured via Phoenix config > parameter. Something like if user create more than lets say 30 indexes per > table, it would not allow more index creation for the that specific table. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4138) Create a hard limit on number of indexes per table
[ https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174005#comment-16174005 ] James Taylor commented on PHOENIX-4138: --- Looks like the license header is in an unconventional place in MetaDataEndpointImplTest. Can we move that to the top of the file? bq. I can extract a code block to unit test this, that would be much faster and it wouldn't add yet another integration test to slow down the suite. What do you think about that? There's not a lot of cost to a unit test, especially if you add it to an existing test suite. How about a new test in CreateTableIT that adds 10 indexes? You could make them local indexes so that only a single physical HBase table is created. The reason for the end to end unit test is to verify that you've placed your check in a spot that is triggered when you expect it's triggered. > Create a hard limit on number of indexes per table > -- > > Key: PHOENIX-4138 > URL: https://issues.apache.org/jira/browse/PHOENIX-4138 > Project: Phoenix > Issue Type: Bug >Reporter: Rahul Shrivastava >Assignee: churro morales > Attachments: PHOENIX-4138.patch, PHOENIX-4138.v1.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > There should be a config parameter to impose a hard limit on number of > indexes per table. There is a SQL Exception > https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260 > , but it gets triggered on the server side > (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589) > . > We need a client side limit that can be configured via Phoenix config > parameter. Something like if user create more than lets say 30 indexes per > table, it would not allow more index creation for the that specific table. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4138) Create a hard limit on number of indexes per table
[ https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172184#comment-16172184 ] Andrew Purtell commented on PHOENIX-4138: - lgtm What do you think [~giacomotaylor]? If no objections I can commit > Create a hard limit on number of indexes per table > -- > > Key: PHOENIX-4138 > URL: https://issues.apache.org/jira/browse/PHOENIX-4138 > Project: Phoenix > Issue Type: Bug >Reporter: Rahul Shrivastava >Assignee: churro morales > Attachments: PHOENIX-4138.patch, PHOENIX-4138.v1.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > There should be a config parameter to impose a hard limit on number of > indexes per table. There is a SQL Exception > https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260 > , but it gets triggered on the server side > (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589) > . > We need a client side limit that can be configured via Phoenix config > parameter. Something like if user create more than lets say 30 indexes per > table, it would not allow more index creation for the that specific table. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4138) Create a hard limit on number of indexes per table
[
https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162239#comment-16162239
]
Hadoop QA commented on PHOENIX-4138:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12886496/PHOENIX-4138.v1.patch
against master branch at commit 7e45e9ea1eee5c71cb14ed1eb7d54c05dc91b46a.
ATTACHMENT ID: 12886496
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+
assertFalse(MetaDataEndpointImpl.execeededIndexQuota(PTableType.INDEX,
parentTable, configuration));
+assertTrue(MetaDataEndpointImpl.execeededIndexQuota(PTableType.INDEX,
parentTable, configuration));
+static boolean execeededIndexQuota(PTableType tableType, PTable
parentTable, Configuration configuration) {
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:red}-1 core zombie tests{color}. There are 5 zombie test(s):
at
org.apache.phoenix.end2end.StatsCollectorIT.testRowCountWhenNumKVsExceedCompactionScannerThreshold(StatsCollectorIT.java:672)
at
org.apache.phoenix.end2end.StatsCollectorIT.testUpdateEmptyStats(StatsCollectorIT.java:174)
at
org.apache.phoenix.end2end.UserDefinedFunctionsIT.testUsingUDFFunctionInDifferentQueries(UserDefinedFunctionsIT.java:529)
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1423//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1423//console
This message is automatically generated.
> Create a hard limit on number of indexes per table
> --
>
> Key: PHOENIX-4138
> URL: https://issues.apache.org/jira/browse/PHOENIX-4138
> Project: Phoenix
> Issue Type: Bug
>Reporter: Rahul Shrivastava
>Assignee: churro morales
> Attachments: PHOENIX-4138.patch, PHOENIX-4138.v1.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There should be a config parameter to impose a hard limit on number of
> indexes per table. There is a SQL Exception
> https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260
> , but it gets triggered on the server side
> (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589)
> .
> We need a client side limit that can be configured via Phoenix config
> parameter. Something like if user create more than lets say 30 indexes per
> table, it would not allow more index creation for the that specific table.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PHOENIX-4138) Create a hard limit on number of indexes per table
[
https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159300#comment-16159300
]
Hadoop QA commented on PHOENIX-4138:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12886128/PHOENIX-4138.patch
against master branch at commit 6775dc5c489bd002186e8b5375dd89b666836067.
ATTACHMENT ID: 12886128
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1409//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1409//console
This message is automatically generated.
> Create a hard limit on number of indexes per table
> --
>
> Key: PHOENIX-4138
> URL: https://issues.apache.org/jira/browse/PHOENIX-4138
> Project: Phoenix
> Issue Type: Bug
>Reporter: Rahul Shrivastava
>Assignee: churro morales
> Attachments: PHOENIX-4138.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There should be a config parameter to impose a hard limit on number of
> indexes per table. There is a SQL Exception
> https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260
> , but it gets triggered on the server side
> (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589)
> .
> We need a client side limit that can be configured via Phoenix config
> parameter. Something like if user create more than lets say 30 indexes per
> table, it would not allow more index creation for the that specific table.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PHOENIX-4138) Create a hard limit on number of indexes per table
[ https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159156#comment-16159156 ] churro morales commented on PHOENIX-4138: - I can extract a code block to unit test this, that would be much faster and it wouldn't add yet another integration test to slow down the suite. What do you think about that? > Create a hard limit on number of indexes per table > -- > > Key: PHOENIX-4138 > URL: https://issues.apache.org/jira/browse/PHOENIX-4138 > Project: Phoenix > Issue Type: Bug >Reporter: Rahul Shrivastava >Assignee: churro morales > Attachments: PHOENIX-4138.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > There should be a config parameter to impose a hard limit on number of > indexes per table. There is a SQL Exception > https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260 > , but it gets triggered on the server side > (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589) > . > We need a client side limit that can be configured via Phoenix config > parameter. Something like if user create more than lets say 30 indexes per > table, it would not allow more index creation for the that specific table. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4138) Create a hard limit on number of indexes per table
[ https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159064#comment-16159064 ] James Taylor commented on PHOENIX-4138: --- Patch looks good, but we need a test that hits the limit. Either a new test class derived from ParallelStatsDisabledIT or perhaps just adding a test to a non parameterized test class like IndexMetadataIT. Also, maybe a lower default of 10 is better. Having 20 indexes on a table sounds a bit scary. Should we do some perf testing around this, [~lhofhansl]? > Create a hard limit on number of indexes per table > -- > > Key: PHOENIX-4138 > URL: https://issues.apache.org/jira/browse/PHOENIX-4138 > Project: Phoenix > Issue Type: Bug >Reporter: Rahul Shrivastava >Assignee: churro morales > Attachments: PHOENIX-4138.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > There should be a config parameter to impose a hard limit on number of > indexes per table. There is a SQL Exception > https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260 > , but it gets triggered on the server side > (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589) > . > We need a client side limit that can be configured via Phoenix config > parameter. Something like if user create more than lets say 30 indexes per > table, it would not allow more index creation for the that specific table. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4138) Create a hard limit on number of indexes per table
[ https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157464#comment-16157464 ] churro morales commented on PHOENIX-4138: - Thanks [~jamestaylor] > Create a hard limit on number of indexes per table > -- > > Key: PHOENIX-4138 > URL: https://issues.apache.org/jira/browse/PHOENIX-4138 > Project: Phoenix > Issue Type: Bug >Reporter: Rahul Shrivastava >Assignee: churro morales > Original Estimate: 48h > Remaining Estimate: 48h > > There should be a config parameter to impose a hard limit on number of > indexes per table. There is a SQL Exception > https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260 > , but it gets triggered on the server side > (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589) > . > We need a client side limit that can be configured via Phoenix config > parameter. Something like if user create more than lets say 30 indexes per > table, it would not allow more index creation for the that specific table. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4138) Create a hard limit on number of indexes per table
[ https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157461#comment-16157461 ] James Taylor commented on PHOENIX-4138: --- Please add static constant for config to QueryServices and default value to QueryServicesOptions. Maybe something like phoenix.index.maxIndexesPerTable? > Create a hard limit on number of indexes per table > -- > > Key: PHOENIX-4138 > URL: https://issues.apache.org/jira/browse/PHOENIX-4138 > Project: Phoenix > Issue Type: Bug >Reporter: Rahul Shrivastava >Assignee: churro morales > Original Estimate: 48h > Remaining Estimate: 48h > > There should be a config parameter to impose a hard limit on number of > indexes per table. There is a SQL Exception > https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260 > , but it gets triggered on the server side > (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589) > . > We need a client side limit that can be configured via Phoenix config > parameter. Something like if user create more than lets say 30 indexes per > table, it would not allow more index creation for the that specific table. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4138) Create a hard limit on number of indexes per table
[ https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157446#comment-16157446 ] churro morales commented on PHOENIX-4138: - what do you want to name this configuration parameter? Default of 20 is reasonable if not set? [~jamestaylor] [~rahul.srivast...@sun.com] > Create a hard limit on number of indexes per table > -- > > Key: PHOENIX-4138 > URL: https://issues.apache.org/jira/browse/PHOENIX-4138 > Project: Phoenix > Issue Type: Bug >Reporter: Rahul Shrivastava >Assignee: churro morales > Original Estimate: 48h > Remaining Estimate: 48h > > There should be a config parameter to impose a hard limit on number of > indexes per table. There is a SQL Exception > https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260 > , but it gets triggered on the server side > (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589) > . > We need a client side limit that can be configured via Phoenix config > parameter. Something like if user create more than lets say 30 indexes per > table, it would not allow more index creation for the that specific table. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4138) Create a hard limit on number of indexes per table
[ https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146910#comment-16146910 ] Andrew Purtell commented on PHOENIX-4138: - That's my point exactly - the client can supply their own value. By definition this is not a hard limit. A hard limit is one that cannot be changed by the user. A server side mechanism is required to assure the check is always made and the set value cannot be changed by a client configuration update or code patch. > Create a hard limit on number of indexes per table > -- > > Key: PHOENIX-4138 > URL: https://issues.apache.org/jira/browse/PHOENIX-4138 > Project: Phoenix > Issue Type: Bug >Reporter: Rahul Shrivastava >Assignee: Rahul Shrivastava > Original Estimate: 48h > Remaining Estimate: 48h > > There should be a config parameter to impose a hard limit on number of > indexes per table. There is a SQL Exception > https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260 > , but it gets triggered on the server side > (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589) > . > We need a client side limit that can be configured via Phoenix config > parameter. Something like if user create more than lets say 30 indexes per > table, it would not allow more index creation for the that specific table. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4138) Create a hard limit on number of indexes per table
[ https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145898#comment-16145898 ] Rahul Shrivastava commented on PHOENIX-4138: If we do this on server side, we need an valid SQL exception code for such a scenario . TOO_MANY_INDICES ? > Create a hard limit on number of indexes per table > -- > > Key: PHOENIX-4138 > URL: https://issues.apache.org/jira/browse/PHOENIX-4138 > Project: Phoenix > Issue Type: Bug >Reporter: Rahul Shrivastava >Assignee: Rahul Shrivastava > Original Estimate: 48h > Remaining Estimate: 48h > > There should be a config parameter to impose a hard limit on number of > indexes per table. There is a SQL Exception > https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260 > , but it gets triggered on the server side > (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589) > . > We need a client side limit that can be configured via Phoenix config > parameter. Something like if user create more than lets say 30 indexes per > table, it would not allow more index creation for the that specific table. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4138) Create a hard limit on number of indexes per table
[ https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144900#comment-16144900 ] Andrew Purtell commented on PHOENIX-4138: - Don't we want this enforced server side in the metadata endpoint? Otherwise the limit can be missed if the client doesn't support the feature or the client side configuration is changed. > Create a hard limit on number of indexes per table > -- > > Key: PHOENIX-4138 > URL: https://issues.apache.org/jira/browse/PHOENIX-4138 > Project: Phoenix > Issue Type: Bug >Reporter: Rahul Shrivastava >Assignee: Rahul Shrivastava > Original Estimate: 48h > Remaining Estimate: 48h > > There should be a config parameter to impose a hard limit on number of > indexes per table. There is a SQL Exception > https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260 > , but it gets triggered on the server side > (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589) > . > We need a client side limit that can be configured via Phoenix config > parameter. Something like if user create more than lets say 30 indexes per > table, it would not allow more index creation for the that specific table. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
