[jira] [Commented] (PHOENIX-4361) Remove redundant argument in separateAndValidateProperties in CQSI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410309#comment-16410309
 ] 

ASF GitHub Bot commented on PHOENIX-4361:
-

Github user ChinmaySKulkarni closed the pull request at:

https://github.com/apache/phoenix/pull/282


> Remove redundant argument in separateAndValidateProperties in CQSI
> --
>
> Key: PHOENIX-4361
> URL: https://issues.apache.org/jira/browse/PHOENIX-4361
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Ethan Wang
>Assignee: Chinmay Kulkarni
>Priority: Minor
>
> Remove redundant argument in separateAndValidateProperties in CQSI
> private Pair 
> separateAndValidateProperties(PTable table, Map Object>>> properties, Set colFamiliesForPColumnsToBeAdded, 
> List>> families, Map 
> tableProps) 
> Map>> families was never used.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4361) Remove redundant argument in separateAndValidateProperties in CQSI

[Ethan Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374975#comment-16374975
 ] 

Ethan Wang commented on PHOENIX-4361:
-

 

[~rajeshbabu]

This JIRA also need to be back ported to 5.x-hbase-2.0. Just Done. FYI

> Remove redundant argument in separateAndValidateProperties in CQSI
> --
>
> Key: PHOENIX-4361
> URL: https://issues.apache.org/jira/browse/PHOENIX-4361
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Ethan Wang
>Assignee: Chinmay Kulkarni
>Priority: Minor
>
> Remove redundant argument in separateAndValidateProperties in CQSI
> private Pair 
> separateAndValidateProperties(PTable table, Map Object>>> properties, Set colFamiliesForPColumnsToBeAdded, 
> List>> families, Map 
> tableProps) 
> Map>> families was never used.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4361) Remove redundant argument in separateAndValidateProperties in CQSI

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257662#comment-16257662
 ] 

Hudson commented on PHOENIX-4361:
-

FAILURE: Integrated in Jenkins build Phoenix-master #1876 (See 
[https://builds.apache.org/job/Phoenix-master/1876/])
PHOENIX-4361: Remove redundant argument in separateAndValidateProperties 
(castives: rev ddd3ef28d36f963b295cef74db372f13040ea22a)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java


> Remove redundant argument in separateAndValidateProperties in CQSI
> --
>
> Key: PHOENIX-4361
> URL: https://issues.apache.org/jira/browse/PHOENIX-4361
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Ethan Wang
>Assignee: Chinmay Kulkarni
>Priority: Minor
>
> Remove redundant argument in separateAndValidateProperties in CQSI
> private Pair 
> separateAndValidateProperties(PTable table, Map Object>>> properties, Set colFamiliesForPColumnsToBeAdded, 
> List>> families, Map 
> tableProps) 
> Map>> families was never used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4361) Remove redundant argument in separateAndValidateProperties in CQSI

[Ethan Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257462#comment-16257462
 ] 

Ethan Wang commented on PHOENIX-4361:
-

patch applied to:
master
4.x-0.98
5.x-2.0

Thanks [~ckulkarni]

> Remove redundant argument in separateAndValidateProperties in CQSI
> --
>
> Key: PHOENIX-4361
> URL: https://issues.apache.org/jira/browse/PHOENIX-4361
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Ethan Wang
>Assignee: Chinmay Kulkarni
>Priority: Minor
>
> Remove redundant argument in separateAndValidateProperties in CQSI
> private Pair 
> separateAndValidateProperties(PTable table, Map Object>>> properties, Set colFamiliesForPColumnsToBeAdded, 
> List>> families, Map 
> tableProps) 
> Map>> families was never used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4361) Remove redundant argument in separateAndValidateProperties in CQSI

[Thomas D'Silva (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257405#comment-16257405
 ] 

Thomas D'Silva commented on PHOENIX-4361:
-

+1

> Remove redundant argument in separateAndValidateProperties in CQSI
> --
>
> Key: PHOENIX-4361
> URL: https://issues.apache.org/jira/browse/PHOENIX-4361
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Ethan Wang
>Assignee: Chinmay Kulkarni
>Priority: Minor
>
> Remove redundant argument in separateAndValidateProperties in CQSI
> private Pair 
> separateAndValidateProperties(PTable table, Map Object>>> properties, Set colFamiliesForPColumnsToBeAdded, 
> List>> families, Map 
> tableProps) 
> Map>> families was never used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4361) Remove redundant argument in separateAndValidateProperties in CQSI

[Ethan Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257365#comment-16257365
 ] 

Ethan Wang commented on PHOENIX-4361:
-

+1

> Remove redundant argument in separateAndValidateProperties in CQSI
> --
>
> Key: PHOENIX-4361
> URL: https://issues.apache.org/jira/browse/PHOENIX-4361
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Ethan Wang
>Assignee: Chinmay Kulkarni
>Priority: Minor
>
> Remove redundant argument in separateAndValidateProperties in CQSI
> private Pair 
> separateAndValidateProperties(PTable table, Map Object>>> properties, Set colFamiliesForPColumnsToBeAdded, 
> List>> families, Map 
> tableProps) 
> Map>> families was never used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4361) Remove redundant argument in separateAndValidateProperties in CQSI

[Ethan Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256080#comment-16256080
 ] 

Ethan Wang commented on PHOENIX-4361:
-

Oh I see. I thought it was just format messed up. 

> Remove redundant argument in separateAndValidateProperties in CQSI
> --
>
> Key: PHOENIX-4361
> URL: https://issues.apache.org/jira/browse/PHOENIX-4361
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Ethan Wang
>Assignee: Chinmay Kulkarni
>Priority: Minor
>
> Remove redundant argument in separateAndValidateProperties in CQSI
> private Pair 
> separateAndValidateProperties(PTable table, Map Object>>> properties, Set colFamiliesForPColumnsToBeAdded, 
> List>> families, Map 
> tableProps) 
> Map>> families was never used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4361) Remove redundant argument in separateAndValidateProperties in CQSI

[Chinmay Kulkarni (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256017#comment-16256017
 ] 

Chinmay Kulkarni commented on PHOENIX-4361:
---

[~aertoria] thanks for the review. I moved some of the arguments to the line 
below for easier readability since it's difficult to follow a line of code 
that's 250 characters long in an IDE. I can still undo this if you want.

> Remove redundant argument in separateAndValidateProperties in CQSI
> --
>
> Key: PHOENIX-4361
> URL: https://issues.apache.org/jira/browse/PHOENIX-4361
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Ethan Wang
>Assignee: Chinmay Kulkarni
>Priority: Minor
>
> Remove redundant argument in separateAndValidateProperties in CQSI
> private Pair 
> separateAndValidateProperties(PTable table, Map Object>>> properties, Set colFamiliesForPColumnsToBeAdded, 
> List>> families, Map 
> tableProps) 
> Map>> families was never used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4361) Remove redundant argument in separateAndValidateProperties in CQSI

[Ethan Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255997#comment-16255997
 ] 

Ethan Wang commented on PHOENIX-4361:
-

Also, you many change this jira progress to "in progress"

> Remove redundant argument in separateAndValidateProperties in CQSI
> --
>
> Key: PHOENIX-4361
> URL: https://issues.apache.org/jira/browse/PHOENIX-4361
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Ethan Wang
>Assignee: Chinmay Kulkarni
>Priority: Minor
>
> Remove redundant argument in separateAndValidateProperties in CQSI
> private Pair 
> separateAndValidateProperties(PTable table, Map Object>>> properties, Set colFamiliesForPColumnsToBeAdded, 
> List>> families, Map 
> tableProps) 
> Map>> families was never used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4361) Remove redundant argument in separateAndValidateProperties in CQSI

[Ethan Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255996#comment-16255996
 ] 

Ethan Wang commented on PHOENIX-4361:
-

[~ckulkarni] nit: There are some extra newlines. will be great if you undo them.

> Remove redundant argument in separateAndValidateProperties in CQSI
> --
>
> Key: PHOENIX-4361
> URL: https://issues.apache.org/jira/browse/PHOENIX-4361
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Ethan Wang
>Assignee: Chinmay Kulkarni
>Priority: Minor
>
> Remove redundant argument in separateAndValidateProperties in CQSI
> private Pair 
> separateAndValidateProperties(PTable table, Map Object>>> properties, Set colFamiliesForPColumnsToBeAdded, 
> List>> families, Map 
> tableProps) 
> Map>> families was never used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4361) Remove redundant argument in separateAndValidateProperties in CQSI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255990#comment-16255990
 ] 

ASF GitHub Bot commented on PHOENIX-4361:
-

Github user aertoria commented on a diff in the pull request:

https://github.com/apache/phoenix/pull/282#discussion_r151541162
  
--- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
 ---
@@ -1940,7 +1940,8 @@ private void setTransactional(HTableDescriptor 
tableDescriptor, PTableType table
 this.addCoprocessors(tableDescriptor.getName(), tableDescriptor, 
tableType, tableProps);
 }
 
-private Pair 
separateAndValidateProperties(PTable table, Map>> properties, Set colFamiliesForPColumnsToBeAdded, 
List>> families, Map 
tableProps) throws SQLException {
+private Pair 
separateAndValidateProperties(PTable table, Map>> properties,
--- End diff --

nit: Please undo this change


> Remove redundant argument in separateAndValidateProperties in CQSI
> --
>
> Key: PHOENIX-4361
> URL: https://issues.apache.org/jira/browse/PHOENIX-4361
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Ethan Wang
>Assignee: Chinmay Kulkarni
>Priority: Minor
>
> Remove redundant argument in separateAndValidateProperties in CQSI
> private Pair 
> separateAndValidateProperties(PTable table, Map Object>>> properties, Set colFamiliesForPColumnsToBeAdded, 
> List>> families, Map 
> tableProps) 
> Map>> families was never used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4361) Remove redundant argument in separateAndValidateProperties in CQSI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254667#comment-16254667
 ] 

ASF GitHub Bot commented on PHOENIX-4361:
-

Github user ChinmaySKulkarni commented on the issue:

https://github.com/apache/phoenix/pull/282
  
@aertoria please take a look. Thanks.


> Remove redundant argument in separateAndValidateProperties in CQSI
> --
>
> Key: PHOENIX-4361
> URL: https://issues.apache.org/jira/browse/PHOENIX-4361
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Ethan Wang
>Assignee: Chinmay Kulkarni
>Priority: Minor
>
> Remove redundant argument in separateAndValidateProperties in CQSI
> private Pair 
> separateAndValidateProperties(PTable table, Map Object>>> properties, Set colFamiliesForPColumnsToBeAdded, 
> List>> families, Map 
> tableProps) 
> Map>> families was never used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4361) Remove redundant argument in separateAndValidateProperties in CQSI

[Chinmay Kulkarni (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254660#comment-16254660
 ] 

Chinmay Kulkarni commented on PHOENIX-4361:
---

[~aertoria] please take a look at the small patch: 
https://github.com/apache/phoenix/pull/282
Thanks.

> Remove redundant argument in separateAndValidateProperties in CQSI
> --
>
> Key: PHOENIX-4361
> URL: https://issues.apache.org/jira/browse/PHOENIX-4361
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Ethan Wang
>Assignee: Chinmay Kulkarni
>Priority: Minor
>
> Remove redundant argument in separateAndValidateProperties in CQSI
> private Pair 
> separateAndValidateProperties(PTable table, Map Object>>> properties, Set colFamiliesForPColumnsToBeAdded, 
> List>> families, Map 
> tableProps) 
> Map>> families was never used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4361) Remove redundant argument in separateAndValidateProperties in CQSI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254657#comment-16254657
 ] 

ASF GitHub Bot commented on PHOENIX-4361:
-

GitHub user ChinmaySKulkarni opened a pull request:

https://github.com/apache/phoenix/pull/282

PHOENIX-4361: Remove redundant argument in separateAndValidateProperties in 
CQSI



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChinmaySKulkarni/phoenix PHOENIX-4361

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/phoenix/pull/282.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #282


commit cc61e0846bbf88583fc14da5c37c3ca3a5d86942
Author: Chinmay Kulkarni 
Date:   2017-11-16T02:31:20Z

PHOENIX-4361: Remove redundant argument in separateAndValidateProperties
in CQSI




> Remove redundant argument in separateAndValidateProperties in CQSI
> --
>
> Key: PHOENIX-4361
> URL: https://issues.apache.org/jira/browse/PHOENIX-4361
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Ethan Wang
>Assignee: Ethan Wang
>Priority: Minor
>
> Remove redundant argument in separateAndValidateProperties in CQSI
> private Pair 
> separateAndValidateProperties(PTable table, Map Object>>> properties, Set colFamiliesForPColumnsToBeAdded, 
> List>> families, Map 
> tableProps) 
> Map>> families was never used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4361) Remove redundant argument in separateAndValidateProperties in CQSI

[Ethan Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248082#comment-16248082
 ] 

Ethan Wang commented on PHOENIX-4361:
-

[~ckulkarni]

> Remove redundant argument in separateAndValidateProperties in CQSI
> --
>
> Key: PHOENIX-4361
> URL: https://issues.apache.org/jira/browse/PHOENIX-4361
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Ethan Wang
>Assignee: Ethan Wang
>Priority: Minor
>
> Remove redundant argument in separateAndValidateProperties in CQSI
> private Pair 
> separateAndValidateProperties(PTable table, Map Object>>> properties, Set colFamiliesForPColumnsToBeAdded, 
> List>> families, Map 
> tableProps) 
> Map>> families was never used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4361) Remove redundant argument in separateAndValidateProperties in CQSI

[Ethan Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245115#comment-16245115
 ] 

Ethan Wang commented on PHOENIX-4361:
-

[~tdsilva]

> Remove redundant argument in separateAndValidateProperties in CQSI
> --
>
> Key: PHOENIX-4361
> URL: https://issues.apache.org/jira/browse/PHOENIX-4361
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Ethan Wang
>Priority: Minor
>
> Remove redundant argument in separateAndValidateProperties in CQSI
> private Pair 
> separateAndValidateProperties(PTable table, Map Object>>> properties, Set colFamiliesForPColumnsToBeAdded, 
> List>> families, Map 
> tableProps) 
> Map>> families was never used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)