[jira] [Commented] (PHOENIX-4487) Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13

2018-02-23 Thread Rajeshbabu Chintaguntla (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374771#comment-16374771
 ] 

Rajeshbabu Chintaguntla commented on PHOENIX-4487:
--

Pushed this to 5.x branch.

> Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13
> -
>
> Key: PHOENIX-4487
> URL: https://issues.apache.org/jira/browse/PHOENIX-4487
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.14.0, 4.13.1, 4.13.2-cdh5.11.2
>Reporter: Flavio Pompermaier
>Assignee: James Taylor
>Priority: Major
> Fix For: 4.14.0, 4.13.2-cdh5.11.2, 5.0.0
>
> Attachments: PHOENIX-4487.patch, PHOENIX-4487_5.x-HBase-2.0.patch, 
> PHOENIX-4487_v2.patch
>
>
> Upgrading from the official Cloudera Parcel equipped with Phoenix 4.7  to the 
> last unofficial parcel (4.13 on CDH 5.11.2) I had the same error of 
> https://issues.apache.org/jira/browse/PHOENIX-4293 (apart from the fact that 
> the from version was 4.7...).
> The creation of system.mutex table fixed the problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4487) Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13

2017-12-28 Thread Flavio Pompermaier (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305824#comment-16305824
 ] 

Flavio Pompermaier commented on PHOENIX-4487:
-

Great! Thanks Pedro for taking care of the tests! Just one question: is
there a place where to find Cloudera VM for all versions...?




> Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13
> -
>
> Key: PHOENIX-4487
> URL: https://issues.apache.org/jira/browse/PHOENIX-4487
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.14.0, 4.13.1, 4.13.2-cdh5.11.2
>Reporter: Flavio Pompermaier
>Assignee: James Taylor
> Fix For: 4.14.0, 4.13.2-cdh5.11.2
>
> Attachments: PHOENIX-4487.patch, PHOENIX-4487_v2.patch
>
>
> Upgrading from the official Cloudera Parcel equipped with Phoenix 4.7  to the 
> last unofficial parcel (4.13 on CDH 5.11.2) I had the same error of 
> https://issues.apache.org/jira/browse/PHOENIX-4293 (apart from the fact that 
> the from version was 4.7...).
> The creation of system.mutex table fixed the problem.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4487) Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13

2017-12-28 Thread Pedro Boado (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305780#comment-16305780
 ] 

Pedro Boado commented on PHOENIX-4487:
--

I've done my testing and the fix is working fine. I had replicated the issue 
before by following this same steps: 

- Spin up a Cloudera CDH Quickstart VM for CDH 5.7
- Installed Cloudera Labs Apache Phoenix 4.7 from 
http://archive.cloudera.com/cloudera-labs/phoenix/parcels/1.3/ 
- Created a couple of tables in Phoenix and checking that querying etc worked 
fine.
- Stopped all services
- Upgraded Cloudera Manager to the latest version ( 5.13 ) . 
- Uninstalled parcels for CDH 5.7
- Uninstalled parcels for Phoenix 4.7
- Upgraded to CDH 5.11.2 
- Installed parcels from 5.13-cdh5.11.2 branch ( published in 
http://phoenix.trenddevs.co.uk/parcels/4.13.2-cdh5.11.2/ ) 
- Started HBase, opened sqlline and checked that the tables and its information 
are still queryable. 

If the issue was still there phoenix wouldn't start after the parcel upgrade - 
errors would be displayed in RS log - .

Thanks guys. 


> Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13
> -
>
> Key: PHOENIX-4487
> URL: https://issues.apache.org/jira/browse/PHOENIX-4487
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.14.0, 4.13.1, 4.13.2-cdh5.11.2
>Reporter: Flavio Pompermaier
>Assignee: James Taylor
> Fix For: 4.14.0, 4.13.2-cdh5.11.2
>
> Attachments: PHOENIX-4487.patch, PHOENIX-4487_v2.patch
>
>
> Upgrading from the official Cloudera Parcel equipped with Phoenix 4.7  to the 
> last unofficial parcel (4.13 on CDH 5.11.2) I had the same error of 
> https://issues.apache.org/jira/browse/PHOENIX-4293 (apart from the fact that 
> the from version was 4.7...).
> The creation of system.mutex table fixed the problem.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4487) Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13

2017-12-28 Thread Pedro Boado (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305341#comment-16305341
 ] 

Pedro Boado commented on PHOENIX-4487:
--

I'll test it - it will take me a day or so to spin up a VM and do both 
installs, I've limited internet connectivity during Christmas and borrow 
someone else's laptop - 

> Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13
> -
>
> Key: PHOENIX-4487
> URL: https://issues.apache.org/jira/browse/PHOENIX-4487
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.14.0, 4.13.1, 4.13.2-cdh5.11.2
>Reporter: Flavio Pompermaier
>Assignee: James Taylor
> Fix For: 4.14.0, 4.13.2-cdh5.11.2
>
> Attachments: PHOENIX-4487.patch, PHOENIX-4487_v2.patch
>
>
> Upgrading from the official Cloudera Parcel equipped with Phoenix 4.7  to the 
> last unofficial parcel (4.13 on CDH 5.11.2) I had the same error of 
> https://issues.apache.org/jira/browse/PHOENIX-4293 (apart from the fact that 
> the from version was 4.7...).
> The creation of system.mutex table fixed the problem.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4487) Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13

2017-12-27 Thread Flavio Pompermaier (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304377#comment-16304377
 ] 

Flavio Pompermaier commented on PHOENIX-4487:
-

The problem is that I'm on vacation for 2 weeks..

On 26 Dec 2017 22:46, "Karan Mehta (JIRA)"  wrote:


[ https://issues.apache.org/jira/browse/PHOENIX-4487?page=
com.atlassian.jira.plugin.system.issuetabpanels:comment-
tabpanel=16304033#comment-16304033 ]

Karan Mehta commented on PHOENIX-4487:
--

Understood your comment, Thanks [~jamestaylor], +1 for the patch. Can
[~pboado] or [~f.pompermaier] confirm that it works after applying the
patch locally?

the last unofficial parcel (4.13 on CDH 5.11.2) I had the same error of
https://issues.apache.org/jira/browse/PHOENIX-4293 (apart from the fact
that the from version was 4.7...).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


> Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13
> -
>
> Key: PHOENIX-4487
> URL: https://issues.apache.org/jira/browse/PHOENIX-4487
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.14.0, 4.13.1, 4.13.2-cdh5.11.2
>Reporter: Flavio Pompermaier
>Assignee: James Taylor
> Attachments: PHOENIX-4487.patch, PHOENIX-4487_v2.patch
>
>
> Upgrading from the official Cloudera Parcel equipped with Phoenix 4.7  to the 
> last unofficial parcel (4.13 on CDH 5.11.2) I had the same error of 
> https://issues.apache.org/jira/browse/PHOENIX-4293 (apart from the fact that 
> the from version was 4.7...).
> The creation of system.mutex table fixed the problem.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4487) Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13

2017-12-26 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304095#comment-16304095
 ] 

Hadoop QA commented on PHOENIX-4487:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12903737/PHOENIX-4487_v2.patch
  against master branch at commit 34693843abe4490b54fbd30512bf7d98d0f59c0d.
  ATTACHMENT ID: 12903737

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

{color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
+if (currentServerSideTableTimeStamp <= 
MetaDataProtocol.MIN_SYSTEM_TABLE_TIMESTAMP_4_10_0 &&
+if (acquiredMutexLock = 
acquireUpgradeMutex(currentServerSideTableTimeStamp, mutexRowKey)) {
+TableName mutexName = 
SchemaUtil.getPhysicalTableName(PhoenixDatabaseMetaData.SYSTEM_MUTEX_NAME, 
props);
+if 
(PhoenixDatabaseMetaData.SYSTEM_MUTEX_HBASE_TABLE_NAME.equals(mutexName) || 
!tableNames.contains(mutexName)) {

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1693//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1693//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1693//console

This message is automatically generated.

> Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13
> -
>
> Key: PHOENIX-4487
> URL: https://issues.apache.org/jira/browse/PHOENIX-4487
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.14.0, 4.13.1, 4.13.2-cdh5.11.2
>Reporter: Flavio Pompermaier
>Assignee: James Taylor
> Attachments: PHOENIX-4487.patch, PHOENIX-4487_v2.patch
>
>
> Upgrading from the official Cloudera Parcel equipped with Phoenix 4.7  to the 
> last unofficial parcel (4.13 on CDH 5.11.2) I had the same error of 
> https://issues.apache.org/jira/browse/PHOENIX-4293 (apart from the fact that 
> the from version was 4.7...).
> The creation of system.mutex table fixed the problem.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4487) Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13

2017-12-26 Thread Karan Mehta (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304033#comment-16304033
 ] 

Karan Mehta commented on PHOENIX-4487:
--

Understood your comment, Thanks [~jamestaylor], +1 for the patch. Can [~pboado] 
or [~f.pompermaier] confirm that it works after applying the patch locally?

> Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13
> -
>
> Key: PHOENIX-4487
> URL: https://issues.apache.org/jira/browse/PHOENIX-4487
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.14.0, 4.13.1, 4.13.2-cdh5.11.2
>Reporter: Flavio Pompermaier
>Assignee: James Taylor
> Attachments: PHOENIX-4487.patch, PHOENIX-4487_v2.patch
>
>
> Upgrading from the official Cloudera Parcel equipped with Phoenix 4.7  to the 
> last unofficial parcel (4.13 on CDH 5.11.2) I had the same error of 
> https://issues.apache.org/jira/browse/PHOENIX-4293 (apart from the fact that 
> the from version was 4.7...).
> The creation of system.mutex table fixed the problem.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4487) Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13

2017-12-26 Thread Pedro Boado (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303904#comment-16303904
 ] 

Pedro Boado commented on PHOENIX-4487:
--

What's the plan with this patch? Is it ready to be merged to CDH branch?

> Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13
> -
>
> Key: PHOENIX-4487
> URL: https://issues.apache.org/jira/browse/PHOENIX-4487
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.14.0, 4.13.1, 4.13.2-cdh5.11.2
>Reporter: Flavio Pompermaier
>Assignee: James Taylor
> Attachments: PHOENIX-4487.patch
>
>
> Upgrading from the official Cloudera Parcel equipped with Phoenix 4.7  to the 
> last unofficial parcel (4.13 on CDH 5.11.2) I had the same error of 
> https://issues.apache.org/jira/browse/PHOENIX-4293 (apart from the fact that 
> the from version was 4.7...).
> The creation of system.mutex table fixed the problem.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4487) Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13

2017-12-23 Thread Karan Mehta (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302529#comment-16302529
 ] 

Karan Mehta commented on PHOENIX-4487:
--

bq. Please don't remove upgrade code without raising a discussion thread on the 
dev list. Vendor distros often need upgrade code to remain longer than two 
minor releases back due to the infrequency of their upgrade. For example, CDH 
will go from 4.7 to 4.11. The HDP distro may be even further behind.

Thank you for the information. I was not aware of this fully. I will take care 
for all the future JIRA's that I take up.

bq. How is it better to go from an unlikely, possible race condition to always 
throwing an exception and blocking the upgrade when the mutex table doesn't 
exist? Please file a separate issue for handling the race condition properly. 
This patch improves things at least.

Sure, will do that.

bq. That check is because if namespaces are enabled, the earlier branch in the 
upgrade code path is executed and ensures that the mutex table is created. I'll 
add a comment.

We can modify the code in {{createSysMutexTable()}} method as follows
{code}
-if (systemTables.contains(mutexTableName) || admin.tableExists( 
TableName.valueOf(

PhoenixDatabaseMetaData.SYSTEM_SCHEMA_NAME,PhoenixDatabaseMetaData.SYSTEM_MUTEX_TABLE_NAME)))
 {
+if 
(systemTables.contains(PhoenixDatabaseMetaData.SYSTEM_MUTEX_HBASE_TABLE_NAME) 
|| admin.tableExists( TableName.valueOf(

PhoenixDatabaseMetaData.SYSTEM_SCHEMA_NAME,PhoenixDatabaseMetaData.SYSTEM_MUTEX_TABLE_NAME)))
 {
{code}

This will ensure that the function checks for SYSTEM.MUTEX and SYSTEM:MUTEX and 
if either of them exist, then it will not proceed to create the table As of 
now, if namespace mapping is enabled, it checks for SYSTEM:MUTEX in both the 
conditions.
With this change, I believe, you can simply call this method on the migrate 
tables path and you can call this method with the Phoenix version condition 
check of 4.10 in the upgrade path. 

> Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13
> -
>
> Key: PHOENIX-4487
> URL: https://issues.apache.org/jira/browse/PHOENIX-4487
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.14.0, 4.13.1, 4.13.2-cdh5.11.2
>Reporter: Flavio Pompermaier
>Assignee: James Taylor
> Attachments: PHOENIX-4487.patch
>
>
> Upgrading from the official Cloudera Parcel equipped with Phoenix 4.7  to the 
> last unofficial parcel (4.13 on CDH 5.11.2) I had the same error of 
> https://issues.apache.org/jira/browse/PHOENIX-4293 (apart from the fact that 
> the from version was 4.7...).
> The creation of system.mutex table fixed the problem.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4487) Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13

2017-12-22 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302168#comment-16302168
 ] 

James Taylor commented on PHOENIX-4487:
---

bq. However as discussed offline with [~twdsi...@gmail.com], we decided that 
since we _officially_ support only 2 client backward versions, this should be 
fine.
Please don't remove upgrade code without raising a discussion thread on the dev 
list. Vendor distros often need upgrade code to remain longer than two minor 
releases back due to the infrequency of their upgrade. For example, CDH will go 
from 4.7 to 4.11. The HDP distro may be even further behind.
bq. The first line checks if SYSTEM.MUTEX table exists or not. This can be in 2 
cases, either the table doesn't exist at all ot its being migrated to SYSTEM 
namespace. There is no clear way of differentiating them and hence there arises 
a plausible race condition here.
How is it better to go from an unlikely, possible race condition to always 
throwing an exception and blocking the upgrade when the mutex table doesn't 
exist? Please file a separate issue for handling the race condition properly. 
This patch improves things at least.
bq. I don't see the need for checking if namespace mapping is enabled or not. 
That check is because if namespaces are enabled, the earlier branch in the 
upgrade code path is executed and ensures that the mutex table is created. I'll 
add a comment.
bq. Also, how do we test this? Any UT or directly tried with a cluster?
Upgrade code needs to be manually checked. I'm hoping [~f.pompermaier] can help 
test this once this patch is committed.


> Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13
> -
>
> Key: PHOENIX-4487
> URL: https://issues.apache.org/jira/browse/PHOENIX-4487
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.14.0, 4.13.1, 4.13.2-cdh5.11.2
>Reporter: Flavio Pompermaier
>Assignee: James Taylor
> Attachments: PHOENIX-4487.patch
>
>
> Upgrading from the official Cloudera Parcel equipped with Phoenix 4.7  to the 
> last unofficial parcel (4.13 on CDH 5.11.2) I had the same error of 
> https://issues.apache.org/jira/browse/PHOENIX-4293 (apart from the fact that 
> the from version was 4.7...).
> The creation of system.mutex table fixed the problem.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4487) Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13

2017-12-22 Thread Karan Mehta (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302148#comment-16302148
 ] 

Karan Mehta commented on PHOENIX-4487:
--

I ran into this issue when one of the older clients connected to a fresh 
cluster and then a newer client tried connecting to the same cluster. However 
as discussed offline with [~twdsi...@gmail.com], we decided that since we 
_officially_ support only 2 client backward versions, this should be fine. 
However, it is always good to fix things and make them as much stable as 
possible. There is also a plausible race condition addressed below, which was 
also one of the reasons we decided not to create SYSMUTEX table and instead 
throw the exception.

{code}
Lines: 3205 - 3211
if 
(!tableNames.contains(PhoenixDatabaseMetaData.SYSTEM_MUTEX_HBASE_TABLE_NAME)) {
TableName mutexName = 
SchemaUtil.getPhysicalTableName(PhoenixDatabaseMetaData.SYSTEM_MUTEX_NAME, 
props);
if 
(PhoenixDatabaseMetaData.SYSTEM_MUTEX_HBASE_TABLE_NAME.equals(mutexName) || 
!tableNames.contains(mutexName)) {
createSysMutexTable(admin, props);
}
}
{code}

The first line checks if SYSTEM.MUTEX table exists or not. This can be in 2 
cases, either the table doesn't exist at all ot its being migrated to SYSTEM 
namespace. There is no clear way of differentiating them and hence there arises 
a plausible race condition here. If it's at all required, we can directly call 
{{createSysMutexTable}} method, since it will check for the table according to 
client properties and create one if none of them exists.

{code}
if (currentServerSideTableTimeStamp <= 
MetaDataProtocol.MIN_SYSTEM_TABLE_TIMESTAMP_4_10_0 &&

!SchemaUtil.isNamespaceMappingEnabled(PTableType.SYSTEM,

ConnectionQueryServicesImpl.this.getProps())) {
{code}

I don't see the need for checking if namespace mapping is enabled or not. 
SYSMUTEX table needs to be created for any client who is jumping from 4.7 to 
4.13 (since it was introduced in 4.10 version). Namespaces can be either 
enabled or disabled. SYSMUTEX will be used once again when client wants to 
migrate the SYSTEM tables to SYSTEM namespace.

Please update the comments on this change to address the concern mentioned. 
[~jamestaylor] Also, how do we test this? Any UT or directly tried with a 
cluster? 

> Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13
> -
>
> Key: PHOENIX-4487
> URL: https://issues.apache.org/jira/browse/PHOENIX-4487
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.14.0, 4.13.1, 4.13.2-cdh5.11.2
>Reporter: Flavio Pompermaier
>Assignee: James Taylor
> Attachments: PHOENIX-4487.patch
>
>
> Upgrading from the official Cloudera Parcel equipped with Phoenix 4.7  to the 
> last unofficial parcel (4.13 on CDH 5.11.2) I had the same error of 
> https://issues.apache.org/jira/browse/PHOENIX-4293 (apart from the fact that 
> the from version was 4.7...).
> The creation of system.mutex table fixed the problem.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4487) Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13

2017-12-22 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301957#comment-16301957
 ] 

Hadoop QA commented on PHOENIX-4487:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12903451/PHOENIX-4487.patch
  against master branch at commit 34693843abe4490b54fbd30512bf7d98d0f59c0d.
  ATTACHMENT ID: 12903451

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

{color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
+if (currentServerSideTableTimeStamp <= 
MetaDataProtocol.MIN_SYSTEM_TABLE_TIMESTAMP_4_10_0 &&
+if (acquiredMutexLock = 
acquireUpgradeMutex(currentServerSideTableTimeStamp, mutexRowKey)) {
+TableName mutexName = 
SchemaUtil.getPhysicalTableName(PhoenixDatabaseMetaData.SYSTEM_MUTEX_NAME, 
props);
+if 
(PhoenixDatabaseMetaData.SYSTEM_MUTEX_HBASE_TABLE_NAME.equals(mutexName) || 
!tableNames.contains(mutexName)) {

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1687//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1687//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1687//console

This message is automatically generated.

> Missing SYSTEM.MUTEX table upgrading from 4.7 to 4.13
> -
>
> Key: PHOENIX-4487
> URL: https://issues.apache.org/jira/browse/PHOENIX-4487
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.14.0, 4.13.1, 4.13.2-cdh5.11.2
>Reporter: Flavio Pompermaier
>Assignee: James Taylor
> Attachments: PHOENIX-4487.patch
>
>
> Upgrading from the official Cloudera Parcel equipped with Phoenix 4.7  to the 
> last unofficial parcel (4.13 on CDH 5.11.2) I had the same error of 
> https://issues.apache.org/jira/browse/PHOENIX-4293 (apart from the fact that 
> the from version was 4.7...).
> The creation of system.mutex table fixed the problem.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)