[jira] [Commented] (PHOENIX-4607) Allow PhoenixInputFormat to use tenant-specific connections
[ https://issues.apache.org/jira/browse/PHOENIX-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384332#comment-16384332 ] Hudson commented on PHOENIX-4607: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #51 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-1.3/51/]) PHOENIX-4607 - Allow PhoenixInputFormat to use tenant-specific (gjacoby: rev bd34ae79fe4fe174968c64b87f0f45a21fb161fb) * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixInputFormat.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixMapReduceUtil.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/MapReduceIT.java > Allow PhoenixInputFormat to use tenant-specific connections > --- > > Key: PHOENIX-4607 > URL: https://issues.apache.org/jira/browse/PHOENIX-4607 > Project: Phoenix > Issue Type: New Feature >Affects Versions: 4.13.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Labels: mapreduce > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4607-v2.patch, PHOENIX-4607.patch > > > When using Phoenix's MapReduce integration, the actual connections for the > SELECT query are created by PhoenixInputFormat. While PhoenixInputFormat has > support for a few connection properties such as SCN, a TenantId is not one of > them. > Add the ability to specify a TenantId for the PhoenixInputFormat's > connections to use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4607) Allow PhoenixInputFormat to use tenant-specific connections
[ https://issues.apache.org/jira/browse/PHOENIX-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384288#comment-16384288 ] Hudson commented on PHOENIX-4607: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-0.98 #1825 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-0.98/1825/]) PHOENIX-4607 - Allow PhoenixInputFormat to use tenant-specific (gjacoby: rev 62a61169057d80ede5cc6807078e4c95a45ffc0c) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/MapReduceIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixInputFormat.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixMapReduceUtil.java > Allow PhoenixInputFormat to use tenant-specific connections > --- > > Key: PHOENIX-4607 > URL: https://issues.apache.org/jira/browse/PHOENIX-4607 > Project: Phoenix > Issue Type: New Feature >Affects Versions: 4.13.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Labels: mapreduce > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4607-v2.patch, PHOENIX-4607.patch > > > When using Phoenix's MapReduce integration, the actual connections for the > SELECT query are created by PhoenixInputFormat. While PhoenixInputFormat has > support for a few connection properties such as SCN, a TenantId is not one of > them. > Add the ability to specify a TenantId for the PhoenixInputFormat's > connections to use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4607) Allow PhoenixInputFormat to use tenant-specific connections
[ https://issues.apache.org/jira/browse/PHOENIX-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384250#comment-16384250 ] Hudson commented on PHOENIX-4607: - ABORTED: Integrated in Jenkins build PreCommit-PHOENIX-Build #1781 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/1781/]) PHOENIX-4607 - Allow PhoenixInputFormat to use tenant-specific (gjacoby: rev a35591c876ddb338cdb8269e67aed92ed6e5d485) * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixMapReduceUtil.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/MapReduceIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixInputFormat.java > Allow PhoenixInputFormat to use tenant-specific connections > --- > > Key: PHOENIX-4607 > URL: https://issues.apache.org/jira/browse/PHOENIX-4607 > Project: Phoenix > Issue Type: New Feature >Affects Versions: 4.13.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Labels: mapreduce > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4607-v2.patch, PHOENIX-4607.patch > > > When using Phoenix's MapReduce integration, the actual connections for the > SELECT query are created by PhoenixInputFormat. While PhoenixInputFormat has > support for a few connection properties such as SCN, a TenantId is not one of > them. > Add the ability to specify a TenantId for the PhoenixInputFormat's > connections to use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4607) Allow PhoenixInputFormat to use tenant-specific connections
[ https://issues.apache.org/jira/browse/PHOENIX-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383902#comment-16383902 ] Thomas D'Silva commented on PHOENIX-4607: - +1 LGTM > Allow PhoenixInputFormat to use tenant-specific connections > --- > > Key: PHOENIX-4607 > URL: https://issues.apache.org/jira/browse/PHOENIX-4607 > Project: Phoenix > Issue Type: New Feature >Affects Versions: 4.13.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Labels: mapreduce > Attachments: PHOENIX-4607-v2.patch, PHOENIX-4607.patch > > > When using Phoenix's MapReduce integration, the actual connections for the > SELECT query are created by PhoenixInputFormat. While PhoenixInputFormat has > support for a few connection properties such as SCN, a TenantId is not one of > them. > Add the ability to specify a TenantId for the PhoenixInputFormat's > connections to use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4607) Allow PhoenixInputFormat to use tenant-specific connections
[ https://issues.apache.org/jira/browse/PHOENIX-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382694#comment-16382694 ] Geoffrey Jacoby commented on PHOENIX-4607: -- I noticed that there was a pre-existing connection leak in PhoenixInputFormat (the non-Hive version, so different from PHOENIX-4635), so I fixed it and made a v2. > Allow PhoenixInputFormat to use tenant-specific connections > --- > > Key: PHOENIX-4607 > URL: https://issues.apache.org/jira/browse/PHOENIX-4607 > Project: Phoenix > Issue Type: New Feature >Affects Versions: 4.13.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Labels: mapreduce > Attachments: PHOENIX-4607-v2.patch, PHOENIX-4607.patch > > > When using Phoenix's MapReduce integration, the actual connections for the > SELECT query are created by PhoenixInputFormat. While PhoenixInputFormat has > support for a few connection properties such as SCN, a TenantId is not one of > them. > Add the ability to specify a TenantId for the PhoenixInputFormat's > connections to use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4607) Allow PhoenixInputFormat to use tenant-specific connections
[ https://issues.apache.org/jira/browse/PHOENIX-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377484#comment-16377484 ] Geoffrey Jacoby commented on PHOENIX-4607: -- [~jamestaylor] [~mujtabachohan] [~tdsilva], if one of you has bandwidth could I please get a review? Thanks! > Allow PhoenixInputFormat to use tenant-specific connections > --- > > Key: PHOENIX-4607 > URL: https://issues.apache.org/jira/browse/PHOENIX-4607 > Project: Phoenix > Issue Type: New Feature >Affects Versions: 4.13.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Labels: mapreduce > Attachments: PHOENIX-4607.patch > > > When using Phoenix's MapReduce integration, the actual connections for the > SELECT query are created by PhoenixInputFormat. While PhoenixInputFormat has > support for a few connection properties such as SCN, a TenantId is not one of > them. > Add the ability to specify a TenantId for the PhoenixInputFormat's > connections to use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4607) Allow PhoenixInputFormat to use tenant-specific connections
[ https://issues.apache.org/jira/browse/PHOENIX-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373751#comment-16373751 ] Geoffrey Jacoby commented on PHOENIX-4607: -- The test failures go away when run against HBase 1.3. There was a failure from ParallelIteratorsIT, but it was a minicluster failure and went away when I ran it standalone. > Allow PhoenixInputFormat to use tenant-specific connections > --- > > Key: PHOENIX-4607 > URL: https://issues.apache.org/jira/browse/PHOENIX-4607 > Project: Phoenix > Issue Type: New Feature >Affects Versions: 4.13.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Labels: mapreduce > Attachments: PHOENIX-4607.patch > > > When using Phoenix's MapReduce integration, the actual connections for the > SELECT query are created by PhoenixInputFormat. While PhoenixInputFormat has > support for a few connection properties such as SCN, a TenantId is not one of > them. > Add the ability to specify a TenantId for the PhoenixInputFormat's > connections to use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4607) Allow PhoenixInputFormat to use tenant-specific connections
[ https://issues.apache.org/jira/browse/PHOENIX-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373636#comment-16373636 ] James Taylor commented on PHOENIX-4607: --- Phoenix on master uses HBase 1.4 which has known test failures that need to be triaged and fixed (see PHOENIX-4539). I'd recommend trying on 4.x-HBase-1.3 branch. > Allow PhoenixInputFormat to use tenant-specific connections > --- > > Key: PHOENIX-4607 > URL: https://issues.apache.org/jira/browse/PHOENIX-4607 > Project: Phoenix > Issue Type: New Feature >Affects Versions: 4.13.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Labels: mapreduce > Attachments: PHOENIX-4607.patch > > > When using Phoenix's MapReduce integration, the actual connections for the > SELECT query are created by PhoenixInputFormat. While PhoenixInputFormat has > support for a few connection properties such as SCN, a TenantId is not one of > them. > Add the ability to specify a TenantId for the PhoenixInputFormat's > connections to use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4607) Allow PhoenixInputFormat to use tenant-specific connections
[ https://issues.apache.org/jira/browse/PHOENIX-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373630#comment-16373630 ] Geoffrey Jacoby commented on PHOENIX-4607: -- HadoopQA doesn't seem to be posting to the JIRA, but the test run did occur. There were 10 test failures, listed here: [https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-PHOENIX-Build/1766/#showFailuresLink] When I run mvn clean verify locally, I can reproduce all the test failures, so they're not flappers – but the same test failures occur if I run mvn clean verify from an unchanged pull of the master branch. So, while we all seem due for another round of test cleanup, this patch should be fine. [~jamestaylor], wdyt? > Allow PhoenixInputFormat to use tenant-specific connections > --- > > Key: PHOENIX-4607 > URL: https://issues.apache.org/jira/browse/PHOENIX-4607 > Project: Phoenix > Issue Type: New Feature >Affects Versions: 4.13.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Labels: mapreduce > Attachments: PHOENIX-4607.patch > > > When using Phoenix's MapReduce integration, the actual connections for the > SELECT query are created by PhoenixInputFormat. While PhoenixInputFormat has > support for a few connection properties such as SCN, a TenantId is not one of > them. > Add the ability to specify a TenantId for the PhoenixInputFormat's > connections to use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4607) Allow PhoenixInputFormat to use tenant-specific connections
[ https://issues.apache.org/jira/browse/PHOENIX-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364972#comment-16364972 ] James Taylor commented on PHOENIX-4607: --- Yes, I'd expect this to work. > Allow PhoenixInputFormat to use tenant-specific connections > --- > > Key: PHOENIX-4607 > URL: https://issues.apache.org/jira/browse/PHOENIX-4607 > Project: Phoenix > Issue Type: New Feature >Affects Versions: 4.13.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > > When using Phoenix's MapReduce integration, the actual connections for the > SELECT query are created by PhoenixInputFormat. While PhoenixInputFormat has > support for a few connection properties such as SCN, a TenantId is not one of > them. > Add the ability to specify a TenantId for the PhoenixInputFormat's > connections to use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4607) Allow PhoenixInputFormat to use tenant-specific connections
[ https://issues.apache.org/jira/browse/PHOENIX-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364961#comment-16364961 ] Geoffrey Jacoby commented on PHOENIX-4607: -- [~jamestaylor], if MapReduce selects can use tenant-specific connections, will we automatically get the ability to use a tenant-view in the FROM clause of a MapReduce SELECT? > Allow PhoenixInputFormat to use tenant-specific connections > --- > > Key: PHOENIX-4607 > URL: https://issues.apache.org/jira/browse/PHOENIX-4607 > Project: Phoenix > Issue Type: New Feature >Affects Versions: 4.13.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > > When using Phoenix's MapReduce integration, the actual connections for the > SELECT query are created by PhoenixInputFormat. While PhoenixInputFormat has > support for a few connection properties such as SCN, a TenantId is not one of > them. > Add the ability to specify a TenantId for the PhoenixInputFormat's > connections to use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)