[jira] [Commented] (PHOENIX-4742) Prevent infinite loop with HBase 1.4 and DistinctPrefixFilter
[ https://issues.apache.org/jira/browse/PHOENIX-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479832#comment-16479832 ] James Taylor commented on PHOENIX-4742: --- FYI, I'm looking at this now, [~sergey.soldatov]. It's a bug in the way descending row keys are handled by DistinctPrefixFilter. We're generating a seek next hint that's smaller than the current key. In HBase 1.4 this causes an infinite loop. In other versions of HBase, this seems to just cause the filter to go to the next row. I'll try to tweak the logic correctly for descending keys. > Prevent infinite loop with HBase 1.4 and DistinctPrefixFilter > - > > Key: PHOENIX-4742 > URL: https://issues.apache.org/jira/browse/PHOENIX-4742 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor >Assignee: Sergey Soldatov >Priority: Major > > OrderByIT.testOrderByReverseOptimizationWithNUllsLastBug3491 is the only test > failing on master (i.e. HBase 1.4). It's getting into an infinite loop when a > reverse scan is done for the DistinctPrefixFilter. It'd be nice to fix this > so we can do a release for HBase 1.4. At a minimum, we could disable > DistinctPrefixFilter when a reverse scan is being done (for HBase 1.4 only). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4742) Prevent infinite loop with HBase 1.4 and DistinctPrefixFilter
[ https://issues.apache.org/jira/browse/PHOENIX-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479828#comment-16479828 ] Sergey Soldatov commented on PHOENIX-4742: -- That happens because of the changes in flters in HBase 1.4 and 2.0. Somehow the matcher instead of SEEK_NEXT_ROW keeps returning SEEK_NEXT_USING_HINT, so we are getting stuck at the last cell. let me dig a bit. > Prevent infinite loop with HBase 1.4 and DistinctPrefixFilter > - > > Key: PHOENIX-4742 > URL: https://issues.apache.org/jira/browse/PHOENIX-4742 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor >Assignee: Sergey Soldatov >Priority: Major > > OrderByIT.testOrderByReverseOptimizationWithNUllsLastBug3491 is the only test > failing on master (i.e. HBase 1.4). It's getting into an infinite loop when a > reverse scan is done for the DistinctPrefixFilter. It'd be nice to fix this > so we can do a release for HBase 1.4. At a minimum, we could disable > DistinctPrefixFilter when a reverse scan is being done (for HBase 1.4 only). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4742) Prevent infinite loop with HBase 1.4 and DistinctPrefixFilter
[ https://issues.apache.org/jira/browse/PHOENIX-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479474#comment-16479474 ] James Taylor commented on PHOENIX-4742: --- [~sergey.soldatov] - any insight into this? I seem to remember you made a change to our filters to accommodate HBase 1.4. Was this change perhaps not done for DistinctPrefixFilter? > Prevent infinite loop with HBase 1.4 and DistinctPrefixFilter > - > > Key: PHOENIX-4742 > URL: https://issues.apache.org/jira/browse/PHOENIX-4742 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor >Priority: Major > > OrderByIT.testOrderByReverseOptimizationWithNUllsLastBug3491 is the only test > failing on master (i.e. HBase 1.4). It's getting into an infinite loop when a > reverse scan is done for the DistinctPrefixFilter. It'd be nice to fix this > so we can do a release for HBase 1.4. At a minimum, we could disable > DistinctPrefixFilter when a reverse scan is being done (for HBase 1.4 only). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
