[ 
https://issues.apache.org/jira/browse/PHOENIX-7131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajeshbabu Chintaguntla resolved PHOENIX-7131.
----------------------------------------------
    Resolution: Won't Fix

As mentioned here 
https://issues.apache.org/jira/browse/OMID-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791445#comment-17791445

Without server side filtering phoenix queries are not working so would be 
better to go with server side filtering by default.

> Honor omid.server.side.filter configuration while creating Omid Transactional 
> Table
> -----------------------------------------------------------------------------------
>
>                 Key: PHOENIX-7131
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7131
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>            Priority: Major
>             Fix For: 5.2.0, 5.1.4
>
>
> Currently by default we are passing server side filter to be used as true 
> always would be better to honor the configuration value of 
> omid.server.side.filter while creating Omid TTable
> {noformat}
>     public OmidTransactionTable(PhoenixTransactionContext ctx, Table hTable, 
> boolean isConflictFree, boolean addShadowCells) throws SQLException  {
>        ....
>         try {
>             tTable = new TTable(hTable, true, isConflictFree);
>         } catch (IOException e) {
>        ....
>     }
> {noformat}
> Would be better to use following constructor
> {noformat}
>     public TTable(Table hTable, boolean conflictFree) throws IOException {
>         this(hTable, 
> hTable.getConfiguration().getBoolean("omid.server.side.filter", false), 
> conflictFree);
>     }
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to