[jira] [Updated] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN
[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-3822: -- Attachment: PHOENIX-3822_v5.patch > Surface byte and row estimates in a machine readable way when doing EXPLAIN > PLAN > > > Key: PHOENIX-3822 > URL: https://issues.apache.org/jira/browse/PHOENIX-3822 > Project: Phoenix > Issue Type: Improvement >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-3822.patch, PHOENIX-3822_v2.patch, > PHOENIX-3822_v3.patch, PHOENIX-3822_v4.patch, PHOENIX-3822_v5.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN
[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-3822: -- Attachment: (was: PHOENIX-3822_v5.patch) > Surface byte and row estimates in a machine readable way when doing EXPLAIN > PLAN > > > Key: PHOENIX-3822 > URL: https://issues.apache.org/jira/browse/PHOENIX-3822 > Project: Phoenix > Issue Type: Improvement >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-3822.patch, PHOENIX-3822_v2.patch, > PHOENIX-3822_v3.patch, PHOENIX-3822_v4.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN
[
https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Samarth Jain updated PHOENIX-3822:
--
Attachment: PHOENIX-3822_v5.patch
Updated patch.
Changed the interface to reflect that the two methods return null only when the
estimate cannot be provided (for example when stats information is not
available for queries whose scans are executed in parallel).
{code}
/**
* @return estimated number of rows that will be scanned when this
statement plan is been executed.
* Returns null if the estimate cannot be provided.
* @throws SQLException
*/
public Long getEstimatedRowsToScan() throws SQLException;
/**
* @return estimated number of bytes that will be scanned when this
statement plan is been executed.
* Returns null if the estimate cannot be provided.
*/
public Long getEstimatedBytesToScan() throws SQLException;
{code}
For queries that are executed serially, estimates can still be provided. I have
added tests for these scenarios in this patch. Also removed changes in
PhoenixStatement where I was previously returning null for the estimates by
moving the code to BaseMutationPlan. This removed the need of having a base
class with zero estimates for now.
> Surface byte and row estimates in a machine readable way when doing EXPLAIN
> PLAN
>
>
> Key: PHOENIX-3822
> URL: https://issues.apache.org/jira/browse/PHOENIX-3822
> Project: Phoenix
> Issue Type: Improvement
>Reporter: Samarth Jain
>Assignee: Samarth Jain
> Attachments: PHOENIX-3822.patch, PHOENIX-3822_v2.patch,
> PHOENIX-3822_v3.patch, PHOENIX-3822_v4.patch, PHOENIX-3822_v5.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN
[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-3822: -- Attachment: PHOENIX-3822_v4.patch Fixing the test failure. > Surface byte and row estimates in a machine readable way when doing EXPLAIN > PLAN > > > Key: PHOENIX-3822 > URL: https://issues.apache.org/jira/browse/PHOENIX-3822 > Project: Phoenix > Issue Type: Improvement >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-3822.patch, PHOENIX-3822_v2.patch, > PHOENIX-3822_v3.patch, PHOENIX-3822_v4.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN
[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-3822: -- Attachment: PHOENIX-3822_v3.patch > Surface byte and row estimates in a machine readable way when doing EXPLAIN > PLAN > > > Key: PHOENIX-3822 > URL: https://issues.apache.org/jira/browse/PHOENIX-3822 > Project: Phoenix > Issue Type: Improvement >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-3822.patch, PHOENIX-3822_v2.patch, > PHOENIX-3822_v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN
[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-3822: -- Attachment: (was: PHOENIX-3822_v3.patch) > Surface byte and row estimates in a machine readable way when doing EXPLAIN > PLAN > > > Key: PHOENIX-3822 > URL: https://issues.apache.org/jira/browse/PHOENIX-3822 > Project: Phoenix > Issue Type: Improvement >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-3822.patch, PHOENIX-3822_v2.patch, > PHOENIX-3822_v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN
[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-3822: -- Attachment: PHOENIX-3822_v3.patch Thanks for the reviews, [~jamestaylor]. Attached is the updated patch along with tests for delete client/server, upsert select client/server and upsert values. > Surface byte and row estimates in a machine readable way when doing EXPLAIN > PLAN > > > Key: PHOENIX-3822 > URL: https://issues.apache.org/jira/browse/PHOENIX-3822 > Project: Phoenix > Issue Type: Improvement >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-3822.patch, PHOENIX-3822_v2.patch, > PHOENIX-3822_v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN
[
https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Samarth Jain updated PHOENIX-3822:
--
Attachment: PHOENIX-3822_v2.patch
Thanks for the review, [~jamestaylor]. Please see the updated patch. I have
added columns BYTES and ROWS in the explain plan result set to provide the info.
ExplainPlanIT#getByteRowEstimates provides an example of how users can get hold
of these values.
{code}
private static Pair getByteRowEstimates(Connection conn, String
sql, List bindValues) throws Exception {
String explainSql = "EXPLAIN " + sql;
Long estimatedBytes = null;
Long estimatedRows = null;
try (PreparedStatement statement = conn.prepareStatement(explainSql)) {
for (Object bind : bindValues) {
statement.setObject(1, bind);
}
ResultSet rs = statement.executeQuery(explainSql);
rs.next();
estimatedBytes = rs.getLong("BYTES");
estimatedRows = rs.getLong("ROWS");
}
return new Pair<>(estimatedRows, estimatedBytes);
}
{code}
> Surface byte and row estimates in a machine readable way when doing EXPLAIN
> PLAN
>
>
> Key: PHOENIX-3822
> URL: https://issues.apache.org/jira/browse/PHOENIX-3822
> Project: Phoenix
> Issue Type: Improvement
>Reporter: Samarth Jain
>Assignee: Samarth Jain
> Attachments: PHOENIX-3822.patch, PHOENIX-3822_v2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN
[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-3822: -- Attachment: (was: PHOENIX-3822.patch) > Surface byte and row estimates in a machine readable way when doing EXPLAIN > PLAN > > > Key: PHOENIX-3822 > URL: https://issues.apache.org/jira/browse/PHOENIX-3822 > Project: Phoenix > Issue Type: Improvement >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-3822.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN
[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-3822: -- Attachment: PHOENIX-3822.patch > Surface byte and row estimates in a machine readable way when doing EXPLAIN > PLAN > > > Key: PHOENIX-3822 > URL: https://issues.apache.org/jira/browse/PHOENIX-3822 > Project: Phoenix > Issue Type: Improvement >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-3822.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN
[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-3822: -- Attachment: (was: PHOENIX-3822.patch) > Surface byte and row estimates in a machine readable way when doing EXPLAIN > PLAN > > > Key: PHOENIX-3822 > URL: https://issues.apache.org/jira/browse/PHOENIX-3822 > Project: Phoenix > Issue Type: Improvement >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-3822.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN
[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-3822: -- Attachment: PHOENIX-3822.patch [~jamestaylor], please review. > Surface byte and row estimates in a machine readable way when doing EXPLAIN > PLAN > > > Key: PHOENIX-3822 > URL: https://issues.apache.org/jira/browse/PHOENIX-3822 > Project: Phoenix > Issue Type: Improvement >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-3822.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN
[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-3822: -- Attachment: PHOENIX-3822.patch > Surface byte and row estimates in a machine readable way when doing EXPLAIN > PLAN > > > Key: PHOENIX-3822 > URL: https://issues.apache.org/jira/browse/PHOENIX-3822 > Project: Phoenix > Issue Type: Improvement >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-3822.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN
[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-3822: -- Attachment: PHOENIX-3822.patch > Surface byte and row estimates in a machine readable way when doing EXPLAIN > PLAN > > > Key: PHOENIX-3822 > URL: https://issues.apache.org/jira/browse/PHOENIX-3822 > Project: Phoenix > Issue Type: Improvement >Reporter: Samarth Jain >Assignee: Samarth Jain > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN
[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-3822: -- Attachment: (was: PHOENIX-3822_4.x-HBase-0.98.patch) > Surface byte and row estimates in a machine readable way when doing EXPLAIN > PLAN > > > Key: PHOENIX-3822 > URL: https://issues.apache.org/jira/browse/PHOENIX-3822 > Project: Phoenix > Issue Type: Improvement >Reporter: Samarth Jain >Assignee: Samarth Jain > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN
[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-3822: -- Attachment: PHOENIX-3822_4.x-HBase-0.98.patch WIP patch. Need to add some tests. Parking here for test run. > Surface byte and row estimates in a machine readable way when doing EXPLAIN > PLAN > > > Key: PHOENIX-3822 > URL: https://issues.apache.org/jira/browse/PHOENIX-3822 > Project: Phoenix > Issue Type: Improvement >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-3822_4.x-HBase-0.98.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
