[jira] [Created] (PHOENIX-4837) Update deprecated API to the new one. Also make the code a bit java 7 style
Aman Poonia created PHOENIX-4837: Summary: Update deprecated API to the new one. Also make the code a bit java 7 style Key: PHOENIX-4837 URL: https://issues.apache.org/jira/browse/PHOENIX-4837 Project: Phoenix Issue Type: Improvement Affects Versions: 4.15.0 Reporter: Aman Poonia Currently we are using a few deprecated HBase API's in LocalIndexing classes. Also Some of the Autoclosable Resources are being closed manually. Improve the code to make it bit more cleaner and updated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (PHOENIX-4837) Update deprecated API to the new one. Also make the code a bit java 7 style
[ https://issues.apache.org/jira/browse/PHOENIX-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Poonia updated PHOENIX-4837: - Attachment: PHOENIX-4837.patch > Update deprecated API to the new one. Also make the code a bit java 7 style > --- > > Key: PHOENIX-4837 > URL: https://issues.apache.org/jira/browse/PHOENIX-4837 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.15.0 >Reporter: Aman Poonia >Priority: Minor > Attachments: PHOENIX-4837.patch > > > Currently we are using a few deprecated HBase API's in LocalIndexing classes. > Also Some of the Autoclosable Resources are being closed manually. Improve > the code to make it bit more cleaner and updated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (PHOENIX-4837) Update deprecated API to the new one. Also make the code a bit java 7 style
[ https://issues.apache.org/jira/browse/PHOENIX-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Poonia updated PHOENIX-4837: - Attachment: PHOENIX-4837.4.x-HBase-1.3.001.patch > Update deprecated API to the new one. Also make the code a bit java 7 style > --- > > Key: PHOENIX-4837 > URL: https://issues.apache.org/jira/browse/PHOENIX-4837 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.15.0 >Reporter: Aman Poonia >Priority: Minor > Attachments: PHOENIX-4837.4.x-HBase-1.3.001.patch, PHOENIX-4837.patch > > > Currently we are using a few deprecated HBase API's in LocalIndexing classes. > Also Some of the Autoclosable Resources are being closed manually. Improve > the code to make it bit more cleaner and updated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (PHOENIX-4837) Update deprecated API to the new one. Also make the code a bit java 7 style
[ https://issues.apache.org/jira/browse/PHOENIX-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Poonia updated PHOENIX-4837: - Attachment: (was: PHOENIX-4837.patch) > Update deprecated API to the new one. Also make the code a bit java 7 style > --- > > Key: PHOENIX-4837 > URL: https://issues.apache.org/jira/browse/PHOENIX-4837 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.15.0 >Reporter: Aman Poonia >Priority: Minor > Attachments: PHOENIX-4837.4.x-HBase-1.3.001.patch > > > Currently we are using a few deprecated HBase API's in LocalIndexing classes. > Also Some of the Autoclosable Resources are being closed manually. Improve > the code to make it bit more cleaner and updated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (PHOENIX-4647) Column header doesn't handle optional arguments correctly
[ https://issues.apache.org/jira/browse/PHOENIX-4647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Cang updated PHOENIX-4647: - Attachment: (was: PHOENIX-4647.master.002.patch) > Column header doesn't handle optional arguments correctly > - > > Key: PHOENIX-4647 > URL: https://issues.apache.org/jira/browse/PHOENIX-4647 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.14.0 >Reporter: Shehzaad Nakhoda >Assignee: Xu Cang >Priority: Major > Attachments: PHOENIX-4647.4.x-HBase-1.3.002.patch, > PHOENIX-4647.master.001.patch > > > SUBSTR(NAME, 1) > being rendered as > SUBSTR(NAME, 1, ) > in things like column headings. > For example: > 0: jdbc:phoenix:> create table hello_table (ID DECIMAL PRIMARY KEY, NAME > VARCHAR); > No rows affected (1.252 seconds) > 0: jdbc:phoenix:> upsert into hello_table values(1, 'abc'); > 1 row affected (0.025 seconds) > 0: jdbc:phoenix:> select substr(name, 1) from hello_table; > ++ > | SUBSTR(NAME, 1, ) | > ++ > | abc| > ++ > Looks to me like there's a bug - > SUBSTR(NAME, 1) should be represented as SUBSTR(NAME, 1) not as SUBSTR(NAME, > 1, ) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (PHOENIX-4647) Column header doesn't handle optional arguments correctly
[ https://issues.apache.org/jira/browse/PHOENIX-4647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Cang updated PHOENIX-4647: - Attachment: PHOENIX-4647.4.x-HBase-1.3.002.patch > Column header doesn't handle optional arguments correctly > - > > Key: PHOENIX-4647 > URL: https://issues.apache.org/jira/browse/PHOENIX-4647 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.14.0 >Reporter: Shehzaad Nakhoda >Assignee: Xu Cang >Priority: Major > Attachments: PHOENIX-4647.4.x-HBase-1.3.002.patch, > PHOENIX-4647.master.001.patch > > > SUBSTR(NAME, 1) > being rendered as > SUBSTR(NAME, 1, ) > in things like column headings. > For example: > 0: jdbc:phoenix:> create table hello_table (ID DECIMAL PRIMARY KEY, NAME > VARCHAR); > No rows affected (1.252 seconds) > 0: jdbc:phoenix:> upsert into hello_table values(1, 'abc'); > 1 row affected (0.025 seconds) > 0: jdbc:phoenix:> select substr(name, 1) from hello_table; > ++ > | SUBSTR(NAME, 1, ) | > ++ > | abc| > ++ > Looks to me like there's a bug - > SUBSTR(NAME, 1) should be represented as SUBSTR(NAME, 1) not as SUBSTR(NAME, > 1, ) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (PHOENIX-4834) PhoenixMetricsLog interface methods should not depend on specific logger
[
https://issues.apache.org/jira/browse/PHOENIX-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karan Mehta reassigned PHOENIX-4834:
Assignee: Karan Mehta
> PhoenixMetricsLog interface methods should not depend on specific logger
>
>
> Key: PHOENIX-4834
> URL: https://issues.apache.org/jira/browse/PHOENIX-4834
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 4.15.0
>Reporter: Karan Mehta
>Assignee: Karan Mehta
>Priority: Major
> Fix For: 4.15.0
>
> Attachments: PHOENIX-4834.001.patch
>
>
> {{PhoenixMetricsLog}} is an interface that provides a wrapper around various
> JDBC objects with logging functionality upon close/commit. The methods take
> in {{Logger}} as an input, which is {{org.slf4j.Logger}}. A better way of
> doing is that the interface should just pass the metrics and allow the user
> to configure and use whatever logging library they want to use.
> This Jira will deprecate the older methods by provide a default
> implementation for them and add the new methods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (PHOENIX-4834) PhoenixMetricsLog interface methods should not depend on specific logger
[
https://issues.apache.org/jira/browse/PHOENIX-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karan Mehta updated PHOENIX-4834:
-
Description:
{{PhoenixMetricsLog}} is an interface that provides a wrapper around various
JDBC objects with logging functionality upon close/commit. The methods take in
{{Logger}} as an input, which is {{org.slf4j.Logger}}. A better way of doing is
that the interface should just pass the metrics and allow the user to configure
and use whatever logging library they want to use.
This Jira will deprecate the older methods by provide a default implementation
for them and add the new methods.
Ideally we should have provided default implementations, but since we are on
Java 7, we are unable to do that.
was:
{{PhoenixMetricsLog}} is an interface that provides a wrapper around various
JDBC objects with logging functionality upon close/commit. The methods take in
{{Logger}} as an input, which is {{org.slf4j.Logger}}. A better way of doing is
that the interface should just pass the metrics and allow the user to configure
and use whatever logging library they want to use.
This Jira will deprecate the older methods by provide a default implementation
for them and add the new methods.
> PhoenixMetricsLog interface methods should not depend on specific logger
>
>
> Key: PHOENIX-4834
> URL: https://issues.apache.org/jira/browse/PHOENIX-4834
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 4.15.0
>Reporter: Karan Mehta
>Assignee: Karan Mehta
>Priority: Major
> Fix For: 4.15.0
>
> Attachments: PHOENIX-4834.001.patch
>
>
> {{PhoenixMetricsLog}} is an interface that provides a wrapper around various
> JDBC objects with logging functionality upon close/commit. The methods take
> in {{Logger}} as an input, which is {{org.slf4j.Logger}}. A better way of
> doing is that the interface should just pass the metrics and allow the user
> to configure and use whatever logging library they want to use.
> This Jira will deprecate the older methods by provide a default
> implementation for them and add the new methods.
> Ideally we should have provided default implementations, but since we are on
> Java 7, we are unable to do that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (PHOENIX-4834) PhoenixMetricsLog interface methods should not depend on specific logger
[
https://issues.apache.org/jira/browse/PHOENIX-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karan Mehta updated PHOENIX-4834:
-
Attachment: PHOENIX-4834.001.patch
> PhoenixMetricsLog interface methods should not depend on specific logger
>
>
> Key: PHOENIX-4834
> URL: https://issues.apache.org/jira/browse/PHOENIX-4834
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 4.15.0
>Reporter: Karan Mehta
>Assignee: Karan Mehta
>Priority: Major
> Fix For: 4.15.0
>
> Attachments: PHOENIX-4834.001.patch
>
>
> {{PhoenixMetricsLog}} is an interface that provides a wrapper around various
> JDBC objects with logging functionality upon close/commit. The methods take
> in {{Logger}} as an input, which is {{org.slf4j.Logger}}. A better way of
> doing is that the interface should just pass the metrics and allow the user
> to configure and use whatever logging library they want to use.
> This Jira will deprecate the older methods by provide a default
> implementation for them and add the new methods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (PHOENIX-4647) Column header doesn't handle optional arguments correctly
[ https://issues.apache.org/jira/browse/PHOENIX-4647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Cang updated PHOENIX-4647: - Attachment: PHOENIX-4647.master.002.patch > Column header doesn't handle optional arguments correctly > - > > Key: PHOENIX-4647 > URL: https://issues.apache.org/jira/browse/PHOENIX-4647 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.14.0 >Reporter: Shehzaad Nakhoda >Assignee: Xu Cang >Priority: Major > Attachments: PHOENIX-4647.master.001.patch, > PHOENIX-4647.master.002.patch > > > SUBSTR(NAME, 1) > being rendered as > SUBSTR(NAME, 1, ) > in things like column headings. > For example: > 0: jdbc:phoenix:> create table hello_table (ID DECIMAL PRIMARY KEY, NAME > VARCHAR); > No rows affected (1.252 seconds) > 0: jdbc:phoenix:> upsert into hello_table values(1, 'abc'); > 1 row affected (0.025 seconds) > 0: jdbc:phoenix:> select substr(name, 1) from hello_table; > ++ > | SUBSTR(NAME, 1, ) | > ++ > | abc| > ++ > Looks to me like there's a bug - > SUBSTR(NAME, 1) should be represented as SUBSTR(NAME, 1) not as SUBSTR(NAME, > 1, ) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (PHOENIX-4834) PhoenixMetricsLog interface methods should not depend on specific logger
[
https://issues.apache.org/jira/browse/PHOENIX-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karan Mehta updated PHOENIX-4834:
-
Attachment: PHOENIX-4834.4.x-HBase-1.4.001.patch
> PhoenixMetricsLog interface methods should not depend on specific logger
>
>
> Key: PHOENIX-4834
> URL: https://issues.apache.org/jira/browse/PHOENIX-4834
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 4.15.0
>Reporter: Karan Mehta
>Assignee: Karan Mehta
>Priority: Major
> Fix For: 4.15.0
>
> Attachments: PHOENIX-4834.4.x-HBase-1.4.001.patch
>
>
> {{PhoenixMetricsLog}} is an interface that provides a wrapper around various
> JDBC objects with logging functionality upon close/commit. The methods take
> in {{Logger}} as an input, which is {{org.slf4j.Logger}}. A better way of
> doing is that the interface should just pass the metrics and allow the user
> to configure and use whatever logging library they want to use.
> This Jira will deprecate the older methods by provide a default
> implementation for them and add the new methods.
> Ideally we should have provided default implementations, but since we are on
> Java 7, we are unable to do that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (PHOENIX-4835) LoggingPhoenixConnection should log metrics upon connection close
[
https://issues.apache.org/jira/browse/PHOENIX-4835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karan Mehta updated PHOENIX-4835:
-
Attachment: PHOENIX-4835.4.x-HBase-1.4.001.patch
> LoggingPhoenixConnection should log metrics upon connection close
> -
>
> Key: PHOENIX-4835
> URL: https://issues.apache.org/jira/browse/PHOENIX-4835
> Project: Phoenix
> Issue Type: Improvement
>Reporter: Karan Mehta
>Priority: Major
> Attachments: PHOENIX-4835.4.x-HBase-1.4.001.patch
>
>
> {{LoggingPhoenixConnection}} currently logs metrics upon {{commit()}}, which
> may miss the logging of metrics sometimes if commit is never called. We
> should move it to {{close()}} method instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (PHOENIX-4834) PhoenixMetricsLog interface methods should not depend on specific logger
[
https://issues.apache.org/jira/browse/PHOENIX-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karan Mehta updated PHOENIX-4834:
-
Attachment: (was: PHOENIX-4834.001.patch)
> PhoenixMetricsLog interface methods should not depend on specific logger
>
>
> Key: PHOENIX-4834
> URL: https://issues.apache.org/jira/browse/PHOENIX-4834
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 4.15.0
>Reporter: Karan Mehta
>Assignee: Karan Mehta
>Priority: Major
> Fix For: 4.15.0
>
> Attachments: PHOENIX-4834.4.x-HBase-1.4.001.patch
>
>
> {{PhoenixMetricsLog}} is an interface that provides a wrapper around various
> JDBC objects with logging functionality upon close/commit. The methods take
> in {{Logger}} as an input, which is {{org.slf4j.Logger}}. A better way of
> doing is that the interface should just pass the metrics and allow the user
> to configure and use whatever logging library they want to use.
> This Jira will deprecate the older methods by provide a default
> implementation for them and add the new methods.
> Ideally we should have provided default implementations, but since we are on
> Java 7, we are unable to do that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (PHOENIX-4838) Remove viewIndexId from PHOENIX protobuf
Mehdi Salarkia created PHOENIX-4838: --- Summary: Remove viewIndexId from PHOENIX protobuf Key: PHOENIX-4838 URL: https://issues.apache.org/jira/browse/PHOENIX-4838 Project: Phoenix Issue Type: Task Affects Versions: 5.0.0 Reporter: Mehdi Salarkia As part of discussion to address PHOENIX-3547 the suggestion was to add a new long property (viewIndexLongId) and remove veiwIndexId which is an int in the next version of Apache Phoenix to support more number of indices. More details: [https://github.com/apache/phoenix/pull/317] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (PHOENIX-4834) PhoenixMetricsLog interface methods should not depend on specific logger
[
https://issues.apache.org/jira/browse/PHOENIX-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karan Mehta updated PHOENIX-4834:
-
Fix Version/s: 5.1.0
> PhoenixMetricsLog interface methods should not depend on specific logger
>
>
> Key: PHOENIX-4834
> URL: https://issues.apache.org/jira/browse/PHOENIX-4834
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 4.15.0
>Reporter: Karan Mehta
>Assignee: Karan Mehta
>Priority: Major
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-4834.4.x-HBase-1.4.001.patch,
> PHOENIX-4834.4.x-HBase-1.4.002.patch
>
>
> {{PhoenixMetricsLog}} is an interface that provides a wrapper around various
> JDBC objects with logging functionality upon close/commit. The methods take
> in {{Logger}} as an input, which is {{org.slf4j.Logger}}. A better way of
> doing is that the interface should just pass the metrics and allow the user
> to configure and use whatever logging library they want to use.
> This Jira will deprecate the older methods by provide a default
> implementation for them and add the new methods.
> Ideally we should have provided default implementations, but since we are on
> Java 7, we are unable to do that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (PHOENIX-4838) Remove viewIndexId from PHOENIX protobuf
[ https://issues.apache.org/jira/browse/PHOENIX-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehdi Salarkia updated PHOENIX-4838: Description: As part of discussion to address PHOENIX-3547 the suggestion was to add a new long property (viewIndexLongId) and remove veiwIndexId which is an int in the next version of Apache Phoenix to support more number of indices while keeping backward compatibility during the migration process. More details: [https://github.com/apache/phoenix/pull/317] was: As part of discussion to address PHOENIX-3547 the suggestion was to add a new long property (viewIndexLongId) and remove veiwIndexId which is an int in the next version of Apache Phoenix to support more number of indices. More details: [https://github.com/apache/phoenix/pull/317] > Remove viewIndexId from PHOENIX protobuf > > > Key: PHOENIX-4838 > URL: https://issues.apache.org/jira/browse/PHOENIX-4838 > Project: Phoenix > Issue Type: Task >Affects Versions: 5.0.0 >Reporter: Mehdi Salarkia >Priority: Minor > > As part of discussion to address PHOENIX-3547 the suggestion was to add a new > long property (viewIndexLongId) and remove veiwIndexId which is an int in the > next version of Apache Phoenix to support more number of indices while > keeping backward compatibility during the migration process. > More details: > [https://github.com/apache/phoenix/pull/317] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (PHOENIX-4836) PhoenixMetricsSink Compatibility problems
[
https://issues.apache.org/jira/browse/PHOENIX-4836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser resolved PHOENIX-4836.
-
Resolution: Invalid
Phoenix-5.0 requires Hadoop3.x
> PhoenixMetricsSink Compatibility problems
> -
>
> Key: PHOENIX-4836
> URL: https://issues.apache.org/jira/browse/PHOENIX-4836
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 5.0.0
> Environment: CentOS 7 x64
> JDK 8
> Hadoop 2.8.4
>Reporter: apcahephoenix
>Priority: Major
>
> java.lang.AbstractMethodError:
> org.apache.phoenix.trace.PhoenixMetricsSink.init(Lorg/apache/commons/configuration/SubsetConfiguration;)V
> at
> org.apache.hadoop.metrics2.impl.MetricsConfig.getPlugin(MetricsConfig.java:199)
> at
> org.apache.hadoop.metrics2.impl.MetricsSystemImpl.newSink(MetricsSystemImpl.java:529)
>
> *org.apache.phoenix.trace.PhoenixMetricsSink :*
> {color:#FF}import{color}
> org.apache.commons.{color:#d04437}*configuration2*{color}.SubsetConfiguration;
>
> *org.apache.hadoop.metrics2.MetricsPlugin:*
> {color:#FF}import{color}
> org.apache.commons.{color:#d04437}*configuration*{color}.SubsetConfiguration;
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (PHOENIX-4834) PhoenixMetricsLog interface methods should not depend on specific logger
[
https://issues.apache.org/jira/browse/PHOENIX-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karan Mehta updated PHOENIX-4834:
-
Attachment: PHOENIX-4834.4.x-HBase-1.4.002.patch
> PhoenixMetricsLog interface methods should not depend on specific logger
>
>
> Key: PHOENIX-4834
> URL: https://issues.apache.org/jira/browse/PHOENIX-4834
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 4.15.0
>Reporter: Karan Mehta
>Assignee: Karan Mehta
>Priority: Major
> Fix For: 4.15.0
>
> Attachments: PHOENIX-4834.4.x-HBase-1.4.001.patch,
> PHOENIX-4834.4.x-HBase-1.4.002.patch
>
>
> {{PhoenixMetricsLog}} is an interface that provides a wrapper around various
> JDBC objects with logging functionality upon close/commit. The methods take
> in {{Logger}} as an input, which is {{org.slf4j.Logger}}. A better way of
> doing is that the interface should just pass the metrics and allow the user
> to configure and use whatever logging library they want to use.
> This Jira will deprecate the older methods by provide a default
> implementation for them and add the new methods.
> Ideally we should have provided default implementations, but since we are on
> Java 7, we are unable to do that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
