[jira] [Commented] (PIG-3765) Ability to disable Pig commands and operators
[ https://issues.apache.org/jira/browse/PIG-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925396#comment-13925396 ] Prashant Kommireddi commented on PIG-3765: -- [~cheolsoo] - would you mind closing this out if there are no more failures? PIG-3802 fixes it. Ability to disable Pig commands and operators - Key: PIG-3765 URL: https://issues.apache.org/jira/browse/PIG-3765 Project: Pig Issue Type: New Feature Components: documentation, grunt Reporter: Prashant Kommireddi Assignee: Prashant Kommireddi Fix For: 0.13.0 Attachments: PIG-3765.patch, PIG-3765_2.patch, PIG-3765_3.patch, PIG-3765_4.patch, PIG-3765_5.patch This is an admin feature providing ability to blacklist or/and whitelist certain commands and operations. Pig exposes a few of these that could be not very safe in a multitenant environment. For example, sh invokes shell commands, set allows users to change non-final configs. While these are tremendously useful in general, having an ability to disable would make Pig a safer platform. The goal is to allow administrators to be able to have more control over user scripts. Default behaviour would still be the same - no filters applied on commands and operators. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (PIG-3765) Ability to disable Pig commands and operators
[ https://issues.apache.org/jira/browse/PIG-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925093#comment-13925093 ] Prashant Kommireddi commented on PIG-3765: -- Opened PIG-3802 to fix this. Ability to disable Pig commands and operators - Key: PIG-3765 URL: https://issues.apache.org/jira/browse/PIG-3765 Project: Pig Issue Type: New Feature Components: documentation, grunt Reporter: Prashant Kommireddi Assignee: Prashant Kommireddi Fix For: 0.13.0 Attachments: PIG-3765.patch, PIG-3765_2.patch, PIG-3765_3.patch, PIG-3765_4.patch, PIG-3765_5.patch This is an admin feature providing ability to blacklist or/and whitelist certain commands and operations. Pig exposes a few of these that could be not very safe in a multitenant environment. For example, sh invokes shell commands, set allows users to change non-final configs. While these are tremendously useful in general, having an ability to disable would make Pig a safer platform. The goal is to allow administrators to be able to have more control over user scripts. Default behaviour would still be the same - no filters applied on commands and operators. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (PIG-3765) Ability to disable Pig commands and operators
[
https://issues.apache.org/jira/browse/PIG-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924574#comment-13924574
]
Prashant Kommireddi commented on PIG-3765:
--
Sure, I will take a look at it during the weekend. It probably has got to do
with the use of {{@Rule}} for checking exception message contents. I will
probably eliminate that.
Ability to disable Pig commands and operators
-
Key: PIG-3765
URL: https://issues.apache.org/jira/browse/PIG-3765
Project: Pig
Issue Type: New Feature
Components: documentation, grunt
Reporter: Prashant Kommireddi
Assignee: Prashant Kommireddi
Fix For: 0.13.0
Attachments: PIG-3765.patch, PIG-3765_2.patch, PIG-3765_3.patch,
PIG-3765_4.patch, PIG-3765_5.patch
This is an admin feature providing ability to blacklist or/and whitelist
certain commands and operations. Pig exposes a few of these that could be not
very safe in a multitenant environment. For example, sh invokes shell
commands, set allows users to change non-final configs. While these are
tremendously useful in general, having an ability to disable would make Pig a
safer platform. The goal is to allow administrators to be able to have more
control over user scripts. Default behaviour would still be the same - no
filters applied on commands and operators.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (PIG-3765) Ability to disable Pig commands and operators
[ https://issues.apache.org/jira/browse/PIG-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923129#comment-13923129 ] Cheolsoo Park commented on PIG-3765: I made some comments in RB. Ability to disable Pig commands and operators - Key: PIG-3765 URL: https://issues.apache.org/jira/browse/PIG-3765 Project: Pig Issue Type: New Feature Components: documentation, grunt Reporter: Prashant Kommireddi Assignee: Prashant Kommireddi Attachments: PIG-3765.patch, PIG-3765_2.patch, PIG-3765_3.patch This is an admin feature providing ability to blacklist or/and whitelist certain commands and operations. Pig exposes a few of these that could be not very safe in a multitenant environment. For example, sh invokes shell commands, set allows users to change non-final configs. While these are tremendously useful in general, having an ability to disable would make Pig a safer platform. The goal is to allow administrators to be able to have more control over user scripts. Default behaviour would still be the same - no filters applied on commands and operators. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (PIG-3765) Ability to disable Pig commands and operators
[ https://issues.apache.org/jira/browse/PIG-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923347#comment-13923347 ] Cheolsoo Park commented on PIG-3765: +1 assuming unit tests pass. Ability to disable Pig commands and operators - Key: PIG-3765 URL: https://issues.apache.org/jira/browse/PIG-3765 Project: Pig Issue Type: New Feature Components: documentation, grunt Reporter: Prashant Kommireddi Assignee: Prashant Kommireddi Attachments: PIG-3765.patch, PIG-3765_2.patch, PIG-3765_3.patch, PIG-3765_4.patch This is an admin feature providing ability to blacklist or/and whitelist certain commands and operations. Pig exposes a few of these that could be not very safe in a multitenant environment. For example, sh invokes shell commands, set allows users to change non-final configs. While these are tremendously useful in general, having an ability to disable would make Pig a safer platform. The goal is to allow administrators to be able to have more control over user scripts. Default behaviour would still be the same - no filters applied on commands and operators. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (PIG-3765) Ability to disable Pig commands and operators
[ https://issues.apache.org/jira/browse/PIG-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923348#comment-13923348 ] Cheolsoo Park commented on PIG-3765: Please open a jira to document this feature. I think it's perfect to document it to the admin section- http://pig.apache.org/docs/r0.12.0/admin.html Ability to disable Pig commands and operators - Key: PIG-3765 URL: https://issues.apache.org/jira/browse/PIG-3765 Project: Pig Issue Type: New Feature Components: documentation, grunt Reporter: Prashant Kommireddi Assignee: Prashant Kommireddi Attachments: PIG-3765.patch, PIG-3765_2.patch, PIG-3765_3.patch, PIG-3765_4.patch This is an admin feature providing ability to blacklist or/and whitelist certain commands and operations. Pig exposes a few of these that could be not very safe in a multitenant environment. For example, sh invokes shell commands, set allows users to change non-final configs. While these are tremendously useful in general, having an ability to disable would make Pig a safer platform. The goal is to allow administrators to be able to have more control over user scripts. Default behaviour would still be the same - no filters applied on commands and operators. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (PIG-3765) Ability to disable Pig commands and operators
[ https://issues.apache.org/jira/browse/PIG-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923648#comment-13923648 ] Prashant Kommireddi commented on PIG-3765: -- Committed to trunk. Thanks [~cheolsoo] for the review! Note: typo in the above comment - failed as PigServer was NOT being set Ability to disable Pig commands and operators - Key: PIG-3765 URL: https://issues.apache.org/jira/browse/PIG-3765 Project: Pig Issue Type: New Feature Components: documentation, grunt Reporter: Prashant Kommireddi Assignee: Prashant Kommireddi Attachments: PIG-3765.patch, PIG-3765_2.patch, PIG-3765_3.patch, PIG-3765_4.patch, PIG-3765_5.patch This is an admin feature providing ability to blacklist or/and whitelist certain commands and operations. Pig exposes a few of these that could be not very safe in a multitenant environment. For example, sh invokes shell commands, set allows users to change non-final configs. While these are tremendously useful in general, having an ability to disable would make Pig a safer platform. The goal is to allow administrators to be able to have more control over user scripts. Default behaviour would still be the same - no filters applied on commands and operators. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (PIG-3765) Ability to disable Pig commands and operators
[ https://issues.apache.org/jira/browse/PIG-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13921119#comment-13921119 ] Cheolsoo Park commented on PIG-3765: [~prkommireddi], do you mind uploading your patch to RB? Ability to disable Pig commands and operators - Key: PIG-3765 URL: https://issues.apache.org/jira/browse/PIG-3765 Project: Pig Issue Type: New Feature Components: documentation, grunt Reporter: Prashant Kommireddi Assignee: Prashant Kommireddi Attachments: PIG-3765.patch, PIG-3765_2.patch, PIG-3765_3.patch This is an admin feature providing ability to blacklist or/and whitelist certain commands and operations. Pig exposes a few of these that could be not very safe in a multitenant environment. For example, sh invokes shell commands, set allows users to change non-final configs. While these are tremendously useful in general, having an ability to disable would make Pig a safer platform. The goal is to allow administrators to be able to have more control over user scripts. Default behaviour would still be the same - no filters applied on commands and operators. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (PIG-3765) Ability to disable Pig commands and operators
[ https://issues.apache.org/jira/browse/PIG-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13921170#comment-13921170 ] Prashant Kommireddi commented on PIG-3765: -- Sure, https://reviews.apache.org/r/18779/ Ability to disable Pig commands and operators - Key: PIG-3765 URL: https://issues.apache.org/jira/browse/PIG-3765 Project: Pig Issue Type: New Feature Components: documentation, grunt Reporter: Prashant Kommireddi Assignee: Prashant Kommireddi Attachments: PIG-3765.patch, PIG-3765_2.patch, PIG-3765_3.patch This is an admin feature providing ability to blacklist or/and whitelist certain commands and operations. Pig exposes a few of these that could be not very safe in a multitenant environment. For example, sh invokes shell commands, set allows users to change non-final configs. While these are tremendously useful in general, having an ability to disable would make Pig a safer platform. The goal is to allow administrators to be able to have more control over user scripts. Default behaviour would still be the same - no filters applied on commands and operators. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (PIG-3765) Ability to disable Pig commands and operators
[ https://issues.apache.org/jira/browse/PIG-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911849#comment-13911849 ] Daniel Dai commented on PIG-3765: - Overall, patch looks good. I have two comments: 1. In your use case, is user allowed to use PigServer/script engine in place of Grunt? If so, we need to hook PigServer as well. 2. Do we need to change the signature of GruntParser which entails lengthy test changes? Seems it is not absolutely needed, right? Ability to disable Pig commands and operators - Key: PIG-3765 URL: https://issues.apache.org/jira/browse/PIG-3765 Project: Pig Issue Type: New Feature Components: documentation, grunt Reporter: Prashant Kommireddi Assignee: Prashant Kommireddi Attachments: PIG-3765.patch, PIG-3765_2.patch This is an admin feature providing ability to blacklist or/and whitelist certain commands and operations. Pig exposes a few of these that could be not very safe in a multitenant environment. For example, sh invokes shell commands, set allows users to change non-final configs. While these are tremendously useful in general, having an ability to disable would make Pig a safer platform. The goal is to allow administrators to be able to have more control over user scripts. Default behaviour would still be the same - no filters applied on commands and operators. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (PIG-3765) Ability to disable Pig commands and operators
[ https://issues.apache.org/jira/browse/PIG-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911952#comment-13911952 ] Prashant Kommireddi commented on PIG-3765: -- 1. You are right, PigServer must handle this as well. 2. I felt it looked cleaner and more intuitive to change the signature. Having a setter for PigServer object seemed unnecessary after having looked at the way it was being used in the codebase so far. It's mostly 1 line changes in test cases, wasn't too hard to do it. What do you think? Ability to disable Pig commands and operators - Key: PIG-3765 URL: https://issues.apache.org/jira/browse/PIG-3765 Project: Pig Issue Type: New Feature Components: documentation, grunt Reporter: Prashant Kommireddi Assignee: Prashant Kommireddi Attachments: PIG-3765.patch, PIG-3765_2.patch This is an admin feature providing ability to blacklist or/and whitelist certain commands and operations. Pig exposes a few of these that could be not very safe in a multitenant environment. For example, sh invokes shell commands, set allows users to change non-final configs. While these are tremendously useful in general, having an ability to disable would make Pig a safer platform. The goal is to allow administrators to be able to have more control over user scripts. Default behaviour would still be the same - no filters applied on commands and operators. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (PIG-3765) Ability to disable Pig commands and operators
[ https://issues.apache.org/jira/browse/PIG-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13902244#comment-13902244 ] Prashant Kommireddi commented on PIG-3765: -- Doesn't include docs either, will have it in the next patch. Ability to disable Pig commands and operators - Key: PIG-3765 URL: https://issues.apache.org/jira/browse/PIG-3765 Project: Pig Issue Type: New Feature Components: documentation, grunt Reporter: Prashant Kommireddi Assignee: Prashant Kommireddi Attachments: PIG-3765.patch This is an admin feature providing ability to blacklist or/and whitelist certain commands and operations. Pig exposes a few of these that could be not very safe in a multitenant environment. For example, sh invokes shell commands, set allows users to change non-final configs. While these are tremendously useful in general, having an ability to disable would make Pig a safer platform. The goal is to allow administrators to be able to have more control over user scripts. Default behaviour would still be the same - no filters applied on commands and operators. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
