[jira] [Commented] (PIG-5286) Run verify_pig in e2e with old version of Pig
[ https://issues.apache.org/jira/browse/PIG-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137870#comment-16137870 ] Daniel Dai commented on PIG-5286: - Sounds good to me. Running verify_pig on old Pig is more natural. > Run verify_pig in e2e with old version of Pig > - > > Key: PIG-5286 > URL: https://issues.apache.org/jira/browse/PIG-5286 > Project: Pig > Issue Type: Bug >Reporter: Rohini Palaniswamy >Assignee: Rohini Palaniswamy > Fix For: 0.18.0 > > Attachments: PIG-5286-1.patch > > > Currently verify_pig runs a different equivalent script as the testcase but > runs with the same version of Pig. Ran into a issue where a test passed when > a bug was introduced and benchmark files were not present. The newly > generated benchmarks were also wrong. Caught the failure when running again > pointing to previously generated benchmarks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PIG-5286) Run verify_pig in e2e with old version of Pig
[ https://issues.apache.org/jira/browse/PIG-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117131#comment-16117131 ] Rohini Palaniswamy commented on PIG-5286: - bq. Then we need separate e2e test that simply run old-pig and current? Don't think so. Don't see a reason to have verify_pig run with same version. We usually use verify_pig when there is new code and the verify_pig script written is usually compatible with previous versions. It may only become a problem if one goes to a very old release. Considering that it can cause bugs to go unnoticed, I don't think we should be running verify_pig with the current version. > Run verify_pig in e2e with old version of Pig > - > > Key: PIG-5286 > URL: https://issues.apache.org/jira/browse/PIG-5286 > Project: Pig > Issue Type: Bug >Reporter: Rohini Palaniswamy >Assignee: Rohini Palaniswamy > Fix For: 0.18.0 > > Attachments: PIG-5286-1.patch > > > Currently verify_pig runs a different equivalent script as the testcase but > runs with the same version of Pig. Ran into a issue where a test passed when > a bug was introduced and benchmark files were not present. The newly > generated benchmarks were also wrong. Caught the failure when running again > pointing to previously generated benchmarks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PIG-5286) Run verify_pig in e2e with old version of Pig
[ https://issues.apache.org/jira/browse/PIG-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117117#comment-16117117 ] Koji Noguchi commented on PIG-5286: --- Then we need separate e2e test that simply run old-pig and current? Having verify_pig running with same versions has the benefit of having full control over the tests whereas relying on old-pig may or may not work depending on how old the base pig version is. > Run verify_pig in e2e with old version of Pig > - > > Key: PIG-5286 > URL: https://issues.apache.org/jira/browse/PIG-5286 > Project: Pig > Issue Type: Bug >Reporter: Rohini Palaniswamy >Assignee: Rohini Palaniswamy > Fix For: 0.18.0 > > Attachments: PIG-5286-1.patch > > > Currently verify_pig runs a different equivalent script as the testcase but > runs with the same version of Pig. Ran into a issue where a test passed when > a bug was introduced and benchmark files were not present. The newly > generated benchmarks were also wrong. Caught the failure when running again > pointing to previously generated benchmarks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PIG-5286) Run verify_pig in e2e with old version of Pig
[ https://issues.apache.org/jira/browse/PIG-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117091#comment-16117091 ] Rohini Palaniswamy commented on PIG-5286: - BagToTuple_1 and BagToString_1 are two other examples where output differs from previous versions. Even if the results were wrong we would have not caught it. > Run verify_pig in e2e with old version of Pig > - > > Key: PIG-5286 > URL: https://issues.apache.org/jira/browse/PIG-5286 > Project: Pig > Issue Type: Bug >Reporter: Rohini Palaniswamy >Assignee: Rohini Palaniswamy > Fix For: 0.18.0 > > Attachments: PIG-5286-1.patch > > > Currently verify_pig runs a different equivalent script as the testcase but > runs with the same version of Pig. Ran into a issue where a test passed when > a bug was introduced and benchmark files were not present. The newly > generated benchmarks were also wrong. Caught the failure when running again > pointing to previously generated benchmarks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PIG-5286) Run verify_pig in e2e with old version of Pig
[ https://issues.apache.org/jira/browse/PIG-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117088#comment-16117088 ] Rohini Palaniswamy commented on PIG-5286: - bq. We already run with old pig when separate script is not passed. Isn't that sufficient? That is good. But we need to do the same for all cases of verify_pig as well to avoid cases where a bug could produce same incorrect results in both the test script and verify_pig script. Since both are run with same version there is a possibility that could happen. Actually did this patch long ago (https://issues.apache.org/jira/secure/attachment/12847873/PIG-5072-2.patch), but had not followed up as I thought it was ok. But dusted and put this back up as I ran into an issue last week where a test passed during my patch testing when it should not have. > Run verify_pig in e2e with old version of Pig > - > > Key: PIG-5286 > URL: https://issues.apache.org/jira/browse/PIG-5286 > Project: Pig > Issue Type: Bug >Reporter: Rohini Palaniswamy >Assignee: Rohini Palaniswamy > Fix For: 0.18.0 > > Attachments: PIG-5286-1.patch > > > Currently verify_pig runs a different equivalent script as the testcase but > runs with the same version of Pig. Ran into a issue where a test passed when > a bug was introduced and benchmark files were not present. The newly > generated benchmarks were also wrong. Caught the failure when running again > pointing to previously generated benchmarks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PIG-5286) Run verify_pig in e2e with old version of Pig
[ https://issues.apache.org/jira/browse/PIG-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117074#comment-16117074 ] Koji Noguchi commented on PIG-5286: --- We already run with old pig when separate script is not passed. Isn't that sufficient? > Run verify_pig in e2e with old version of Pig > - > > Key: PIG-5286 > URL: https://issues.apache.org/jira/browse/PIG-5286 > Project: Pig > Issue Type: Bug >Reporter: Rohini Palaniswamy >Assignee: Rohini Palaniswamy > Fix For: 0.18.0 > > Attachments: PIG-5286-1.patch > > > Currently verify_pig runs a different equivalent script as the testcase but > runs with the same version of Pig. Ran into a issue where a test passed when > a bug was introduced and benchmark files were not present. The newly > generated benchmarks were also wrong. Caught the failure when running again > pointing to previously generated benchmarks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
