[GitHub] incubator-pirk issue #107: [WIP] PIRK-45 Remove dependency on Java serializa...
Github user wraydulany commented on the issue: https://github.com/apache/incubator-pirk/pull/107 Ok, changing to full PR. I should note for the record that the previously-working-for-me Pirk Releases also no longer pass the ES and ESS tests for me, another sign that It's Not My Fault. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-pirk issue #107: [WIP] PIRK-45 Remove dependency on Java serializa...
Github user wraydulany commented on the issue: https://github.com/apache/incubator-pirk/pull/107 Ok, I've expurgated references (import and comment) to jackson in the code, and I've run the style checker against the code i touched. Additionally, I've investigated the problems with the 1:ES and 1:ESS tests that I'm having, and I'm convinced that they are due to misconfiguration of the cluster I'm testing on. This passes the build tests and distributed tests 1:J, 1:JS, 1:JSS, 1:SS, and 1:E for me. If anyone has been able to successfully execute the 1:ES and/or 1:ESS tests with this PR *and* fail them, please comment and kill this PR. Otherwise, I'm going to move this from WIP to full PR in the late morning on the US East Coast tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-pirk issue #107: [WIP] PIRK-45 Remove dependency on Java serializa...
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/107 A couple of general comments - (1) need to remove the Jackson imports and dependency as it GSON is being used (2) need to format with the Pirk codestyle file. I'll take a look at the ES issues... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-pirk issue #107: [WIP] PIRK-45 Remove dependency on Java serializa...
Github user wraydulany commented on the issue: https://github.com/apache/incubator-pirk/pull/107 Fixed the `import...*` and also removed some code garbage that i'd commented out, from an earlier attempt to use jackson, an attempt killed by spark and its ancient version of jackson. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
