[BUILD-FAILURE]: Job 'PLC4X/PLC4X/develop [develop] [1478]'
BUILD-FAILURE: Job 'PLC4X/PLC4X/develop [develop] [1478]': Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/1478/;>PLC4X/PLC4X/develop [develop] [1478]"
Re: [PR] Add support of PlcDINT for BigInteger in PlcValueHandler (plc4x)
splatch commented on PR #962: URL: https://github.com/apache/plc4x/pull/962#issuecomment-1575227300 @chrisdutz if you're ok with changes (PlcLINT is in place) I'd proceed with merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat(plc4j) Better handling of timeouts in plc4j (#821). (plc4x)
splatch commented on PR #822: URL: https://github.com/apache/plc4x/pull/822#issuecomment-1575226211 This PR was open for quite long time. I'm going to address @spnettec review comments in separate change set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat(plc4j) Better handling of timeouts in plc4j (#821). (plc4x)
splatch merged PR #822: URL: https://github.com/apache/plc4x/pull/822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [D] [Java] How should we handle "loggers"? (plc4x)
Hello, Totally agree on equalizing the use of logs (log, LOG, logger, LOGGER), and so on... If there is a best practice that does not imply adding more libraries to the existing ones, we should evaluate it. Kind regards, El sáb, 3 jun 2023 a las 17:18, Łukasz Dywicki () escribió: > The static logger declaration is still a thing made by (older/elder? ;)) > java developers, mainly because log4j 1.x/commons-logging/jul loggers > were advised to be made like that. With switch to slf4j static is no > longer mandatory/strongly recommended. > Most of code I make myself rely on logger field, but I've seen people > who do it with `@Slf4j` annotation coming from Lombok. > > Anyhow, is there a intention (not yet a plan) to unify this part of our > code? > > Best, > Łukasz > > On 2.06.2023 08:35, chrisdutz (via GitHub) wrote: > > > > GitHub user chrisdutz added a comment to the discussion: [Java] How > should we handle "loggers"? > > > > And here ... even the Slf4j folks no longer recommend any general way of > doing things: https://www.slf4j.org/faq.html#declared_static > > I guess in the past, there was a performance reason to to things, but > this no longer seems to apply today. > > > > GitHub link: > https://github.com/apache/plc4x/discussions/973#discussioncomment-6068178 > > > > > > This is an automatically sent email for dev@plc4x.apache.org. > > To unsubscribe, please send an email to: > dev-unsubscr...@plc4x.apache.org > > > -- *CEOS Automatización, C.A.* *GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,* *PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,* *FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI* *Ing. César García* *Cel: +58 414-760.98.95* *Hotline Técnica SIEMENS: 0800 1005080* *Email: support.aan.automat...@siemens.com *
Re: [D] [Java] How should we handle "loggers"? (plc4x)
The static logger declaration is still a thing made by (older/elder? ;)) java developers, mainly because log4j 1.x/commons-logging/jul loggers were advised to be made like that. With switch to slf4j static is no longer mandatory/strongly recommended. Most of code I make myself rely on logger field, but I've seen people who do it with `@Slf4j` annotation coming from Lombok. Anyhow, is there a intention (not yet a plan) to unify this part of our code? Best, Łukasz On 2.06.2023 08:35, chrisdutz (via GitHub) wrote: GitHub user chrisdutz added a comment to the discussion: [Java] How should we handle "loggers"? And here ... even the Slf4j folks no longer recommend any general way of doing things: https://www.slf4j.org/faq.html#declared_static I guess in the past, there was a performance reason to to things, but this no longer seems to apply today. GitHub link: https://github.com/apache/plc4x/discussions/973#discussioncomment-6068178 This is an automatically sent email for dev@plc4x.apache.org. To unsubscribe, please send an email to: dev-unsubscr...@plc4x.apache.org
[BUILD-UNSTABLE]: Job 'PLC4X/PLC4X/develop [develop] [1477]'
BUILD-UNSTABLE: Job 'PLC4X/PLC4X/develop [develop] [1477]': Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/1477/;>PLC4X/PLC4X/develop [develop] [1477]"
[BUILD-UNSTABLE]: Job 'PLC4X/PLC4X/develop [develop] [1476]'
BUILD-UNSTABLE: Job 'PLC4X/PLC4X/develop [develop] [1476]': Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/1476/;>PLC4X/PLC4X/develop [develop] [1476]"
