[GitHub] [plc4x] foxpluto opened a new pull request #183: Use Gradle with compiled library

[GitBox]

foxpluto opened a new pull request #183:
URL: https://github.com/apache/plc4x/pull/183


   HI,
   
   I have added a little description of how to use the compiled library with 
Gradle. 
   
   Regards,
   S.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] ottlukas merged pull request #183: Use Gradle with compiled library

[GitBox]

ottlukas merged pull request #183:
URL: https://github.com/apache/plc4x/pull/183


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] niclash commented on pull request #186: Feature/modbus data type

[GitBox]

niclash commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-690872320


   I have also seen 32-bit integers. Maybe it should be available too.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb commented on pull request #186: Feature/modbus data type

[GitBox]

hutcheb commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-691032464


   Hi Niclas,
   
   The plan is to add support for as many IEC 61131 data types as possible. 
I've added DINT as an example for what it would take to add additional data 
types but will wait for more feedback before adding more.
   
   Ben
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb opened a new pull request #186: Feature/modbus data type

[GitBox]

hutcheb opened a new pull request #186:
URL: https://github.com/apache/plc4x/pull/186


   Add support for BOOL, INT, UINT and REAL data types for the Modbus protocol.
   address string can now include any of these types such as:- 
holding-register:10:REAL[10], extended-register:10:UINT[10].
   Note the previous format now defaults to BOOL or INT depending on the memory 
area.
   
   Add support to parse values from Java Strings to any of these types. This 
fixes a bug in the hello-world example when writing.
   
   Add support for BOOL, INT, UINT and REAL PlcValue types. This have been 
added as we are able to include the max/min value checks and casting of the 
input type within the constructors cleaning up the ModbusFieldHandler logic. 
The method getBytes has also been added to clean up the ModbusProtocolLogic 
class.
   
   I'll add Documentation once the other Modbus Documentation PR has been 
finalized.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] splatch merged pull request #185: PLC4X-248 Permit more locations for MSpec comments.

[GitBox]

splatch merged pull request #185:
URL: https://github.com/apache/plc4x/pull/185


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb commented on pull request #186: Feature/modbus data type

[GitBox]

hutcheb commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-691032464







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb commented on pull request #186: Feature/modbus data type

[GitBox]

hutcheb commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-691032464







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] niclash commented on pull request #186: Feature/modbus data type

[GitBox]

niclash commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-690872320







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] niclash commented on pull request #186: Feature/modbus data type

[GitBox]

niclash commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-690872320







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on a change in pull request #186: Feature/modbus data type

[GitBox]

chrisdutz commented on a change in pull request #186:
URL: https://github.com/apache/plc4x/pull/186#discussion_r487711822



##
File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcDINT.java
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.plc4x.java.api.value;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonIgnore;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonTypeInfo;
+import org.apache.plc4x.java.api.exceptions.PlcIncompatibleDatatypeException;
+
+import org.apache.plc4x.java.api.value.*;
+
+import java.math.BigDecimal;
+import java.math.BigInteger;
+import java.util.LinkedList;
+import java.util.List;
+
+@JsonTypeInfo(use = JsonTypeInfo.Id.CLASS, property = "className")
+public class PlcDINT extends PlcIECValue {
+
+BigInteger minValue = BigInteger.valueOf((long) Integer.MIN_VALUE);
+BigInteger maxValue = BigInteger.valueOf((long) Integer.MAX_VALUE);

Review comment:
   Same as with PlcBOOL (And probably all others) 

##
File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcBOOL.java
##
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.plc4x.java.api.value;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonIgnore;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonTypeInfo;
+import org.apache.plc4x.java.api.exceptions.PlcInvalidFieldException;
+
+import org.apache.plc4x.java.api.value.*;
+
+import java.math.BigDecimal;
+import java.math.BigInteger;
+
+@JsonTypeInfo(use = JsonTypeInfo.Id.CLASS, property = "className")
+public class PlcBOOL extends PlcIECValue {
+
+BigInteger minValue = BigInteger.valueOf(0);
+BigInteger maxValue = BigInteger.valueOf(1);

Review comment:
   Could we perhaps make these static ... A BigInteger is a pretty big type 
and creating these for every boolean PlcValue seems wasting memory and CPU time 
for cleaning up.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on pull request #187: add initial class and test

[GitBox]

chrisdutz commented on pull request #187:
URL: https://github.com/apache/plc4x/pull/187#issuecomment-691908870


   As I have almost no Python skills, I'm not sure my review would be worth 
much ...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] ottlukas merged pull request #187: add initial class and test

[GitBox]

ottlukas merged pull request #187:
URL: https://github.com/apache/plc4x/pull/187


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb opened a new pull request #184: Modbus/update documentation

[GitBox]

hutcheb opened a new pull request #184:
URL: https://github.com/apache/plc4x/pull/184


   Updated the Modbus documentation including references to the starting 
addresses and extended registers.
   I have also included the headers used in the S7 protocol documentation to 
help keep it a bit more consistent between different protocols.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] splatch commented on pull request #182: PLC4X-244 Support for variable length padding fields.

[GitBox]

splatch commented on pull request #182:
URL: https://github.com/apache/plc4x/pull/182#issuecomment-684965544


   Good spot on naming, I did a blind change trying to keep it close to initial 
names. Anyhow, thanks for taking care of this!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on a change in pull request #170: PLC4X-207 When a Handler Timeout occurs cancel the read future to not…

[GitBox]

chrisdutz commented on a change in pull request #170:
URL: https://github.com/apache/plc4x/pull/170#discussion_r481211814



##
File path: 
plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java
##
@@ -299,6 +319,14 @@ public void onConnect(ConversationContext 
context) {
 return future;
 }
 
+/**
+ * This method is only called when there is no Response Handler.
+ */
+@Override
+protected void decode(ConversationContext context, TPKTPacket 
msg) throws Exception {
+throw new IllegalStateException("This should not happen!");

Review comment:
   Just today did I push some changes that should help greatly with the 
decoding of errors in S7 ... the main problem was, that in case of an error, 
the response is not a S7MessageResponseData type, but a S7MessageResponse 
(without Data) ... I changed the code to wait for a S7Message with the given 
PDU Id and to handle that then ... so I think most bad errors were due to this 
... perhaps the problem now will go away.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on pull request #182: PLC4X-244 Support for variable length padding fields.

[GitBox]

chrisdutz commented on pull request #182:
URL: https://github.com/apache/plc4x/pull/182#issuecomment-684905262


   Just saw that due to the nature of C ... you found all the places that 
needed adjusting ... thank you very much :-)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz edited a comment on pull request #67: poll loop fetches data in a continous loop

[GitBox]

chrisdutz edited a comment on pull request #67:
URL: https://github.com/apache/plc4x/pull/67#issuecomment-684925891


   Guess it doesn't harm adding this example ... perhaps it helps someone ... 
however I am not sure if we would need an ICLA on file for this contribution.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on pull request #178: Fix ToAnsi method : bufferoverflow

[GitBox]

chrisdutz commented on pull request #178:
URL: https://github.com/apache/plc4x/pull/178#issuecomment-684920366


   Hi Johanna, 
   
   sorry for me picking this up so late ... I just had a look ... your code 
changes generally look good, and I'm not going to insist on tests as in that 
case I would have to reject most of my stuff to ;-)
   
   Does the driver work with your changes? Are you able to read with multiple 
"." in them? I'm asking this stupid questions as I don't know the protocol and 
want to understand if this just makes the Execption go away.
   
   Chris



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on pull request #67: poll loop fetches data in a continous loop

[GitBox]

chrisdutz commented on pull request #67:
URL: https://github.com/apache/plc4x/pull/67#issuecomment-684925891


   Guess it doesn't harm adding this example ... perhaps it helps someone ...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on pull request #182: PLC4X-244 Support for variable length padding fields.

[GitBox]

chrisdutz commented on pull request #182:
URL: https://github.com/apache/plc4x/pull/182#issuecomment-684899684


   I will probably need to add something to the size-calculation in C too, but 
I'll take care of this. Perhaps also change the name of the varialbe from 
"needsPadding" to "numPading" or similar ... "needs" sounds binary to me.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz merged pull request #182: PLC4X-244 Support for variable length padding fields.

[GitBox]

chrisdutz merged pull request #182:
URL: https://github.com/apache/plc4x/pull/182


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on pull request #170: PLC4X-207 When a Handler Timeout occurs cancel the read future to not…

[GitBox]

chrisdutz commented on pull request #170:
URL: https://github.com/apache/plc4x/pull/170#issuecomment-684924829


   So right now I think we could probably add a test ... I do not want to force 
Julian to dig into my IT framework ... if you could explain the situation in 
which this code would kick in, I could probably come up with a testcase.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] ottobackwards opened a new pull request #187: add initial class and test

[GitBox]

ottobackwards opened a new pull request #187:
URL: https://github.com/apache/plc4x/pull/187


   Created simple shell implementation for PlcManager, PlcConnection, and a 
test that shows some mocking and tests context manager functionality



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb opened a new pull request #193: Add support for writing arrays to the hello world write example.

[GitBox]

hutcheb opened a new pull request #193:
URL: https://github.com/apache/plc4x/pull/193


   This allows us to pass an array of values to the hello world write example. 
The format is
   
   --field-addresses 04:BOOL[2] --field-values [true,true]
   --field-addresses 44:LINT[2] --field-values [1,1]
   
   can be used.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] splatch opened a new pull request #195: Beckhoff Device Discovery structures

[GitBox]

splatch opened a new pull request #195:
URL: https://github.com/apache/plc4x/pull/195


   Given that I need to park this one for a moment and I managed to test and 
collect extra data for TC3 as well as extra sample for TC2 further work can 
continue on develop branch.
   Discovery is based on UDP so requires separate discovery driver 
implementation. To start with this task we need to fully understand rest of 
discovery response frame which is used to identify device operating system and 
twincat runtime version. I made some comments in serializer XML tests for 
further investigation.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb commented on a change in pull request #192: Refactor Field Handler Classes

[GitBox]

hutcheb commented on a change in pull request #192:
URL: https://github.com/apache/plc4x/pull/192#discussion_r500131203



##
File path: 
plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcValues.java
##
@@ -355,6 +356,28 @@ public static PlcValue of(Map map) {
 return new PlcStruct(map);
 }
 
+private static PlcValue constructorHelper(Constructor constructor, 
Object value) {
+try {
+return (PlcValue) constructor.newInstance(value);
+} catch (InstantiationException | IllegalAccessException | 
InvocationTargetException e) {
+throw new PlcIncompatibleDatatypeException(value.getClass());
+}
+}
+
+public static PlcValue of(Object[] values, Class clazz) {
+//Encode values to the type defined in clazz
+try {
+Constructor constructor = 
clazz.getDeclaredConstructor(values[0].getClass());
+if(values.length == 1) {
+return ((PlcValue) constructor.newInstance(values[0]));
+} else {
+return PlcValues.of(Arrays.stream(values).map(value -> 
(constructorHelper(constructor, value))).collect(Collectors.toList()));
+}

Review comment:
   The exception would be raised if there wasn't a class (PlcBYTE, PlcINT, 
etc..) that matched the datatype that was passed. It shouldn't be raised in 
normal operation. 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb commented on a change in pull request #192: Refactor Field Handler Classes

[GitBox]

hutcheb commented on a change in pull request #192:
URL: https://github.com/apache/plc4x/pull/192#discussion_r500139132



##
File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcBYTE.java
##
@@ -169,6 +169,30 @@ public PlcBYTE(@JsonProperty("value") short value) {
 }
 }
 
+@Override
+@JsonIgnore
+public boolean isBoolean() {
+return true;
+}
+
+@Override
+@JsonIgnore
+public boolean getBoolean() {
+return (value != null) && !value.equals(0);
+}

Review comment:
   I was having trouble with how we would do this. I was initially thinking 
that if we request to read a WORD we should parse the return value as a PlcList 
of PlcBOOLs instead of a PlcWORD but wasn't sure how to implement this easily.
   
   But your idea of returning a list from a getBoolean method seems reasonable.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb commented on a change in pull request #192: Refactor Field Handler Classes

[GitBox]

hutcheb commented on a change in pull request #192:
URL: https://github.com/apache/plc4x/pull/192#discussion_r500144795



##
File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcBYTE.java
##
@@ -181,6 +205,90 @@ public short getShort() {
 return value;
 }
 
+@Override
+@JsonIgnore
+public boolean isInteger() {
+return true;
+}
+
+@Override
+@JsonIgnore
+public int getInteger() {
+return value.intValue();
+}
+

Review comment:
   I think there a at least two use cases for these methods. To use them 
when parsing the value within the dataio classes. The other is by the user when 
they need to parse the value to a specific type. 
   
   A generic function to be used when parsing like getValue() would be good.
   
   For the user the getInteger, getByte, etc.. might be good as I can't think 
of an easy way to pass a type to the function and have it return the data type 
requested without just putting the existing functions within a switch statement.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on a change in pull request #192: Refactor Field Handler Classes

[GitBox]

chrisdutz commented on a change in pull request #192:
URL: https://github.com/apache/plc4x/pull/192#discussion_r500057457



##
File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcBYTE.java
##
@@ -169,6 +169,30 @@ public PlcBYTE(@JsonProperty("value") short value) {
 }
 }
 
+@Override
+@JsonIgnore
+public boolean isBoolean() {
+return true;
+}
+
+@Override
+@JsonIgnore
+public boolean getBoolean() {
+return (value != null) && !value.equals(0);
+}
+
+@Override
+@JsonIgnore
+public boolean isByte() {
+return (value != null) && (value <= Byte.MAX_VALUE) && (value >= 
Byte.MIN_VALUE);
+}
+
+@Override
+@JsonIgnore
+public byte getByte() {
+return value.byteValue();
+}
+

Review comment:
   We now have a "byte getByte()" and a "short getBYTE()" method, I think 
it should only be the one or the other ... I would like to opt for the "byte 
getByte()". But right now I'm unsure which implications that would have.

##
File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcBYTE.java
##
@@ -169,6 +169,30 @@ public PlcBYTE(@JsonProperty("value") short value) {
 }
 }
 
+@Override
+@JsonIgnore
+public boolean isBoolean() {
+return true;
+}
+
+@Override
+@JsonIgnore
+public boolean getBoolean() {
+return (value != null) && !value.equals(0);
+}

Review comment:
   In general a bit-string (at least in my perception of it, represents an 
array of booleans. So if for example I read one byte, from the point of the API 
it should be a list of 8 boolean values ... I think we need to allow this 
somehow. Right now the only way would be to get the "byte" value and to pick 
that appart.

##
File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcBYTE.java
##
@@ -181,6 +205,90 @@ public short getShort() {
 return value;
 }
 
+@Override
+@JsonIgnore
+public boolean isInteger() {
+return true;
+}
+
+@Override
+@JsonIgnore
+public int getInteger() {
+return value.intValue();
+}
+

Review comment:
   Instead of adding these for every type, wouldn't it make sense to have 
something like a "PlcIECBitStringValue", "PlcIECIntegerValue", ...?

##
File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcBYTE.java
##
@@ -181,6 +205,90 @@ public short getShort() {
 return value;
 }
 
+@Override
+@JsonIgnore
+public boolean isInteger() {
+return true;
+}
+
+@Override
+@JsonIgnore
+public int getInteger() {
+return value.intValue();
+}
+

Review comment:
   But thinking of it ... perhaps making it generic and passing in the type 
would help ... 

##
File path: 
plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcValues.java
##
@@ -355,6 +356,28 @@ public static PlcValue of(Map map) {
 return new PlcStruct(map);
 }
 
+private static PlcValue constructorHelper(Constructor constructor, 
Object value) {
+try {
+return (PlcValue) constructor.newInstance(value);
+} catch (InstantiationException | IllegalAccessException | 
InvocationTargetException e) {
+throw new PlcIncompatibleDatatypeException(value.getClass());
+}
+}
+
+public static PlcValue of(Object[] values, Class clazz) {
+//Encode values to the type defined in clazz
+try {
+Constructor constructor = 
clazz.getDeclaredConstructor(values[0].getClass());
+if(values.length == 1) {
+return ((PlcValue) constructor.newInstance(values[0]));
+} else {
+return PlcValues.of(Arrays.stream(values).map(value -> 
(constructorHelper(constructor, value))).collect(Collectors.toList()));
+}

Review comment:
   One thing I've learnt recently, is that exceptions are extremely 
expensive, as creating the stack trace is expensive. is this code that is 
likely to produce any of "InstantiationException | IllegalAccessException | 
InvocationTargetException | NoSuchMethodException" in normal execution? If yes, 
we should probably change this and other parts where we use similar patterns to 
check first instead of silently catching exceptions.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb commented on a change in pull request #192: Refactor Field Handler Classes

[GitBox]

hutcheb commented on a change in pull request #192:
URL: https://github.com/apache/plc4x/pull/192#discussion_r500123620



##
File path: plc4j/api/src/main/java/org/apache/plc4x/java/api/value/PlcBYTE.java
##
@@ -169,6 +169,30 @@ public PlcBYTE(@JsonProperty("value") short value) {
 }
 }
 
+@Override
+@JsonIgnore
+public boolean isBoolean() {
+return true;
+}
+
+@Override
+@JsonIgnore
+public boolean getBoolean() {
+return (value != null) && !value.equals(0);
+}
+
+@Override
+@JsonIgnore
+public boolean isByte() {
+return (value != null) && (value <= Byte.MAX_VALUE) && (value >= 
Byte.MIN_VALUE);
+}
+
+@Override
+@JsonIgnore
+public byte getByte() {
+return value.byteValue();
+}
+

Review comment:
   There's no reason to have the getBYTE,getINT,getREAL,etc... they don't 
get used anymore. I added these in the previous PR so we can customize the 
method that gets called in the data-io template by using the case name.  





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb commented on pull request #192: Refactor Field Handler Classes

[GitBox]

hutcheb commented on pull request #192:
URL: https://github.com/apache/plc4x/pull/192#issuecomment-703242394


   Bit of a mismatch of a bunch of issues:-
   - Implemented WriteBuffer - Big Integer and floating point functions.
   - Implemented staticserialzer support for PlcLists
   - Moved Modbus to use the static serialiser so as not to duplicate 
serializing code
   - Refactored the field handler code, esp for Modbus, no uses a class lookup 
within PlcValues. Other protocols haven't been tested.
   - Added support within the hello world write example for writing arrays.
   - Fix for bit lengths within the WriteBuffer writeXXX functions.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb commented on pull request #194: Add an OPC UA Server

[GitBox]

hutcheb commented on pull request #194:
URL: https://github.com/apache/plc4x/pull/194#issuecomment-707077234


   It is definitely usable but somethings to improve on:-
   - Security isn't implemented.
   - Arrays should probably be a list of nodes in OPCUA instead of a single one.
   - Discovery doesn't seem to work.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz merged pull request #192: Refactor Field Handler Classes

[GitBox]

chrisdutz merged pull request #192:
URL: https://github.com/apache/plc4x/pull/192


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb merged pull request #194: Add an OPC UA Server

[GitBox]

hutcheb merged pull request #194:
URL: https://github.com/apache/plc4x/pull/194


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] splatch merged pull request #195: Beckhoff Device Discovery structures

[GitBox]

splatch merged pull request #195:
URL: https://github.com/apache/plc4x/pull/195


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb opened a new pull request #194: Add an OPC UA Server

[GitBox]

hutcheb opened a new pull request #194:
URL: https://github.com/apache/plc4x/pull/194


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz opened a new pull request #181: Feature/plc4c

[GitBox]

chrisdutz opened a new pull request #181:
URL: https://github.com/apache/plc4x/pull/181


   Working on implementing the S7 and the Modbus driver using the generated 
code.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] splatch opened a new pull request #182: PLC4X-244 Support for variable length padding fields.

[GitBox]

splatch opened a new pull request #182:
URL: https://github.com/apache/plc4x/pull/182


   Padding expression must now evaluate to an integer specifying how many times 
'padding' field needs to be read or written to the buffer.
   
   S7 parser tests are fine with this change as well as my experiments with 
socketcan payloads.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] ottobackwards merged pull request #180: PLC4X-236 Pre-Commit and Hinting Configuration for python

[GitBox]

ottobackwards merged pull request #180:
URL: https://github.com/apache/plc4x/pull/180


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] ottobackwards merged pull request #179: Feature/plc4py

[GitBox]

ottobackwards merged pull request #179:
URL: https://github.com/apache/plc4x/pull/179


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] ottobackwards commented on pull request #180: PLC4X-236 Pre-Commit and Hinting Configuration for python

[GitBox]

ottobackwards commented on pull request #180:
URL: https://github.com/apache/plc4x/pull/180#issuecomment-677762209


   @vemmert -
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] ottobackwards opened a new pull request #180: PLC4X-236 Pre-Commit and Hinting Configuration for python

[GitBox]

ottobackwards opened a new pull request #180:
URL: https://github.com/apache/plc4x/pull/180


   black, mypy and pre-commit. pre-commit is added as a dev dependency in poetry
   
   To enable these hooks ->
   
   - pip install pre-commit
   - pre-commit install
   
   Please see [pre-commit](https://pre-commit.com/#usage)
   
   A local .gitignore specific to python was also added



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on pull request #108: Pubish Subscribe support for S7

[GitBox]

chrisdutz commented on pull request #108:
URL: https://github.com/apache/plc4x/pull/108#issuecomment-700598552


   I guess Cesar is currently consumed with other work topics ... if this is a 
high priority requirement for you and your company you could consider 
contracting someone of the community to work on this (I for my part don't have 
the necessary hardware ... my S7-1200 doesn't support this form of 
communication)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] mahendra-korat commented on pull request #108: Pubish Subscribe support for S7

[GitBox]

mahendra-korat commented on pull request #108:
URL: https://github.com/apache/plc4x/pull/108#issuecomment-700594490


   Any progress on this? I need to start trials with my PLCs.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] glcj commented on pull request #108: Pubish Subscribe support for S7

[GitBox]

glcj commented on pull request #108:
URL: https://github.com/apache/plc4x/pull/108#issuecomment-700748393


   Hello,
   
   The features noted are functional in version 0.6.1 (actually the "s7alarm" 
branch).
   
   The software is tested for S7-300 & S7-400. 
   
   S7-1500 and S7-1200 stations use or do not have a notification system.
   
   By next week I must finish the tests on an S7-400H system, which would 
transform this version of the driver into the most complete one outside the 
Siemens ecosystem.
   
   As Chris points out, the next step is to go to the mspec, which is an 
interesting job, but needs to be funded as you point out.
   
   I will be happy to help you with testing, documenting everything on the 
PLC4X mailing list.
   
   Best regards,



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb opened a new pull request #192: Refactor Field Handler Classes

[GitBox]

hutcheb opened a new pull request #192:
URL: https://github.com/apache/plc4x/pull/192


   First attempt at refactoring the field handler class, currently 
troubleshooting issue with new PlcValue of method.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb opened a new pull request #191: Implement WriteBuffer float, double and BigInteger functions

[GitBox]

hutcheb opened a new pull request #191:
URL: https://github.com/apache/plc4x/pull/191


   Initial commit, hasn't been tested at all.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] ottlukas merged pull request #189: PLC4X-250 python Namespace refactor

[GitBox]

ottlukas merged pull request #189:
URL: https://github.com/apache/plc4x/pull/189


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on pull request #186: Feature/modbus data type

[GitBox]

chrisdutz commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-695931480


   Hi Ben,
   
   will do so asap …
   
   Chris
   
   Von: hutcheb 
   Antworten an: apache/plc4x 
   Datum: Samstag, 19. September 2020 um 13:30
   An: apache/plc4x 
   Cc: Christofer Dutz , Comment 

   Betreff: Re: [apache/plc4x] Feature/modbus data type (#186)
   
   
   Hi Chris,
   
   This should be in a position for you to review.
   
   Ben
   
   —
   You are receiving this because you commented.
   Reply to this email directly, view it on 
GitHub, or 
unsubscribe.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] anup-km commented on pull request #36: Add simple mock driver

[GitBox]

anup-km commented on pull request #36:
URL: https://github.com/apache/plc4x/pull/36#issuecomment-695914069


   Hi @JulianFeinauer , I got some PLC4X connection error while running .jar 
file in command prompt, but when I run the same source code on the IntelliJ 
environment its getting executing properly and working properly. I gone through 
the error by debugging and got this 
"org.apache.plc4x.java.spi.transport.Transport" for this interface the IntelliJ 
is providing the .class implementation. How to run on the command prompt, 
please help me out.
   ![Screenshot 
(17)](https://user-images.githubusercontent.com/71625115/93736041-bda10c00-fbfc-11ea-811b-480633fccab7.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb commented on pull request #186: Feature/modbus data type

[GitBox]

hutcheb commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-696058599


   Hi,
   
   I was looking at starting to use the staticSerialize method for Modbus as it 
would reduce the fromPLCValue method. However there are a few methods in the 
WriteBuffer class that aren't implemented. writeDouble and the writeBigInteger 
functions. The writeDouble function in particular would cause issues with 
writing floats of any kind for all protocols that use it.
   
   Does writing floats with the S7 protocol work or am I missing something?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] anup-km commented on pull request #36: Add simple mock driver

[GitBox]

anup-km commented on pull request #36:
URL: https://github.com/apache/plc4x/pull/36#issuecomment-698079911


   > Hi @JulianFeinauer , I got some PLC4X connection error while running .jar 
file in command prompt, but when I run the same source code on the IntelliJ 
environment its getting executing properly and working properly. I gone through 
the error by debugging and got this 
"org.apache.plc4x.java.spi.transport.Transport" for this interface the IntelliJ 
is providing the .class implementation. How to run on the command prompt, 
please help me out.
   > ![Screenshot 
(17)](https://user-images.githubusercontent.com/71625115/93736041-bda10c00-fbfc-11ea-811b-480633fccab7.png)
   
   Hi any update on this..



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb commented on a change in pull request #191: Implement WriteBuffer float, double and BigInteger functions

[GitBox]

hutcheb commented on a change in pull request #191:
URL: https://github.com/apache/plc4x/pull/191#discussion_r494920825



##
File path: 
plc4j/drivers/knxnetip/src/main/java/org/apache/plc4x/java/knxnetip/utils/KnxHelper.java
##
@@ -46,9 +46,16 @@ public static void f16toBytes(WriteBuffer io, Object param) {
 boolean negative = value < 0;
 final int exponent = Math.getExponent(value);
 final double mantissa = value / Math.pow(2, exponent);
+//io.writeBit(negative);
+//io.writeInt(4, exponent);
+//io.writeDouble(11, Math.getExponent(mantissa), mantissa); 
//Don't think this works BH
+
+String mantissaString = Double.toString(mantissa);
+int mantissaInteger = 
Integer.parseInt(mantissaString.substring(mantissaString.indexOf('.')));

Review comment:
   The string conversion is to get the digits after the decimal place of 
the mantissa as part of writing a 16-bit float.
   (In my head the mantissa is always going to have a one before the decimal 
place which can be discarded)
   The digits after are then converted to an integer to be written as the 
manitssa part.
   
   I haven't tested this part of it, it has a slight chance of working for most 
cases but not all. I'll create a 16-bit floating point PlcValue at some point 
and test it with Modbus and then move it over to the KNX protocol as a custom 
PlcValue.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on a change in pull request #191: Implement WriteBuffer float, double and BigInteger functions

[GitBox]

chrisdutz commented on a change in pull request #191:
URL: https://github.com/apache/plc4x/pull/191#discussion_r494808810



##
File path: 
plc4j/drivers/knxnetip/src/main/java/org/apache/plc4x/java/knxnetip/utils/KnxHelper.java
##
@@ -46,9 +46,16 @@ public static void f16toBytes(WriteBuffer io, Object param) {
 boolean negative = value < 0;
 final int exponent = Math.getExponent(value);
 final double mantissa = value / Math.pow(2, exponent);
+//io.writeBit(negative);
+//io.writeInt(4, exponent);
+//io.writeDouble(11, Math.getExponent(mantissa), mantissa); 
//Don't think this works BH
+
+String mantissaString = Double.toString(mantissa);
+int mantissaInteger = 
Integer.parseInt(mantissaString.substring(mantissaString.indexOf('.')));

Review comment:
   What's the String conversion for? I think in this case a simple 
double-to-int-cast should do the trick 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x-build-tools] chrisdutz commented on pull request #4: More content about MSpec, its use and overall structure.

[GitBox]

chrisdutz commented on pull request #4:
URL: https://github.com/apache/plc4x-build-tools/pull/4#issuecomment-698776318


   But I just noticed ... this is only in the build tools in the site testsuite 
... this will never find it's way into the main website ...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x-build-tools] chrisdutz commented on pull request #4: More content about MSpec, its use and overall structure.

[GitBox]

chrisdutz commented on pull request #4:
URL: https://github.com/apache/plc4x-build-tools/pull/4#issuecomment-698775703


   Thanks for this :-) Highly appreciated :-)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x-build-tools] chrisdutz merged pull request #4: More content about MSpec, its use and overall structure.

[GitBox]

chrisdutz merged pull request #4:
URL: https://github.com/apache/plc4x-build-tools/pull/4


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] anup-km commented on pull request #36: Add simple mock driver

[GitBox]

anup-km commented on pull request #36:
URL: https://github.com/apache/plc4x/pull/36#issuecomment-698079911


   > Hi @JulianFeinauer , I got some PLC4X connection error while running .jar 
file in command prompt, but when I run the same source code on the IntelliJ 
environment its getting executing properly and working properly. I gone through 
the error by debugging and got this 
"org.apache.plc4x.java.spi.transport.Transport" for this interface the IntelliJ 
is providing the .class implementation. How to run on the command prompt, 
please help me out.
   > ![Screenshot 
(17)](https://user-images.githubusercontent.com/71625115/93736041-bda10c00-fbfc-11ea-811b-480633fccab7.png)
   
   Hi any update on this..



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb commented on a change in pull request #191: Implement WriteBuffer float, double and BigInteger functions

[GitBox]

hutcheb commented on a change in pull request #191:
URL: https://github.com/apache/plc4x/pull/191#discussion_r494920825



##
File path: 
plc4j/drivers/knxnetip/src/main/java/org/apache/plc4x/java/knxnetip/utils/KnxHelper.java
##
@@ -46,9 +46,16 @@ public static void f16toBytes(WriteBuffer io, Object param) {
 boolean negative = value < 0;
 final int exponent = Math.getExponent(value);
 final double mantissa = value / Math.pow(2, exponent);
+//io.writeBit(negative);
+//io.writeInt(4, exponent);
+//io.writeDouble(11, Math.getExponent(mantissa), mantissa); 
//Don't think this works BH
+
+String mantissaString = Double.toString(mantissa);
+int mantissaInteger = 
Integer.parseInt(mantissaString.substring(mantissaString.indexOf('.')));

Review comment:
   The string conversion is to get the digits after the decimal place of 
the mantissa as part of writing a 16-bit float.
   (In my head the mantissa is always going to have a one before the decimal 
place which can be discarded)
   The digits after are then converted to an integer to be written as the 
manitssa part.
   
   I haven't tested this part of it, it has a slight chance of working for most 
cases but not all. I'll create a 16-bit floating point PlcValue at some point 
and test it with Modbus and then move it over to the KNX protocol as a custom 
PlcValue.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x-build-tools] chrisdutz merged pull request #4: More content about MSpec, its use and overall structure.

[GitBox]

chrisdutz merged pull request #4:
URL: https://github.com/apache/plc4x-build-tools/pull/4


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x-build-tools] chrisdutz commented on pull request #4: More content about MSpec, its use and overall structure.

[GitBox]

chrisdutz commented on pull request #4:
URL: https://github.com/apache/plc4x-build-tools/pull/4#issuecomment-698775703







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on pull request #186: Feature/modbus data type

[GitBox]

chrisdutz commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-698989556


   The PR #190 now contains all changes of this PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz closed pull request #186: Feature/modbus data type

[GitBox]

chrisdutz closed pull request #186:
URL: https://github.com/apache/plc4x/pull/186


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] asfgit merged pull request #190: Feature/write extended registers

[GitBox]

asfgit merged pull request #190:
URL: https://github.com/apache/plc4x/pull/190


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz merged pull request #188: Modbus Data Type Documentation

[GitBox]

chrisdutz merged pull request #188:
URL: https://github.com/apache/plc4x/pull/188


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb opened a new pull request #190: Feature/write extended registers

[GitBox]

hutcheb opened a new pull request #190:
URL: https://github.com/apache/plc4x/pull/190


   Add support for writing extended registers.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on pull request #186: Feature/modbus data type

[GitBox]

chrisdutz commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-696964288


   Hi Ben ... sorry for the late response ... I'm currently drowning in getting 
some stuff finished as well as preparing for ApacheCon next week ... I'll try 
to squeeze it in, but can't promise ... haven't forgotten you and your hard 
work ... just want to invest the time for reviewing, that your work deserves.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb commented on pull request #186: Feature/modbus data type

[GitBox]

hutcheb commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-696981490


   Hi Chris, not a problem take your time. :)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on pull request #186: Feature/modbus data type

[GitBox]

chrisdutz commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-696964288


   Hi Ben ... sorry for the late response ... I'm currently drowning in getting 
some stuff finished as well as preparing for ApacheCon next week ... I'll try 
to squeeze it in, but can't promise ... haven't forgotten you and your hard 
work ... just want to invest the time for reviewing, that your work deserves.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb commented on pull request #186: Feature/modbus data type

[GitBox]

hutcheb commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-696981490


   Hi Chris, not a problem take your time. :)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb opened a new pull request #188: Modbus Data Type Documentation

[GitBox]

hutcheb opened a new pull request #188:
URL: https://github.com/apache/plc4x/pull/188


   Documentation for the Modbus Data type PR



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on pull request #186: Feature/modbus data type

[GitBox]

chrisdutz commented on pull request #186:
URL: https://github.com/apache/plc4x/pull/186#issuecomment-694150435


   Do you need any help from my side in order to continue? If yes, just reach 
out to me.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz merged pull request #184: Modbus/update documentation

[GitBox]

chrisdutz merged pull request #184:
URL: https://github.com/apache/plc4x/pull/184


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb commented on pull request #191: Implement WriteBuffer float, double and BigInteger functions

[GitBox]

hutcheb commented on pull request #191:
URL: https://github.com/apache/plc4x/pull/191#issuecomment-699621155


   Little Endian BigInteger functions havn't been tested.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb commented on pull request #192: Refactor Field Handler Classes

[GitBox]

hutcheb commented on pull request #192:
URL: https://github.com/apache/plc4x/pull/192#issuecomment-703093701


   StaticSerialzer when writing booleans needs some work.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb closed pull request #193: Add support for writing arrays to the hello world write example.

[GitBox]

hutcheb closed pull request #193:
URL: https://github.com/apache/plc4x/pull/193


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] hutcheb closed pull request #191: Implement WriteBuffer float, double and BigInteger functions

[GitBox]

hutcheb closed pull request #191:
URL: https://github.com/apache/plc4x/pull/191


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on pull request #161: C-Code-Generation (Please don't merge ... this is used for allowing code-reviews)

[GitBox]

chrisdutz commented on pull request #161:
URL: https://github.com/apache/plc4x/pull/161#issuecomment-634811316


   So how about if the next letter is uppercase too, treat the current as the 
same block. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on pull request #161: C-Code-Generation (Please don't merge ... this is used for allowing code-reviews)

[GitBox]

chrisdutz commented on pull request #161:
URL: https://github.com/apache/plc4x/pull/161#issuecomment-634810800


   Yeah that would indeed shorten some names by 50%



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz opened a new pull request #161: C-Code-Generation (Please don't merge ... this is used for allowing code-reviews)

[GitBox]

chrisdutz opened a new pull request #161:
URL: https://github.com/apache/plc4x/pull/161


   …) so we can do code reviews on it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] nalim2 merged pull request #158: Updated Eclipse Milo to 0.3.7

[GitBox]

nalim2 merged pull request #158:
URL: https://github.com/apache/plc4x/pull/158


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] ottobackwards commented on pull request #161: C-Code-Generation (Please don't merge ... this is used for allowing code-reviews)

[GitBox]

ottobackwards commented on pull request #161:
URL: https://github.com/apache/plc4x/pull/161#issuecomment-634876265


   Yes something like that



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] JulianFeinauer commented on pull request #162: Updated the codecentric adopters page entry

[GitBox]

JulianFeinauer commented on pull request #162:
URL: https://github.com/apache/plc4x/pull/162#issuecomment-635229505


   LGTM.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] JulianFeinauer merged pull request #162: Updated the codecentric adopters page entry

[GitBox]

JulianFeinauer merged pull request #162:
URL: https://github.com/apache/plc4x/pull/162


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz opened a new pull request #162: Updated the codecentric adopters page entry

[GitBox]

chrisdutz opened a new pull request #162:
URL: https://github.com/apache/plc4x/pull/162


   Hi folks,
   
   I would like the community to approve this change ... 
   
   Chris



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] nalim2 edited a comment on pull request #158: Updated Eclipse Milo to 0.3.7

[GitBox]

nalim2 edited a comment on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633525795


   Yeah i think to include there a Sample Server should be a good idea. I would 
first just integrate a Milo example server and would transfere the ManualTest 
class to an integration test or what you mean by the TestContainers Project?
   
   If there would be an alternativ server it would be better to get possible 
specification problems



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] patrickse opened a new pull request #158: Updated Eclipse Milo to 0.3.7

[GitBox]

patrickse opened a new pull request #158:
URL: https://github.com/apache/plc4x/pull/158


   Eclipse Milo 0.3.7 supports relaxed nonce validation when not using 
protected credentials. It's needed to talk to development PLC from Schneider 
Electric.
   
   
https://github.com/eclipse/milo/commit/35ee06ea87676db9fdf4caf748b9265c40d1c841
   
   Signed-off-by: Patrick Sernetz 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] JulianFeinauer commented on pull request #158: Updated Eclipse Milo to 0.3.7

[GitBox]

JulianFeinauer commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633479750


   Good question, indeed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] JulianFeinauer edited a comment on pull request #158: Updated Eclipse Milo to 0.3.7

[GitBox]

JulianFeinauer edited a comment on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633479750


   Good question, indeed. But good to know that it works for you. @nalim2 we 
should definetly have a look there. Probably we could start an OPC Server and 
start a Client and just do some sending. Probably even using the awesome 
TestContainers Project?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] patrickse commented on pull request #158: Updated Eclipse Milo to 0.3.7

[GitBox]

patrickse commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633479410


   I am not aware of any integration test. We've changed the dependency and 
deployd it to our platform. It looks ok for now. How could I implement an 
integration test?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] nalim2 commented on pull request #158: Updated Eclipse Milo to 0.3.7

[GitBox]

nalim2 commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633525795


   Yeah i think to include there a Sample Server should be a good idea. I would 
first just integrate a Milo example server and would transfere the ManualTest 
class to an integration test or what you mean by the TestContainers Project?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] JulianFeinauer commented on pull request #158: Updated Eclipse Milo to 0.3.7

[GitBox]

JulianFeinauer commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633477367


   Thanks @patrickse ! Do we have integration tests for milo or did you test 
the code already?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] nalim2 commented on pull request #158: Updated Eclipse Milo to 0.3.7

[GitBox]

nalim2 commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633527174


   But just the updated versions lgtm



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] ottobackwards commented on pull request #161: C-Code-Generation (Please don't merge ... this is used for allowing code-reviews)

[GitBox]

ottobackwards commented on pull request #161:
URL: https://github.com/apache/plc4x/pull/161#issuecomment-635369565


   That looks great!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] ottobackwards merged pull request #160: have rat ignore .java-version files from jenv since we need java kung…

[GitBox]

ottobackwards merged pull request #160:
URL: https://github.com/apache/plc4x/pull/160


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz merged pull request #159: [SITE] Add Logo Column. Add pragmatic minds and pragmatic industries …

[GitBox]

chrisdutz merged pull request #159:
URL: https://github.com/apache/plc4x/pull/159


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] ottobackwards opened a new pull request #160: have rat ignore .java-version files from jenv since we need java kung…

[GitBox]

ottobackwards opened a new pull request #160:
URL: https://github.com/apache/plc4x/pull/160


   … fu between all supported versions



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz merged pull request #161: C-Code-Generation (Please don't merge ... this is used for allowing code-reviews)

[GitBox]

chrisdutz merged pull request #161:
URL: https://github.com/apache/plc4x/pull/161


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on pull request #161: C-Code-Generation (Please don't merge ... this is used for allowing code-reviews)

[GitBox]

chrisdutz commented on pull request #161:
URL: https://github.com/apache/plc4x/pull/161#issuecomment-637527414


   ;-) ... I am currently replicating what we have in Java and here the 
endianess is handled internally. It's handled in the constructor of the buffer.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org