Re: Time for another release?
We could also fork the trunk to a release branch when we want to make a release candidate so that development can continue on the trunk. There likely wouldn't be any changes to make on the branch, so we would end up copying the release branch to a tag and deleting the release branch. This would require changing the release scripts, but is a possibility as we think about rewriting some of the release procedure in Gradle. On Jan 24, 2017 22:07, "Nick Burch" wrote: > On Wed, 25 Jan 2017, Greg Woolsey wrote: > >> I have something I'm going to file an issue about tomorrow, but it could >> wait. Although having it in would help fix some bugs I'm working around >> with Vaadin Spreadsheet. It would be my first official commit, so I don't >> want to do it near a code freeze, just in case. It's a helper to expose >> the formula evaluation code more cleanly for evaluating formulas not tied >> to a specific cell, like conditional formatting and data validation >> expressions. >> > > I'd suggest you create a branch of trunk, and commit to that. I'm happy to > help review, especially the conditional formatting angle. Once we're all > happy, and the release is done, merge away! > > Nick > > - > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org > For additional commands, e-mail: dev-h...@poi.apache.org > >
Re: Time for another release?
On Wed, 25 Jan 2017, Greg Woolsey wrote: I have something I'm going to file an issue about tomorrow, but it could wait. Although having it in would help fix some bugs I'm working around with Vaadin Spreadsheet. It would be my first official commit, so I don't want to do it near a code freeze, just in case. It's a helper to expose the formula evaluation code more cleanly for evaluating formulas not tied to a specific cell, like conditional formatting and data validation expressions. I'd suggest you create a branch of trunk, and commit to that. I'm happy to help review, especially the conditional formatting angle. Once we're all happy, and the release is done, merge away! Nick - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 60571] Custom number formats with custom currency symbols not applied to cells
https://bz.apache.org/bugzilla/show_bug.cgi?id=60571 --- Comment #5 from Greg Woolsey --- One major complicating factor with this particular issue, that I've dealt with in the past, is that Excel uses the Windows Region settings for default number formatting, and doesn't store them (as you see) in the document itself. That's how two users can open the same file and see different grouping separators and decimal symbols, for example. These are very deeply buried in the Windows Control Panel settings, but are the only way to change the Excel defaults. I don't even know how different versions of Excel will handle having them explicitly set in the document XML, i.e. Excel for Mac, let alone LibreOffice. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
Re: Time for another release?
I have something I'm going to file an issue about tomorrow, but it could wait. Although having it in would help fix some bugs I'm working around with Vaadin Spreadsheet. It would be my first official commit, so I don't want to do it near a code freeze, just in case. It's a helper to expose the formula evaluation code more cleanly for evaluating formulas not tied to a specific cell, like conditional formatting and data validation expressions. Currently one has to implement a class in the o.a.p. package space to access some package scoped items to evaluate these without using a dummy cell as an intermediary. A public utility class will avoid that while also reducing the likelihood of questions and issues arising from the misuse of internal code. And it can have tests. On Tue, Jan 24, 2017 at 3:07 PM Javen O'Neal wrote: > I'll take this release, then. > > Are there any outstanding changes that should be committed before creating > the the artifacts for 3.16 beta 2? > > On Jan 24, 2017 10:45, "Greg Woolsey" wrote: > > > I have a product release for my day job this week, best I sit this one > out > > :) > > > > On Tue, Jan 24, 2017 at 8:40 AM Javen O'Neal wrote: > > > > > Definitely go for a beta. Also want to check out how JCmpApi is doing > to > > > find API breaks. > > > > > > Greg, do you want to be release manager for 3.16 beta 2? If not, I can > do > > > it. > > > > > > On Jan 23, 2017 23:52, "Andreas Beeker" wrote: > > > > > > > I would go for another beta soon. > > > > Who will be the release manager? > > > > > > > > Andi > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org > > > > For additional commands, e-mail: dev-h...@poi.apache.org > > > > > > > > > > > > > >
Re: Time for another release?
I'll take this release, then. Are there any outstanding changes that should be committed before creating the the artifacts for 3.16 beta 2? On Jan 24, 2017 10:45, "Greg Woolsey" wrote: > I have a product release for my day job this week, best I sit this one out > :) > > On Tue, Jan 24, 2017 at 8:40 AM Javen O'Neal wrote: > > > Definitely go for a beta. Also want to check out how JCmpApi is doing to > > find API breaks. > > > > Greg, do you want to be release manager for 3.16 beta 2? If not, I can do > > it. > > > > On Jan 23, 2017 23:52, "Andreas Beeker" wrote: > > > > > I would go for another beta soon. > > > Who will be the release manager? > > > > > > Andi > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org > > > For additional commands, e-mail: dev-h...@poi.apache.org > > > > > > > > >
[Bug 60571] Custom number formats with custom currency symbols not applied to cells
https://bz.apache.org/bugzilla/show_bug.cgi?id=60571 --- Comment #4 from Jonny --- Hello, so I have been working on this issue. I believe the change may be deeper than the package I had mentioned, and I don't see the source code for them. But more importantly, I don't quite know where the implementation for the solution would take place. In the excel file, I did comparisons and looked at the cell properties, by using VBA editor. The cell properties "NumberFormat" and "NumberFormatLocal" should be set with the custom number format somehow. They aren't set currently with the custom format, except for the Japanese Yen, as I had mentioned; the others are set with a standard currency format. I also manaully added the format to a cell value, and did see this cell property update to the correct custom number format. So I believe if we have some way to set this in Apache POI, that will resolve the issue. The following are some things I've looked into. I looked in CellUtil.setCellStyleProperty(), and those are limited. Updating this to have a setNumberFormat & setNumberFormatLocal might help. However, I've unzipped an xlsx file, and looked at the containing xml files, and it seems that the only place which has the custom number formats is in styles.xml. And as I've mentioned before, the JPY number format works mostly. So I don't know how this update would help. Another location I looked in is in CTXF, which is used when setting the data format for cell styles. When debugging, I looked at the xml fragment generated (this is for Japanese Yen, but it looks the same for all the cells): http://schemas.openxmlformats.org/spreadsheetml/2006/main";> >From what I've researched, this should include the "formatCode" attribute, which the value would be the number format. I received that from this stackoverflow, but the solution doesn't use Apache POI, nor do I think it still uses the formatCode attribute, which leads me to believe this implementation may not be fruitful. But I'd appreciate an opinion from someone else. http://stackoverflow.com/questions/23501843/applying-number-formatting-in-openxml This package may be with a different open source product, is that right? org.openxmlformats.schemas.spreadsheetml.x2006.main If so, maybe the issue resides in there and I should open a different ticket? Thank you all for any tips or suggestions. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
Re: Time for another release?
I have a product release for my day job this week, best I sit this one out :) On Tue, Jan 24, 2017 at 8:40 AM Javen O'Neal wrote: > Definitely go for a beta. Also want to check out how JCmpApi is doing to > find API breaks. > > Greg, do you want to be release manager for 3.16 beta 2? If not, I can do > it. > > On Jan 23, 2017 23:52, "Andreas Beeker" wrote: > > > I would go for another beta soon. > > Who will be the release manager? > > > > Andi > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org > > For additional commands, e-mail: dev-h...@poi.apache.org > > > > >
Re: Time for another release?
Definitely go for a beta. Also want to check out how JCmpApi is doing to find API breaks. Greg, do you want to be release manager for 3.16 beta 2? If not, I can do it. On Jan 23, 2017 23:52, "Andreas Beeker" wrote: > I would go for another beta soon. > Who will be the release manager? > > Andi > > - > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org > For additional commands, e-mail: dev-h...@poi.apache.org > >
[Bug 60626] ArrayIndexOutOfBoundsException in EvilUnclosedBRFixingInputStream
https://bz.apache.org/bugzilla/show_bug.cgi?id=60626 Joachim Piketz changed: What|Removed |Added Hardware|PC |All -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
