[Bug 60184] Saved file that uses a XSSFFont without a specifically set FontFamily won't open in Excel

2017-05-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60184

Greg Woolsey  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Greg Woolsey  ---
Fixed in 3.17, r1794111.  No longer creating an empty family entry as a side
effect of calling the getter.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 60184] Saved file that uses a XSSFFont without a specifically set FontFamily won't open in Excel

2017-05-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60184

Greg Woolsey  changed:

   What|Removed |Added

 CC||gwool...@apache.org

--- Comment #8 from Greg Woolsey  ---
I just now found this issue, wish I'd seen it earlier.  I see the problem now.

XSSFFont can be created without a family.  This is what happens when calling
XSSFWorkbook.createFont().  This is fine per the OOXML XSD.

However, XSSFFont.getFamily() creates an empty family element if none exist. 
This is invalid, as the family element is required to have a val attribute.

Further, it's really bad practice for things that are defined as property
getters to have side effects like this.

Since the API's been out there a while, we should maintain backward
compatibility, but I don't like it too much.

I think in the missing element case it should just return 0, the index for
NOT_APPLICABLE, which appears to coincide with "auto" in the spec, but NOT
create a family element.

Better would be a method that returns an instance of the enum or null if not
defined, or NOT_APPLICABLE if null is undesirable.  For now though, I'll just
update to not create the empty element if missing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Jenkins build is back to normal : POI-DSL-1.6 #288

2017-05-05 Thread Apache Jenkins Server
See 



-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Build failed in Jenkins: POI-DSL-1.6 #287

2017-05-05 Thread Apache Jenkins Server
oading source files for package org.apache.poi.xssf...
  [javadoc] Loading source files for package org.apache.poi.xssf.binary...
  [javadoc] Loading source files for package org.apache.poi.xssf.dev...
  [javadoc] Loading source files for package 
org.apache.poi.xssf.eventusermodel...
  [javadoc] Loading source files for package org.apache.poi.xssf.extractor...
  [javadoc] Loading source files for package org.apache.poi.xssf.model...
  [javadoc] Loading source files for package org.apache.poi.xssf.streaming...
  [javadoc] Loading source files for package org.apache.poi.xssf.usermodel...
  [javadoc] Loading source files for package 
org.apache.poi.xssf.usermodel.charts...
  [javadoc] Loading source files for package 
org.apache.poi.xssf.usermodel.extensions...
  [javadoc] Loading source files for package 
org.apache.poi.xssf.usermodel.helpers...
  [javadoc] Loading source files for package org.apache.poi.xssf.util...
  [javadoc] Loading source files for package org.apache.poi.xwpf.extractor...
  [javadoc] Loading source files for package org.apache.poi.xwpf.model...
  [javadoc] Loading source files for package org.apache.poi.xwpf.usermodel...
  [javadoc] Constructing Javadoc information...
  [javadoc] Standard Doclet version 1.6.0_45
  [javadoc] Building tree for all the packages and classes...
  [javadoc] Building index for all the packages and classes...
  [javadoc] Building index for all classes...
  [javadoc] Patched 1 link injection vulnerable javadocs

jar-src:
  [jar] Building jar: 
<https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/maven/poi/poi-3.17-beta1-sources.jar>
  [jar] Building jar: 
<https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/maven/poi-scratchpad/poi-scratchpad-3.17-beta1-sources.jar>
  [jar] Building jar: 
<https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/maven/poi-ooxml/poi-ooxml-3.17-beta1-sources.jar>
  [jar] Building jar: 
<https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/maven/poi-examples/poi-examples-3.17-beta1-sources.jar>
  [jar] Building jar: 
<https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/maven/poi-excelant/poi-excelant-3.17-beta1-sources.jar>

-do-jar-check-javadocs-package-list:

-do-jar-create-javadocs-package-list:

jar-javadocs:
 [echo] Building poi javadocs from 
<https://builds.apache.org/job/POI-DSL-1.6/ws/src/java>
[mkdir] Created dir: 
<https://builds.apache.org/job/POI-DSL-1.6/ws/build/tmp/maven-javadocs>
  [javadoc] Generating Javadoc
  [javadoc] Javadoc execution
  [javadoc] Patched 1 link injection vulnerable javadocs
  [jar] Building jar: 
<https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/maven/poi/poi-3.17-beta1-javadoc.jar>
 [echo] Building poi-scratchpad javadocs from 
<https://builds.apache.org/job/POI-DSL-1.6/ws/src/scratchpad/src>
   [delete] Deleting directory 
<https://builds.apache.org/job/POI-DSL-1.6/ws/build/tmp/maven-javadocs>
[mkdir] Created dir: 
<https://builds.apache.org/job/POI-DSL-1.6/ws/build/tmp/maven-javadocs>
  [javadoc] Generating Javadoc
  [javadoc] Javadoc execution
  [javadoc] Patched 1 link injection vulnerable javadocs
  [jar] Building jar: 
<https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/maven/poi-scratchpad/poi-scratchpad-3.17-beta1-javadoc.jar>
 [echo] Building poi-ooxml javadocs from 
<https://builds.apache.org/job/POI-DSL-1.6/ws/src/ooxml/java>
   [delete] Deleting directory 
<https://builds.apache.org/job/POI-DSL-1.6/ws/build/tmp/maven-javadocs>
[mkdir] Created dir: 
<https://builds.apache.org/job/POI-DSL-1.6/ws/build/tmp/maven-javadocs>
  [javadoc] Generating Javadoc
  [javadoc] Javadoc execution
  [javadoc] Patched 1 link injection vulnerable javadocs
  [jar] Building jar: 
<https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/maven/poi-ooxml/poi-ooxml-3.17-beta1-javadoc.jar>

assemble:
  [zip] Building zip: 
<https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/poi-bin-3.17-beta1-20170505.zip>
  [tar] Building tar: 
<https://builds.apache.org/job/POI-DSL-1.6/287/artifact/build/dist/poi-bin-3.17-beta1-20170505.tar.gz>
  [zip] Building zip: 
<https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/poi-src-3.17-beta1-20170505.zip>
  [tar] Building tar: 
<https://builds.apache.org/job/POI-DSL-1.6/287/artifact/build/dist/poi-src-3.17-beta1-20170505.tar.gz>
 [echo] Creating Maven POMs

maven-poms:
 [copy] Copying 6 files to 
<https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/maven>
 [echo] Maven POMs are located in 
<https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist>
 [echo] Use ant dist-nexus to deploy the artifacts in the remote repository
 [echo] Distribution located in 
<https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist>
 [echo] Use "ant dist-checksum" to create md5/sha1 checksums and GPG 
signatures

fin

[Bug 61060] DataFormatter should honor conditional formatting rule formats

2017-05-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61060

Greg Woolsey  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #2 from Greg Woolsey  ---
Implemented in r1794084

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 61034] Call to XSSFReader.getSheetsData() returns duplicate sheets

2017-05-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61034

--- Comment #3 from Tim Allison  ---
Sorry, all.  1) shouldn't have introduced this and 2) should have caught this
with tika-eval...argh.

Thank you for reporting this and supplying a patch.  Thank you, Javen!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 60833] Initialisation of record 0x31 left 4 bytes remaining still to be read.

2017-05-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60833

--- Comment #10 from Tim Allison  ---
Stats from our regression corpus on which Excel records cause
LeftoverDataExceptions (Record \t number of exceptions).

0x850(ChartFRTInfoRecord)   763  (Bug 47247)
0x85(BoundSheetRecord)  95
0x1D(SelectionRecord)   35
0x31(FontRecord)15
0x203(NumberRecord) 8
0x42(CodepageRecord)5
0x3C(ContinueRecord)2
0x868(FeatRecord)   2
0x5B(FileSharingRecord) 1
0x5F(SaveRecalcRecord)  1
0xE(PrecisionRecord)1

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 60833] Initialisation of record 0x31 left 4 bytes remaining still to be read.

2017-05-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60833

--- Comment #9 from Tim Allison  ---
Whoa... and govdocs1/093/093996.xls has seven font records with an extra 1918
bytes!

No intelligible text (on a quick look)...

FONT NAME:MS Sans Serif : 13
0 : 149 :  
1 : 129 :  
2 : 95 : _
3 : 41 : )
4 : 59 : ;
5 : 95 : _
...
1893 : 0 :  
1894 : 115 : s
1895 : 142 :  
1896 : 78 : N
1897 : 0 :  
1898 : 75 : K
1899 : 161 :  
1900 : 78 : N
1901 : 0 :  
1902 : 3 :  
1903 : 180 :  
1904 : 78 : N
1905 : 0 :  
1906 : 227 :  
1907 : 198 :  
1908 : 78 : N
1909 : 0 :  
1910 : 145 :  
1911 : 214 :  
1912 : 78 : N
1913 : 0 :  
1914 : 48 : 0
1915 : 65 : A
1916 : 85 : U
1917 : 8 :

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 60833] Initialisation of record 0x31 left 4 bytes remaining still to be read.

2017-05-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60833

--- Comment #8 from Tim Allison  ---
We have 15 stacktraces like this in our regression corpus for Tika.  I was
hoping from the file attached here (first) and the file attached on Bug 57093
(second), that the first byte or two specified a length somehow.

However, from govdocs1 085890.xls (third), it looks like junk at the end of the
font record.  By junk, of course, I mean, "I don't understand why it's
there"...like junk DNA. :)  But seriously, in 085890.xls, when I open the file
in Excel and search for "providing", I don't find anything.

First line is font name : length
Remaining lines are: byte index : byte&0xff : char (if above 20)

FONT NAME:黑体 : 2
0 : 0 :  
1 : 0 :  
2 : 0 :  
3 : 0 : 

FONT NAME:MS Sans Serif : 13
0 : 19 :  
1 : 0 :  
2 : 1 :  
3 : 0 :  
4 : 0 :  
5 : 88 : X
6 : 1 :  
7 : 0 :  
8 : 0 :  
9 : 89 : Y
10 : 95 : _
11 : 41 : )
12 : 63 : ?
13 : 95 : _
14 : 41 : )
15 : 59 : ;
16 : 95 : _
17 : 40 : (
18 : 64 : @
19 : 95 : _
20 : 41 : )
21 : 0 :  

FONT NAME:MS Sans Serif : 13
0 : 116 : t
1 : 129 :  
2 : 84 : T
3 : 73 : I
4 : 84 : T
5 : 85 : U
6 : 84 : T
7 : 73 : I
8 : 79 : O
9 : 78 : N
10 : 95 : _
11 : 80 : P
12 : 82 : R
13 : 79 : O
14 : 86 : V
15 : 73 : I
16 : 68 : D
17 : 73 : I
18 : 78 : N
19 : 71 : G
20 : 95 : _
21 : 68 : D
22 : 65 : A
23 : 84 : T
24 : 65 : A
25 : 95 : _
26 : 73 : I
27 : 68 : D
28 : 10 :  
29 : 0 :  
30 : 0 :  
31 : 67 : C
32 : 79 : O
33 : 78 : N
34 : 84 : T
35 : 65 : A
36 : 67 : C
37 : 84 : T
38 : 95 : _
39 : 73 : I
40 : 68 : D
41 : 20 :

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org