Re: publishing poi xmlbeans jars

2018-03-08 Thread Javen O'Neal 
+1 sending it back to Incubator or subproject of Commons.

+0.9 as a subproject of POI.

Would prefer Xmlbeans to have its own PMC to make it easier for other
Apache devs to make changes, but given how stable/mature it is, the support
volume should be low.

If/when POI does replace XMLBeans for a more memory efficient/faster XML
library, it'd be awkward for our PMC to manage a product we don't use. We
can move it out to incubator, attic, or put it up for adoption when that
time comes.

As long as the board doesn't have reservations about us subprojecting
XMLBeans and then making another change in a couple years, I'm fine with
taking XMLBeans as a subproject of POI.

On Thu, Mar 8, 2018, 10:50 Dominik Stadler  wrote:

> +1
>
> On Wed, Mar 7, 2018 at 11:20 PM, pj.fanning  wrote:
>
> > +1
> >
> >
> >
> > --
> > Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
> >
> >
>

Re: publishing poi xmlbeans jars

2018-03-08 Thread Dominik Stadler 
+1

On Wed, Mar 7, 2018 at 11:20 PM, pj.fanning  wrote:

> +1
>
>
>
> --
> Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

[Bug 62165] New: OldExcelExtractor closed NPOIFSFileSystem too early

2018-03-08 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62165

Bug ID: 62165
   Summary: OldExcelExtractor closed NPOIFSFileSystem too early
   Product: POI
   Version: 3.17-FINAL
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P2
 Component: HSSF
  Assignee: dev@poi.apache.org
  Reporter: billow...@gmail.com
  Target Milestone: ---

Created attachment 35756
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35756&action=edit
OldExcelExtractor patch file to fix the open stream bug

open(InputStream biffStream) closed the NPOIFSFileSystem  right after open
which is wrong. We should only close it when open failed.

The buggy code:
try {
open(poifs);
} finally {
poifs.close();
}

Should be:
try {
open(poifs);
toClose = poifs; // Fixed by GR, we should not close it here
} finally {
if (toClose == null) {
poifs.close();
}
}

Attached is the patch file

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org