[Bug 62625] VBAMacroReader in 4.0.0-SNAPSHOT, unexpected reserved byte

2018-10-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62625

--- Comment #7 from Tim Allison  ---
And fix made to ensure closing of streams from lgtm.  Thank you, again, PJ.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 62625] VBAMacroReader in 4.0.0-SNAPSHOT, unexpected reserved byte

2018-10-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62625

Tim Allison  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Tim Allison  ---
One dodgy loop fixed.  Added other sanity checks.  Thank you, PJ!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 62625] VBAMacroReader in 4.0.0-SNAPSHOT, unexpected reserved byte

2018-10-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62625

Tim Allison  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #5 from Tim Allison  ---
Doh. Fixing now.  Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 62625] VBAMacroReader in 4.0.0-SNAPSHOT, unexpected reserved byte

2018-10-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62625

--- Comment #4 from PJ Fanning  ---
The recent code changes seem to have introduced a number of new warnings in
https://lgtm.com/projects/g/apache/poi/alerts/?mode=list and in FindBugs output
(see the spike in https://builds.apache.org/view/P/view/POI/job/POI-DSL-1.8/)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Re: Proposal - host javadocs of recent versions too

2018-10-30 Thread Nick Burch

On Fri, 19 Oct 2018, Nick Burch wrote:

The immediate change would be:
* Everything at https://poi.apache.org/apidocs/ gets pushed to
  https://poi.apache.org/apidocs/dev/
* A new page at https://poi.apache.org/apidocs/ which says which
  versions you can see javadocs for online, and instructions on getting
  older ones from the released files
* Redirects for as much as possible from https://poi.apache.org/apidocs/
  to https://poi.apache.org/apidocs/dev/ to avoid breaking links
* Tweaks to the site build ant file to support the changes


These are now hopefully all done and sorted!


Then, and this is the bit which could use some more feedback:
* /apidocs/4.0/ for the latest 4.0.x release (eg when we do 4.0.1 we
  replace them)
* /apidocs/3.17/ for 3.17 final


These two are done as well


I think the main thing that remains now, if anyone feels keen is that 
building the latest Javadocs shows a bunch of broken references to other 
classes / methods / fields. If someone has maybe an hour to spare, it'd be 
great to run "ant javadocs", see the warnings for the broken references, 
and fix as many of them as possible!


Nick

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Re: POI 4.0.1 release

2018-10-30 Thread Greg Woolsey
+1 for next weekend/week as well.

Liking the current state of things after the initial 4.0.0 public feedback.

On Tue, Oct 30, 2018 at 8:31 AM Alain FAGOT BÉAREZ 
wrote:

> +1 to release 4.0.1
>
> The blocking issues related to charts in XDDF are now fixed. Related
> Bugzilla issue has also been resolved.
>
> Some tricks from StackOverflow tickets have been integrated into the code
> base and in the examples. Some Bugzilla issues were resolved as side
> effect.
>
> Remaining chart related issues in Bugzilla will require either some
> investigation (shifting rows and columns in XSSF) or brand new
> implementation (chart extensions like TreeMap and SunBurst). The easiest
> one is more about gathering examples from various SO tickets and building a
> new example, rather than improvement of the API for charts.
>
> ⁣Gesendet mit BlueMail ​
>
> Von: "pj.fanning"
> Gesendet: Tue Oct 30 04:59:08 GMT-03:00 2018
> An: dev@poi.apache.org
> Betreff: POI 4.0.1 release
>
> Is it time for us to look at doing a POI 4.0.1 release?
>
> Are there any issues we would like to see completed before we proceed?
>
>
>
> --
> Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html
>
>
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>
>  Originale Nachricht 
> Von: "pj.fanning" 
> Gesendet: Tue Oct 30 04:59:08 GMT-03:00 2018
> An: dev@poi.apache.org
> Betreff: POI 4.0.1 release
>
> Is it time for us to look at doing a POI 4.0.1 release?
>
> Are there any issues we would like to see completed before we proceed?
>
>
>
> --
> Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>


Re: POI 4.0.1 release

2018-10-30 Thread Alain FAGOT BÉAREZ
+1 to release 4.0.1

The blocking issues related to charts in XDDF are now fixed. Related Bugzilla 
issue has also been resolved.

Some tricks from StackOverflow tickets have been integrated into the code base 
and in the examples. Some Bugzilla issues were resolved as side effect.

Remaining chart related issues in Bugzilla will require either some 
investigation (shifting rows and columns in XSSF) or brand new implementation 
(chart extensions like TreeMap and SunBurst). The easiest one is more about 
gathering examples from various SO tickets and building a new example, rather 
than improvement of the API for charts.

⁣Gesendet mit BlueMail ​

Von: "pj.fanning"
Gesendet: Tue Oct 30 04:59:08 GMT-03:00 2018
An: dev@poi.apache.org
Betreff: POI 4.0.1 release

Is it time for us to look at doing a POI 4.0.1 release?

Are there any issues we would like to see completed before we proceed?



--
Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html


To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org


 Originale Nachricht 
Von: "pj.fanning" 
Gesendet: Tue Oct 30 04:59:08 GMT-03:00 2018
An: dev@poi.apache.org
Betreff: POI 4.0.1 release

Is it time for us to look at doing a POI 4.0.1 release?

Are there any issues we would like to see completed before we proceed?



--
Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org


[Bug 62625] VBAMacroReader in 4.0.0-SNAPSHOT, unexpected reserved byte

2018-10-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62625

Tim Allison  changed:

   What|Removed |Added

Summary|Regression in   |VBAMacroReader in
   |VBAMacroReader in   |4.0.0-SNAPSHOT, unexpected
   |4.0.0-SNAPSHOT, unexpected  |reserved byte
   |reserved byte   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 62625] VBAMacroReader in 4.0.0-SNAPSHOT, unexpected reserved byte

2018-10-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62625

--- Comment #3 from Tim Allison  ---
To clarify, this wasn't a regression.  This was a bug that became apparent with
better exception handling.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 62869] New: Let's add the VBAMacroReader to our integration tests

2018-10-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62869

Bug ID: 62869
   Summary: Let's add the VBAMacroReader to our integration tests
   Product: POI
   Version: unspecified
  Hardware: PC
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: POI Overall
  Assignee: dev@poi.apache.org
  Reporter: talli...@mitre.org
  Target Milestone: ---

I probably won't get around to this for a bit, but would there be any
objections?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 62625] Regression in VBAMacroReader in 4.0.0-SNAPSHOT, unexpected reserved byte

2018-10-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62625

Tim Allison  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Tim Allison  ---
r1845238

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Re: POI 4.0.1 release

2018-10-30 Thread Tim Allison
+1 "end of this week" that'll work well for my issues, too.  I want to
confirm I didn't break anything in my recent commits via large scale
regression testing.
On Tue, Oct 30, 2018 at 8:31 AM Yegor Kozlov  wrote:
>
> +1
>
> Bug 62836 is pending. I'm going to check in the code anyway, just waiting
> to see if the contributor is planning any follow-up patches. Please give me
> time till the end of this week.
>
> Yegor
>
> On Tue, Oct 30, 2018 at 10:59 AM pj.fanning  wrote:
>
> > Is it time for us to look at doing a POI 4.0.1 release?
> >
> > Are there any issues we would like to see completed before we proceed?
> >
> >
> >
> > --
> > Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
> >
> >

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Re: POI 4.0.1 release

2018-10-30 Thread Yegor Kozlov
+1

Bug 62836 is pending. I'm going to check in the code anyway, just waiting
to see if the contributor is planning any follow-up patches. Please give me
time till the end of this week.

Yegor

On Tue, Oct 30, 2018 at 10:59 AM pj.fanning  wrote:

> Is it time for us to look at doing a POI 4.0.1 release?
>
> Are there any issues we would like to see completed before we proceed?
>
>
>
> --
> Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>


Re: POI 4.0.1 release

2018-10-30 Thread kiwiwings
+1 for rolling it out soon

I think the grace period is over and we can go on rolling the fixes out.
Also my (H)EMF implementation is giving promising results and although EMF+
is not yet implemented, I think the slideshow users, would benefit from it
... but I don't want to spoil the bugfix release ...

Andi



--
Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



POI 4.0.1 release

2018-10-30 Thread pj.fanning
Is it time for us to look at doing a POI 4.0.1 release?

Are there any issues we would like to see completed before we proceed?



--
Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org