Re: [VOTE] Release Apache POI 5.2.4 (RC1)

[Axel Howind]

+1 for the release.

I just built and tested one of my own projects with the RC and everything seems 
to work just fine.

Two notes:
- I think release candidates should be published with an "rc“ in the version 
string, something like "5.3.4-rc1“ because otherwise when a second release 
candidate/the final release becomes available, Maven might stick with the old 
rc build in the local .m2.
- pdfboc has been updated to 2.0.29. in the meantime, pdfbox released the next 
major release (3.0.0), but I think switching to pdfbox 3 should be more 
thoroughly tested and would rather be something for POI 5.3 

> Am 21.09.2023 um 23:58 schrieb PJ Fanning :
> 
> https://dist.apache.org/repos/dist/dev/poi/RELEASE-NOTES-5.2.4.txt

Build failed in Jenkins: POI » POI-DSL-OpenJDK #832

[Apache Jenkins Server]

See 


Changes:

[PJ Fanning] prep v5.2.4

[PJ Fanning] update changes

[Dominik Stadler] Bug 66425: Avoid exceptions found via poi-fuzz

We try to avoid throwing NullPointerException, ClassCastExceptions and 
StackOverflowException, but it was possible
to trigger them

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=62548 and 
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=62564

[PJ Fanning] [bug-67396] add tests for standalone flag


--
[...truncated 3.82 MB...]
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2396 
spreadsheet/WithChart.xls HPSF PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2419 
spreadsheet/WithMoreVariousData.xlsx XSSF PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2377 
spreadsheet/TwoSheetsOneHidden.xlsx XSSF PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2398 
spreadsheet/WithChart.xlsx OPC PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2397 
spreadsheet/WithChart.xlsx XSSF PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2404 
spreadsheet/WithConditionalFormatting.xls HPSF PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2434 
spreadsheet/WithTwoCharts.xlsx XSSF PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2439 
spreadsheet/WithVariousData.xlsx OPC PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2440 
spreadsheet/WrongFormulaRecordType.xls HSSF PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2441 
spreadsheet/WrongFormulaRecordType.xls HPSF PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2442 
spreadsheet/XRefCalc.xls HSSF PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2443 
spreadsheet/XRefCalc.xls HPSF PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2444 
spreadsheet/XRefCalcData.xls HSSF PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2405 
spreadsheet/WithConditionalFormatting.xlsx XSSF PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2408 
spreadsheet/WithDrawing.xlsx OPC PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2445 
spreadsheet/XRefCalcData.xls HPSF PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2409 
spreadsheet/WithEmbeddedObjects.xls HSSF PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2410 
spreadsheet/WithEmbeddedObjects.xls HPSF PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2411 
spreadsheet/WithEmbeded.xlsx XSSF PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2412 
spreadsheet/WithEmbeded.xlsx OPC PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2413 
spreadsheet/WithExtendedStyles.xls HSSF PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2420 
spreadsheet/WithMoreVariousData.xlsx OPC PASSED
org.apache.poi.stress.TestAllFiles > handleExtracting(String, 
FileHandlerKnown, String, Class, String) Extracting - #2448 

Re: poi 5.2.4 release

[PJ Fanning]

I have created a release candidate and started a vote thread on this mailing 
list. I would appreciate if we could avoid svn commits that are not related to 
the release or fixing high priority bugs until after the vote concludes.

It's been a while since I did a POI release and it is a very manual process so 
I would appreciate if reviewers have a good look at the source distribution and 
jars.

On 2023/09/21 15:23:54 PJ Fanning wrote:
> I'll have a quick look around to see if any tidy up is needed but I suspect 
> we are ok to do an RC in next day or 2. It suits me to cut an RC soon because 
> I'm pretty busy with Apache Pekko releases and don't generally have much time 
> to look at POI these days.
> 
> I'll try to update the release docs as I go. I tend to use the XMLBeans 
> release docs as a guide because I think those ones are easier to follow. I 
> might just clone the XMLBeans ones and make adjustments to make the new docs 
> apply for POI.
> 
> 
> On 2023/09/21 09:55:33 Tim Allison wrote:
> > Sounds great. I’ll try to make a run against our corpus as well.
> > 
> > Thank you!
> > 
> > On Thu, Sep 21, 2023 at 2:58 AM Dominik Stadler 
> > wrote:
> > 
> > > Hi,
> > >
> > > Yes, I agree, a release soon would be good to get the many many
> > > improvements out to users.
> > >
> > > P.J., could you run the process once more and maybe update documentation
> > > along the way so others can do it as well in the future? Not sure how
> > > up-to-date
> > >
> > > https://svn.apache.org/repos/asf/poi/site/src/documentation/release-guide.txt
> > > is to the actual current steps?
> > >
> > > I can trigger a regression-run of the large corpus over the weekend to see
> > > which regressions may have creeped in.
> > >
> > > Thanks... Dominik.
> > >
> > >
> > > On Wed, Sep 20, 2023 at 9:32 PM PJ Fanning  wrote:
> > >
> > > > Should we be looking at doing a POI 5.2.4 release soon? It's about a 
> > > > year
> > > > since the 5.2.3 release and we have quite a backlog of changes in trunk.
> > > > There also some lib changes where CVEs have been issued with those
> > > > downstream libs (eg commons-compress).
> > > >
> > > > -
> > > > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > > > For additional commands, e-mail: dev-h...@poi.apache.org
> > > >
> > > >
> > >
> > 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
> 
> 

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[VOTE] Release Apache POI 5.2.4 (RC1)

[PJ Fanning]

Hello POI Community,

This is a call for a vote to release Apache POI version 5.2.4 (RC1).

The discussion thread:

https://lists.apache.org/thread/yj35zj9kt8w7zpcbfqpg6ho2fbnxqtb3

The release candidate:

https://dist.apache.org/repos/dist/dev/poi/

This release has been signed with a PGP key available here:

https://dist.apache.org/repos/dist/release/poi/KEYS

Release Notes:

https://dist.apache.org/repos/dist/dev/poi/RELEASE-NOTES-5.2.4.txt

I will add the svn tag REL_5_2_4 if the vote passes.
Svn commit ID: https://svn.apache.org/repos/asf/poi/trunk@1912467

Please download, verify, and test.

We have also staged jars in the Apache Nexus Repository. These were
built with the same code
as appears in this Source Release Candidate. We would appreciate if
users could test with these too.
If anyone finds any serious problems with these jars, please also
notify us on this thread.

https://repository.apache.org/content/groups/staging/org/apache/poi/

In gradle, you can add this repository.

maven {
url "https://repository.apache.org/content/groups/staging/;
}



The VOTE will pass if we have more positive votes than negative votes
and there must be a minimum of 3 approvals from POI PMC members.

I will leave the vote open for at least a week.

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason

To learn more about Apache POI, please see https://poi.apache.org/

Checklist for reference:

[ ] Download links are valid.
[ ] Checksums and signatures.
[ ] LICENSE/NOTICE files exist
[ ] No unexpected binary files
[ ] Source files have ASF headers
[ ] Can compile from source

To compile from the source, please refer to:

Some notes about verifying downloads can be found at:

https://poi.apache.org/download.html


Here is my +1 (binding).

Thanks,

PJ Fanning (Apache POI PMC member)

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[GitHub] [poi] avl93 opened a new pull request, #524: Fix row and column ranges after sheet rename

[via GitHub]

avl93 opened a new pull request, #524:
URL: https://github.com/apache/poi/pull/524

   After renaming sheet, row and column ranges are being converted to cell 
ranges, like this:
   ```
   before-> after 
   sheet2!$2:$4  -> sheet2!$A$2:$XFD$4
   sheet2!$B:$C  -> sheet2!B:C
   ```
   This fix changes some logic regarding updating ranges and formulas, also, it 
fixes TODO in TestHSSFName#testRepeatingRowsAndColumnsNames, referring the same 
problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[GitHub] [poi] avl93 commented on a diff in pull request #523: fix test locale

[via GitHub]

avl93 commented on code in PR #523:
URL: https://github.com/apache/poi/pull/523#discussion_r1333616687


##
poi/src/test/java/org/apache/poi/ss/formula/functions/TestDays.java:
##
@@ -37,6 +39,11 @@ Licensed to the Apache Software Foundation (ASF) under one 
or more
  */
 public class TestDays {
 
+@BeforeAll
+static void setup() {
+Locale.setDefault(Locale.US);

Review Comment:
   Sure, done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[GitHub] [poi] pjfanning commented on a diff in pull request #523: fix test locale

[via GitHub]

pjfanning commented on code in PR #523:
URL: https://github.com/apache/poi/pull/523#discussion_r1333610010


##
poi/src/test/java/org/apache/poi/ss/formula/functions/TestDays.java:
##
@@ -37,6 +39,11 @@ Licensed to the Apache Software Foundation (ASF) under one 
or more
  */
 public class TestDays {
 
+@BeforeAll
+static void setup() {
+Locale.setDefault(Locale.US);

Review Comment:
   POI has its own LocaleUtil. Could you use that instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[GitHub] [poi] avl93 opened a new pull request, #523: fix test locale

[via GitHub]

avl93 opened a new pull request, #523:
URL: https://github.com/apache/poi/pull/523

   Some tests rely on system locale being US and fails on other locales, these 
fix makes them run successfully on any locale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: poi 5.2.4 release

[PJ Fanning]

I'll have a quick look around to see if any tidy up is needed but I suspect we 
are ok to do an RC in next day or 2. It suits me to cut an RC soon because I'm 
pretty busy with Apache Pekko releases and don't generally have much time to 
look at POI these days.

I'll try to update the release docs as I go. I tend to use the XMLBeans release 
docs as a guide because I think those ones are easier to follow. I might just 
clone the XMLBeans ones and make adjustments to make the new docs apply for POI.


On 2023/09/21 09:55:33 Tim Allison wrote:
> Sounds great. I’ll try to make a run against our corpus as well.
> 
> Thank you!
> 
> On Thu, Sep 21, 2023 at 2:58 AM Dominik Stadler 
> wrote:
> 
> > Hi,
> >
> > Yes, I agree, a release soon would be good to get the many many
> > improvements out to users.
> >
> > P.J., could you run the process once more and maybe update documentation
> > along the way so others can do it as well in the future? Not sure how
> > up-to-date
> >
> > https://svn.apache.org/repos/asf/poi/site/src/documentation/release-guide.txt
> > is to the actual current steps?
> >
> > I can trigger a regression-run of the large corpus over the weekend to see
> > which regressions may have creeped in.
> >
> > Thanks... Dominik.
> >
> >
> > On Wed, Sep 20, 2023 at 9:32 PM PJ Fanning  wrote:
> >
> > > Should we be looking at doing a POI 5.2.4 release soon? It's about a year
> > > since the 5.2.3 release and we have quite a backlog of changes in trunk.
> > > There also some lib changes where CVEs have been issued with those
> > > downstream libs (eg commons-compress).
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > > For additional commands, e-mail: dev-h...@poi.apache.org
> > >
> > >
> >
> 

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 47950] No case insensitivity handling for OLE2 entry names

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=47950

Tim Allison  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #13 from Tim Allison  ---
Committed the patch to fix this. Will be available with the 5.2.4 release.

Thank you, Ross, PJ and Dominik!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 67396] Excel getting corrupted in poi 5.0.0 because of standalone = no

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=67396

--- Comment #14 from PJ Fanning  ---
I have added tests using r1912456 that show that simple XSSF and SXSSF
workbooks do not create XML with standalone=no. Provide some code that demos
the issue - I have no plans to do further work on this without proof of an
issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: poi 5.2.4 release

[Tim Allison]

Sounds great. I’ll try to make a run against our corpus as well.

Thank you!

On Thu, Sep 21, 2023 at 2:58 AM Dominik Stadler 
wrote:

> Hi,
>
> Yes, I agree, a release soon would be good to get the many many
> improvements out to users.
>
> P.J., could you run the process once more and maybe update documentation
> along the way so others can do it as well in the future? Not sure how
> up-to-date
>
> https://svn.apache.org/repos/asf/poi/site/src/documentation/release-guide.txt
> is to the actual current steps?
>
> I can trigger a regression-run of the large corpus over the weekend to see
> which regressions may have creeped in.
>
> Thanks... Dominik.
>
>
> On Wed, Sep 20, 2023 at 9:32 PM PJ Fanning  wrote:
>
> > Should we be looking at doing a POI 5.2.4 release soon? It's about a year
> > since the 5.2.3 release and we have quite a backlog of changes in trunk.
> > There also some lib changes where CVEs have been issued with those
> > downstream libs (eg commons-compress).
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
> >
> >
>

Re: poi 5.2.4 release

[Dominik Stadler]

Hi,

Yes, I agree, a release soon would be good to get the many many
improvements out to users.

P.J., could you run the process once more and maybe update documentation
along the way so others can do it as well in the future? Not sure how
up-to-date
https://svn.apache.org/repos/asf/poi/site/src/documentation/release-guide.txt
is to the actual current steps?

I can trigger a regression-run of the large corpus over the weekend to see
which regressions may have creeped in.

Thanks... Dominik.


On Wed, Sep 20, 2023 at 9:32 PM PJ Fanning  wrote:

> Should we be looking at doing a POI 5.2.4 release soon? It's about a year
> since the 5.2.3 release and we have quite a backlog of changes in trunk.
> There also some lib changes where CVEs have been issued with those
> downstream libs (eg commons-compress).
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

[Bug 67396] Excel getting corrupted in poi 5.0.0 because of standalone = no

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=67396

Rakhi Barayanan  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 67396] Excel getting corrupted in poi 5.0.0 because of standalone = no

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=67396

--- Comment #13 from Rakhi Barayanan  ---
Created attachment 39058
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=39058=edit
File after saving--works fine

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 67396] Excel getting corrupted in poi 5.0.0 because of standalone = no

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=67396

--- Comment #12 from Rakhi Barayanan  ---
Created attachment 39057
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=39057=edit
File before saving

File before saving

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 67396] Excel getting corrupted in poi 5.0.0 because of standalone = no

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=67396

--- Comment #11 from Rakhi Barayanan  ---
Hi Fanning,

The standalone=yes is not added in all the places,for example it is still
missing in these instances.

docProps\app.xml 
xl\sharedStrings.xml 
xl\styles.xml 
xl\workbook.xml 

I shared the jar with code change to one of our customer and it didnot work.But
once they opened the excel and saved it ,the size got changed and they were
able to work with the saved copy.So something is still missing in the Excel we
are creating .

I am attaching the copies of Excel before anf after the save operation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org