[Bug 62242] Shouldn't show '0' if number format is "??" and cell value is 0

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62242

--- Comment #8 from Dominik Stadler  ---
When trying to apply the changes from the PR it fixes the issue here, but some
other tests fail, so unfortunately this needs a bit more work to either change
the tests or the fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62242] Shouldn't show '0' if number format is "??" and cell value is 0

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62242

Dominik Stadler  changed:

   What|Removed |Added

 CC||cgh_c...@126.com

--- Comment #7 from Dominik Stadler  ---
*** Bug 59433 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62242] Shouldn't show '0' if number format is "??" and cell value is 0

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62242

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62242] Shouldn't show '0' if number format is "??" and cell value is 0

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62242

linghao2...@hotmail.com changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #6 from linghao2...@hotmail.com ---
(In reply to Dominik Stadler from comment #5)
> The PR causes unit-tests to fail, please try to adjust any other unit-test
> as well to still have tests succeed with the changes applied.

Sorry for that. I didn't notice the ooxml test cases. It seems hard to resolve
it. I will try.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62242] Shouldn't show '0' if number format is "??" and cell value is 0

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62242

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #5 from Dominik Stadler  ---
The PR causes unit-tests to fail, please try to adjust any other unit-test as
well to still have tests succeed with the changes applied.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62242] Shouldn't show '0' if number format is "??" and cell value is 0

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62242

--- Comment #4 from linghao2...@hotmail.com ---
I created a pull request: https://github.com/apache/poi/pull/106.
Also found another bug when test with new test case for my code. This bug
exists all the time. I have commented out the failed new case and add a TODO on
it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62242] Shouldn't show '0' if number format is "??" and cell value is 0

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62242

--- Comment #3 from linghao2...@hotmail.com ---
Found already there is a TODO in unit test TestCellFormat.java :

// TODO Fix these to not have an incorrect bonus 0 on the end 
//assertEquals(" "+pound+"   -   ", cfUK.apply(Double.valueOf(0)).text);
//assertEquals(" -"+euro+"  ", cfFR.apply(Double.valueOf(0)).text);

so it's a known issue. I have tried to fix code in my way, it works but leads
other case failed.

I will create a pull request if I find the correct way. I hope so.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62242] Shouldn't show '0' if number format is "??" and cell value is 0

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62242

--- Comment #2 from linghao2...@hotmail.com ---
I'm not sure whether it's a bug or a feature. Maybe for some reasons, the zero
character must appear at least once?
If nobody knows that, I can create a pull request and do some unit test, a few
days later. I need more time to confirm the current logic.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62242] Shouldn't show '0' if number format is "??" and cell value is 0

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62242

PJ Fanning  changed:

   What|Removed |Added

 OS||All

--- Comment #1 from PJ Fanning  ---
Thanks for reporting and investigating the issue. Could you create a Pull
Request on https://github.com/apache/poi with a test case?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org