[Bug 62768] OPCPackage#close() method is incorrectly synchronized

2018-09-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62768

--- Comment #4 from PJ Fanning  ---
I'll remove the synchronized keyword

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 62768] OPCPackage#close() method is incorrectly synchronized

2018-09-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62768

--- Comment #3 from Danila Galimov  ---
Yes, I agree, maybe the synchronization should be removed at all, but the
classes should be annotated that they are designed to be used in single-thread
environment only.

I just opened the file and found dummy synchronization which won't work anyway,
that's why i reported this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 62768] OPCPackage#close() method is incorrectly synchronized

2018-09-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62768

--- Comment #2 from Dominik Stadler  ---
I am wondering why we even use synchronization here at all. 

Our thread-safety guarantee does not allow to use one workbook/doc/item in more
than one thread at a time anyway. So this synchronization is not really
necessary as we ask our users to perform synchronization at an upper level
anyway, if they want to access documents across different threads...

Having all of POI fully thread-safe would require many many points of
synchronization and would cause a performance penalty for many current
power-users.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 62768] OPCPackage#close() method is incorrectly synchronized

2018-09-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62768

PJ Fanning  changed:

   What|Removed |Added

 OS||All
 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from PJ Fanning  ---
https://svn.apache.org/repos/asf/poi/trunk@1842142

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org