[Bug 64838] Loading and saving a file adds an unwanted tag resulting in additional newlines in the document

2021-05-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64838

--- Comment #7 from Sayi  ---
see bug #65292

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 64838] Loading and saving a file adds an unwanted tag resulting in additional newlines in the document

2020-12-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64838

Dominik Stadler  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #6 from Dominik Stadler  ---
I thought some more about this and decided to try to remove this behavior as it
seems unwanted and is likely a very old remnant of the early implementation
here. 

We'll see if there are cases that need this behavior and can then re-add it
under some better conditions that do not change files in such an unexpected
way.

This is done via r1884958.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 64838] Loading and saving a file adds an unwanted tag resulting in additional newlines in the document

2020-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64838

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 64838] Loading and saving a file adds an unwanted tag resulting in additional newlines in the document

2020-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64838

--- Comment #5 from Dominik Stadler  ---
The following change would remove this check and adding of the paragraph, but
it seems to have been added for a reason a long time ago, probably for a
similar reason to what Sayi explained, so I fear reverting this in general
might have side-effects on other documents.


Index: src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFTableCell.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===
--- src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFTableCell.java
(revision d427ca10e24dfc4b43985a0dd87ad750ca1e18ba)
+++ src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFTableCell.java
(revision 3304c1bdfa571730386f147116586917ac40762f)
@@ -80,9 +80,7 @@
 this.ctTc = cell;
 this.part = part;
 this.tableRow = tableRow;
-// NB: If a table cell does not include at least one block-level
element, then this document shall be considered corrupt.
-if (cell.sizeOfPArray() < 1)
-cell.addNewP();
+
 bodyElements = new ArrayList<>();
 paragraphs = new ArrayList<>();
 tables = new ArrayList<>();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 64838] Loading and saving a file adds an unwanted tag resulting in additional newlines in the document

2020-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64838

Dominik Stadler  changed:

   What|Removed |Added

Summary|Loading and saving a file,  |Loading and saving a file
   |adds an unwanted  tag |adds an unwanted  tag
   ||resulting in additional
   ||newlines in the document

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org