[GitHub] [poi] centic9 commented on a change in pull request #224: Use Log4j 2 for logging
centic9 commented on a change in pull request #224: URL: https://github.com/apache/poi/pull/224#discussion_r575051285 ## File path: log4j2-console.xml ## @@ -0,0 +1,42 @@ + Review comment: Thanks for the effort, to me it looks clearer this way as it makes it easy to see that these files are only used for tests and not deployed as part of the released library itself. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] centic9 commented on a change in pull request #224: Use Log4j 2 for logging
centic9 commented on a change in pull request #224: URL: https://github.com/apache/poi/pull/224#discussion_r568637101 ## File path: log4j2-console.xml ## @@ -0,0 +1,42 @@ + Review comment: Is there a way to move the two xml-configuration files away from the root-directory? For other logging frameworks these are loaded via the classpath, so would go to the "src/resources". Not sure how this would work in the actual deployment of Apache POI as part of a bigger application, would they also have to store those files in some additional directory and need to set the system-property? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] [poi] centic9 commented on a change in pull request #224: Use Log4j 2 for logging
centic9 commented on a change in pull request #224: URL: https://github.com/apache/poi/pull/224#discussion_r568637101 ## File path: log4j2-console.xml ## @@ -0,0 +1,42 @@ + Review comment: Is there a way to move the two xml-configuration files away from the root-directory? For other logging frameworks these are loaded via the classpath, so would go to the "src/resources". Not sure how this would work in the actual deployment of Apache POI as part of a bigger application, would they also have to store those files in some additional directory and need to set the system-property? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
