Re: [GitHub] poi pull request #79: Remove the method invocation of toString on a string.
Looks like all of the String.toString() calls have been removed. I added this to the forbidden APIs list in r1812239 to eliminate this problem from recurring. On Oct 15, 2017 17:42, "Javen O'Neal" wrote: We can probably add String.toString() to forbidden APIs to make sure there aren't other usages of String.toString and that this stays fixed in the future. Even if String.toString gets compiled out and therefore doesn't affect library performance, it could be confusing for someone reading the code. Are there any reasons to keep String.toString() usages? Perhaps String.toString(Locale). On Oct 15, 2017 13:34, "asfgit" wrote: > Github user asfgit closed the pull request at: > > https://github.com/apache/poi/pull/79 > > > --- > > - > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org > For additional commands, e-mail: dev-h...@poi.apache.org > >
Re: [GitHub] poi pull request #79: Remove the method invocation of toString on a string.
We can probably add String.toString() to forbidden APIs to make sure there aren't other usages of String.toString and that this stays fixed in the future. Even if String.toString gets compiled out and therefore doesn't affect library performance, it could be confusing for someone reading the code. Are there any reasons to keep String.toString() usages? Perhaps String.toString(Locale). On Oct 15, 2017 13:34, "asfgit" wrote: > Github user asfgit closed the pull request at: > > https://github.com/apache/poi/pull/79 > > > --- > > - > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org > For additional commands, e-mail: dev-h...@poi.apache.org > >
[GitHub] poi pull request #79: Remove the method invocation of toString on a string.
Github user asfgit closed the pull request at: https://github.com/apache/poi/pull/79 --- - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[GitHub] poi pull request #79: Remove the method invocation of toString on a string.
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/poi/pull/79 Remove the method invocation of toString on a string. Calling String.toString() is just a redundant operation. Just use the String. http://findbugs.sourceforge.net/bugDescriptions.html#DM_STRING_TOSTRING You can merge this pull request into a Git repository by running: $ git pull https://github.com/BruceKuiLiu/poi trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/poi/pull/79.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #79 commit 28e706c86187d033619c9590d48b16778535f88f Author: Kui LIU Date: 2017-10-12T21:16:12Z Remove the method invocation of toString on a string. Calling String.toString() is just a redundant operation. Just use the String. http://findbugs.sourceforge.net/bugDescriptions.html#DM_STRING_TOSTRING --- - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
