Re: XSSF tables - anyone know much about them?

2017-06-09 Thread Greg Woolsey
Looks good so far, I think you are on the right track.  Keeping things in
sync is a real pain since tables are a logical structure stored completely
independent of the actual cells they are supposed to reference.

In particular I'm glad for the fix to use DataFormatter to get the text
representation of table headers.

On Thu, Jun 8, 2017 at 9:46 AM Greg Woolsey  wrote:

> I'm using XSSF tables all the time, but for reading and updating, not
> writing.  I'll take a look tomorrow at your stuff (meetings all day
> today).  I've recently added support to read table formatting without
> needing direct access to the CT classes, for example.
>
> On Thu, Jun 8, 2017 at 9:21 AM Nick Burch  wrote:
>
>> Hi All
>>
>> Yesterday I came across a post on stackoverflow with a user having trouble
>> with XSSF tables. In the process of fixing the bug they'd found, I also
>> had a go at tidying up their code to reduce the need to touch the raw CT
>> classes from end-user java code.
>>
>> As part of that, I've added a couple of methods, but I don't know enough
>> about the table stuff to know if they're right for all cases, plus there's
>> a few more bits we might want to improve
>>
>> Anyone know about the XSSF tables stuff? If so, any chance you could
>> review my commits from yesterday, as well as looking at the updated
>> CreateTable example, and let me know your thoughts / go ahead and fix more
>> things?
>>
>> Cheers
>> Nick
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
>> For additional commands, e-mail: dev-h...@poi.apache.org
>>
>>


Re: XSSF tables - anyone know much about them?

2017-06-08 Thread Greg Woolsey
I'm using XSSF tables all the time, but for reading and updating, not
writing.  I'll take a look tomorrow at your stuff (meetings all day
today).  I've recently added support to read table formatting without
needing direct access to the CT classes, for example.

On Thu, Jun 8, 2017 at 9:21 AM Nick Burch  wrote:

> Hi All
>
> Yesterday I came across a post on stackoverflow with a user having trouble
> with XSSF tables. In the process of fixing the bug they'd found, I also
> had a go at tidying up their code to reduce the need to touch the raw CT
> classes from end-user java code.
>
> As part of that, I've added a couple of methods, but I don't know enough
> about the table stuff to know if they're right for all cases, plus there's
> a few more bits we might want to improve
>
> Anyone know about the XSSF tables stuff? If so, any chance you could
> review my commits from yesterday, as well as looking at the updated
> CreateTable example, and let me know your thoughts / go ahead and fix more
> things?
>
> Cheers
> Nick
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>


XSSF tables - anyone know much about them?

2017-06-08 Thread Nick Burch

Hi All

Yesterday I came across a post on stackoverflow with a user having trouble 
with XSSF tables. In the process of fixing the bug they'd found, I also 
had a go at tidying up their code to reduce the need to touch the raw CT 
classes from end-user java code.


As part of that, I've added a couple of methods, but I don't know enough 
about the table stuff to know if they're right for all cases, plus there's 
a few more bits we might want to improve


Anyone know about the XSSF tables stuff? If so, any chance you could 
review my commits from yesterday, as well as looking at the updated 
CreateTable example, and let me know your thoughts / go ahead and fix more 
things?


Cheers
Nick

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org