XMLBeans 3.0.0 release vote

[pj.fanning]

Can I ask for a vote on releasing XMLBeans 3.0.0?

This branch builds and tests POI with a pre-release version of XMLBeans.
https://github.com/apache/poi/pull/113

Releasing this jar to Maven Central should just be a click of a button in
Nexus.

https://issues.apache.org/jira/browse/XMLBEANS-517?jql=project%20%3D%20XMLBEANS%20AND%20fixVersion%20%3D%20%22Version%203.0.0%22

Details on getting the source are at
https://xmlbeans.apache.org/sourceAndBinaries/index.html

My vote is +1



--
Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: XMLBeans 3.0.0 release vote

[Andreas Beeker]

Before I vote, I'd like to see the XmlBeans 3.0.0 RC version in our POI build
and although you've removed and then reverted it, it would be nice, if
we don't need to do the piccolo modifications.

So it looks like I need to do those modifications locally and find out why
the piccolo stuff makes problems ...

Andi




signature.asc
Description: OpenPGP digital signature

Re: XMLBeans 3.0.0 release vote

[Andreas Beeker]

Sorry for the confusion of pull request vs. github mirror - ... now it's on the 
SVN.

What was the problem with the piccolo removal? ... after removing the "*.orig" 
renamings it worked out of the box?

As we (POI) provide our own ContextTypeLoader (POIXMLTypeLoader), I'm just 
trying to find out, if the TypeLoader loaded via [1] is safely loading the xml 
sources.

Andi

[1] org.apache.xmlbeans.XmlBeans.getContextTypeLoader()



signature.asc
Description: OpenPGP digital signature

Re: XMLBeans 3.0.0 release vote

[pj.fanning]

Some of the github pull request builds failed and I wasn't sure what was
causing the issue. Conceptually, the POI build no longer needs any piccolo
manipulation because xmlbeans 3.0.0 removes the support for piccolo
entirely. 



--
Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Build failed in Jenkins: POI-DSL-Maven #556

[Apache Jenkins Server]

See 


Changes:

[kiwiwings] #59268 - add license header / escape unicode string

[kiwiwings] #59268 - Work on providing an updated version of XMLBeans
(imported from https://github.com/apache/poi/pull/113)

--
[...truncated 1.69 MB...]
Format is   0 (0x0)
Length is   0 (0x0)
Compressed is   false
Stream is   
org.apache.poi.hdgf.streams.UnknownStream
First few bytes are []
Stream at   0 (0x0)
Type is 0 (0x0)
Format is   0 (0x0)
Length is   0 (0x0)
Compressed is   false
Stream is   
org.apache.poi.hdgf.streams.UnknownStream
First few bytes are []
Stream at   0 (0x0)
Type is 0 (0x0)
Format is   0 (0x0)
Length is   0 (0x0)
Compressed is   false
Stream is   
org.apache.poi.hdgf.streams.UnknownStream
First few bytes are []
Stream at   0 (0x0)
Type is 0 (0x0)
Format is   0 (0x0)
Length is   0 (0x0)
Compressed is   false
Stream is   
org.apache.poi.hdgf.streams.UnknownStream
First few bytes are []
Stream at   35148 (0x894c)
Type is 69 (0x45)
Format is   82 (0x52)
Length is   13 (0xd)
DC.Length is72 (0x48)
Compressed is   true
Stream is   
org.apache.poi.hdgf.streams.PointerContainingStream
First few bytes are [60, 0, 0, 0, 0, 0, 0, 0, 0, 0, 
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 
0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
Nbr of children 0 (0x0)
Stream at   0 (0x0)
Type is 0 (0x0)
Format is   0 (0x0)
Length is   0 (0x0)
Compressed is   false
Stream is   
org.apache.poi.hdgf.streams.UnknownStream
First few bytes are []
Stream at   0 (0x0)
Type is 0 (0x0)
Format is   0 (0x0)
Length is   0 (0x0)
Compressed is   false
Stream is   
org.apache.poi.hdgf.streams.UnknownStream
First few bytes are []
Stream at   0 (0x0)
Type is 0 (0x0)
Format is   0 (0x0)
Length is   0 (0x0)
Compressed is   false
Stream is   
org.apache.poi.hdgf.streams.UnknownStream
First few bytes are []
Stream at   0 (0x0)
Type is 0 (0x0)
Format is   0 (0x0)
Length is   0 (0x0)
Compressed is   false
Stream is   
org.apache.poi.hdgf.streams.UnknownStream
First few bytes are []
Stream at   0 (0x0)
Type is 0 (0x0)
Format is   0 (0x0)
Length is   0 (0x0)
Compressed is   false
Stream is   
org.apache.poi.hdgf.streams.UnknownStream
First few bytes are []
Stream at   0 (0x0)
Type is 0 (0x0)
Format is   0 (0x0)
Length is   0 (0x0)
Compressed is   false
Stream is   
org.apache.poi.hdgf.streams.UnknownStream
First few bytes are []
Stream at   0 (0x0)
Type is 0 (0x0)
Format is   0 (0x0)
Length is   0 (0x0)
Compressed is   false
Stream is   
org.apache.poi.hdgf.streams.UnknownStream
First few bytes are []
Stream at   0 (0x0)
Type is 0 (0x0)
Format is 

[Bug 62484] XSSFRow:OnDocumentWrite Unordered row will generate CTCells that are not referenced by _cells Treemap

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62484

--- Comment #2 from PJ Fanning  ---
We don't encourage the use of the generated CT classes. The public APIs that we
support are the XSSF ones.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62484] XSSFRow:OnDocumentWrite Unordered row will generate CTCells that are not referenced by _cells Treemap

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62484

PJ Fanning  changed:

   What|Removed |Added

   Severity|blocker |normal

--- Comment #1 from PJ Fanning  ---
Marking as `normal` priority - I don't agree this a blocker.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Build failed in Jenkins: POI-DSL-1.8 #436

[Apache Jenkins Server]

bookFactory.java>:45:
 error: exception not thrown: 
org.apache.poi.openxml4j.exceptions.InvalidFormatException
  [javadoc]  * @throws InvalidFormatException
  [javadoc]^
  [javadoc] 
<https://builds.apache.org/job/POI-DSL-1.8/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFWorkbookFactory.java>:62:
 error: exception not thrown: 
org.apache.poi.openxml4j.exceptions.InvalidFormatException
  [javadoc]  * @throws InvalidFormatException
  [javadoc]^
  [javadoc] 
<https://builds.apache.org/job/POI-DSL-1.8/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFWorkbookFactory.java>:79:
 error: exception not thrown: 
org.apache.poi.openxml4j.exceptions.InvalidFormatException
  [javadoc]  * @throws InvalidFormatException
  [javadoc]^
  [javadoc] 
<https://builds.apache.org/job/POI-DSL-1.8/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/extensions/XSSFHeaderFooter.java>:40:
 error: semicolon missing
  [javadoc]  * section), and the date on the second line (center section). 

  [javadoc]^
  [javadoc] 
<https://builds.apache.org/job/POI-DSL-1.8/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/extensions/XSSFHeaderFooter.java>:41:
 error: bad HTML entity
  [javadoc]  * &"-,Bold"Bold &"-,Regular"Header_x000A_
  [javadoc]^
  [javadoc] 100 errors
  [javadoc] 100 warnings
  [jar] Building jar: 
<https://builds.apache.org/job/POI-DSL-1.8/ws/build/dist/maven/poi-ooxml/poi-ooxml-4.0.0-SNAPSHOT-javadoc.jar>

assemble:
  [zip] Building zip: 
<https://builds.apache.org/job/POI-DSL-1.8/ws/build/dist/poi-bin-4.0.0-SNAPSHOT-20180622.zip>
  [tar] Building tar: 
<https://builds.apache.org/job/POI-DSL-1.8/436/artifact/build/dist/poi-bin-4.0.0-SNAPSHOT-20180622.tar.gz>
  [zip] Building zip: 
<https://builds.apache.org/job/POI-DSL-1.8/ws/build/dist/poi-src-4.0.0-SNAPSHOT-20180622.zip>
  [tar] Building tar: 
<https://builds.apache.org/job/POI-DSL-1.8/436/artifact/build/dist/poi-src-4.0.0-SNAPSHOT-20180622.tar.gz>
 [echo] Creating Maven POMs

maven-poms:
 [copy] Copying 6 files to 
<https://builds.apache.org/job/POI-DSL-1.8/ws/build/dist/maven>
 [echo] Maven POMs are located in 
<https://builds.apache.org/job/POI-DSL-1.8/ws/build/dist>
 [echo] Use ant dist-nexus to deploy the artifacts in the remote repository
 [echo] Distribution located in 
<https://builds.apache.org/job/POI-DSL-1.8/ws/build/dist>
 [echo] Use "ant dist-checksum" to create md5/sha1/sha512 checksums and GPG 
signatures

findbugs:
  [get] Destination already exists (skipping): 
<https://builds.apache.org/job/POI-DSL-1.8/ws/lib/findbugs-noUpdateChecks-3.0.1.zip>
[unzip] Expanding: 
<https://builds.apache.org/job/POI-DSL-1.8/ws/lib/findbugs-noUpdateChecks-3.0.1.zip>
 into <https://builds.apache.org/job/POI-DSL-1.8/ws/build/findbugs>
 [findbugs] Executing findbugs FindBugsTask from ant task
 [findbugs] Running FindBugs...
 [findbugs] Warnings generated: 52
 [findbugs] Calculating exit code...
 [findbugs] Setting 'bugs found' flag (1)
 [findbugs] Exit code set to: 1
 [findbugs] Java Result: 1
 [findbugs] Output saved to build/findbugs.xml
 [xslt] Transforming into 
<https://builds.apache.org/job/POI-DSL-1.8/ws/build>
 [xslt] Processing 
<https://builds.apache.org/job/POI-DSL-1.8/ws/build/findbugs.xml> to 
<https://builds.apache.org/job/POI-DSL-1.8/436/artifact/build/findbugs.html>
 [xslt] Loading stylesheet 
jar:<https://builds.apache.org/job/POI-DSL-1.8/ws/build/findbugs/lib/findbugs.jar!/fancy-hist.xsl>

release-notes:
 [copy] Copying 1 file to 
<https://builds.apache.org/job/POI-DSL-1.8/ws/build/dist>

rat-check:
[mkdir] Created dir: 
<https://builds.apache.org/job/POI-DSL-1.8/ws/build/rat>
 [echo] 
 [echo] *
 [echo] Summary
 [echo] ---
 [echo] Generated at: 2018-06-22T21:50:21+00:00
 [echo] 
 [echo] Notes: 1
 [echo] Binaries: 121
 [echo] Archives: 0
 [echo] Standards: 3777
 [echo] 
 [echo] Apache Licensed: 3775
 [echo] Generated Documents: 0
 [echo] 
 [echo] JavaDocs are generated, thus a license header is optional.
 [echo] Generated files do not require license headers.
 [echo] 
 [echo] 2 Unknown Licenses
 [echo] 
 [echo] *
 [echo] 
 [echo] Files with unapproved licenses:
 [echo] 
 [echo]   
<https://builds.apache.org/job/POI-DSL-1.8/ws/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestSXSSFUnicodeSurrogates.java>
 [echo]   
<https://builds.apache.org/job/POI-DSL-1.8/ws/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFUnicodeSurrogates.java>
 [echo] 
 [echo] **

Re: XMLBeans 3.0.0 release vote

[Andreas Beeker]

I've just realized, that you've done the changes to the github mirror.
In the context of POI, I'm looking at github only as a source for patches, but 
not as our project repo.
So I try to integrate your changes locally and then to the svn repo ...

Andi

On 6/22/18 10:35 PM, Andreas Beeker wrote:
> Before I vote, I'd like to see the XmlBeans 3.0.0 RC version in our POI build
> and although you've removed and then reverted it, it would be nice, if
> we don't need to do the piccolo modifications.
>
> So it looks like I need to do those modifications locally and find out why
> the piccolo stuff makes problems ...
>
> Andi
>
>




signature.asc
Description: OpenPGP digital signature

Re: XMLBeans 3.0.0 release vote

[sebb]

On 22 June 2018 at 21:49, Andreas Beeker  wrote:
> I've just realized, that you've done the changes to the github mirror.
> In the context of POI, I'm looking at github only as a source for patches, 
> but not as our project repo.
> So I try to integrate your changes locally and then to the svn repo ...

Huh?
If GitHub is set up as a proper mirror, it should not differ from the
project repo.

There should be only one master repo which holds all changes.
If that is not the case, it seems to me that something has gone badly wrong.

> Andi
>
> On 6/22/18 10:35 PM, Andreas Beeker wrote:
>> Before I vote, I'd like to see the XmlBeans 3.0.0 RC version in our POI build
>> and although you've removed and then reverted it, it would be nice, if
>> we don't need to do the piccolo modifications.
>>
>> So it looks like I need to do those modifications locally and find out why
>> the piccolo stuff makes problems ...
>>
>> Andi
>>
>>
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59268] Work on providing an updated version of XMLBeans

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59268

--- Comment #31 from Andreas Beeker  ---
Applied PJ Fannings pull request [1] via r1834165
[1] https://github.com/apache/poi/pull/113

Leaving it open until XmlBeans 3.0.0 is released

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: XMLBeans 3.0.0 release vote

[pj.fanning]

github is a read only mirror of the poi svn - we use pull requests on github
to demonstrate proposed changes but those pull requests need to be merged
using svn commits (by POI committers)



--
Sent from: http://apache-poi.1045710.n5.nabble.com/POI-Dev-f2312866.html

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Jenkins build is back to normal : POI-DSL-1.8 #437

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 62484] New: XSSFRow:OnDocumentWrite Unordered row will generate CTCells that are not referenced by _cells Treemap

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62484

Bug ID: 62484
   Summary: XSSFRow:OnDocumentWrite Unordered row will generate
CTCells that are not referenced by _cells Treemap
   Product: POI
   Version: 3.17-FINAL
  Hardware: All
OS: All
Status: NEW
  Severity: blocker
  Priority: P2
 Component: XSSF
  Assignee: dev@poi.apache.org
  Reporter: fr...@tygron.com
  Target Milestone: ---

I have a Microsoft Excel file which has several rows that are not ordered
alphabetically. Reading and writing to this Excel file will work well, until I
write the XSSF-document to a file for the first time.

When I continued reading from and writing to cells in this document, I noticed
some cells did not update properly in the CTRows of XSSFRows.

I debugged deeper and noticed that onDocumentWrite, for XSSFRows that are not
ordered, new CTCells are created through a copy. I understand this code and it
seemed logical.


if(!isOrdered){
  cArray = new CTCell[_cells.size()];
  int i = 0;
  for (XSSFCell xssfCell : _cells.values()) {
cArray[i] = (CTCell) xssfCell.getCTCell().copy();

// we have to copy and re-create the XSSFCell here because the 
// elements as otherwise setCArray below invalidates all the columns!
// see Bug 56170, XMLBeans seems to always release previous objects
// in the CArray, so we need to provide completely new ones here!
// _cells.put(entry.getKey(), new XSSFCell(this, cArray[i]));
// xssfCell.setCTCell(cArray[i]);
i++;
  }
  _row.setCArray(cArray);
}

However, when this new CTCell array is set to the CTRow:
 _row.setCArray(cArray);
code in this method can (or often will) also copy these Cell objects again for
its own internal row.

(The underlying classes and methods doing this are:
 XmlComplexContentImpl::arraySetterHelper( XmlObject[] sources, QName elemName)
 XmlObject::set(XmlObject src) 
  -> 
if (monitor() == obj.monitor()) // both are in the same locale
{
  if (noSyncThis) // the locale is not sync
newObj = setterHelper( obj );
  else// the locale is sync
  {
synchronized (monitor()) {
  newObj = setterHelper( obj ); <-- new CTCell object is created
}
  }
}

)

The result is that the CTRow will now reference other CTCells than the _cells
TreeMap of the XSSFRow. Writing new values to these cells will only end up in
the _cells TreeMap and not in the CTRow any more. 
Consequently, writing the document a second time after having changed cell
values in these rows will write the wrong cell values.

Hopefully others are also able to reproduce this issue!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org