[jira] [Commented] (PIO-176) Clean up unmanaged sources in the data module
[
https://issues.apache.org/jira/browse/PIO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637858#comment-16637858
]
ASF GitHub Bot commented on PIO-176:
Github user asfgit closed the pull request at:
https://github.com/apache/predictionio/pull/477
> Clean up unmanaged sources in the data module
> -
>
> Key: PIO-176
> URL: https://issues.apache.org/jira/browse/PIO-176
> Project: PredictionIO
> Issue Type: Improvement
> Components: Core
>Affects Versions: 0.13.0
>Reporter: Donald Szeto
>Priority: Minor
>
> There was a hack in {{build.sbt}} for switching between Spark 1.x and 2.x
> specific code. With PIO-171 completed, that should be cleaned up.
> Specifically, these
> [lines|https://github.com/apache/predictionio/blob/718ebe2e8e98c5462d14ad2663c65288f0409972/build.sbt#L140-L141]
> should be removed. The source that it refers to should be refactored
> properly in the main source code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIO-176) Clean up unmanaged sources in the data module
[
https://issues.apache.org/jira/browse/PIO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637856#comment-16637856
]
ASF GitHub Bot commented on PIO-176:
Github user dszeto commented on the issue:
https://github.com/apache/predictionio/pull/477
LGTM. Merging. Thanks @saurabh3091 !
> Clean up unmanaged sources in the data module
> -
>
> Key: PIO-176
> URL: https://issues.apache.org/jira/browse/PIO-176
> Project: PredictionIO
> Issue Type: Improvement
> Components: Core
>Affects Versions: 0.13.0
>Reporter: Donald Szeto
>Priority: Minor
>
> There was a hack in {{build.sbt}} for switching between Spark 1.x and 2.x
> specific code. With PIO-171 completed, that should be cleaned up.
> Specifically, these
> [lines|https://github.com/apache/predictionio/blob/718ebe2e8e98c5462d14ad2663c65288f0409972/build.sbt#L140-L141]
> should be removed. The source that it refers to should be refactored
> properly in the main source code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIO-176) Clean up unmanaged sources in the data module
[
https://issues.apache.org/jira/browse/PIO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636820#comment-16636820
]
ASF GitHub Bot commented on PIO-176:
GitHub user saurabh3091 opened a pull request:
https://github.com/apache/predictionio/pull/477
[PIO-176] Clean up unmanaged sources in the data module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/saurabh3091/predictionio develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/predictionio/pull/477.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #477
commit 093a4d0ab778064f1349c21be7ff4d606d4ebbf4
Author: saurabh gulati
Date: 2018-10-02T14:22:23Z
[PIO-171] Hack in build.sbt for switching between Spark 1.x and 2.x should
be cleaned up.
commit 977186ad43794885ca6d46606395eaccec0f292c
Author: saurabh gulati
Date: 2018-10-03T09:42:56Z
[PIO-176] reverted PPythonEventStore and added it to 'data' module
commit 7b93a7c8796358cedf482419d3fe4ae9c990ccfb
Author: saurabh gulati
Date: 2018-10-03T11:21:18Z
[PIO-176] added a new line at the end
> Clean up unmanaged sources in the data module
> -
>
> Key: PIO-176
> URL: https://issues.apache.org/jira/browse/PIO-176
> Project: PredictionIO
> Issue Type: Improvement
> Components: Core
>Affects Versions: 0.13.0
>Reporter: Donald Szeto
>Priority: Minor
>
> There was a hack in {{build.sbt}} for switching between Spark 1.x and 2.x
> specific code. With PIO-171 completed, that should be cleaned up.
> Specifically, these
> [lines|https://github.com/apache/predictionio/blob/718ebe2e8e98c5462d14ad2663c65288f0409972/build.sbt#L140-L141]
> should be removed. The source that it refers to should be refactored
> properly in the main source code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIO-176) Clean up unmanaged sources in the data module
[
https://issues.apache.org/jira/browse/PIO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636817#comment-16636817
]
ASF GitHub Bot commented on PIO-176:
Github user saurabh3091 closed the pull request at:
https://github.com/apache/predictionio/pull/476
> Clean up unmanaged sources in the data module
> -
>
> Key: PIO-176
> URL: https://issues.apache.org/jira/browse/PIO-176
> Project: PredictionIO
> Issue Type: Improvement
> Components: Core
>Affects Versions: 0.13.0
>Reporter: Donald Szeto
>Priority: Minor
>
> There was a hack in {{build.sbt}} for switching between Spark 1.x and 2.x
> specific code. With PIO-171 completed, that should be cleaned up.
> Specifically, these
> [lines|https://github.com/apache/predictionio/blob/718ebe2e8e98c5462d14ad2663c65288f0409972/build.sbt#L140-L141]
> should be removed. The source that it refers to should be refactored
> properly in the main source code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIO-176) Clean up unmanaged sources in the data module
[
https://issues.apache.org/jira/browse/PIO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636709#comment-16636709
]
ASF GitHub Bot commented on PIO-176:
Github user saurabh3091 commented on the issue:
https://github.com/apache/predictionio/pull/476
IntelliJ was unable to figure out the usage of PPythonEventOperator in
python module.
How do you guys check this? (or do i need to find the word usage through
whole project)
> Clean up unmanaged sources in the data module
> -
>
> Key: PIO-176
> URL: https://issues.apache.org/jira/browse/PIO-176
> Project: PredictionIO
> Issue Type: Improvement
> Components: Core
>Affects Versions: 0.13.0
>Reporter: Donald Szeto
>Priority: Minor
>
> There was a hack in {{build.sbt}} for switching between Spark 1.x and 2.x
> specific code. With PIO-171 completed, that should be cleaned up.
> Specifically, these
> [lines|https://github.com/apache/predictionio/blob/718ebe2e8e98c5462d14ad2663c65288f0409972/build.sbt#L140-L141]
> should be removed. The source that it refers to should be refactored
> properly in the main source code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIO-176) Clean up unmanaged sources in the data module
[
https://issues.apache.org/jira/browse/PIO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636701#comment-16636701
]
ASF GitHub Bot commented on PIO-176:
GitHub user saurabh3091 opened a pull request:
https://github.com/apache/predictionio/pull/476
[PIO-176] Revert PPythonEventStore and add it to 'data' module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/saurabh3091/predictionio develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/predictionio/pull/476.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #476
commit 093a4d0ab778064f1349c21be7ff4d606d4ebbf4
Author: saurabh gulati
Date: 2018-10-02T14:22:23Z
[PIO-171] Hack in build.sbt for switching between Spark 1.x and 2.x should
be cleaned up.
commit 977186ad43794885ca6d46606395eaccec0f292c
Author: saurabh gulati
Date: 2018-10-03T09:42:56Z
[PIO-176] reverted PPythonEventStore and added it to 'data' module
> Clean up unmanaged sources in the data module
> -
>
> Key: PIO-176
> URL: https://issues.apache.org/jira/browse/PIO-176
> Project: PredictionIO
> Issue Type: Improvement
> Components: Core
>Affects Versions: 0.13.0
>Reporter: Donald Szeto
>Priority: Minor
>
> There was a hack in {{build.sbt}} for switching between Spark 1.x and 2.x
> specific code. With PIO-171 completed, that should be cleaned up.
> Specifically, these
> [lines|https://github.com/apache/predictionio/blob/718ebe2e8e98c5462d14ad2663c65288f0409972/build.sbt#L140-L141]
> should be removed. The source that it refers to should be refactored
> properly in the main source code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIO-176) Clean up unmanaged sources in the data module
[
https://issues.apache.org/jira/browse/PIO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636699#comment-16636699
]
ASF GitHub Bot commented on PIO-176:
Github user saurabh3091 closed the pull request at:
https://github.com/apache/predictionio/pull/475
> Clean up unmanaged sources in the data module
> -
>
> Key: PIO-176
> URL: https://issues.apache.org/jira/browse/PIO-176
> Project: PredictionIO
> Issue Type: Improvement
> Components: Core
>Affects Versions: 0.13.0
>Reporter: Donald Szeto
>Priority: Minor
>
> There was a hack in {{build.sbt}} for switching between Spark 1.x and 2.x
> specific code. With PIO-171 completed, that should be cleaned up.
> Specifically, these
> [lines|https://github.com/apache/predictionio/blob/718ebe2e8e98c5462d14ad2663c65288f0409972/build.sbt#L140-L141]
> should be removed. The source that it refers to should be refactored
> properly in the main source code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIO-176) Clean up unmanaged sources in the data module
[
https://issues.apache.org/jira/browse/PIO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636372#comment-16636372
]
ASF GitHub Bot commented on PIO-176:
Github user shimamoto commented on the issue:
https://github.com/apache/predictionio/pull/475
Yeah, it's necessary for python/pypio for now. We can probably remove it
after supporting Spark ML natively.
> Clean up unmanaged sources in the data module
> -
>
> Key: PIO-176
> URL: https://issues.apache.org/jira/browse/PIO-176
> Project: PredictionIO
> Issue Type: Improvement
> Components: Core
>Affects Versions: 0.13.0
>Reporter: Donald Szeto
>Priority: Minor
>
> There was a hack in {{build.sbt}} for switching between Spark 1.x and 2.x
> specific code. With PIO-171 completed, that should be cleaned up.
> Specifically, these
> [lines|https://github.com/apache/predictionio/blob/718ebe2e8e98c5462d14ad2663c65288f0409972/build.sbt#L140-L141]
> should be removed. The source that it refers to should be refactored
> properly in the main source code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIO-176) Clean up unmanaged sources in the data module
[
https://issues.apache.org/jira/browse/PIO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636216#comment-16636216
]
ASF GitHub Bot commented on PIO-176:
Github user marevol commented on the issue:
https://github.com/apache/predictionio/pull/475
PPythonEventStore is used in python/pypio.
> Clean up unmanaged sources in the data module
> -
>
> Key: PIO-176
> URL: https://issues.apache.org/jira/browse/PIO-176
> Project: PredictionIO
> Issue Type: Improvement
> Components: Core
>Affects Versions: 0.13.0
>Reporter: Donald Szeto
>Priority: Minor
>
> There was a hack in {{build.sbt}} for switching between Spark 1.x and 2.x
> specific code. With PIO-171 completed, that should be cleaned up.
> Specifically, these
> [lines|https://github.com/apache/predictionio/blob/718ebe2e8e98c5462d14ad2663c65288f0409972/build.sbt#L140-L141]
> should be removed. The source that it refers to should be refactored
> properly in the main source code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIO-176) Clean up unmanaged sources in the data module
[
https://issues.apache.org/jira/browse/PIO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635588#comment-16635588
]
ASF GitHub Bot commented on PIO-176:
Github user saurabh3091 commented on the issue:
https://github.com/apache/predictionio/pull/475
Please review and let me know if I missed anything.
Thanks a lot for your support guys.
> Clean up unmanaged sources in the data module
> -
>
> Key: PIO-176
> URL: https://issues.apache.org/jira/browse/PIO-176
> Project: PredictionIO
> Issue Type: Improvement
> Components: Core
>Affects Versions: 0.13.0
>Reporter: Donald Szeto
>Priority: Minor
>
> There was a hack in {{build.sbt}} for switching between Spark 1.x and 2.x
> specific code. With PIO-171 completed, that should be cleaned up.
> Specifically, these
> [lines|https://github.com/apache/predictionio/blob/718ebe2e8e98c5462d14ad2663c65288f0409972/build.sbt#L140-L141]
> should be removed. The source that it refers to should be refactored
> properly in the main source code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIO-176) Clean up unmanaged sources in the data module
[
https://issues.apache.org/jira/browse/PIO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635580#comment-16635580
]
ASF GitHub Bot commented on PIO-176:
GitHub user saurabh3091 opened a pull request:
https://github.com/apache/predictionio/pull/475
[PIO-176] Hack in build.sbt for switching between Spark 1.x and 2.x s…
- Removed unmanagedSourceDirectories in data module
- refactored sqlSession code blocks to use SparkSession instead of
SqlContext
- removed PPythonEventStore.scala as it was not being used anywhere.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/saurabh3091/predictionio develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/predictionio/pull/475.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #475
commit 093a4d0ab778064f1349c21be7ff4d606d4ebbf4
Author: saurabh gulati
Date: 2018-10-02T14:22:23Z
[PIO-171] Hack in build.sbt for switching between Spark 1.x and 2.x should
be cleaned up.
> Clean up unmanaged sources in the data module
> -
>
> Key: PIO-176
> URL: https://issues.apache.org/jira/browse/PIO-176
> Project: PredictionIO
> Issue Type: Improvement
> Components: Core
>Affects Versions: 0.13.0
>Reporter: Donald Szeto
>Priority: Minor
>
> There was a hack in {{build.sbt}} for switching between Spark 1.x and 2.x
> specific code. With PIO-171 completed, that should be cleaned up.
> Specifically, these
> [lines|https://github.com/apache/predictionio/blob/718ebe2e8e98c5462d14ad2663c65288f0409972/build.sbt#L140-L141]
> should be removed. The source that it refers to should be refactored
> properly in the main source code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
