[GitHub] incubator-predictionio issue #421: Elasticsearch 5.x singleton client with a...
Github user mars commented on the issue: https://github.com/apache/incubator-predictionio/pull/421 I will resolve these conflicts today and then merge this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #421: Elasticsearch 5.x singleton client with a...
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/421 @mars LGTM! but sorry for conflict with my previous commit: 6789dbeb71b1cc7f13a385032da6fbc3b8cf7a12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #421: Elasticsearch 5.x singleton client with a...
Github user mars commented on the issue: https://github.com/apache/incubator-predictionio/pull/421 ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #421: Elasticsearch 5.x singleton client with a...
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/421 > I addressed all your Scala style & usage suggestions. ð > Still need to take care of the threadsafety issue with the singleton client. Yes, I'm reviewing the PIO codebase from this point of view now, but still my understanding about the whole PIO is not enough... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #421: Elasticsearch 5.x singleton client with a...
Github user mars commented on the issue: https://github.com/apache/incubator-predictionio/pull/421 Based on these [Scala Concurrency/Thread Safety docs](https://twitter.github.io/scala_school/concurrency.html#danger), I believe simply annotating `@volatile` will cause the synchronization needed for thread-safety in this case. So, I updated this PR with that change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-predictionio issue #421: Elasticsearch 5.x singleton client with a...
Github user mars commented on the issue: https://github.com/apache/incubator-predictionio/pull/421 Cheers @takezoe I addressed all your Scala style & usage suggestions. Still need to take care of the threadsafety issue with the singleton client. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
