[
https://issues.apache.org/jira/browse/PIO-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148202#comment-16148202
]
Donald Szeto edited comment on PIO-99 at 8/30/17 11:20 PM:
-----------------------------------------------------------
To reproduce:
# Build an engine that will return a successful run.
# Purposely introduce a syntax error in engine code.
# Build again.
This is a bug because log lines above mentioned it ran into an error and was
going to abort, but it did not and proceeded to check for build JARs, which
succeeded because there was a good previous build.
was (Author: dszeto):
To reproduce:
1. Build an engine that will return a successful run.
2. Purposely introduce a syntax error in engine code.
3. Build again.
This is a bug because log lines above mentioned it ran into an error and was
going to abort, but it did not and proceeded to check for build JARs, which
succeeded because there was a good previous build.
> `pio build` exits successfully even when compilation fails
> ----------------------------------------------------------
>
> Key: PIO-99
> URL: https://issues.apache.org/jira/browse/PIO-99
> Project: PredictionIO
> Issue Type: Bug
> Components: Build
> Affects Versions: 0.11.0-incubating
> Reporter: Mars Hall
> Labels: newbie
>
> The build command does not fail as expected. While not a big deal when
> working locally, it seems like this could be problematic for automated,
> continuous build/integration workflows.
> {code}
> $ pio build
> …
> [ERROR] [Engine$] [error] one error found
> [ERROR] [Engine$] [error] (compile:compileIncremental) Compilation failed
> [ERROR] [Engine$] [error] Total time: 5 s, completed Jun 21, 2017 9:59:55 AM
> [ERROR] [Engine$] Return code of build command:
> /Users/mars.hall/Projects/predictionio-engine-ur/PredictionIO-dist/sbt/sbt
> package assemblyPackageDependency is 1. Aborting.
> [INFO] [Engine$] Looking for an engine...
> [INFO] [Engine$] Found universal-recommender-assembly-0.5.0-deps.jar
> [INFO] [Engine$] Found universal-recommender_2.11-0.5.0.jar
> [INFO] [Engine$] Build finished successfully.
> [INFO] [Pio$] Your engine is ready for training.
> {code}
> It certainly appears successful at the end, and exit code was {{0}}.
> Looking back for the error is not hard, but this behavior is problematic when
> composing {{pio build}} command into a shell script.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
