[jira] [Commented] (PIO-104) Make proper implementation of plugins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PIO-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105616#comment-16105616
 ] 

ASF GitHub Bot commented on PIO-104:


Github user asfgit closed the pull request at:

https://github.com/apache/incubator-predictionio/pull/407


> Make proper implementation of plugins
> -
>
> Key: PIO-104
> URL: https://issues.apache.org/jira/browse/PIO-104
> Project: PredictionIO
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 0.11.0-incubating
>Reporter: Naoki Takezoe
>Assignee: Naoki Takezoe
> Fix For: 0.12.0-incubating
>
>
> The current plugin system has some issues to be fixed:
> - start() method of plugin is not called, this method seems to be unnecessary
> - outputSniffer exists as interface, but it's not implemented in engine server
> We should fix them before documenting plugin usage in PIO-101



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PIO-104) Make proper implementation of plugins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PIO-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085250#comment-16085250
 ] 

ASF GitHub Bot commented on PIO-104:


GitHub user takezoe opened a pull request:

https://github.com/apache/incubator-predictionio/pull/407

[PIO-104] Make proper implementation of plugins

- Remove start() method of EventServerPlugin and EngineServerPlugin
- Send prediction result to outputSniffers in the engine server


http://mail-archives.apache.org/mod_mbox/incubator-predictionio-dev/201706.mbox/%3CCAF_HxLtEonOVALSQgrCRGXctAbL7eypxwG0ErHpaBJJym15j5Q%40mail.gmail.com%3E

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/takezoe/incubator-predictionio fix-plugin-impl

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-predictionio/pull/407.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #407


commit 66218c8167c200109aea423af2f1ac543082d633
Author: Naoki Takezoe 
Date:   2017-07-13T06:12:29Z

[PIO-104] Make proper implementation of plugins

- Remove start() method of EventServerPlugin and EngineServerPlugin
- Send prediction result to outputSniffers in the engine server




> Make proper implementation of plugins
> -
>
> Key: PIO-104
> URL: https://issues.apache.org/jira/browse/PIO-104
> Project: PredictionIO
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 0.11.0-incubating
>Reporter: Naoki Takezoe
>Assignee: Naoki Takezoe
>
> The current plugin system has some issues to be fixed:
> - start() method of plugin is not called, this method seems to be unnecessary
> - outputSniffer exists as interface, but it's not implemented in engine server
> We should fix them before documenting plugin usage in PIO-101



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)