[jira] [Commented] (PIO-35) Add integration tests for major templates
[ https://issues.apache.org/jira/browse/PIO-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570398#comment-15570398 ] ASF GitHub Bot commented on PIO-35: --- Github user chanlee514 closed the pull request at: https://github.com/apache/incubator-predictionio/pull/300 > Add integration tests for major templates > - > > Key: PIO-35 > URL: https://issues.apache.org/jira/browse/PIO-35 > Project: PredictionIO > Issue Type: Improvement >Reporter: Chan > > Developers of engine templates should be able to test that their template > works with the latest changes in PredictionIO. As a starting point, we can > expand the integration test suite to all previously "official" templates. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIO-35) Add integration tests for major templates
[
https://issues.apache.org/jira/browse/PIO-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524988#comment-15524988
]
ASF GitHub Bot commented on PIO-35:
---
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/300#discussion_r80616820
--- Diff: tests/pio_tests/scenarios/basic_app_usecases.py ---
@@ -61,17 +61,13 @@ class BasicAppUsecases(BaseTestCase):
def setUp(self):
random.seed(3)
self.log.info("Setting up the engine")
-
-template_path = pjoin(
-self.test_context.engine_directory, "recommendation-engine")
+template_path =
"https://github.com/chanlee514/template-scala-parallel-recommendation;
--- End diff --
That's a good idea. In fact, the templates have been donated and are in the
process of migrating to Apache. I will ping you when that's done, so you can
start using those new Git URLs as well.
> Add integration tests for major templates
> -
>
> Key: PIO-35
> URL: https://issues.apache.org/jira/browse/PIO-35
> Project: PredictionIO
> Issue Type: Improvement
>Reporter: Chan
>
> Developers of engine templates should be able to test that their template
> works with the latest changes in PredictionIO. As a starting point, we can
> expand the integration test suite to all previously "official" templates.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIO-35) Add integration tests for major templates
[
https://issues.apache.org/jira/browse/PIO-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517580#comment-15517580
]
ASF GitHub Bot commented on PIO-35:
---
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/300#discussion_r80327209
--- Diff:
tests/pio_tests/data/eventserver_test/partially_malformed_events.json ---
@@ -1,10 +1,10 @@
[
- {
+ {
"event" : "test",
"entityType" : "test",
"entityId" : "t2"
},
{
-"event" : "malformed-event"
+"event" : "malformed-event"
}
]
--- End diff --
Would be nice to have a newline here.
> Add integration tests for major templates
> -
>
> Key: PIO-35
> URL: https://issues.apache.org/jira/browse/PIO-35
> Project: PredictionIO
> Issue Type: Improvement
>Reporter: Chan
>
> Developers of engine templates should be able to test that their template
> works with the latest changes in PredictionIO. As a starting point, we can
> expand the integration test suite to all previously "official" templates.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIO-35) Add integration tests for major templates
[
https://issues.apache.org/jira/browse/PIO-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517581#comment-15517581
]
ASF GitHub Bot commented on PIO-35:
---
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/300#discussion_r80327618
--- Diff: tests/pio_tests/scenarios/basic_app_usecases.py ---
@@ -61,17 +61,13 @@ class BasicAppUsecases(BaseTestCase):
def setUp(self):
random.seed(3)
self.log.info("Setting up the engine")
-
-template_path = pjoin(
-self.test_context.engine_directory, "recommendation-engine")
+template_path =
"https://github.com/chanlee514/template-scala-parallel-recommendation;
--- End diff --
Any changes to your fork's template? We should use official ones.
> Add integration tests for major templates
> -
>
> Key: PIO-35
> URL: https://issues.apache.org/jira/browse/PIO-35
> Project: PredictionIO
> Issue Type: Improvement
>Reporter: Chan
>
> Developers of engine templates should be able to test that their template
> works with the latest changes in PredictionIO. As a starting point, we can
> expand the integration test suite to all previously "official" templates.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIO-35) Add integration tests for major templates
[ https://issues.apache.org/jira/browse/PIO-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517582#comment-15517582 ] ASF GitHub Bot commented on PIO-35: --- Github user dszeto commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/300#discussion_r80326911 --- Diff: .travis.yml --- @@ -68,7 +69,7 @@ env: before_install: - unset SBT_OPTS JVM_OPTS - - docker pull ziemin/pio-testing + - docker pull chanlee514/pio-testing --- End diff -- I think we should put this under `predictionio` org on Docker Hub. We are missing something that automatically build and tag these testing container images properly. Let me work on it and we can modify our integration test to pick up the proper container. > Add integration tests for major templates > - > > Key: PIO-35 > URL: https://issues.apache.org/jira/browse/PIO-35 > Project: PredictionIO > Issue Type: Improvement >Reporter: Chan > > Developers of engine templates should be able to test that their template > works with the latest changes in PredictionIO. As a starting point, we can > expand the integration test suite to all previously "official" templates. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
