[jira] [Commented] (PIO-56) Unit tests in module core should not require real setup

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PIO-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103679#comment-16103679
 ] 

ASF GitHub Bot commented on PIO-56:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-predictionio/pull/355


> Unit tests in module core should not require real setup
> ---
>
> Key: PIO-56
> URL: https://issues.apache.org/jira/browse/PIO-56
> Project: PredictionIO
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 0.10.0-incubating
> Environment: Tested with Mac OS X, i7, 8GB
>Reporter: Lucas Bonatto Miguel
>  Labels: development_environment
>
> *This issue affects only developers*
> When downloading the code from github and trying to run the tests of the 
> project core via sbt, one will face an error stating that the METADATA 
> configuration is missing, e.g:
> [ERROR] [Storage$] Required repository (METADATA) configuration is missing.
> [ERROR] [Storage$] There were 1 configuration errors. Exiting.
> It looks like the project predictionio core requires a METADATA datasource 
> (elasticsearch) installed and configured in the developer machine.
> There are some benefits if the project require less external 
> installation/configuration:
>  - Developers would have an easy setup of the environment.
>  - Continuous integration would be easier
> How to reproduce:
>  - Download predictionio from github
>  - In root folder run ./make-distribution.sh
>  - In root folder run sbt core/test



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PIO-56) Unit tests in module core should not require real setup

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PIO-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103678#comment-16103678
 ] 

ASF GitHub Bot commented on PIO-56:
---

Github user dszeto commented on the issue:

https://github.com/apache/incubator-predictionio/pull/355
  
Sorry for the late reply. LGTM and merging. Thanks @lucasbm88 !


> Unit tests in module core should not require real setup
> ---
>
> Key: PIO-56
> URL: https://issues.apache.org/jira/browse/PIO-56
> Project: PredictionIO
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 0.10.0-incubating
> Environment: Tested with Mac OS X, i7, 8GB
>Reporter: Lucas Bonatto Miguel
>  Labels: development_environment
>
> *This issue affects only developers*
> When downloading the code from github and trying to run the tests of the 
> project core via sbt, one will face an error stating that the METADATA 
> configuration is missing, e.g:
> [ERROR] [Storage$] Required repository (METADATA) configuration is missing.
> [ERROR] [Storage$] There were 1 configuration errors. Exiting.
> It looks like the project predictionio core requires a METADATA datasource 
> (elasticsearch) installed and configured in the developer machine.
> There are some benefits if the project require less external 
> installation/configuration:
>  - Developers would have an easy setup of the environment.
>  - Continuous integration would be easier
> How to reproduce:
>  - Download predictionio from github
>  - In root folder run ./make-distribution.sh
>  - In root folder run sbt core/test



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PIO-56) Unit tests in module core should not require real setup

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PIO-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16059788#comment-16059788
 ] 

ASF GitHub Bot commented on PIO-56:
---

Github user brunitto commented on the issue:

https://github.com/apache/incubator-predictionio/pull/355
  
+1


> Unit tests in module core should not require real setup
> ---
>
> Key: PIO-56
> URL: https://issues.apache.org/jira/browse/PIO-56
> Project: PredictionIO
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 0.10.0-incubating
> Environment: Tested with Mac OS X, i7, 8GB
>Reporter: Lucas Bonatto Miguel
>  Labels: development_environment
>
> *This issue affects only developers*
> When downloading the code from github and trying to run the tests of the 
> project core via sbt, one will face an error stating that the METADATA 
> configuration is missing, e.g:
> [ERROR] [Storage$] Required repository (METADATA) configuration is missing.
> [ERROR] [Storage$] There were 1 configuration errors. Exiting.
> It looks like the project predictionio core requires a METADATA datasource 
> (elasticsearch) installed and configured in the developer machine.
> There are some benefits if the project require less external 
> installation/configuration:
>  - Developers would have an easy setup of the environment.
>  - Continuous integration would be easier
> How to reproduce:
>  - Download predictionio from github
>  - In root folder run ./make-distribution.sh
>  - In root folder run sbt core/test



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PIO-56) Unit tests in module core should not require real setup

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PIO-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896577#comment-15896577
 ] 

ASF GitHub Bot commented on PIO-56:
---

Github user lucasbm88 commented on the issue:

https://github.com/apache/incubator-predictionio/pull/355
  
Got it, I will wait until you merge your code to update mine.

Thx for the clarification.


> Unit tests in module core should not require real setup
> ---
>
> Key: PIO-56
> URL: https://issues.apache.org/jira/browse/PIO-56
> Project: PredictionIO
>  Issue Type: Improvement
>Affects Versions: 0.10.0-incubating
> Environment: Tested with Mac OS X, i7, 8GB
>Reporter: Lucas Bonatto Miguel
>  Labels: development_environment
> Fix For: 0.11.0
>
>
> *This issue affects only developers*
> When downloading the code from github and trying to run the tests of the 
> project core via sbt, one will face an error stating that the METADATA 
> configuration is missing, e.g:
> [ERROR] [Storage$] Required repository (METADATA) configuration is missing.
> [ERROR] [Storage$] There were 1 configuration errors. Exiting.
> It looks like the project predictionio core requires a METADATA datasource 
> (elasticsearch) installed and configured in the developer machine.
> There are some benefits if the project require less external 
> installation/configuration:
>  - Developers would have an easy setup of the environment.
>  - Continuous integration would be easier
> How to reproduce:
>  - Download predictionio from github
>  - In root folder run ./make-distribution.sh
>  - In root folder run sbt core/test



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (PIO-56) Unit tests in module core should not require real setup

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PIO-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895059#comment-15895059
 ] 

ASF GitHub Bot commented on PIO-56:
---

Github user marevol commented on the issue:

https://github.com/apache/incubator-predictionio/pull/355
  
My concern is core depends on Elasticsearch.
Since Elasticsearch 1.x is EOLed by elastic, it will be removed from PIO in 
the future release
and PIO will not contain elasticsearch jar in the dependencies(NodeBuilder 
does not exist).
Others are not changed.




> Unit tests in module core should not require real setup
> ---
>
> Key: PIO-56
> URL: https://issues.apache.org/jira/browse/PIO-56
> Project: PredictionIO
>  Issue Type: Improvement
>Affects Versions: 0.10.0-incubating
> Environment: Tested with Mac OS X, i7, 8GB
>Reporter: Lucas Bonatto Miguel
>  Labels: development_environment
> Fix For: 0.11.0
>
>
> *This issue affects only developers*
> When downloading the code from github and trying to run the tests of the 
> project core via sbt, one will face an error stating that the METADATA 
> configuration is missing, e.g:
> [ERROR] [Storage$] Required repository (METADATA) configuration is missing.
> [ERROR] [Storage$] There were 1 configuration errors. Exiting.
> It looks like the project predictionio core requires a METADATA datasource 
> (elasticsearch) installed and configured in the developer machine.
> There are some benefits if the project require less external 
> installation/configuration:
>  - Developers would have an easy setup of the environment.
>  - Continuous integration would be easier
> How to reproduce:
>  - Download predictionio from github
>  - In root folder run ./make-distribution.sh
>  - In root folder run sbt core/test



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (PIO-56) Unit tests in module core should not require real setup

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PIO-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894545#comment-15894545
 ] 

ASF GitHub Bot commented on PIO-56:
---

Github user lucasbm88 commented on the issue:

https://github.com/apache/incubator-predictionio/pull/355
  
Hi @marevol , thanks for the update

Yes, I noticed that you're removing elasticsearch from core, but correct if 
I'm wrong, the unit tests in the project core will continue depending on a 
METADATA configuration in order to run. If it is the case I can update my code 
to match your changes once you merge it.


> Unit tests in module core should not require real setup
> ---
>
> Key: PIO-56
> URL: https://issues.apache.org/jira/browse/PIO-56
> Project: PredictionIO
>  Issue Type: Improvement
>Affects Versions: 0.10.0-incubating
> Environment: Tested with Mac OS X, i7, 8GB
>Reporter: Lucas Bonatto Miguel
>  Labels: development_environment
> Fix For: 0.11.0
>
>
> *This issue affects only developers*
> When downloading the code from github and trying to run the tests of the 
> project core via sbt, one will face an error stating that the METADATA 
> configuration is missing, e.g:
> [ERROR] [Storage$] Required repository (METADATA) configuration is missing.
> [ERROR] [Storage$] There were 1 configuration errors. Exiting.
> It looks like the project predictionio core requires a METADATA datasource 
> (elasticsearch) installed and configured in the developer machine.
> There are some benefits if the project require less external 
> installation/configuration:
>  - Developers would have an easy setup of the environment.
>  - Continuous integration would be easier
> How to reproduce:
>  - Download predictionio from github
>  - In root folder run ./make-distribution.sh
>  - In root folder run sbt core/test



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (PIO-56) Unit tests in module core should not require real setup

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PIO-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891606#comment-15891606
 ] 

ASF GitHub Bot commented on PIO-56:
---

Github user marevol commented on the issue:

https://github.com/apache/incubator-predictionio/pull/355
  
Please see https://github.com/apache/incubator-predictionio/pull/352
We are working on Elasticsearch 5 support.
This fix removes elasticsearch from core.


> Unit tests in module core should not require real setup
> ---
>
> Key: PIO-56
> URL: https://issues.apache.org/jira/browse/PIO-56
> Project: PredictionIO
>  Issue Type: Improvement
>Affects Versions: 0.10.0-incubating
> Environment: Tested with Mac OS X, i7, 8GB
>Reporter: Lucas Bonatto Miguel
>  Labels: development_environment
> Fix For: 0.11.0
>
>
> *This issue affects only developers*
> When downloading the code from github and trying to run the tests of the 
> project core via sbt, one will face an error stating that the METADATA 
> configuration is missing, e.g:
> [ERROR] [Storage$] Required repository (METADATA) configuration is missing.
> [ERROR] [Storage$] There were 1 configuration errors. Exiting.
> It looks like the project predictionio core requires a METADATA datasource 
> (elasticsearch) installed and configured in the developer machine.
> There are some benefits if the project require less external 
> installation/configuration:
>  - Developers would have an easy setup of the environment.
>  - Continuous integration would be easier
> How to reproduce:
>  - Download predictionio from github
>  - In root folder run ./make-distribution.sh
>  - In root folder run sbt core/test



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (PIO-56) Unit tests in module core should not require real setup

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/PIO-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891542#comment-15891542
 ] 

ASF GitHub Bot commented on PIO-56:
---

GitHub user lucasbm88 opened a pull request:

https://github.com/apache/incubator-predictionio/pull/355

[PIO-56] Adding embedded elasticsearch and mocked configuration for tests

This pull request will add a code that will avoid the need of an 
elasticsearch installation and pio-env configuration when running unit tests of 
the project core.

Basically the changes are:
 - Adding scalamock as a dependency for project core
 - Modifying data Storage.scala file to allow mocked configuration
 - Creating a new helper object to start and shutdown embedded elasticsearch
 - Modifying existing tests to use new infrastructure.

More details of the issue in ASF Jira: 
https://issues.apache.org/jira/browse/PIO-56

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lucasbm88/incubator-predictionio develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-predictionio/pull/355.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #355


commit 077b18a5bd83f81d0e5152e197f1590fa69ba6f6
Author: administrador 
Date:   2017-03-02T02:48:28Z

Adjusting the project core tests and Storage object in order to use an 
embedded elasticsearch and mocked METADATA configuration on unit tests. Fix for 
#PIO-56




> Unit tests in module core should not require real setup
> ---
>
> Key: PIO-56
> URL: https://issues.apache.org/jira/browse/PIO-56
> Project: PredictionIO
>  Issue Type: Improvement
>Affects Versions: 0.10.0-incubating
> Environment: Tested with Mac OS X, i7, 8GB
>Reporter: Lucas Bonatto Miguel
>  Labels: development_environment
> Fix For: 0.11.0
>
>
> *This issue affects only developers*
> When downloading the code from github and trying to run the tests of the 
> project core via sbt, one will face an error stating that the METADATA 
> configuration is missing, e.g:
> [ERROR] [Storage$] Required repository (METADATA) configuration is missing.
> [ERROR] [Storage$] There were 1 configuration errors. Exiting.
> It looks like the project predictionio core requires a METADATA datasource 
> (elasticsearch) installed and configured in the developer machine.
> There are some benefits if the project require less external 
> installation/configuration:
>  - Developers would have an easy setup of the environment.
>  - Continuous integration would be easier
> How to reproduce:
>  - Download predictionio from github
>  - In root folder run ./make-distribution.sh
>  - In root folder run sbt core/test



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)