Re: Request for QPID-3118 in 0.10

[Gordon Sim]

On 03/04/2011 10:02 PM, jr...@redhat.com wrote:

Hi, Steve.  I approved this, but Andrew had a good question: whither old
api examples?

I'm personally conflicted on whether it's best to include them. I lean,
however, toward removing them. Examples are principally documentation
for new work, and new work should use the new apis.

Sorry if this was already discussed. I didn't find anything apart from
QPID-3067, and that doesn't contain a conclusion.


It doesn't contain a conclusion, but as raised it suggested renaming 
rather than removing and this was backed up by one of the comments.


While my own inclination was to remove them, that seemed the more 
extreme approach and the renaming does very clearly signal the intent.


Arguably, since the old headers are all still included along with the 
new headers, having these examples there and clearly marked as 'old' 
actually makes their status clearer. Really we should be marking the old 
APIs deprecated in doxygen I think.


My view would probably be that we leave this as is for now (i.e. 
renamed) but aim to more clearly deprecate the APIs in the next release 
(while still supporting them) and remove the examples at that time. 
However I'm not opposed to other solutions including their removal for 
this release if others feel strongly enough.



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Request for inclusion in 0.10 - r1078729

[Robbie Gemmell]

Hi Justin,

I would like to apply the below changes onto the 0.10 branch (substituting
10 for 11, obviously), is that ok?

Thanks,
Robbie

-- Forwarded message --
From: rob...@apache.org
Date: 7 March 2011 10:21
Subject: svn commit: r1078729 - in /qpid/trunk/qpid: cpp/src/ extras/qmf/
java/broker-plugins/experimental/shutdown/src/main/java/
java/broker/src/main/java/org/apache/qpid/server/plugins/
java/common/src/main/java/ tests/ tools/
To: comm...@qpid.apache.org


Author: robbie
Date: Mon Mar  7 10:21:47 2011
New Revision: 1078729

URL: http://svn.apache.org/viewvc?rev=1078729view=rev
Log:
NO-JIRA: increment version numbers from 0.9 to 0.11

Modified:
   qpid/trunk/qpid/cpp/src/CMakeWinVersions.cmake
   qpid/trunk/qpid/extras/qmf/setup.py

 
qpid/trunk/qpid/java/broker-plugins/experimental/shutdown/src/main/java/shutdown.bnd

 
qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/plugins/PluginManager.java
   qpid/trunk/qpid/java/common/src/main/java/common.bnd
   qpid/trunk/qpid/tests/setup.py
   qpid/trunk/qpid/tools/setup.py

Modified: qpid/trunk/qpid/cpp/src/CMakeWinVersions.cmake
URL:
http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/CMakeWinVersions.cmake?rev=1078729r1=1078728r2=1078729view=diff
==
--- qpid/trunk/qpid/cpp/src/CMakeWinVersions.cmake (original)
+++ qpid/trunk/qpid/cpp/src/CMakeWinVersions.cmake Mon Mar  7 10:21:47 2011
@@ -34,11 +34,11 @@
 # set (winver_PACKAGE_NAME qpid-cpp)
 # set (winver_DESCRIPTION_SUMMARY  Apache Qpid C++)
 # set (winver_FILE_VERSION_N1  0)
-# set (winver_FILE_VERSION_N2  9)
+# set (winver_FILE_VERSION_N2  11)
 # set (winver_FILE_VERSION_N3  0)
 # set (winver_FILE_VERSION_N4  0)
 # set (winver_PRODUCT_VERSION_N1   0)
-# set (winver_PRODUCT_VERSION_N2   9)
+# set (winver_PRODUCT_VERSION_N2   11)
 # set (winver_PRODUCT_VERSION_N3   0)
 # set (winver_PRODUCT_VERSION_N4   0)
 # set (winver_LEGAL_COPYRIGHT  )
@@ -46,10 +46,10 @@
 #
 # Specification of per-project settings:
 #
-# set (winver_${projectName}_FileVersionBinary0,9,0,0)
-# set (winver_${projectName}_ProductVersionBinary 0,9,0,0)
-# set (winver_${projectName}_FileVersionString0, 9, 0, 0)
-# set (winver_${projectName}_ProductVersionString 0, 9, 0, 0)
+# set (winver_${projectName}_FileVersionBinary0,11,0,0)
+# set (winver_${projectName}_ProductVersionBinary 0,11,0,0)
+# set (winver_${projectName}_FileVersionString0, 11, 0, 0)
+# set (winver_${projectName}_ProductVersionString 0, 11, 0, 0)
 # set (winver_${projectName}_FileDescription  qpid-cpp-qpidcommon
Library)
 # set (winver_${projectName}_LegalCopyright   )
 # set (winver_${projectName}_InternalName qpidcommon)

Modified: qpid/trunk/qpid/extras/qmf/setup.py
URL:
http://svn.apache.org/viewvc/qpid/trunk/qpid/extras/qmf/setup.py?rev=1078729r1=1078728r2=1078729view=diff
==
--- qpid/trunk/qpid/extras/qmf/setup.py (original)
+++ qpid/trunk/qpid/extras/qmf/setup.py Mon Mar  7 10:21:47 2011
@@ -20,7 +20,7 @@
 from distutils.core import setup

 setup(name=qpid-qmf,
-  version=0.9,
+  version=0.11,
  author=Apache Qpid,
  author_email=dev@qpid.apache.org,
  packages=[qmf],

Modified:
qpid/trunk/qpid/java/broker-plugins/experimental/shutdown/src/main/java/shutdown.bnd
URL:
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-plugins/experimental/shutdown/src/main/java/shutdown.bnd?rev=1078729r1=1078728r2=1078729view=diff
==
---
qpid/trunk/qpid/java/broker-plugins/experimental/shutdown/src/main/java/shutdown.bnd
(original)
+++
qpid/trunk/qpid/java/broker-plugins/experimental/shutdown/src/main/java/shutdown.bnd
Mon Mar  7 10:21:47 2011
@@ -17,7 +17,7 @@
 # under the License.
 #

-ver: 0.9.0
+ver: 0.11.0

 Bundle-SymbolicName: qpid-shutdown-plugin
 Bundle-Version: ${ver}

Modified:
qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/plugins/PluginManager.java
URL:
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/plugins/PluginManager.java?rev=1078729r1=1078728r2=1078729view=diff
==
---
qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/plugins/PluginManager.java
(original)
+++
qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/plugins/PluginManager.java
Mon Mar  7 10:21:47 2011
@@ -63,7 +63,7 @@ public class PluginManager implements Cl
private static final Logger _logger =
Logger.getLogger(PluginManager.class);

private static final int FELIX_STOP_TIMEOUT = 3;
-private static final String QPID_VER_SUFFIX = version=0.9,;
+private static final String QPID_VER_SUFFIX = version=0.11,;

private Framework _felix;


Modified: 

[jira] Resolved: (QPID-2944) QMan readme is not included in the release package and contains incorrect URL.

[Robbie Gemmell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-2944.
--

Resolution: Fixed

 QMan readme is not included in the release package and contains incorrect URL.
 --

 Key: QPID-2944
 URL: https://issues.apache.org/jira/browse/QPID-2944
 Project: Qpid
  Issue Type: Bug
  Components: Java Management : QMan
Affects Versions: 0.7
Reporter: Robbie Gemmell
Assignee: Robbie Gemmell
 Fix For: 0.9


 The QMan readme is not included in the release package and contains an 
 incorrect URL for its management interface.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2986) Segregate the XML Parsing into a utility class

[Robbie Gemmell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-2986:
-

Fix Version/s: (was: 0.9)
   Future

 Segregate the XML Parsing into a utility class
 --

 Key: QPID-2986
 URL: https://issues.apache.org/jira/browse/QPID-2986
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Affects Versions: 0.8
Reporter: Sorin Suciu
Assignee: Robbie Gemmell
Priority: Minor
 Fix For: Future

 Attachments: qpid-2986.patch


 There is a slight xml parsing/validating code duplication 
 QpidLog4JConfigurator and LoggingManagementMBean and it would be useful to 
 segregate the XML parsing as a utility class so we could reuse it for XML 
 configuration validation for example. The patch attached is an attempt to do 
 so. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2568) QueueEntries should release their reference to the message when they deleted

[Robbie Gemmell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-2568:
-

Affects Version/s: 0.9
   0.7
   0.8
Fix Version/s: (was: 0.9)
   Future

 QueueEntries should release their reference to the message when they deleted
 

 Key: QPID-2568
 URL: https://issues.apache.org/jira/browse/QPID-2568
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Affects Versions: M2.1, M3, M4, 0.5, 0.6, 0.7, 0.8, 0.9
Reporter: Robbie Gemmell
Assignee: Robbie Gemmell
 Fix For: Future


 The QueueEntrytImpl currently maintains its reference to the message object 
 even after it is deleted. As a result, if the QE is held onto for any reason 
 then the GarbageCollector is unable to reclaim the memory from the now unused 
 message object.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Resolved: (QPID-3047) The QueueDepthWithSelectorTest fails on 0-10 profiles

[Robbie Gemmell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-3047.
--

Resolution: Fixed

Looks good to me.

 The QueueDepthWithSelectorTest fails on 0-10 profiles
 -

 Key: QPID-3047
 URL: https://issues.apache.org/jira/browse/QPID-3047
 Project: Qpid
  Issue Type: Bug
  Components: Java Client
Affects Versions: 0.9
Reporter: Andrew Kennedy
Assignee: Robbie Gemmell
 Fix For: 0.9


 The QueueDepthWithSelector needs refactored to use QpidBrokerTestCase rather 
 than being hardcoded simply the 0-8 iVM broker. Once this is done, the test 
 fails on 0-10 profiles,  as the session is not flushing acks correctly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Resolved: (QPID-3065) Send header and frame data as single buffer

[Robbie Gemmell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-3065.
--

Resolution: Fixed

 Send header and frame data as single buffer
 ---

 Key: QPID-3065
 URL: https://issues.apache.org/jira/browse/QPID-3065
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Affects Versions: 0.9
Reporter: Andrew Kennedy
Assignee: Robbie Gemmell
 Fix For: 0.9


 The Disassembler class for the AMQP 0-10 protocol version sends the 12 byte 
 frame header to the network layer in a separate call from the rest of the 
 frame data. This can cause frame header data to be received out-of-order or 
 corrupted frame bodies, particularly with VM transports. The entire frame, 
 including the header, should be written into a single ByteBuffer which should 
 be sent using a single call to the network layer, eliminating this issue.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2584) Update VirtualHost to load VirtualHostPlugins

[Robbie Gemmell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-2584:
-

Fix Version/s: (was: 0.9)
   Future

 Update VirtualHost to load VirtualHostPlugins 
 --

 Key: QPID-2584
 URL: https://issues.apache.org/jira/browse/QPID-2584
 Project: Qpid
  Issue Type: New Feature
  Components: Java Broker
Reporter: Martin Ritchie
Assignee: Martin Ritchie
 Fix For: Future


 Add setup for the new VirtualHostPlugins that will be run in a thread pool to 
 as a side process on the VirtualHost.
 The existing HouseKeeping thread should be converted to a VHostPlugin and run 
 in the same way, using a ThreadPool we can ensure that VHostPlugins that fail 
 can be restarted at their next interval rather than simply stopping as they 
 would just now.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2638) Add topic configuration processing to allow Slow Consumer Detection to be configurable per topic

[Robbie Gemmell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-2638:
-

Fix Version/s: (was: 0.9)
   Future

 Add topic configuration processing to allow Slow Consumer Detection to be 
 configurable per topic
 

 Key: QPID-2638
 URL: https://issues.apache.org/jira/browse/QPID-2638
 Project: Qpid
  Issue Type: New Feature
  Components: Java Broker
Reporter: Martin Ritchie
Assignee: Martin Ritchie
 Fix For: Future


 Currently there is no way to configure topics this presents a problem for the 
 configuration of the slow consumer detection for topics.
 Following the desing documented here:
 https://cwiki.apache.org/confluence/display/qpid/Topic+Configuration+Design
 The plan is to implement simply add the topic section to the configuration 
 and a TopicConfiguration class that will process start the processing of that 
 configuration. The additional items described in the overal topic 
 configuration design are not in scope for this change.
 The TopicConfiguration will be hierarchical just as as the topic version is 
 so the configuration will load in the following strucutre.
 NamedQueue-NamedTopic-GeneralTopic-GeneralQueue
 This means that you can have a configuration for a given topic but if you 
 specify configuration for a specific durable subscription through the named 
 queue configuration this will take presidence.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

0.10 and 0.11 versions now added to JIRA

[Robbie Gemmell]

As trunk is now open for 0.11 development,I have added versions for the 0.10
release and 0.11 development stream in JIRA so that we can appropriately tag
the Affects and Fix For versions on new work that doesn't get merged back to
the release branch.

[jira] Updated: (QPID-3113) ChannelCloseTest should be excluded from test profiles properly

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-3113:
-

Fix Version/s: (was: Future)
   0.11

 ChannelCloseTest should be excluded from test profiles properly
 ---

 Key: QPID-3113
 URL: https://issues.apache.org/jira/browse/QPID-3113
 Project: Qpid
  Issue Type: Bug
  Components: Java Tests
Affects Versions: 0.9
Reporter: Andrew Kennedy
Assignee: Andrew Kennedy
Priority: Minor
 Fix For: 0.11


 ChannelCloseTest should use the Excludes file mechanism to ensure it is not 
 run for 0-10 profiles, and should also not be restricted to VM broker profiles

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2816) Create TCP based 0-10 MINA transport

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2816:
-

Fix Version/s: (was: 0.9)
   0.11

 Create TCP based 0-10 MINA transport
 

 Key: QPID-2816
 URL: https://issues.apache.org/jira/browse/QPID-2816
 Project: Qpid
  Issue Type: Improvement
Affects Versions: 0.7
Reporter: Andrew Kennedy
Assignee: Andrew Kennedy
 Fix For: 0.11


 Create a 0-10 MINA transport that implements the tcp:// protocol for broker 
 communication

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2812) Update 0-10 connection configuration mechanism and properties

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2812:
-

Fix Version/s: (was: 0.9)
   0.11

 Update 0-10 connection configuration mechanism and properties
 -

 Key: QPID-2812
 URL: https://issues.apache.org/jira/browse/QPID-2812
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker, Java Client
Affects Versions: 0.7
Reporter: Andrew Kennedy
Assignee: Andrew Kennedy
 Fix For: 0.11


 Update the 0-10 connection settings and system properties to rationalise the 
 configuration of the connection mechanism/transport/protocol. This may depend 
 on how different transport mechanisms are loaded, e.g. if we use OSGi plugins 
 or not. It would be nice to make things consistent across all protocols, so 
 that broker addressing does not change. Note that some transports may not 
 support all types of broker addressing,and this has to fail gracefully.
 This will also include removal of some classes and options, such as the 
 _IoTransport_ configuration property. This property is present as an 
 apperntly untested 0-9 protocol *only* option, and uses an entirely new 
 mechanism to connect the transport layer to the MINA mechanism. Since the 
 intent of the preceding JIRA is to harmonise the transport layer binterfaces 
 between protocols, I believe this is an unnescessary complication.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2720) Qpid broker can not run inside an OSGi container

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2720:
-

Fix Version/s: 0.11

 Qpid broker can not run inside an OSGi container
 

 Key: QPID-2720
 URL: https://issues.apache.org/jira/browse/QPID-2720
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Reporter: Danushka Menikkumbura
Assignee: Andrew Kennedy
 Fix For: 0.11

 Attachments: QPID-2720-V2.patch, QPID-2720.patch




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-3070) SessionComplete command sent for empty range

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-3070:
-

Fix Version/s: (was: 0.9)
   0.11

 SessionComplete command sent for empty range
 

 Key: QPID-3070
 URL: https://issues.apache.org/jira/browse/QPID-3070
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker, Java Client
Affects Versions: 0.9
Reporter: Andrew Kennedy
Assignee: Andrew Kennedy
 Fix For: 0.11


 The 0-10 AMQP protocol implementation sends a SessionComplete command with an 
 empty RangeSet, which will be replied to with a SessionKnownComplete and a 
 similar empty or null RangeSet (these are equivalent on the wire) iff the 
 TimelyReply field is set to true in the request.
 I think that the initial empty SessionComplete (caused by a call to 
 flushProcessed normally) should never be sent, so adding a check for 
 range.size()  0 before sending should do this.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-3111) DynamicQueueExchangeCreateTest should check for 404 error code explicitly

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-3111:
-

Fix Version/s: (was: Future)
   0.11

 DynamicQueueExchangeCreateTest should check for 404 error code explicitly
 -

 Key: QPID-3111
 URL: https://issues.apache.org/jira/browse/QPID-3111
 Project: Qpid
  Issue Type: Bug
  Components: Java Tests
Affects Versions: 0.9
Reporter: Andrew Kennedy
Assignee: Andrew Kennedy
Priority: Minor
 Fix For: 0.11


 DynamicQueueExchangeCreateTest checks for a tect string in the message 
 property of a thrown exception. This is brittle and should be replaced with a 
 check for the AMQConstant#NOT_FOUND (404) error code instead.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-3114) Exclusive queues do not record their owning session in 0-10

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-3114:
-

Fix Version/s: (was: Future)
   0.11

 Exclusive queues do not record their owning session in 0-10
 ---

 Key: QPID-3114
 URL: https://issues.apache.org/jira/browse/QPID-3114
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Affects Versions: 0.9
Reporter: Andrew Kennedy
Assignee: Andrew Kennedy
 Fix For: 0.11


 When using 0-10 sessions to create exclusive queues they should have the 
 owning server session recorded on the broker.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2945) QMan 0.8RC1 is unable to connect to the 0.6 or 0.8RC1 C++ broker, and QMan 0.6 is unable to list resources for the 0.8RC1 C++ broker.

[Robbie Gemmell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-2945:
-

Affects Version/s: 0.10
   0.9
Fix Version/s: (was: 0.9)
   Future

 QMan 0.8RC1 is unable to connect to the 0.6 or 0.8RC1 C++ broker, and QMan 
 0.6 is unable to list resources for the 0.8RC1 C++ broker.
 -

 Key: QPID-2945
 URL: https://issues.apache.org/jira/browse/QPID-2945
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker, Java Management : QMan
Affects Versions: 0.7, 0.8, 0.9, 0.10
Reporter: Robbie Gemmell
Priority: Critical
 Fix For: Future


 QMan 0.7/0.8(RC1) is apparently unable to connect to the (C++) broker.  QMan 
 either throws an exception when trying to connect (using the MBean for the 
 JMX version) or appears to do nothing and fail to connect when using the WSDM 
 interface attempting to connect to the 0.8 RC1 C++ broker, continually saying 
 there are no brokers connected to manage.
 When attempting to connect the 0.6 QMan to the 0.8 RC1 C++ broker, the 
 connection is made and listed in the WDSM console, but no resources for the 
 broker are displayed for management. When connecting the 0.6 QMan to the 
 0.6C++ broker everything appears to be fine and resources show up for 
 management and can be viewed.
 From this it would seem that changes to the C++ broker since 0.6 have made 
 QMan 0.6 unable to manage the 0.8 broker resources, and also that changes 
 since 0.6 in the Java tree have resulted in breakage for QMan 0.8.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-3066) UTF8Test does not run under non VM 0-10 profiles

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-3066:
-

Fix Version/s: (was: 0.9)
   0.11

 UTF8Test does not run under non VM 0-10 profiles
 

 Key: QPID-3066
 URL: https://issues.apache.org/jira/browse/QPID-3066
 Project: Qpid
  Issue Type: Bug
  Components: Java Tests
Affects Versions: 0.9
Reporter: Andrew Kennedy
Assignee: Andrew Kennedy
Priority: Minor
 Fix For: 0.11


 The UTF8Test uses the 'isBrokerExternal' and 'isBroker010' methods to check 
 whether it should run, rather than relying on the Excludes files. The checks 
 wrongly cause an exception to be thrown on the java.0.10 test profile.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-3052) Java test profiles do not effectively test all AMQP protocol versions

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-3052:
-

Fix Version/s: (was: 0.9)
   0.11

 Java test profiles do not effectively test all AMQP protocol versions
 -

 Key: QPID-3052
 URL: https://issues.apache.org/jira/browse/QPID-3052
 Project: Qpid
  Issue Type: Bug
  Components: Java Tests
Affects Versions: 0.9
Reporter: Andrew Kennedy
Assignee: Andrew Kennedy
Priority: Minor
 Fix For: 0.11


 The Java test profiles assume that, particularly default one for InVm 
 transports, the 0-10 protocol will fail, causing renegotiation. If 0-10 InVm 
 support is added then the default protocol will use this. It seems to make 
 more sense to specify exactly the version the client and the broker should 
 announce, and force renegotiation explicitly by disabling various protocol 
 versions on the command line when starting an external Java broker. Note that 
 this is not possible to specify for the InVm profiles anyway. Also, the only 
 protocol that is ever tested will be the highest supported by both broker and 
 client, therefore this is AMQP 0-9-1. In order for the tests not to do 
 surprising things when new protocol versions are added, I think that setting 
 versions explicitly is the best idea. I woulsd also like to add an explicit 
 0-8 test profile for both InVM and external Java brokers, in order to 
 exercise and get coverage on this code.
 In future, I recommend that some form of combinatorial profile system be 
 investigated for the test subsystem, allowing the required protocol, broker 
 type and so on to be specified separately.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2813) Update current 0-10 socket connection to conform to new mechanism

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2813:
-

Fix Version/s: (was: 0.9)
   0.11

 Update current 0-10 socket connection to conform to new mechanism
 -

 Key: QPID-2813
 URL: https://issues.apache.org/jira/browse/QPID-2813
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker, Java Client
Affects Versions: 0.7
Reporter: Andrew Kennedy
Assignee: Andrew Kennedy
 Fix For: 0.11


 Make any additonal changes to the existing transport to allow it to conform 
 fully to the changes made in QPID-2811 and QPID-2812

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2814) Create MINA InVM 0-10 Transport

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2814:
-

Fix Version/s: (was: 0.9)
   0.11

 Create MINA InVM 0-10 Transport
 ---

 Key: QPID-2814
 URL: https://issues.apache.org/jira/browse/QPID-2814
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker, Java Client
Affects Versions: 0.7
Reporter: Andrew Kennedy
Assignee: Andrew Kennedy
 Fix For: 0.11


 Create a MINA transport that implements the vm:// VmPipe protocol, to allow 
 for inVM communication with the 0-10 protocol

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2811) Rationalise 0-10 Transport Interface

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2811:
-

Fix Version/s: (was: 0.9)
   0.11

 Rationalise 0-10 Transport Interface
 

 Key: QPID-2811
 URL: https://issues.apache.org/jira/browse/QPID-2811
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker, Java Client, Java Common
Affects Versions: 0.7
Reporter: Andrew Kennedy
Assignee: Andrew Kennedy
 Fix For: 0.11

 Attachments: transport-layer.ppt


 Create or modify current transport mechanism classes and interfaces to make 
 them more generic and allow for other mechanisms and protocols to be added in 
 a modular way.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2815) Make InVM broker startup protocol independent

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2815:
-

Fix Version/s: (was: 0.9)
   0.11

 Make InVM broker startup protocol independent
 -

 Key: QPID-2815
 URL: https://issues.apache.org/jira/browse/QPID-2815
 Project: Qpid
  Issue Type: Improvement
Affects Versions: 0.7
Reporter: Andrew Kennedy
Assignee: Andrew Kennedy
 Fix For: 0.11


 Update the way the InVm broker is started to decouple it from any particular 
 protocol version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-3026) The ApplicationRegistry object should be a singleton

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-3026:
-

Fix Version/s: 0.11

 The ApplicationRegistry object should be a singleton
 

 Key: QPID-3026
 URL: https://issues.apache.org/jira/browse/QPID-3026
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Affects Versions: 0.9
Reporter: Andrew Kennedy
Assignee: Andrew Kennedy
Priority: Minor
 Fix For: 0.11


 The ApplicationRegistry can currently have multiple instances, in order to 
 cater for multiple brokers in the same VM. However, *many* parts of the code 
 simply call ApplcationRegistry.getInstance() to obtain a reference, meaning 
 multiple instances are ignored. The only time this is ever useful is for 
 certain types of tests, therefore the capability to have multiple broker 
 instances should be removed.
 Any tests that require multiple brokers can start a VM broker and an 
 external, or two external brokers. In general, test-only code should not be 
 made available to the rest of the application.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

QPID-3115: candidate for 0.10?

[Gordon Sim]

I have completed fixes to the c++ client for QPID-3115 (making it more 
consistent with the python connection options).


I believe this is a low risk set of changes and would be useful to users 
of Qpid 0.10 and would therefore suggest they could be merged on to the 
0.10 release branch. However they are not critical in anyway, so this is 
not essential.


Any thoughts or opinions?

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Created: (QPID-3120) Queue reroute doesn't honor alternate exchange

[Gordon Sim (JIRA)]

Queue reroute doesn't honor alternate exchange
--

 Key: QPID-3120
 URL: https://issues.apache.org/jira/browse/QPID-3120
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker
Affects Versions: 0.8
Reporter: Gordon Sim
Assignee: Gordon Sim
 Fix For: 0.9


When invoking the reroute method on a queue, messages delivered to an exchange 
are dropped instead of being delivered to the exchange's alternate exchange if 
no bindings match.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

RE: QPID-3115: candidate for 0.10?

[Steve Huston]

Hi Gordon,

 I have completed fixes to the c++ client for QPID-3115 
 (making it more 
 consistent with the python connection options).
 
 I believe this is a low risk set of changes and would be 
 useful to users 
 of Qpid 0.10 and would therefore suggest they could be merged 
 on to the 
 0.10 release branch. However they are not critical in anyway, 
 so this is 
 not essential.
 
 Any thoughts or opinions?

Consistency is good. Is there any place the change is documented for the
unsuspecting user? Will this break 0.8 applications?

-Steve


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

RE: Request for QPID-3118 in 0.10

[Steve Huston]

Some more background on my rationale for this.

First, it's all related only to the Windows installer. Whatever is
released in the source packages is not affected.

The Windows installer installs the requisite Boost headers needed to
build the examples. I don't like doing this. If the old-api examples
aren't in the install, the Boost headers don't need to be either. And,
since any time someone on the user list asks a question re the API the
answer often involves a recommendation to use the new API, removing the
old-api examples from the installer seems a good idea. People looking
for examples should be looking at the new API.

-Steve

 -Original Message-
 From: Gordon Sim [mailto:g...@redhat.com] 
 Sent: Monday, March 07, 2011 4:51 AM
 To: dev@qpid.apache.org
 Subject: Re: Request for QPID-3118 in 0.10
 
 
 On 03/04/2011 10:02 PM, jr...@redhat.com wrote:
  Hi, Steve.  I approved this, but Andrew had a good 
 question: whither 
  old api examples?
 
  I'm personally conflicted on whether it's best to include them. I 
  lean, however, toward removing them. Examples are principally 
  documentation for new work, and new work should use the new apis.
 
  Sorry if this was already discussed. I didn't find anything 
 apart from 
  QPID-3067, and that doesn't contain a conclusion.
 
 It doesn't contain a conclusion, but as raised it suggested renaming 
 rather than removing and this was backed up by one of the comments.
 
 While my own inclination was to remove them, that seemed the more 
 extreme approach and the renaming does very clearly signal the intent.
 
 Arguably, since the old headers are all still included along with the 
 new headers, having these examples there and clearly marked as 'old' 
 actually makes their status clearer. Really we should be 
 marking the old 
 APIs deprecated in doxygen I think.
 
 My view would probably be that we leave this as is for now (i.e. 
 renamed) but aim to more clearly deprecate the APIs in the 
 next release 
 (while still supporting them) and remove the examples at that time. 
 However I'm not opposed to other solutions including their 
 removal for 
 this release if others feel strongly enough.
 
 
 -
 Apache Qpid - AMQP Messaging Implementation
 Project:  http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org
 
 


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: QPID-3115: candidate for 0.10?

[Gordon Sim]

On 03/07/2011 12:32 PM, Steve Huston wrote:

Hi Gordon,


I have completed fixes to the c++ client for QPID-3115
(making it more
consistent with the python connection options).

I believe this is a low risk set of changes and would be
useful to users
of Qpid 0.10 and would therefore suggest they could be merged
on to the
0.10 release branch. However they are not critical in anyway,
so this is
not essential.

Any thoughts or opinions?


Consistency is good. Is there any place the change is documented for the
unsuspecting user?


I've update the programming guide in line with these changes. However it 
doesn't describe the change itself, just the final state. I think the 
JIRA (and thus release notes) would be the best place to describe the 
change. The commit logs attached to the JIRA do that to some extent, but 
I can add an explicit comment also.



Will this break 0.8 applications?


The old names are still supported. However where previously unrecognised 
options were silently ignored, now they will cause an exception.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Request for QPID-3120[1] in 0.10

[Gordon Sim]

The fix[2] is very trivial and low risk and it does make things easier 
for users who might rely on the alternate-exchange pattern in their 
systems. Any concerns or objections to merging this to the 0.10 branch?


[1] https://issues.apache.org/jira/browse/QPID-3120

[2] 
http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/Queue.cpp/?rev=1078763view=diffr1=1078763r2=1078762p1=/qpid/trunk/qpid/cpp/src/qpid/broker/Queue.cppp2=/qpid/trunk/qpid/cpp/src/qpid/broker/Queue.cpp


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: Request for QPID-3118 in 0.10

[Justin Ross]

On Mon, 7 Mar 2011, Gordon Sim wrote:


On 03/07/2011 12:37 PM, Steve Huston wrote:

Some more background on my rationale for this.

First, it's all related only to the Windows installer. Whatever is
released in the source packages is not affected.

The Windows installer installs the requisite Boost headers needed to
build the examples. I don't like doing this. If the old-api examples
aren't in the install, the Boost headers don't need to be either. And,
since any time someone on the user list asks a question re the API the
answer often involves a recommendation to use the new API, removing the
old-api examples from the installer seems a good idea. People looking
for examples should be looking at the new API.


I for one would be perfectly happy with that.


Me too.

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: Request for inclusion in 0.10 - r1078729

[Justin Ross]

Definitely okay.  Thanks, Robbie.

On Mon, 7 Mar 2011, Robbie Gemmell wrote:


Hi Justin,

I would like to apply the below changes onto the 0.10 branch (substituting
10 for 11, obviously), is that ok?

Thanks,
Robbie

-- Forwarded message --
From: rob...@apache.org
Date: 7 March 2011 10:21
Subject: svn commit: r1078729 - in /qpid/trunk/qpid: cpp/src/ extras/qmf/
java/broker-plugins/experimental/shutdown/src/main/java/
java/broker/src/main/java/org/apache/qpid/server/plugins/
java/common/src/main/java/ tests/ tools/
To: comm...@qpid.apache.org


Author: robbie
Date: Mon Mar  7 10:21:47 2011
New Revision: 1078729

URL: http://svn.apache.org/viewvc?rev=1078729view=rev
Log:
NO-JIRA: increment version numbers from 0.9 to 0.11

Modified:
  qpid/trunk/qpid/cpp/src/CMakeWinVersions.cmake
  qpid/trunk/qpid/extras/qmf/setup.py

qpid/trunk/qpid/java/broker-plugins/experimental/shutdown/src/main/java/shutdown.bnd

qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/plugins/PluginManager.java
  qpid/trunk/qpid/java/common/src/main/java/common.bnd
  qpid/trunk/qpid/tests/setup.py
  qpid/trunk/qpid/tools/setup.py

Modified: qpid/trunk/qpid/cpp/src/CMakeWinVersions.cmake
URL:
http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/CMakeWinVersions.cmake?rev=1078729r1=1078728r2=1078729view=diff
==
--- qpid/trunk/qpid/cpp/src/CMakeWinVersions.cmake (original)
+++ qpid/trunk/qpid/cpp/src/CMakeWinVersions.cmake Mon Mar  7 10:21:47 2011
@@ -34,11 +34,11 @@
# set (winver_PACKAGE_NAME qpid-cpp)
# set (winver_DESCRIPTION_SUMMARY  Apache Qpid C++)
# set (winver_FILE_VERSION_N1  0)
-# set (winver_FILE_VERSION_N2  9)
+# set (winver_FILE_VERSION_N2  11)
# set (winver_FILE_VERSION_N3  0)
# set (winver_FILE_VERSION_N4  0)
# set (winver_PRODUCT_VERSION_N1   0)
-# set (winver_PRODUCT_VERSION_N2   9)
+# set (winver_PRODUCT_VERSION_N2   11)
# set (winver_PRODUCT_VERSION_N3   0)
# set (winver_PRODUCT_VERSION_N4   0)
# set (winver_LEGAL_COPYRIGHT  )
@@ -46,10 +46,10 @@
#
# Specification of per-project settings:
#
-# set (winver_${projectName}_FileVersionBinary0,9,0,0)
-# set (winver_${projectName}_ProductVersionBinary 0,9,0,0)
-# set (winver_${projectName}_FileVersionString0, 9, 0, 0)
-# set (winver_${projectName}_ProductVersionString 0, 9, 0, 0)
+# set (winver_${projectName}_FileVersionBinary0,11,0,0)
+# set (winver_${projectName}_ProductVersionBinary 0,11,0,0)
+# set (winver_${projectName}_FileVersionString0, 11, 0, 0)
+# set (winver_${projectName}_ProductVersionString 0, 11, 0, 0)
# set (winver_${projectName}_FileDescription  qpid-cpp-qpidcommon
Library)
# set (winver_${projectName}_LegalCopyright   )
# set (winver_${projectName}_InternalName qpidcommon)

Modified: qpid/trunk/qpid/extras/qmf/setup.py
URL:
http://svn.apache.org/viewvc/qpid/trunk/qpid/extras/qmf/setup.py?rev=1078729r1=1078728r2=1078729view=diff
==
--- qpid/trunk/qpid/extras/qmf/setup.py (original)
+++ qpid/trunk/qpid/extras/qmf/setup.py Mon Mar  7 10:21:47 2011
@@ -20,7 +20,7 @@
from distutils.core import setup

setup(name=qpid-qmf,
-  version=0.9,
+  version=0.11,
 author=Apache Qpid,
 author_email=dev@qpid.apache.org,
 packages=[qmf],

Modified:
qpid/trunk/qpid/java/broker-plugins/experimental/shutdown/src/main/java/shutdown.bnd
URL:
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-plugins/experimental/shutdown/src/main/java/shutdown.bnd?rev=1078729r1=1078728r2=1078729view=diff
==
---
qpid/trunk/qpid/java/broker-plugins/experimental/shutdown/src/main/java/shutdown.bnd
(original)
+++
qpid/trunk/qpid/java/broker-plugins/experimental/shutdown/src/main/java/shutdown.bnd
Mon Mar  7 10:21:47 2011
@@ -17,7 +17,7 @@
# under the License.
#

-ver: 0.9.0
+ver: 0.11.0

Bundle-SymbolicName: qpid-shutdown-plugin
Bundle-Version: ${ver}

Modified:
qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/plugins/PluginManager.java
URL:
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/plugins/PluginManager.java?rev=1078729r1=1078728r2=1078729view=diff
==
---
qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/plugins/PluginManager.java
(original)
+++
qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/plugins/PluginManager.java
Mon Mar  7 10:21:47 2011
@@ -63,7 +63,7 @@ public class PluginManager implements Cl
   private static final Logger _logger =
Logger.getLogger(PluginManager.class);

   private static final int FELIX_STOP_TIMEOUT = 3;
-private static final String QPID_VER_SUFFIX = version=0.9,;
+private static final String QPID_VER_SUFFIX = version=0.11,;

   private Framework 

[jira] Commented: (QPID-3115) Differences in connection options between c++ and python clients

[Gordon Sim (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003381#comment-13003381
 ] 

Gordon Sim commented on QPID-3115:
--

The c++ client now recognises options via the same names as used in python 
(generally this means it recognises '_' in place of '-'. The old names are also 
still recognised. Additionally however the client will now thro exceptions when 
encountering unrecognised options, rather than just ignoring them.

 Differences in connection options between c++ and python clients
 

 Key: QPID-3115
 URL: https://issues.apache.org/jira/browse/QPID-3115
 Project: Qpid
  Issue Type: Improvement
  Components: C++ Client
Affects Versions: 0.8
Reporter: Gordon Sim
Assignee: Gordon Sim

  For example, to set the reconnect limit, the syntax is the following:
 in C++:reconnect-limit
 in Python: reconnect_limit
 The documentation uses the Python syntax but does not call out the C++
 differences.
 To compound the problem, unrecognized options in C++ are silently ignored.  If
 a user chooses the wrong syntax (as he would do if he read the documentation),
 the option does not take effect and the default is used instead, leading to
 unpredictable and undesired results.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3120) Queue reroute doesn't honor alternate exchange

[Alan Conway (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003395#comment-13003395
 ] 

Alan Conway commented on QPID-3120:
---

Reviewed changes on trunk, approved for 0.10.

 Queue reroute doesn't honor alternate exchange
 --

 Key: QPID-3120
 URL: https://issues.apache.org/jira/browse/QPID-3120
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker
Affects Versions: 0.8
Reporter: Gordon Sim
Assignee: Gordon Sim
 Fix For: 0.9


 When invoking the reroute method on a queue, messages delivered to an 
 exchange are dropped instead of being delivered to the exchange's alternate 
 exchange if no bindings match.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3120) Queue reroute doesn't honor alternate exchange

[Justin Ross (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003397#comment-13003397
 ] 

Justin Ross commented on QPID-3120:
---

Approved for 0.10.

 Queue reroute doesn't honor alternate exchange
 --

 Key: QPID-3120
 URL: https://issues.apache.org/jira/browse/QPID-3120
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker
Affects Versions: 0.8
Reporter: Gordon Sim
Assignee: Gordon Sim
 Fix For: 0.9


 When invoking the reroute method on a queue, messages delivered to an 
 exchange are dropped instead of being delivered to the exchange's alternate 
 exchange if no bindings match.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Created: (QPID-3121) Cluster management inconsistency when using persistent store.

[Alan Conway (JIRA)]

Cluster management inconsistency when using persistent store.
-

 Key: QPID-3121
 URL: https://issues.apache.org/jira/browse/QPID-3121
 Project: Qpid
  Issue Type: Bug
  Components: C++ Clustering
Affects Versions: 0.9
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.9


If cluster_tests.py, test_management is modified to enable durable messages. 
The log comparison at end of test sometimes shows messages like this on one 
broker but not the others:

trace Changed V1 statistics 
org.apache.qpid.broker:connection:127.0.0.1:52742-127.0.0.1:44104 len=NN
trace Changed V2 statistics 
org.apache.qpid.broker:connection:127.0.0.1:52742-127.0.0.1:44104

To date this hasn't been seen to actually cause a cluster crash but in 
principle it is possible it could.

To reproduce, build the message store at: 
http://anonsvn.jboss.org/repos/rhmessaging/store/
In the tests/cluster directory, run this in a loop:

make check TESTS=run_python_cluster_tests CLUSTER_TESTS='*.test_management* 
-DDURATION=2'

It will fail, usually on the first iteration, showing the log files that don't 
match. Use diff or other such tool to confirm that the mismatched lines are as 
above. The file may also contain some other mismatches showing a different 
number of stats in a periodic update - that is a consequence of the above.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-3121) Cluster management inconsistency when using persistent store.

[Alan Conway (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway updated QPID-3121:
--

Description: 
If cluster_tests.py, test_management is modified to enable durable messages, it 
fails the log comparison test shows messages like this on one broker but not 
the others:

trace Changed V1 statistics 
org.apache.qpid.broker:connection:127.0.0.1:52742-127.0.0.1:44104 len=NN
trace Changed V2 statistics 
org.apache.qpid.broker:connection:127.0.0.1:52742-127.0.0.1:44104

To date this hasn't been seen to actually cause a cluster crash but in 
principle it is possible it could.

To reproduce, build the message store at: 
http://anonsvn.jboss.org/repos/rhmessaging/store/
In the tests/cluster directory, run this in a loop:

make check TESTS=run_python_cluster_tests CLUSTER_TESTS='*.test_management* 
-DDURATION=2'

It will fail, usually on the first iteration, showing the log files that don't 
match. Use diff or other such tool to confirm that the mismatched lines are as 
above. The file may also contain some other mismatches showing a different 
number of stats in a periodic update - that is a consequence of the above.

  was:
If cluster_tests.py, test_management is modified to enable durable messages. 
The log comparison at end of test sometimes shows messages like this on one 
broker but not the others:

trace Changed V1 statistics 
org.apache.qpid.broker:connection:127.0.0.1:52742-127.0.0.1:44104 len=NN
trace Changed V2 statistics 
org.apache.qpid.broker:connection:127.0.0.1:52742-127.0.0.1:44104

To date this hasn't been seen to actually cause a cluster crash but in 
principle it is possible it could.

To reproduce, build the message store at: 
http://anonsvn.jboss.org/repos/rhmessaging/store/
In the tests/cluster directory, run this in a loop:

make check TESTS=run_python_cluster_tests CLUSTER_TESTS='*.test_management* 
-DDURATION=2'

It will fail, usually on the first iteration, showing the log files that don't 
match. Use diff or other such tool to confirm that the mismatched lines are as 
above. The file may also contain some other mismatches showing a different 
number of stats in a periodic update - that is a consequence of the above.


 Cluster management inconsistency when using persistent store.
 -

 Key: QPID-3121
 URL: https://issues.apache.org/jira/browse/QPID-3121
 Project: Qpid
  Issue Type: Bug
  Components: C++ Clustering
Affects Versions: 0.9
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.9


 If cluster_tests.py, test_management is modified to enable durable messages, 
 it fails the log comparison test shows messages like this on one broker but 
 not the others:
 trace Changed V1 statistics 
 org.apache.qpid.broker:connection:127.0.0.1:52742-127.0.0.1:44104 len=NN
 trace Changed V2 statistics 
 org.apache.qpid.broker:connection:127.0.0.1:52742-127.0.0.1:44104
 To date this hasn't been seen to actually cause a cluster crash but in 
 principle it is possible it could.
 To reproduce, build the message store at: 
 http://anonsvn.jboss.org/repos/rhmessaging/store/
 In the tests/cluster directory, run this in a loop:
 make check TESTS=run_python_cluster_tests CLUSTER_TESTS='*.test_management* 
 -DDURATION=2'
 It will fail, usually on the first iteration, showing the log files that 
 don't match. Use diff or other such tool to confirm that the mismatched lines 
 are as above. The file may also contain some other mismatches showing a 
 different number of stats in a periodic update - that is a consequence of the 
 above.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3109) Java client needs to implement the Delete option in address string

[Andrew Kennedy (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003413#comment-13003413
 ] 

Andrew Kennedy commented on QPID-3109:
--

Rajith,

In BasicMessageProducer_0_10#close() you make the assumption that _destination 
will hold a valid (non-null) destination. This is not always the case, as can 
be seen from the following code sample (taken from InvaliDestinationTest, which 
is currently failing in the java.0.10 profile):

{code}
sender = queueSession.createSender(null);
// ... try to send to invalid destination first
sender.send(validDestination, msg);
sender.close();
{code}

Obviously, the close call will now fail with a NullPointerException. I have not 
seen any other tests failing because of this, but this is most likely due to 
lack of coverage, since other methods in this commit assume a non-null 
_destination field also.

I believe the code sample above to be a valid JMS idiom.

Andrew.

 Java client needs to implement the Delete option in address string
 --

 Key: QPID-3109
 URL: https://issues.apache.org/jira/browse/QPID-3109
 Project: Qpid
  Issue Type: Improvement
  Components: Java Client
Affects Versions: 0.8
Reporter: Rajith Attapattu
Assignee: Rajith Attapattu
Priority: Minor
 Fix For: 0.9


 The address syntax defines a delete option with 4 possible values - {always, 
 receiver, sender, never}.
 The default value is 'never'.
 if delete = 'always' or delete = 'sender', then when a sender is closed it 
 should delete the queue.
 if delete = 'always' or delete = 'receiver', then when a receiver is closed 
 it should delete the queue.
 Please note that the client will delete the queue irrespective of whether 
 there are consumers on the queue or not.
 Also it will not take into account whether the queue is empty or not.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Resolved: (QPID-3115) Differences in connection options between c++ and python clients

[Gordon Sim (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved QPID-3115.
--

Resolution: Fixed

 Differences in connection options between c++ and python clients
 

 Key: QPID-3115
 URL: https://issues.apache.org/jira/browse/QPID-3115
 Project: Qpid
  Issue Type: Improvement
  Components: C++ Client
Affects Versions: 0.8
Reporter: Gordon Sim
Assignee: Gordon Sim
 Fix For: 0.9, 0.10


  For example, to set the reconnect limit, the syntax is the following:
 in C++:reconnect-limit
 in Python: reconnect_limit
 The documentation uses the Python syntax but does not call out the C++
 differences.
 To compound the problem, unrecognized options in C++ are silently ignored.  If
 a user chooses the wrong syntax (as he would do if he read the documentation),
 the option does not take effect and the default is used instead, leading to
 unpredictable and undesired results.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-3115) Differences in connection options between c++ and python clients

[Gordon Sim (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim updated QPID-3115:
-

Fix Version/s: 0.10
   0.9

 Differences in connection options between c++ and python clients
 

 Key: QPID-3115
 URL: https://issues.apache.org/jira/browse/QPID-3115
 Project: Qpid
  Issue Type: Improvement
  Components: C++ Client
Affects Versions: 0.8
Reporter: Gordon Sim
Assignee: Gordon Sim
 Fix For: 0.9, 0.10


  For example, to set the reconnect limit, the syntax is the following:
 in C++:reconnect-limit
 in Python: reconnect_limit
 The documentation uses the Python syntax but does not call out the C++
 differences.
 To compound the problem, unrecognized options in C++ are silently ignored.  If
 a user chooses the wrong syntax (as he would do if he read the documentation),
 the option does not take effect and the default is used instead, leading to
 unpredictable and undesired results.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: SessionComplete behaviour in AMQP 0-10

[Andrew Kennedy]

On 18 February 2011 12:13, Andrew Kennedy andrewinternatio...@gmail.com wrote:
 Hi.

 Can someone with more knowledge of AMQP 0-10 please take a look at
 QPID-3070 for me?

https://issues.apache.org/jira/browse/QPID-3070

 Basically, I think that 'flushProcessed' does NOT need to send a
 SessionComplete (and receive an empty SessionKnownComplete) if the
 RangeSet is empty. Is this a valid thing to do according to the AMQP
 spec? Also, what about if the broker receives a SessionComplete with a
 null or empty RangeSet - could it simply NOT send back a
 SessionKnownComplete, since it would necessarily just contain an empty
 or null RangeSet also? I couln't find much about this in the
 specification...

To clarify, the change made for QPID-3070 involves NOT sending a
'SessionCompleted' command IF the range is empty, in the
Session#flushProcessed(...) method.

I have discussed this with Rob, and Gordon and Rajith also confirmed
in the JIRA comments, that this seems like a sensible optimisation for
the 0-10 protocol. I will therefore be committing this change to the
0.11 trunk.

Andrew.
--
-- andrew d kennedy ? edinburgh : +44 7582 293 255

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3109) Java client needs to implement the Delete option in address string

[Andrew Kennedy (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003415#comment-13003415
 ] 

Andrew Kennedy commented on QPID-3109:
--

Tests in SimpleACLTest and subclasses are also failing, again in the java.0.10 
profile, due to the use of the following JMS idiom, which resultrs in 
_destination not being set in a producer:

MessageProducer sender = ((AMQSession?, ?) 
sess).createProducer(null);

 Java client needs to implement the Delete option in address string
 --

 Key: QPID-3109
 URL: https://issues.apache.org/jira/browse/QPID-3109
 Project: Qpid
  Issue Type: Improvement
  Components: Java Client
Affects Versions: 0.8
Reporter: Rajith Attapattu
Assignee: Rajith Attapattu
Priority: Minor
 Fix For: 0.9


 The address syntax defines a delete option with 4 possible values - {always, 
 receiver, sender, never}.
 The default value is 'never'.
 if delete = 'always' or delete = 'sender', then when a sender is closed it 
 should delete the queue.
 if delete = 'always' or delete = 'receiver', then when a receiver is closed 
 it should delete the queue.
 Please note that the client will delete the queue irrespective of whether 
 there are consumers on the queue or not.
 Also it will not take into account whether the queue is empty or not.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Issue Comment Edited: (QPID-3109) Java client needs to implement the Delete option in address string

[Andrew Kennedy (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003413#comment-13003413
 ] 

Andrew Kennedy edited comment on QPID-3109 at 3/7/11 4:18 PM:
--

Rajith,

In BasicMessageProducer_0_10#close() you make the assumption that _destination 
will hold a valid (non-null) destination. This is not always the case, as can 
be seen from the following code sample (taken from InvalidDestinationTest, 
which is currently failing in the java.0.10 profile):

sender = queueSession.createSender(null);
// ... try to send to invalid destination first
sender.send(validDestination, msg);
sender.close();

Obviously, the close call will now fail with a NullPointerException. I have not 
seen any other tests failing because of this, but this is most likely due to 
lack of coverage, since other methods in this commit assume a non-null 
_destination field also.

I believe the code sample above to be a valid JMS idiom.

Andrew.

  was (Author: andrew.kennedy):
Rajith,

In BasicMessageProducer_0_10#close() you make the assumption that _destination 
will hold a valid (non-null) destination. This is not always the case, as can 
be seen from the following code sample (taken from InvaliDestinationTest, which 
is currently failing in the java.0.10 profile):

{code}
sender = queueSession.createSender(null);
// ... try to send to invalid destination first
sender.send(validDestination, msg);
sender.close();
{code}

Obviously, the close call will now fail with a NullPointerException. I have not 
seen any other tests failing because of this, but this is most likely due to 
lack of coverage, since other methods in this commit assume a non-null 
_destination field also.

I believe the code sample above to be a valid JMS idiom.

Andrew.
  
 Java client needs to implement the Delete option in address string
 --

 Key: QPID-3109
 URL: https://issues.apache.org/jira/browse/QPID-3109
 Project: Qpid
  Issue Type: Improvement
  Components: Java Client
Affects Versions: 0.8
Reporter: Rajith Attapattu
Assignee: Rajith Attapattu
Priority: Minor
 Fix For: 0.9


 The address syntax defines a delete option with 4 possible values - {always, 
 receiver, sender, never}.
 The default value is 'never'.
 if delete = 'always' or delete = 'sender', then when a sender is closed it 
 should delete the queue.
 if delete = 'always' or delete = 'receiver', then when a receiver is closed 
 it should delete the queue.
 Please note that the client will delete the queue irrespective of whether 
 there are consumers on the queue or not.
 Also it will not take into account whether the queue is empty or not.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-3121) Cluster management inconsistency when using persistent store.

[Alan Conway (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway updated QPID-3121:
--

Attachment: durable-test-mgmt.patch

Modified version of cluster_tests.py to enable durable messages for 
test_management.

 Cluster management inconsistency when using persistent store.
 -

 Key: QPID-3121
 URL: https://issues.apache.org/jira/browse/QPID-3121
 Project: Qpid
  Issue Type: Bug
  Components: C++ Clustering
Affects Versions: 0.9
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.9

 Attachments: durable-test-mgmt.patch


 If cluster_tests.py, test_management is modified to enable durable messages, 
 it fails the log comparison test shows messages like this on one broker but 
 not the others:
 trace Changed V1 statistics 
 org.apache.qpid.broker:connection:127.0.0.1:52742-127.0.0.1:44104 len=NN
 trace Changed V2 statistics 
 org.apache.qpid.broker:connection:127.0.0.1:52742-127.0.0.1:44104
 To date this hasn't been seen to actually cause a cluster crash but in 
 principle it is possible it could.
 To reproduce, build the message store at: 
 http://anonsvn.jboss.org/repos/rhmessaging/store/
 In the tests/cluster directory, run this in a loop:
 make check TESTS=run_python_cluster_tests CLUSTER_TESTS='*.test_management* 
 -DDURATION=2'
 It will fail, usually on the first iteration, showing the log files that 
 don't match. Use diff or other such tool to confirm that the mismatched lines 
 are as above. The file may also contain some other mismatches showing a 
 different number of stats in a periodic update - that is a consequence of the 
 above.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Resolved: (QPID-3118) cpp/examples/CMakeLists.txt tries to install non-existant files

[Steve Huston (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Huston resolved QPID-3118.


   Resolution: Fixed
Fix Version/s: (was: 0.9)
   0.11
   0.10

Fixed on 0.10 branch r1078833

 cpp/examples/CMakeLists.txt tries to install non-existant files
 ---

 Key: QPID-3118
 URL: https://issues.apache.org/jira/browse/QPID-3118
 Project: Qpid
  Issue Type: Bug
  Components: Packaging
Affects Versions: 0.9
 Environment: CMake builds
Reporter: Steve Huston
Assignee: Steve Huston
 Fix For: 0.10, 0.11

 Attachments: QPID-3118.diff


 The examples revision in QPID-3097 moved some files; the CMakeLists.txt still 
 refers to them. This prevents the Windows installer from generating a package 
 correctly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3109) Java client needs to implement the Delete option in address string

[Rajith Attapattu (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003438#comment-13003438
 ] 

Rajith Attapattu commented on QPID-3109:


I am currently fixing a bug related to this area and will add the null check as 
well.

However I don't know how useful it is to create a producer (or a consumer) with 
a null destination other than in a test case.
IMO the code should probably throw an exception if a null destination is passed 
when creating a producer or a consumer.
But I will add the null check as it's much better to write defensive code.

 Java client needs to implement the Delete option in address string
 --

 Key: QPID-3109
 URL: https://issues.apache.org/jira/browse/QPID-3109
 Project: Qpid
  Issue Type: Improvement
  Components: Java Client
Affects Versions: 0.8
Reporter: Rajith Attapattu
Assignee: Rajith Attapattu
Priority: Minor
 Fix For: 0.9


 The address syntax defines a delete option with 4 possible values - {always, 
 receiver, sender, never}.
 The default value is 'never'.
 if delete = 'always' or delete = 'sender', then when a sender is closed it 
 should delete the queue.
 if delete = 'always' or delete = 'receiver', then when a receiver is closed 
 it should delete the queue.
 Please note that the client will delete the queue irrespective of whether 
 there are consumers on the queue or not.
 Also it will not take into account whether the queue is empty or not.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3109) Java client needs to implement the Delete option in address string

[Robbie Gemmell (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003444#comment-13003444
 ] 

Robbie Gemmell commented on QPID-3109:
--

From the MessageProducer Javadoc:

A client also has the option of creating a message producer without supplying 
a destination. In this case, a destination must be provided with every send 
operation. A typical use for this kind of message producer is to send replies 
to requests using the request's JMSReplyTo destination. 

 Java client needs to implement the Delete option in address string
 --

 Key: QPID-3109
 URL: https://issues.apache.org/jira/browse/QPID-3109
 Project: Qpid
  Issue Type: Improvement
  Components: Java Client
Affects Versions: 0.8
Reporter: Rajith Attapattu
Assignee: Rajith Attapattu
Priority: Minor
 Fix For: 0.9


 The address syntax defines a delete option with 4 possible values - {always, 
 receiver, sender, never}.
 The default value is 'never'.
 if delete = 'always' or delete = 'sender', then when a sender is closed it 
 should delete the queue.
 if delete = 'always' or delete = 'receiver', then when a receiver is closed 
 it should delete the queue.
 Please note that the client will delete the queue irrespective of whether 
 there are consumers on the queue or not.
 Also it will not take into account whether the queue is empty or not.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3109) Java client needs to implement the Delete option in address string

[Rajith Attapattu (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003446#comment-13003446
 ] 

Rajith Attapattu commented on QPID-3109:


Interesting... I totally missed that part. 
Robbie thanks for pointing that out to me.

 Java client needs to implement the Delete option in address string
 --

 Key: QPID-3109
 URL: https://issues.apache.org/jira/browse/QPID-3109
 Project: Qpid
  Issue Type: Improvement
  Components: Java Client
Affects Versions: 0.8
Reporter: Rajith Attapattu
Assignee: Rajith Attapattu
Priority: Minor
 Fix For: 0.9


 The address syntax defines a delete option with 4 possible values - {always, 
 receiver, sender, never}.
 The default value is 'never'.
 if delete = 'always' or delete = 'sender', then when a sender is closed it 
 should delete the queue.
 if delete = 'always' or delete = 'receiver', then when a receiver is closed 
 it should delete the queue.
 Please note that the client will delete the queue irrespective of whether 
 there are consumers on the queue or not.
 Also it will not take into account whether the queue is empty or not.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Resolved: (QPID-3120) Queue reroute doesn't honor alternate exchange

[Gordon Sim (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved QPID-3120.
--

Resolution: Fixed

 Queue reroute doesn't honor alternate exchange
 --

 Key: QPID-3120
 URL: https://issues.apache.org/jira/browse/QPID-3120
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker
Affects Versions: 0.8
Reporter: Gordon Sim
Assignee: Gordon Sim
 Fix For: 0.9


 When invoking the reroute method on a queue, messages delivered to an 
 exchange are dropped instead of being delivered to the exchange's alternate 
 exchange if no bindings match.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3070) SessionComplete command sent for empty range

[Rafael H. Schloming (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003465#comment-13003465
 ] 

Rafael H. Schloming commented on QPID-3070:
---

I don't think there was any good reason for it. I'd go ahead with the change.

 SessionComplete command sent for empty range
 

 Key: QPID-3070
 URL: https://issues.apache.org/jira/browse/QPID-3070
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker, Java Client
Affects Versions: 0.9
Reporter: Andrew Kennedy
Assignee: Andrew Kennedy
 Fix For: 0.11


 The 0-10 AMQP protocol implementation sends a SessionComplete command with an 
 empty RangeSet, which will be replied to with a SessionKnownComplete and a 
 similar empty or null RangeSet (these are equivalent on the wire) iff the 
 TimelyReply field is set to true in the request.
 I think that the initial empty SessionComplete (caused by a call to 
 flushProcessed normally) should never be sent, so adding a check for 
 range.size()  0 before sending should do this.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-3079) message.accept command should be completed on a per-dequeue basis

[Ken Giusti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ken Giusti updated QPID-3079:
-

Fix Version/s: 0.11

 message.accept command should be completed on a per-dequeue basis
 -

 Key: QPID-3079
 URL: https://issues.apache.org/jira/browse/QPID-3079
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker
Affects Versions: 0.8, 0.9
Reporter: Ken Giusti
Assignee: Ken Giusti
 Fix For: 0.11


 ** Overview
 Asynchronous completion means that command execution is initiated in one 
 thread
 (a client connection thread) and completed in a different thread.
 When the async store is loaded, message.transfer commands are
 completed by a store thread that does the async write.
 ** Issues with asynchronous completion code as of revision r1029686
 *** Not really asynchronous
 IncompleteMessageList::process blocks the connection thread till all
 outstanding async commands (messages) for the session are complete.
 With the new cluster, this could deadlock since it is blocking a Poller 
 thread.
 *** Race condition for message.transfer
 
 Sketch of the current code:
 // Called in connection thread 
 PersistableMessage::enqueueAsync { ++counter; } 
 // Called in store thread once message is written.
 PersistableMessage::enqueueComplete { if (--counter == 0) notifyCompleted(); }
 The intent is that notify be called once per message, after the
 message has been written to each queue it was routed to.
 However of a message is routed to N queues, it's possible for
 notifyCompleted to be called up to N times. The store thread could
 call notifyCompleted for the first queue before the connection thread
 has called enqueueAsync for the second queue, and so on.
 *** No asynchronous completion for message.accept
 We do not currently delay completion of message.accept until the
 message is deleted from the async store. This could cause duplicate
 delivery if the broker crashes after completing the message but 
 before it is removed from store.
 There is code in PersistableMessage to maintain a counter for dequeues
 analogous to to the async enqueue code but this is incorrect. 
 Completion of transfer is triggered when all enqueues for a message are 
 complete.
 Completion of accept is triggered for *each* dequeue from a queue 
 independently.
 Furthermore a single accept can reference many messages, so it can't be 
 associated with a message.
 ** New requirements
 The new cluster design will need to participate in async completion, e.g.
 an accept cannot be comlpeted until the message is 
 - removed from store (if present) AND
 - replicated to the cluster (if present) as dequeued
 The new cluster also needs to asynchronously complete binding commands
 (declare, bind, delete) when they are replicated to the cluster.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-3080) Broker should issue QMF event on queue flow control state change

[Ken Giusti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ken Giusti updated QPID-3080:
-

Issue Type: Improvement  (was: Bug)

 Broker should issue QMF event on queue flow control state change
 

 Key: QPID-3080
 URL: https://issues.apache.org/jira/browse/QPID-3080
 Project: Qpid
  Issue Type: Improvement
  Components: C++ Broker
Affects Versions: 0.9
 Environment: all
Reporter: Ken Giusti
Assignee: Ken Giusti
Priority: Trivial
 Fix For: Future

 Attachments: QPID-3080.patch


 When a queue's flow control state changes, the broker should issue an QMF 
 event to notify management clients.
 A rough sketch of a possible schema implementation for the event:
   eventArguments
 
 arg name=qName type=sstr   desc=Name of a queue/
 arg name=msgDepth  type=count32 desc=Current size of queue in 
 messages/
 arg name=byteDepth type=count32 desc=Current size of queue in 
 bytes/
 arg name=active   type=bool desc=True if flow stopped, else flow 
 allowed/
   /eventArguments
   event name=queueFlowControl   sev=inform args=qName, active, 
 msgDepth, byteDepth/

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Closed: (QPID-2261) QMF V2 API implementation (Python).

[Ken Giusti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ken Giusti closed QPID-2261.


Resolution: Invalid

V2 Python implemented as a wrapper over the V2 C++ libraries.

 QMF V2 API implementation (Python).
 ---

 Key: QPID-2261
 URL: https://issues.apache.org/jira/browse/QPID-2261
 Project: Qpid
  Issue Type: Improvement
  Components: Qpid Managment Framework
Reporter: Ken Giusti
Assignee: Ken Giusti
 Attachments: qmfv2-01-04-10.patch, qmfv2-01-11-10.patch, 
 qmfv2-01-14-10.patch, qmfv2-01192010.patch, qmfv2-12-14-09.patch, 
 qmfv2-12-16-09.patch, qmfv2-12-22-09.patch, qmfv2.patch


 To track code proposed for implementing the QMFv2 api.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Closed: (QPID-2248) QMF: proposed API for QMFv2

[Ken Giusti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ken Giusti closed QPID-2248.


Resolution: Not A Problem

Prototype API no longer needed - new API is available as of 0.10

 QMF: proposed API for QMFv2 
 

 Key: QPID-2248
 URL: https://issues.apache.org/jira/browse/QPID-2248
 Project: Qpid
  Issue Type: New Feature
  Components: Qpid Managment Framework
Reporter: Ken Giusti
Assignee: Ken Giusti
 Attachments: qmf-ng-api-01042010.txt, qmf-ng-api-01052010.txt, 
 qmf-ng-api-01192010.txt, qmf-ng-api-12012009.txt, qmf-ng-api-12042009.patch, 
 qmf-ng-api-12042009.txt, qmf-ng-api-12112009.txt, qmf-ng-api-12142009.txt, 
 qmf-ng-api-12232009.txt


 Track the evolution of the QMFv2 api document.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2216) Error for missing ssl-cert-db option reports wrong option name

[Gordon Sim (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim updated QPID-2216:
-

Fix Version/s: 0.11

 Error for missing ssl-cert-db option reports wrong option name
 --

 Key: QPID-2216
 URL: https://issues.apache.org/jira/browse/QPID-2216
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker
Affects Versions: 0.6
 Environment: Linux
Reporter: Steve Huston
Priority: Minor
 Fix For: 0.11


 On Linux, trying to run the broker with the ssl module, but forgetting the 
 ssl-cert-db option, yields:
 2009-11-24 18:48:18 info SSL plugin not enabled, you must set 
 --qpid-ssl-cert-db to enable it.
 Two problems:
 1. It's an 'info' message, so is not visible with default logging level set; 
 I added -t to see this.
 2. the option that must be set is --ssl-cert-db, not --qpid-ssl-cert-db 
 (--help reports it correctly)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Resolved: (QPID-2216) Error for missing ssl-cert-db option reports wrong option name

[Gordon Sim (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved QPID-2216.
--

Resolution: Fixed

 Error for missing ssl-cert-db option reports wrong option name
 --

 Key: QPID-2216
 URL: https://issues.apache.org/jira/browse/QPID-2216
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker
Affects Versions: 0.6
 Environment: Linux
Reporter: Steve Huston
Priority: Minor
 Fix For: 0.11


 On Linux, trying to run the broker with the ssl module, but forgetting the 
 ssl-cert-db option, yields:
 2009-11-24 18:48:18 info SSL plugin not enabled, you must set 
 --qpid-ssl-cert-db to enable it.
 Two problems:
 1. It's an 'info' message, so is not visible with default logging level set; 
 I added -t to see this.
 2. the option that must be set is --ssl-cert-db, not --qpid-ssl-cert-db 
 (--help reports it correctly)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Created: (QPID-3122) backward compatibility problem with 0.9 agents

[Ted Ross (JIRA)]

backward compatibility problem with 0.9 agents
--

 Key: QPID-3122
 URL: https://issues.apache.org/jira/browse/QPID-3122
 Project: Qpid
  Issue Type: Bug
  Components: Qpid Managment Framework
Affects Versions: 0.8
Reporter: Ted Ross
Assignee: Ted Ross
Priority: Minor
 Fix For: 0.10


The QMF console needs to accept older agent-map keywords as well as the newer 
ones.

The attributes advertised in the agent heartbeat include the following keys 
that were changed in 0.10 for consistency:

timestamp = _timestamp
heartbeat_interval = _heartbeat_interval
epoch = _epoch


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2546) QMF: ruby and python bindings need event support

[Ken Giusti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ken Giusti updated QPID-2546:
-

Fix Version/s: (was: 0.9)

 QMF: ruby and python bindings need event support
 

 Key: QPID-2546
 URL: https://issues.apache.org/jira/browse/QPID-2546
 Project: Qpid
  Issue Type: Bug
  Components: Qpid Managment Framework
Affects Versions: 0.7
Reporter: Ken Giusti
Assignee: Ken Giusti
 Fix For: 0.10


 Missing functionality.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Resolved: (QPID-2546) QMF: ruby and python bindings need event support

[Ken Giusti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ken Giusti resolved QPID-2546.
--

   Resolution: Fixed
Fix Version/s: 0.10

raiseEvent (python) and raise_event (ruby) api provided by qmf v2 api

 QMF: ruby and python bindings need event support
 

 Key: QPID-2546
 URL: https://issues.apache.org/jira/browse/QPID-2546
 Project: Qpid
  Issue Type: Bug
  Components: Qpid Managment Framework
Affects Versions: 0.7
Reporter: Ken Giusti
Assignee: Ken Giusti
 Fix For: 0.9, 0.10


 Missing functionality.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Request for QPID-3122 in 0.10

[Ted Ross]

This fix is simple and changes the two QMFv2 consoles (Python and C++) 
to accept both the new agent-attribute keys as well as older versions of 
the keys.  Specifically, underscores were prepended to the keys to 
distinguish protocol-required keys from user-defined attribute keys.


Jira:https://issues.apache.org/jira/browse/QPID-3122
Commit:  http://svn.apache.org/viewvc?rev=1078895view=rev

-Ted


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Created: (QPID-3123) disallow federation links between members of a cluster

[michael j. goulish (JIRA)]

disallow federation links between members of a cluster
--

 Key: QPID-3123
 URL: https://issues.apache.org/jira/browse/QPID-3123
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker
Reporter: michael j. goulish
Assignee: michael j. goulish
Priority: Minor


Attempts to create a federation link between two brokers that are members of 
the same cluster should be disallowed.   Otherwise messages delivered to one 
end of the link are double-delivered to members of the cluster.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3122) backward compatibility problem with 0.9 agents

[Ken Giusti (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003548#comment-13003548
 ] 

Ken Giusti commented on QPID-3122:
--

There's a change introduced to the python console by this patch that doesn't 
appear to be related:

@@ -2416,7 +2427,7 @@
   if uid.__class__ == tuple and len(uid) == 2:
 self.saslUser = uid[1]
   else:
-self.saslUser = None
+self.saslUser = self.authUser
 
   # prevent topic queues from filling up (and causing the agents to
   # disconnect) by discarding the oldest queued messages when full.


Is this related?

 backward compatibility problem with 0.9 agents
 --

 Key: QPID-3122
 URL: https://issues.apache.org/jira/browse/QPID-3122
 Project: Qpid
  Issue Type: Bug
  Components: Qpid Managment Framework
Affects Versions: 0.8
Reporter: Ted Ross
Assignee: Ted Ross
Priority: Minor
 Fix For: 0.10


 The QMF console needs to accept older agent-map keywords as well as the newer 
 ones.
 The attributes advertised in the agent heartbeat include the following keys 
 that were changed in 0.10 for consistency:
 timestamp = _timestamp
 heartbeat_interval = _heartbeat_interval
 epoch = _epoch

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3122) backward compatibility problem with 0.9 agents

[Ted Ross (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003549#comment-13003549
 ] 

Ted Ross commented on QPID-3122:


There is a second change that was carried in this commit:

@@ -2416,7 +2427,7 @@
   if uid.__class__ == tuple and len(uid) == 2:
 self.saslUser = uid[1]
   else:
-self.saslUser = None
+self.saslUser = self.authUser

This allows the user-id to fall back to the requested username (supplied in the 
URL) if the saslwrapper library is not installed and in-use.  This is related 
to the change committed in r1071138.


 backward compatibility problem with 0.9 agents
 --

 Key: QPID-3122
 URL: https://issues.apache.org/jira/browse/QPID-3122
 Project: Qpid
  Issue Type: Bug
  Components: Qpid Managment Framework
Affects Versions: 0.8
Reporter: Ted Ross
Assignee: Ted Ross
Priority: Minor
 Fix For: 0.10


 The QMF console needs to accept older agent-map keywords as well as the newer 
 ones.
 The attributes advertised in the agent heartbeat include the following keys 
 that were changed in 0.10 for consistency:
 timestamp = _timestamp
 heartbeat_interval = _heartbeat_interval
 epoch = _epoch

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3122) backward compatibility problem with 0.9 agents

[Justin Ross (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003553#comment-13003553
 ] 

Justin Ross commented on QPID-3122:
---

Approved for 0.10.  Also reviewed and approved by Ken Giusti.

 backward compatibility problem with 0.9 agents
 --

 Key: QPID-3122
 URL: https://issues.apache.org/jira/browse/QPID-3122
 Project: Qpid
  Issue Type: Bug
  Components: Qpid Managment Framework
Affects Versions: 0.8
Reporter: Ted Ross
Assignee: Ted Ross
Priority: Minor
 Fix For: 0.10


 The QMF console needs to accept older agent-map keywords as well as the newer 
 ones.
 The attributes advertised in the agent heartbeat include the following keys 
 that were changed in 0.10 for consistency:
 timestamp = _timestamp
 heartbeat_interval = _heartbeat_interval
 epoch = _epoch

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Created: (QPID-3124) Update release script for new build artifacts

[Justin Ross (JIRA)]

Update release script for new build artifacts
-

 Key: QPID-3124
 URL: https://issues.apache.org/jira/browse/QPID-3124
 Project: Qpid
  Issue Type: Improvement
  Components: Build Tools
Affects Versions: 0.10, 0.11
Reporter: Justin Ross
 Fix For: 0.10, 0.11
 Attachments: release.sh.patch

This patch (1) fixes the scripting for maven artifacts and (2) adds scripting 
for the qmf and tools components.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-3124) Update release script for new build artifacts

[Justin Ross (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Ross updated QPID-3124:
--

Attachment: release.sh.patch

Patch to bin/release.sh

 Update release script for new build artifacts
 -

 Key: QPID-3124
 URL: https://issues.apache.org/jira/browse/QPID-3124
 Project: Qpid
  Issue Type: Improvement
  Components: Build Tools
Affects Versions: 0.10, 0.11
Reporter: Justin Ross
 Fix For: 0.10, 0.11

 Attachments: release.sh.patch


 This patch (1) fixes the scripting for maven artifacts and (2) adds scripting 
 for the qmf and tools components.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Created: (QPID-3125) Add junitreport task for readability in Java unit tests

[Weston M. Price (JIRA)]

Add junitreport task for readability in Java unit tests
---

 Key: QPID-3125
 URL: https://issues.apache.org/jira/browse/QPID-3125
 Project: Qpid
  Issue Type: Improvement
  Components: Java Tests
Affects Versions: 0.11
 Environment: All platforms. Area of functionality is Java based unit 
tests.
Reporter: Weston M. Price
Priority: Trivial
 Fix For: 0.11


Currently when running the unit tests there is no real convenient way to see 
what has failed and why. The attached patch makes a modification to the 
module.xml file for the java tests to allow junit to print a report after the 
testsuite is run to output the results in html format. The results are placed 
into

build/results/module-name/report/html

where module name is one of client, common, systests etc.



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-3125) Add junitreport task for readability in Java unit tests

[Weston M. Price (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Weston M. Price updated QPID-3125:
--

Attachment: module.patch

Simple patch file to add junitreport task to module.xml for java based unit 
tests.

 Add junitreport task for readability in Java unit tests
 ---

 Key: QPID-3125
 URL: https://issues.apache.org/jira/browse/QPID-3125
 Project: Qpid
  Issue Type: Improvement
  Components: Java Tests
Affects Versions: 0.11
 Environment: All platforms. Area of functionality is Java based unit 
 tests.
Reporter: Weston M. Price
Priority: Trivial
 Fix For: 0.11

 Attachments: module.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 Currently when running the unit tests there is no real convenient way to see 
 what has failed and why. The attached patch makes a modification to the 
 module.xml file for the java tests to allow junit to print a report after the 
 testsuite is run to output the results in html format. The results are placed 
 into
 build/results/module-name/report/html
 where module name is one of client, common, systests etc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3121) Cluster management inconsistency when using persistent store.

[Alan Conway (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003603#comment-13003603
 ] 

Alan Conway commented on QPID-3121:
---

Fix committed to trunk r1078947

 Cluster management inconsistency when using persistent store.
 -

 Key: QPID-3121
 URL: https://issues.apache.org/jira/browse/QPID-3121
 Project: Qpid
  Issue Type: Bug
  Components: C++ Clustering
Affects Versions: 0.9
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.9

 Attachments: durable-test-mgmt.patch


 If cluster_tests.py, test_management is modified to enable durable messages, 
 it fails the log comparison test shows messages like this on one broker but 
 not the others:
 trace Changed V1 statistics 
 org.apache.qpid.broker:connection:127.0.0.1:52742-127.0.0.1:44104 len=NN
 trace Changed V2 statistics 
 org.apache.qpid.broker:connection:127.0.0.1:52742-127.0.0.1:44104
 To date this hasn't been seen to actually cause a cluster crash but in 
 principle it is possible it could.
 To reproduce, build the message store at: 
 http://anonsvn.jboss.org/repos/rhmessaging/store/
 In the tests/cluster directory, run this in a loop:
 make check TESTS=run_python_cluster_tests CLUSTER_TESTS='*.test_management* 
 -DDURATION=2'
 It will fail, usually on the first iteration, showing the log files that 
 don't match. Use diff or other such tool to confirm that the mismatched lines 
 are as above. The file may also contain some other mismatches showing a 
 different number of stats in a periodic update - that is a consequence of the 
 above.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3121) Cluster management inconsistency when using persistent store.

[Justin Ross (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003602#comment-13003602
 ] 

Justin Ross commented on QPID-3121:
---

Approved for 0.10. Also reviewed on reviewboard by Ken Giusti.

 Cluster management inconsistency when using persistent store.
 -

 Key: QPID-3121
 URL: https://issues.apache.org/jira/browse/QPID-3121
 Project: Qpid
  Issue Type: Bug
  Components: C++ Clustering
Affects Versions: 0.9
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.9

 Attachments: durable-test-mgmt.patch


 If cluster_tests.py, test_management is modified to enable durable messages, 
 it fails the log comparison test shows messages like this on one broker but 
 not the others:
 trace Changed V1 statistics 
 org.apache.qpid.broker:connection:127.0.0.1:52742-127.0.0.1:44104 len=NN
 trace Changed V2 statistics 
 org.apache.qpid.broker:connection:127.0.0.1:52742-127.0.0.1:44104
 To date this hasn't been seen to actually cause a cluster crash but in 
 principle it is possible it could.
 To reproduce, build the message store at: 
 http://anonsvn.jboss.org/repos/rhmessaging/store/
 In the tests/cluster directory, run this in a loop:
 make check TESTS=run_python_cluster_tests CLUSTER_TESTS='*.test_management* 
 -DDURATION=2'
 It will fail, usually on the first iteration, showing the log files that 
 don't match. Use diff or other such tool to confirm that the mismatched lines 
 are as above. The file may also contain some other mismatches showing a 
 different number of stats in a periodic update - that is a consequence of the 
 above.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3121) Cluster management inconsistency when using persistent store.

[Alan Conway (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003630#comment-13003630
 ] 

Alan Conway commented on QPID-3121:
---

Also comitted to 0.10 release branch QPID-3121

 Cluster management inconsistency when using persistent store.
 -

 Key: QPID-3121
 URL: https://issues.apache.org/jira/browse/QPID-3121
 Project: Qpid
  Issue Type: Bug
  Components: C++ Clustering
Affects Versions: 0.9
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.9

 Attachments: durable-test-mgmt.patch


 If cluster_tests.py, test_management is modified to enable durable messages, 
 it fails the log comparison test shows messages like this on one broker but 
 not the others:
 trace Changed V1 statistics 
 org.apache.qpid.broker:connection:127.0.0.1:52742-127.0.0.1:44104 len=NN
 trace Changed V2 statistics 
 org.apache.qpid.broker:connection:127.0.0.1:52742-127.0.0.1:44104
 To date this hasn't been seen to actually cause a cluster crash but in 
 principle it is possible it could.
 To reproduce, build the message store at: 
 http://anonsvn.jboss.org/repos/rhmessaging/store/
 In the tests/cluster directory, run this in a loop:
 make check TESTS=run_python_cluster_tests CLUSTER_TESTS='*.test_management* 
 -DDURATION=2'
 It will fail, usually on the first iteration, showing the log files that 
 don't match. Use diff or other such tool to confirm that the mismatched lines 
 are as above. The file may also contain some other mismatches showing a 
 different number of stats in a periodic update - that is a consequence of the 
 above.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3125) Add junitreport task for readability in Java unit tests

[Robbie Gemmell (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003629#comment-13003629
 ] 

Robbie Gemmell commented on QPID-3125:
--

Have you tried running 'ant report' after running the tests?

Admitedly it isnt module-level as with your patch, but I actually find that 
preferable since it means you dont need to look in several different places to 
find the results. The seprate target doesnt force generation of the report 
files, which is useful if you dont actually want to generate them (I hardly 
ever do).

 Add junitreport task for readability in Java unit tests
 ---

 Key: QPID-3125
 URL: https://issues.apache.org/jira/browse/QPID-3125
 Project: Qpid
  Issue Type: Improvement
  Components: Java Tests
Affects Versions: 0.11
 Environment: All platforms. Area of functionality is Java based unit 
 tests.
Reporter: Weston M. Price
Priority: Trivial
 Fix For: 0.11

 Attachments: module.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 Currently when running the unit tests there is no real convenient way to see 
 what has failed and why. The attached patch makes a modification to the 
 module.xml file for the java tests to allow junit to print a report after the 
 testsuite is run to output the results in html format. The results are placed 
 into
 build/results/module-name/report/html
 where module name is one of client, common, systests etc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3125) Add junitreport task for readability in Java unit tests

[Rajith Attapattu (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003633#comment-13003633
 ] 

Rajith Attapattu commented on QPID-3125:


I'd agree with Robbie. I would also prefer a separate target for report 
generation. I also prefer the current report format where I can see at a glance 
the failures, rather than having to go into each module. 

 Add junitreport task for readability in Java unit tests
 ---

 Key: QPID-3125
 URL: https://issues.apache.org/jira/browse/QPID-3125
 Project: Qpid
  Issue Type: Improvement
  Components: Java Tests
Affects Versions: 0.11
 Environment: All platforms. Area of functionality is Java based unit 
 tests.
Reporter: Weston M. Price
Priority: Trivial
 Fix For: 0.11

 Attachments: module.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 Currently when running the unit tests there is no real convenient way to see 
 what has failed and why. The attached patch makes a modification to the 
 module.xml file for the java tests to allow junit to print a report after the 
 testsuite is run to output the results in html format. The results are placed 
 into
 build/results/module-name/report/html
 where module name is one of client, common, systests etc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3125) Add junitreport task for readability in Java unit tests

[Weston M. Price (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003631#comment-13003631
 ] 

Weston M. Price commented on QPID-3125:
---

Yep, it certainly does. Agreed, I think this is a better approach as well. The 
only reason for the patch was the split between modules but I agree, it 
probably doesn't warrant a separate task. 



 Add junitreport task for readability in Java unit tests
 ---

 Key: QPID-3125
 URL: https://issues.apache.org/jira/browse/QPID-3125
 Project: Qpid
  Issue Type: Improvement
  Components: Java Tests
Affects Versions: 0.11
 Environment: All platforms. Area of functionality is Java based unit 
 tests.
Reporter: Weston M. Price
Priority: Trivial
 Fix For: 0.11

 Attachments: module.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 Currently when running the unit tests there is no real convenient way to see 
 what has failed and why. The attached patch makes a modification to the 
 module.xml file for the java tests to allow junit to print a report after the 
 testsuite is run to output the results in html format. The results are placed 
 into
 build/results/module-name/report/html
 where module name is one of client, common, systests etc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Resolved: (QPID-3121) Cluster management inconsistency when using persistent store.

[Alan Conway (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway resolved QPID-3121.
---

Resolution: Fixed

Committed to trunk and 0.10 branch.

 Cluster management inconsistency when using persistent store.
 -

 Key: QPID-3121
 URL: https://issues.apache.org/jira/browse/QPID-3121
 Project: Qpid
  Issue Type: Bug
  Components: C++ Clustering
Affects Versions: 0.9
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.9

 Attachments: durable-test-mgmt.patch


 If cluster_tests.py, test_management is modified to enable durable messages, 
 it fails the log comparison test shows messages like this on one broker but 
 not the others:
 trace Changed V1 statistics 
 org.apache.qpid.broker:connection:127.0.0.1:52742-127.0.0.1:44104 len=NN
 trace Changed V2 statistics 
 org.apache.qpid.broker:connection:127.0.0.1:52742-127.0.0.1:44104
 To date this hasn't been seen to actually cause a cluster crash but in 
 principle it is possible it could.
 To reproduce, build the message store at: 
 http://anonsvn.jboss.org/repos/rhmessaging/store/
 In the tests/cluster directory, run this in a loop:
 make check TESTS=run_python_cluster_tests CLUSTER_TESTS='*.test_management* 
 -DDURATION=2'
 It will fail, usually on the first iteration, showing the log files that 
 don't match. Use diff or other such tool to confirm that the mismatched lines 
 are as above. The file may also contain some other mismatches showing a 
 different number of stats in a periodic update - that is a consequence of the 
 above.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Closed: (QPID-3125) Add junitreport task for readability in Java unit tests

[Weston M. Price (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Weston M. Price closed QPID-3125.
-

Resolution: Won't Fix

Better solution presented that already exists within the build system.

 Add junitreport task for readability in Java unit tests
 ---

 Key: QPID-3125
 URL: https://issues.apache.org/jira/browse/QPID-3125
 Project: Qpid
  Issue Type: Improvement
  Components: Java Tests
Affects Versions: 0.11
 Environment: All platforms. Area of functionality is Java based unit 
 tests.
Reporter: Weston M. Price
Priority: Trivial
 Fix For: 0.11

 Attachments: module.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 Currently when running the unit tests there is no real convenient way to see 
 what has failed and why. The attached patch makes a modification to the 
 module.xml file for the java tests to allow junit to print a report after the 
 testsuite is run to output the results in html format. The results are placed 
 into
 build/results/module-name/report/html
 where module name is one of client, common, systests etc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2733) Temp queues created when receiving from an exchange are not deleted.

[Rajith Attapattu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajith Attapattu updated QPID-2733:
---

Fix Version/s: (was: 0.9)
   Future

Descoping the JIRA as the current solution does not implement all the 
functionality described in the description.

 Temp queues created when receiving from an exchange are not deleted.  
 --

 Key: QPID-2733
 URL: https://issues.apache.org/jira/browse/QPID-2733
 Project: Qpid
  Issue Type: Bug
  Components: Java Client
Reporter: Rajith Attapattu
Assignee: Rajith Attapattu
Priority: Minor
 Fix For: Future


 In the new addressing scheme, when you subscribe to an exchange a temp queue 
 is created for the subscriber.
 The queue deletion depends on the reliability mode.
 If reliability mode is unreliable or at-most-once then the queue should 
 be created with auto-delete=true. 
 If reliability mode is at-least-once then the queue should set 
 auto-delete=false, and the queue will only be deleted if the client app 
 invokes consumer.close().
 If x-declare properties include auto-delete=true, then the reliability mode 
 is ignored.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3125) Add junitreport task for readability in Java unit tests

[Robbie Gemmell (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003644#comment-13003644
 ] 

Robbie Gemmell commented on QPID-3125:
--

Whilst both myself and Rajith prefer the full set of results, that isnt to say 
we cant have both; I only object to the forced generation of results, I wouldnt 
actually be bothered by having e.g. 'report-module' as a new module-level build 
target that generated the alternative style results upon demand. 

To do that you would just need to add a module.xml level target and then use an 
iterator style target in build.xml (like most of the targets in the build 
system do) instead of adding it to the test task like your current patch.

 Add junitreport task for readability in Java unit tests
 ---

 Key: QPID-3125
 URL: https://issues.apache.org/jira/browse/QPID-3125
 Project: Qpid
  Issue Type: Improvement
  Components: Java Tests
Affects Versions: 0.11
 Environment: All platforms. Area of functionality is Java based unit 
 tests.
Reporter: Weston M. Price
Priority: Trivial
 Fix For: 0.11

 Attachments: module.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 Currently when running the unit tests there is no real convenient way to see 
 what has failed and why. The attached patch makes a modification to the 
 module.xml file for the java tests to allow junit to print a report after the 
 testsuite is run to output the results in html format. The results are placed 
 into
 build/results/module-name/report/html
 where module name is one of client, common, systests etc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Resolved: (QPID-3122) backward compatibility problem with 0.9 agents

[Ted Ross (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross resolved QPID-3122.


Resolution: Fixed

 backward compatibility problem with 0.9 agents
 --

 Key: QPID-3122
 URL: https://issues.apache.org/jira/browse/QPID-3122
 Project: Qpid
  Issue Type: Bug
  Components: Qpid Managment Framework
Affects Versions: 0.8
Reporter: Ted Ross
Assignee: Ted Ross
Priority: Minor
 Fix For: 0.10


 The QMF console needs to accept older agent-map keywords as well as the newer 
 ones.
 The attributes advertised in the agent heartbeat include the following keys 
 that were changed in 0.10 for consistency:
 timestamp = _timestamp
 heartbeat_interval = _heartbeat_interval
 epoch = _epoch

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Reopened: (QPID-3125) Add junitreport task for readability in Java unit tests

[Weston M. Price (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Weston M. Price reopened QPID-3125:
---


As a result of discussion I am reopening this issue and attaching an updated 
patch that provides unit test reports for each module within the QPID java 
framework.

 Add junitreport task for readability in Java unit tests
 ---

 Key: QPID-3125
 URL: https://issues.apache.org/jira/browse/QPID-3125
 Project: Qpid
  Issue Type: Improvement
  Components: Java Tests
Affects Versions: 0.11
 Environment: All platforms. Area of functionality is Java based unit 
 tests.
Reporter: Weston M. Price
Priority: Trivial
 Fix For: 0.11

 Attachments: module.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 Currently when running the unit tests there is no real convenient way to see 
 what has failed and why. The attached patch makes a modification to the 
 module.xml file for the java tests to allow junit to print a report after the 
 testsuite is run to output the results in html format. The results are placed 
 into
 build/results/module-name/report/html
 where module name is one of client, common, systests etc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-3125) Add junitreport task for readability in Java unit tests

[Weston M. Price (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Weston M. Price updated QPID-3125:
--

Attachment: report-module.patch

As a result of the discussion, I am attaching report-module.patch that provides 
junit reports for each module in the java QPID framework. To execute

ant test-report-module

 Add junitreport task for readability in Java unit tests
 ---

 Key: QPID-3125
 URL: https://issues.apache.org/jira/browse/QPID-3125
 Project: Qpid
  Issue Type: Improvement
  Components: Java Tests
Affects Versions: 0.11
 Environment: All platforms. Area of functionality is Java based unit 
 tests.
Reporter: Weston M. Price
Priority: Trivial
 Fix For: 0.11

 Attachments: module.patch, report-module.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 Currently when running the unit tests there is no real convenient way to see 
 what has failed and why. The attached patch makes a modification to the 
 module.xml file for the java tests to allow junit to print a report after the 
 testsuite is run to output the results in html format. The results are placed 
 into
 build/results/module-name/report/html
 where module name is one of client, common, systests etc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Assigned: (QPID-3125) Add junitreport task for readability in Java unit tests

[Robbie Gemmell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell reassigned QPID-3125:


Assignee: Robbie Gemmell

 Add junitreport task for readability in Java unit tests
 ---

 Key: QPID-3125
 URL: https://issues.apache.org/jira/browse/QPID-3125
 Project: Qpid
  Issue Type: Improvement
  Components: Java Tests
Affects Versions: 0.11
 Environment: All platforms. Area of functionality is Java based unit 
 tests.
Reporter: Weston M. Price
Assignee: Robbie Gemmell
Priority: Trivial
 Fix For: 0.11

 Attachments: module.patch, report-module.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 Currently when running the unit tests there is no real convenient way to see 
 what has failed and why. The attached patch makes a modification to the 
 module.xml file for the java tests to allow junit to print a report after the 
 testsuite is run to output the results in html format. The results are placed 
 into
 build/results/module-name/report/html
 where module name is one of client, common, systests etc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3125) Add junitreport task for readability in Java unit tests

[Robbie Gemmell (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003687#comment-13003687
 ] 

Robbie Gemmell commented on QPID-3125:
--

Just a couple small niggles: for clarity the new build.xml target should also 
just be 'report-module' so it aligns with the new module.xml task, and the line 
at module.xml ~L390 should not be removed.

If you update the patch I'll commit it in the morning.

 Add junitreport task for readability in Java unit tests
 ---

 Key: QPID-3125
 URL: https://issues.apache.org/jira/browse/QPID-3125
 Project: Qpid
  Issue Type: Improvement
  Components: Java Tests
Affects Versions: 0.11
 Environment: All platforms. Area of functionality is Java based unit 
 tests.
Reporter: Weston M. Price
Assignee: Robbie Gemmell
Priority: Trivial
 Fix For: 0.11

 Attachments: module.patch, report-module.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 Currently when running the unit tests there is no real convenient way to see 
 what has failed and why. The attached patch makes a modification to the 
 module.xml file for the java tests to allow junit to print a report after the 
 testsuite is run to output the results in html format. The results are placed 
 into
 build/results/module-name/report/html
 where module name is one of client, common, systests etc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-3125) Add junitreport task for readability in Java unit tests

[Weston M. Price (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003698#comment-13003698
 ] 

Weston M. Price commented on QPID-3125:
---

Thanks Robbie for both the guidance as well as looking at the patch. I am 
attaching the updated version. 



 Add junitreport task for readability in Java unit tests
 ---

 Key: QPID-3125
 URL: https://issues.apache.org/jira/browse/QPID-3125
 Project: Qpid
  Issue Type: Improvement
  Components: Java Tests
Affects Versions: 0.11
 Environment: All platforms. Area of functionality is Java based unit 
 tests.
Reporter: Weston M. Price
Assignee: Robbie Gemmell
Priority: Trivial
 Fix For: 0.11

 Attachments: module.patch, report-module.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 Currently when running the unit tests there is no real convenient way to see 
 what has failed and why. The attached patch makes a modification to the 
 module.xml file for the java tests to allow junit to print a report after the 
 testsuite is run to output the results in html format. The results are placed 
 into
 build/results/module-name/report/html
 where module name is one of client, common, systests etc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-3125) Add junitreport task for readability in Java unit tests

[Weston M. Price (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Weston M. Price updated QPID-3125:
--

Attachment: report-module-v2.patch

updated version per comments/suggestions.

 Add junitreport task for readability in Java unit tests
 ---

 Key: QPID-3125
 URL: https://issues.apache.org/jira/browse/QPID-3125
 Project: Qpid
  Issue Type: Improvement
  Components: Java Tests
Affects Versions: 0.11
 Environment: All platforms. Area of functionality is Java based unit 
 tests.
Reporter: Weston M. Price
Assignee: Robbie Gemmell
Priority: Trivial
 Fix For: 0.11

 Attachments: module.patch, report-module-v2.patch, report-module.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 Currently when running the unit tests there is no real convenient way to see 
 what has failed and why. The attached patch makes a modification to the 
 module.xml file for the java tests to allow junit to print a report after the 
 testsuite is run to output the results in html format. The results are placed 
 into
 build/results/module-name/report/html
 where module name is one of client, common, systests etc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2985) Add producer configurable transaction timeouts

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2985:
-

Status: Ready To Review  (was: In Progress)

 Add producer configurable transaction timeouts
 --

 Key: QPID-2985
 URL: https://issues.apache.org/jira/browse/QPID-2985
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Reporter: Andrew Kennedy
Assignee: Andrew Kennedy
 Fix For: 0.9


 Port  changes from QPID-2864 to trunk

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Assigned: (QPID-2984) Add statistics generation for broker message delivery

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy reassigned QPID-2984:


Assignee: Robbie Gemmell  (was: Andrew Kennedy)

Robbie, can you review please?

 Add statistics generation for broker message delivery
 -

 Key: QPID-2984
 URL: https://issues.apache.org/jira/browse/QPID-2984
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Reporter: Andrew Kennedy
Assignee: Robbie Gemmell
 Fix For: 0.11


 Port changes from QPID-2932 to trunk

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Assigned: (QPID-2985) Add producer configurable transaction timeouts

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy reassigned QPID-2985:


Assignee: Robbie Gemmell  (was: Andrew Kennedy)

Robbie, can you review please?

 Add producer configurable transaction timeouts
 --

 Key: QPID-2985
 URL: https://issues.apache.org/jira/browse/QPID-2985
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Reporter: Andrew Kennedy
Assignee: Robbie Gemmell
 Fix For: 0.9


 Port  changes from QPID-2864 to trunk

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2984) Add statistics generation for broker message delivery

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2984:
-

Fix Version/s: (was: 0.9)
   0.11

 Add statistics generation for broker message delivery
 -

 Key: QPID-2984
 URL: https://issues.apache.org/jira/browse/QPID-2984
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Reporter: Andrew Kennedy
Assignee: Robbie Gemmell
 Fix For: 0.11


 Port changes from QPID-2932 to trunk

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2984) Add statistics generation for broker message delivery

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2984:
-

Status: Ready To Review  (was: In Progress)

 Add statistics generation for broker message delivery
 -

 Key: QPID-2984
 URL: https://issues.apache.org/jira/browse/QPID-2984
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Reporter: Andrew Kennedy
Assignee: Andrew Kennedy
 Fix For: 0.11


 Port changes from QPID-2932 to trunk

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-3070) SessionComplete command sent for empty range

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-3070:
-

Status: Ready To Review  (was: In Progress)

 SessionComplete command sent for empty range
 

 Key: QPID-3070
 URL: https://issues.apache.org/jira/browse/QPID-3070
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker, Java Client
Affects Versions: 0.9
Reporter: Andrew Kennedy
Assignee: Andrew Kennedy
 Fix For: 0.11


 The 0-10 AMQP protocol implementation sends a SessionComplete command with an 
 empty RangeSet, which will be replied to with a SessionKnownComplete and a 
 similar empty or null RangeSet (these are equivalent on the wire) iff the 
 TimelyReply field is set to true in the request.
 I think that the initial empty SessionComplete (caused by a call to 
 flushProcessed normally) should never be sent, so adding a check for 
 range.size()  0 before sending should do this.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2985) Add producer configurable transaction timeouts

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2985:
-

Fix Version/s: (was: 0.9)
   0.11

 Add producer configurable transaction timeouts
 --

 Key: QPID-2985
 URL: https://issues.apache.org/jira/browse/QPID-2985
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Reporter: Andrew Kennedy
Assignee: Robbie Gemmell
 Fix For: 0.11


 Port  changes from QPID-2864 to trunk

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Assigned: (QPID-3070) SessionComplete command sent for empty range

[Andrew Kennedy (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy reassigned QPID-3070:


Assignee: Rafael H. Schloming  (was: Andrew Kennedy)

Rafi, can you confirm this is OK, please?

 SessionComplete command sent for empty range
 

 Key: QPID-3070
 URL: https://issues.apache.org/jira/browse/QPID-3070
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker, Java Client
Affects Versions: 0.9
Reporter: Andrew Kennedy
Assignee: Rafael H. Schloming
 Fix For: 0.11


 The 0-10 AMQP protocol implementation sends a SessionComplete command with an 
 empty RangeSet, which will be replied to with a SessionKnownComplete and a 
 similar empty or null RangeSet (these are equivalent on the wire) iff the 
 TimelyReply field is set to true in the request.
 I think that the initial empty SessionComplete (caused by a call to 
 flushProcessed normally) should never be sent, so adding a check for 
 range.size()  0 before sending should do this.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2519) Allow Windows Broker to run as a Service

[Steve Huston (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Huston updated QPID-2519:
---

Attachment: QPID-2519.diff

Patch against the point the trunk was branched; would replace orignal patch. 
I'll add this to the review site as well.

 Allow Windows Broker to run as a Service
 

 Key: QPID-2519
 URL: https://issues.apache.org/jira/browse/QPID-2519
 Project: Qpid
  Issue Type: New Feature
  Components: C++ Broker
 Environment: Windows
Reporter: Kerry Bonin
Assignee: Steve Huston
 Fix For: Future

 Attachments: QPID-2519.diff, broker_as_service_Qpid_Logging.patch, 
 broker_as_service_r921371.patch


 The Windows version of the C++ Broker should have the ability to run as a 
 Windows Service, to correspond with the ability of the *nix version to run as 
 a daemon, as this is a common requirement for critical software 
 infrastructure elements of enterprise class software on the Windows platform.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Review Request: Allow C++ broker to run as a Windows Service

[Steve Huston]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/479/
---

Review request for qpid and Andrew Stitcher.


Summary
---

Proposed changes to allow the broker to run as a Windows Service. Adds command 
line options to qpidd to install, uninstall, start, stop the service, as well 
as the detection that qpidd was started from the service manager and act 
accordingly (register w/ SCM, default logging to the system event log).


This addresses bug QPID-2519.
https://issues.apache.org/jira/browse/QPID-2519


Diffs
-

  /branches/QPID-2519/cpp/src/CMakeLists.txt 1072051 
  /branches/QPID-2519/cpp/src/posix/QpiddBroker.cpp 1072051 
  /branches/QPID-2519/cpp/src/qpidd.h 1072051 
  /branches/QPID-2519/cpp/src/qpidd.cpp 1072051 
  /branches/QPID-2519/cpp/src/windows/QpiddBroker.cpp 1072051 
  /branches/QPID-2519/cpp/src/windows/SCM.h PRE-CREATION 
  /branches/QPID-2519/cpp/src/windows/SCM.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/479/diff


Testing
---

Basic install, uninstall, start, stop. Has a problem running as LocalService 
that I don't yet know the cause of.


Thanks,

Steve

RE: 0.10 release update - feature integration week

[Steve Huston]

 -Original Message-
 From: Andrew Stitcher [mailto:astitc...@redhat.com] 
 Sent: Thursday, February 17, 2011 2:45 PM
 To: dev@qpid.apache.org
 Subject: RE: 0.10 release update - feature integration week
 
 
 On Wed, 2011-02-16 at 18:04 -0500, Steve Huston wrote:
   Hi, Steve.  End of the week is certainly okay.
  
  Ok, thanks.
  
   I see that change introduces some (warning, speaking from
   some naivete 
   here) big changes to broker config.  If that's the case, I'd 
   like it to 
   get a shot at some extra review.
  
  It's in JIRA... Reviews are welcome. Some of my earlier 
 review to the 
  submitter wasn't acted on, so there's real work to be done 
 to get it 
  ready for inclusion. If my time is less free than I 
 anticipate I may 
  not have time to get it in, but I'm going to try.
 
 Steve could you possibly publish the patch to review board? 
 I'd like to review this change and I've found that review 
 board is by far the most productive way to do it.

The latest patch is attached to QPID-2519 and is also on Review Board (I
mentioned Andrew specifically, but all are welcome to comment).

Thanks,
-Steve


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

JMS Queue Browser Implementation

[Rajith Attapattu]

Each time the getEnumeration method is called we create a new consumer.
I fully understand the reasons as to why each enumeration needs to have it's
own consumer.
However I am wondering if we could optimize this a bit more as an suspecting
user may end up creating lots of consumers by repeatedly calling
getEnumeration in a bid to receive the latest snapshot.
This may put a strain on the broker as well as the client side as it will
contain consumers (and local message queues) for no good reason.

If we can receive queue events (only interested in dequeues here) then we
can maintain a single local message queue per Queue browser.
We could potentially leverage the async queue replication strategy
(implemented in the c++ broker) here all though I am not sure if a similar
functionality exists in the Java broker.

Then each enumeration is just a light weight object which maintains only a
pointer (index) to the local queue.
If a dequeue event is received then that message is removed from the local
queue.
The local queue can be filled on demand using the sync receive method.

Thoughts ?

Regards,

Rajith