[jira] [Updated] (QPID-3307) ClassNotfound Exception when using Qpid java client in Complex classloading Environments.

2011-06-14 Thread Charith Dhanushka Wickramarachchi (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charith Dhanushka Wickramarachchi updated QPID-3307:


Attachment: QPID-3307_patch.txt

Attaching the patch to resolve this issue. 

I looked at the Apache ActiveMQ code and used the method they used to resolve 
this exact issue. 

thanks,
Charith

> ClassNotfound Exception when using Qpid java client in Complex classloading 
> Environments.  
> ---
>
> Key: QPID-3307
> URL: https://issues.apache.org/jira/browse/QPID-3307
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Reporter: Charith Dhanushka Wickramarachchi
>Priority: Critical
> Attachments: QPID-3307_patch.txt
>
>
> Hi ,
> When we are using qpid client to receive JMSObject in complex class loading 
> environments like web application containers/Osgi environments .There is a 
> scenario where this issues comes. 
> Scenario. 
> In a web application container normally they use a class loader per web app. 
> and if we have qpid client libs at the root classloader level this error can 
> come. The reason for this is Serializable  Object types that are used inside 
> the web app are not visible to the class loader that loads the JMSObject 
> message and unmarshall it.
> thanks,
> Charith

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Created] (QPID-3307) ClassNotfound Exception when using Qpid java client in Complex classloading Environments.

2011-06-14 Thread Charith Dhanushka Wickramarachchi (JIRA)
ClassNotfound Exception when using Qpid java client in Complex classloading 
Environments.  
---

 Key: QPID-3307
 URL: https://issues.apache.org/jira/browse/QPID-3307
 Project: Qpid
  Issue Type: Bug
  Components: Java Client
Reporter: Charith Dhanushka Wickramarachchi
Priority: Critical


Hi ,

When we are using qpid client to receive JMSObject in complex class loading 
environments like web application containers/Osgi environments .There is a 
scenario where this issues comes. 

Scenario. 

In a web application container normally they use a class loader per web app. 
and if we have qpid client libs at the root classloader level this error can 
come. The reason for this is Serializable  Object types that are used inside 
the web app are not visible to the class loader that loads the JMSObject 
message and unmarshall it.

thanks,
Charith


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-3256) Application which uses Qpid (in my case Excel) hangs on shutdown

2011-06-14 Thread Cliff Jansen (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049564#comment-13049564
 ] 

Cliff Jansen commented on QPID-3256:


I requested that the reporter test the patch in the JIRA and received the 
following response:

fromSmirnov Eugene eugen...@yandex.ru
to  Cliff Jansen 
dateTue, Jun 14, 2011 at 10:41 AM
subject Re: qpid 3256 excel hang

Hi Cliff

I've checked and it works fine.

Thank you!!!


> Application which uses Qpid (in my case Excel) hangs on shutdown
> 
>
> Key: QPID-3256
> URL: https://issues.apache.org/jira/browse/QPID-3256
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.8, 0.10
> Environment: OS: Windows.
> Qpid is assembled as DLL. 
>Reporter: Eugene
>Assignee: Steve Huston
> Fix For: 0.11
>
> Attachments: qpid-3256.patch
>
>
> Hi All
> I encountered with strange behavior on shutdown when using qpid 0-8 and 0-10. 
> When I use qpid in standalone console-application everything is ok. But when 
> I use qpid in DLL which is loaded into Excel (as RTD module), Excel hangs on 
> shutdown. 
> I found out that in standalone application on shutdown I have next stack:
>   qpidclientd.dll!qpid::client::`anonymous 
> namespace'::IOThread::~IOThread()  Line 138C++
>   qpidclientd.dll!`qpid::client::`anonymous 
> namespace'::theIO'::`2'::`dynamic atexit destructor for 'io''()  + 0xd bytes  
> C++
>   qpidclientd.dll!_CRT_INIT(void * hDllHandle=0x6008, unsigned long 
> dwReason=0, void * lpreserved=0x0001)  Line 449   C
>   qpidclientd.dll!__DllMainCRTStartup(void * hDllHandle=0x6008, 
> unsigned long dwReason=0, void * lpreserved=0x0001)  Line 560 + 0x11 
> bytesC
>   qpidclientd.dll!_DllMainCRTStartup(void * hDllHandle=0x6008, 
> unsigned long dwReason=0, void * lpreserved=0x0001)  Line 510 + 0x11 
> bytes C
>   ntdll.dll!77b79960()
>   [Frames below may be incorrect and/or missing, no symbols loaded for 
> ntdll.dll] 
>   ntdll.dll!77b9a516()
>   ntdll.dll!77b9a3b8()
>   kernel32.dll!77657363() 
>   msvcr90d.dll!__crtExitProcess(int status=0)  Line 732   C
>   msvcr90d.dll!doexit(int code=0, int quick=0, int retcaller=0)  Line 644 
> + 0x9 bytes C
>   msvcr90d.dll!exit(int code=0)  Line 412 + 0xd bytes C
>   Test.exe!__tmainCRTStartup()  Line 599  C
>   Test.exe!mainCRTStartup()  Line 403 C
>   kernel32.dll!77653677() 
>   ntdll.dll!77b79f02()
>   ntdll.dll!77b79ed5()
> And in this state all threads of application have been already terminated. 
> The only thread is:
> 1 >   21720   Main Thread Main Thread 
> qpid::client::`anonymous namespace'::IOThread::~IOThreadNormal  0
> so code from file ConnectionImpl.cpp works well:
> ~IOThread() {
> std::vector threads;
> {
> ScopedLock l(threadLock);
> if (poller_)
> poller_->shutdown();
> t.swap(threads);
> }
> for (std::vector::iterator i = threads.begin(); i != 
> threads.end(); ++i) {
> i->join();
> }
> }
> BUT in Excel I get stack:
> qpidclientd.dll!qpid::client::`anonymous namespace'::IOThread::~IOThread()  
> Line 130  C++
>   qpidclientd.dll!`qpid::client::`anonymous 
> namespace'::theIO'::`2'::`dynamic atexit destructor for 'io''()  + 0xd bytes  
> C++
>   qpidclientd.dll!_CRT_INIT(void * hDllHandle=0x0770, unsigned long 
> dwReason=0, void * lpreserved=0x)  Line 449   C
>   qpidclientd.dll!__DllMainCRTStartup(void * hDllHandle=0x0770, 
> unsigned long dwReason=0, void * lpreserved=0x)  Line 560 + 0x11 
> bytesC
>   qpidclientd.dll!_DllMainCRTStartup(void * hDllHandle=0x0770, 
> unsigned long dwReason=0, void * lpreserved=0x)  Line 510 + 0x11 
> bytes C
>   ntdll.dll!77b79960()
>   [Frames below may be incorrect and/or missing, no symbols loaded for 
> ntdll.dll] 
>   ntdll.dll!77ba1525()
>   ntdll.dll!77b81231()
>   KernelBase.dll!77281da7()   
>   ole32.dll!75bb9562()
>   ole32.dll!75bb9593()
>   ole32.dll!75bb95a7()
>   ole32.dll!75bb98bf()
>   ole32.dll!75bb9805()
>   ole32.dll!75bb9a8c()
>   EXCEL.EXE!2f3811e9()
>   EXCEL.EXE!2f6933e8()
>   EXCEL.EXE!2f32a5af()
>   EXCEL.EXE!2f34894a()
>   EXCEL.EXE!2f670001()
>   MSO.DLL!65bc6ed5()  
>   MSO.DLL!65c26a34()  
>   MSO.DLL!65c30305()  
>   MSO.DLL!65bc910c()  
>   MSO.DLL!65c4f420()  
>   MSO.DLL!65bbf161()  
>   comctl32.

[jira] [Commented] (QPID-3256) Application which uses Qpid (in my case Excel) hangs on shutdown

2011-06-14 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049557#comment-13049557
 ] 

jirapos...@reviews.apache.org commented on QPID-3256:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/904/
---

Review request for qpid.


Summary
---

Keeps track of Qpid runnable threads and other threads, ensuring that rundown 
doesn't deadlock.


This addresses bug QPID-3256.
https://issues.apache.org/jira/browse/QPID-3256


Diffs
-

  /trunk/qpid/cpp/src/qpid/sys/windows/Thread.cpp 1132733 

Diff: https://reviews.apache.org/r/904/diff


Testing
---

Qpid regression test suite.


Thanks,

Steve



> Application which uses Qpid (in my case Excel) hangs on shutdown
> 
>
> Key: QPID-3256
> URL: https://issues.apache.org/jira/browse/QPID-3256
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.8, 0.10
> Environment: OS: Windows.
> Qpid is assembled as DLL. 
>Reporter: Eugene
>Assignee: Steve Huston
> Fix For: 0.11
>
> Attachments: qpid-3256.patch
>
>
> Hi All
> I encountered with strange behavior on shutdown when using qpid 0-8 and 0-10. 
> When I use qpid in standalone console-application everything is ok. But when 
> I use qpid in DLL which is loaded into Excel (as RTD module), Excel hangs on 
> shutdown. 
> I found out that in standalone application on shutdown I have next stack:
>   qpidclientd.dll!qpid::client::`anonymous 
> namespace'::IOThread::~IOThread()  Line 138C++
>   qpidclientd.dll!`qpid::client::`anonymous 
> namespace'::theIO'::`2'::`dynamic atexit destructor for 'io''()  + 0xd bytes  
> C++
>   qpidclientd.dll!_CRT_INIT(void * hDllHandle=0x6008, unsigned long 
> dwReason=0, void * lpreserved=0x0001)  Line 449   C
>   qpidclientd.dll!__DllMainCRTStartup(void * hDllHandle=0x6008, 
> unsigned long dwReason=0, void * lpreserved=0x0001)  Line 560 + 0x11 
> bytesC
>   qpidclientd.dll!_DllMainCRTStartup(void * hDllHandle=0x6008, 
> unsigned long dwReason=0, void * lpreserved=0x0001)  Line 510 + 0x11 
> bytes C
>   ntdll.dll!77b79960()
>   [Frames below may be incorrect and/or missing, no symbols loaded for 
> ntdll.dll] 
>   ntdll.dll!77b9a516()
>   ntdll.dll!77b9a3b8()
>   kernel32.dll!77657363() 
>   msvcr90d.dll!__crtExitProcess(int status=0)  Line 732   C
>   msvcr90d.dll!doexit(int code=0, int quick=0, int retcaller=0)  Line 644 
> + 0x9 bytes C
>   msvcr90d.dll!exit(int code=0)  Line 412 + 0xd bytes C
>   Test.exe!__tmainCRTStartup()  Line 599  C
>   Test.exe!mainCRTStartup()  Line 403 C
>   kernel32.dll!77653677() 
>   ntdll.dll!77b79f02()
>   ntdll.dll!77b79ed5()
> And in this state all threads of application have been already terminated. 
> The only thread is:
> 1 >   21720   Main Thread Main Thread 
> qpid::client::`anonymous namespace'::IOThread::~IOThreadNormal  0
> so code from file ConnectionImpl.cpp works well:
> ~IOThread() {
> std::vector threads;
> {
> ScopedLock l(threadLock);
> if (poller_)
> poller_->shutdown();
> t.swap(threads);
> }
> for (std::vector::iterator i = threads.begin(); i != 
> threads.end(); ++i) {
> i->join();
> }
> }
> BUT in Excel I get stack:
> qpidclientd.dll!qpid::client::`anonymous namespace'::IOThread::~IOThread()  
> Line 130  C++
>   qpidclientd.dll!`qpid::client::`anonymous 
> namespace'::theIO'::`2'::`dynamic atexit destructor for 'io''()  + 0xd bytes  
> C++
>   qpidclientd.dll!_CRT_INIT(void * hDllHandle=0x0770, unsigned long 
> dwReason=0, void * lpreserved=0x)  Line 449   C
>   qpidclientd.dll!__DllMainCRTStartup(void * hDllHandle=0x0770, 
> unsigned long dwReason=0, void * lpreserved=0x)  Line 560 + 0x11 
> bytesC
>   qpidclientd.dll!_DllMainCRTStartup(void * hDllHandle=0x0770, 
> unsigned long dwReason=0, void * lpreserved=0x)  Line 510 + 0x11 
> bytes C
>   ntdll.dll!77b79960()
>   [Frames below may be incorrect and/or missing, no symbols loaded for 
> ntdll.dll] 
>   ntdll.dll!77ba1525()
>   ntdll.dll!77b81231()
>   KernelBase.dll!77281da7()   
>   ole32.dll!75bb9562()
>   ole32.dll!75bb9593()
>   ole32.dll!75bb95a7()
>   ole32.dll!75bb98bf()
>   ole32.dll!75bb9805()
>   ole32.dll!75bb9a8c()
>   EXCEL.EXE

Review Request: Keep better track of threads avoiding deadlocks at process rundown

2011-06-14 Thread Steve Huston

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/904/
---

Review request for qpid.


Summary
---

Keeps track of Qpid runnable threads and other threads, ensuring that rundown 
doesn't deadlock.


This addresses bug QPID-3256.
https://issues.apache.org/jira/browse/QPID-3256


Diffs
-

  /trunk/qpid/cpp/src/qpid/sys/windows/Thread.cpp 1132733 

Diff: https://reviews.apache.org/r/904/diff


Testing
---

Qpid regression test suite.


Thanks,

Steve



[jira] [Updated] (QPID-3256) Application which uses Qpid (in my case Excel) hangs on shutdown

2011-06-14 Thread Steve Huston (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Huston updated QPID-3256:
---

 Due Date: 15/Jun/11
Fix Version/s: 0.11
 Assignee: Steve Huston  (was: Cliff Jansen)

Taking over to apply attached patch for 0.12.

> Application which uses Qpid (in my case Excel) hangs on shutdown
> 
>
> Key: QPID-3256
> URL: https://issues.apache.org/jira/browse/QPID-3256
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.8, 0.10
> Environment: OS: Windows.
> Qpid is assembled as DLL. 
>Reporter: Eugene
>Assignee: Steve Huston
> Fix For: 0.11
>
> Attachments: qpid-3256.patch
>
>
> Hi All
> I encountered with strange behavior on shutdown when using qpid 0-8 and 0-10. 
> When I use qpid in standalone console-application everything is ok. But when 
> I use qpid in DLL which is loaded into Excel (as RTD module), Excel hangs on 
> shutdown. 
> I found out that in standalone application on shutdown I have next stack:
>   qpidclientd.dll!qpid::client::`anonymous 
> namespace'::IOThread::~IOThread()  Line 138C++
>   qpidclientd.dll!`qpid::client::`anonymous 
> namespace'::theIO'::`2'::`dynamic atexit destructor for 'io''()  + 0xd bytes  
> C++
>   qpidclientd.dll!_CRT_INIT(void * hDllHandle=0x6008, unsigned long 
> dwReason=0, void * lpreserved=0x0001)  Line 449   C
>   qpidclientd.dll!__DllMainCRTStartup(void * hDllHandle=0x6008, 
> unsigned long dwReason=0, void * lpreserved=0x0001)  Line 560 + 0x11 
> bytesC
>   qpidclientd.dll!_DllMainCRTStartup(void * hDllHandle=0x6008, 
> unsigned long dwReason=0, void * lpreserved=0x0001)  Line 510 + 0x11 
> bytes C
>   ntdll.dll!77b79960()
>   [Frames below may be incorrect and/or missing, no symbols loaded for 
> ntdll.dll] 
>   ntdll.dll!77b9a516()
>   ntdll.dll!77b9a3b8()
>   kernel32.dll!77657363() 
>   msvcr90d.dll!__crtExitProcess(int status=0)  Line 732   C
>   msvcr90d.dll!doexit(int code=0, int quick=0, int retcaller=0)  Line 644 
> + 0x9 bytes C
>   msvcr90d.dll!exit(int code=0)  Line 412 + 0xd bytes C
>   Test.exe!__tmainCRTStartup()  Line 599  C
>   Test.exe!mainCRTStartup()  Line 403 C
>   kernel32.dll!77653677() 
>   ntdll.dll!77b79f02()
>   ntdll.dll!77b79ed5()
> And in this state all threads of application have been already terminated. 
> The only thread is:
> 1 >   21720   Main Thread Main Thread 
> qpid::client::`anonymous namespace'::IOThread::~IOThreadNormal  0
> so code from file ConnectionImpl.cpp works well:
> ~IOThread() {
> std::vector threads;
> {
> ScopedLock l(threadLock);
> if (poller_)
> poller_->shutdown();
> t.swap(threads);
> }
> for (std::vector::iterator i = threads.begin(); i != 
> threads.end(); ++i) {
> i->join();
> }
> }
> BUT in Excel I get stack:
> qpidclientd.dll!qpid::client::`anonymous namespace'::IOThread::~IOThread()  
> Line 130  C++
>   qpidclientd.dll!`qpid::client::`anonymous 
> namespace'::theIO'::`2'::`dynamic atexit destructor for 'io''()  + 0xd bytes  
> C++
>   qpidclientd.dll!_CRT_INIT(void * hDllHandle=0x0770, unsigned long 
> dwReason=0, void * lpreserved=0x)  Line 449   C
>   qpidclientd.dll!__DllMainCRTStartup(void * hDllHandle=0x0770, 
> unsigned long dwReason=0, void * lpreserved=0x)  Line 560 + 0x11 
> bytesC
>   qpidclientd.dll!_DllMainCRTStartup(void * hDllHandle=0x0770, 
> unsigned long dwReason=0, void * lpreserved=0x)  Line 510 + 0x11 
> bytes C
>   ntdll.dll!77b79960()
>   [Frames below may be incorrect and/or missing, no symbols loaded for 
> ntdll.dll] 
>   ntdll.dll!77ba1525()
>   ntdll.dll!77b81231()
>   KernelBase.dll!77281da7()   
>   ole32.dll!75bb9562()
>   ole32.dll!75bb9593()
>   ole32.dll!75bb95a7()
>   ole32.dll!75bb98bf()
>   ole32.dll!75bb9805()
>   ole32.dll!75bb9a8c()
>   EXCEL.EXE!2f3811e9()
>   EXCEL.EXE!2f6933e8()
>   EXCEL.EXE!2f32a5af()
>   EXCEL.EXE!2f34894a()
>   EXCEL.EXE!2f670001()
>   MSO.DLL!65bc6ed5()  
>   MSO.DLL!65c26a34()  
>   MSO.DLL!65c30305()  
>   MSO.DLL!65bc910c()  
>   MSO.DLL!65c4f420()  
>   MSO.DLL!65bbf161()  
>   comctl32.dll!7233463d() 
>   user32.dll!762971be()   
>   user32.dll!76297d31()   
>   user32.dll!76297dfa()   
>   EXCEL.EXE!2f324572()
>   EXCEL.EXE!2f324534()
>   EXCE

[jira] [Commented] (QPID-3200) Ability to acknowledge all messages up to and including a given message for a Session

2011-06-14 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049262#comment-13049262
 ] 

jirapos...@reviews.apache.org commented on QPID-3200:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/882/#review832
---

Ship it!


- Kenneth


On 2011-06-10 16:27:29, Gordon Sim wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/882/
bq.  ---
bq.  
bq.  (Updated 2011-06-10 16:27:29)
bq.  
bq.  
bq.  Review request for qpid.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  This patch adds a new method to the qpid::messaging::Session class in the 
public API that allows all messages up to a certain point to be acknowledged.
bq.  
bq.  
bq.  This addresses bug QPID-3200.
bq.  https://issues.apache.org/jira/browse/QPID-3200
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq./trunk/qpid/cpp/include/qpid/messaging/Session.h 1130102 
bq./trunk/qpid/cpp/src/qpid/client/amqp0_10/AcceptTracker.h 1130102 
bq./trunk/qpid/cpp/src/qpid/client/amqp0_10/AcceptTracker.cpp 1130102 
bq./trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.h 1130102 
bq./trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp 1130102 
bq./trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.h 1130102 
bq./trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.cpp 1133822 
bq./trunk/qpid/cpp/src/tests/MessagingSessionTests.cpp 1130102 
bq.  
bq.  Diff: https://reviews.apache.org/r/882/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  All existing tests pass, new test added to cover the new method.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Gordon
bq.  
bq.



> Ability to acknowledge all messages up to and including a given message for a 
> Session
> -
>
> Key: QPID-3200
> URL: https://issues.apache.org/jira/browse/QPID-3200
> Project: Qpid
>  Issue Type: Improvement
>  Components: C++ Client
>Reporter: Andy Goldstein
>Assignee: Gordon Sim
> Fix For: 0.11
>
>
> Currently the Session class gives us the ability to acknowledge either a 
> single specified message, or all outstanding messages for the Session.  We'd 
> like to be able to acknowledge all messages up to and including a given 
> message in a single method call, to save on round trip times to the broker.
> Our use case.
>  1) create receiver with capacity > 0 (e.g. 100)
>  2) repeat:
>a) receive message X from queue A
>b) perform business logic
>c) send message X to a broker (could be same broker, could be a different 
> broker)
>  3) Every so often, we'd like to acknowledge messages that we're certain have 
> been received by the broker in 2c.  We can't use session.acknowledge() 
> because it's possible some messages that we've received in 2a haven't been 
> completed by the broker in 2c.  We plan on checking the unsettled count in 
> our sender and using that to determine which messages can be safely 
> acknowledged.  It's currently slow to ack each message individually, and we 
> think that being able to invoke session.acknowledgeThrough(messageX) should 
> be faster for us.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Review Request: QPID-3200: cumulative acknowledgement up to a specified point

2011-06-14 Thread Kenneth Giusti

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/882/#review832
---

Ship it!


- Kenneth


On 2011-06-10 16:27:29, Gordon Sim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/882/
> ---
> 
> (Updated 2011-06-10 16:27:29)
> 
> 
> Review request for qpid.
> 
> 
> Summary
> ---
> 
> This patch adds a new method to the qpid::messaging::Session class in the 
> public API that allows all messages up to a certain point to be acknowledged.
> 
> 
> This addresses bug QPID-3200.
> https://issues.apache.org/jira/browse/QPID-3200
> 
> 
> Diffs
> -
> 
>   /trunk/qpid/cpp/include/qpid/messaging/Session.h 1130102 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/AcceptTracker.h 1130102 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/AcceptTracker.cpp 1130102 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.h 1130102 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp 1130102 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.h 1130102 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.cpp 1133822 
>   /trunk/qpid/cpp/src/tests/MessagingSessionTests.cpp 1130102 
> 
> Diff: https://reviews.apache.org/r/882/diff
> 
> 
> Testing
> ---
> 
> All existing tests pass, new test added to cover the new method.
> 
> 
> Thanks,
> 
> Gordon
> 
>



Re: 0.12 release update - upcoming dates

2011-06-14 Thread Rajith Attapattu
Aidan/Justin,

That was precisely what I was hoping for :)
Any ways I have a bunch of patches and it will take till friday to get
them in completely.
I will try to post them as soon as possible in review board say end of
wednesday.
Based on that lets make a call about what items can be approved or not.

Rajith

On Tue, Jun 14, 2011 at 10:47 AM, Justin Ross  wrote:
>
> I agree, and that's why I prefer to set the deadlines to the middle of the 
> week.  That way if we slip a little, there's still a chance we'll get it that 
> week and not the next.
>
> Rajith (or anyone else facing a similar problem), are the changes you'd like 
> to see in 0.12 looking like they will land by end of day Wednesday?  Just so 
> I can determine when we can accept it, what's the new feature and what is its 
> current status?
>
> Justin
>
> - Original Message -
> From: "Aidan Skinner" 
> To: dev@qpid.apache.org
> Sent: Friday, June 3, 2011 1:43:45 AM
> Subject: Re: 0.12 release update - upcoming dates
>
> I'm really only passing through qpid-dev, so feel free to ignore me,
> but IME Friday deadlines turn into Monday deadlines turn into
> Wednesday the week after deadlines all too easily.
>
> - Aidan
>
> On Thu, Jun 2, 2011 at 2:21 PM, Rajith Attapattu  wrote:
> > Justin,
> >
> > Wondering if you could move the beta date to 17th of June (friday) instead
> > of the 15th?
> >
> > Regards,
> >
> > Rajith
> >
> > On Tue, May 31, 2011 at 5:19 PM, Justin Ross  wrote:
> >
> >> Hi, folks.  Here are some of the upcoming dates for the 0.12 release
> >> of Qpid.
> >>
> >>  - 3 March - 0.12 trunk opened
> >>  - 15 June - 0.12 alpha (in a little over 2 weeks)
> >>  - 28 June - 0.12 beta
> >>  - 27 July - Target date for the final 0.12 release candidate
> >>
> >> The alpha date is the deadline for landing major features.  Said
> >> features must be functionally complete, with all distribution-related
> >> integration complete.
> >>
> >> After the alpha, we may still be able to accept a new feature, but it
> >> must be something (a) quite small or (b) isolated from the other code.
> >> In addition, it must not change the existing distribution artifacts in
> >> any significant way.
> >>
> >> With the beta, we will create the 0.12 release branch, and 0.14
> >> development can then begin on trunk.
> >>
> >> The release page[1] has links to the jiras for 0.12 and an overview of
> >> the schedule.
> >>
> >> Thanks!
> >> Justin
> >>
> >> ---
> >> [1] https://cwiki.apache.org/confluence/display/qpid/0.12+Release
> >>
> >> -
> >> Apache Qpid - AMQP Messaging Implementation
> >> Project:      http://qpid.apache.org
> >> Use/Interact: mailto:dev-subscr...@qpid.apache.org
> >>
> >>
> >
>
>
>
> --
> Apache Qpid - AMQP, JMS, other messaging love http://qpid.apache.org
> "A witty saying proves nothing" - Voltaire
>
> -
> Apache Qpid - AMQP Messaging Implementation
> Project:      http://qpid.apache.org
> Use/Interact: mailto:dev-subscr...@qpid.apache.org
>
>
> -
> Apache Qpid - AMQP Messaging Implementation
> Project:      http://qpid.apache.org
> Use/Interact: mailto:dev-subscr...@qpid.apache.org
>

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-3145) messaging::Message API needs to be documented, little to no Doxygen comments

2011-06-14 Thread Gordon Sim (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved QPID-3145.
--

   Resolution: Fixed
Fix Version/s: 0.11

Marking this fixed for now, can raise new more specific improvement requests as 
needed.

> messaging::Message API needs to be documented, little to no Doxygen comments
> 
>
> Key: QPID-3145
> URL: https://issues.apache.org/jira/browse/QPID-3145
> Project: Qpid
>  Issue Type: Improvement
>  Components: C++ Client
>Affects Versions: 0.8
> Environment: C++ API
>Reporter: David Hickerson
>Assignee: Gordon Sim
>  Labels: documentation
> Fix For: 0.11
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The documentation of everything in this class is represented by about 100 
> words, mostly representing the obvious that can be inferred by the method 
> name. 
> Questions:
> 1. Can you tell by calling getContentType whether to call getContent or 
> getContentPtr or getProperties, or does that
>require the sender to set the content? 
> 2. If using the xml mentioned in the AMQP Messaging (Part 2), does 
> Variant.getString() return that xml?
> 3. By setting TTL, Durable, Redelivered, what behavior does the system 
> exhibit?
> 4. Does the broker modify any of the settings or are they only for use by the 
> broker? MessageId?
> 5. Are there any conventions that should be followed for string data in this 
> class that are used in other AMQP systems or language versions of Apid?
> 6. On getting the char* to the data on getContentPtr, what is the life of 
> that data, are you expected to copy it or are you passed ownership 
> responsibility?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-3145) messaging::Message API needs to be documented, little to no Doxygen comments

2011-06-14 Thread Gordon Sim (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049208#comment-13049208
 ] 

Gordon Sim commented on QPID-3145:
--

Additional comments added in http://svn.apache.org/viewvc?rev=1135614&view=rev

> messaging::Message API needs to be documented, little to no Doxygen comments
> 
>
> Key: QPID-3145
> URL: https://issues.apache.org/jira/browse/QPID-3145
> Project: Qpid
>  Issue Type: Improvement
>  Components: C++ Client
>Affects Versions: 0.8
> Environment: C++ API
>Reporter: David Hickerson
>Assignee: Gordon Sim
>  Labels: documentation
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The documentation of everything in this class is represented by about 100 
> words, mostly representing the obvious that can be inferred by the method 
> name. 
> Questions:
> 1. Can you tell by calling getContentType whether to call getContent or 
> getContentPtr or getProperties, or does that
>require the sender to set the content? 
> 2. If using the xml mentioned in the AMQP Messaging (Part 2), does 
> Variant.getString() return that xml?
> 3. By setting TTL, Durable, Redelivered, what behavior does the system 
> exhibit?
> 4. Does the broker modify any of the settings or are they only for use by the 
> broker? MessageId?
> 5. Are there any conventions that should be followed for string data in this 
> class that are used in other AMQP systems or language versions of Apid?
> 6. On getting the char* to the data on getContentPtr, what is the life of 
> that data, are you expected to copy it or are you passed ownership 
> responsibility?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: 0.12 release update - upcoming dates

2011-06-14 Thread Justin Ross
I agree, and that's why I prefer to set the deadlines to the middle of the 
week.  That way if we slip a little, there's still a chance we'll get it that 
week and not the next.

Rajith (or anyone else facing a similar problem), are the changes you'd like to 
see in 0.12 looking like they will land by end of day Wednesday?  Just so I can 
determine when we can accept it, what's the new feature and what is its current 
status?

Justin

- Original Message -
From: "Aidan Skinner" 
To: dev@qpid.apache.org
Sent: Friday, June 3, 2011 1:43:45 AM
Subject: Re: 0.12 release update - upcoming dates

I'm really only passing through qpid-dev, so feel free to ignore me,
but IME Friday deadlines turn into Monday deadlines turn into
Wednesday the week after deadlines all too easily.

- Aidan

On Thu, Jun 2, 2011 at 2:21 PM, Rajith Attapattu  wrote:
> Justin,
>
> Wondering if you could move the beta date to 17th of June (friday) instead
> of the 15th?
>
> Regards,
>
> Rajith
>
> On Tue, May 31, 2011 at 5:19 PM, Justin Ross  wrote:
>
>> Hi, folks.  Here are some of the upcoming dates for the 0.12 release
>> of Qpid.
>>
>>  - 3 March - 0.12 trunk opened
>>  - 15 June - 0.12 alpha (in a little over 2 weeks)
>>  - 28 June - 0.12 beta
>>  - 27 July - Target date for the final 0.12 release candidate
>>
>> The alpha date is the deadline for landing major features.  Said
>> features must be functionally complete, with all distribution-related
>> integration complete.
>>
>> After the alpha, we may still be able to accept a new feature, but it
>> must be something (a) quite small or (b) isolated from the other code.
>> In addition, it must not change the existing distribution artifacts in
>> any significant way.
>>
>> With the beta, we will create the 0.12 release branch, and 0.14
>> development can then begin on trunk.
>>
>> The release page[1] has links to the jiras for 0.12 and an overview of
>> the schedule.
>>
>> Thanks!
>> Justin
>>
>> ---
>> [1] https://cwiki.apache.org/confluence/display/qpid/0.12+Release
>>
>> -
>> Apache Qpid - AMQP Messaging Implementation
>> Project:      http://qpid.apache.org
>> Use/Interact: mailto:dev-subscr...@qpid.apache.org
>>
>>
>



-- 
Apache Qpid - AMQP, JMS, other messaging love http://qpid.apache.org
"A witty saying proves nothing" - Voltaire

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-3200) Ability to acknowledge all messages up to and including a given message for a Session

2011-06-14 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049152#comment-13049152
 ] 

jirapos...@reviews.apache.org commented on QPID-3200:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/882/#review831
---

Ship it!


- Alan


On 2011-06-10 16:27:29, Gordon Sim wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/882/
bq.  ---
bq.  
bq.  (Updated 2011-06-10 16:27:29)
bq.  
bq.  
bq.  Review request for qpid.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  This patch adds a new method to the qpid::messaging::Session class in the 
public API that allows all messages up to a certain point to be acknowledged.
bq.  
bq.  
bq.  This addresses bug QPID-3200.
bq.  https://issues.apache.org/jira/browse/QPID-3200
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq./trunk/qpid/cpp/include/qpid/messaging/Session.h 1130102 
bq./trunk/qpid/cpp/src/qpid/client/amqp0_10/AcceptTracker.h 1130102 
bq./trunk/qpid/cpp/src/qpid/client/amqp0_10/AcceptTracker.cpp 1130102 
bq./trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.h 1130102 
bq./trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp 1130102 
bq./trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.h 1130102 
bq./trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.cpp 1133822 
bq./trunk/qpid/cpp/src/tests/MessagingSessionTests.cpp 1130102 
bq.  
bq.  Diff: https://reviews.apache.org/r/882/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  All existing tests pass, new test added to cover the new method.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Gordon
bq.  
bq.



> Ability to acknowledge all messages up to and including a given message for a 
> Session
> -
>
> Key: QPID-3200
> URL: https://issues.apache.org/jira/browse/QPID-3200
> Project: Qpid
>  Issue Type: Improvement
>  Components: C++ Client
>Reporter: Andy Goldstein
>Assignee: Gordon Sim
> Fix For: 0.11
>
>
> Currently the Session class gives us the ability to acknowledge either a 
> single specified message, or all outstanding messages for the Session.  We'd 
> like to be able to acknowledge all messages up to and including a given 
> message in a single method call, to save on round trip times to the broker.
> Our use case.
>  1) create receiver with capacity > 0 (e.g. 100)
>  2) repeat:
>a) receive message X from queue A
>b) perform business logic
>c) send message X to a broker (could be same broker, could be a different 
> broker)
>  3) Every so often, we'd like to acknowledge messages that we're certain have 
> been received by the broker in 2c.  We can't use session.acknowledge() 
> because it's possible some messages that we've received in 2a haven't been 
> completed by the broker in 2c.  We plan on checking the unsettled count in 
> our sender and using that to determine which messages can be safely 
> acknowledged.  It's currently slow to ack each message individually, and we 
> think that being able to invoke session.acknowledgeThrough(messageX) should 
> be faster for us.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Review Request: QPID-3200: cumulative acknowledgement up to a specified point

2011-06-14 Thread Alan Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/882/#review831
---

Ship it!


- Alan


On 2011-06-10 16:27:29, Gordon Sim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/882/
> ---
> 
> (Updated 2011-06-10 16:27:29)
> 
> 
> Review request for qpid.
> 
> 
> Summary
> ---
> 
> This patch adds a new method to the qpid::messaging::Session class in the 
> public API that allows all messages up to a certain point to be acknowledged.
> 
> 
> This addresses bug QPID-3200.
> https://issues.apache.org/jira/browse/QPID-3200
> 
> 
> Diffs
> -
> 
>   /trunk/qpid/cpp/include/qpid/messaging/Session.h 1130102 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/AcceptTracker.h 1130102 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/AcceptTracker.cpp 1130102 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.h 1130102 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp 1130102 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.h 1130102 
>   /trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.cpp 1133822 
>   /trunk/qpid/cpp/src/tests/MessagingSessionTests.cpp 1130102 
> 
> Diff: https://reviews.apache.org/r/882/diff
> 
> 
> Testing
> ---
> 
> All existing tests pass, new test added to cover the new method.
> 
> 
> Thanks,
> 
> Gordon
> 
>



[jira] [Updated] (QPID-3200) Ability to acknowledge all messages up to and including a given message for a Session

2011-06-14 Thread Gordon Sim (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim updated QPID-3200:
-

Fix Version/s: 0.11

> Ability to acknowledge all messages up to and including a given message for a 
> Session
> -
>
> Key: QPID-3200
> URL: https://issues.apache.org/jira/browse/QPID-3200
> Project: Qpid
>  Issue Type: Improvement
>  Components: C++ Client
>Reporter: Andy Goldstein
>Assignee: Gordon Sim
> Fix For: 0.11
>
>
> Currently the Session class gives us the ability to acknowledge either a 
> single specified message, or all outstanding messages for the Session.  We'd 
> like to be able to acknowledge all messages up to and including a given 
> message in a single method call, to save on round trip times to the broker.
> Our use case.
>  1) create receiver with capacity > 0 (e.g. 100)
>  2) repeat:
>a) receive message X from queue A
>b) perform business logic
>c) send message X to a broker (could be same broker, could be a different 
> broker)
>  3) Every so often, we'd like to acknowledge messages that we're certain have 
> been received by the broker in 2c.  We can't use session.acknowledge() 
> because it's possible some messages that we've received in 2a haven't been 
> completed by the broker in 2c.  We plan on checking the unsettled count in 
> our sender and using that to determine which messages can be safely 
> acknowledged.  It's currently slow to ack each message individually, and we 
> think that being able to invoke session.acknowledgeThrough(messageX) should 
> be faster for us.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org