[jira] [Commented] (QPID-3313) Update example scripts for perl binding.

2011-07-14 Thread Kumar Sundaram (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13065097#comment-13065097
 ] 

Kumar Sundaram commented on QPID-3313:
--

I would like to work on this issue

 Update example scripts for perl binding.
 

 Key: QPID-3313
 URL: https://issues.apache.org/jira/browse/QPID-3313
 Project: Qpid
  Issue Type: Improvement
  Components: Qpid Examples
Reporter: Hao Chang Yu
Priority: Minor
 Attachments: cqpid_perl_examples.diff


 Hi
 I had updated the perl qpid example scripts. The overall changes are:
 - use getOptions in all scripts.
 - Parse connectionOptions variable in hash instead of string.
 - fix some small typo mistakes I made.
 - fix the setProperty function in spout.pl
 - perltidy
 Please see the attached diff file.
 Thanks.
 Regards
 Hao

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org




[jira] [Updated] (QPID-3313) Update example scripts for perl binding.

2011-07-14 Thread Kumar Sundaram (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kumar Sundaram updated QPID-3313:
-

Comment: was deleted

(was: I would like to work on this issue)

 Update example scripts for perl binding.
 

 Key: QPID-3313
 URL: https://issues.apache.org/jira/browse/QPID-3313
 Project: Qpid
  Issue Type: Improvement
  Components: Qpid Examples
Reporter: Hao Chang Yu
Priority: Minor
 Attachments: cqpid_perl_examples.diff


 Hi
 I had updated the perl qpid example scripts. The overall changes are:
 - use getOptions in all scripts.
 - Parse connectionOptions variable in hash instead of string.
 - fix some small typo mistakes I made.
 - fix the setProperty function in spout.pl
 - perltidy
 Please see the attached diff file.
 Thanks.
 Regards
 Hao

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-3313) Update example scripts for perl binding.

2011-07-14 Thread Kumar Sundaram (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13065103#comment-13065103
 ] 

Kumar Sundaram commented on QPID-3313:
--

I would like to work on this issue saw the attached file, what should i do next?

 Update example scripts for perl binding.
 

 Key: QPID-3313
 URL: https://issues.apache.org/jira/browse/QPID-3313
 Project: Qpid
  Issue Type: Improvement
  Components: Qpid Examples
Reporter: Hao Chang Yu
Priority: Minor
 Attachments: cqpid_perl_examples.diff


 Hi
 I had updated the perl qpid example scripts. The overall changes are:
 - use getOptions in all scripts.
 - Parse connectionOptions variable in hash instead of string.
 - fix some small typo mistakes I made.
 - fix the setProperty function in spout.pl
 - perltidy
 Please see the attached diff file.
 Thanks.
 Regards
 Hao

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3345) Make new transport implementations pluggable

2011-07-14 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell reassigned QPID-3345:


Assignee: Robbie Gemmell  (was: Rajith Attapattu)

 Make new transport implementations pluggable
 

 Key: QPID-3345
 URL: https://issues.apache.org/jira/browse/QPID-3345
 Project: Qpid
  Issue Type: Improvement
  Components: Java Client, Java Common
Reporter: Keith Wall
Assignee: Robbie Gemmell
 Fix For: 0.13

 Attachments: 
 0001-QPID-3345-restore-add-ability-to-use-sys-props-to-se.patch


 Allow new transport implementations (those produced by QPID-3342) to be 
 loaded by reflection, thus working towards the removal of dependencies on 
 Mina by the client.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-3345) Make new transport implementations pluggable

2011-07-14 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-3345.
--

Resolution: Fixed

Patch applied, closing out.

 Make new transport implementations pluggable
 

 Key: QPID-3345
 URL: https://issues.apache.org/jira/browse/QPID-3345
 Project: Qpid
  Issue Type: Improvement
  Components: Java Client, Java Common
Reporter: Keith Wall
Assignee: Robbie Gemmell
 Fix For: 0.13

 Attachments: 
 0001-QPID-3345-restore-add-ability-to-use-sys-props-to-se.patch


 Allow new transport implementations (those produced by QPID-3342) to be 
 loaded by reflection, thus working towards the removal of dependencies on 
 Mina by the client.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Unable to connect multiple consumers to a queue on fan out exchange

2011-07-14 Thread Gordon Sim

On 07/14/2011 01:30 AM, Uday77 wrote:

I have a fanout exchange and I am binding different queues to this exchange.
When I send data to this exchange each queue that is bound to this exchange
is getting data as expected. But when I try to connect multiple consumers to
one of these fanned out queues, I get the following message:
Queue message_queue1 has an exclusive consumer. No more consumers allowed.


[snip]


I tried to connect two consumers to message_queue1 and I get the following
error:
INFO org.apache.qpid.client.AMQConnection - Closing AMQConnection due to
:org.apache.qpid.AMQException: ch=0 id=0
ExecutionException(errorCode=RESOURCE_LOCKED, commandId=6, classCode=4,
commandCode=7, fieldIndex=0, description=resource-locked: Queue
message_queue1 has an exclusive consumer. No more consumers allowed.
(qpid/broker/Queue.cpp:385), errorInfo={}) [error code 405: Already exists]

I checked the configuration on AMQP Server and it says that message_queue1
is a non-exclusive queue.


There are two levels of 'exclusivity' in AMQP, one is an exclusive queue 
the other is an exclusive consumer. As you point out this is not the 
former case, but the latter.


If you try qpid-stat -u you'll see the subscriptions marked as exclusive.

I'm not familiar enough with the format and handling of those JMS 
'binding urls' to comment on whether this is expected and whether there 
is another way to accomplish what you want. Anyone else able to help here?


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Deleting ruby and dotnet top level directories (was Re: 0.12 release update - RC1 this week)

2011-07-14 Thread Gordon Sim

On 07/13/2011 07:15 PM, Chuck Rolke wrote:

There already IS a top level README.txt. An edit on that file will go nicely 
with the deletion of component directories. Remember to edit the LICENSE and 
NOTICE files, too.


Done.

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Reopened] (QPID-2815) Refactor broker startup to enable a uniform method of starting the broker

2011-07-14 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell reopened QPID-2815:
--


Reopening to add a unit test for the vastly  simplified Main class to ensure 
the command line argument parsing is functioning as expected.

 Refactor broker startup to enable a uniform method of starting the broker
 -

 Key: QPID-2815
 URL: https://issues.apache.org/jira/browse/QPID-2815
 Project: Qpid
  Issue Type: Improvement
Affects Versions: 0.7
Reporter: Andrew Kennedy
Assignee: Robbie Gemmell
 Fix For: 0.13

 Attachments: 
 0006-QPID-2815-refactor-broker-startup-to-present-a-clean.patch


 Update the way the broker is started to decouple it from any particular 
 protocol version or transport.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-2815) Refactor broker startup to enable a uniform method of starting the broker

2011-07-14 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell reassigned QPID-2815:


Assignee: Keith Wall  (was: Robbie Gemmell)

Hi Keith, could you review this latest change and close out the JIRA if you are 
happy?

I added a unit test for Main and updated the handling of the logWatch argument 
slightly.

 Refactor broker startup to enable a uniform method of starting the broker
 -

 Key: QPID-2815
 URL: https://issues.apache.org/jira/browse/QPID-2815
 Project: Qpid
  Issue Type: Improvement
Affects Versions: 0.7
Reporter: Andrew Kennedy
Assignee: Keith Wall
 Fix For: 0.13

 Attachments: 
 0006-QPID-2815-refactor-broker-startup-to-present-a-clean.patch


 Update the way the broker is started to decouple it from any particular 
 protocol version or transport.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-2815) Refactor broker startup to enable a uniform method of starting the broker

2011-07-14 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall resolved QPID-2815.
--

Resolution: Fixed

I've reviewed the additions and I have no comments.
cheers Keith.

 Refactor broker startup to enable a uniform method of starting the broker
 -

 Key: QPID-2815
 URL: https://issues.apache.org/jira/browse/QPID-2815
 Project: Qpid
  Issue Type: Improvement
Affects Versions: 0.7
Reporter: Andrew Kennedy
Assignee: Keith Wall
 Fix For: 0.13

 Attachments: 
 0006-QPID-2815-refactor-broker-startup-to-present-a-clean.patch


 Update the way the broker is started to decouple it from any particular 
 protocol version or transport.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-2899) SelectorTest#testRuntimeSelectorError fails when using 0-10

2011-07-14 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-2899:
-

Fix Version/s: 0.13
  Summary: SelectorTest#testRuntimeSelectorError fails when using 0-10  
(was: SelectorTest#testRuntimeSelectorError fails when using 0-10 because the 
broker fails to close the connection )

 SelectorTest#testRuntimeSelectorError fails when using 0-10
 ---

 Key: QPID-2899
 URL: https://issues.apache.org/jira/browse/QPID-2899
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Affects Versions: 0.6
Reporter: Robbie Gemmell
 Fix For: 0.13


 org.apache.qpid.test.client.message.SelectorTest#testRuntimeSelectorError 
 fails when using 0-10 because the broker fails to close the connection when 
 the deliberate error occurs, as it does when using 0-8/0-9
 QpidBrokerTestCase behaviour is to close connections during teardown that 
 were created using the getConnection() utility method, and the teardown close 
 is failing because it tries to sync outstanding 0-10 commands with the broker 
 and times out. This test should already have caused the connection to be 
 closed due to a (deliberate) error when evaluating the selector.
 However, in addition to the original exception it can be seen that there are 
 IllegalArgumentException occurrences immediately afterwards because the 
 InputHandler is continuing to process recieved data on the connection (whcih 
 should have been closed) and then ends up trying to add the contents of a 
 ByteBuffer to itself in the received() method (possibly because the exception 
 being throwing prevented an instance variable being set to null on completion 
 of a process), prompting the throwing of the IllegalArgumentException.
 Commenting out the connection close during teardown reveals the test would 
 otherwise have failed because the connection was not closed due to the 
 original error as it should have been. It appears that the 0-8 broker code 
 closes the mina protocol session in this situation when the first exception 
 is thrown, but the 0-10 broker code proceeds using a crippled connection and 
 then gets into further difficulty.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-2498) Upgrade Mina to 1.1.7

2011-07-14 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall reassigned QPID-2498:


Assignee: Keith Wall  (was: Robbie Gemmell)

 Upgrade Mina to 1.1.7
 -

 Key: QPID-2498
 URL: https://issues.apache.org/jira/browse/QPID-2498
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker, Java Client
Affects Versions: 0.6
Reporter: Emmanuel Bourg
Assignee: Keith Wall
 Fix For: 0.13

 Attachments: mina-update.patch, mina-upgrade.patch


 Upgrading Mina to 1.1.7 would allow the removal of 
 backport-util-concurrent.jar from the dependencies.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-2498) Upgrade Mina to 1.1.7

2011-07-14 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-2498:
-

Attachment: 0001-QPID-2498-Upgrade-Mina-to-1.1.7.patch

Hi Robbie

Emmanuel's patch had gone stale over the last 15 months (removal of inVM, pom 
dep changes etc). I've created a new patch which achieves the same result 
against the current codebase.

cheers Keith


 Upgrade Mina to 1.1.7
 -

 Key: QPID-2498
 URL: https://issues.apache.org/jira/browse/QPID-2498
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker, Java Client
Affects Versions: 0.6
Reporter: Emmanuel Bourg
Assignee: Keith Wall
 Fix For: 0.13

 Attachments: 0001-QPID-2498-Upgrade-Mina-to-1.1.7.patch, 
 mina-update.patch, mina-upgrade.patch


 Upgrading Mina to 1.1.7 would allow the removal of 
 backport-util-concurrent.jar from the dependencies.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3356) Dynamic Federation doesn't work as expected for headers exchange

2011-07-14 Thread Gordon Sim (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim updated QPID-3356:
-

Description: 
start two brokers, link amq.match using a dynamic route in one direction, start 
two subscribers on the destination broker (e.g two drain instances from 
amq.match; {link:{x-bindings:[{arguments:{source:B, x-match:any}}]}} and 
amq.match; {link:{x-bindings:[{arguments:{format:standard, x-match:any}}]}} 
respectively), you then see the following error appear on the source broker 
after a second or so:

error Detected two management objects with the same identifier: 
0-614-1--18(org.apache.qpid.broker:binding:org.apache.qpid.broker:exchange:amq.match,org.apache.qpid.broker:queue:bridge_queue_1_a51ddbb5-bac4-4e6a-ba45-3a2e1b096858,)

Further, duplicate messages can then be received at the subscribers. E.g. send 
a message to the source broker that matches each subscriber and observe that 
the message is received twice by each of them (e.g. spout --content my-message 
-P format=standard -P source=B amq.match)

This appears to be due to the same binding key being used for two different 
subscriptions. E.g. if you changes the addresses for the drains above to: 
amq.match; {link:{x-bindings:[{key: key1, arguments:{source:B, x-match:any}}]}} 
and amq.match; {link:{x-bindings:[{key: key2, arguments:{format:standard, 
x-match:any}}]}} respectively, i.e. add unique keys to each, then you avoid the 
error and the message duplication.

  was:
start two brokers, link amq.match using a dynamic route in one direction, start 
two subscribers on the destination broker (e.g two drain instances from 
amq.match; {link:{x-bindings:[{arguments:{source:B, x-match:any}}]}} and 
amq.match; {link:{x-bindings:[{arguments:{format:standard, x-match:any}}]}} 
respectively), you then see the following error appear on the source broker 
after a second or so:

error Detected two management objects with the same identifier: 
0-614-1--18(org.apache.qpid.broker:binding:org.apache.qpid.broker:exchange:amq.match,org.apache.qpid.broker:queue:bridge_queue_1_a51ddbb5-bac4-4e6a-ba45-3a2e1b096858,)

There also seems to be duplicate queues in place (though the management tools 
don't show them, I think because of the error above), such that you get 
duplicated messages. E.g. send a message to the source broker that matches each 
subscriber and observe that the message is received twice by each of them (e.g. 
spout --content my-message -P format=standard -P source=B amq.match)

This appears to be due to the same binding key being used for two different 
subscriptions. E.g. if you changes the addresses for the drains above to: 
amq.match; {link:{x-bindings:[{key: key1, arguments:{source:B, x-match:any}}]}} 
and amq.match; {link:{x-bindings:[{key: key2, arguments:{format:standard, 
x-match:any}}]}} respectively, i.e. add unique keys to each, then you avoid the 
error and the message duplication.


 Dynamic Federation doesn't work as expected for headers exchange
 

 Key: QPID-3356
 URL: https://issues.apache.org/jira/browse/QPID-3356
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker
Affects Versions: 0.13
Reporter: Gordon Sim

 start two brokers, link amq.match using a dynamic route in one direction, 
 start two subscribers on the destination broker (e.g two drain instances from 
 amq.match; {link:{x-bindings:[{arguments:{source:B, x-match:any}}]}} and 
 amq.match; {link:{x-bindings:[{arguments:{format:standard, x-match:any}}]}} 
 respectively), you then see the following error appear on the source broker 
 after a second or so:
 error Detected two management objects with the same identifier: 
 0-614-1--18(org.apache.qpid.broker:binding:org.apache.qpid.broker:exchange:amq.match,org.apache.qpid.broker:queue:bridge_queue_1_a51ddbb5-bac4-4e6a-ba45-3a2e1b096858,)
 Further, duplicate messages can then be received at the subscribers. E.g. 
 send a message to the source broker that matches each subscriber and observe 
 that the message is received twice by each of them (e.g. spout --content 
 my-message -P format=standard -P source=B amq.match)
 This appears to be due to the same binding key being used for two different 
 subscriptions. E.g. if you changes the addresses for the drains above to: 
 amq.match; {link:{x-bindings:[{key: key1, arguments:{source:B, 
 x-match:any}}]}} and amq.match; {link:{x-bindings:[{key: key2, 
 arguments:{format:standard, x-match:any}}]}} respectively, i.e. add unique 
 keys to each, then you avoid the error and the message duplication.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging 

[jira] [Created] (QPID-3357) Broker should purge more aggressively before invoking queue limit policy

2011-07-14 Thread Andy Goldstein (JIRA)
Broker should purge more aggressively before invoking queue limit policy


 Key: QPID-3357
 URL: https://issues.apache.org/jira/browse/QPID-3357
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker
Reporter: Andy Goldstein


When enqueuing a message, the broker checks the message/byte count in the queue 
and ensures the new message will not violate the queue's limits and limit 
policy (reject, ring, etc).  It does not take into account messages still in 
the queue that have expired, which could result in a message being dropped or 
the oldest message being removed unnecessarily.  For example, create a queue 
with a max count of 2 messages.  Send 1 message with no ttl.  Send a 2nd 
message with a small ttl e.g. 1 second.  Wait longer then the ttl so the 2nd 
message expires.  Try to send a 3rd message to the queue.  If the queue policy 
is reject, you will get an exception that the queue is full.  If the queue 
policy is ring, it will discard the 1st message (no ttl so unexpired) to make 
room for the new message.

One possible solution would be to try to purge expired messages more 
aggressively, e.g. when an enqueue would exceed the limit, try to purge any 
expired messages, and then re-check the limit.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-3356) Dynamic Federation doesn't work as expected for headers exchange

2011-07-14 Thread Gordon Sim (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13065213#comment-13065213
 ] 

Gordon Sim commented on QPID-3356:
--

The AMQP spec requires the exchange+queue+bindingkey triple to be unique, 
however the headers exchange implementation does not enforce this. That is the 
cause of the error message about duplicate management objects with the same 
identifier - the binding is identified by that triple which should be unique. 
That is also the cause of the duplicated message. Therefore there is a bug in 
the basic headers exchange implementation itself where it needs to enforce this 
uniqueness. (How it should do that is an interesting question - should it 
reject or ignore attempts to bind with different args but the same 
exchange+queue+biningkey?)

However there is also a bug in the handling of dynamic federation. For the 
headers exchange the propagated bindings can't use the original binding key or 
cases like above would either fail or one part of the subscription would be 
lost.

 Dynamic Federation doesn't work as expected for headers exchange
 

 Key: QPID-3356
 URL: https://issues.apache.org/jira/browse/QPID-3356
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker
Affects Versions: 0.13
Reporter: Gordon Sim

 start two brokers, link amq.match using a dynamic route in one direction, 
 start two subscribers on the destination broker (e.g two drain instances from 
 amq.match; {link:{x-bindings:[{arguments:{source:B, x-match:any}}]}} and 
 amq.match; {link:{x-bindings:[{arguments:{format:standard, x-match:any}}]}} 
 respectively), you then see the following error appear on the source broker 
 after a second or so:
 error Detected two management objects with the same identifier: 
 0-614-1--18(org.apache.qpid.broker:binding:org.apache.qpid.broker:exchange:amq.match,org.apache.qpid.broker:queue:bridge_queue_1_a51ddbb5-bac4-4e6a-ba45-3a2e1b096858,)
 Further, duplicate messages can then be received at the subscribers. E.g. 
 send a message to the source broker that matches each subscriber and observe 
 that the message is received twice by each of them (e.g. spout --content 
 my-message -P format=standard -P source=B amq.match)
 This appears to be due to the same binding key being used for two different 
 subscriptions. E.g. if you changes the addresses for the drains above to: 
 amq.match; {link:{x-bindings:[{key: key1, arguments:{source:B, 
 x-match:any}}]}} and amq.match; {link:{x-bindings:[{key: key2, 
 arguments:{format:standard, x-match:any}}]}} respectively, i.e. add unique 
 keys to each, then you avoid the error and the message duplication.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-2784) C++ Example with new Addressing and API

2011-07-14 Thread Kumar Sundaram (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13065259#comment-13065259
 ] 

Kumar Sundaram commented on QPID-2784:
--

I would like to work on this 

 C++ Example with new Addressing and API
 ---

 Key: QPID-2784
 URL: https://issues.apache.org/jira/browse/QPID-2784
 Project: Qpid
  Issue Type: Improvement
  Components: Qpid Examples
Affects Versions: 0.7
Reporter: William Henry
 Fix For: 0.11

 Attachments: feeddemo.tar

   Original Estimate: 2h
  Remaining Estimate: 2h

 I've updated the trade demo (tradedemo) example for the new addressing and 
 renamed it feeddemo (as it is really about ticker and market data feeds and 
 not trades).
 I'd like to know if this sort of demo is still useful.  I think it is, but we 
 also have the reservation system demo. What's nice about this example is that 
 is used TTL and LVQ.
 See the attached files. Note that the OptionParser.h/.cpp is the one already 
 used in drain/spout etc. so it ought to be made common. 
 It can be tested tested by:
 1. running setup_broker.sh which creates the exchanges.
 2. Run a feed_listener (you can run it for ticker info or market data using 
 -t or -m or with a custom exchange or all three:
 a. ./feed_listener -t 1 -m 0  (actually default is this so you can just run 
 ./feed_listener)
 b. ./feed_listener -t 0 -m 1
 c. ./feed_listener -t 0 -m 0 TICKER/NYSE.RHT
 d. ./feed_listener -m 1 TICKER/NYSE.RHT(TICKER/NYSE.RHT is just an 
 example)
 3. Run feed_publisher e.g.:   ./feed_publisher -c 1000
 William

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: 0.12 release update - release branch created, beta available

2011-07-14 Thread Rajith Attapattu
Justin,

Could we apply the fix for QPID-3302 into the release branch ?
It's a very low impact change and it allows folks to use JMS to do QMF
operations via Map messages.

Regards,

Rajith

On Tue, Jul 12, 2011 at 1:31 PM, Chuck Rolke cro...@redhat.com wrote:
 +1 Ship it.

 -Chuck

 - Original Message -
 From: Cliff Jansen cliffjan...@gmail.com
 To: dev@qpid.apache.org
 Sent: Tuesday, July 12, 2011 1:21:57 PM
 Subject: Re: 0.12 release update - release branch created, beta available
 I have tested the patch for QPID-3338 against qpid-0.12-beta on Linux
 and it appears to do the right thing for mingw and cmake.

 I would like to request approval for this patch.

 cliff

 -
 Apache Qpid - AMQP Messaging Implementation
 Project: http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org

 -
 Apache Qpid - AMQP Messaging Implementation
 Project:      http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3283) Make AuthenticationManager pluggable

2011-07-14 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-3283:
-

Attachment: 0001-QPID-3283-Make-Authentication-Manager-pluggable.patch

Hi Robbie

Please find attached proposed patch for this improvement.

cheers Keith

 Make AuthenticationManager pluggable
 

 Key: QPID-3283
 URL: https://issues.apache.org/jira/browse/QPID-3283
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Reporter: Keith Wall
Assignee: Keith Wall
 Fix For: 0.13

 Attachments: 
 0001-QPID-3283-Make-Authentication-Manager-pluggable.patch


 This improvement forms part of the proposal I made to the Qpid Developer List 
 on 2011-05-16 in the posting entitled Java Broker: Pluggable Authentication 
 Managers.
 The existing AuthenticationManager and configuration classes will be 
 refactored to allow a user to choose an implementation of 
 AuthenticationManager through new elements in the config.xml.
 Existing use-cases (that is authentication against the etc/passwd file) will 
 be maintained by plugging-in the PrincipalDatabaseAuthenticationManager 
 implementation.   Future implementations of AuthenticationManager could then 
 allow authentication to be delegated to an external system such as an LDAP 
 Directory.
 This change *will* alter the format of the config.xml file.  Existing users 
 of =0-12 will need to edit their config.xml when upgrading.  Documentation 
 will be updated to guide upgraders and helpful error messages will gently 
 reject older configure files.
 See also:
 https://cwiki.apache.org/confluence/display/qpid/Java+Pluggable+Authentication+Managers

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Closed] (QPID-3104) why is backport-util-concurrent.jar required when running on linux java 1.6 but not windows

2011-07-14 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell closed QPID-3104.


Resolution: Not A Problem
  Assignee: Robbie Gemmell

The use of backport was required due to the older mina version (1.0.1) being 
used on the Linux test vs the Windows test (1.1.7). Mina 1.1.7 makes use of 
Java5 constructs, whereas Mina 1.0.1 supports Java 1.4 and makes use of the 
backport classes.

QPID-2498 has seen us upgrade our use of Mina to 1.1.7 on trunk for inclusion 
in the 0.14 release, so backport should no longer be required and this JIRA can 
be closed.

 why is backport-util-concurrent.jar required when running on linux java 1.6 
 but not windows
 ---

 Key: QPID-3104
 URL: https://issues.apache.org/jira/browse/QPID-3104
 Project: Qpid
  Issue Type: Bug
  Components: Java Client
Affects Versions: 0.5
 Environment: Lunix,  hotpsot server JVM 1.6.0_20 
 Windows XP. Hotspot client JVM  1.6.0_17
 Qpid java client 0.5
Reporter: Jason Smith
Assignee: Robbie Gemmell
Priority: Minor

 The problem is when running my java application which includes the following 
 Qpid jars and dependencies, it works on Windows but with the same deployment 
 lib it fails when running on Linux.  
 1. I have to add backport 3.0 jar which Im not sure why since I didn't have 
 to in my Windows sandbox.  
 2. apache mina 1.1.7 doesn't work with Qpid 0.5, I had to use mina 1.0.1  
 This is an acceptable solutions but I'm not sure why.  Part of the reason is 
 I have other libraries that will perform much better when using using the 
 latest mina 1.1.7 on java 6.
 On Windows XP - these jars cause no problems
 mina-core-1.1.7.jar
 qpid-all.jar
 qpid-client-0.5.jar
 qpid-common-0.5.jar
 geronimo-jms_1.1_spec-1.0.jar
 On Linux - I have to add these jars in order for Qpid to work, backport was 
 needed and mina needed a downgrade
 mina-core-1.0.1.jar
 backport-util-concurrent.jar
 qpid-all.jar
 qpid-client-0.5.jar
 qpid-common-0.5.jar
 geronimo-jms_1.1_spec-1.0.jar

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: 0.12 release update - release branch created, beta available

2011-07-14 Thread Justin Ross
Rajith, I'm confused by this one.  All the commits associated with QPID-3302 
fall before the 0.12 branch point, 1141543.  I figure we've already got these 
in 0.12.

Justin

- Original Message -
From: Rajith Attapattu rajit...@gmail.com
To: dev@qpid.apache.org
Sent: Thursday, July 14, 2011 10:50:18 AM
Subject: Re: 0.12 release update - release branch created, beta available

Justin,

Could we apply the fix for QPID-3302 into the release branch ?
It's a very low impact change and it allows folks to use JMS to do QMF
operations via Map messages.

Regards,

Rajith

On Tue, Jul 12, 2011 at 1:31 PM, Chuck Rolke cro...@redhat.com wrote:
 +1 Ship it.

 -Chuck

 - Original Message -
 From: Cliff Jansen cliffjan...@gmail.com
 To: dev@qpid.apache.org
 Sent: Tuesday, July 12, 2011 1:21:57 PM
 Subject: Re: 0.12 release update - release branch created, beta available
 I have tested the patch for QPID-3338 against qpid-0.12-beta on Linux
 and it appears to do the right thing for mingw and cmake.

 I would like to request approval for this patch.

 cliff

 -
 Apache Qpid - AMQP Messaging Implementation
 Project: http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org

 -
 Apache Qpid - AMQP Messaging Implementation
 Project:      http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



0.12 release update - RC1 is out

2011-07-14 Thread Justin Ross

Greetings, everyone.  Today I produced RC1 from revision 1146605:

  http://people.apache.org/~jross/qpid-0.12-rc1/

Thanks to everyone who has tested and prodded.  RC2 is due this time next 
week, and the final RC is planned for the end of this month.  See all 
the details at the release page.


Justin

---
0.12 release page: https://cwiki.apache.org/confluence/display/qpid/0.12+Release

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Created] (QPID-3358) Improve performance testing tools for the Java client

2011-07-14 Thread Rajith Attapattu (JIRA)
Improve performance testing tools for the Java client
-

 Key: QPID-3358
 URL: https://issues.apache.org/jira/browse/QPID-3358
 Project: Qpid
  Issue Type: Improvement
  Components: Java Client
Reporter: Rajith Attapattu
Assignee: Rajith Attapattu
 Fix For: 0.14


I plan to do the following.

1. Simplify the scripts - and provide clear instructions to under different 
environments.
   Ex. Running them from an svn checkout.
   Running them from installed rpms.

2. Provide a clear README outlining,
   1. What types of tools are available
   2. How to run the canned scripts
   3. How to construct customized test cases from the building blocks provided.

3. Improve the tests to run with multiple connections/sessions within the same 
JVM

4. Improve the tests to run multiple processors and coordinate results.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: 0.12 release update - release branch created, beta available

2011-07-14 Thread Rajith Attapattu
On Thu, Jul 14, 2011 at 2:56 PM, Justin Ross jr...@redhat.com wrote:
 Rajith, I'm confused by this one.  All the commits associated with QPID-3302 
 fall before the 0.12 branch point, 1141543.  I figure we've already got these 
 in 0.12.
Oh dear, my bad. I was under the impression it was not.
I guess I got confused with the alpha release. I believe this was
after the alpha, but forgot that you didn't branch until after that.
Again please accept my apologies !

Rajith

 Justin

 - Original Message -
 From: Rajith Attapattu rajit...@gmail.com
 To: dev@qpid.apache.org
 Sent: Thursday, July 14, 2011 10:50:18 AM
 Subject: Re: 0.12 release update - release branch created, beta available

 Justin,

 Could we apply the fix for QPID-3302 into the release branch ?
 It's a very low impact change and it allows folks to use JMS to do QMF
 operations via Map messages.

 Regards,

 Rajith

 On Tue, Jul 12, 2011 at 1:31 PM, Chuck Rolke cro...@redhat.com wrote:
 +1 Ship it.

 -Chuck

 - Original Message -
 From: Cliff Jansen cliffjan...@gmail.com
 To: dev@qpid.apache.org
 Sent: Tuesday, July 12, 2011 1:21:57 PM
 Subject: Re: 0.12 release update - release branch created, beta available
 I have tested the patch for QPID-3338 against qpid-0.12-beta on Linux
 and it appears to do the right thing for mingw and cmake.

 I would like to request approval for this patch.

 cliff

 -
 Apache Qpid - AMQP Messaging Implementation
 Project: http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org

 -
 Apache Qpid - AMQP Messaging Implementation
 Project:      http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org



 -
 Apache Qpid - AMQP Messaging Implementation
 Project:      http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org


 -
 Apache Qpid - AMQP Messaging Implementation
 Project:      http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: 0.12 release update - release branch created, beta available

2011-07-14 Thread Justin Ross

Hey, man, no problem.

On Thu, 14 Jul 2011, Rajith Attapattu wrote:


On Thu, Jul 14, 2011 at 2:56 PM, Justin Ross jr...@redhat.com wrote:

Rajith, I'm confused by this one.  All the commits associated with QPID-3302 
fall before the 0.12 branch point, 1141543.  I figure we've already got these 
in 0.12.

Oh dear, my bad. I was under the impression it was not.
I guess I got confused with the alpha release. I believe this was
after the alpha, but forgot that you didn't branch until after that.
Again please accept my apologies !

Rajith


Justin

- Original Message -
From: Rajith Attapattu rajit...@gmail.com
To: dev@qpid.apache.org
Sent: Thursday, July 14, 2011 10:50:18 AM
Subject: Re: 0.12 release update - release branch created, beta available

Justin,

Could we apply the fix for QPID-3302 into the release branch ?
It's a very low impact change and it allows folks to use JMS to do QMF
operations via Map messages.

Regards,

Rajith

On Tue, Jul 12, 2011 at 1:31 PM, Chuck Rolke cro...@redhat.com wrote:

+1 Ship it.

-Chuck

- Original Message -

From: Cliff Jansen cliffjan...@gmail.com
To: dev@qpid.apache.org
Sent: Tuesday, July 12, 2011 1:21:57 PM
Subject: Re: 0.12 release update - release branch created, beta available
I have tested the patch for QPID-3338 against qpid-0.12-beta on Linux
and it appears to do the right thing for mingw and cmake.

I would like to request approval for this patch.

cliff

-
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org


-
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org




-
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org


-
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org




-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: Review Request: Recreation of JCA Resource Adapter review

2011-07-14 Thread Andrew Stitcher


 On 2011-03-03 17:40:21, Andrew Kennedy wrote:
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java,
   line 48
  https://reviews.apache.org/r/441/diff/3/?file=13133#file13133line48
 
  QPID-CF should be external constant 
  r.get() result not checked for null

Agreed - fixed in newer version


 On 2011-03-03 17:40:21, Andrew Kennedy wrote:
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java,
   line 127
  https://reviews.apache.org/r/441/diff/3/?file=13137#file13137line127
 
  QPID-CF should be external constant

Agreed - fixed in newer version


 On 2011-03-03 17:40:21, Andrew Kennedy wrote:
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java,
   line 324
  https://reviews.apache.org/r/441/diff/3/?file=13140#file13140line324
 
  null check is redundant, since instanceof will return false for a null 
  value of obj

Agreed - fixed in newer version


 On 2011-03-03 17:40:21, Andrew Kennedy wrote:
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java,
   line 349
  https://reviews.apache.org/r/441/diff/3/?file=13140#file13140line349
 
  hashCode does not meet Object contract with equals and should include 
  clientId in calculation

Agreed - fixed in newer version


 On 2011-03-03 17:40:21, Andrew Kennedy wrote:
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java,
   line 355
  https://reviews.apache.org/r/441/diff/3/?file=13140#file13140line355
 
  can just use type here?

Agreed - fixed in newer version


 On 2011-03-03 17:40:21, Andrew Kennedy wrote:
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java,
   line 357
  https://reviews.apache.org/r/441/diff/3/?file=13140#file13140line357
 
  can just use acknowledgeMode here?

Agreed - fixed in newer version


 On 2011-03-03 17:40:21, Andrew Kennedy wrote:
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java,
   line 304
  https://reviews.apache.org/r/441/diff/3/?file=13146#file13146line304
 
  null check is redundant, due to use of instanceof

Agreed - fixed in newer version


 On 2011-03-03 17:40:21, Andrew Kennedy wrote:
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java,
   line 321
  https://reviews.apache.org/r/441/diff/3/?file=13146#file13146line321
 
  null check redundant, due to instanceof

Agreed - fixed in newer version


 On 2011-03-03 17:40:21, Andrew Kennedy wrote:
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java,
   line 176
  https://reviews.apache.org/r/441/diff/3/?file=13141#file13141line176
 
  do we really want to use Object's toString here?

On balance we've decided to leave it as is for now, it does no real harm.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/441/#review298
---


On 2011-02-24 15:12:05, Andrew Stitcher wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/441/
 ---
 
 (Updated 2011-02-24 15:12:05)
 
 
 Review request for qpid.
 
 
 Summary
 ---
 
 Review for a qpid JCA resource adapter.
 
 So far no build infrastructure is included.
 
 I'd also like an opinion as to whether java/jca is the appropriate name for 
 this (I'm thinking perhaps java/ra would be more usual).
 
 Any and all comments welcome.
 
 
 This addresses bug QPID-3044.
 https://issues.apache.org/jira/browse/QPID-3044
 
 
 Diffs
 -
 
   
 /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java
  PRE-CREATION 
   
 /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java 
 PRE-CREATION 
   
 /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java
  PRE-CREATION 
   /trunk/qpid/java/build.deps 1070497 
   /trunk/qpid/java/build.xml 1070497 
   /trunk/qpid/java/jca/build.xml PRE-CREATION 
   
 /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java
  PRE-CREATION 
   
 /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java
  PRE-CREATION 
   
 /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java
  PRE-CREATION 
   
 /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java
  PRE-CREATION 
   
 /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java
  PRE-CREATION 
   /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java 
 PRE-CREATION 
   

[jira] [Commented] (QPID-3044) Implement JCA Adapter for Java JMS client

2011-07-14 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13065573#comment-13065573
 ] 

jirapos...@reviews.apache.org commented on QPID-3044:
-



bq.  On 2011-03-03 17:40:21, Andrew Kennedy wrote:
bq.   
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java,
 line 48
bq.   https://reviews.apache.org/r/441/diff/3/?file=13133#file13133line48
bq.  
bq.   QPID-CF should be external constant 
bq.   r.get() result not checked for null

Agreed - fixed in newer version


bq.  On 2011-03-03 17:40:21, Andrew Kennedy wrote:
bq.   
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java,
 line 127
bq.   https://reviews.apache.org/r/441/diff/3/?file=13137#file13137line127
bq.  
bq.   QPID-CF should be external constant

Agreed - fixed in newer version


bq.  On 2011-03-03 17:40:21, Andrew Kennedy wrote:
bq.   
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java,
 line 324
bq.   https://reviews.apache.org/r/441/diff/3/?file=13140#file13140line324
bq.  
bq.   null check is redundant, since instanceof will return false for a 
null value of obj

Agreed - fixed in newer version


bq.  On 2011-03-03 17:40:21, Andrew Kennedy wrote:
bq.   
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java,
 line 349
bq.   https://reviews.apache.org/r/441/diff/3/?file=13140#file13140line349
bq.  
bq.   hashCode does not meet Object contract with equals and should 
include clientId in calculation

Agreed - fixed in newer version


bq.  On 2011-03-03 17:40:21, Andrew Kennedy wrote:
bq.   
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java,
 line 355
bq.   https://reviews.apache.org/r/441/diff/3/?file=13140#file13140line355
bq.  
bq.   can just use type here?

Agreed - fixed in newer version


bq.  On 2011-03-03 17:40:21, Andrew Kennedy wrote:
bq.   
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java,
 line 357
bq.   https://reviews.apache.org/r/441/diff/3/?file=13140#file13140line357
bq.  
bq.   can just use acknowledgeMode here?

Agreed - fixed in newer version


bq.  On 2011-03-03 17:40:21, Andrew Kennedy wrote:
bq.   
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java,
 line 304
bq.   https://reviews.apache.org/r/441/diff/3/?file=13146#file13146line304
bq.  
bq.   null check is redundant, due to use of instanceof

Agreed - fixed in newer version


bq.  On 2011-03-03 17:40:21, Andrew Kennedy wrote:
bq.   
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java,
 line 321
bq.   https://reviews.apache.org/r/441/diff/3/?file=13146#file13146line321
bq.  
bq.   null check redundant, due to instanceof

Agreed - fixed in newer version


bq.  On 2011-03-03 17:40:21, Andrew Kennedy wrote:
bq.   
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java, 
line 176
bq.   https://reviews.apache.org/r/441/diff/3/?file=13141#file13141line176
bq.  
bq.   do we really want to use Object's toString here?

On balance we've decided to leave it as is for now, it does no real harm.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/441/#review298
---


On 2011-02-24 15:12:05, Andrew Stitcher wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/441/
bq.  ---
bq.  
bq.  (Updated 2011-02-24 15:12:05)
bq.  
bq.  
bq.  Review request for qpid.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  Review for a qpid JCA resource adapter.
bq.  
bq.  So far no build infrastructure is included.
bq.  
bq.  I'd also like an opinion as to whether java/jca is the appropriate name 
for this (I'm thinking perhaps java/ra would be more usual).
bq.  
bq.  Any and all comments welcome.
bq.  
bq.  
bq.  This addresses bug QPID-3044.
bq.  https://issues.apache.org/jira/browse/QPID-3044
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java
 PRE-CREATION 
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java 
PRE-CREATION 
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java
 PRE-CREATION 
bq./trunk/qpid/java/build.deps 1070497 
bq./trunk/qpid/java/build.xml 1070497 
bq./trunk/qpid/java/jca/build.xml PRE-CREATION 
bq.
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java
 

Re: Review Request: Recreation of JCA Resource Adapter review

2011-07-14 Thread Andrew Stitcher

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/441/
---

(Updated 2011-07-14 22:39:37.941135)


Review request for qpid, Gordon Sim, Andrew Kennedy, Robbie Gemmell, rajith 
attapattu, and Weston Price.


Changes
---

- Addresses review comments from Andrew Kennedy
- Adds a bunch of examples and documentation
- Removes author (and some other) comments tags imported with code
- Bug fixes found through testing
- Updated Serialization UIDs (for changes since code import)

I intend this to be the code checked into qpid, so review would be welcome.


Summary
---

Review for a qpid JCA resource adapter.

So far no build infrastructure is included.

I'd also like an opinion as to whether java/jca is the appropriate name for 
this (I'm thinking perhaps java/ra would be more usual).

Any and all comments welcome.


This addresses bug QPID-3044.
https://issues.apache.org/jira/browse/QPID-3044


Diffs (updated)
-

  /trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN 
  /trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java
 PRE-CREATION 
  /trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidConnectionFactoryProxy.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidDestinationProxy.java
 PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidQueue.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidTopic.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/AdminObjectFactory.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidBindingURL.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java
 PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java
 PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueBrowser.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java
 PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java
 

[jira] [Commented] (QPID-3044) Implement JCA Adapter for Java JMS client

2011-07-14 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13065588#comment-13065588
 ] 

jirapos...@reviews.apache.org commented on QPID-3044:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/441/
---

(Updated 2011-07-14 22:39:37.941135)


Review request for qpid, Gordon Sim, Andrew Kennedy, Robbie Gemmell, rajith 
attapattu, and Weston Price.


Changes
---

- Addresses review comments from Andrew Kennedy
- Adds a bunch of examples and documentation
- Removes author (and some other) comments tags imported with code
- Bug fixes found through testing
- Updated Serialization UIDs (for changes since code import)

I intend this to be the code checked into qpid, so review would be welcome.


Summary
---

Review for a qpid JCA resource adapter.

So far no build infrastructure is included.

I'd also like an opinion as to whether java/jca is the appropriate name for 
this (I'm thinking perhaps java/ra would be more usual).

Any and all comments welcome.


This addresses bug QPID-3044.
https://issues.apache.org/jira/browse/QPID-3044


Diffs (updated)
-

  /trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN 
  /trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java
 PRE-CREATION 
  /trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidConnectionFactoryProxy.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidDestinationProxy.java
 PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidQueue.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidTopic.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/AdminObjectFactory.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidBindingURL.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java
 PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java
 PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueBrowser.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java
 PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java 
PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java
 PRE-CREATION 
  
/trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java 
PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java 
PRE-CREATION