public facing CI for the C++ components

2011-08-23 Thread Robbie Gemmell
Hi all,

I think it would be a good idea if we could get some public facing CI
set up for the C++ components. There have been various issues which
have gone unnnoticed in recent weeks at least in part due to the lack
of CI as a fallback after not spotting the issues otherwise. We have
some projects set up for the Java tree on the ASF Jenkins instances
(more to follow, once we get some issues with the framework sorted
out), it would be good to get something set up for the C++ broker,
either directly running there or through its remote results reporting
abilities.

Any volunteers willing to get involved?

Some of the recent examples which should have been highlighted by CI
if nothing else:
- I helped break SSL in the 0-10 Java client codepath several weeks
ago and it was only noticed when we were finally fixing SSL in the
Java broker and the 0-8/0-9 client codepath last week. It turned out
the 'cpp' test profile was only no-op'ing whilst saying it was running
the SSL test, and so the only tests that used SSL were in the
'cpp.ssl' test profile (we are running SSL tests in every profile for
the Java broker now though) which evidently no one has been running
considering our
failure to spot the issue, or the fact one of the tests was taking
half an hour to run (https://issues.apache.org/jira/browse/QPID-3431).
- The C++ broker recently started enforcing that exchange.bind
commands dont use the empty string (though it is throwing the wrong
exception when it does,
https://issues.apache.org/jira/browse/QPID-3443), this has broken a
few of the AddressBasedDestination test cases covering the Addressing
syntax support in the Java client, although the Java broker test
profiles dont currently show that because it too has not been checking
for the empty string
(https://issues.apache.org/jira/browse/QPID-3444).
- The recent IPv6 work broke all the Java test profiles for the C++
broker by altering its startup logging which meant the test framework
thought it had failed to start properly
(http://svn.apache.org/viewvc?rev=1160232view=rev)
- etc.

Robbie

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: [VOTE] Release 0.12

2011-08-23 Thread Robbie Gemmell
I have promoted the Maven artifacts for the Java client to the release
repo, so they should sync to the central repo soon.

Robbie

On 23 August 2011 03:23, Justin Ross jus...@redhat.com wrote:
 I've now updated the website.  Please let me know if you have any problems
 after the update.

 I'll have the release notes and announce message ready tomorrow afternoon.

 Thanks,
 Justin

 On Mon, 22 Aug 2011, Robbie Gemmell wrote:

 Excellent. We should probably have (perhaps need?) a [RESULT] [VOTE]
 mail for the record books.

 Robbie

 On 22 August 2011 15:55, Justin Ross jus...@redhat.com wrote:

 Sorry, I'm responsible for the delay.  It's staged on apache dist, and
 I've
 got the web site diff nearly ready.

 Justin

 On Mon, 22 Aug 2011, Robbie Gemmell wrote:

 Bump. Any updates?

 Robbie

 On 16 August 2011 19:10, Justin Ross jr...@redhat.com wrote:

 Last call.  I'll check tomorrow and consider this vote closed if
 there's
 no
 new discussion.

 On Tue, 9 Aug 2011, Justin Ross wrote:

 Howdy, all.  The last-minute blocker, QPID-3394, has been fixed, and
 there
 are no open blocker jiras against 0.12.  The proposed final RC, from
 revision 1154981 of the 0.12 release branch, is available here:

  http://people.apache.org/~jross/qpid-0.12/

 If you favor releasing this distribution as Qpid 0.12, vote +1.  If
 you
 are aware of problems that ought to prevent this distribution from
 being
 released, vote -1.

 If the release proceeds, I'll take the final steps to publicize and
 distribute the release.  That should take one or two days.

 ---
 0.12 release page: https://cwiki.apache.org/qpid/012-release.html

 -
 Apache Qpid - AMQP Messaging Implementation
 Project:      http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org



 -
 Apache Qpid - AMQP Messaging Implementation
 Project:      http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org



 -
 Apache Qpid - AMQP Messaging Implementation
 Project:      http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org




 -
 Apache Qpid - AMQP Messaging Implementation
 Project:      http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org


 -
 Apache Qpid - AMQP Messaging Implementation
 Project:      http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org




 -
 Apache Qpid - AMQP Messaging Implementation
 Project:      http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: public facing CI for the C++ components

2011-08-23 Thread Gordon Sim

On 08/23/2011 09:35 AM, Robbie Gemmell wrote:

- The C++ broker recently started enforcing that exchange.bind
commands dont use the empty string (though it is throwing the wrong
exception when it does,
https://issues.apache.org/jira/browse/QPID-3443)


That was me (QPID-3363). I was actually looking at the default-access 
rule which doesn't specify the exception to use so I chose the exception 
that seemed to me to best fit the rule. Should have thought to check the 
field in the bind/unbind commands. I'll correct the exception type.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3443) the C++ broker uses the wrong exception type when clients try to modify the default exchange

2011-08-23 Thread Gordon Sim (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim reassigned QPID-3443:


Assignee: Gordon Sim

 the C++ broker uses the wrong exception type when clients try to modify the 
 default exchange
 

 Key: QPID-3443
 URL: https://issues.apache.org/jira/browse/QPID-3443
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker
Affects Versions: 0.13
Reporter: Robbie Gemmell
Assignee: Gordon Sim
 Fix For: Future


 Various test cases in AddressBasedDestinationTest are failing on the C++ test 
 profiles, due to an exception being returned indicating the client tried to 
 modify the default exchange. The exception is a NOT_ALLOWED, but the 0-10 
 spec says this should be met with an ILLEGAL_ARGUMENT exception.
 Eg:
 Testcase: testDestinationOnSend took 0.207 sec
 Caused an ERROR
 Error registering consumer: org.apache.qpid.AMQException: ch=0 id=0 
 ExecutionException(errorCode=NOT_ALLOWED, commandId=4, classCode=7, 
 commandCode=4, fieldI
 ndex=0, description=not-allowed: Bind not allowed for default exchange 
 (qpid/broker/Broker.cpp:920), errorInfo={}) [error code 530: not allowed]
 javax.jms.JMSException: Error registering consumer: 
 org.apache.qpid.AMQException: ch=0 id=0 
 ExecutionException(errorCode=NOT_ALLOWED, commandId=4, classCode=
 7, commandCode=4, fieldIndex=0, description=not-allowed: Bind not allowed for 
 default exchange (qpid/broker/Broker.cpp:920), errorInfo={}) [error code 530: 
 n
 ot allowed]
 at org.apache.qpid.client.AMQSession$4.execute(AMQSession.java:2057)
 at org.apache.qpid.client.AMQSession$4.execute(AMQSession.java:2000)
 at 
 org.apache.qpid.client.AMQConnectionDelegate_0_10.executeRetrySupport(AMQConnectionDelegate_0_10.java:325)
 at 
 org.apache.qpid.client.AMQConnection.executeRetrySupport(AMQConnection.java:570)
 at 
 org.apache.qpid.client.failover.FailoverRetrySupport.execute(FailoverRetrySupport.java:102)
 at 
 org.apache.qpid.client.AMQSession.createConsumerImpl(AMQSession.java:1998)
 at 
 org.apache.qpid.client.AMQSession.createConsumer(AMQSession.java:971)
 at 
 org.apache.qpid.test.client.destination.AddressBasedDestinationTest.testDestinationOnSend(AddressBasedDestinationTest.java:1119)
 at 
 org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
 at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:128)
 Caused by: org.apache.qpid.AMQException: ch=0 id=0 
 ExecutionException(errorCode=NOT_ALLOWED, commandId=4, classCode=7, 
 commandCode=4, fieldIndex=0, descripti
 on=not-allowed: Bind not allowed for default exchange 
 (qpid/broker/Broker.cpp:920), errorInfo={}) [error code 530: not allowed]
 at 
 org.apache.qpid.client.AMQSession_0_10.setCurrentException(AMQSession_0_10.java:1058)
 at 
 org.apache.qpid.client.AMQSession_0_10.sync(AMQSession_0_10.java:1038)
 at 
 org.apache.qpid.client.AMQSession_0_10.sendQueueBind(AMQSession_0_10.java:377)
 at org.apache.qpid.client.AMQSession$2.execute(AMQSession.java:678)
 at 
 org.apache.qpid.client.failover.FailoverNoopSupport.execute(FailoverNoopSupport.java:67)
 at org.apache.qpid.client.AMQSession.bindQueue(AMQSession.java:674)
 at 
 org.apache.qpid.client.AMQSession.registerConsumer(AMQSession.java:2854)
 at org.apache.qpid.client.AMQSession.access$500(AMQSession.java:120)
 at org.apache.qpid.client.AMQSession$4.execute(AMQSession.java:2034)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3433) Remove non existing and passing java tests form excludes in java test profiles. Raise JIRAs for non-passing tests where it is necessary.

2011-08-23 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-3433:
-

Attachment: (was: 
Remove-passing-and-not-existing-tests-from-excludes.patch)

 Remove non existing and passing java tests form excludes in java test 
 profiles. Raise JIRAs for non-passing tests where it is necessary.
 

 Key: QPID-3433
 URL: https://issues.apache.org/jira/browse/QPID-3433
 Project: Qpid
  Issue Type: Task
  Components: Java Broker, Java Client
Affects Versions: 0.14, Future
Reporter: Alex Rudyy
Assignee: Keith Wall
Priority: Minor

 Existing exclude files for java tests contain entries with passing tests and 
 non existing tests. The aim of this task is to run and verify all excluded 
 tests, raise defects for excluded tests( if such defects were not raised 
 before), clean excludes from non existing tests and passing tests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3433) Remove non existing and passing java tests form excludes in java test profiles. Raise JIRAs for non-passing tests where it is necessary.

2011-08-23 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-3433:
-

Attachment: Remove-passing-and-not-existing-tests-from-excludes.patch

In updated patch I removed ConnectionTest exclude from Pre010Profile and 
updated commentaries

 Remove non existing and passing java tests form excludes in java test 
 profiles. Raise JIRAs for non-passing tests where it is necessary.
 

 Key: QPID-3433
 URL: https://issues.apache.org/jira/browse/QPID-3433
 Project: Qpid
  Issue Type: Task
  Components: Java Broker, Java Client
Affects Versions: 0.14, Future
Reporter: Alex Rudyy
Assignee: Keith Wall
Priority: Minor
 Attachments: Remove-passing-and-not-existing-tests-from-excludes.patch


 Existing exclude files for java tests contain entries with passing tests and 
 non existing tests. The aim of this task is to run and verify all excluded 
 tests, raise defects for excluded tests( if such defects were not raised 
 before), clean excludes from non existing tests and passing tests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Created] (QPID-3448) JMS Client throws unchecked SessionExceptions to client application

2011-08-23 Thread Keith Wall (JIRA)
JMS Client throws unchecked SessionExceptions to client application
---

 Key: QPID-3448
 URL: https://issues.apache.org/jira/browse/QPID-3448
 Project: Qpid
  Issue Type: Bug
  Components: Java Client
Affects Versions: 0.10, 0.11, 0.12
Reporter: Keith Wall


On the 0-10 code path, there are instances where the client application 
receives an unchecked Qpid SessionException rather than a JMSException as 
mandated by the JMS Specification.   The client application should not be 
forced to catch 'internal' Qpid exceptions.

For example if a javax.jms.Session#commit takes longer than 60 seconds, the 
client receives:

{code}
org.apache.qpid.transport.SessionException: timed out waiting for sync: 
complete = 12, point = 15
at org.apache.qpid.transport.Session.sync(Session.java:798)
at org.apache.qpid.transport.Session.sync(Session.java:772)
at org.apache.qpid.transport.Session.invoke(Session.java:732)
at org.apache.qpid.transport.Session.invoke(Session.java:561)
at 
org.apache.qpid.transport.SessionInvoker.txCommit(SessionInvoker.java:148)
at 
org.apache.qpid.client.AMQSession_0_10.sendCommit(AMQSession_0_10.java:423)
at 
org.apache.qpid.client.AMQSession_0_10.commit(AMQSession_0_10.java:1008)
{code}

For comparison, 0-8..-0-9-1 throws a JMSException with an underlying of 
AMQTimeoutException.



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Created] (QPID-3449) 0-10 code path hardcodes session timeout to 60 seconds.

2011-08-23 Thread Keith Wall (JIRA)
0-10 code path hardcodes session timeout to 60 seconds.
---

 Key: QPID-3449
 URL: https://issues.apache.org/jira/browse/QPID-3449
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker, Java Client
Affects Versions: 0.10, 0.11, 0.12
Reporter: Keith Wall
Assignee: Robbie Gemmell


The 0-10 code path has a hardcoded timeout value (Session#timeout) used to 
enforce a maximum time permitted for Method invocation (Session#invoke) and 
sync (Session#sync).  This value is 60,000ms.

Users should have the ability to override this setting on both broker and 
client side in order that they have flexibility to deal with issues such as 
slow WAN, contended storage etc that may require this parameter to be tuned.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Updated] (QPID-3433) Remove non existing and passing java tests from excludes in java test profiles. Raise JIRAs for non-passing tests where it is necessary.

2011-08-23 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall updated QPID-3433:
-

Summary: Remove non existing and passing java tests from excludes in java 
test profiles. Raise JIRAs for non-passing tests where it is necessary.  (was: 
Remove non existing and passing java tests form excludes in java test profiles. 
Raise JIRAs for non-passing tests where it is necessary.)

 Remove non existing and passing java tests from excludes in java test 
 profiles. Raise JIRAs for non-passing tests where it is necessary.
 

 Key: QPID-3433
 URL: https://issues.apache.org/jira/browse/QPID-3433
 Project: Qpid
  Issue Type: Task
  Components: Java Broker, Java Client
Affects Versions: 0.14, Future
Reporter: Alex Rudyy
Assignee: Keith Wall
Priority: Minor
 Attachments: Remove-passing-and-not-existing-tests-from-excludes.patch


 Existing exclude files for java tests contain entries with passing tests and 
 non existing tests. The aim of this task is to run and verify all excluded 
 tests, raise defects for excluded tests( if such defects were not raised 
 before), clean excludes from non existing tests and passing tests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-3443) the C++ broker uses the wrong exception type when clients try to modify the default exchange

2011-08-23 Thread Gordon Sim (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved QPID-3443.
--

   Resolution: Fixed
Fix Version/s: (was: Future)
   0.13

Fixed (note the exception specified by the specification is *invalid* argument).

 the C++ broker uses the wrong exception type when clients try to modify the 
 default exchange
 

 Key: QPID-3443
 URL: https://issues.apache.org/jira/browse/QPID-3443
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker
Affects Versions: 0.13
Reporter: Robbie Gemmell
Assignee: Gordon Sim
 Fix For: 0.13


 Various test cases in AddressBasedDestinationTest are failing on the C++ test 
 profiles, due to an exception being returned indicating the client tried to 
 modify the default exchange. The exception is a NOT_ALLOWED, but the 0-10 
 spec says this should be met with an ILLEGAL_ARGUMENT exception.
 Eg:
 Testcase: testDestinationOnSend took 0.207 sec
 Caused an ERROR
 Error registering consumer: org.apache.qpid.AMQException: ch=0 id=0 
 ExecutionException(errorCode=NOT_ALLOWED, commandId=4, classCode=7, 
 commandCode=4, fieldI
 ndex=0, description=not-allowed: Bind not allowed for default exchange 
 (qpid/broker/Broker.cpp:920), errorInfo={}) [error code 530: not allowed]
 javax.jms.JMSException: Error registering consumer: 
 org.apache.qpid.AMQException: ch=0 id=0 
 ExecutionException(errorCode=NOT_ALLOWED, commandId=4, classCode=
 7, commandCode=4, fieldIndex=0, description=not-allowed: Bind not allowed for 
 default exchange (qpid/broker/Broker.cpp:920), errorInfo={}) [error code 530: 
 n
 ot allowed]
 at org.apache.qpid.client.AMQSession$4.execute(AMQSession.java:2057)
 at org.apache.qpid.client.AMQSession$4.execute(AMQSession.java:2000)
 at 
 org.apache.qpid.client.AMQConnectionDelegate_0_10.executeRetrySupport(AMQConnectionDelegate_0_10.java:325)
 at 
 org.apache.qpid.client.AMQConnection.executeRetrySupport(AMQConnection.java:570)
 at 
 org.apache.qpid.client.failover.FailoverRetrySupport.execute(FailoverRetrySupport.java:102)
 at 
 org.apache.qpid.client.AMQSession.createConsumerImpl(AMQSession.java:1998)
 at 
 org.apache.qpid.client.AMQSession.createConsumer(AMQSession.java:971)
 at 
 org.apache.qpid.test.client.destination.AddressBasedDestinationTest.testDestinationOnSend(AddressBasedDestinationTest.java:1119)
 at 
 org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
 at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:128)
 Caused by: org.apache.qpid.AMQException: ch=0 id=0 
 ExecutionException(errorCode=NOT_ALLOWED, commandId=4, classCode=7, 
 commandCode=4, fieldIndex=0, descripti
 on=not-allowed: Bind not allowed for default exchange 
 (qpid/broker/Broker.cpp:920), errorInfo={}) [error code 530: not allowed]
 at 
 org.apache.qpid.client.AMQSession_0_10.setCurrentException(AMQSession_0_10.java:1058)
 at 
 org.apache.qpid.client.AMQSession_0_10.sync(AMQSession_0_10.java:1038)
 at 
 org.apache.qpid.client.AMQSession_0_10.sendQueueBind(AMQSession_0_10.java:377)
 at org.apache.qpid.client.AMQSession$2.execute(AMQSession.java:678)
 at 
 org.apache.qpid.client.failover.FailoverNoopSupport.execute(FailoverNoopSupport.java:67)
 at org.apache.qpid.client.AMQSession.bindQueue(AMQSession.java:674)
 at 
 org.apache.qpid.client.AMQSession.registerConsumer(AMQSession.java:2854)
 at org.apache.qpid.client.AMQSession.access$500(AMQSession.java:120)
 at org.apache.qpid.client.AMQSession$4.execute(AMQSession.java:2034)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-3439) stop importing Signal handling classes directly to break reliance on sun.misc heirarchy and prevent the associated compiler warnings

2011-08-23 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall resolved QPID-3439.
--

Resolution: Fixed

Reviewed, no comments from me. 

cheers Keith.

 stop importing Signal handling classes directly to break reliance on sun.misc 
 heirarchy and prevent the associated compiler warnings
 

 Key: QPID-3439
 URL: https://issues.apache.org/jira/browse/QPID-3439
 Project: Qpid
  Issue Type: Improvement
  Components: Java Broker
Affects Versions: 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
Reporter: Robbie Gemmell
Assignee: Keith Wall
 Fix For: 0.13


 The broker currently uses the sun.misc.Signal(Handler) classes directly 
 within the ServerConfiguration class, creating both a reliance on the classes 
 existing (they are far more prevalent than just the Sun JDK as might be 
 expected, but their existance isn't guaranteed) and also causing 
 unsuppressable compiler warnigns during the build.
 The use of these classes should be isolated from ServerConfiguration to allow 
 use of the broker on JDKs which do not support them, and additionally their 
 use should be proxied using reflection to remove the associated compiler 
 warnings.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Resolved] (QPID-3387) QueueEntries can hold the Subscriptions which rejected them in memory after they are closed

2011-08-23 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall resolved QPID-3387.
--

Resolution: Fixed

Reviewed earlier this month as part of QPID-3386.  There were no comments.

 QueueEntries can hold the Subscriptions which rejected them in memory after 
 they are closed
 ---

 Key: QPID-3387
 URL: https://issues.apache.org/jira/browse/QPID-3387
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Affects Versions: 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
Reporter: Robbie Gemmell
Assignee: Keith Wall
 Fix For: 0.13


 QueueEntries can hold Subscriptions which rejected them in memory after they 
 are closed, due to the implementation of the isRejectedBy() method. This is 
 further compounded by the Subscriptions having a reference to the 
 channel/session they belong to, which in the case of a 0-10 ServerSession can 
 be an extremely heavy weight object in the wrong conditions. The 
 isRejectedBy() implementation should be updated to function without requiring 
 a reference to the Subscription itself, thus preventing the retention leak.
 I have had a simple patch for this for a while, its just waiting for 
 QPID-3386 being done (which it almost is, will get it committed shortly).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-3443) the C++ broker uses the wrong exception type when clients try to modify the default exchange

2011-08-23 Thread Robbie Gemmell (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089402#comment-13089402
 ] 

Robbie Gemmell commented on QPID-3443:
--

Oops, too used to using IllegalArgumentException so I guess I typed it 
instinctively :)

 the C++ broker uses the wrong exception type when clients try to modify the 
 default exchange
 

 Key: QPID-3443
 URL: https://issues.apache.org/jira/browse/QPID-3443
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker
Affects Versions: 0.13
Reporter: Robbie Gemmell
Assignee: Gordon Sim
 Fix For: 0.13


 Various test cases in AddressBasedDestinationTest are failing on the C++ test 
 profiles, due to an exception being returned indicating the client tried to 
 modify the default exchange. The exception is a NOT_ALLOWED, but the 0-10 
 spec says this should be met with an ILLEGAL_ARGUMENT exception.
 Eg:
 Testcase: testDestinationOnSend took 0.207 sec
 Caused an ERROR
 Error registering consumer: org.apache.qpid.AMQException: ch=0 id=0 
 ExecutionException(errorCode=NOT_ALLOWED, commandId=4, classCode=7, 
 commandCode=4, fieldI
 ndex=0, description=not-allowed: Bind not allowed for default exchange 
 (qpid/broker/Broker.cpp:920), errorInfo={}) [error code 530: not allowed]
 javax.jms.JMSException: Error registering consumer: 
 org.apache.qpid.AMQException: ch=0 id=0 
 ExecutionException(errorCode=NOT_ALLOWED, commandId=4, classCode=
 7, commandCode=4, fieldIndex=0, description=not-allowed: Bind not allowed for 
 default exchange (qpid/broker/Broker.cpp:920), errorInfo={}) [error code 530: 
 n
 ot allowed]
 at org.apache.qpid.client.AMQSession$4.execute(AMQSession.java:2057)
 at org.apache.qpid.client.AMQSession$4.execute(AMQSession.java:2000)
 at 
 org.apache.qpid.client.AMQConnectionDelegate_0_10.executeRetrySupport(AMQConnectionDelegate_0_10.java:325)
 at 
 org.apache.qpid.client.AMQConnection.executeRetrySupport(AMQConnection.java:570)
 at 
 org.apache.qpid.client.failover.FailoverRetrySupport.execute(FailoverRetrySupport.java:102)
 at 
 org.apache.qpid.client.AMQSession.createConsumerImpl(AMQSession.java:1998)
 at 
 org.apache.qpid.client.AMQSession.createConsumer(AMQSession.java:971)
 at 
 org.apache.qpid.test.client.destination.AddressBasedDestinationTest.testDestinationOnSend(AddressBasedDestinationTest.java:1119)
 at 
 org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
 at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:128)
 Caused by: org.apache.qpid.AMQException: ch=0 id=0 
 ExecutionException(errorCode=NOT_ALLOWED, commandId=4, classCode=7, 
 commandCode=4, fieldIndex=0, descripti
 on=not-allowed: Bind not allowed for default exchange 
 (qpid/broker/Broker.cpp:920), errorInfo={}) [error code 530: not allowed]
 at 
 org.apache.qpid.client.AMQSession_0_10.setCurrentException(AMQSession_0_10.java:1058)
 at 
 org.apache.qpid.client.AMQSession_0_10.sync(AMQSession_0_10.java:1038)
 at 
 org.apache.qpid.client.AMQSession_0_10.sendQueueBind(AMQSession_0_10.java:377)
 at org.apache.qpid.client.AMQSession$2.execute(AMQSession.java:678)
 at 
 org.apache.qpid.client.failover.FailoverNoopSupport.execute(FailoverNoopSupport.java:67)
 at org.apache.qpid.client.AMQSession.bindQueue(AMQSession.java:674)
 at 
 org.apache.qpid.client.AMQSession.registerConsumer(AMQSession.java:2854)
 at org.apache.qpid.client.AMQSession.access$500(AMQSession.java:120)
 at org.apache.qpid.client.AMQSession$4.execute(AMQSession.java:2034)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Commented] (QPID-3443) the C++ broker uses the wrong exception type when clients try to modify the default exchange

2011-08-23 Thread Gordon Sim (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089411#comment-13089411
 ] 

Gordon Sim commented on QPID-3443:
--

There is an illegal argument code as well(!), just not defined as the right 
choice in this case.

 the C++ broker uses the wrong exception type when clients try to modify the 
 default exchange
 

 Key: QPID-3443
 URL: https://issues.apache.org/jira/browse/QPID-3443
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker
Affects Versions: 0.13
Reporter: Robbie Gemmell
Assignee: Gordon Sim
 Fix For: 0.13


 Various test cases in AddressBasedDestinationTest are failing on the C++ test 
 profiles, due to an exception being returned indicating the client tried to 
 modify the default exchange. The exception is a NOT_ALLOWED, but the 0-10 
 spec says this should be met with an ILLEGAL_ARGUMENT exception.
 Eg:
 Testcase: testDestinationOnSend took 0.207 sec
 Caused an ERROR
 Error registering consumer: org.apache.qpid.AMQException: ch=0 id=0 
 ExecutionException(errorCode=NOT_ALLOWED, commandId=4, classCode=7, 
 commandCode=4, fieldI
 ndex=0, description=not-allowed: Bind not allowed for default exchange 
 (qpid/broker/Broker.cpp:920), errorInfo={}) [error code 530: not allowed]
 javax.jms.JMSException: Error registering consumer: 
 org.apache.qpid.AMQException: ch=0 id=0 
 ExecutionException(errorCode=NOT_ALLOWED, commandId=4, classCode=
 7, commandCode=4, fieldIndex=0, description=not-allowed: Bind not allowed for 
 default exchange (qpid/broker/Broker.cpp:920), errorInfo={}) [error code 530: 
 n
 ot allowed]
 at org.apache.qpid.client.AMQSession$4.execute(AMQSession.java:2057)
 at org.apache.qpid.client.AMQSession$4.execute(AMQSession.java:2000)
 at 
 org.apache.qpid.client.AMQConnectionDelegate_0_10.executeRetrySupport(AMQConnectionDelegate_0_10.java:325)
 at 
 org.apache.qpid.client.AMQConnection.executeRetrySupport(AMQConnection.java:570)
 at 
 org.apache.qpid.client.failover.FailoverRetrySupport.execute(FailoverRetrySupport.java:102)
 at 
 org.apache.qpid.client.AMQSession.createConsumerImpl(AMQSession.java:1998)
 at 
 org.apache.qpid.client.AMQSession.createConsumer(AMQSession.java:971)
 at 
 org.apache.qpid.test.client.destination.AddressBasedDestinationTest.testDestinationOnSend(AddressBasedDestinationTest.java:1119)
 at 
 org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
 at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:128)
 Caused by: org.apache.qpid.AMQException: ch=0 id=0 
 ExecutionException(errorCode=NOT_ALLOWED, commandId=4, classCode=7, 
 commandCode=4, fieldIndex=0, descripti
 on=not-allowed: Bind not allowed for default exchange 
 (qpid/broker/Broker.cpp:920), errorInfo={}) [error code 530: not allowed]
 at 
 org.apache.qpid.client.AMQSession_0_10.setCurrentException(AMQSession_0_10.java:1058)
 at 
 org.apache.qpid.client.AMQSession_0_10.sync(AMQSession_0_10.java:1038)
 at 
 org.apache.qpid.client.AMQSession_0_10.sendQueueBind(AMQSession_0_10.java:377)
 at org.apache.qpid.client.AMQSession$2.execute(AMQSession.java:678)
 at 
 org.apache.qpid.client.failover.FailoverNoopSupport.execute(FailoverNoopSupport.java:67)
 at org.apache.qpid.client.AMQSession.bindQueue(AMQSession.java:674)
 at 
 org.apache.qpid.client.AMQSession.registerConsumer(AMQSession.java:2854)
 at org.apache.qpid.client.AMQSession.access$500(AMQSession.java:120)
 at org.apache.qpid.client.AMQSession$4.execute(AMQSession.java:2034)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Review Request: Provides the EventNotifier type, plus example agent and unit test.

2011-08-23 Thread Darryl L. Pierce
On Mon, Aug 22, 2011 at 06:19:57PM -0400, Andrew Stitcher wrote:
 The problem is that the closest thing to a Unix file descriptor on
 Windows is a HANDLE. But SOCKETs are not HANDLEs.
 
 If all your application wants to do is receive data from sockets and
 multiplex that then a windows SOCKET is fine.
 
 But given you're writing a library which will be used by some arbitrary
 application I don't see how you can assert that the only thing this
 unknown application will be allowed to do in parallel in it's main loop
 with qmf is other network operations.

Okay, I'm getting the intent on yours and Steve's side now. I was still
focused more on providing the same capability as *nix on the Windows
side. 

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/



pgpVDbMgiJiMY.pgp
Description: PGP signature


Re: Review Request: Provides the EventNotifier type, plus example agent and unit test.

2011-08-23 Thread Darryl L. Pierce
On Mon, Aug 22, 2011 at 04:49:13PM -0500, Steve Huston wrote:
 What do you expect that the caller will need (or want) to do with this thing?

I think my expectations were off on the Windows side. 

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/



pgpUnPZDX0qFT.pgp
Description: PGP signature


[jira] [Commented] (QPID-3433) Remove non existing and passing java tests from excludes in java test profiles. Raise JIRAs for non-passing tests where it is necessary.

2011-08-23 Thread Keith Wall (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089442#comment-13089442
 ] 

Keith Wall commented on QPID-3433:
--

Hi Alex, I think that RecoverTest and FailoverBeforeConsumingRecoverTest should 
be reenabled on the 0-10 profile.   I find I can run these tests dozens of 
times without seeing failure.  If you agree please remake the patch and I'll 
apply.  No other comments.  Thanks, Keith.



 Remove non existing and passing java tests from excludes in java test 
 profiles. Raise JIRAs for non-passing tests where it is necessary.
 

 Key: QPID-3433
 URL: https://issues.apache.org/jira/browse/QPID-3433
 Project: Qpid
  Issue Type: Task
  Components: Java Broker, Java Client
Affects Versions: 0.14, Future
Reporter: Alex Rudyy
Assignee: Keith Wall
Priority: Minor
 Attachments: Remove-passing-and-not-existing-tests-from-excludes.patch


 Existing exclude files for java tests contain entries with passing tests and 
 non existing tests. The aim of this task is to run and verify all excluded 
 tests, raise defects for excluded tests( if such defects were not raised 
 before), clean excludes from non existing tests and passing tests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] [Assigned] (QPID-3433) Remove non existing and passing java tests from excludes in java test profiles. Raise JIRAs for non-passing tests where it is necessary.

2011-08-23 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall reassigned QPID-3433:


Assignee: Alex Rudyy  (was: Keith Wall)

 Remove non existing and passing java tests from excludes in java test 
 profiles. Raise JIRAs for non-passing tests where it is necessary.
 

 Key: QPID-3433
 URL: https://issues.apache.org/jira/browse/QPID-3433
 Project: Qpid
  Issue Type: Task
  Components: Java Broker, Java Client
Affects Versions: 0.14, Future
Reporter: Alex Rudyy
Assignee: Alex Rudyy
Priority: Minor
 Attachments: Remove-passing-and-not-existing-tests-from-excludes.patch


 Existing exclude files for java tests contain entries with passing tests and 
 non existing tests. The aim of this task is to run and verify all excluded 
 tests, raise defects for excluded tests( if such defects were not raised 
 before), clean excludes from non existing tests and passing tests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Review Request: Provides the EventNotifier type, plus example agent and unit test.

2011-08-23 Thread Andrew Stitcher

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1557/#review1601
---



trunk/qpid/cpp/include/qmf/EventNotifier.h
https://reviews.apache.org/r/1557/#comment3618

Don't need this include use

class AgentSession;



trunk/qpid/cpp/include/qmf/EventNotifier.h
https://reviews.apache.org/r/1557/#comment3619

similarly use

class ConsoleSession;

and remove this #include



trunk/qpid/cpp/include/qmf/EventNotifier.h
https://reviews.apache.org/r/1557/#comment3620

I think it would be clearer to combine this #ifdef section with the one 
below (the definition here is only used there anyway



trunk/qpid/cpp/src/qmf/PosixEventNotifierImpl.cpp
https://reviews.apache.org/r/1557/#comment3621

Why use a socketpair? a pipe whould do just as well for Posix.

(socketpair has a certain compatibility with windows, but uses more 
resources if a pipe will do)


- Andrew


On 2011-08-19 18:30:06, Darryl Pierce wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/1557/
 ---
 
 (Updated 2011-08-19 18:30:06)
 
 
 Review request for qpid, Kenneth Giusti, michael goulish, and Ted Ross.
 
 
 Summary
 ---
 
 Provides a new method for providing notification to an interested party when 
 new messages are received.
 
 The EventNotifier class can be associated with either a console or agent 
 session. The object provides a file descriptor which then becomes readable 
 when there are messages to be processed.
 
 This implementation only supports Posix. There is some work necessary to get 
 a Windows implementation in place.
 
 
 Diffs
 -
 
   trunk/qpid/cpp/bindings/qmf2/examples/cpp/Makefile.am 1159329 
   trunk/qpid/cpp/bindings/qmf2/examples/cpp/event_driven_list_agents.cpp 
 PRE-CREATION 
   trunk/qpid/cpp/include/qmf/AgentSession.h 1159329 
   trunk/qpid/cpp/include/qmf/ConsoleSession.h 1159329 
   trunk/qpid/cpp/include/qmf/EventNotifier.h PRE-CREATION 
   trunk/qpid/cpp/src/CMakeLists.txt 1159329 
   trunk/qpid/cpp/src/qmf.mk 1159329 
   trunk/qpid/cpp/src/qmf/AgentSession.cpp 1159329 
   trunk/qpid/cpp/src/qmf/AgentSessionImpl.h PRE-CREATION 
   trunk/qpid/cpp/src/qmf/ConsoleSession.cpp 1159329 
   trunk/qpid/cpp/src/qmf/ConsoleSessionImpl.h 1159329 
   trunk/qpid/cpp/src/qmf/EventNotifier.cpp PRE-CREATION 
   trunk/qpid/cpp/src/qmf/EventNotifierImpl.h PRE-CREATION 
   trunk/qpid/cpp/src/qmf/EventNotifierImpl.cpp PRE-CREATION 
   trunk/qpid/cpp/src/qmf/PosixEventNotifierImpl.cpp PRE-CREATION 
   trunk/qpid/cpp/src/tests/EventNotifierTest.cpp PRE-CREATION 
   trunk/qpid/cpp/src/tests/Makefile.am 1159329 
 
 Diff: https://reviews.apache.org/r/1557/diff
 
 
 Testing
 ---
 
 An example agent takes the existing list_agents and uses an EventNotifier to 
 respond to incoming messages rather than blocking on the 
 ConsoleSession.nextReceiver() API.
 
 A unit test verifies that the file handle provides by the EventNotifier type 
 is properly updating on incoming messgaes.
 
 
 Thanks,
 
 Darryl
 




[jira] [Updated] (QPID-3419) qpid-config --file-size parameter's help text uses incorrect units

2011-08-23 Thread Paul Colby (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Colby updated QPID-3419:
-

Attachment: QPID-3419.diff

Added a very small diff file to make the one (very minor) change.

 qpid-config --file-size parameter's help text uses incorrect units
 --

 Key: QPID-3419
 URL: https://issues.apache.org/jira/browse/QPID-3419
 Project: Qpid
  Issue Type: Bug
  Components: Tools
Affects Versions: 0.10
Reporter: Paul Colby
Priority: Trivial
 Attachments: QPID-3419.diff


 It seems to me, that the {{qpid-config --file-size}} parameter's help text 
 uses incorrect units.  It shows:
 bq. --file-size=n File size in pages (64Kib/page)
 which would indicate that 24-pages (the default) would yield 192KiB journal 
 files (24 * 64 / 8).  But instead, the journal files I get are ~1.6MiB, which 
 would suggest that the 64Kib is meant to be 64KiB (ie Kibibytes instead of 
 Kibibits).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org