[jira] [Updated] (QPID-4480) If amqp/map contains a string containing a null, perl bindings will truncate it when encoding

2012-11-28 Thread Jimmy Jones (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jimmy Jones updated QPID-4480:
--

Attachment: hello_world2.pl

Test case. Well not a proper perl test as i've not written one before, but a 
script that shows the problem.

> If amqp/map contains a string containing a null, perl bindings will truncate 
> it when encoding
> -
>
> Key: QPID-4480
> URL: https://issues.apache.org/jira/browse/QPID-4480
> Project: Qpid
>  Issue Type: Bug
>Affects Versions: 0.18
> Environment: RHEL6
>Reporter: Jimmy Jones
>Assignee: Darryl L. Pierce
> Attachments: hello_world2.pl, null-in-string-inside-map.patch
>
>
> The following code doesn't work as expected, the name element is truncated at 
> the null byte.
> my $hash = { id => 1234, name => "Blah\x00Blah" };
> cqpid_perl::encode($hash, $outmsg);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



PROTON - amqp 1.0 support

2012-11-28 Thread Mary Hinton
Hi,

I'm trying to use  the optional amqp 1.0 support for qpid within cmake, but
I get the following message in debug mode:

CMake Error at src/amqp.cmake:38 (message):

  Qpid proton not found, required for amqp 1.0 support.

 

I have the environment system variables - PROTON_HOME and PROJECT_SOURCE_DIR
set. Does anyone know what else I might need to set?

 

I'm working in Windows and have a Windows version of proton working. I also
had a qpid windows project setup, but I'm trying to setup the latest qpid
code with amqp 1.0 support.

 

Thanks,

Mary



[jira] [Created] (QPID-4482) Have the broker send unsolicited outstanding completions every n seconds

2012-11-28 Thread Andy Goldstein (JIRA)
Andy Goldstein created QPID-4482:


 Summary: Have the broker send unsolicited outstanding completions 
every n seconds
 Key: QPID-4482
 URL: https://issues.apache.org/jira/browse/QPID-4482
 Project: Qpid
  Issue Type: Improvement
  Components: C++ Broker
Reporter: Andy Goldstein
Priority: Minor


When a Sender with capacity > 1 sends a message to a broker asynchronously, it 
currently won't receive completions from the broker for unsettled messages 
until the window is > capacity/4 (which is when the Sender calls 
session.flush()).

Similarly, when using federation with acks enabled, the broker only flushes 
completions every  messages, which could result in a large amount of 
memory usage if there is a large number of unacked messages, even if it's been 
seconds/minutes/hours/etc since the last message was sent over the federation 
link.

It would be nice if in both situations the broker could be configured to send 
completions every n seconds, where n is configurable.  This way, senders and 
federated brokers could receive updates on the status of their unsettled 
messages without having to wait to cross a "# of messages" threshold.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4472) NPE when connecting over AMQP 1.0 with no SASL layer

2012-11-28 Thread Rob Godfrey (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505919#comment-13505919
 ] 

Rob Godfrey commented on QPID-4472:
---

Merged to 0.20 as r1414799.

> NPE when connecting over AMQP 1.0 with no SASL layer
> 
>
> Key: QPID-4472
> URL: https://issues.apache.org/jira/browse/QPID-4472
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.20
>Reporter: Gordon Sim
> Fix For: 0.20, 0.21
>
>
> In doing some interop testing, I ran the c++ client (qpid::messaging) against 
> the java broker without a SASL layer, triggering a NullPointerException and 
> broker shutdown:
> {noformat}
> [Broker] BRK-1004 : Qpid Broker Ready
> java.lang.NullPointerException
>   at 
> org.apache.qpid.server.protocol.ProtocolEngine_1_0_0.received(ProtocolEngine_1_0_0.java:280)
>   at 
> org.apache.qpid.server.protocol.ProtocolEngine_1_0_0.received(ProtocolEngine_1_0_0.java:49)
>   at 
> org.apache.qpid.server.protocol.MultiVersionProtocolEngine$SelfDelegateProtocolEngine.received(MultiVersionProtocolEngine.java:556)
>   at 
> org.apache.qpid.server.protocol.MultiVersionProtocolEngine$SelfDelegateProtocolEngine.received(MultiVersionProtocolEngine.java:442)
>   at 
> org.apache.qpid.server.protocol.MultiVersionProtocolEngine.received(MultiVersionProtocolEngine.java:118)
>   at 
> org.apache.qpid.server.protocol.MultiVersionProtocolEngine.received(MultiVersionProtocolEngine.java:37)
>   at 
> org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:161)
>   at java.lang.Thread.run(Thread.java:722)
> 
> #
> # Unhandled Exception java.lang.NullPointerException in Thread IoReceiver - 
> /127.0.0.1:59542
> #
> # Exiting
> #
> 
> java.lang.NullPointerException
>   at 
> org.apache.qpid.server.protocol.ProtocolEngine_1_0_0.closed(ProtocolEngine_1_0_0.java:293)
>   at 
> org.apache.qpid.server.protocol.MultiVersionProtocolEngine.closed(MultiVersionProtocolEngine.java:102)
>   at 
> org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:222)
>   at java.lang.Thread.run(Thread.java:722)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-2796) [Java] implement support for heartbeats following IO changes to the 0-8/0-9/0-9-1/0-10 broker and 0-8/0-9/0-9-1 client

2012-11-28 Thread Rob Godfrey (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505917#comment-13505917
 ] 

Rob Godfrey commented on QPID-2796:
---

Merged to 0.20 as r1414927.

> [Java] implement support for heartbeats following IO changes to the 
> 0-8/0-9/0-9-1/0-10 broker and 0-8/0-9/0-9-1 client
> --
>
> Key: QPID-2796
> URL: https://issues.apache.org/jira/browse/QPID-2796
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker, Java Client
>Affects Versions: 0.15
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.20, 0.21
>
>
> The Java broker and client are not able to generate AMQP heartbeats following 
> the updates to their IO layer. The 0-8/0-9/0-9-1 codepaths previously relied 
> on the Mina IO layer to support this, and as such can no longer do so. The 
> 0-10 path of the Java broker leverages much of the 0-10 implementation in 
> common originally developed for the 0-10 Java client, which simply reflects 
> heartbeats it receives from a broker and as such no heartbeats will ever be 
> sent by broker or the client despite its support.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



Re: Perl bindings fix for 0.20

2012-11-28 Thread Darryl L. Pierce
On Wed, Nov 28, 2012 at 09:50:06PM +0100, Jimmy Jones wrote:
> Would someone mind reviewing QPID-4480, and if possible including in 0.20? 
> Using the perl bindings, when sending a amqp/map containing a string 
> containing a null, its truncated at the first null. I've attached a simple 
> patch that fixes this. I can't find any workaround apart from the patch.

Hi, Jimmy. Thanks for the patch! Would you mind providing a test to
exhibit the problem that we can use to verify the patch? I'm planning to
introduce some test suites for the Perl bindings and would love a way to
verify this fix.

If you can make it so that the test can be run with and without the
patch, failing in the former case, I'll be glad to commit this patch.
Getting it into 0.20 is outside of my control, but will request it. :)

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/



pgpwllSQ3due3.pgp
Description: PGP signature


[jira] [Assigned] (QPID-4480) If amqp/map contains a string containing a null, perl bindings will truncate it when encoding

2012-11-28 Thread Darryl L. Pierce (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darryl L. Pierce reassigned QPID-4480:
--

Assignee: Darryl L. Pierce

> If amqp/map contains a string containing a null, perl bindings will truncate 
> it when encoding
> -
>
> Key: QPID-4480
> URL: https://issues.apache.org/jira/browse/QPID-4480
> Project: Qpid
>  Issue Type: Bug
>Affects Versions: 0.18
> Environment: RHEL6
>Reporter: Jimmy Jones
>Assignee: Darryl L. Pierce
> Attachments: null-in-string-inside-map.patch
>
>
> The following code doesn't work as expected, the name element is truncated at 
> the null byte.
> my $hash = { id => 1234, name => "Blah\x00Blah" };
> cqpid_perl::encode($hash, $outmsg);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



Perl bindings fix for 0.20

2012-11-28 Thread Jimmy Jones
Hi,

Would someone mind reviewing QPID-4480, and if possible including in 0.20? 
Using the perl bindings, when sending a amqp/map containing a string containing 
a null, its truncated at the first null. I've attached a simple patch that 
fixes this. I can't find any workaround apart from the patch.

Jimmy

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4462) SimpleLDAPAuthenticationManager does not register SASL mechanism PLAIN

2012-11-28 Thread Justin Ross (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505862#comment-13505862
 ] 

Justin Ross commented on QPID-4462:
---

Doc fix approved for 0.20.

> SimpleLDAPAuthenticationManager does not register SASL mechanism PLAIN
> --
>
> Key: QPID-4462
> URL: https://issues.apache.org/jira/browse/QPID-4462
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.18, 0.19, 0.20, 0.21
>Reporter: Keith Wall
>  Labels: LDAP
>
> If the user tries to configure only the simple-ldap-auth-manager, client see 
> the following exception on attempting to connect.
> {noformat}
> javax.jms.JMSException: Error creating connection: Error: Unable to create 
> SASL Server:PLAIN
>   at 
> org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:125)
>   at org.apache.qpid.example.Hello.runTest(Hello.java:51)
>   at org.apache.qpid.example.Hello.main(Hello.java:40)
> {noformat}
> The issue is that SimpleLDAPAuthenticationManager is omitting to register the 
> PLAIN SASL mechanism.
> The user can workaround the issue by configuring a plain pd-auth-manager, 
> (which causes the SASL mechanism to be registered) and specifying a 
> default-auth-manager of SimpleLDAPAuthenticationManager as illustrated below:
> {code}
> SimpleLDAPAuthenticationManager
> 
> 
> org.apache.qpid.server.security.auth.database.PlainPasswordFilePrincipalDatabase
> 
>
>  passwordFile
>  ${conf}/emptypasswd
>
> 
>   
> 
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4461) [Java broker] the qpid-server startup scripts logfile naming prefix and suffix configuration does not work

2012-11-28 Thread Robbie Gemmell (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505802#comment-13505802
 ] 

Robbie Gemmell commented on QPID-4461:
--

Now merged to the 0.20 release branch.

> [Java broker] the qpid-server startup scripts logfile naming prefix and 
> suffix configuration does not work
> --
>
> Key: QPID-4461
> URL: https://issues.apache.org/jira/browse/QPID-4461
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.18
>Reporter: Robbie Gemmell
>Assignee: Alex Rudyy
> Fix For: 0.20, 0.21
>
>
> The qpid-server startup scripts logfile naming prefix and suffix 
> configuration does not work. Setting the QPID_LOG_SUFFIX or QPID_LOG_PREFIX 
> environment variables means the script unable to start the broker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4474) ensure the BDBHAMessageStore JMX MBean name is quoted

2012-11-28 Thread Robbie Gemmell (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505798#comment-13505798
 ] 

Robbie Gemmell commented on QPID-4474:
--

Now merged to the 0.20 release branch.

> ensure the BDBHAMessageStore JMX MBean name is quoted
> -
>
> Key: QPID-4474
> URL: https://issues.apache.org/jira/browse/QPID-4474
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.18
>Reporter: Robbie Gemmell
>Assignee: Alex Rudyy
> Fix For: 0.20, 0.21
>
>
> Ensure the BDBHAMessageStore JMX MBean name is quoted. The name of the other 
> MBeans (Virtualhost, Queue, Exchange) are quoted to allow them to contain 
> names which cant be encoded in an JMX ObjectName without use of quotes. The 
> BDBHAMessageStore should also have its name quoted, for the same reasons and 
> also for consistency with the other MBeans.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4468) [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry

2012-11-28 Thread Robbie Gemmell (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505796#comment-13505796
 ] 

Robbie Gemmell commented on QPID-4468:
--

Now merged to the 0.20 release branch.

> [Java client] restore ability to enable SSL using a connection level option 
> rather than as a sub-option of each brokerlist entry
> 
>
> Key: QPID-4468
> URL: https://issues.apache.org/jira/browse/QPID-4468
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Client
>Affects Versions: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.20, 0.21
>
>
> On old client versions it was possible to specify that SSL should be used at 
> the connection level options. It is now only possible to specify this as part 
> of the brokerlist sub-options (in addition to much finer-grained control over 
> the keystores/truststores and certificates etc to be used). If you are just 
> using the SSL system properties to define they keystore/truststore etc and 
> have multiple brokers in the brokerlist it is actually more convenient to 
> specify ssl=true at the connection level.
> Restoring this will maintain compatibility for drop-in replacement of old 
> clients and also help prevent user confiusion resulting from the URL parsers 
> inability to alert them to the previous ssl configuration going unused.
> It will be restored as an ovveride of ssl option in the brokerlist entries.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-4469) [Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()

2012-11-28 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved QPID-4469.
--

Resolution: Fixed

Now merged to the 0.20 release branch.

> [Java common] remove unused sslContext parameter from 
> OutgoingNetworkTransport#connect()
> 
>
> Key: QPID-4469
> URL: https://issues.apache.org/jira/browse/QPID-4469
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Client, Java Common
>Affects Versions: 0.14, 0.16, 0.18
>Reporter: Robbie Gemmell
>Assignee: Rob Godfrey
> Fix For: 0.20, 0.21
>
>
> OutgoingNetworkTransport#connect() takes an sslContext parameter. This is 
> unused by the transport implementations because SSL is implemented in the 
> client as a wrapper over the transport. The 0-10 path of the client supplies 
> null for this arg, but the 08/0-9/0-9-1 patch still creates and supplies one. 
> The parameter should be removed to ensure consistency now and in the future.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4475) Web management plugin support for PLAIN SASL mechanism

2012-11-28 Thread Robbie Gemmell (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505783#comment-13505783
 ] 

Robbie Gemmell commented on QPID-4475:
--

Now merged to the 0.20 release branch.

> Web management plugin support for PLAIN SASL mechanism
> --
>
> Key: QPID-4475
> URL: https://issues.apache.org/jira/browse/QPID-4475
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Affects Versions: 0.21
>Reporter: Keith Wall
>Assignee: Rob Godfrey
> Fix For: 0.20, 0.21
>
>
> The web management module of the Java Broker should be enhanced to allow for 
> the use of the PLAIN SASL mechanism.  This would allow the web-management 
> module to be used with the SimpleLDAPAuthenticationManager (which requires 
> PLAIN as it must pass a clear-text password through to the LDAP server).
> If PLAIN is in-use, then the Broker should restrict the web management to a 
> secure protocol in order to avoid the transmision of user password in 
> clear-text across the wire.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4476) [Java broker] SimpleLDAPAuthenticationManager returns different Principal name formats for sasl vs non-sasl usage

2012-11-28 Thread Robbie Gemmell (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505778#comment-13505778
 ] 

Robbie Gemmell commented on QPID-4476:
--

Now merged to the 0.20 release branch.

> [Java broker] SimpleLDAPAuthenticationManager returns different Principal 
> name formats for sasl vs non-sasl usage
> -
>
> Key: QPID-4476
> URL: https://issues.apache.org/jira/browse/QPID-4476
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.18, 0.20
>Reporter: Robbie Gemmell
>Assignee: Rob Godfrey
> Fix For: 0.20, 0.21
>
>
> The SimpleLDAPAuthenticationManager returns different Principal name formats 
> for sasl vs non-sasl usage.
> In the sasl case, the PlainSaslServer returns the basic username that was 
> originally provided, but in the non-sasl case the 
> SimpleLDAPAuthenticationManager returns a Principal based on the search 
> context/filter. This leads to inconsistent behaviour between e.g. AMQP and 
> JMX interface authentication, and in the later case means it is not possible 
> to specify the user be included as part of an group.
> The non-sasl behaviour should be updated to be consistent with the sasl 
> behaviour.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4456) update the Java broker-only release package to account for changes in plugin system

2012-11-28 Thread Robbie Gemmell (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505773#comment-13505773
 ] 

Robbie Gemmell commented on QPID-4456:
--

Second commit now merged to the 0.20 release branch.


> update the Java broker-only release package to account for changes in plugin 
> system
> ---
>
> Key: QPID-4456
> URL: https://issues.apache.org/jira/browse/QPID-4456
> Project: Qpid
>  Issue Type: Task
>  Components: Packaging
>Affects Versions: 0.19
>Reporter: Robbie Gemmell
>Assignee: Keith Wall
>Priority: Blocker
> Fix For: 0.20
>
>
> Following the simplification of the plugin system in the Java broker via 
> QPID-4335 and the modifications to the tests in QPID-4353, the plugins are 
> not being packaged in the broker-only release binary (as per discussion on 
> QPID- just prior to the 0.20 beta).
> The build system should be updated to account for the changes and ensure the 
> plugins are again included.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4441) [Java broker] queue declare arguments are lost during v6 schema update for the optional bdbstore

2012-11-28 Thread Robbie Gemmell (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505769#comment-13505769
 ] 

Robbie Gemmell commented on QPID-4441:
--

The additional test changes have now been merged to the 0.20 release branch.

> [Java broker] queue declare arguments are lost during v6 schema update for 
> the optional bdbstore
> 
>
> Key: QPID-4441
> URL: https://issues.apache.org/jira/browse/QPID-4441
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.18
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
>Priority: Blocker
> Fix For: 0.19, 0.20
>
>
> The queue declare arguments are lost during v5 -> v6 store schema update for 
> the optional bdbstore. This will present itself in a variety of ways, such as 
> a DLQ losing the marker argument used to prevent chained DLQ creation, and 
> also in Priority and Sorted queues becoming regular queues.
> As part of the schema update, the old FieldTable binary encoding for the 
> queue arguments is transitioned to a property within the larger JSON 
> ConfiguredObject encoding. This process makes use of an intermediate 
> FieldTable to which it does an addAll() based copy of the original FieldTable 
> and then potentially adds a new description argument. This addAll() fails to 
> copy the previous properties due to a defect in the method, wherby the source 
> FieldTables lack of use after creation from encoded bytes means they have yet 
> to be decoded and this is in effect mistaken as it being an empty FieldTable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



Re: Yet more 0.20 inclusion requests

2012-11-28 Thread Robbie Gemmell
Thanks for approving those Justin, I will merge them shortly.

One more trivial request for inclusion in 0.20:
http://svn.apache.org/viewvc?rev=1414821&view=rev

It is a documentation-only change to include the workaround for QPID-4462
as part of the docs until we can actually fix it, which wont be in 0.20.

Robbie


On 27 November 2012 18:19, Robbie Gemmell  wrote:

> Hi Justin, I just have a few requests...sorry :)
>
> From previously:
> JIRA: https://issues.apache.org/jira/browse/QPID-4441
> Commit: http://svn.apache.org/viewvc?rev=1412203&view=rev
> Description: A test-only change to further confirm effectiveness of an
> earlier commit on the JIRA that was included on the branch since creation.
>
>
> New:
> JIRA: https://issues.apache.org/jira/browse/QPID-4456
> Commit: http://svn.apache.org/viewvc?rev=1413444&view=rev
> Description: ensure the qpid-server.bat script for windows picks up the
> broker plugins. Confined change, low risk, release blocker.
>
> JIRA: https://issues.apache.org/jira/browse/QPID-4476
> Commit: http://svn.apache.org/viewvc?rev=1414257&view=rev
> Description: Makes the LDAP authentication manger return a consistent
> UserPrincipal name on both authentication paths to allow consistent/any use
> of ACLs and groups. Confined change, low risk.
>
> JIRA: https://issues.apache.org/jira/browse/QPID-4475
> Commit: http://svn.apache.org/viewvc?rev=1414256&view=rev
> Description: enable the web management UI to support the PLAIN SASL
> mechanism required for logging in with the LDAP authentication manger.
> Confined change, low risk.
>
> JIRA: https://issues.apache.org/jira/browse/QPID-4468
> Commit: http://svn.apache.org/viewvc?rev=1413364&view=rev
> Description: restore connection level ssl option to provide compatibility
> with older client configuration. Fairly confined change, low risk.
>
> JIRA: https://issues.apache.org/jira/browse/QPID-4469
> Commit: http://svn.apache.org/viewvc?rev=1413363&view=rev
> Description: remove an unused method parameter. Trivial change, I'm only
> asking because leaving it out will generate conflicts for the above change.
>
> For the below requests the JIRAs have yet to be resolved, however Alex was
> pairing with me when they were done so they have been reviewed implicitly,
> he just hasnt had a chance to resolve them due to a short vacation. Could
> you look them over anyway? If you think them worthy I promise not to commit
> until he can update JIRAs tomorrow.
>
> JIRA: https://issues.apache.org/jira/browse/QPID-4474
> Commit: http://svn.apache.org/viewvc?rev=1413676&view=rev
> Description: Quote the name within the JMX ObjectName for the
> BDBHAMessageStore MBean, to allow for characters that are illegal in
> unquoted ObjectNames and for consistency with all the other MBeans.
> Confined changed, low risk.
>
> JIRA: https://issues.apache.org/jira/browse/QPID-4461
> Commit: http://svn.apache.org/viewvc?rev=1412822&view=rev
> Description: remove some spaces to ensure that options are passed
> correctly following a previous change, allowing the broker to start if they
> are used. Confined change, low risk.
>
> Thanks,
> Robbie
>


[jira] [Commented] (QPID-4462) SimpleLDAPAuthenticationManager does not register SASL mechanism PLAIN

2012-11-28 Thread Robbie Gemmell (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505663#comment-13505663
 ] 

Robbie Gemmell commented on QPID-4462:
--

I have added the workaround to the documentation until this issue is resolved:
http://svn.apache.org/viewvc?view=revision&revision=1414821

> SimpleLDAPAuthenticationManager does not register SASL mechanism PLAIN
> --
>
> Key: QPID-4462
> URL: https://issues.apache.org/jira/browse/QPID-4462
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.18, 0.19, 0.20, 0.21
>Reporter: Keith Wall
>  Labels: LDAP
>
> If the user tries to configure only the simple-ldap-auth-manager, client see 
> the following exception on attempting to connect.
> {noformat}
> javax.jms.JMSException: Error creating connection: Error: Unable to create 
> SASL Server:PLAIN
>   at 
> org.apache.qpid.client.AMQConnectionFactory.createConnection(AMQConnectionFactory.java:125)
>   at org.apache.qpid.example.Hello.runTest(Hello.java:51)
>   at org.apache.qpid.example.Hello.main(Hello.java:40)
> {noformat}
> The issue is that SimpleLDAPAuthenticationManager is omitting to register the 
> PLAIN SASL mechanism.
> The user can workaround the issue by configuring a plain pd-auth-manager, 
> (which causes the SASL mechanism to be registered) and specifying a 
> default-auth-manager of SimpleLDAPAuthenticationManager as illustrated below:
> {code}
> SimpleLDAPAuthenticationManager
> 
> 
> org.apache.qpid.server.security.auth.database.PlainPasswordFilePrincipalDatabase
> 
>
>  passwordFile
>  ${conf}/emptypasswd
>
> 
>   
> 
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4475) Web management plugin support for PLAIN SASL mechanism

2012-11-28 Thread Justin Ross (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505635#comment-13505635
 ] 

Justin Ross commented on QPID-4475:
---

Reviewed by Rob.  Approved for 0.20.

> Web management plugin support for PLAIN SASL mechanism
> --
>
> Key: QPID-4475
> URL: https://issues.apache.org/jira/browse/QPID-4475
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Affects Versions: 0.21
>Reporter: Keith Wall
>Assignee: Rob Godfrey
> Fix For: 0.20, 0.21
>
>
> The web management module of the Java Broker should be enhanced to allow for 
> the use of the PLAIN SASL mechanism.  This would allow the web-management 
> module to be used with the SimpleLDAPAuthenticationManager (which requires 
> PLAIN as it must pass a clear-text password through to the LDAP server).
> If PLAIN is in-use, then the Broker should restrict the web management to a 
> secure protocol in order to avoid the transmision of user password in 
> clear-text across the wire.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-4475) Web management plugin support for PLAIN SASL mechanism

2012-11-28 Thread Justin Ross (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Ross updated QPID-4475:
--

Fix Version/s: 0.21
   0.20

> Web management plugin support for PLAIN SASL mechanism
> --
>
> Key: QPID-4475
> URL: https://issues.apache.org/jira/browse/QPID-4475
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Affects Versions: 0.21
>Reporter: Keith Wall
>Assignee: Rob Godfrey
> Fix For: 0.20, 0.21
>
>
> The web management module of the Java Broker should be enhanced to allow for 
> the use of the PLAIN SASL mechanism.  This would allow the web-management 
> module to be used with the SimpleLDAPAuthenticationManager (which requires 
> PLAIN as it must pass a clear-text password through to the LDAP server).
> If PLAIN is in-use, then the Broker should restrict the web management to a 
> secure protocol in order to avoid the transmision of user password in 
> clear-text across the wire.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



Re: New Perl bindings committed

2012-11-28 Thread Andrew Stitcher
On Wed, 2012-11-28 at 16:05 +, Robbie Gemmell wrote:
> The CI job (https://builds.apache.org/job/Qpid-Java-Cpp-Test/) still
> doesn't seem to be very happy. Is there anything needing done to cleanup
> from the previous issue?
> 
> 
> make[1]: Entering directory `<
> https://builds.apache.org/job/Qpid-Java-Cpp-Test/ws/trunk/qpid/cpp/managementgen
> '>
> make[1]: Nothing to be done for `all'.
> make[1]: Leaving directory `<
> https://builds.apache.org/job/Qpid-Java-Cpp-Test/ws/trunk/qpid/cpp/managementgen
> '>
> Making all in etc
> make[1]: Entering directory `<
> https://builds.apache.org/job/Qpid-Java-Cpp-Test/ws/trunk/qpid/cpp/etc'>
> sed "s|!!sysconfdir!!|/usr/local/
> etc|;s|!!sbindir!!|/usr/local/sbin|;s|!!bindir!!|/usr/local/bin|"
> qpidd.in> qpidd
> sed
> "s|!!sysconfdir!!|/usr/local/etc|;s|!!sbindir!!|/usr/local/sbin|;s|!!bindir!!|/usr/local/bin|"
> qpidd-primary.in > qpidd-primary
> make[1]: *** No rule to make target `qpidd.service', needed by `all-am'.
>  Stop.
> make[1]: *** Waiting for unfinished jobs
> make[1]: Leaving directory `<
> https://builds.apache.org/job/Qpid-Java-Cpp-Test/ws/trunk/qpid/cpp/etc'>
> make: *** [all-recursive] Error 1
> 

I think this derives from a change that came after the changes I fixed,
so I did not fix it. Also I was fixing failures for a pure "make" and I
think this failure is from "make install"

The error I'm now getting is a little bit different:

 /usr/bin/mkdir -p '/usr/lib/systemd/system'
 /usr/bin/install -c ../../src-released/qpid/cpp/etc/qpidd.service
'/usr/lib/systemd/system'
/usr/bin/install: cannot create regular file
`/usr/lib/systemd/system/qpidd.service': Permission denied
make[2]: *** [install-nobase_systemdSCRIPTS] Error 1
make[2]: Leaving directory `/home/andrew/Work/qpid/blda-released/etc'
make[1]: *** [install-am] Error 2
make[1]: Leaving directory `/home/andrew/Work/qpid/blda-released/etc'
make: *** [install-recursive] Error 1

But might be the same underlying cause - the install is now not
respecting --prefix.

Andrew



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-4474) ensure the BDBHAMessageStore JMX MBean name is quoted

2012-11-28 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy resolved QPID-4474.
--

Resolution: Fixed

The changes look good for me.

> ensure the BDBHAMessageStore JMX MBean name is quoted
> -
>
> Key: QPID-4474
> URL: https://issues.apache.org/jira/browse/QPID-4474
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.18
>Reporter: Robbie Gemmell
>Assignee: Alex Rudyy
> Fix For: 0.20, 0.21
>
>
> Ensure the BDBHAMessageStore JMX MBean name is quoted. The name of the other 
> MBeans (Virtualhost, Queue, Exchange) are quoted to allow them to contain 
> names which cant be encoded in an JMX ObjectName without use of quotes. The 
> BDBHAMessageStore should also have its name quoted, for the same reasons and 
> also for consistency with the other MBeans.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-4461) [Java broker] the qpid-server startup scripts logfile naming prefix and suffix configuration does not work

2012-11-28 Thread Alex Rudyy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy resolved QPID-4461.
--

Resolution: Fixed

The changes look good for me.

> [Java broker] the qpid-server startup scripts logfile naming prefix and 
> suffix configuration does not work
> --
>
> Key: QPID-4461
> URL: https://issues.apache.org/jira/browse/QPID-4461
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.18
>Reporter: Robbie Gemmell
>Assignee: Alex Rudyy
> Fix For: 0.20, 0.21
>
>
> The qpid-server startup scripts logfile naming prefix and suffix 
> configuration does not work. Setting the QPID_LOG_SUFFIX or QPID_LOG_PREFIX 
> environment variables means the script unable to start the broker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4388) Systemd support not being installed with Cmake

2012-11-28 Thread Justin Ross (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505603#comment-13505603
 ] 

Justin Ross commented on QPID-4388:
---

Andrew, please review.

> Systemd support not being installed with Cmake
> --
>
> Key: QPID-4388
> URL: https://issues.apache.org/jira/browse/QPID-4388
> Project: Qpid
>  Issue Type: Bug
>Affects Versions: 0.19
>Reporter: Darryl L. Pierce
>Assignee: Andrew Stitcher
> Fix For: 0.21
>
> Attachments: 
> 0001-QPID-4388-Systemd-support-not-being-installed-with-C.patch
>
>
> The enhancement for systemd support was added to the autotools build system 
> but not the Cmake system in QPID-4351.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (QPID-4388) Systemd support not being installed with Cmake

2012-11-28 Thread Justin Ross (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Ross reassigned QPID-4388:
-

Assignee: Andrew Stitcher

> Systemd support not being installed with Cmake
> --
>
> Key: QPID-4388
> URL: https://issues.apache.org/jira/browse/QPID-4388
> Project: Qpid
>  Issue Type: Bug
>Affects Versions: 0.19
>Reporter: Darryl L. Pierce
>Assignee: Andrew Stitcher
> Fix For: 0.21
>
> Attachments: 
> 0001-QPID-4388-Systemd-support-not-being-installed-with-C.patch
>
>
> The enhancement for systemd support was added to the autotools build system 
> but not the Cmake system in QPID-4351.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



Re: New Perl bindings committed

2012-11-28 Thread Robbie Gemmell
The CI job (https://builds.apache.org/job/Qpid-Java-Cpp-Test/) still
doesn't seem to be very happy. Is there anything needing done to cleanup
from the previous issue?


make[1]: Entering directory `<
https://builds.apache.org/job/Qpid-Java-Cpp-Test/ws/trunk/qpid/cpp/managementgen
'>
make[1]: Nothing to be done for `all'.
make[1]: Leaving directory `<
https://builds.apache.org/job/Qpid-Java-Cpp-Test/ws/trunk/qpid/cpp/managementgen
'>
Making all in etc
make[1]: Entering directory `<
https://builds.apache.org/job/Qpid-Java-Cpp-Test/ws/trunk/qpid/cpp/etc'>
sed "s|!!sysconfdir!!|/usr/local/
etc|;s|!!sbindir!!|/usr/local/sbin|;s|!!bindir!!|/usr/local/bin|"
qpidd.in> qpidd
sed
"s|!!sysconfdir!!|/usr/local/etc|;s|!!sbindir!!|/usr/local/sbin|;s|!!bindir!!|/usr/local/bin|"
qpidd-primary.in > qpidd-primary
make[1]: *** No rule to make target `qpidd.service', needed by `all-am'.
 Stop.
make[1]: *** Waiting for unfinished jobs
make[1]: Leaving directory `<
https://builds.apache.org/job/Qpid-Java-Cpp-Test/ws/trunk/qpid/cpp/etc'>
make: *** [all-recursive] Error 1



On 28 November 2012 15:07, Andrew Stitcher  wrote:

> On Tue, 2012-11-27 at 13:32 -0500, Darryl L. Pierce wrote:
> > I've pushed the new Qpid Perl bindings to master today. This newer
> > binding layer more closely matches what's defined in the C++ layer.
> >
> > The namespace for each class is qpid::messaging and the class names are
> > a 1:1 match to what's in C++. The method names as well, with underscore
> > case replacing camel case, which is more intuitive for dynamic
> > languages.
> >
> > Also updated are the Perl examples, which now use the updated APIs.
>
> Can I point out that somewhere in the changes you just made you broke
> the build for the bindings for both the cmake and autotools builds. I
> checked in a fix for this now, could you be more careful next time?
>
> (I will admit that this is pot calling kettle black, but still...)
>
> Andrew
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
> For additional commands, e-mail: dev-h...@qpid.apache.org
>
>


[jira] [Commented] (QPID-4472) NPE when connecting over AMQP 1.0 with no SASL layer

2012-11-28 Thread Justin Ross (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505595#comment-13505595
 ] 

Justin Ross commented on QPID-4472:
---

Approved for 0.20.

> NPE when connecting over AMQP 1.0 with no SASL layer
> 
>
> Key: QPID-4472
> URL: https://issues.apache.org/jira/browse/QPID-4472
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.20
>Reporter: Gordon Sim
> Fix For: 0.20, 0.21
>
>
> In doing some interop testing, I ran the c++ client (qpid::messaging) against 
> the java broker without a SASL layer, triggering a NullPointerException and 
> broker shutdown:
> {noformat}
> [Broker] BRK-1004 : Qpid Broker Ready
> java.lang.NullPointerException
>   at 
> org.apache.qpid.server.protocol.ProtocolEngine_1_0_0.received(ProtocolEngine_1_0_0.java:280)
>   at 
> org.apache.qpid.server.protocol.ProtocolEngine_1_0_0.received(ProtocolEngine_1_0_0.java:49)
>   at 
> org.apache.qpid.server.protocol.MultiVersionProtocolEngine$SelfDelegateProtocolEngine.received(MultiVersionProtocolEngine.java:556)
>   at 
> org.apache.qpid.server.protocol.MultiVersionProtocolEngine$SelfDelegateProtocolEngine.received(MultiVersionProtocolEngine.java:442)
>   at 
> org.apache.qpid.server.protocol.MultiVersionProtocolEngine.received(MultiVersionProtocolEngine.java:118)
>   at 
> org.apache.qpid.server.protocol.MultiVersionProtocolEngine.received(MultiVersionProtocolEngine.java:37)
>   at 
> org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:161)
>   at java.lang.Thread.run(Thread.java:722)
> 
> #
> # Unhandled Exception java.lang.NullPointerException in Thread IoReceiver - 
> /127.0.0.1:59542
> #
> # Exiting
> #
> 
> java.lang.NullPointerException
>   at 
> org.apache.qpid.server.protocol.ProtocolEngine_1_0_0.closed(ProtocolEngine_1_0_0.java:293)
>   at 
> org.apache.qpid.server.protocol.MultiVersionProtocolEngine.closed(MultiVersionProtocolEngine.java:102)
>   at 
> org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:222)
>   at java.lang.Thread.run(Thread.java:722)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-4472) NPE when connecting over AMQP 1.0 with no SASL layer

2012-11-28 Thread Justin Ross (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Ross updated QPID-4472:
--

Fix Version/s: 0.21
   0.20

> NPE when connecting over AMQP 1.0 with no SASL layer
> 
>
> Key: QPID-4472
> URL: https://issues.apache.org/jira/browse/QPID-4472
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.20
>Reporter: Gordon Sim
> Fix For: 0.20, 0.21
>
>
> In doing some interop testing, I ran the c++ client (qpid::messaging) against 
> the java broker without a SASL layer, triggering a NullPointerException and 
> broker shutdown:
> {noformat}
> [Broker] BRK-1004 : Qpid Broker Ready
> java.lang.NullPointerException
>   at 
> org.apache.qpid.server.protocol.ProtocolEngine_1_0_0.received(ProtocolEngine_1_0_0.java:280)
>   at 
> org.apache.qpid.server.protocol.ProtocolEngine_1_0_0.received(ProtocolEngine_1_0_0.java:49)
>   at 
> org.apache.qpid.server.protocol.MultiVersionProtocolEngine$SelfDelegateProtocolEngine.received(MultiVersionProtocolEngine.java:556)
>   at 
> org.apache.qpid.server.protocol.MultiVersionProtocolEngine$SelfDelegateProtocolEngine.received(MultiVersionProtocolEngine.java:442)
>   at 
> org.apache.qpid.server.protocol.MultiVersionProtocolEngine.received(MultiVersionProtocolEngine.java:118)
>   at 
> org.apache.qpid.server.protocol.MultiVersionProtocolEngine.received(MultiVersionProtocolEngine.java:37)
>   at 
> org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:161)
>   at java.lang.Thread.run(Thread.java:722)
> 
> #
> # Unhandled Exception java.lang.NullPointerException in Thread IoReceiver - 
> /127.0.0.1:59542
> #
> # Exiting
> #
> 
> java.lang.NullPointerException
>   at 
> org.apache.qpid.server.protocol.ProtocolEngine_1_0_0.closed(ProtocolEngine_1_0_0.java:293)
>   at 
> org.apache.qpid.server.protocol.MultiVersionProtocolEngine.closed(MultiVersionProtocolEngine.java:102)
>   at 
> org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:222)
>   at java.lang.Thread.run(Thread.java:722)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



Re: New Perl bindings committed

2012-11-28 Thread Darryl L. Pierce
On Wed, Nov 28, 2012 at 10:07:06AM -0500, Andrew Stitcher wrote:
> Can I point out that somewhere in the changes you just made you broke
> the build for the bindings for both the cmake and autotools builds. I
> checked in a fix for this now, could you be more careful next time?
> 
> (I will admit that this is pot calling kettle black, but still...)

My apologies.

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/



pgpthJwh7oCGq.pgp
Description: PGP signature


[jira] [Updated] (QPID-2796) [Java] implement support for heartbeats following IO changes to the 0-8/0-9/0-9-1/0-10 broker and 0-8/0-9/0-9-1 client

2012-11-28 Thread Justin Ross (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Ross updated QPID-2796:
--

Fix Version/s: 0.20

> [Java] implement support for heartbeats following IO changes to the 
> 0-8/0-9/0-9-1/0-10 broker and 0-8/0-9/0-9-1 client
> --
>
> Key: QPID-2796
> URL: https://issues.apache.org/jira/browse/QPID-2796
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker, Java Client
>Affects Versions: 0.15
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.20, 0.21
>
>
> The Java broker and client are not able to generate AMQP heartbeats following 
> the updates to their IO layer. The 0-8/0-9/0-9-1 codepaths previously relied 
> on the Mina IO layer to support this, and as such can no longer do so. The 
> 0-10 path of the Java broker leverages much of the 0-10 implementation in 
> common originally developed for the 0-10 Java client, which simply reflects 
> heartbeats it receives from a broker and as such no heartbeats will ever be 
> sent by broker or the client despite its support.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-2796) [Java] implement support for heartbeats following IO changes to the 0-8/0-9/0-9-1/0-10 broker and 0-8/0-9/0-9-1 client

2012-11-28 Thread Justin Ross (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505566#comment-13505566
 ] 

Justin Ross commented on QPID-2796:
---

Reviewed by Robbie.  Approved for 0.20.

> [Java] implement support for heartbeats following IO changes to the 
> 0-8/0-9/0-9-1/0-10 broker and 0-8/0-9/0-9-1 client
> --
>
> Key: QPID-2796
> URL: https://issues.apache.org/jira/browse/QPID-2796
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker, Java Client
>Affects Versions: 0.15
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.20, 0.21
>
>
> The Java broker and client are not able to generate AMQP heartbeats following 
> the updates to their IO layer. The 0-8/0-9/0-9-1 codepaths previously relied 
> on the Mina IO layer to support this, and as such can no longer do so. The 
> 0-10 path of the Java broker leverages much of the 0-10 implementation in 
> common originally developed for the 0-10 Java client, which simply reflects 
> heartbeats it receives from a broker and as such no heartbeats will ever be 
> sent by broker or the client despite its support.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



Re: New Perl bindings committed

2012-11-28 Thread Andrew Stitcher
On Tue, 2012-11-27 at 13:32 -0500, Darryl L. Pierce wrote:
> I've pushed the new Qpid Perl bindings to master today. This newer
> binding layer more closely matches what's defined in the C++ layer.
> 
> The namespace for each class is qpid::messaging and the class names are
> a 1:1 match to what's in C++. The method names as well, with underscore
> case replacing camel case, which is more intuitive for dynamic
> languages.
> 
> Also updated are the Perl examples, which now use the updated APIs.

Can I point out that somewhere in the changes you just made you broke
the build for the bindings for both the cmake and autotools builds. I
checked in a fix for this now, could you be more careful next time?

(I will admit that this is pot calling kettle black, but still...)

Andrew



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



Re: New Perl bindings committed

2012-11-28 Thread Gordon Sim

On 11/27/2012 06:32 PM, Darryl L. Pierce wrote:

I've pushed the new Qpid Perl bindings to master today. This newer
binding layer more closely matches what's defined in the C++ layer.

The namespace for each class is qpid::messaging and the class names are
a 1:1 match to what's in C++. The method names as well, with underscore
case replacing camel case, which is more intuitive for dynamic
languages.

Also updated are the Perl examples, which now use the updated APIs.


Information concerning APIs, examples etc should really be posted on the 
user list.


-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



Re: 0.20 request roundup

2012-11-28 Thread Gordon Sim

On 11/27/2012 08:42 PM, Gordon Sim wrote:

On 11/27/2012 06:29 PM, Justin Ross wrote:

On Tue, 27 Nov 2012, Gordon Sim wrote:


On 11/26/2012 08:12 PM, Justin Ross wrote:

  - Gordon
- https://issues.apache.org/jira/browse/QPID-4448
  - http://svn.apache.org/viewvc?rev=1412239&view=rev
- Out for review, Andrew

- Now approved

- https://issues.apache.org/jira/browse/QPID-4451
  - http://svn.apache.org/viewvc?rev=1412241&view=rev
- Approved
- https://issues.apache.org/jira/browse/QPID-4452
  - http://svn.apache.org/viewvc?rev=1412242&view=rev
- Approved
- https://issues.apache.org/jira/browse/QPID-4459
  - http://svn.apache.org/viewvc?rev=1412960&view=rev
- Approved
- https://issues.apache.org/jira/browse/QPID-4460
  - http://svn.apache.org/viewvc?rev=1412961&view=rev
- Approved
- https://issues.apache.org/jira/browse/QPID-4464
  - http://svn.apache.org/viewvc?rev=1412962&view=rev
- Approved
- https://issues.apache.org/jira/browse/QPID-4465
  - http://svn.apache.org/viewvc?rev=1412963&view=rev
- Approved


Thanks, Justin! One more request, to allow better interop between the
c++ implementation of qpid::messaging and messenger:

https://issues.apache.org/jira/browse/QPID-4477

committed to trunk: http://svn.apache.org/viewvc?rev=1414227&view=rev

Again, this only affects 1.0 code so has zero impact on anything else.


Thanks, Gordon.  Approved.


Thanks again... one more small one if you don't mind (literally one
line, and a short one at that :-)

https://issues.apache.org/jira/browse/QPID-4478: wakeup driver after
setting credit

http://svn.apache.org/viewvc?rev=1414291&view=rev


I saw the approval message for this in the JIRA, thanks again! These are 
all now committed on the 0.20 branch.



-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-4368) Add AMQP 1.0 Support

2012-11-28 Thread Gordon Sim (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved QPID-4368.
--

   Resolution: Fixed
Fix Version/s: (was: 0.19)
   0.20

Will close this issue and track enhancements and defects via more specific 
JIRAs.

> Add AMQP 1.0 Support
> 
>
> Key: QPID-4368
> URL: https://issues.apache.org/jira/browse/QPID-4368
> Project: Qpid
>  Issue Type: Improvement
>  Components: C++ Broker, C++ Client
>Reporter: Gordon Sim
>Assignee: Gordon Sim
> Fix For: 0.20
>
> Attachments: 
> 0001-QPID-4368-Read-any-extra-data-available-after-protoc.patch, 
> 0002-QPID-4368-Make-security-strength-factor-a-property-o.patch, 
> 0003-QPID-4368-Add-protocol-description-to-connection-sch.patch, 
> 0004-QPID-4368-Updated-protocol-version-header-handling-t.patch, 
> 0005-QPID-4368-Define-SASL-server-role-that-is-free-from-.patch, 
> 0006-QPID-4368-Allow-pluggable-protocol-implementations.patch, 
> 0007-QPID-4368-Allow-pluggable-protocol-implementation-to.patch, 
> 0008-QPID-4368-Pluggable-AMQP-1.0-implementation-for-brok.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-4448) Credit checking messages for sending on 0-10 of messages from 1.0 results in seg fault

2012-11-28 Thread Gordon Sim (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved QPID-4448.
--

   Resolution: Fixed
Fix Version/s: (was: 0.19)

Applied on branch: http://svn.apache.org/viewvc?rev=1414714&view=rev

> Credit checking messages for sending on 0-10 of messages from 1.0 results in 
> seg fault
> --
>
> Key: QPID-4448
> URL: https://issues.apache.org/jira/browse/QPID-4448
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: 0.19
>Reporter: Gordon Sim
>Assignee: Andrew Stitcher
> Fix For: 0.20
>
>
> thus restricting 1.0->0-10 interop

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-4477) Need to handle case where outcome is issued by peer before init has been sent

2012-11-28 Thread Gordon Sim (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved QPID-4477.
--

Resolution: Fixed

Applied on branch: http://svn.apache.org/viewvc?rev=1414712&view=rev

> Need to handle case where outcome is issued by peer before init has been sent
> -
>
> Key: QPID-4477
> URL: https://issues.apache.org/jira/browse/QPID-4477
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.20
>Reporter: Gordon Sim
>Assignee: Gordon Sim
> Fix For: 0.20, 0.21
>
>
> This is needed when connecting to a messenger listening on a socket as it 
> assumes ANONYMOUS and issues positive outcome automatically.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-4478) AMQP 1.0: flow is occasionally not sent when setting capacity

2012-11-28 Thread Gordon Sim (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved QPID-4478.
--

   Resolution: Fixed
Fix Version/s: (was: 0.21)

Applied on branch: http://svn.apache.org/viewvc?rev=1414713&view=rev

> AMQP 1.0: flow is occasionally not sent when setting capacity
> -
>
> Key: QPID-4478
> URL: https://issues.apache.org/jira/browse/QPID-4478
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.20
>Reporter: Gordon Sim
>Assignee: Gordon Sim
> Fix For: 0.20
>
>
> This is due to not waking up the driver thread to handle the IO.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-4465) only send subject filter if subject is specified

2012-11-28 Thread Gordon Sim (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved QPID-4465.
--

Resolution: Fixed

Applied on branch: http://svn.apache.org/viewvc?rev=1414711&view=rev

> only send subject filter if subject is specified
> 
>
> Key: QPID-4465
> URL: https://issues.apache.org/jira/browse/QPID-4465
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.20
>Reporter: Gordon Sim
>Assignee: Gordon Sim
> Fix For: 0.20
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-4464) broker does not set container name on AMQP 1.0 connection open

2012-11-28 Thread Gordon Sim (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved QPID-4464.
--

Resolution: Fixed

Applied on branch: http://svn.apache.org/viewvc?rev=1414710&view=rev

> broker does not set container name on AMQP 1.0 connection open
> --
>
> Key: QPID-4464
> URL: https://issues.apache.org/jira/browse/QPID-4464
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker
>Affects Versions: 0.20
>Reporter: Gordon Sim
>Assignee: Gordon Sim
> Fix For: 0.20
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-4460) after drain, full credit is not replenished

2012-11-28 Thread Gordon Sim (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved QPID-4460.
--

Resolution: Fixed

Applied on branch: http://svn.apache.org/viewvc?rev=1414708&view=rev

> after drain, full credit is not replenished
> ---
>
> Key: QPID-4460
> URL: https://issues.apache.org/jira/browse/QPID-4460
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.20
>Reporter: Gordon Sim
>Assignee: Gordon Sim
> Fix For: 0.20
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-4459) Sender doesn't settle messages

2012-11-28 Thread Gordon Sim (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved QPID-4459.
--

Resolution: Fixed

Applied on branch: http://svn.apache.org/viewvc?rev=1414707&view=rev

> Sender doesn't settle messages
> --
>
> Key: QPID-4459
> URL: https://issues.apache.org/jira/browse/QPID-4459
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.20
>Reporter: Gordon Sim
>Assignee: Gordon Sim
> Fix For: 0.20
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-4452) issuing and handling of producer credit not implemented

2012-11-28 Thread Gordon Sim (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved QPID-4452.
--

Resolution: Fixed

Fixed on branch: http://svn.apache.org/viewvc?rev=1414706&view=rev

> issuing and handling of producer credit not implemented
> ---
>
> Key: QPID-4452
> URL: https://issues.apache.org/jira/browse/QPID-4452
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Broker, C++ Client
>Affects Versions: 0.20
>Reporter: Gordon Sim
>Assignee: Gordon Sim
> Fix For: 0.20
>
>
> Prevents proper stress testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-4451) Need to wait for outgoing messages to settle when calling Connection::close()

2012-11-28 Thread Gordon Sim (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved QPID-4451.
--

Resolution: Fixed

applied on branch: http://svn.apache.org/viewvc?rev=1414705&view=rev
applied on trunk: http://svn.apache.org/viewvc?rev=1412241&view=rev 

> Need to wait for outgoing messages to settle when calling Connection::close()
> -
>
> Key: QPID-4451
> URL: https://issues.apache.org/jira/browse/QPID-4451
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.20
>Reporter: Gordon Sim
>Assignee: Gordon Sim
> Fix For: 0.20
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-4478) AMQP 1.0: flow is occasionally not sent when setting capacity

2012-11-28 Thread Justin Ross (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Ross updated QPID-4478:
--

Fix Version/s: 0.21

> AMQP 1.0: flow is occasionally not sent when setting capacity
> -
>
> Key: QPID-4478
> URL: https://issues.apache.org/jira/browse/QPID-4478
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.20
>Reporter: Gordon Sim
>Assignee: Gordon Sim
> Fix For: 0.20, 0.21
>
>
> This is due to not waking up the driver thread to handle the IO.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4478) AMQP 1.0: flow is occasionally not sent when setting capacity

2012-11-28 Thread Justin Ross (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505426#comment-13505426
 ] 

Justin Ross commented on QPID-4478:
---

A trivial change confined to the 1.0 impl.  Approved for 0.20.

> AMQP 1.0: flow is occasionally not sent when setting capacity
> -
>
> Key: QPID-4478
> URL: https://issues.apache.org/jira/browse/QPID-4478
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.20
>Reporter: Gordon Sim
>Assignee: Gordon Sim
> Fix For: 0.20, 0.21
>
>
> This is due to not waking up the driver thread to handle the IO.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4215) Provide necessary files for creating an upstream source tarball for the Perl language bindings.

2012-11-28 Thread Darryl L. Pierce (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505425#comment-13505425
 ] 

Darryl L. Pierce commented on QPID-4215:


An additional commit (marked NO-JIRA) fixes a typo in this.

http://svn.apache.org/viewvc?view=revision&revision=1414355

> Provide necessary files for creating an upstream source tarball for the Perl 
> language bindings.
> ---
>
> Key: QPID-4215
> URL: https://issues.apache.org/jira/browse/QPID-4215
> Project: Qpid
>  Issue Type: Sub-task
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: 0.21
>
> Attachments: 
> 0005-Adds-a-target-to-release.sh-to-generate-Perl-languag.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-4477) Need to handle case where outcome is issued by peer before init has been sent

2012-11-28 Thread Justin Ross (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Ross updated QPID-4477:
--

Fix Version/s: 0.21

> Need to handle case where outcome is issued by peer before init has been sent
> -
>
> Key: QPID-4477
> URL: https://issues.apache.org/jira/browse/QPID-4477
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.20
>Reporter: Gordon Sim
>Assignee: Gordon Sim
> Fix For: 0.20, 0.21
>
>
> This is needed when connecting to a messenger listening on a socket as it 
> assumes ANONYMOUS and issues positive outcome automatically.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4477) Need to handle case where outcome is issued by peer before init has been sent

2012-11-28 Thread Justin Ross (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505420#comment-13505420
 ] 

Justin Ross commented on QPID-4477:
---

http://svn.apache.org/viewvc?view=revision&revision=1414227

> Need to handle case where outcome is issued by peer before init has been sent
> -
>
> Key: QPID-4477
> URL: https://issues.apache.org/jira/browse/QPID-4477
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.20
>Reporter: Gordon Sim
>Assignee: Gordon Sim
> Fix For: 0.20, 0.21
>
>
> This is needed when connecting to a messenger listening on a socket as it 
> assumes ANONYMOUS and issues positive outcome automatically.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4479) spout/drain examples fixes and improvements

2012-11-28 Thread Justin Ross (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505419#comment-13505419
 ] 

Justin Ross commented on QPID-4479:
---

This change was codeveloped by Petr Matousek and Darryl.  Approved for 0.20.

For the discussion, see https://bugzilla.redhat.com/show_bug.cgi?id=878940 .

> spout/drain examples fixes and improvements
> ---
>
> Key: QPID-4479
> URL: https://issues.apache.org/jira/browse/QPID-4479
> Project: Qpid
>  Issue Type: Improvement
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
>Priority: Minor
> Fix For: 0.20, 0.21
>
>
> (From BZ#878940)
> Description of problem:
> It is unable to set message properties with spout.pl, following change needs 
> to be made to fix this issue:
>   - $message->getProperties()->{$name} = $value;
>   + $message->setProperty($name, $value);
> Below are proposed changes to the spout/drain examples to be more conformable 
> to other clients (c++, python, java), I think it is valuable to have all the 
> client examples working the same way:
> Patch files for both spout.pl/drain.pl can be found in attachment.
> * drain.pl *:
> Drain do not output the message properties in usable form (properties are 
> displayed as a hash), ie:
> # perl /usr/share/doc/perl-qpid-0.18/examples/drain.pl -c 1 q
> Message(properties=HASH(0x8f1ecc8),content='')
> It also can be useful to display if the message is redelivered as other 
> clients do.
> Proposing following change to fix these issues:
>   +sub printProperties {
>   +  my $h = shift();
>   +  return qq[{${\(join', ',map"'$_': '$h->{$_}'",keys%$h)}}]
>   +}
>   - print "Message(properties=" . $message->getProperties() . ",content='";
>   + my $redelivered = ($message->getRedelivered) ? "redelivered=True, " : "";
>   + print "Message(" . $redelivered . "properties=" . 
> printProperties($message->getProperties()) . ", content='";
> Proposing to set default timeout to 0 (to be more conformable to other 
> clients):
>   - my $timeout = 60;
>   + my $timeout = 0;
> Proposing to set default messages count to 0 (to be more conformable to other 
> clients)
>   - my $count   = 1;
>   + my $count   = 0;
> * both spout.pl/drain.pl *:
> It is good practise to output usage with -h/--help options, or if the input 
> is wrong. It is also in place to stop the program execution after the bad 
> input/help request.
> Proposing following change:
>   -"connection-options=s" => \ $connectionOptions,   
>   -);
>   -
>   -
>   -if (! $result) {
>   -print "Usage: perl drain.pl [OPTIONS]\n";
>   -}
>   -
>   +"connection-options=s" => \ $connectionOptions,
>   +"help|h"   => \ &usage
>   +) or usage();
>   +sub usage {
>   +print "Usage: perl drain.pl [OPTIONS]\n";
>   +exit;
>   +}
> Version-Release number of selected component (if applicable):
> perl-qpid-0.18-1.el6
> Actual results:
> Unable to set message properties with spout.pl, spout/drain behaviour differs 
> from other clients (c++,py,java)
> Expected results:
> Message properties can be set using spout.pl, spout/drain behaviour more 
> concords to other clients

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-4479) spout/drain examples fixes and improvements

2012-11-28 Thread Justin Ross (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Ross updated QPID-4479:
--

Fix Version/s: 0.21

> spout/drain examples fixes and improvements
> ---
>
> Key: QPID-4479
> URL: https://issues.apache.org/jira/browse/QPID-4479
> Project: Qpid
>  Issue Type: Improvement
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
>Priority: Minor
> Fix For: 0.20, 0.21
>
>
> (From BZ#878940)
> Description of problem:
> It is unable to set message properties with spout.pl, following change needs 
> to be made to fix this issue:
>   - $message->getProperties()->{$name} = $value;
>   + $message->setProperty($name, $value);
> Below are proposed changes to the spout/drain examples to be more conformable 
> to other clients (c++, python, java), I think it is valuable to have all the 
> client examples working the same way:
> Patch files for both spout.pl/drain.pl can be found in attachment.
> * drain.pl *:
> Drain do not output the message properties in usable form (properties are 
> displayed as a hash), ie:
> # perl /usr/share/doc/perl-qpid-0.18/examples/drain.pl -c 1 q
> Message(properties=HASH(0x8f1ecc8),content='')
> It also can be useful to display if the message is redelivered as other 
> clients do.
> Proposing following change to fix these issues:
>   +sub printProperties {
>   +  my $h = shift();
>   +  return qq[{${\(join', ',map"'$_': '$h->{$_}'",keys%$h)}}]
>   +}
>   - print "Message(properties=" . $message->getProperties() . ",content='";
>   + my $redelivered = ($message->getRedelivered) ? "redelivered=True, " : "";
>   + print "Message(" . $redelivered . "properties=" . 
> printProperties($message->getProperties()) . ", content='";
> Proposing to set default timeout to 0 (to be more conformable to other 
> clients):
>   - my $timeout = 60;
>   + my $timeout = 0;
> Proposing to set default messages count to 0 (to be more conformable to other 
> clients)
>   - my $count   = 1;
>   + my $count   = 0;
> * both spout.pl/drain.pl *:
> It is good practise to output usage with -h/--help options, or if the input 
> is wrong. It is also in place to stop the program execution after the bad 
> input/help request.
> Proposing following change:
>   -"connection-options=s" => \ $connectionOptions,   
>   -);
>   -
>   -
>   -if (! $result) {
>   -print "Usage: perl drain.pl [OPTIONS]\n";
>   -}
>   -
>   +"connection-options=s" => \ $connectionOptions,
>   +"help|h"   => \ &usage
>   +) or usage();
>   +sub usage {
>   +print "Usage: perl drain.pl [OPTIONS]\n";
>   +exit;
>   +}
> Version-Release number of selected component (if applicable):
> perl-qpid-0.18-1.el6
> Actual results:
> Unable to set message properties with spout.pl, spout/drain behaviour differs 
> from other clients (c++,py,java)
> Expected results:
> Message properties can be set using spout.pl, spout/drain behaviour more 
> concords to other clients

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-4461) [Java broker] the qpid-server startup scripts logfile naming prefix and suffix configuration does not work

2012-11-28 Thread Justin Ross (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Ross updated QPID-4461:
--

Fix Version/s: 0.20

> [Java broker] the qpid-server startup scripts logfile naming prefix and 
> suffix configuration does not work
> --
>
> Key: QPID-4461
> URL: https://issues.apache.org/jira/browse/QPID-4461
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.18
>Reporter: Robbie Gemmell
>Assignee: Alex Rudyy
> Fix For: 0.20, 0.21
>
>
> The qpid-server startup scripts logfile naming prefix and suffix 
> configuration does not work. Setting the QPID_LOG_SUFFIX or QPID_LOG_PREFIX 
> environment variables means the script unable to start the broker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4461) [Java broker] the qpid-server startup scripts logfile naming prefix and suffix configuration does not work

2012-11-28 Thread Justin Ross (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505411#comment-13505411
 ] 

Justin Ross commented on QPID-4461:
---

Approved for 0.20.  This one's trivial and doesn't require further review imo.

> [Java broker] the qpid-server startup scripts logfile naming prefix and 
> suffix configuration does not work
> --
>
> Key: QPID-4461
> URL: https://issues.apache.org/jira/browse/QPID-4461
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.18
>Reporter: Robbie Gemmell
>Assignee: Alex Rudyy
> Fix For: 0.21
>
>
> The qpid-server startup scripts logfile naming prefix and suffix 
> configuration does not work. Setting the QPID_LOG_SUFFIX or QPID_LOG_PREFIX 
> environment variables means the script unable to start the broker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



Re: 0.20 request roundup

2012-11-28 Thread Rob Godfrey
A couple more from me that I'd really like to get into 0.20:

(1) https://issues.apache.org/jira/browse/QPID-2796 : Restore heartbeating
functionality to the Java Broker, and the 0-8,0-9,0-9-1 Java Client ...

something we broke a couple of releases back, and have had requests to
restore. 0-10 Java client behaviour is unchanged.  Code reviewed by Robbie.

http://svn.apache.org/viewvc?rev=1413376&view=rev  (initial commit)
http://svn.apache.org/viewvc?rev=1413539&view=rev  (added system test)
http://svn.apache.org/viewvc?rev=1413549&view=rev  (addressed Robbie's
comments)
http://svn.apache.org/viewvc?rev=1413567&view=rev  (exclude a system test
running against the C++ broker - test only applied to 0-8/9 client path)

(2) https://issues.apache.org/jira/browse/QPID-4472 : [Java Broker] NPE
with non-SASL AMQP 1.0 Connection

Affects only the 1-0 code within the Java Broker - very low impact/risk

http://svn.apache.org/viewvc?rev=1413627&view=rev (initial commit to fix
the NPE)
http://svn.apache.org/viewvc?rev=1413724&view=rev (fix to a test which was
previously working mainly by coincidence and was broken by fixing the above)

Thanks,
Rob

On 27 November 2012 21:42, Gordon Sim  wrote:

> On 11/27/2012 06:29 PM, Justin Ross wrote:
>
>> On Tue, 27 Nov 2012, Gordon Sim wrote:
>>
>>  On 11/26/2012 08:12 PM, Justin Ross wrote:
>>>
   - Gordon
 - 
 https://issues.apache.org/**jira/browse/QPID-4448
   - 
 http://svn.apache.org/viewvc?**rev=1412239&view=rev
 - Out for review, Andrew

>>> - Now approved
>>
>>> - 
>>> https://issues.apache.org/**jira/browse/QPID-4451
   - 
 http://svn.apache.org/viewvc?**rev=1412241&view=rev
 - Approved
 - 
 https://issues.apache.org/**jira/browse/QPID-4452
   - 
 http://svn.apache.org/viewvc?**rev=1412242&view=rev
 - Approved
 - 
 https://issues.apache.org/**jira/browse/QPID-4459
   - 
 http://svn.apache.org/viewvc?**rev=1412960&view=rev
 - Approved
 - 
 https://issues.apache.org/**jira/browse/QPID-4460
   - 
 http://svn.apache.org/viewvc?**rev=1412961&view=rev
 - Approved
 - 
 https://issues.apache.org/**jira/browse/QPID-4464
   - 
 http://svn.apache.org/viewvc?**rev=1412962&view=rev
 - Approved
 - 
 https://issues.apache.org/**jira/browse/QPID-4465
   - 
 http://svn.apache.org/viewvc?**rev=1412963&view=rev
 - Approved

>>>
>>> Thanks, Justin! One more request, to allow better interop between the
>>> c++ implementation of qpid::messaging and messenger:
>>>
>>> https://issues.apache.org/**jira/browse/QPID-4477
>>>
>>> committed to trunk: 
>>> http://svn.apache.org/viewvc?**rev=1414227&view=rev
>>>
>>> Again, this only affects 1.0 code so has zero impact on anything else.
>>>
>>
>> Thanks, Gordon.  Approved.
>>
>
> Thanks again... one more small one if you don't mind (literally one line,
> and a short one at that :-)
>
> https://issues.apache.org/**jira/browse/QPID-4478:
> wakeup driver after setting credit
>
> http://svn.apache.org/viewvc?**rev=1414291&view=rev
>
>
> --**--**-
> To unsubscribe, e-mail: 
> dev-unsubscribe@qpid.apache.**org
> For additional commands, e-mail: dev-h...@qpid.apache.org
>
>


[jira] [Commented] (QPID-4474) ensure the BDBHAMessageStore JMX MBean name is quoted

2012-11-28 Thread Justin Ross (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505407#comment-13505407
 ] 

Justin Ross commented on QPID-4474:
---

>From the release-goals point of view, approved for 0.20.  Alex will review.

> ensure the BDBHAMessageStore JMX MBean name is quoted
> -
>
> Key: QPID-4474
> URL: https://issues.apache.org/jira/browse/QPID-4474
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.18
>Reporter: Robbie Gemmell
>Assignee: Alex Rudyy
> Fix For: 0.20, 0.21
>
>
> Ensure the BDBHAMessageStore JMX MBean name is quoted. The name of the other 
> MBeans (Virtualhost, Queue, Exchange) are quoted to allow them to contain 
> names which cant be encoded in an JMX ObjectName without use of quotes. The 
> BDBHAMessageStore should also have its name quoted, for the same reasons and 
> also for consistency with the other MBeans.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-4474) ensure the BDBHAMessageStore JMX MBean name is quoted

2012-11-28 Thread Justin Ross (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Ross updated QPID-4474:
--

Fix Version/s: 0.20

> ensure the BDBHAMessageStore JMX MBean name is quoted
> -
>
> Key: QPID-4474
> URL: https://issues.apache.org/jira/browse/QPID-4474
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.18
>Reporter: Robbie Gemmell
>Assignee: Alex Rudyy
> Fix For: 0.20, 0.21
>
>
> Ensure the BDBHAMessageStore JMX MBean name is quoted. The name of the other 
> MBeans (Virtualhost, Queue, Exchange) are quoted to allow them to contain 
> names which cant be encoded in an JMX ObjectName without use of quotes. The 
> BDBHAMessageStore should also have its name quoted, for the same reasons and 
> also for consistency with the other MBeans.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4469) [Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()

2012-11-28 Thread Justin Ross (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505403#comment-13505403
 ] 

Justin Ross commented on QPID-4469:
---

Though not in itself a priority change for 0.20, it sensibly goes along with 
QPID-4468.  Reviewed by Rob.  Approved for 0.20.

> [Java common] remove unused sslContext parameter from 
> OutgoingNetworkTransport#connect()
> 
>
> Key: QPID-4469
> URL: https://issues.apache.org/jira/browse/QPID-4469
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Client, Java Common
>Affects Versions: 0.14, 0.16, 0.18
>Reporter: Robbie Gemmell
>Assignee: Rob Godfrey
> Fix For: 0.20, 0.21
>
>
> OutgoingNetworkTransport#connect() takes an sslContext parameter. This is 
> unused by the transport implementations because SSL is implemented in the 
> client as a wrapper over the transport. The 0-10 path of the client supplies 
> null for this arg, but the 08/0-9/0-9-1 patch still creates and supplies one. 
> The parameter should be removed to ensure consistency now and in the future.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-4468) [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry

2012-11-28 Thread Justin Ross (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Ross updated QPID-4468:
--

Fix Version/s: 0.20

> [Java client] restore ability to enable SSL using a connection level option 
> rather than as a sub-option of each brokerlist entry
> 
>
> Key: QPID-4468
> URL: https://issues.apache.org/jira/browse/QPID-4468
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Client
>Affects Versions: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.20, 0.21
>
>
> On old client versions it was possible to specify that SSL should be used at 
> the connection level options. It is now only possible to specify this as part 
> of the brokerlist sub-options (in addition to much finer-grained control over 
> the keystores/truststores and certificates etc to be used). If you are just 
> using the SSL system properties to define they keystore/truststore etc and 
> have multiple brokers in the brokerlist it is actually more convenient to 
> specify ssl=true at the connection level.
> Restoring this will maintain compatibility for drop-in replacement of old 
> clients and also help prevent user confiusion resulting from the URL parsers 
> inability to alert them to the previous ssl configuration going unused.
> It will be restored as an ovveride of ssl option in the brokerlist entries.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-4469) [Java common] remove unused sslContext parameter from OutgoingNetworkTransport#connect()

2012-11-28 Thread Justin Ross (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Ross updated QPID-4469:
--

Fix Version/s: 0.20

> [Java common] remove unused sslContext parameter from 
> OutgoingNetworkTransport#connect()
> 
>
> Key: QPID-4469
> URL: https://issues.apache.org/jira/browse/QPID-4469
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Client, Java Common
>Affects Versions: 0.14, 0.16, 0.18
>Reporter: Robbie Gemmell
>Assignee: Rob Godfrey
> Fix For: 0.20, 0.21
>
>
> OutgoingNetworkTransport#connect() takes an sslContext parameter. This is 
> unused by the transport implementations because SSL is implemented in the 
> client as a wrapper over the transport. The 0-10 path of the client supplies 
> null for this arg, but the 08/0-9/0-9-1 patch still creates and supplies one. 
> The parameter should be removed to ensure consistency now and in the future.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4468) [Java client] restore ability to enable SSL using a connection level option rather than as a sub-option of each brokerlist entry

2012-11-28 Thread Justin Ross (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505400#comment-13505400
 ] 

Justin Ross commented on QPID-4468:
---

Reviewed by Rob.  Approve for 0.20.

> [Java client] restore ability to enable SSL using a connection level option 
> rather than as a sub-option of each brokerlist entry
> 
>
> Key: QPID-4468
> URL: https://issues.apache.org/jira/browse/QPID-4468
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Client
>Affects Versions: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.20, 0.21
>
>
> On old client versions it was possible to specify that SSL should be used at 
> the connection level options. It is now only possible to specify this as part 
> of the brokerlist sub-options (in addition to much finer-grained control over 
> the keystores/truststores and certificates etc to be used). If you are just 
> using the SSL system properties to define they keystore/truststore etc and 
> have multiple brokers in the brokerlist it is actually more convenient to 
> specify ssl=true at the connection level.
> Restoring this will maintain compatibility for drop-in replacement of old 
> clients and also help prevent user confiusion resulting from the URL parsers 
> inability to alert them to the previous ssl configuration going unused.
> It will be restored as an ovveride of ssl option in the brokerlist entries.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4476) [Java broker] SimpleLDAPAuthenticationManager returns different Principal name formats for sasl vs non-sasl usage

2012-11-28 Thread Justin Ross (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505396#comment-13505396
 ] 

Justin Ross commented on QPID-4476:
---

Reviewed by Rob.  Approved for 0.20.

> [Java broker] SimpleLDAPAuthenticationManager returns different Principal 
> name formats for sasl vs non-sasl usage
> -
>
> Key: QPID-4476
> URL: https://issues.apache.org/jira/browse/QPID-4476
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.18, 0.20
>Reporter: Robbie Gemmell
>Assignee: Rob Godfrey
> Fix For: 0.20, 0.21
>
>
> The SimpleLDAPAuthenticationManager returns different Principal name formats 
> for sasl vs non-sasl usage.
> In the sasl case, the PlainSaslServer returns the basic username that was 
> originally provided, but in the non-sasl case the 
> SimpleLDAPAuthenticationManager returns a Principal based on the search 
> context/filter. This leads to inconsistent behaviour between e.g. AMQP and 
> JMX interface authentication, and in the later case means it is not possible 
> to specify the user be included as part of an group.
> The non-sasl behaviour should be updated to be consistent with the sasl 
> behaviour.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-4476) [Java broker] SimpleLDAPAuthenticationManager returns different Principal name formats for sasl vs non-sasl usage

2012-11-28 Thread Justin Ross (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Ross updated QPID-4476:
--

Fix Version/s: 0.20

> [Java broker] SimpleLDAPAuthenticationManager returns different Principal 
> name formats for sasl vs non-sasl usage
> -
>
> Key: QPID-4476
> URL: https://issues.apache.org/jira/browse/QPID-4476
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.18, 0.20
>Reporter: Robbie Gemmell
>Assignee: Rob Godfrey
> Fix For: 0.20, 0.21
>
>
> The SimpleLDAPAuthenticationManager returns different Principal name formats 
> for sasl vs non-sasl usage.
> In the sasl case, the PlainSaslServer returns the basic username that was 
> originally provided, but in the non-sasl case the 
> SimpleLDAPAuthenticationManager returns a Principal based on the search 
> context/filter. This leads to inconsistent behaviour between e.g. AMQP and 
> JMX interface authentication, and in the later case means it is not possible 
> to specify the user be included as part of an group.
> The non-sasl behaviour should be updated to be consistent with the sasl 
> behaviour.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-4441) [Java broker] queue declare arguments are lost during v6 schema update for the optional bdbstore

2012-11-28 Thread Justin Ross (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Ross updated QPID-4441:
--

Fix Version/s: 0.20

> [Java broker] queue declare arguments are lost during v6 schema update for 
> the optional bdbstore
> 
>
> Key: QPID-4441
> URL: https://issues.apache.org/jira/browse/QPID-4441
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.18
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
>Priority: Blocker
> Fix For: 0.19, 0.20
>
>
> The queue declare arguments are lost during v5 -> v6 store schema update for 
> the optional bdbstore. This will present itself in a variety of ways, such as 
> a DLQ losing the marker argument used to prevent chained DLQ creation, and 
> also in Priority and Sorted queues becoming regular queues.
> As part of the schema update, the old FieldTable binary encoding for the 
> queue arguments is transitioned to a property within the larger JSON 
> ConfiguredObject encoding. This process makes use of an intermediate 
> FieldTable to which it does an addAll() based copy of the original FieldTable 
> and then potentially adds a new description argument. This addAll() fails to 
> copy the previous properties due to a defect in the method, wherby the source 
> FieldTables lack of use after creation from encoded bytes means they have yet 
> to be decoded and this is in effect mistaken as it being an empty FieldTable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4456) update the Java broker-only release package to account for changes in plugin system

2012-11-28 Thread Justin Ross (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505393#comment-13505393
 ] 

Justin Ross commented on QPID-4456:
---

Second change reviewed by Keith; approved for 0.20.

> update the Java broker-only release package to account for changes in plugin 
> system
> ---
>
> Key: QPID-4456
> URL: https://issues.apache.org/jira/browse/QPID-4456
> Project: Qpid
>  Issue Type: Task
>  Components: Packaging
>Affects Versions: 0.19
>Reporter: Robbie Gemmell
>Assignee: Keith Wall
>Priority: Blocker
> Fix For: 0.20
>
>
> Following the simplification of the plugin system in the Java broker via 
> QPID-4335 and the modifications to the tests in QPID-4353, the plugins are 
> not being packaged in the broker-only release binary (as per discussion on 
> QPID- just prior to the 0.20 beta).
> The build system should be updated to account for the changes and ensure the 
> plugins are again included.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-4441) [Java broker] queue declare arguments are lost during v6 schema update for the optional bdbstore

2012-11-28 Thread Justin Ross (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505392#comment-13505392
 ] 

Justin Ross commented on QPID-4441:
---

Reviewed by Alex.  Approved for 0.20.

> [Java broker] queue declare arguments are lost during v6 schema update for 
> the optional bdbstore
> 
>
> Key: QPID-4441
> URL: https://issues.apache.org/jira/browse/QPID-4441
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.18
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
>Priority: Blocker
> Fix For: 0.19, 0.20
>
>
> The queue declare arguments are lost during v5 -> v6 store schema update for 
> the optional bdbstore. This will present itself in a variety of ways, such as 
> a DLQ losing the marker argument used to prevent chained DLQ creation, and 
> also in Priority and Sorted queues becoming regular queues.
> As part of the schema update, the old FieldTable binary encoding for the 
> queue arguments is transitioned to a property within the larger JSON 
> ConfiguredObject encoding. This process makes use of an intermediate 
> FieldTable to which it does an addAll() based copy of the original FieldTable 
> and then potentially adds a new description argument. This addAll() fails to 
> copy the previous properties due to a defect in the method, wherby the source 
> FieldTables lack of use after creation from encoded bytes means they have yet 
> to be decoded and this is in effect mistaken as it being an empty FieldTable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org