[jira] [Commented] (QPID-5009) [Java Broker] Update broker store to revision 7
[ https://issues.apache.org/jira/browse/QPID-5009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13715218#comment-13715218 ] Robbie Gemmell commented on QPID-5009: -- Looks good. Should be requested for inclusion in 0.24 along with the related QPID-4999. [Java Broker] Update broker store to revision 7 --- Key: QPID-5009 URL: https://issues.apache.org/jira/browse/QPID-5009 Project: Qpid Issue Type: Improvement Reporter: Rob Godfrey Assignee: Rob Godfrey To reflect the addition of the config version table, update the revision number for the database version in all persistent store implementations. Ensure store upgrades fail if encountering a database version newer than the one the code is expecting -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4999) [Java Broker] Strip selector arguments from persistent bindings to non-topic exchanges created by buggy old clients
[ https://issues.apache.org/jira/browse/QPID-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13715216#comment-13715216 ] Robbie Gemmell commented on QPID-4999: -- As already discussed elsewhere, looks good other than not upgrading the store version, which has now been handled via QPID-5009. This needs to be requested for inclusion in 0.24 so that people upgrading don't find their broker starts behaving quite differently. [Java Broker] Strip selector arguments from persistent bindings to non-topic exchanges created by buggy old clients --- Key: QPID-4999 URL: https://issues.apache.org/jira/browse/QPID-4999 Project: Qpid Issue Type: Bug Components: Java Broker Reporter: Rob Godfrey With the addition of the ability to add selectors to queue bindings, we need to remove any arguments on bindings that were caused by the buggy behaviour of the JMS client. Previously such arguments would have been ignored, but upon upgrading the queue would now receive fewer messages than expected as the selector would take effect). This stripping of bindings should take effect when the store is first upgraded. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: New Defects reported by Coverity Scan for Apache-Qpid
I've been looking at the Qpid-Java Coverity project and can't see a way to modify its FindBugs configuration, e.g. uploading a FindBugs filter.xml file. The closest I can do is to upload a Model File to override how Coverity treats specific third-party method calls, but I don't think that would achieve the same thing. Does anyone else have experience with this? Phil On 17 July 2013 13:53, Phil Harvey p...@philharveyonline.com wrote: I'm in the process of getting this set up. In a wider context, I would like to work towards a situation where developers can run a scan against local (ie not yet committed) code. The rationale is to get feedback about potential issues as early as possible. For Java code this should be possible by running FindBugs locally (either from Ant, Maven or using an IDE plugin), using the same rules that we've set up on Coverity. I think this means we'd check in the rule config somewhere in svn. I must confess I don't know what the C/C++ equivalent would be. Phil On 16 Jul 2013 15:24, Steve Huston shus...@riverace.com wrote: This would be great, Phil! We currently are not scanning the Java code, but it would be great if you can set up the Java scan. If you'd like some help from Coverity please let me know - the mgr I worked with to get the C++ scan going was eager to get Java projects in as well - but they couldn't scan Java at that time. -Original Message- From: philharveyonl...@googlemail.com [mailto:philharveyonl...@googlemail.com] On Behalf Of Phil Harvey Sent: Tuesday, July 16, 2013 8:09 AM To: dev@qpid.apache.org Subject: Re: New Defects reported by Coverity Scan for Apache-Qpid Hi Steve, I'd be happy to help make sense of the Java results. I'll set up a Coverity account now. Thanks Phil On 2 July 2013 15:43, Steve Huston shus...@riverace.com wrote: Yes, I noticed that too - and Coverity was fairly eager to get a scan of the Qpid Java code back when we started, but they weren't ready to scan Java quite yet. If anyone would like to tackle the Java scans, and is not yet signed up at coverity.com, please let me know and I'll help get you going. From: Rob Godfrey [mailto:rob.j.godf...@gmail.com] Sent: Tuesday, July 02, 2013 10:41 AM To: qpid Cc: Steve Huston Subject: Re: New Defects reported by Coverity Scan for Apache-Qpid As an aside, I notice that they seem to have enabled scanning of Java projects as well as C++ now... we should maybe look to see what a coverity scan of the Java code looks like -- Rob snip - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Request for inclusion in 0.24
Hi Justin, we'd like to get QPID-4999 and QPID-5009 into 0.24. These changes enable users upgrading from prior versions of Qpid to maintain expected functionality. Without these changes people may see unexpected behaviour and missing messages when upgrading a broker with existing bindings to 0.24. The changes have been reviewed by Robbie. -- Rob https://issues.apache.org/jira/browse/QPID-4999 https://issues.apache.org/jira/browse/QPID-5009
[jira] [Commented] (QPID-4999) [Java Broker] Strip selector arguments from persistent bindings to non-topic exchanges created by buggy old clients
[ https://issues.apache.org/jira/browse/QPID-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13715377#comment-13715377 ] Justin Ross commented on QPID-4999: --- Reviewed by Robbie. Approved for 0.24. [Java Broker] Strip selector arguments from persistent bindings to non-topic exchanges created by buggy old clients --- Key: QPID-4999 URL: https://issues.apache.org/jira/browse/QPID-4999 Project: Qpid Issue Type: Bug Components: Java Broker Reporter: Rob Godfrey With the addition of the ability to add selectors to queue bindings, we need to remove any arguments on bindings that were caused by the buggy behaviour of the JMS client. Previously such arguments would have been ignored, but upon upgrading the queue would now receive fewer messages than expected as the selector would take effect). This stripping of bindings should take effect when the store is first upgraded. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5009) [Java Broker] Update broker store to revision 7
[ https://issues.apache.org/jira/browse/QPID-5009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13715378#comment-13715378 ] Justin Ross commented on QPID-5009: --- Reviewed by Robbie. Approved for 0.24. [Java Broker] Update broker store to revision 7 --- Key: QPID-5009 URL: https://issues.apache.org/jira/browse/QPID-5009 Project: Qpid Issue Type: Improvement Reporter: Rob Godfrey Assignee: Rob Godfrey To reflect the addition of the config version table, update the revision number for the database version in all persistent store implementations. Ensure store upgrades fail if encountering a database version newer than the one the code is expecting -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Request for inclusion in 0.24
Thanks, Rob and Robbie. Approved. On Mon, Jul 22, 2013 at 12:22 PM, Rob Godfrey rob.j.godf...@gmail.com wrote: Hi Justin, we'd like to get QPID-4999 and QPID-5009 into 0.24. These changes enable users upgrading from prior versions of Qpid to maintain expected functionality. Without these changes people may see unexpected behaviour and missing messages when upgrading a broker with existing bindings to 0.24. The changes have been reviewed by Robbie. -- Rob https://issues.apache.org/jira/browse/QPID-4999 https://issues.apache.org/jira/browse/QPID-5009 - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-4530) Provide Documentation for JCA/XA/Cluster configuration
[ https://issues.apache.org/jira/browse/QPID-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Ross updated QPID-4530: -- Fix Version/s: (was: 0.23) 0.25 Provide Documentation for JCA/XA/Cluster configuration -- Key: QPID-4530 URL: https://issues.apache.org/jira/browse/QPID-4530 Project: Qpid Issue Type: Improvement Components: JCA Affects Versions: 0.18 Environment: All supported OS platforms, all supported JEE platforms. Reporter: Weston M. Price Assignee: Weston M. Price Fix For: 0.25 Currently we are lacking any sort of documentation on configuration, limitations etc when running JCA in a cluster environment. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-5010) ACL self tests written in python handle self.fail incorrectly
Chuck Rolke created QPID-5010:
-
Summary: ACL self tests written in python handle self.fail
incorrectly
Key: QPID-5010
URL: https://issues.apache.org/jira/browse/QPID-5010
Project: Qpid
Issue Type: Bug
Components: Python Test Suite
Affects Versions: 0.14
Environment: cmake 'make test', or ./cpp/src/tests/run_acl_tests
Reporter: Chuck Rolke
Assignee: Chuck Rolke
When a self.fail() function is called inside a try: block then control simply
passes to the except: handler. The function does not exit with a failure.
In this example suppose that the get_connection() for evildude is expected to
fail but it does not.
{noformat}
try:
conne1 = self.get_connection('evildude','evildude')
self.fail(Should not create a connection for user evildude)
except Exception, e:
result = None
self.fail(: + str(e))
{noformat}
produces failure:
{noformat}
AssertionError: :Should not create a connection for user evildude
{noformat}
Code in acl.py expected the function to exit with the signalled error. To
properly fail the code must set a flag while in the try block and then test
that flag to sequently fail outside of the try block.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-5011) C++ Broker ACL allows one connection when user quota is zero
Chuck Rolke created QPID-5011:
-
Summary: C++ Broker ACL allows one connection when user quota is
zero
Key: QPID-5011
URL: https://issues.apache.org/jira/browse/QPID-5011
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.22
Reporter: Chuck Rolke
Assignee: Chuck Rolke
If an ACL file has a rule like
{noformat}
quota connections 0 user@QPID
{noformat}
then the user is still allowed one connection.
This feature was tested in a self test but the self test did not detect that
the feature was broken. See QPID-5010.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-4999) [Java Broker] Strip selector arguments from persistent bindings to non-topic exchanges created by buggy old clients
[ https://issues.apache.org/jira/browse/QPID-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated QPID-4999: -- Fix Version/s: 0.24 [Java Broker] Strip selector arguments from persistent bindings to non-topic exchanges created by buggy old clients --- Key: QPID-4999 URL: https://issues.apache.org/jira/browse/QPID-4999 Project: Qpid Issue Type: Bug Components: Java Broker Reporter: Rob Godfrey Fix For: 0.24 With the addition of the ability to add selectors to queue bindings, we need to remove any arguments on bindings that were caused by the buggy behaviour of the JMS client. Previously such arguments would have been ignored, but upon upgrading the queue would now receive fewer messages than expected as the selector would take effect). This stripping of bindings should take effect when the store is first upgraded. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5009) [Java Broker] Update broker store to revision 7
[ https://issues.apache.org/jira/browse/QPID-5009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13715670#comment-13715670 ] ASF subversion and git services commented on QPID-5009: --- Commit 1505821 from [~godfrer] in branch 'qpid/branches/0' [ https://svn.apache.org/r1505821 ] QPID-5009 : merged to 0.24 branch (1505029) [Java Broker] Update broker store to revision 7 --- Key: QPID-5009 URL: https://issues.apache.org/jira/browse/QPID-5009 Project: Qpid Issue Type: Improvement Reporter: Rob Godfrey Assignee: Rob Godfrey To reflect the addition of the config version table, update the revision number for the database version in all persistent store implementations. Ensure store upgrades fail if encountering a database version newer than the one the code is expecting -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-5009) [Java Broker] Update broker store to revision 7
[ https://issues.apache.org/jira/browse/QPID-5009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved QPID-5009. --- Resolution: Fixed Fix Version/s: 0.24 [Java Broker] Update broker store to revision 7 --- Key: QPID-5009 URL: https://issues.apache.org/jira/browse/QPID-5009 Project: Qpid Issue Type: Improvement Reporter: Rob Godfrey Assignee: Rob Godfrey Fix For: 0.24 To reflect the addition of the config version table, update the revision number for the database version in all persistent store implementations. Ensure store upgrades fail if encountering a database version newer than the one the code is expecting -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-4999) [Java Broker] Strip selector arguments from persistent bindings to non-topic exchanges created by buggy old clients
[ https://issues.apache.org/jira/browse/QPID-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved QPID-4999. --- Resolution: Fixed [Java Broker] Strip selector arguments from persistent bindings to non-topic exchanges created by buggy old clients --- Key: QPID-4999 URL: https://issues.apache.org/jira/browse/QPID-4999 Project: Qpid Issue Type: Bug Components: Java Broker Reporter: Rob Godfrey Fix For: 0.24 With the addition of the ability to add selectors to queue bindings, we need to remove any arguments on bindings that were caused by the buggy behaviour of the JMS client. Previously such arguments would have been ignored, but upon upgrading the queue would now receive fewer messages than expected as the selector would take effect). This stripping of bindings should take effect when the store is first upgraded. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-5011) C++ Broker ACL allows one connection when user quota is zero
[
https://issues.apache.org/jira/browse/QPID-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13715690#comment-13715690
]
ASF subversion and git services commented on QPID-5011:
---
Commit 1505823 from c...@apache.org in branch 'qpid/trunk'
[ https://svn.apache.org/r1505823 ]
QPID-5011: C++ Broker ACL allows one connection when user quota is zero
Compute limit-check result even for first connection.
C++ Broker ACL allows one connection when user quota is zero
Key: QPID-5011
URL: https://issues.apache.org/jira/browse/QPID-5011
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.22
Reporter: Chuck Rolke
Assignee: Chuck Rolke
If an ACL file has a rule like
{noformat}
quota connections 0 user@QPID
{noformat}
then the user is still allowed one connection.
This feature was tested in a self test but the self test did not detect that
the feature was broken. See QPID-5010.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-5011) C++ Broker ACL allows one connection when user quota is zero
[
https://issues.apache.org/jira/browse/QPID-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chuck Rolke resolved QPID-5011.
---
Resolution: Fixed
Fix Version/s: 0.25
C++ Broker ACL allows one connection when user quota is zero
Key: QPID-5011
URL: https://issues.apache.org/jira/browse/QPID-5011
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Affects Versions: 0.22
Reporter: Chuck Rolke
Assignee: Chuck Rolke
Fix For: 0.25
If an ACL file has a rule like
{noformat}
quota connections 0 user@QPID
{noformat}
then the user is still allowed one connection.
This feature was tested in a self test but the self test did not detect that
the feature was broken. See QPID-5010.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (QPID-5004) AMQP queue client functionality is not working behind a HTTP proxy.
[ https://issues.apache.org/jira/browse/QPID-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13713949#comment-13713949 ] venkata yerrapothu edited comment on QPID-5004 at 7/23/13 12:26 AM: I got it working finally through the proxy. Thanks was (Author: yerrapothu): Apologies for the miscommunication. In our case the any internet connectivity (external) must go through proxies only. Our Firewalls block everything. Thanks AMQP queue client functionality is not working behind a HTTP proxy. --- Key: QPID-5004 URL: https://issues.apache.org/jira/browse/QPID-5004 Project: Qpid Issue Type: Bug Components: Java Client Affects Versions: 0.22 Environment: SUN and IBM JVM's version 6 and 7 as well. Reporter: venkata yerrapothu -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
