[jira] [Commented] (PROTON-1215) Move codec::data class to internal namespace

2016-06-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313594#comment-15313594
 ] 

ASF subversion and git services commented on PROTON-1215:
-

Commit 348f4d51fa6bd27da2dc56bbeafef0c0d2273d21 in qpid-proton's branch 
refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=348f4d5 ]

PROTON-1215: [C++ binding] Move data to internal namespace
-- Also tidy up use of "using namespace"


> Move codec::data class to internal namespace
> 
>
> Key: PROTON-1215
> URL: https://issues.apache.org/jira/browse/PROTON-1215
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: cpp-binding
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (DISPATCH-337) Huge memory leaks in Qpid Dispatch router

2016-06-02 Thread Vishal Sharda (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DISPATCH-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vishal Sharda updated DISPATCH-337:
---
Attachment: Subsequent_memory_increase.png
Rapid_perm_memory_increase.png

Two files attached: Rapid_perm_memory_increase.png and 
Subsequent_memory_increase.png

We ran two interconnected routers having 2-way SSL connection between them and 
accepting 2-way SSL connections from clients.  We connected several senders to 
one router and several receivers to the other.  Total of 250K messages were 
sent from one end to the other.  We saw  rapid increase in memory usage of both 
the routers.  This memory never became low again and a subsequent identical run 
increased the memory further.

Since the routers are never intended to be terminated, such memory leaks on all 
subsequent connections and data transfers will eventually lead to routers being 
killed.

> Huge memory leaks in Qpid Dispatch router
> -
>
> Key: DISPATCH-337
> URL: https://issues.apache.org/jira/browse/DISPATCH-337
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 0.6.0
> Environment: Debian 8.3, Apache Qpid Proton 0.12.2 for drivers and 
> dependencies, Hardware: 2 CPUs, 15 GB RAM, 60 GB HDD on 2 separate machines
>Reporter: Vishal Sharda
>Priority: Critical
> Attachments: Rapid_perm_memory_increase.png, 
> Subsequent_memory_increase.png, config1.conf, config2.conf, 
> val2_receiver.txt, val2_sender.txt
>
>
> Valgrind shows huge memory leaks while running 2 interconnected routers with 
> 2 parallel senders connected to the one router and 2 parallel receivers 
> connected to the other router.
> The CRYPTO leak that is coming from Qpid Proton 0.12.2 is already fixed here:
> https://issues.apache.org/jira/browse/PROTON-1115
> However, the rest of the leaks are from qdrouterd.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1225) c++: taking address of element 0 of an empty string or vector

2016-06-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312919#comment-15312919
 ] 

ASF subversion and git services commented on PROTON-1225:
-

Commit b57e6ea7d7318caf83a36648164637ae2d3afa66 in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=b57e6ea ]

PROTON-1225: c++: taking address of element 0 of an empty string or vector

Added x.empty() checks and assertions to all uses of the [0] idiom.


> c++: taking address of element 0 of an empty string or vector
> -
>
> Key: PROTON-1225
> URL: https://issues.apache.org/jira/browse/PROTON-1225
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: 0.12.2
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Blocker
> Fix For: 0.13.0
>
>
> This bug shows up in a couple places, fixing all. Originally pointed out on 
> the user list: 
> http://qpid.2158936.n2.nabble.com/Proton-C-0-12-2-C-vector-subscript-out-of-range-in-unit-tests-td7644983.html
> The problem is using the idiom [0] to get the address of storage in a 
> string or vector without first testing that it is not empty. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (PROTON-1225) c++: taking address of element 0 of an empty string or vector

2016-06-02 Thread Alan Conway (JIRA) 
Alan Conway created PROTON-1225:
---

 Summary: c++: taking address of element 0 of an empty string or 
vector
 Key: PROTON-1225
 URL: https://issues.apache.org/jira/browse/PROTON-1225
 Project: Qpid Proton
  Issue Type: Bug
  Components: cpp-binding
Affects Versions: 0.12.2
Reporter: Alan Conway
Assignee: Alan Conway
Priority: Blocker
 Fix For: 0.13.0


This bug shows up in a couple places, fixing all. Originally pointed out on the 
user list: 

http://qpid.2158936.n2.nabble.com/Proton-C-0-12-2-C-vector-subscript-out-of-range-in-unit-tests-td7644983.html

The problem is using the idiom [0] to get the address of storage in a string 
or vector without first testing that it is not empty. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1216) c++: proton::coerce() should allow conversion from binary.

2016-06-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312776#comment-15312776
 ] 

ASF subversion and git services commented on PROTON-1216:
-

Commit 7cc9562cd6c83f995586e56f939072213ce60cae in qpid-proton's branch 
refs/heads/0.13.x from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=7cc9562 ]

PROTON-1216: c++: proton::coerce should convert binary to string.

Make scalar and value coerce<> consistent with C++ implicit conversions and 
each other.

- No source api change (still have deprecated functions)
- Better test coverage, consistent tests for value and scalar where applicable.
- Fixed unknown integer type conversions for scalar.
- Fixed examples using deprecated APIs (deprecated APIs are still in place)
- Consistent printing of scalar values, repect the std::ios::boolalpha flag for 
printing bool.

This commit also includes the following 2 commits from master:

PROTON-1216: c++: cleanup to previous commit.

Removed file left behind in error, removed non standard cxxabi.h.

PROTON-1216: Fix windows warnings from is_convertible<>

Locally suppress Windows warnings about legal but risky argument
conversions (float/int, signed/unsigned etc.) only in template is_convertible<>.

The compile-time warnings are a side effect of template instantiation by
coerce<>, not an indication of risky use. coerce<> is a run-time conversion and
throws run-time errors for illegal conversions. In future we may add something
like safe_convert<> that throws run-time errors for risky conversions as well.


> c++: proton::coerce() should allow conversion from binary.
> ---
>
> Key: PROTON-1216
> URL: https://issues.apache.org/jira/browse/PROTON-1216
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: 0.12.2
>Reporter: Alan Conway
>Assignee: Alan Conway
> Fix For: 0.13.0
>
>
> proton::coerce should convert a binary value to a std::string. 
> The documentation also needs clarification: coerce should allow exactly those 
> conversions that are allowed as implicit C++ conversions.
> Issue raised in excellent bug report on the user list 
> http://qpid.2158936.n2.nabble.com/Proton-C-0-13-x-decode-binary-type-tp7644510p7644747.html
>  text follows:
> proton::coerce (both forms) currently throws the same
> exception as proton::get, as does value.as_string(), although that doesn't
> appear to be in the public API. Not sure what 'd' was in the d>>b  example,
> but got a version working using value.get() and an implicit
> cast to std::string.
> To reproduce...
> #include 
> #include 
> #include 
> #include 
> template
> void expect_exception ( Lambda f )
> {
>   try
>   {
> f();
> std::cout << "*** FAIL (expected conversion error) ***" << std::endl;
>   }
>   catch ( const proton::conversion_error& e )
>   {
> std::cout << "PASS" << std::endl;
>   }
> }
> template
> void expect_value ( const std::string& expected, Lambda f )
> {
>   try
>   {
> std::cout << (f() == expected ? "PASS" : "*** FAIL (wrong value) ***")
> << std::endl;
>   }
>   catch ( const proton::conversion_error& e )
>   {
> std::cout << "*** FAIL (conversion error) ***" << std::endl;
>   }
> }
> int main()
> {
>   std::string expected = "Hello World!";
>   proton::value value = proton::binary(expected);
>   expect_exception(  [=] { return value.get();   
>  
> });
>   expect_exception(  [=] { return proton::get(value);
>  
> });
>   expect_exception(  [=] { std::string result;
> proton::get(value); return result; });
>   expect_value(expected, [=] () -> std::string { return
> value.get(); } );
>   // The following currently fail under 0.13.x
>   expect_value(expected, [=] { return value.as_string();  
>  
> });
>   expect_value(expected, [=] { return proton::coerce(value); 
>  
> });
>   expect_value(expected, [=] { std::string result;
> proton::coerce(value, result); return result; });
>   
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1216) c++: proton::coerce() should allow conversion from binary.

2016-06-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312775#comment-15312775
 ] 

ASF subversion and git services commented on PROTON-1216:
-

Commit 7cc9562cd6c83f995586e56f939072213ce60cae in qpid-proton's branch 
refs/heads/0.13.x from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=7cc9562 ]

PROTON-1216: c++: proton::coerce should convert binary to string.

Make scalar and value coerce<> consistent with C++ implicit conversions and 
each other.

- No source api change (still have deprecated functions)
- Better test coverage, consistent tests for value and scalar where applicable.
- Fixed unknown integer type conversions for scalar.
- Fixed examples using deprecated APIs (deprecated APIs are still in place)
- Consistent printing of scalar values, repect the std::ios::boolalpha flag for 
printing bool.

This commit also includes the following 2 commits from master:

PROTON-1216: c++: cleanup to previous commit.

Removed file left behind in error, removed non standard cxxabi.h.

PROTON-1216: Fix windows warnings from is_convertible<>

Locally suppress Windows warnings about legal but risky argument
conversions (float/int, signed/unsigned etc.) only in template is_convertible<>.

The compile-time warnings are a side effect of template instantiation by
coerce<>, not an indication of risky use. coerce<> is a run-time conversion and
throws run-time errors for illegal conversions. In future we may add something
like safe_convert<> that throws run-time errors for risky conversions as well.


> c++: proton::coerce() should allow conversion from binary.
> ---
>
> Key: PROTON-1216
> URL: https://issues.apache.org/jira/browse/PROTON-1216
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: 0.12.2
>Reporter: Alan Conway
>Assignee: Alan Conway
> Fix For: 0.13.0
>
>
> proton::coerce should convert a binary value to a std::string. 
> The documentation also needs clarification: coerce should allow exactly those 
> conversions that are allowed as implicit C++ conversions.
> Issue raised in excellent bug report on the user list 
> http://qpid.2158936.n2.nabble.com/Proton-C-0-13-x-decode-binary-type-tp7644510p7644747.html
>  text follows:
> proton::coerce (both forms) currently throws the same
> exception as proton::get, as does value.as_string(), although that doesn't
> appear to be in the public API. Not sure what 'd' was in the d>>b  example,
> but got a version working using value.get() and an implicit
> cast to std::string.
> To reproduce...
> #include 
> #include 
> #include 
> #include 
> template
> void expect_exception ( Lambda f )
> {
>   try
>   {
> f();
> std::cout << "*** FAIL (expected conversion error) ***" << std::endl;
>   }
>   catch ( const proton::conversion_error& e )
>   {
> std::cout << "PASS" << std::endl;
>   }
> }
> template
> void expect_value ( const std::string& expected, Lambda f )
> {
>   try
>   {
> std::cout << (f() == expected ? "PASS" : "*** FAIL (wrong value) ***")
> << std::endl;
>   }
>   catch ( const proton::conversion_error& e )
>   {
> std::cout << "*** FAIL (conversion error) ***" << std::endl;
>   }
> }
> int main()
> {
>   std::string expected = "Hello World!";
>   proton::value value = proton::binary(expected);
>   expect_exception(  [=] { return value.get();   
>  
> });
>   expect_exception(  [=] { return proton::get(value);
>  
> });
>   expect_exception(  [=] { std::string result;
> proton::get(value); return result; });
>   expect_value(expected, [=] () -> std::string { return
> value.get(); } );
>   // The following currently fail under 0.13.x
>   expect_value(expected, [=] { return value.as_string();  
>  
> });
>   expect_value(expected, [=] { return proton::coerce(value); 
>  
> });
>   expect_value(expected, [=] { std::string result;
> proton::coerce(value, result); return result; });
>   
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Comment Edited] (PROTON-1216) c++: proton::coerce() should allow conversion from binary.

2016-06-02 Thread Alan Conway (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311188#comment-15311188
 ] 

Alan Conway edited comment on PROTON-1216 at 6/2/16 5:29 PM:
-

Fixed windows warnings on master, almost 0 risk - conditionally disabled one 
warning for one line of code. 
{code}
diff --git a/proton-c/bindings/cpp/include/proton/internal/type_traits.hpp 
b/proton-c/bindings/cpp/include/proton/internal/type_traits.hpp
index 0490823..c99c248 100644
--- a/proton-c/bindings/cpp/include/proton/internal/type_traits.hpp
+++ b/proton-c/bindings/cpp/include/proton/internal/type_traits.hpp
@@ -161,7 +161,17 @@ template  struct is_convertible : 
public sfinae {
 static yes test(const To&);
 static no test(...);
 static const From& from;
+// Windows compilers warn about data-loss caused by legal conversions.  We
+// can't use static_cast because that will cause a hard error instead of
+// letting SFINAE overload resolution select the test(...) overload.
+#ifdef _WIN32
+#pragma warning( push )
+#pragma warning( disable : 4244 )
+#endif
 static bool const value = sizeof(test(from)) == sizeof(yes);
+#ifdef _WIN32
+#pragma warning( pop )
+#endif
 };
{code}


was (Author: aconway):
Committed approved bits to 0.13.x:

b30fa9c PROTON-1216: c++: cleanup to previous commit.
68f1c15 PROTON-1216: c++: proton::coerce should convert binary to string.

Fixed windows warnings on master, almost 0 risk - conditionally disabled one 
warning for one line of code. Will add to 0.13.x if approved.

{code}
diff --git a/proton-c/bindings/cpp/include/proton/internal/type_traits.hpp 
b/proton-c/bindings/cpp/include/proton/internal/type_traits.hpp
index 0490823..c99c248 100644
--- a/proton-c/bindings/cpp/include/proton/internal/type_traits.hpp
+++ b/proton-c/bindings/cpp/include/proton/internal/type_traits.hpp
@@ -161,7 +161,17 @@ template  struct is_convertible : 
public sfinae {
 static yes test(const To&);
 static no test(...);
 static const From& from;
+// Windows compilers warn about data-loss caused by legal conversions.  We
+// can't use static_cast because that will cause a hard error instead of
+// letting SFINAE overload resolution select the test(...) overload.
+#ifdef _WIN32
+#pragma warning( push )
+#pragma warning( disable : 4244 )
+#endif
 static bool const value = sizeof(test(from)) == sizeof(yes);
+#ifdef _WIN32
+#pragma warning( pop )
+#endif
 };
{code}

> c++: proton::coerce() should allow conversion from binary.
> ---
>
> Key: PROTON-1216
> URL: https://issues.apache.org/jira/browse/PROTON-1216
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: 0.12.2
>Reporter: Alan Conway
>Assignee: Alan Conway
> Fix For: 0.13.0
>
>
> proton::coerce should convert a binary value to a std::string. 
> The documentation also needs clarification: coerce should allow exactly those 
> conversions that are allowed as implicit C++ conversions.
> Issue raised in excellent bug report on the user list 
> http://qpid.2158936.n2.nabble.com/Proton-C-0-13-x-decode-binary-type-tp7644510p7644747.html
>  text follows:
> proton::coerce (both forms) currently throws the same
> exception as proton::get, as does value.as_string(), although that doesn't
> appear to be in the public API. Not sure what 'd' was in the d>>b  example,
> but got a version working using value.get() and an implicit
> cast to std::string.
> To reproduce...
> #include 
> #include 
> #include 
> #include 
> template
> void expect_exception ( Lambda f )
> {
>   try
>   {
> f();
> std::cout << "*** FAIL (expected conversion error) ***" << std::endl;
>   }
>   catch ( const proton::conversion_error& e )
>   {
> std::cout << "PASS" << std::endl;
>   }
> }
> template
> void expect_value ( const std::string& expected, Lambda f )
> {
>   try
>   {
> std::cout << (f() == expected ? "PASS" : "*** FAIL (wrong value) ***")
> << std::endl;
>   }
>   catch ( const proton::conversion_error& e )
>   {
> std::cout << "*** FAIL (conversion error) ***" << std::endl;
>   }
> }
> int main()
> {
>   std::string expected = "Hello World!";
>   proton::value value = proton::binary(expected);
>   expect_exception(  [=] { return value.get();   
>  
> });
>   expect_exception(  [=] { return proton::get(value);
>  
> });
>   expect_exception(  [=] { std::string result;
> proton::get(value); return result; });
>   expect_value(expected, [=] () -> std::string { return
> value.get(); } );
>   // The following currently fail under 0.13.x
>   expect_value(expected, [=] { return value.as_string();  
>  
> });
>   expect_value(expected, [=] { return proton::coerce(value); 
>

Re: [jira] [Commented] (QPID-7274) [Java Client] Asynchronous client acknowledgements

2016-06-02 Thread Jakub Scholz 
Hi Keith,

This sounds reasonable. Thanks for looking into it.

Regards
Jakub

On Thu, Jun 2, 2016 at 6:08 PM, Keith W  wrote:

> Hi Jakub
>
> I think the proposal to make the sync optional after a message
> acknowledgement on a {{Session.CLIENT_ACKNOWLEDGE}} session looks
> reasonable. I notice the the 0-8 code path already supports a system
> property {{qpid.sync_after_client.ack}} (which default to true) which
> is used to control whether the sync is performed or not.  I think the
> change should unify behaviour and make it configurable via the
> connection url too.  I think the default behaviour should be unchanged
> i.e. client ack should continue to sync by default.  Does this sound
> reasonable?  I have a change almost ready, including an update to the
> documentation.
>
>
> On 24 May 2016 at 08:44, Keith Wall (JIRA)  wrote:
> >
> > [
> https://issues.apache.org/jira/browse/QPID-7274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297848#comment-15297848
> ]
> >
> > Keith Wall commented on QPID-7274:
> > --
> >
> > Hi Jakub,  Thanks for the contribution.  I hope to be able to take a
> look and comment later this week.
> >
> >> [Java Client] Asynchronous client acknowledgements
> >> --
> >>
> >> Key: QPID-7274
> >> URL: https://issues.apache.org/jira/browse/QPID-7274
> >> Project: Qpid
> >>  Issue Type: Improvement
> >>  Components: Java Client
> >>Reporter: Jakub Scholz
> >> Attachments: sync_ack.patch
> >>
> >>
> >> When the application is using client acknowledgements, they are always
> done in a synchronous way with a sync() being issues after the
> acknowledgement. This can have significant impact on the performance of the
> client applications and it should be possible to configure the client to
> use asynchronous acknowledgements.
> >> The Java AMQP 0-10 client has already a connection URL option called
> "sync_ack" which should affect whether acknowledgements are synchronous or
> asynchronous, but it is used only for auto acknowledgements. It has no
> effect to client acknowledgements.
> >> Attached is a (trivial) patch which synchronizes the acknowledgements
> based on the sync_ack option. It seems to work fine. However, the sync_ack
> option is by default set to false. So using this option would mean that the
> current behavior would change for all current applications using client
> acknowledgements. I'm not sure that is desired. Would it be better to add a
> new option "sync_client_ack" for the client acknowledgements which would
> sync by default? Please let me know what the preferred option is and I can
> update the patch.
> >
> >
> >
> > --
> > This message was sent by Atlassian JIRA
> > (v6.3.4#6332)
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
> > For additional commands, e-mail: dev-h...@qpid.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
> For additional commands, e-mail: dev-h...@qpid.apache.org
>
>

[jira] [Resolved] (PROTON-1220) C examples builds without enabling warnings

2016-06-02 Thread Ken Giusti (JIRA) 

 [ 
https://issues.apache.org/jira/browse/PROTON-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ken Giusti resolved PROTON-1220.

Resolution: Fixed

> C examples builds without enabling warnings
> ---
>
> Key: PROTON-1220
> URL: https://issues.apache.org/jira/browse/PROTON-1220
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: examples
>Affects Versions: 0.13.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Minor
> Fix For: 0.14.0
>
>
> Without turning on warnings it's likely bad changes to the code will be 
> committed (trust me, I know).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: [jira] [Commented] (QPID-7274) [Java Client] Asynchronous client acknowledgements

2016-06-02 Thread Keith W 
Hi Jakub

I think the proposal to make the sync optional after a message
acknowledgement on a {{Session.CLIENT_ACKNOWLEDGE}} session looks
reasonable. I notice the the 0-8 code path already supports a system
property {{qpid.sync_after_client.ack}} (which default to true) which
is used to control whether the sync is performed or not.  I think the
change should unify behaviour and make it configurable via the
connection url too.  I think the default behaviour should be unchanged
i.e. client ack should continue to sync by default.  Does this sound
reasonable?  I have a change almost ready, including an update to the
documentation.


On 24 May 2016 at 08:44, Keith Wall (JIRA)  wrote:
>
> [ 
> https://issues.apache.org/jira/browse/QPID-7274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297848#comment-15297848
>  ]
>
> Keith Wall commented on QPID-7274:
> --
>
> Hi Jakub,  Thanks for the contribution.  I hope to be able to take a look and 
> comment later this week.
>
>> [Java Client] Asynchronous client acknowledgements
>> --
>>
>> Key: QPID-7274
>> URL: https://issues.apache.org/jira/browse/QPID-7274
>> Project: Qpid
>>  Issue Type: Improvement
>>  Components: Java Client
>>Reporter: Jakub Scholz
>> Attachments: sync_ack.patch
>>
>>
>> When the application is using client acknowledgements, they are always done 
>> in a synchronous way with a sync() being issues after the acknowledgement. 
>> This can have significant impact on the performance of the client 
>> applications and it should be possible to configure the client to use 
>> asynchronous acknowledgements.
>> The Java AMQP 0-10 client has already a connection URL option called 
>> "sync_ack" which should affect whether acknowledgements are synchronous or 
>> asynchronous, but it is used only for auto acknowledgements. It has no 
>> effect to client acknowledgements.
>> Attached is a (trivial) patch which synchronizes the acknowledgements based 
>> on the sync_ack option. It seems to work fine. However, the sync_ack option 
>> is by default set to false. So using this option would mean that the current 
>> behavior would change for all current applications using client 
>> acknowledgements. I'm not sure that is desired. Would it be better to add a 
>> new option "sync_client_ack" for the client acknowledgements which would 
>> sync by default? Please let me know what the preferred option is and I can 
>> update the patch.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
> For additional commands, e-mail: dev-h...@qpid.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-06-02 Thread Jem Day (JIRA) 
Jem Day created PROTON-1224:
---

 Summary: Proton-J SSL uses deprecated Bouncy Castle functionality
 Key: PROTON-1224
 URL: https://issues.apache.org/jira/browse/PROTON-1224
 Project: Qpid Proton
  Issue Type: Improvement
  Components: proton-j
Affects Versions: 0.12.2
Reporter: Jem Day


The BouncyCastle project deprecated functionality used by the proton-j driver 
in version 1.48. This causes run-time issues for us as our application 
containers are using newer BC versions.

I've submitted a PR for this change and verified that all tests run using both 
BC 1.48 and 1.54.

Note: The CI pipeline for the PR is flagging an error but i am able to 
build/test locally with no reported errors - build log is attached to the PR 
comments.

https://github.com/apache/qpid-proton/pull/74




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1220) C examples builds without enabling warnings

2016-06-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312535#comment-15312535
 ] 

ASF subversion and git services commented on PROTON-1220:
-

Commit 979ce2c45d4d70e38c8485f71467b272d625023e in qpid-proton's branch 
refs/heads/master from [~kgiusti]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=979ce2c ]

PROTON-1220: add compiler flags for C examples


> C examples builds without enabling warnings
> ---
>
> Key: PROTON-1220
> URL: https://issues.apache.org/jira/browse/PROTON-1220
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: examples
>Affects Versions: 0.13.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Minor
> Fix For: 0.14.0
>
>
> Without turning on warnings it's likely bad changes to the code will be 
> committed (trust me, I know).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7290) [Java Broker] [WMC] Incorrect title on 'Add TrustStore' dialog

2016-06-02 Thread Lorenz Quack (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-7290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312529#comment-15312529
 ] 

Lorenz Quack commented on QPID-7290:


This was fixed as part of QPID-7112 on trunk (i.e., 6.1).
That JIRA is unrelated so here a [deep link  to the 
fix|https://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/management-http/src/main/java/resources/js/qpid/management/addStore.js?r1=1736195=1736194=1736195].

Only question is whether we want to backport to 6.0.x?


> [Java Broker] [WMC] Incorrect title on 'Add TrustStore' dialog
> --
>
> Key: QPID-7290
> URL: https://issues.apache.org/jira/browse/QPID-7290
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Reporter: Rob Godfrey
>Priority: Minor
>
> As reported by [~adelbout...@live.com] in [this 
> mail|http://qpid.2158936.n2.nabble.com/Qpid-Java-Broker-6-0-0-Bug-in-popup-window-when-adding-a-trust-store-and-incomplete-documentation-tp7644940.html]
>  the 'Add Trust Store' dialog is titled 'Add Key Store'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-7291) [Java Broker] [Documentation] Add documentation for ManagedCertificateStore and SiteSpecificTrustStore

2016-06-02 Thread Lorenz Quack (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lorenz Quack updated QPID-7291:
---
Summary: [Java Broker] [Documentation] Add documentation for 
ManagedCertificateStore and SiteSpecificTrustStore  (was: [Java Broker] 
[Documentation] Add documentation for 
ManagedCertificateStoreSiteSpecificTrustStore)

> [Java Broker] [Documentation] Add documentation for ManagedCertificateStore 
> and SiteSpecificTrustStore
> --
>
> Key: QPID-7291
> URL: https://issues.apache.org/jira/browse/QPID-7291
> Project: Qpid
>  Issue Type: Improvement
>  Components: Documentation, Java Broker
>Reporter: Rob Godfrey
>
> As reported by [~adelbout...@live.com] in [this 
> mail|http://qpid.2158936.n2.nabble.com/Qpid-Java-Broker-6-0-0-Bug-in-popup-window-when-adding-a-trust-store-and-incomplete-documentation-tp7644940.html]
>  we are lacking documentation for the 
> ManagedCertificateStoreSiteSpecificTrustStore



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1219) C Reactor sender/receiver examples leak like a sieve and fails to build on windows

2016-06-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312487#comment-15312487
 ] 

ASF subversion and git services commented on PROTON-1219:
-

Commit 4ca0533c418f506c3b6fc554edefc8ecff9fdd6d in qpid-proton's branch 
refs/heads/0.13.x from [~kgiusti]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=4ca0533 ]

PROTON-1219: fix windows errors and signed/unsigned issues

(cherry picked from commit 5cd3d4ee51d8ed8d22bbdc5f782eb88d6b181c06)


> C Reactor sender/receiver examples leak like a sieve and fails to build on 
> windows
> --
>
> Key: PROTON-1219
> URL: https://issues.apache.org/jira/browse/PROTON-1219
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: examples
>Affects Versions: 0.13.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
> Fix For: 0.13.0
>
>
> Tried to fix this once.  Failed miserably.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1219) C Reactor sender/receiver examples leak like a sieve and fails to build on windows

2016-06-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312486#comment-15312486
 ] 

ASF subversion and git services commented on PROTON-1219:
-

Commit 737ffd2f4c98f52c30b39bada5ec3d39be2e5ab9 in qpid-proton's branch 
refs/heads/0.13.x from [~kgiusti]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=737ffd2 ]

PROTON-1219: fix memory leaks in reactor examples.

(cherry picked from commit 47c778e18893f96e2c0b8d17f2d3f87d116b70b3)


> C Reactor sender/receiver examples leak like a sieve and fails to build on 
> windows
> --
>
> Key: PROTON-1219
> URL: https://issues.apache.org/jira/browse/PROTON-1219
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: examples
>Affects Versions: 0.13.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
> Fix For: 0.13.0
>
>
> Tried to fix this once.  Failed miserably.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1219) C Reactor sender/receiver examples leak like a sieve and fails to build on windows

2016-06-02 Thread Justin Ross (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312449#comment-15312449
 ] 

Justin Ross commented on PROTON-1219:
-

Reviewed by Chuck. Approved for 0.13.0.

> C Reactor sender/receiver examples leak like a sieve and fails to build on 
> windows
> --
>
> Key: PROTON-1219
> URL: https://issues.apache.org/jira/browse/PROTON-1219
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: examples
>Affects Versions: 0.13.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
> Fix For: 0.13.0
>
>
> Tried to fix this once.  Failed miserably.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Closed] (PROTON-1223) Windows connection errors are cryptic.

2016-06-02 Thread Cliff Jansen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/PROTON-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cliff Jansen closed PROTON-1223.

Resolution: Fixed

> Windows connection errors are cryptic.
> --
>
> Key: PROTON-1223
> URL: https://issues.apache.org/jira/browse/PROTON-1223
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: 0.14.0
> Environment: Windows. 
>Reporter: Cliff Jansen
>Assignee: Cliff Jansen
> Fix For: 0.14.0
>
>
> If an example program such as helloworld requires a broker and the broker is 
> not running or it's address is mis-specified, the example fails with a 
> completely unhelpful assertion error in debug builds and a barely more 
> comprehensible error message in release builds alluding to a truncated frame.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (QPID-7116) Ability to utilise group information from a LDAP compatible directory

2016-06-02 Thread Lorenz Quack (JIRA) 

 [ 
https://issues.apache.org/jira/browse/QPID-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lorenz Quack resolved QPID-7116.

Resolution: Fixed

> Ability to utilise group information from a LDAP compatible directory
> -
>
> Key: QPID-7116
> URL: https://issues.apache.org/jira/browse/QPID-7116
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Reporter: Keith Wall
>Assignee: Alex Rudyy
> Fix For: qpid-java-6.1
>
> Attachments: 0001-WIP-unification.patch, 0002-WIP-LDAP-groups.patch
>
>
> The Java Broker can already authenticate users against an LDAP compatible 
> directory.  It should also be able to use the same information source as a 
> source of group information too.
> The authentication provide needs to accept optional attributes governing 
> where the group information will be found:
> {{groupSearchContext}} - the base entry for the role search. If not 
> specified, the search base is the top-level directory context.
> {{groupSearchFilter}} - the LDAP search filter for selecting group entries.  
> A {0} token within the filter will be replaced by the distinguish name of the 
> authenticated user.
> {{groupAttributeName}} - the name of the attribute that contains the name of 
> the role.
> After the authentication provider has successfully bound (authenticated) the 
> user, it should perform a second query for the groups.  It should build a 
> {{GroupPrincipal}} for each group to which the user belongs and return this 
> as part of the AuthenticationResult.   If the group search attributes are not 
> found, the group search should be skipped.
> A future version if the LDAP Authentication Provider may offer the ability to 
> cache the group results for a DN period of time.  This would serve to avoid 
> hitting the Directory several times authentication (it already hits the 
> Directory twice if {{bindWithoutSearch}} is false, this will add a third).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7291) [Java Broker] [Documentation] Add documentation for ManagedCertificateStoreSiteSpecificTrustStore

2016-06-02 Thread Adel Boutros (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312293#comment-15312293
 ] 

Adel Boutros commented on QPID-7291:


Sorry but my mail was badly formatted, you should replace 
*ManagedCertificateStoreSiteSpecificTrustStore* with *ManagedCertificateStore 
and SiteSpecificTrustStore*

> [Java Broker] [Documentation] Add documentation for 
> ManagedCertificateStoreSiteSpecificTrustStore
> -
>
> Key: QPID-7291
> URL: https://issues.apache.org/jira/browse/QPID-7291
> Project: Qpid
>  Issue Type: Improvement
>  Components: Documentation, Java Broker
>Reporter: Rob Godfrey
>
> As reported by [~adelbout...@live.com] in [this 
> mail|http://qpid.2158936.n2.nabble.com/Qpid-Java-Broker-6-0-0-Bug-in-popup-window-when-adding-a-trust-store-and-incomplete-documentation-tp7644940.html]
>  we are lacking documentation for the 
> ManagedCertificateStoreSiteSpecificTrustStore



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-7291) [Java Broker] [Documentation] Add documentation for ManagedCertificateStoreSiteSpecificTrustStore

2016-06-02 Thread Rob Godfrey (JIRA) 
Rob Godfrey created QPID-7291:
-

 Summary: [Java Broker] [Documentation] Add documentation for 
ManagedCertificateStoreSiteSpecificTrustStore
 Key: QPID-7291
 URL: https://issues.apache.org/jira/browse/QPID-7291
 Project: Qpid
  Issue Type: Improvement
  Components: Documentation, Java Broker
Reporter: Rob Godfrey


As reported by [~adelbout...@live.com] in [this 
mail|http://qpid.2158936.n2.nabble.com/Qpid-Java-Broker-6-0-0-Bug-in-popup-window-when-adding-a-trust-store-and-incomplete-documentation-tp7644940.html]
 we are lacking documentation for the 
ManagedCertificateStoreSiteSpecificTrustStore



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-7290) [Java Broker] [WMC] Incorrect title on 'Add TrustStore' dialog

2016-06-02 Thread Rob Godfrey (JIRA) 
Rob Godfrey created QPID-7290:
-

 Summary: [Java Broker] [WMC] Incorrect title on 'Add TrustStore' 
dialog
 Key: QPID-7290
 URL: https://issues.apache.org/jira/browse/QPID-7290
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Reporter: Rob Godfrey
Priority: Minor


As reported by [~adelbout...@live.com] in [this 
mail|http://qpid.2158936.n2.nabble.com/Qpid-Java-Broker-6-0-0-Bug-in-popup-window-when-adding-a-trust-store-and-incomplete-documentation-tp7644940.html]
 the 'Add Trust Store' dialog is titled 'Add Key Store'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7282) Java Broker should always send server-final message (if required) to the client on succesful SASL negotiation

2016-06-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/QPID-7282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312283#comment-15312283
 ] 

ASF subversion and git services commented on QPID-7282:
---

Commit 1746557 from [~lorenz.quack] in branch 'java/branches/6.0.x'
[ https://svn.apache.org/r1746557 ]

QPID-7282: [Java Broker] always send server-final message (if required) to the 
client on succesful SASL negotiation

merged from trunk using:
$ svn merge -c 1746140,1746273 ^/qpid/java/trunk
conflicts on AMQPConnection_0_8 and AMQPConnection_1_0 were resolved manually

> Java Broker should always send server-final message (if required) to the 
> client on succesful SASL negotiation
> -
>
> Key: QPID-7282
> URL: https://issues.apache.org/jira/browse/QPID-7282
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.30, 0.32, qpid-java-6.0, qpid-java-6.0.1, 
> qpid-java-6.0.2, qpid-java-6.0.3, qpid-java-6.1
>Reporter: Alex Rudyy
> Fix For: qpid-java-6.1, qpid-java-6.0.4
>
>
> On Scram Sha SASL negotiation Broker does not send server-final challenge 
> (ServerSignature) with the following authentication providers:
> * Simple (SimpleAuthenticationManager)
> * PlainPasswordFile (PlainPasswordDatabaseAuthenticationManager)
> The sasl negotiation for Scram Sha SASL mechanisms should always include 
> sending of server-final message in order to give a chance to verify server 
> signature on a client as per  [RFC 
> 5802|https://tools.ietf.org/html/rfc5802#page-7]
> {quote}
>   The client then authenticates the server by computing the
>ServerSignature and comparing it to the value sent by the server.  If
>the two are different, the client MUST consider the authentication
>exchange to be unsuccessful, and it might have to drop the
>connection.
> {quote}
> We need to change all existing Authentication Provider to support sending of 
> final message



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1219) C Reactor sender/receiver examples leak like a sieve and fails to build on windows

2016-06-02 Thread Chuck Rolke (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312278#comment-15312278
 ] 

Chuck Rolke commented on PROTON-1219:
-

These examples work for me in windows. Approved for 0.13.0

> C Reactor sender/receiver examples leak like a sieve and fails to build on 
> windows
> --
>
> Key: PROTON-1219
> URL: https://issues.apache.org/jira/browse/PROTON-1219
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: examples
>Affects Versions: 0.13.0
>Reporter: Ken Giusti
>Assignee: Ken Giusti
> Fix For: 0.13.0
>
>
> Tried to fix this once.  Failed miserably.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (DISPATCH-343) Router stops accepting connections after load from parallel senders

2016-06-02 Thread Ted Ross (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DISPATCH-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross resolved DISPATCH-343.
---
Resolution: Fixed

> Router stops accepting connections after load from parallel senders
> ---
>
> Key: DISPATCH-343
> URL: https://issues.apache.org/jira/browse/DISPATCH-343
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Routing Engine
>Affects Versions: 0.6.0
>Reporter: Vishal Sharda
>Assignee: Ted Ross
>Priority: Blocker
> Fix For: 0.6.0
>
> Attachments: Connection_aborted.png, Connection_aborted_1.png, 
> Crash.png, Crash_10S_2R.png, R1.conf, R2.conf, R3.conf, 
> Sender_router_crash.png, bt_qd_dealloc.png, bt_qdr_link_cleanup_CT.png, 
> bt_sasl.png, bt_sys_mutex_lock.png, config1_nossl.conf, config2_nossl.conf, 
> drivers.tar.gz, resource-limit-exceeded.png
>
>
> We ran 2 parallel senders and 2 receivers with each sender sending 5 
> messages.  After a while we saw that router stopped accepting connections 
> even from qdstat.  We saw various errors in the logs (screenshots attached).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-343) Router stops accepting connections after load from parallel senders

2016-06-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312181#comment-15312181
 ] 

ASF subversion and git services commented on DISPATCH-343:
--

Commit b765c1b841f868429113a3678934a97cf604c1c1 in qpid-dispatch's branch 
refs/heads/master from [~tr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=b765c1b ]

DISPATCH-343 - Fixed a regression affecting multi-frame presettled deliveries.


> Router stops accepting connections after load from parallel senders
> ---
>
> Key: DISPATCH-343
> URL: https://issues.apache.org/jira/browse/DISPATCH-343
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Routing Engine
>Affects Versions: 0.6.0
>Reporter: Vishal Sharda
>Assignee: Ted Ross
>Priority: Blocker
> Fix For: 0.6.0
>
> Attachments: Connection_aborted.png, Connection_aborted_1.png, 
> Crash.png, Crash_10S_2R.png, R1.conf, R2.conf, R3.conf, 
> Sender_router_crash.png, bt_qd_dealloc.png, bt_qdr_link_cleanup_CT.png, 
> bt_sasl.png, bt_sys_mutex_lock.png, config1_nossl.conf, config2_nossl.conf, 
> drivers.tar.gz, resource-limit-exceeded.png
>
>
> We ran 2 parallel senders and 2 receivers with each sender sending 5 
> messages.  After a while we saw that router stopped accepting connections 
> even from qdstat.  We saw various errors in the logs (screenshots attached).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-343) Router stops accepting connections after load from parallel senders

2016-06-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/DISPATCH-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312180#comment-15312180
 ] 

ASF subversion and git services commented on DISPATCH-343:
--

Commit a19ec1ebb29a7aa7108ba2a02b5d5b5afa4bcd07 in qpid-dispatch's branch 
refs/heads/master from [~tr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=a19ec1e ]

DISPATCH-343 - Updated lifecycle management for deliveries


> Router stops accepting connections after load from parallel senders
> ---
>
> Key: DISPATCH-343
> URL: https://issues.apache.org/jira/browse/DISPATCH-343
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Routing Engine
>Affects Versions: 0.6.0
>Reporter: Vishal Sharda
>Assignee: Ted Ross
>Priority: Blocker
> Fix For: 0.6.0
>
> Attachments: Connection_aborted.png, Connection_aborted_1.png, 
> Crash.png, Crash_10S_2R.png, R1.conf, R2.conf, R3.conf, 
> Sender_router_crash.png, bt_qd_dealloc.png, bt_qdr_link_cleanup_CT.png, 
> bt_sasl.png, bt_sys_mutex_lock.png, config1_nossl.conf, config2_nossl.conf, 
> drivers.tar.gz, resource-limit-exceeded.png
>
>
> We ran 2 parallel senders and 2 receivers with each sender sending 5 
> messages.  After a while we saw that router stopped accepting connections 
> even from qdstat.  We saw various errors in the logs (screenshots attached).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-7289) [Java Broker] SASL challenges and response should be masked in the log file

2016-06-02 Thread Lorenz Quack (JIRA) 
Lorenz Quack created QPID-7289:
--

 Summary: [Java Broker] SASL challenges and response should be 
masked in the log file
 Key: QPID-7289
 URL: https://issues.apache.org/jira/browse/QPID-7289
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Affects Versions: qpid-java-6.0.3, qpid-java-6.0, qpid-java-6.1
Reporter: Lorenz Quack


The broker logs the SAL negotiation at DEBUG level. This includes the 
challenges and response going between the client and the broker.
These contain potentially sensitive information (e.g., user credentials) and 
should therefore be masked.

On AMQP 0-9 they are masked.
On AMQP 0-10 they are not masked.
I did not test 1.0




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1223) Windows connection errors are cryptic.

2016-06-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311903#comment-15311903
 ] 

ASF subversion and git services commented on PROTON-1223:
-

Commit 934b40e35d8bc5c12457e2aeaf354b4187cbd0ef in qpid-proton's branch 
refs/heads/master from Clifford Jansen
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=934b40e ]

PROTON-1223: defer socketclose as long as possible, shorten heartbeat test on 
Windows, mimic POSIX connection failure behavior


> Windows connection errors are cryptic.
> --
>
> Key: PROTON-1223
> URL: https://issues.apache.org/jira/browse/PROTON-1223
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: 0.14.0
> Environment: Windows. 
>Reporter: Cliff Jansen
>Assignee: Cliff Jansen
> Fix For: 0.14.0
>
>
> If an example program such as helloworld requires a broker and the broker is 
> not running or it's address is mis-specified, the example fails with a 
> completely unhelpful assertion error in debug builds and a barely more 
> comprehensible error message in release builds alluding to a truncated frame.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1223) Windows connection errors are cryptic.

2016-06-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311902#comment-15311902
 ] 

ASF subversion and git services commented on PROTON-1223:
-

Commit 088737a64416f38a1e7a4af9d82b2e864150ced8 in qpid-proton's branch 
refs/heads/master from Clifford Jansen
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=088737a ]

PROTON-1223: revert incorrect error status test from f646079


> Windows connection errors are cryptic.
> --
>
> Key: PROTON-1223
> URL: https://issues.apache.org/jira/browse/PROTON-1223
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: 0.14.0
> Environment: Windows. 
>Reporter: Cliff Jansen
>Assignee: Cliff Jansen
> Fix For: 0.14.0
>
>
> If an example program such as helloworld requires a broker and the broker is 
> not running or it's address is mis-specified, the example fails with a 
> completely unhelpful assertion error in debug builds and a barely more 
> comprehensible error message in release builds alluding to a truncated frame.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1222) Some bugs spotted by coverity

2016-06-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311830#comment-15311830
 ] 

ASF subversion and git services commented on PROTON-1222:
-

Commit da8b50a65b246866436fbc4dc5988299a8fc7ec6 in qpid-proton's branch 
refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=da8b50a ]

PROTON-1222: Small fixes for bugs spotted by Coverity


> Some bugs spotted by coverity
> -
>
> Key: PROTON-1222
> URL: https://issues.apache.org/jira/browse/PROTON-1222
> Project: Qpid Proton
>  Issue Type: Bug
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>
> Small fixes for coverity issues:
> CID 126953
> CID 126938



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (PROTON-1223) Windows connection errors are cryptic.

2016-06-02 Thread Cliff Jansen (JIRA) 
Cliff Jansen created PROTON-1223:


 Summary: Windows connection errors are cryptic.
 Key: PROTON-1223
 URL: https://issues.apache.org/jira/browse/PROTON-1223
 Project: Qpid Proton
  Issue Type: Bug
  Components: cpp-binding
Affects Versions: 0.14.0
 Environment: Windows. 
Reporter: Cliff Jansen
Assignee: Cliff Jansen
 Fix For: 0.14.0


If an example program such as helloworld requires a broker and the broker is 
not running or it's address is mis-specified, the example fails with a 
completely unhelpful assertion error in debug builds and a barely more 
comprehensible error message in release builds alluding to a truncated frame.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org