date:20160902

[jira] [Resolved] (DISPATCH-495) Autolinks to non-existent nodes cause problems in the router

2016-09-02 Thread Ted Ross (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross resolved DISPATCH-495.
---
Resolution: Fixed

> Autolinks to non-existent nodes cause problems in the router
> 
>
> Key: DISPATCH-495
> URL: https://issues.apache.org/jira/browse/DISPATCH-495
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.6.1
>Reporter: Ted Ross
>Assignee: Ted Ross
> Fix For: 0.7.0
>
>
> If an autolink is created to a nonexistent node in a running container, a 
> number of problems occurs:
>  - There is a connection error upon the closing of the session for the link, 
> "no such channel", which causes the connection to close.  This is 
> particularly troublesome if there are other successful autolinks operating on 
> the connection.
>  - When the connection closes, there can be a dereferencing of an invalid 
> pn_link_t pointer, causing a segfault.
>  - The rate at which the connection is re-established and subsequently closed 
> is very high, bounded only by available CPU.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (DISPATCH-496) Activation of an autolink does not result in issuing credit to a blocked sender

2016-09-02 Thread Ted Ross (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross resolved DISPATCH-496.
---
Resolution: Fixed

> Activation of an autolink does not result in issuing credit to a blocked 
> sender
> ---
>
> Key: DISPATCH-496
> URL: https://issues.apache.org/jira/browse/DISPATCH-496
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.6.1
>Reporter: Ted Ross
>Assignee: Ted Ross
> Fix For: 0.7.0
>
>
> When a sender attaches to a router with a target address that has no 
> consumers, credit is not issued until such a consumer is available.
> If the first consumer is a node attached via an autolink (i.e. a broker 
> queue), credit is not issued to the blocked sender(s) and they will remain 
> blocked even though there is a valid consumer attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-496) Activation of an autolink does not result in issuing credit to a blocked sender

2016-09-02 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459614#comment-15459614
 ] 

ASF subversion and git services commented on DISPATCH-496:
--

Commit 41b740761adf7fb24dd0de8a5aa0bef604240d5c in qpid-dispatch's branch 
refs/heads/master from [~tr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=41b7407 ]

DISPATCH-496 - Issue credit to blocked senders when an autolink attaches the 
first consumer.


> Activation of an autolink does not result in issuing credit to a blocked 
> sender
> ---
>
> Key: DISPATCH-496
> URL: https://issues.apache.org/jira/browse/DISPATCH-496
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.6.1
>Reporter: Ted Ross
>Assignee: Ted Ross
> Fix For: 0.7.0
>
>
> When a sender attaches to a router with a target address that has no 
> consumers, credit is not issued until such a consumer is available.
> If the first consumer is a node attached via an autolink (i.e. a broker 
> queue), credit is not issued to the blocked sender(s) and they will remain 
> blocked even though there is a valid consumer attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-495) Autolinks to non-existent nodes cause problems in the router

2016-09-02 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459616#comment-15459616
 ] 

ASF subversion and git services commented on DISPATCH-495:
--

Commit bba79f3c68d771624a9b1b54d36ae96f368205b4 in qpid-dispatch's branch 
refs/heads/master from [~tr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=bba79f3 ]

DISPATCH-495 - Improved stability of autolinks and added a set of autolink 
tests.


> Autolinks to non-existent nodes cause problems in the router
> 
>
> Key: DISPATCH-495
> URL: https://issues.apache.org/jira/browse/DISPATCH-495
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.6.1
>Reporter: Ted Ross
>Assignee: Ted Ross
> Fix For: 0.7.0
>
>
> If an autolink is created to a nonexistent node in a running container, a 
> number of problems occurs:
>  - There is a connection error upon the closing of the session for the link, 
> "no such channel", which causes the connection to close.  This is 
> particularly troublesome if there are other successful autolinks operating on 
> the connection.
>  - When the connection closes, there can be a dereferencing of an invalid 
> pn_link_t pointer, causing a segfault.
>  - The rate at which the connection is re-established and subsequently closed 
> is very high, bounded only by available CPU.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Closed] (DISPATCH-497) Activation of an autolink does not result in issuing credit to a blocked sender

2016-09-02 Thread Ted Ross (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross closed DISPATCH-497.
-
Resolution: Duplicate

> Activation of an autolink does not result in issuing credit to a blocked 
> sender
> ---
>
> Key: DISPATCH-497
> URL: https://issues.apache.org/jira/browse/DISPATCH-497
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Router Node
>Affects Versions: 0.6.1
>Reporter: Ted Ross
>Assignee: Ted Ross
> Fix For: 0.7.0
>
>
> When a sender attaches to a router with a target address that has no 
> consumers, credit is not issued until such a consumer is available.
> If the first consumer is a node attached via an autolink (i.e. a broker 
> queue), credit is not issued to the blocked sender(s) and they will remain 
> blocked even though there is a valid consumer attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-497) Activation of an autolink does not result in issuing credit to a blocked sender

2016-09-02 Thread Ted Ross (JIRA)

Ted Ross created DISPATCH-497:
-

 Summary: Activation of an autolink does not result in issuing 
credit to a blocked sender
 Key: DISPATCH-497
 URL: https://issues.apache.org/jira/browse/DISPATCH-497
 Project: Qpid Dispatch
  Issue Type: Bug
  Components: Router Node
Affects Versions: 0.6.1
Reporter: Ted Ross
Assignee: Ted Ross
 Fix For: 0.7.0


When a sender attaches to a router with a target address that has no consumers, 
credit is not issued until such a consumer is available.

If the first consumer is a node attached via an autolink (i.e. a broker queue), 
credit is not issued to the blocked sender(s) and they will remain blocked even 
though there is a valid consumer attached.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-496) Activation of an autolink does not result in issuing credit to a blocked sender

2016-09-02 Thread Ted Ross (JIRA)

Ted Ross created DISPATCH-496:
-

 Summary: Activation of an autolink does not result in issuing 
credit to a blocked sender
 Key: DISPATCH-496
 URL: https://issues.apache.org/jira/browse/DISPATCH-496
 Project: Qpid Dispatch
  Issue Type: Bug
  Components: Router Node
Affects Versions: 0.6.1
Reporter: Ted Ross
Assignee: Ted Ross
 Fix For: 0.7.0


When a sender attaches to a router with a target address that has no consumers, 
credit is not issued until such a consumer is available.

If the first consumer is a node attached via an autolink (i.e. a broker queue), 
credit is not issued to the blocked sender(s) and they will remain blocked even 
though there is a valid consumer attached.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPIDJMS-164) Provide an OSGi bundle for the Qpid JMS client

2016-09-02 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459417#comment-15459417
 ] 

ASF GitHub Bot commented on QPIDJMS-164:


Github user chirino closed the pull request at:

https://github.com/apache/qpid-jms/pull/2


> Provide an OSGi bundle for the Qpid JMS client
> --
>
> Key: QPIDJMS-164
> URL: https://issues.apache.org/jira/browse/QPIDJMS-164
> Project: Qpid JMS
>  Issue Type: Improvement
>Reporter: Hiram Chirino
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-jms pull request #2: Implements QPIDJMS-164 - Provide an OSGi bundle fo...

2016-09-02 Thread chirino

Github user chirino closed the pull request at:

https://github.com/apache/qpid-jms/pull/2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (PROTON-1295) [proton-j] some unencrypted private keys won't load

2016-09-02 Thread Robbie Gemmell (JIRA)


 [ 
https://issues.apache.org/jira/browse/PROTON-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell resolved PROTON-1295.

Resolution: Fixed
  Assignee: Robbie Gemmell

> [proton-j] some unencrypted private keys won't load
> ---
>
> Key: PROTON-1295
> URL: https://issues.apache.org/jira/browse/PROTON-1295
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-j
>Affects Versions: 0.15.0
>Reporter: Daniel Evans
>Assignee: Robbie Gemmell
>
> In SslEngineFacadeFactory, line 469,
> privateKey = (PrivateKey) getPrivateKeyMethod.invoke(pemObject);
> I think should read
> privateKey = (PrivateKey) getPrivateKeyMethod.invoke(keyConverter, pemObject);
> At the moment it throws an exception on method evocation since the method 
> doesn't exist in pemObject.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1295) [proton-j] some unencrypted private keys won't load

2016-09-02 Thread Daniel Evans (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459371#comment-15459371
 ] 

Daniel Evans commented on PROTON-1295:
--

Thanks for jumping on it.

> [proton-j] some unencrypted private keys won't load
> ---
>
> Key: PROTON-1295
> URL: https://issues.apache.org/jira/browse/PROTON-1295
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-j
>Affects Versions: 0.15.0
>Reporter: Daniel Evans
>
> In SslEngineFacadeFactory, line 469,
> privateKey = (PrivateKey) getPrivateKeyMethod.invoke(pemObject);
> I think should read
> privateKey = (PrivateKey) getPrivateKeyMethod.invoke(keyConverter, pemObject);
> At the moment it throws an exception on method evocation since the method 
> doesn't exist in pemObject.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1295) [proton-j] some unencrypted private keys won't load

2016-09-02 Thread Robbie Gemmell (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459334#comment-15459334
 ] 

Robbie Gemmell commented on PROTON-1295:


Note that I've left the fix-for blank to avoid a dupe in the release notes, as 
its covered by PROTON-1224 already.

> [proton-j] some unencrypted private keys won't load
> ---
>
> Key: PROTON-1295
> URL: https://issues.apache.org/jira/browse/PROTON-1295
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-j
>Affects Versions: 0.15.0
>Reporter: Daniel Evans
>
> In SslEngineFacadeFactory, line 469,
> privateKey = (PrivateKey) getPrivateKeyMethod.invoke(pemObject);
> I think should read
> privateKey = (PrivateKey) getPrivateKeyMethod.invoke(keyConverter, pemObject);
> At the moment it throws an exception on method evocation since the method 
> doesn't exist in pemObject.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (PROTON-1295) [proton-j] some unencrypted private keys won't load

2016-09-02 Thread Robbie Gemmell (JIRA)


 [ 
https://issues.apache.org/jira/browse/PROTON-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated PROTON-1295:
---
Summary: [proton-j] some unencrypted private keys won't load  (was: 
Proton-j unencrypted private key won't load)

> [proton-j] some unencrypted private keys won't load
> ---
>
> Key: PROTON-1295
> URL: https://issues.apache.org/jira/browse/PROTON-1295
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-j
>Affects Versions: 0.15.0
>Reporter: Daniel Evans
>
> In SslEngineFacadeFactory, line 469,
> privateKey = (PrivateKey) getPrivateKeyMethod.invoke(pemObject);
> I think should read
> privateKey = (PrivateKey) getPrivateKeyMethod.invoke(keyConverter, pemObject);
> At the moment it throws an exception on method evocation since the method 
> doesn't exist in pemObject.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1295) Proton-j unencrypted private key won't load

2016-09-02 Thread Robbie Gemmell (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459324#comment-15459324
 ] 

Robbie Gemmell commented on PROTON-1295:


Thanks for catching this, I missed that during review. Though it appeared to 
already be tested the type of keyfile meant that it didn't in fact hit that 
codepath after all. I've added an additional test+keyfile to ensure it does, 
and made the suggested change. 

> Proton-j unencrypted private key won't load
> ---
>
> Key: PROTON-1295
> URL: https://issues.apache.org/jira/browse/PROTON-1295
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-j
>Affects Versions: 0.15.0
>Reporter: Daniel Evans
>
> In SslEngineFacadeFactory, line 469,
> privateKey = (PrivateKey) getPrivateKeyMethod.invoke(pemObject);
> I think should read
> privateKey = (PrivateKey) getPrivateKeyMethod.invoke(keyConverter, pemObject);
> At the moment it throws an exception on method evocation since the method 
> doesn't exist in pemObject.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) [proton-j] use newer versions of BouncyCastle

2016-09-02 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459309#comment-15459309
 ] 

ASF subversion and git services commented on PROTON-1224:
-

Commit 21b0b76d0ee070bb5b5d37434694988a6dd28dc8 in qpid-proton's branch 
refs/heads/master from Robert Gemmell
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=21b0b76 ]

PROTON-1224, PROTON-1295: fix recent change to ensure method is invoked on the 
converter, add additional keyfile+test to ensure tests really do exercise that 
codepath


> [proton-j] use newer versions of BouncyCastle
> -
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.14.0
>Reporter: Jem Day
>Assignee: Robbie Gemmell
> Fix For: 0.15.0
>
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> Thanks for you patience with this, hopefully this is now cleaner PR, I have 
> closed the original PR #75
> Jem



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (PROTON-1295) Proton-j unencrypted private key won't load

2016-09-02 Thread Daniel Evans (JIRA)

Daniel Evans created PROTON-1295:


 Summary: Proton-j unencrypted private key won't load
 Key: PROTON-1295
 URL: https://issues.apache.org/jira/browse/PROTON-1295
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-j
Affects Versions: 0.15.0
Reporter: Daniel Evans


In SslEngineFacadeFactory, line 469,

privateKey = (PrivateKey) getPrivateKeyMethod.invoke(pemObject);

I think should read

privateKey = (PrivateKey) getPrivateKeyMethod.invoke(keyConverter, pemObject);

At the moment it throws an exception on method evocation since the method 
doesn't exist in pemObject.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (DISPATCH-495) Autolinks to non-existent nodes cause problems in the router

2016-09-02 Thread Ted Ross (JIRA)

Ted Ross created DISPATCH-495:
-

 Summary: Autolinks to non-existent nodes cause problems in the 
router
 Key: DISPATCH-495
 URL: https://issues.apache.org/jira/browse/DISPATCH-495
 Project: Qpid Dispatch
  Issue Type: Bug
  Components: Router Node
Affects Versions: 0.6.1
Reporter: Ted Ross
Assignee: Ted Ross
 Fix For: 0.7.0


If an autolink is created to a nonexistent node in a running container, a 
number of problems occurs:
 - There is a connection error upon the closing of the session for the link, 
"no such channel", which causes the connection to close.  This is particularly 
troublesome if there are other successful autolinks operating on the connection.
 - When the connection closes, there can be a dereferencing of an invalid 
pn_link_t pointer, causing a segfault.
 - The rate at which the connection is re-established and subsequently closed 
is very high, bounded only by available CPU.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-350) Display list of links for client connections. Allow acquiesce of links

2016-09-02 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458943#comment-15458943
 ] 

ASF subversion and git services commented on DISPATCH-350:
--

Commit ddc85fab8ffdc2e78a1ba5f586adafeb1ddb2445 in qpid-dispatch's branch 
refs/heads/master from [~eallen]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=ddc85fa ]

DISPATCH-350 Fix rate calculation for links


> Display list of links for client connections. Allow acquiesce of links
> --
>
> Key: DISPATCH-350
> URL: https://issues.apache.org/jira/browse/DISPATCH-350
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Affects Versions: 0.7.0
>Reporter: Ernest Allen
>Assignee: Ernest Allen
> Fix For: 0.7.0
>
>
> On the topology page when a client is clicked, a list of links should be 
> displayed. 
> The link direction, admin state, owning address, delivery count, etc. should 
> be shown. 
> There should be an option to send a request to acquiesce any or all of the 
> links for a connection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Closed] (QPID-7343) [Java Client] 0-10 code path fails to reconnect following AMQP redirect

2016-09-02 Thread Keith Wall (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-7343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall closed QPID-7343.

Resolution: Cannot Reproduce

> [Java Client] 0-10 code path fails to reconnect following AMQP redirect
> ---
>
> Key: QPID-7343
> URL: https://issues.apache.org/jira/browse/QPID-7343
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: qpid-java-6.1
>Reporter: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1
>
>
> I notice that if I try and use the VH Redirector feature of the Java Broker, 
> the Java Client, on the 0-10 path, fails to connect correctly to the host 
> following redirect from the Broker.The client logs suggests a state 
> management problem within the client itself.
> On the 0-8..0-91 path, redirection works corrected.
> I have not investigated further and do not know if this is a regression.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7343) [Java Client] 0-10 code path fails to reconnect following AMQP redirect

2016-09-02 Thread Keith Wall (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-7343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458938#comment-15458938
 ] 

Keith Wall commented on QPID-7343:
--

I am no longer able to reproduce this problem.

> [Java Client] 0-10 code path fails to reconnect following AMQP redirect
> ---
>
> Key: QPID-7343
> URL: https://issues.apache.org/jira/browse/QPID-7343
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: qpid-java-6.1
>Reporter: Keith Wall
>Priority: Minor
> Fix For: qpid-java-6.1
>
>
> I notice that if I try and use the VH Redirector feature of the Java Broker, 
> the Java Client, on the 0-10 path, fails to connect correctly to the host 
> following redirect from the Broker.The client logs suggests a state 
> management problem within the client itself.
> On the 0-8..0-91 path, redirection works corrected.
> I have not investigated further and do not know if this is a regression.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Assigned] (QPID-7408) REST API streams compressed message content without a Content-Encoding header

2016-09-02 Thread Alex Rudyy (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy reassigned QPID-7408:


Assignee: Alex Rudyy  (was: Lorenz Quack)

> REST API streams compressed message content without a Content-Encoding header
> -
>
> Key: QPID-7408
> URL: https://issues.apache.org/jira/browse/QPID-7408
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.30, 0.32, qpid-java-6.0, qpid-java-6.1
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-6.1
>
>
> The Broker for Java supports compressed messages.  If I view a compressed 
> message through the management console, the Broker sends the content to the 
> client without a {{Content-Encoding}} header, so the client treats the bytes 
> as if they were uncompressed.  If the message's mime type is {{text/*}}, I 
> see seeming garbage instead of the inlined text content.  If the message's 
> mime type is something else the browser handles the content as if it were 
> uncompressed.  This could confused applications associated with the Browser.
> This could potentially hinder an operator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7413) [Java Broker, WMC] Fix minor defects and usability issues in query and dashboard UI

2016-09-02 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-7413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458900#comment-15458900
 ] 

ASF subversion and git services commented on QPID-7413:
---

Commit 1758983 from oru...@apache.org in branch 'java/trunk'
[ https://svn.apache.org/r1758983 ]

QPID-7413: [Java Broker, WMC] Fix label and tooltip for query clone dialog

> [Java Broker, WMC] Fix minor defects and usability issues in query and 
> dashboard UI
> ---
>
> Key: QPID-7413
> URL: https://issues.apache.org/jira/browse/QPID-7413
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0.1
>Reporter: Alex Rudyy
>Assignee: Lorenz Quack
> Fix For: qpid-java-6.1
>
>
> # Menu bar - the serialized form of the username in the menu bar looks ugly
> # Menu bar is a muddle of some with icons some with text and some with both.  
> We said all menu titles would have a word and icon.  We said menu entries 
> would not have an icon.
> # Rename Show Xxx Browser => Browse Xx
> # Add explanatory text to the Create Query and Create Dashboard dialogues to 
> help the user understand what scope and category mean.
> # In the save dialogues, the fully qualified name of the group should be 
> visible to the user, perhaps as a hover.
> # A newly cloned query does not warn if it is closed before save has been 
> pressed.
> # Use qpid confirmation dialogue box instead of system confirmation dialogue 
> universally
> # On the Query and Dashboard browsers rename "Mine" to "Created by me"
> # Add the ability select a query from the query browser with the Return key.
> # Add an icon to the "Add Widget" button
> # Add units to the refresh period in the widget customization dialogue
> # Defect:  With a group of HA nodes, create a virtualhost scoped dashboard 
> containing a virtualhost scoped query,   Flip the mastership Expected 
> behaviour - dashboard and widget should be present on the new master.  
> Actual: dashboard was present but was empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7413) [Java Broker, WMC] Fix minor defects and usability issues in query and dashboard UI

2016-09-02 Thread Lorenz Quack (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-7413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458882#comment-15458882
 ] 

Lorenz Quack commented on QPID-7413:


Seems like you overlooked the first point of my comments:
 * The clone dialogue for queries still has the old wording for scope

> [Java Broker, WMC] Fix minor defects and usability issues in query and 
> dashboard UI
> ---
>
> Key: QPID-7413
> URL: https://issues.apache.org/jira/browse/QPID-7413
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0.1
>Reporter: Alex Rudyy
>Assignee: Lorenz Quack
> Fix For: qpid-java-6.1
>
>
> # Menu bar - the serialized form of the username in the menu bar looks ugly
> # Menu bar is a muddle of some with icons some with text and some with both.  
> We said all menu titles would have a word and icon.  We said menu entries 
> would not have an icon.
> # Rename Show Xxx Browser => Browse Xx
> # Add explanatory text to the Create Query and Create Dashboard dialogues to 
> help the user understand what scope and category mean.
> # In the save dialogues, the fully qualified name of the group should be 
> visible to the user, perhaps as a hover.
> # A newly cloned query does not warn if it is closed before save has been 
> pressed.
> # Use qpid confirmation dialogue box instead of system confirmation dialogue 
> universally
> # On the Query and Dashboard browsers rename "Mine" to "Created by me"
> # Add the ability select a query from the query browser with the Return key.
> # Add an icon to the "Add Widget" button
> # Add units to the refresh period in the widget customization dialogue
> # Defect:  With a group of HA nodes, create a virtualhost scoped dashboard 
> containing a virtualhost scoped query,   Flip the mastership Expected 
> behaviour - dashboard and widget should be present on the new master.  
> Actual: dashboard was present but was empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7382) Message dialogue tries to inline the text of a text message content regardless of the its length

2016-09-02 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458846#comment-15458846
 ] 

ASF subversion and git services commented on QPID-7382:
---

Commit 1758980 from [~lorenz.quack] in branch 'java/trunk'
[ https://svn.apache.org/r1758980 ]

QPID-7382: [Java Broker, WMC] Add Content-Disposition to Message download

also address Alex's other review comments:
 * make content dialogue use 100% width
 * move preview markup code from javascript to html

> Message dialogue tries to inline the text of a text message content 
> regardless of the its length
> 
>
> Key: QPID-7382
> URL: https://issues.apache.org/jira/browse/QPID-7382
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.30, 0.32, qpid-java-6.0
>Reporter: Keith Wall
> Fix For: qpid-java-6.1, qpid-java-6.0.5
>
> Attachments: suggested-changes.diff
>
>
> When viewing a message through the WMC, if the message's mime type indicates 
> that the content it text, the message dialogue tries to inline the content, 
> properly escaping the content first.  If the content is very large, this 
> approach is problematic and can cause formatting problems with buttons out of 
> reach, or at worst an unresponsive or crashed client side UI.
> The WMC should display the leading portion of a long text message using 
> ellipses and offer a download button to retrieve the full text content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Resolved] (DISPATCH-494) Policy objects do not support management update and delete directives

2016-09-02 Thread Chuck Rolke (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chuck Rolke resolved DISPATCH-494.
--
   Resolution: Fixed
Fix Version/s: 0.7.0

Fixed at commit d35659

> Policy objects do not support management update and delete directives
> -
>
> Key: DISPATCH-494
> URL: https://issues.apache.org/jira/browse/DISPATCH-494
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Policy Engine
>Affects Versions: 0.6.1
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
> Fix For: 0.7.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1293) Support username and password in electron go binding

2016-09-02 Thread Alan Conway (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458764#comment-15458764
 ] 

Alan Conway commented on PROTON-1293:
-

You are correct but it is useful to know that there is specific interest in Go 
electron, since proton-1255 covers the C core and several different language 
bindings. I'll raise this in my todo list.

> Support username and password in electron go binding
> 
>
> Key: PROTON-1293
> URL: https://issues.apache.org/jira/browse/PROTON-1293
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: go-binding
>Affects Versions: 0.15.0
>Reporter: Richard Laos
>Assignee: Alan Conway
>Priority: Minor
>
> It appears that the electron api does not support a username and password as 
> part of an amqp connection. However maybe the example just needs to included 
> this if it is supported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Assigned] (QPID-7413) [Java Broker, WMC] Fix minor defects and usability issues in query and dashboard UI

2016-09-02 Thread Alex Rudyy (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-7413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy reassigned QPID-7413:


Assignee: Lorenz Quack  (was: Alex Rudyy)

Lorenz,
I addressed your remaining comments in commit under revision [ 
https://svn.apache.org/r1758967 ].
Additionally I noticed some errors on deletion of dashboard and query tabs 
caused by premature deletion of content panes.
I also fixed leaking of resources for dashboard dialogs

> [Java Broker, WMC] Fix minor defects and usability issues in query and 
> dashboard UI
> ---
>
> Key: QPID-7413
> URL: https://issues.apache.org/jira/browse/QPID-7413
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0.1
>Reporter: Alex Rudyy
>Assignee: Lorenz Quack
> Fix For: qpid-java-6.1
>
>
> # Menu bar - the serialized form of the username in the menu bar looks ugly
> # Menu bar is a muddle of some with icons some with text and some with both.  
> We said all menu titles would have a word and icon.  We said menu entries 
> would not have an icon.
> # Rename Show Xxx Browser => Browse Xx
> # Add explanatory text to the Create Query and Create Dashboard dialogues to 
> help the user understand what scope and category mean.
> # In the save dialogues, the fully qualified name of the group should be 
> visible to the user, perhaps as a hover.
> # A newly cloned query does not warn if it is closed before save has been 
> pressed.
> # Use qpid confirmation dialogue box instead of system confirmation dialogue 
> universally
> # On the Query and Dashboard browsers rename "Mine" to "Created by me"
> # Add the ability select a query from the query browser with the Return key.
> # Add an icon to the "Add Widget" button
> # Add units to the refresh period in the widget customization dialogue
> # Defect:  With a group of HA nodes, create a virtualhost scoped dashboard 
> containing a virtualhost scoped query,   Flip the mastership Expected 
> behaviour - dashboard and widget should be present on the new master.  
> Actual: dashboard was present but was empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-7413) [Java Broker, WMC] Fix minor defects and usability issues in query and dashboard UI

2016-09-02 Thread Alex Rudyy (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-7413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-7413:
-
Status: Reviewable  (was: In Progress)

> [Java Broker, WMC] Fix minor defects and usability issues in query and 
> dashboard UI
> ---
>
> Key: QPID-7413
> URL: https://issues.apache.org/jira/browse/QPID-7413
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
> Fix For: qpid-java-6.1
>
>
> # Menu bar - the serialized form of the username in the menu bar looks ugly
> # Menu bar is a muddle of some with icons some with text and some with both.  
> We said all menu titles would have a word and icon.  We said menu entries 
> would not have an icon.
> # Rename Show Xxx Browser => Browse Xx
> # Add explanatory text to the Create Query and Create Dashboard dialogues to 
> help the user understand what scope and category mean.
> # In the save dialogues, the fully qualified name of the group should be 
> visible to the user, perhaps as a hover.
> # A newly cloned query does not warn if it is closed before save has been 
> pressed.
> # Use qpid confirmation dialogue box instead of system confirmation dialogue 
> universally
> # On the Query and Dashboard browsers rename "Mine" to "Created by me"
> # Add the ability select a query from the query browser with the Return key.
> # Add an icon to the "Add Widget" button
> # Add units to the refresh period in the widget customization dialogue
> # Defect:  With a group of HA nodes, create a virtualhost scoped dashboard 
> containing a virtualhost scoped query,   Flip the mastership Expected 
> behaviour - dashboard and widget should be present on the new master.  
> Actual: dashboard was present but was empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7413) [Java Broker, WMC] Fix minor defects and usability issues in query and dashboard UI

2016-09-02 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-7413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458721#comment-15458721
 ] 

ASF subversion and git services commented on QPID-7413:
---

Commit 1758967 from oru...@apache.org in branch 'java/trunk'
[ https://svn.apache.org/r1758967 ]

QPID-7413: [Java Broker, WMC] Address review comments

   Fix tooltip text for query scope
   Optimize rendering of groups and owner in PreferenceBrowser
   Stop leaking resources from dashboard UI
   Avoid premature deletion of dashboard and query content panes from 
TabContainer

> [Java Broker, WMC] Fix minor defects and usability issues in query and 
> dashboard UI
> ---
>
> Key: QPID-7413
> URL: https://issues.apache.org/jira/browse/QPID-7413
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
> Fix For: qpid-java-6.1
>
>
> # Menu bar - the serialized form of the username in the menu bar looks ugly
> # Menu bar is a muddle of some with icons some with text and some with both.  
> We said all menu titles would have a word and icon.  We said menu entries 
> would not have an icon.
> # Rename Show Xxx Browser => Browse Xx
> # Add explanatory text to the Create Query and Create Dashboard dialogues to 
> help the user understand what scope and category mean.
> # In the save dialogues, the fully qualified name of the group should be 
> visible to the user, perhaps as a hover.
> # A newly cloned query does not warn if it is closed before save has been 
> pressed.
> # Use qpid confirmation dialogue box instead of system confirmation dialogue 
> universally
> # On the Query and Dashboard browsers rename "Mine" to "Created by me"
> # Add the ability select a query from the query browser with the Return key.
> # Add an icon to the "Add Widget" button
> # Add units to the refresh period in the widget customization dialogue
> # Defect:  With a group of HA nodes, create a virtualhost scoped dashboard 
> containing a virtualhost scoped query,   Flip the mastership Expected 
> behaviour - dashboard and widget should be present on the new master.  
> Actual: dashboard was present but was empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-494) Policy objects do not support management update and delete directives

2016-09-02 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458667#comment-15458667
 ] 

ASF subversion and git services commented on DISPATCH-494:
--

Commit d356593fef5935edda538734f5ccb48c2bb37764 in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=d356593 ]

DISPATCH-494: Policy vhost support for mgmt Update and Delete

Sets proper field attributes in qdrouter.json to allow ops.
Add hooks in agent and policy manager to relay mgmt ops to policy code.
Add self tests to exercise vhost add, update, and delete.


> Policy objects do not support management update and delete directives
> -
>
> Key: DISPATCH-494
> URL: https://issues.apache.org/jira/browse/DISPATCH-494
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Policy Engine
>Affects Versions: 0.6.1
>Reporter: Chuck Rolke
>Assignee: Chuck Rolke
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Updated] (QPID-7382) Message dialogue tries to inline the text of a text message content regardless of the its length

2016-09-02 Thread Alex Rudyy (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-7382:
-
Attachment: suggested-changes.diff

> Message dialogue tries to inline the text of a text message content 
> regardless of the its length
> 
>
> Key: QPID-7382
> URL: https://issues.apache.org/jira/browse/QPID-7382
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.30, 0.32, qpid-java-6.0
>Reporter: Keith Wall
> Fix For: qpid-java-6.1, qpid-java-6.0.5
>
> Attachments: suggested-changes.diff
>
>
> When viewing a message through the WMC, if the message's mime type indicates 
> that the content it text, the message dialogue tries to inline the content, 
> properly escaping the content first.  If the content is very large, this 
> approach is problematic and can cause formatting problems with buttons out of 
> reach, or at worst an unresponsive or crashed client side UI.
> The WMC should display the leading portion of a long text message using 
> ellipses and offer a download button to retrieve the full text content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Comment Edited] (QPID-7382) Message dialogue tries to inline the text of a text message content regardless of the its length

2016-09-02 Thread Alex Rudyy (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458595#comment-15458595
 ] 

Alex Rudyy edited comment on QPID-7382 at 9/2/16 1:56 PM:
--

Lorenz,
Here are my review comments.
# The implemented changes look good to me. However, I am wondering would not it 
be better to move the html markup for download link and preview into a template 
rather then generating html on the flight?
# It seems an existing defect but the content of dialog does not occupy 100% of 
the space. I think it can be fixed as part of this JIRA by committing the 
following change
{code}
broker-plugins/management-http/src/main/java/resources/showMessage.html
@@ -18,7 +18,7 @@
 
 
 
-
+
 
 Message Number:
 
{code}
# By clicking on download link the message content is replacing WMC UI. 
Although it is an existing issue, I think that it needs to be fixed to make 
content downloading user friendly by adding Content-Disposition header to the 
content, for example:
{code}
broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
@@ -2684,11 +2684,13 @@ public abstract class AbstractQueue>
 public static final int UNLIMITED = -1;
 private final MessageReference _messageReference;
 private final long _limit;
+private final String _queueName;
 
-public MessageContent(MessageReference messageReference, long limit)
+public MessageContent(MessageReference messageReference, long 
limit, String queueName)
 {
 _messageReference = messageReference;
 _limit = (limit == UNLIMITED ? 
messageReference.getMessage().getSize() : limit);
+_queueName = queueName;
 }
 
 @Override
@@ -2735,6 +2737,12 @@ public abstract class AbstractQueue>
 return 
_messageReference.getMessage().getMessageHeader().getEncoding();
 }
 
+@RestContentHeader("Content-Disposition")
+public String getContentDisposition()
+{
+return "attachment; filename=\"" + _queueName
+   + "/" + _messageReference.getMessage().getMessageNumber() + 
"\"";
+}
 }
 
 private static class AcquireAllQueueEntryFilter implements QueueEntryFilter
@@ -3507,7 +3515,7 @@ public abstract class AbstractQueue>
 visit(messageFinder);
 if(messageFinder.isFound())
 {
-return new MessageContent(messageFinder.getMessageReference(), 
limit);
+return new MessageContent(messageFinder.getMessageReference(), 
limit, this.getName());
 }
 else
 {
{code}

I think that 2 and 3 should be addressed whilst 1 is up to you to decide 
whether we can make code a bit nicer by moving markup into template.


was (Author: alex.rufous):
Lorenz,
Here are my review comments.
# The implemented changes look good to me. However, I am wondering would not it 
be better to move the html markup for download link and preview into a template 
rather then generating html on the flight?
# It seems an existing defect but the content of dialog does not occupy 100% of 
the space. I think it can be fixed as part of this JIRA by committing the 
following change
{code}
broker-plugins/management-http/src/main/java/resources/showMessage.html
@@ -18,7 +18,7 @@
 
 
 
-
+
 
 Message Number:
 
{code}
# By clicking on download link the message content is replacing WMC UI. 
Although it is an existing issue, I think that it needs to be fixed to make 
content downloading user friendly by adding Content-Disposition header to the 
content, for example:
{code}
broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
@@ -2684,11 +2684,13 @@ public abstract class AbstractQueue>
 public static final int UNLIMITED = -1;
 private final MessageReference _messageReference;
 private final long _limit;
+private final String _queueName;
 
-public MessageContent(MessageReference messageReference, long limit)
+public MessageContent(MessageReference messageReference, long 
limit, String queueName)
 {
 _messageReference = messageReference;
 _limit = (limit == UNLIMITED ? 
messageReference.getMessage().getSize() : limit);
+_queueName = queueName;
 }
 
 @Override
@@ -2735,6 +2737,12 @@ public abstract class AbstractQueue>
 return 
_messageReference.getMessage().getMessageHeader().getEncoding();
 }
 
+@RestContentHeader("Content-Disposition")
+public String getContentDisposition()
+{
+return "attachment; filename=\"" + _queueName
+   + "/" + _messageReference.getMessage().getMessageHeader() + 
"\"";
+}
 }
 
 private static class AcquireAllQueueEntryFilter implements QueueEntryFilter

[jira] [Comment Edited] (QPID-7382) Message dialogue tries to inline the text of a text message content regardless of the its length

2016-09-02 Thread Alex Rudyy (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458595#comment-15458595
 ] 

Alex Rudyy edited comment on QPID-7382 at 9/2/16 1:55 PM:
--

Lorenz,
Here are my review comments.
# The implemented changes look good to me. However, I am wondering would not it 
be better to move the html markup for download link and preview into a template 
rather then generating html on the flight?
# It seems an existing defect but the content of dialog does not occupy 100% of 
the space. I think it can be fixed as part of this JIRA by committing the 
following change
{code}
broker-plugins/management-http/src/main/java/resources/showMessage.html
@@ -18,7 +18,7 @@
 
 
 
-
+
 
 Message Number:
 
{code}
# By clicking on download link the message content is replacing WMC UI. 
Although it is an existing issue, I think that it needs to be fixed to make 
content downloading user friendly by adding Content-Disposition header to the 
content, for example:
{code}
broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
@@ -2684,11 +2684,13 @@ public abstract class AbstractQueue>
 public static final int UNLIMITED = -1;
 private final MessageReference _messageReference;
 private final long _limit;
+private final String _queueName;
 
-public MessageContent(MessageReference messageReference, long limit)
+public MessageContent(MessageReference messageReference, long 
limit, String queueName)
 {
 _messageReference = messageReference;
 _limit = (limit == UNLIMITED ? 
messageReference.getMessage().getSize() : limit);
+_queueName = queueName;
 }
 
 @Override
@@ -2735,6 +2737,12 @@ public abstract class AbstractQueue>
 return 
_messageReference.getMessage().getMessageHeader().getEncoding();
 }
 
+@RestContentHeader("Content-Disposition")
+public String getContentDisposition()
+{
+return "attachment; filename=\"" + _queueName
+   + "/" + _messageReference.getMessage().getMessageHeader() + 
"\"";
+}
 }
 
 private static class AcquireAllQueueEntryFilter implements QueueEntryFilter
@@ -3507,7 +3515,7 @@ public abstract class AbstractQueue>
 visit(messageFinder);
 if(messageFinder.isFound())
 {
-return new MessageContent(messageFinder.getMessageReference(), 
limit);
+return new MessageContent(messageFinder.getMessageReference(), 
limit, this.getName());
 }
 else
 {
{code}

I think that 2 and 3 should be addressed whilst 1 is up to you to decide 
whether we can make code a bit nicer by moving markup into template.


was (Author: alex.rufous):
Lorenz,
Here are my review comments.
# The implemented changes look good to me. However, I am wondering would not it 
be easier to move the html markup for download link and preview into a template 
class rather then generating html on the flight?
# It seems an existing defect but the content of dialog does not occupy 100% of 
the space. I think it can be fixed as part of this JIRA by committing the 
following change
{code}
broker-plugins/management-http/src/main/java/resources/showMessage.html
@@ -18,7 +18,7 @@
 
 
 
-
+
 
 Message Number:
 
{code}
# By clicking on download link the message content is replacing WMC UI. 
Although it is an existing issue, I think that it needs to be fixed to make 
content downloading user friendly by adding Content-Disposition header to the 
content, for example:
{code}
broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
@@ -2684,11 +2684,13 @@ public abstract class AbstractQueue>
 public static final int UNLIMITED = -1;
 private final MessageReference _messageReference;
 private final long _limit;
+private final String _queueName;
 
-public MessageContent(MessageReference messageReference, long limit)
+public MessageContent(MessageReference messageReference, long 
limit, String queueName)
 {
 _messageReference = messageReference;
 _limit = (limit == UNLIMITED ? 
messageReference.getMessage().getSize() : limit);
+_queueName = queueName;
 }
 
 @Override
@@ -2735,6 +2737,12 @@ public abstract class AbstractQueue>
 return 
_messageReference.getMessage().getMessageHeader().getEncoding();
 }
 
+@RestContentHeader("Content-Disposition")
+public String getContentDisposition()
+{
+return "attachment; filename=\"" + _queueName
+   + "/" + _messageReference.getMessage().getMessageHeader() + 
"\"";
+}
 }
 
 private static class AcquireAllQueueEntryFilter implements

[jira] [Commented] (QPID-7382) Message dialogue tries to inline the text of a text message content regardless of the its length

2016-09-02 Thread Alex Rudyy (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458595#comment-15458595
 ] 

Alex Rudyy commented on QPID-7382:
--

Lorenz,
Here are my review comments.
# The implemented changes look good to me. However, I am wondering would not it 
be easier to move the html markup for download link and preview into a template 
class rather then generating html on the flight?
# It seems an existing defect but the content of dialog does not occupy 100% of 
the space. I think it can be fixed as part of this JIRA by committing the 
following change
{code}
broker-plugins/management-http/src/main/java/resources/showMessage.html
@@ -18,7 +18,7 @@
 
 
 
-
+
 
 Message Number:
 
{code}
# By clicking on download link the message content is replacing WMC UI. 
Although it is an existing issue, I think that it needs to be fixed to make 
content downloading user friendly by adding Content-Disposition header to the 
content, for example:
{code}
broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
@@ -2684,11 +2684,13 @@ public abstract class AbstractQueue>
 public static final int UNLIMITED = -1;
 private final MessageReference _messageReference;
 private final long _limit;
+private final String _queueName;
 
-public MessageContent(MessageReference messageReference, long limit)
+public MessageContent(MessageReference messageReference, long 
limit, String queueName)
 {
 _messageReference = messageReference;
 _limit = (limit == UNLIMITED ? 
messageReference.getMessage().getSize() : limit);
+_queueName = queueName;
 }
 
 @Override
@@ -2735,6 +2737,12 @@ public abstract class AbstractQueue>
 return 
_messageReference.getMessage().getMessageHeader().getEncoding();
 }
 
+@RestContentHeader("Content-Disposition")
+public String getContentDisposition()
+{
+return "attachment; filename=\"" + _queueName
+   + "/" + _messageReference.getMessage().getMessageHeader() + 
"\"";
+}
 }
 
 private static class AcquireAllQueueEntryFilter implements QueueEntryFilter
@@ -3507,7 +3515,7 @@ public abstract class AbstractQueue>
 visit(messageFinder);
 if(messageFinder.isFound())
 {
-return new MessageContent(messageFinder.getMessageReference(), 
limit);
+return new MessageContent(messageFinder.getMessageReference(), 
limit, this.getName());
 }
 else
 {
{code}

I think that 2 and 3 should be addressed whilst 1 is up to you to decide 
whether we can make code a bit nicer by moving markup into template.

> Message dialogue tries to inline the text of a text message content 
> regardless of the its length
> 
>
> Key: QPID-7382
> URL: https://issues.apache.org/jira/browse/QPID-7382
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.30, 0.32, qpid-java-6.0
>Reporter: Keith Wall
> Fix For: qpid-java-6.1, qpid-java-6.0.5
>
>
> When viewing a message through the WMC, if the message's mime type indicates 
> that the content it text, the message dialogue tries to inline the content, 
> properly escaping the content first.  If the content is very large, this 
> approach is problematic and can cause formatting problems with buttons out of 
> reach, or at worst an unresponsive or crashed client side UI.
> The WMC should display the leading portion of a long text message using 
> ellipses and offer a download button to retrieve the full text content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7413) [Java Broker, WMC] Fix minor defects and usability issues in query and dashboard UI

2016-09-02 Thread Lorenz Quack (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-7413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458446#comment-15458446
 ] 

Lorenz Quack commented on QPID-7413:


Sorry Alex, but I do have a couple more comments:
* The clone dialogue for queries still has the old wording for scope
* In the tooltip for scope in the query creation dialogue: {{Determines where 
query is stored and where to query for the objects.}} should be {{Determines 
where *the* query is stored and where to query for the objects.}}
* The stars after the labels (indicating the fields as mandatory) in the 
dialogues are a bit pointless since you cannot leave the combo box empty. But I 
am not opposed to leaving them for consistency.
* In {{PreferenceBrowserWidget#_renderGroups}} you successively build up a 
string using the += operator in addition you have a if check to only insert 
between elements and not at the very end. This is exactly the pattern that 
{{array.join(separator)}} is for. You do not need the if logic and it can be 
more efficient because it does not have to create N successively larger 
immutable strings (e.g. by use something like a Java stringbuilder).
* In {{PreferenceBrowserWidget#_renderOwner}} you check twice for {{value}} 
once hidden in the ternary operator and once in the explicit if-statement. This 
could all move into one if block


> [Java Broker, WMC] Fix minor defects and usability issues in query and 
> dashboard UI
> ---
>
> Key: QPID-7413
> URL: https://issues.apache.org/jira/browse/QPID-7413
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
> Fix For: qpid-java-6.1
>
>
> # Menu bar - the serialized form of the username in the menu bar looks ugly
> # Menu bar is a muddle of some with icons some with text and some with both.  
> We said all menu titles would have a word and icon.  We said menu entries 
> would not have an icon.
> # Rename Show Xxx Browser => Browse Xx
> # Add explanatory text to the Create Query and Create Dashboard dialogues to 
> help the user understand what scope and category mean.
> # In the save dialogues, the fully qualified name of the group should be 
> visible to the user, perhaps as a hover.
> # A newly cloned query does not warn if it is closed before save has been 
> pressed.
> # Use qpid confirmation dialogue box instead of system confirmation dialogue 
> universally
> # On the Query and Dashboard browsers rename "Mine" to "Created by me"
> # Add the ability select a query from the query browser with the Return key.
> # Add an icon to the "Add Widget" button
> # Add units to the refresh period in the widget customization dialogue
> # Defect:  With a group of HA nodes, create a virtualhost scoped dashboard 
> containing a virtualhost scoped query,   Flip the mastership Expected 
> behaviour - dashboard and widget should be present on the new master.  
> Actual: dashboard was present but was empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7413) [Java Broker, WMC] Fix minor defects and usability issues in query and dashboard UI

2016-09-02 Thread Alex Rudyy (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-7413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458266#comment-15458266
 ] 

Alex Rudyy commented on QPID-7413:
--

Lorenz,
I addressed some of your review comments:
1) window check as added in commit [r1758940|https://svn.apache.org/r1758940]
2) labels and tooltips were changed in commit 
[r1758940|https://svn.apache.org/r1758940]
3) pointless notification icon is removed in commit 
[r1758940|https://svn.apache.org/r1758940]
4) Displaying of user names at Dashboard/Query Browsers was fixed in commit 
[r1758782|https://svn.apache.org/r1758782]
5) Changing of confirmation dialogs everywhere in WMC is not in the scope of 
this JIRA. Only dashboard and query UI are subjects for the changes with this 
JIRA.

Could you please review changes?

> [Java Broker, WMC] Fix minor defects and usability issues in query and 
> dashboard UI
> ---
>
> Key: QPID-7413
> URL: https://issues.apache.org/jira/browse/QPID-7413
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
> Fix For: qpid-java-6.1
>
>
> # Menu bar - the serialized form of the username in the menu bar looks ugly
> # Menu bar is a muddle of some with icons some with text and some with both.  
> We said all menu titles would have a word and icon.  We said menu entries 
> would not have an icon.
> # Rename Show Xxx Browser => Browse Xx
> # Add explanatory text to the Create Query and Create Dashboard dialogues to 
> help the user understand what scope and category mean.
> # In the save dialogues, the fully qualified name of the group should be 
> visible to the user, perhaps as a hover.
> # A newly cloned query does not warn if it is closed before save has been 
> pressed.
> # Use qpid confirmation dialogue box instead of system confirmation dialogue 
> universally
> # On the Query and Dashboard browsers rename "Mine" to "Created by me"
> # Add the ability select a query from the query browser with the Return key.
> # Add an icon to the "Add Widget" button
> # Add units to the refresh period in the widget customization dialogue
> # Defect:  With a group of HA nodes, create a virtualhost scoped dashboard 
> containing a virtualhost scoped query,   Flip the mastership Expected 
> behaviour - dashboard and widget should be present on the new master.  
> Actual: dashboard was present but was empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7413) [Java Broker, WMC] Fix minor defects and usability issues in query and dashboard UI

2016-09-02 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-7413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458251#comment-15458251
 ] 

ASF subversion and git services commented on QPID-7413:
---

Commit 1758940 from oru...@apache.org in branch 'java/trunk'
[ https://svn.apache.org/r1758940 ]

QPID-7413: [Java Broker, WMC] Address review comments

   Change tooltips and labels on query/dashboard creation UI
   Decode friendly username
   Verify the existance of window for Broker Manual before moving focus 
to it

> [Java Broker, WMC] Fix minor defects and usability issues in query and 
> dashboard UI
> ---
>
> Key: QPID-7413
> URL: https://issues.apache.org/jira/browse/QPID-7413
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: qpid-java-6.0.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
> Fix For: qpid-java-6.1
>
>
> # Menu bar - the serialized form of the username in the menu bar looks ugly
> # Menu bar is a muddle of some with icons some with text and some with both.  
> We said all menu titles would have a word and icon.  We said menu entries 
> would not have an icon.
> # Rename Show Xxx Browser => Browse Xx
> # Add explanatory text to the Create Query and Create Dashboard dialogues to 
> help the user understand what scope and category mean.
> # In the save dialogues, the fully qualified name of the group should be 
> visible to the user, perhaps as a hover.
> # A newly cloned query does not warn if it is closed before save has been 
> pressed.
> # Use qpid confirmation dialogue box instead of system confirmation dialogue 
> universally
> # On the Query and Dashboard browsers rename "Mine" to "Created by me"
> # Add the ability select a query from the query browser with the Return key.
> # Add an icon to the "Add Widget" button
> # Add units to the refresh period in the widget customization dialogue
> # Defect:  With a group of HA nodes, create a virtualhost scoped dashboard 
> containing a virtualhost scoped query,   Flip the mastership Expected 
> behaviour - dashboard and widget should be present on the new master.  
> Actual: dashboard was present but was empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Created] (QPID-7414) [Java Broker] File based authentication providers PlainPasswordFile and Base64MD5PasswordFile should allow semi-colons in usernames and passwords

2016-09-02 Thread Alex Rudyy (JIRA)

Alex Rudyy created QPID-7414:


 Summary: [Java Broker] File based authentication providers 
PlainPasswordFile and Base64MD5PasswordFile should allow semi-colons in 
usernames and passwords
 Key: QPID-7414
 URL: https://issues.apache.org/jira/browse/QPID-7414
 Project: Qpid
  Issue Type: Bug
  Components: Java Broker
Affects Versions: qpid-java-6.0.4, qpid-java-6.0.3, qpid-java-6.0.2, 
qpid-java-6.0.1, qpid-java-6.0, 0.32, 0.30, 0.28, 0.26, 0.24, 0.22, 0.20, 0.18
Reporter: Alex Rudyy


Semi-colons in user name for authentication providers of types 
PlainPasswordFile and Base64MD5PasswordFile cause failures on opening of such 
authentication providers on broker startup. As result,  authentication fails 
for any user account belonging to the impacted authentication provider. The 
user names with semi-colons would need to be removed manually from the 
configuration files in order to recover from the issue.
Semi-colons in user password for PlainPasswordFile results in the same issue.

The exception similar to the one below is reported for the above:
{noformat}
ERROR [Broker-Config] (o.a.q.s.m.AbstractConfiguredObject) - Failed to open 
object with name 'passwordFile'.  Object will be put into ERROR state.
java.lang.IllegalArgumentException: User Data should be length 2, username, 
password
at 
org.apache.qpid.server.security.auth.database.PlainUser.(PlainUser.java:37)
 ~[classes/:na]
at 
org.apache.qpid.server.security.auth.database.PlainPasswordFilePrincipalDatabase.createUserFromFileData(PlainPasswordFilePrincipalDatabase.java:132)
 ~[classes/:na]
at 
org.apache.qpid.server.security.auth.database.PlainPasswordFilePrincipalDatabase.createUserFromFileData(PlainPasswordFilePrincipalDatabase.java:56)
 ~[classes/:na]
at 
org.apache.qpid.server.security.auth.database.AbstractPasswordFilePrincipalDatabase.loadPasswordFile(AbstractPasswordFilePrincipalDatabase.java:213)
 ~[classes/:na]
at 
org.apache.qpid.server.security.auth.database.AbstractPasswordFilePrincipalDatabase.open(AbstractPasswordFilePrincipalDatabase.java:82)
 ~[classes/:na]
at 
org.apache.qpid.server.security.auth.manager.PrincipalDatabaseAuthenticationManager.initialise(PrincipalDatabaseAuthenticationManager.java:143)
 ~[classes/:na]
at 
org.apache.qpid.server.security.auth.manager.PrincipalDatabaseAuthenticationManager.onOpen(PrincipalDatabaseAuthenticationManager.java:120)
 ~[classes/:na]
at 
org.apache.qpid.server.model.AbstractConfiguredObject.doOpening(AbstractConfiguredObject.java:1095)
 [classes/:na]
at 
org.apache.qpid.server.model.AbstractConfiguredObject$9.performAction(AbstractConfiguredObject.java:1110)
 [classes/:na]
at 
org.apache.qpid.server.model.AbstractConfiguredObject$9.performAction(AbstractConfiguredObject.java:1098)
 [classes/:na]
at 
org.apache.qpid.server.model.AbstractConfiguredObject.applyToChildren(AbstractConfiguredObject.java:1269)
 [classes/:na]
at 
org.apache.qpid.server.model.AbstractConfiguredObject.doOpening(AbstractConfiguredObject.java:1097)
 [classes/:na]
at 
org.apache.qpid.server.model.AbstractConfiguredObject$1.execute(AbstractConfiguredObject.java:583)
 [classes/:na]
at 
org.apache.qpid.server.model.AbstractConfiguredObject$1.execute(AbstractConfiguredObject.java:571)
 [classes/:na]
at 
org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:632)
 [classes/:na]
at 
org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:625)
 [classes/:na]
at 
org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:240)
 [classes/:na]
at 
org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submitWrappedTask(TaskExecutorImpl.java:157)
 [classes/:na]
at 
org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submit(TaskExecutorImpl.java:145)
 [classes/:na]
at 
org.apache.qpid.server.model.AbstractConfiguredObject.doOnConfigThread(AbstractConfiguredObject.java:624)
 [classes/:na]
at 
org.apache.qpid.server.model.AbstractConfiguredObject.openAsync(AbstractConfiguredObject.java:570)
 [classes/:na]
at 
org.apache.qpid.server.model.AbstractSystemConfig.activate(AbstractSystemConfig.java:237)
 [classes/:na]
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1292) errno not thread-safe on Solaris

2016-09-02 Thread Adel Boutros (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458039#comment-15458039
 ] 

Adel Boutros commented on PROTON-1292:
--

[~astitcher] I confirm adding the "-mt" flag works fine.

Regards,
Adel

> errno not thread-safe on Solaris
> 
>
> Key: PROTON-1292
> URL: https://issues.apache.org/jira/browse/PROTON-1292
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.12.2, 0.13.0
>Reporter: Adel Boutros
>Assignee: Andrew Stitcher
>
> For some time, we were having random errors on Solaris with proton-c where we 
> would get a transport error "proton:io connect: Error 0". We were finally 
> able to reproduce it in a multi-threading environment. It turns out some 
> C/C++ system calls such as opening sockets will set the value of "errno" and 
> some parts of proton-c code you rely on the value of errno to determine if 
> the operation was successful or not[1].
> The issue is that errno is not thread safe[2] and as a consequence if by the 
> time Thread A was checking the value of errno, Thread B has set it to 
> something else, the check will fail.
> We resolved it by compiling Proton with "-D_REENTRANT" which makes errno 
> thread local variable.
> Please note we only got this error on Solaris because on Linux setting 
> "-lpthread" implies "-D_REENTRANT flag" according to stackoverflow[2].
> Do you think this flag could be set by default in the CMakeList of proton to 
> avoid others having the same issue?
> On Solaris:
> /usr/include/errno.h
> #if defined(_REENTRANT) || defined(_TS_ERRNO) || _POSIX_C_SOURCE - 0 >= 
> 199506L
> extern int *___errno();
> #define errno (*(___errno()))
> #else
> extern int errno;
> /* ANSI C++ requires that errno be a macro */
> #if __cplusplus >= 199711L
> #define errno errno
> #endif
> #endif  /* defined(_REENTRANT) || defined(_TS_ERRNO) */
> PS: The code is still the same on 0.14.0. So the error could happen there as 
> well I guess.
> [1]: 
> https://github.com/apache/qpid-proton/blob/0.12.2/proton-c/src/posix/io.c 
> (line 187-188)
> [2]: http://stackoverflow.com/questions/1694164/is-errno-thread-safe
> [3]: 
> http://stackoverflow.com/questions/875789/gcc-do-i-need-d-reentrant-with-pthreads
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Re: Dispute of CVSS Score for CVE-2016-4974

2016-09-02 Thread Lorenz Quack


Hello Chuck,

Thank you for the quick turnaround time on this issue.

Kind regards,
Lorenz


On 01/09/16 18:46, Wergin, Charles (Assoc) wrote:

Good afternoon,

Thank you for contacting the NVD regarding this issue.  We have adjusted the 
attack vectors based on the information you have provided.
Based on the CVSSv3 specification and scoring guidance, we feel the metrics for 
impact are accurate based on the current available information.  If you can 
provide additional publically available information that justifies other 
changes, we will investigate and perhaps further adjust the score.

Respectfully,

Chuck Wergin
National Vulnerability Database
nvd.nist.gov

-Original Message-
From: Lorenz Quack [mailto:quack.lor...@gmail.com]
Sent: Thursday, September 01, 2016 8:23 AM
To: nvd 
Cc: dev@qpid.apache.org; secur...@apache.org
Subject: Dispute of CVSS Score for CVE-2016-4974

Dear Madam or Sir,

I would like to dispute the CVSS score of CVE-2016-4974 [1].

Upon our request the MITRE description [2] was recently changed to more 
accurately describe the circumstances under which this vulnerability can be 
exploited.  The original description read:

  Apache Qpid AMQP 0-x JMS client before 6.0.4 and JMS (AMQP
  1.0) before 0.10.0 does not restrict the use of classes
  available on the classpath, which might allow remote
  attackers to deserialize arbitrary objects and execute
  arbitrary code by leveraging a crafted serialized object in a
  JMS ObjectMessage that is handled by the getObject function.

This has been changed in the following way:

  [...] which might allow remote authenticated users with
  permission to send messages to deserialize arbitrary objects
  [...]

I can see that this change is already reflected in the NVD database.  However, 
the CVSS severity score has not been adjusted.

Our impression is that the current high rating is mainly due to the 
misunderstanding that this vulnerability could be exploited by a 
unauthenticated remote attacker which is not correct. To exploit the 
vulnerability the following conditions need to be
met:

   * The attacker needs authorization to send messages to the
 target system.

   * The target application needs to call getObject() on the
 received JMS message.

   * The target application needs to have additional exploitable
 classes (e.g., Apache Commons Collections [3]) on the JVM
 classpath.

For reference, Red Hat's CVVSv3 severity assessment [4] resulted in a score of 
5.6, whereas NVD's assessment [1] resulted in a score of 9.8.

Please let me know if you require further information to consider changing the 
CVSS score.


Kind regards,

Lorenz Quack
on behalf of the Apache Qpid Project Management Committee


[1] https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2016-4974
[2] https://cve.mitre.org/cgi-bin/cvename.cgi?name=2016-4974
[3] https://issues.apache.org/jira/browse/COLLECTIONS-580
[4] https://access.redhat.com/security/cve/CVE-2016-4974





-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (QPID-7381) [Java Broker] Support consumer priorities

2016-09-02 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457946#comment-15457946
 ] 

ASF subversion and git services commented on QPID-7381:
---

Commit 1758900 from [~godfrer] in branch 'java/trunk'
[ https://svn.apache.org/r1758900 ]

QPID-7381 : Flip priority to have large numbers mean high priority

> [Java Broker] Support consumer priorities
> -
>
> Key: QPID-7381
> URL: https://issues.apache.org/jira/browse/QPID-7381
> Project: Qpid
>  Issue Type: New Feature
>  Components: Java Broker
>Reporter: Rob Godfrey
> Fix For: qpid-java-6.1
>
>
> Support the concept of consumer priorities.  A consumer of a lower priority 
> should only receive a message if there exists no consumer on the queue of a 
> higher priority which has credit and would accept the message if offered it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

41 matches

Mail list logo