[jira] [Commented] (QPID-6933) Factor out a JMS client neutral messaging test suite from system tests

2017-11-27 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268312#comment-16268312
 ] 

ASF subversion and git services commented on QPID-6933:
---

Commit c47109b41dbeda51159ae5ce22666e5cee8eedab in qpid-broker-j's branch 
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=c47109b ]

QPID-6933: [System Tests] Change amqp protocol version defined in maven 
profiles to be spec complient


> Factor out a JMS client neutral messaging test suite from system tests
> --
>
> Key: QPID-6933
> URL: https://issues.apache.org/jira/browse/QPID-6933
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>
> The existing system testsuite is in a poor state.
> * It is poorly structured
> * Mixes different types of test.  i.e. messaging behaviour with those that 
> test features of the Java Broker (e.g. REST).
> * Many of the tests refer directly to the implementation classes of the Qpid 
> Client 0-8..0-10 client meaning the tests cannot be run using the new client.
> As a first step, we want to factor out a separate messaging system test suite:
> * The tests in this suite will be JMS client neutral.
> * Written in terms of JNDI/JMS client
> * Configurations/Broker observations will be performed via a clean 
> Broker-neutral facade. For instance
> **  a mechanism to cause the queue to be created of a particular type.
> ** a mechanism to observe a queue depth.
> * The tests will be classified by feature (to be defined)
> * The classification system will be used to drive an exclusion feature (to be 
> defined).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6933) Factor out a JMS client neutral messaging test suite from system tests

2017-11-27 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268309#comment-16268309
 ] 

ASF subversion and git services commented on QPID-6933:
---

Commit 6dc32330fc7309650d7feaff8981ae72ddde81df in qpid-broker-j's branch 
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=6dc3233 ]

QPID-6933: [System Tests] Change JMS 2.0 system tests to start broker per test 
suite


> Factor out a JMS client neutral messaging test suite from system tests
> --
>
> Key: QPID-6933
> URL: https://issues.apache.org/jira/browse/QPID-6933
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>
> The existing system testsuite is in a poor state.
> * It is poorly structured
> * Mixes different types of test.  i.e. messaging behaviour with those that 
> test features of the Java Broker (e.g. REST).
> * Many of the tests refer directly to the implementation classes of the Qpid 
> Client 0-8..0-10 client meaning the tests cannot be run using the new client.
> As a first step, we want to factor out a separate messaging system test suite:
> * The tests in this suite will be JMS client neutral.
> * Written in terms of JNDI/JMS client
> * Configurations/Broker observations will be performed via a clean 
> Broker-neutral facade. For instance
> **  a mechanism to cause the queue to be created of a particular type.
> ** a mechanism to observe a queue depth.
> * The tests will be classified by feature (to be defined)
> * The classification system will be used to drive an exclusion feature (to be 
> defined).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6933) Factor out a JMS client neutral messaging test suite from system tests

2017-11-27 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268313#comment-16268313
 ] 

ASF subversion and git services commented on QPID-6933:
---

Commit 7336b5203f5b190d0671473d36ea060cdf3fd165 in qpid-broker-j's branch 
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=7336b52 ]

QPID-6933: [System Tests] Remove jndi client settings from profiles


> Factor out a JMS client neutral messaging test suite from system tests
> --
>
> Key: QPID-6933
> URL: https://issues.apache.org/jira/browse/QPID-6933
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>
> The existing system testsuite is in a poor state.
> * It is poorly structured
> * Mixes different types of test.  i.e. messaging behaviour with those that 
> test features of the Java Broker (e.g. REST).
> * Many of the tests refer directly to the implementation classes of the Qpid 
> Client 0-8..0-10 client meaning the tests cannot be run using the new client.
> As a first step, we want to factor out a separate messaging system test suite:
> * The tests in this suite will be JMS client neutral.
> * Written in terms of JNDI/JMS client
> * Configurations/Broker observations will be performed via a clean 
> Broker-neutral facade. For instance
> **  a mechanism to cause the queue to be created of a particular type.
> ** a mechanism to observe a queue depth.
> * The tests will be classified by feature (to be defined)
> * The classification system will be used to drive an exclusion feature (to be 
> defined).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6933) Factor out a JMS client neutral messaging test suite from system tests

2017-11-27 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268310#comment-16268310
 ] 

ASF subversion and git services commented on QPID-6933:
---

Commit 9089861a47551cb6caee363c961655e94c7e97fd in qpid-broker-j's branch 
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=9089861 ]

QPID-6933: [System Tests] Remove compile time dependencies to legacy JMS client 
classes from JMSProvider implementations and reduce the amount of methods to 
create connection


> Factor out a JMS client neutral messaging test suite from system tests
> --
>
> Key: QPID-6933
> URL: https://issues.apache.org/jira/browse/QPID-6933
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>
> The existing system testsuite is in a poor state.
> * It is poorly structured
> * Mixes different types of test.  i.e. messaging behaviour with those that 
> test features of the Java Broker (e.g. REST).
> * Many of the tests refer directly to the implementation classes of the Qpid 
> Client 0-8..0-10 client meaning the tests cannot be run using the new client.
> As a first step, we want to factor out a separate messaging system test suite:
> * The tests in this suite will be JMS client neutral.
> * Written in terms of JNDI/JMS client
> * Configurations/Broker observations will be performed via a clean 
> Broker-neutral facade. For instance
> **  a mechanism to cause the queue to be created of a particular type.
> ** a mechanism to observe a queue depth.
> * The tests will be classified by feature (to be defined)
> * The classification system will be used to drive an exclusion feature (to be 
> defined).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-6933) Factor out a JMS client neutral messaging test suite from system tests

2017-11-27 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268314#comment-16268314
 ] 

ASF subversion and git services commented on QPID-6933:
---

Commit 59218fdc3eeaa6ef1c7f535bcbb29edbbc9cb962 in qpid-broker-j's branch 
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=59218fd ]

QPID-6933: [System Tests] Add module for JMS 1.1 system tests and start moving 
JMS 1.1 tests into it


> Factor out a JMS client neutral messaging test suite from system tests
> --
>
> Key: QPID-6933
> URL: https://issues.apache.org/jira/browse/QPID-6933
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Tests
>Reporter: Keith Wall
>Assignee: Alex Rudyy
>
> The existing system testsuite is in a poor state.
> * It is poorly structured
> * Mixes different types of test.  i.e. messaging behaviour with those that 
> test features of the Java Broker (e.g. REST).
> * Many of the tests refer directly to the implementation classes of the Qpid 
> Client 0-8..0-10 client meaning the tests cannot be run using the new client.
> As a first step, we want to factor out a separate messaging system test suite:
> * The tests in this suite will be JMS client neutral.
> * Written in terms of JNDI/JMS client
> * Configurations/Broker observations will be performed via a clean 
> Broker-neutral facade. For instance
> **  a mechanism to cause the queue to be created of a particular type.
> ** a mechanism to observe a queue depth.
> * The tests will be classified by feature (to be defined)
> * The classification system will be used to drive an exclusion feature (to be 
> defined).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8055) [Perftests] Remove hardcoded reference to legacy jms client context factory from perftests runner

2017-11-27 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268311#comment-16268311
 ] 

ASF subversion and git services commented on QPID-8055:
---

Commit 0b7666ebe869de6cfdc34e13ff9d6c8e18c0cd5e in qpid-broker-j's branch 
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=0b7666e ]

QPID-8055: [Performance Tests] Remove hardcoded reference to legacy jms client 
context factory from perftests runner


> [Perftests] Remove hardcoded reference to legacy jms client context factory 
> from perftests runner
> -
>
> Key: QPID-8055
> URL: https://issues.apache.org/jira/browse/QPID-8055
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Performance Tests
>Affects Versions: qpid-java-broker-7.0.1
>Reporter: Alex Rudyy
>Priority: Minor
>
> A legacy client jndi context factory 
> {{org.apache.qpid.jndi.PropertiesFileInitialContextFactory}} is hardcoded in 
> perftests {{AbstractRunner}}. If jvm system property 
> {{InitialContext.INITIAL_CONTEXT_FACTORY}} is not set, the legacy client 
> factory is used even when other client factory is specified in the 
> {{jndi-config}}. As result, the legacy client initial contex is used instead 
> of the one configured in {{jndi-config}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-887) Dispatch reestablishes connection inspite of deleting the connector

2017-11-27 Thread Ganesh Murthy (JIRA)
Ganesh Murthy created DISPATCH-887:
--

 Summary: Dispatch reestablishes connection inspite of deleting the 
connector
 Key: DISPATCH-887
 URL: https://issues.apache.org/jira/browse/DISPATCH-887
 Project: Qpid Dispatch
  Issue Type: Bug
  Components: Container
Affects Versions: 1.0.0
Reporter: Ganesh Murthy
Assignee: Ganesh Murthy
 Fix For: 1.1.0


There is a race condition happening when a connector is deleted.

On connector delete, the following function is called 

{code}
void qd_connection_manager_delete_connector(qd_dispatch_t *qd, void *impl)
{
qd_connector_t *ct = (qd_connector_t*) impl;
if (ct) {
sys_mutex_lock(ct->lock);
if (ct->ctx && ct->ctx->pn_conn) {
qd_connection_invoke_deferred(ct->ctx, deferred_close, 
ct->ctx->pn_conn);
}
sys_mutex_unlock(ct->lock);
DEQ_REMOVE(qd->connection_manager->connectors, ct);
qd_connector_decref(ct);
}
}
{code}

The deferred_close() is invoked before qd_connector_decref() is invoked hence 
the connection's connector is still in place and the connector is 
re-established.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Closed] (PROTON-1691) Memory leak when creating endpoint objects with a handler

2017-11-27 Thread Xin Chen (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xin Chen closed PROTON-1691.

Resolution: Not A Problem

> Memory leak when creating endpoint objects with a handler
> -
>
> Key: PROTON-1691
> URL: https://issues.apache.org/jira/browse/PROTON-1691
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: proton-c-0.18.1
> Environment: Reproduced on Windows but the code is not platform 
> specific.
>Reporter: Xin Chen
>Assignee: Cliff Jansen
>
> Using the Python binding, one can provide a handler when creating an Endpoint 
> object (Connection/Session/Link). This handler object is set in the record 
> context. In pn_###_finalize methods, the context is not cleared by calling 
> pn_record_clear. This results in a _cadapter object leaking in Python process 
> without any references. The fix is simply to call pn_record_clear before 
> freeing the context. For example, in pn_link_finalize (line 1121 in engine.c),
> +  pn_record_clear(link->context);
>   pn_free(link->context);
> With this fix the memory does not grow anymore with repeated link 
> creation/closing. I only use a handler in link endpoint but I think this is 
> needed for connection and session as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1691) Memory leak when creating endpoint objects with a handler

2017-11-27 Thread Xin Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268032#comment-16268032
 ] 

Xin Chen commented on PROTON-1691:
--

It is not an issue if I call link.free() after close.

> Memory leak when creating endpoint objects with a handler
> -
>
> Key: PROTON-1691
> URL: https://issues.apache.org/jira/browse/PROTON-1691
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: proton-c-0.18.1
> Environment: Reproduced on Windows but the code is not platform 
> specific.
>Reporter: Xin Chen
>Assignee: Cliff Jansen
>
> Using the Python binding, one can provide a handler when creating an Endpoint 
> object (Connection/Session/Link). This handler object is set in the record 
> context. In pn_###_finalize methods, the context is not cleared by calling 
> pn_record_clear. This results in a _cadapter object leaking in Python process 
> without any references. The fix is simply to call pn_record_clear before 
> freeing the context. For example, in pn_link_finalize (line 1121 in engine.c),
> +  pn_record_clear(link->context);
>   pn_free(link->context);
> With this fix the memory does not grow anymore with repeated link 
> creation/closing. I only use a handler in link endpoint but I think this is 
> needed for connection and session as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1701) [OSX] Add Qpid Proton to the MacPorts collection

2017-11-27 Thread Roddie Kieley (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267992#comment-16267992
 ] 

Roddie Kieley commented on PROTON-1701:
---

Current work 
[here|https://github.com/RoddieKieley/macports-ports/tree/qpid-proton/net/qpid-proton],
 needs final test and cleanup prior to submission.

> [OSX] Add Qpid Proton to the MacPorts collection
> 
>
> Key: PROTON-1701
> URL: https://issues.apache.org/jira/browse/PROTON-1701
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
> Environment: OSX 10.11.6
> MacPorts 2.4.z
>Reporter: Roddie Kieley
>Priority: Minor
>
> According to [The MacPorts Project Official 
> Homepage|https://www.macports.org/]:
> {quote}
> The MacPorts Project is an open-source community initiative to design an 
> easy-to-use system for compiling, installing, and upgrading either 
> command-line, X11 or Aqua based open-source software on the Mac operating 
> system. 
> {quote}
> As such it would be beneficial for the open-source community if Qpid Proton 
> was a part of the collection so that it was easily consumable on OSX.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (PROTON-1701) [OSX] Add Qpid Proton to the MacPorts collection

2017-11-27 Thread Roddie Kieley (JIRA)
Roddie Kieley created PROTON-1701:
-

 Summary: [OSX] Add Qpid Proton to the MacPorts collection
 Key: PROTON-1701
 URL: https://issues.apache.org/jira/browse/PROTON-1701
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c
 Environment: OSX 10.11.6
MacPorts 2.4.z
Reporter: Roddie Kieley
Priority: Minor


According to [The MacPorts Project Official Homepage|https://www.macports.org/]:
{quote}
The MacPorts Project is an open-source community initiative to design an 
easy-to-use system for compiling, installing, and upgrading either 
command-line, X11 or Aqua based open-source software on the Mac operating 
system. 
{quote}

As such it would be beneficial for the open-source community if Qpid Proton was 
a part of the collection so that it was easily consumable on OSX.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (PROTON-1700) Reconnecting container does not respond to stop

2017-11-27 Thread Justin Ross (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Ross updated PROTON-1700:

Attachment: reconnect-and-stop.cpp

> Reconnecting container does not respond to stop
> ---
>
> Key: PROTON-1700
> URL: https://issues.apache.org/jira/browse/PROTON-1700
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: proton-c-0.18.1
>Reporter: Justin Ross
>Assignee: Andrew Stitcher
>  Labels: reproducer
> Fix For: proton-c-0.19.0
>
> Attachments: reconnect-and-stop.cpp
>
>
> Calling stop from another thread fails to terminate a container when it is 
> attempting to reconnect.
> The attached reproducer never exits (or mostly never exits - I may have seen 
> it do it once).  I believe it should.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (PROTON-1700) Reconnecting container does not respond to stop

2017-11-27 Thread Justin Ross (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Ross updated PROTON-1700:

Labels: reproducer  (was: )

> Reconnecting container does not respond to stop
> ---
>
> Key: PROTON-1700
> URL: https://issues.apache.org/jira/browse/PROTON-1700
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: proton-c-0.18.1
>Reporter: Justin Ross
>Assignee: Andrew Stitcher
>  Labels: reproducer
> Fix For: proton-c-0.19.0
>
> Attachments: reconnect-and-stop.cpp
>
>
> Calling stop from another thread fails to terminate a container when it is 
> attempting to reconnect.
> The attached reproducer never exits (or mostly never exits - I may have seen 
> it do it once).  I believe it should.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (PROTON-1700) Reconnecting container does not respond to stop

2017-11-27 Thread Justin Ross (JIRA)
Justin Ross created PROTON-1700:
---

 Summary: Reconnecting container does not respond to stop
 Key: PROTON-1700
 URL: https://issues.apache.org/jira/browse/PROTON-1700
 Project: Qpid Proton
  Issue Type: Bug
  Components: cpp-binding
Affects Versions: proton-c-0.18.1
Reporter: Justin Ross
Assignee: Andrew Stitcher
 Fix For: proton-c-0.19.0


Calling stop from another thread fails to terminate a container when it is 
attempting to reconnect.

The attached reproducer never exits (or mostly never exits - I may have seen it 
do it once).  I believe it should.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (QPID-8055) [Perftests] Remove hardcoded reference to legacy jms client context factory from perftests runner

2017-11-27 Thread Alex Rudyy (JIRA)
Alex Rudyy created QPID-8055:


 Summary: [Perftests] Remove hardcoded reference to legacy jms 
client context factory from perftests runner
 Key: QPID-8055
 URL: https://issues.apache.org/jira/browse/QPID-8055
 Project: Qpid
  Issue Type: Bug
  Components: Java Performance Tests
Affects Versions: qpid-java-broker-7.0.1
Reporter: Alex Rudyy
Priority: Minor


A legacy client jndi context factory 
{{org.apache.qpid.jndi.PropertiesFileInitialContextFactory}} is hardcoded in 
perftests {{AbstractRunner}}. If jvm system property 
{{InitialContext.INITIAL_CONTEXT_FACTORY}} is not set, the legacy client 
factory is used even when other client factory is specified in the 
{{jndi-config}}. As result, the legacy client initial contex is used instead of 
the one configured in {{jndi-config}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1643) [FreeBSD] ruby-example-test hangs

2017-11-27 Thread Alan Conway (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267566#comment-16267566
 ] 

Alan Conway commented on PROTON-1643:
-

This issue may be fixed by the latest commit on PROTON-1636, but it has not 
been tested on FreeBSD

> [FreeBSD] ruby-example-test hangs
> -
>
> Key: PROTON-1643
> URL: https://issues.apache.org/jira/browse/PROTON-1643
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
>Affects Versions: proton-c-0.18.0
> Environment: FreeBSD 10.3-RELEASE-p20
>Reporter: Andrew Stitcher
>Assignee: Alan Conway
>  Labels: freebsd
> Fix For: proton-c-0.19.0
>
>
> When running ctest ruby-example-test hangs.
> If you examine the process list there is a process {{/usr/local/bin/ruby23 
> reactor/broker.rb -a :26780}} that has not exited. If you kill that process 
> the test fails but the test run carries on.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (PROTON-1699) [ruby] add messenger tests to backward compatibility suite

2017-11-27 Thread Alan Conway (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway resolved PROTON-1699.
-
Resolution: Fixed

> [ruby] add messenger tests to backward compatibility suite
> --
>
> Key: PROTON-1699
> URL: https://issues.apache.org/jira/browse/PROTON-1699
> Project: Qpid Proton
>  Issue Type: Test
>Affects Versions: proton-c-0.18.1
>Reporter: Alan Conway
>Assignee: Alan Conway
> Fix For: proton-c-0.19.0
>
>
> Add the messenger smoke tests, fixed as per pull request 114, to the 
> old_examples backwards compatibility suite. 
> The Messenger API will be supported but deprecated in the next release, so 
> messenger examples are removed from the examples tree but are preserved (with 
> other older examples) in the ruby/tests/old_examples tree to ensure we don't 
> break deprecated features too early.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-proton pull request #114: [Ruby code Example] fix Messenger package

2017-11-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/qpid-proton/pull/114


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1636) Fairly Consistent (but intermittent) hangs in ruby-example-test/ruby-test-container using Travis CI

2017-11-27 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267558#comment-16267558
 ] 

ASF subversion and git services commented on PROTON-1636:
-

Commit f9d8cc4acdbe11ad58d3a3004abfa42b0e3dd098 in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=f9d8cc4 ]

PROTON-1636: [ruby] fix race condition in ruby container tests

Made "stopped" a terminal state for the Container to avoid races during
shut-down, e.g. because threads have not even entered #run when the container
auto-stops.


> Fairly Consistent (but intermittent) hangs in 
> ruby-example-test/ruby-test-container using Travis CI
> ---
>
> Key: PROTON-1636
> URL: https://issues.apache.org/jira/browse/PROTON-1636
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: ruby-binding
>Affects Versions: proton-c-0.18.0
> Environment: Travis CI:
> Ubuntu 1404 with lots of changes
>Reporter: Andrew Stitcher
>Assignee: Alan Conway
> Fix For: proton-c-0.19.0
>
>
> This is pretty annoying as it makes the build fail about 50% of the time for 
> me and so it looks like the change just made failed the build.
> {noformat}
>   Start 14: ruby-example-test
> 14: Test command: /home/travis/.rvm/rubies/ruby-2.4.1/bin/ruby 
> "example_test.rb" "-v"
> 14: Test timeout computed to be: 1500
> 14: Run options: -v --seed 7224
> 14: 
> 14: # Running:
> 14: 
> 14: ExampleTest#test_client_server = 0.30 s = .
> No output has been received in the last 10m0s, this potentially indicates a 
> stalled build or something wrong with the build itself.
> Check the details on how to adjust your build configuration on: 
> https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
> The build has been terminated
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1699) [ruby] add messenger tests to backward compatibility suite

2017-11-27 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267557#comment-16267557
 ] 

ASF subversion and git services commented on PROTON-1699:
-

Commit 1bf4a32ccbadfe3cfe103661f8a87d7fdb4ad4a7 in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=1bf4a32 ]

PROTON-1699: [ruby] add messenger tests to backward compatibility suite

This closes #114, and adds the direct_ examples to the old_examples test suite.


> [ruby] add messenger tests to backward compatibility suite
> --
>
> Key: PROTON-1699
> URL: https://issues.apache.org/jira/browse/PROTON-1699
> Project: Qpid Proton
>  Issue Type: Test
>Affects Versions: proton-c-0.18.1
>Reporter: Alan Conway
>Assignee: Alan Conway
> Fix For: proton-c-0.19.0
>
>
> Add the messenger smoke tests, fixed as per pull request 114, to the 
> old_examples backwards compatibility suite. 
> The Messenger API will be supported but deprecated in the next release, so 
> messenger examples are removed from the examples tree but are preserved (with 
> other older examples) in the ruby/tests/old_examples tree to ensure we don't 
> break deprecated features too early.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (DISPATCH-886) Console does not properly escape HTML in entity names

2017-11-27 Thread Ernest Allen (JIRA)

 [ 
https://issues.apache.org/jira/browse/DISPATCH-886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Allen reassigned DISPATCH-886:
-

Assignee: Ernest Allen

> Console does not properly escape HTML in entity names
> -
>
> Key: DISPATCH-886
> URL: https://issues.apache.org/jira/browse/DISPATCH-886
> Project: Qpid Dispatch
>  Issue Type: Bug
>  Components: Console
>Affects Versions: 1.0.0
>Reporter: Ernest Allen
>Assignee: Ernest Allen
>
> From ENTMQIC-1888
> Put this into qdrouterd.conf file:
> router { id: Router.A }
> Then connect to the router with the console.
> In the tree on the left in the Overview page, the u will be actually bold.
> The Overview page will refer to the router as Rou< in the table of routers 
> on the right, that is, part of the name is missing. The DOM looks like this 
> Rou<
> Regarding exploitability, I did manage to send a command to Jolokia (to kill 
> Artemis broker) by creating the following address prefix and then having the 
> admin looking at it.
> qdmanage create --type=address prefix=aPrefix name=" src=\"http://127.0.0.1:8161/hawtio/jolokia/exec/org.apache.activemq.artemis:type=Broker,brokerName=%220.0.0.0%22,module=Core,serviceType=Server/forceFailover()\">"
> Now open up the Entities tab in the browser and expand the address subtree on 
> that page.
> I did not manage to push through any JavaScript (to do XSS) and I needed to 
> edit the server config or use qdmanage to put in the HTML. In other words, I 
> had to be server admin to do this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-886) Console does not properly escape HTML in entity names

2017-11-27 Thread Ernest Allen (JIRA)
Ernest Allen created DISPATCH-886:
-

 Summary: Console does not properly escape HTML in entity names
 Key: DISPATCH-886
 URL: https://issues.apache.org/jira/browse/DISPATCH-886
 Project: Qpid Dispatch
  Issue Type: Bug
  Components: Console
Affects Versions: 1.0.0
Reporter: Ernest Allen


>From ENTMQIC-1888


Put this into qdrouterd.conf file:

router { id: Router.A }

Then connect to the router with the console.

In the tree on the left in the Overview page, the u will be actually bold.

The Overview page will refer to the router as Rou< in the table of routers 
on the right, that is, part of the name is missing. The DOM looks like this 
Rou<

Regarding exploitability, I did manage to send a command to Jolokia (to kill 
Artemis broker) by creating the following address prefix and then having the 
admin looking at it.

qdmanage create --type=address prefix=aPrefix name="http://127.0.0.1:8161/hawtio/jolokia/exec/org.apache.activemq.artemis:type=Broker,brokerName=%220.0.0.0%22,module=Core,serviceType=Server/forceFailover()\">"

Now open up the Entities tab in the browser and expand the address subtree on 
that page.

I did not manage to push through any JavaScript (to do XSS) and I needed to 
edit the server config or use qdmanage to put in the HTML. In other words, I 
had to be server admin to do this.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1687) Improve efficiency of the transport output buffer

2017-11-27 Thread Andrew Stitcher (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267239#comment-16267239
 ] 

Andrew Stitcher commented on PROTON-1687:
-

Yeah, looks like the same bug. Certainly same symptoms.

> Improve efficiency of the transport output buffer
> -
>
> Key: PROTON-1687
> URL: https://issues.apache.org/jira/browse/PROTON-1687
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Affects Versions: proton-c-0.18.0
>Reporter: Ted Ross
>Assignee: Andrew Stitcher
>  Labels: perf
> Fix For: proton-c-0.19.0
>
>
> As the size of the transport output buffer grows due to production of 
> deliveries sent through pn_link_send, the amount of time that the CPU spends 
> in memmove becomes a problem.
> It appears (dispatcher.c - pn_dispatcher_output) that whenever a block of 
> data is removed from the buffer, the remainder of the data in the buffer is 
> shifted down using memmove.  If the buffer contains a large amount of data 
> (100s of megabytes), the sending process may spend several minutes doing 
> almost nothing but running memmove.
> Some data:
>   (credit window of 250, unlimited session window, 1 MB payload)
>   - 10 messages, .251 sec, 40 deliveries/sec
>   - 20 messages, 1.267s, 16 dlv/s
>   - 40 messages, 6s, 7 dlv/s
>   - 80 messages, 28s, 3 dlv/s
>   - 160 messages, 138s, ~1 dlv/s



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (PROTON-1697) Tests of Ruby and Go bindings don't correctly use the path for saslpasswd2 discovered by cmake

2017-11-27 Thread Andrew Stitcher (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Stitcher resolved PROTON-1697.
-
Resolution: Fixed

> Tests of Ruby and Go bindings don't correctly use the path for saslpasswd2 
> discovered by cmake
> --
>
> Key: PROTON-1697
> URL: https://issues.apache.org/jira/browse/PROTON-1697
> Project: Qpid Proton
>  Issue Type: Bug
>Affects Versions: proton-c-0.18.1
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
> Fix For: proton-c-0.19.0
>
>
> This causes test failures if saslpasswd2 is not on the path even when cmake 
> correctly found the executable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1697) Tests of Ruby and Go bindings don't correctly use the path for saslpasswd2 discovered by cmake

2017-11-27 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267231#comment-16267231
 ] 

ASF subversion and git services commented on PROTON-1697:
-

Commit 4bfe8823345f5560d8d0935105ad2bf43836fd60 in qpid-proton's branch 
refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=4bfe882 ]

PROTON-1697: Ruby/Go tests should use SASLPASSWD environment var
- Otherwise they fail in environments where cmake found saslpasswd2
  but it's not in the path.


> Tests of Ruby and Go bindings don't correctly use the path for saslpasswd2 
> discovered by cmake
> --
>
> Key: PROTON-1697
> URL: https://issues.apache.org/jira/browse/PROTON-1697
> Project: Qpid Proton
>  Issue Type: Bug
>Affects Versions: proton-c-0.18.1
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
> Fix For: proton-c-0.19.0
>
>
> This causes test failures if saslpasswd2 is not on the path even when cmake 
> correctly found the executable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Closed] (QPID-8021) [Broker-J] [BDB] Make BDB store module compatible with JE release 7.4.5 [6.1.x]

2017-11-27 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-8021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall closed QPID-8021.


> [Broker-J] [BDB] Make BDB store module compatible with JE release 7.4.5   
> [6.1.x]
> -
>
> Key: QPID-8021
> URL: https://issues.apache.org/jira/browse/QPID-8021
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Reporter: Keith Wall
>Assignee: Keith Wall
> Fix For: qpid-java-6.1.5
>
>
> There a couple of simple binary incompatibilities that prevent a user of 
> Broker J 6.1.x from substituting a newer BDB JE releases.Adapting the 
> code to allow the 6.1.5 release to work with the current newer releases  will 
> give the user the option to upgrade if they wish (say to avoid a defect in 
> BDB JE).
> As Broker-J 6.1.x originally targeted JE 5.0.104 compatibility with this will 
> be retained.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Closed] (QPID-7853) Message enqueued twice to the same queue leads to Broker failure

2017-11-27 Thread Keith Wall (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall closed QPID-7853.


> Message enqueued twice to the same queue leads to Broker failure
> 
>
> Key: QPID-7853
> URL: https://issues.apache.org/jira/browse/QPID-7853
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.0, qpid-java-6.1, qpid-java-6.1.4
>Reporter: Keith Wall
>Assignee: Keith Wall
> Fix For: qpid-java-6.1.5, qpid-java-6.0.9
>
>
> QPID-4307 added a defence against the same message being enqueued twice on a 
> single queue, however a defect at 
> {{org/apache/qpid/server/exchange/AbstractExchange.java:502}} means that it 
> is still possible for this situation to arise on some paths.
> Reproduction:
> # Create queue with DLQ wired-up and max delivery count enforced.
> # Publish a single message to the queue.
> # Use management to copy the message from the queue to the DLQ
> # Transactionally consume the message and rollback until the message is 
> dead-lettered..
> The following stack trace will appear and the Broker will shutdown.
> {noformat}
> /Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home/bin/java 
> -agentlib:jdwp=transport=dt_socket,address=127.0.0.1:61800,suspend=y,server=n 
> -DQPID_HOME=/Users/keith/src/qpid-broker-j/systests/target/qpid-broker/6.1.5-SNAPSHOT
>  
> -DQPID_WORK=/Users/keith/src/qpid-broker-j/systests/target/qpid-broker/6.1.5-SNAPSHOT/work
>  -DSSL_DIR=/Users/keith/src/qpid-broker-j/test-profiles/test_resources/ssl/ 
> -Xmx4g -DXqpid.httpManagement.serveUncompressedDojo=true 
> -DXqpid.broker.networkBufferSize=1046512 -Djavax.net.debugX=ssl 
> -Dfile.encoding=UTF-8 -classpath 
> 

[jira] [Created] (PROTON-1699) [ruby] add messenger tests to backward compatibility suite

2017-11-27 Thread Alan Conway (JIRA)
Alan Conway created PROTON-1699:
---

 Summary: [ruby] add messenger tests to backward compatibility suite
 Key: PROTON-1699
 URL: https://issues.apache.org/jira/browse/PROTON-1699
 Project: Qpid Proton
  Issue Type: Test
Affects Versions: proton-c-0.18.1
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: proton-c-0.19.0


Add the messenger smoke tests, fixed as per pull request 114, to the 
old_examples backwards compatibility suite. 

The Messenger API will be supported but deprecated in the next release, so 
messenger examples are removed from the examples tree but are preserved (with 
other older examples) in the ruby/tests/old_examples tree to ensure we don't 
break deprecated features too early.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org