[jira] [Commented] (QPIDJMS-365) [Failover] failover.reconnectDelay not applied between connection attempts if peer Closes gracefully
[
https://issues.apache.org/jira/browse/QPIDJMS-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401399#comment-16401399
]
ASF subversion and git services commented on QPIDJMS-365:
-
Commit bb7b596bbed768b3e3cf03a02a8951b7fdd6d686 in qpid-jms's branch
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=bb7b596 ]
QPIDJMS-365 Ensure failed provider is cleared if close fails
> [Failover] failover.reconnectDelay not applied between connection attempts if
> peer Closes gracefully
>
>
> Key: QPIDJMS-365
> URL: https://issues.apache.org/jira/browse/QPIDJMS-365
> Project: Qpid JMS
> Issue Type: Bug
> Components: qpid-jms-client
>Reporter: Keith Wall
>Assignee: Timothy Bish
>Priority: Major
>
> When using Broker-J's High Availability feature, the client's failover
> abilities are used to allow the client to discover which Broker in the HA
> group has the master role. The client tries each Broker on the failover list
> until until one successfully responds to the {{Open}} indicating that it is
> current master.
>
> When a node is not in the master role, it gracefully closes the AMQP
> connection by sending a {{Close}} performative. During election periods, it
> is normal for all nodes in the HA group to respond with the {{Close}} until
> the election concludes.
> {noformat}
> Close{error=Error{condition=amqp:not-found, description='Virtual host
> 'localhost' is not active', info=null}}
> {noformat}
> The QpidJMS Client failover options includes a {{failover.reconnectDelay}}
> which "Controls the delay between successive reconnection attempts".
> However it appears that the reconnection delay is only applied between
> attempts when a connection fails owing to a 'transport' level failure
> (connection refused etc). If the connection fails at the AMQP level, the
> delay is not applied.
> This is impactful to the HA use-case for Broker-J. It means that during
> periods of reelection, the client, tightly spins in the reconnection loop,
> excessively consuming system resources. It is also necessary to ensure that
> {{failover.maxReconnectAttempts}} is set sufficiently large to allow for an
> election period to conclude successfully. Whilst the user could use
> unlimited reconnection attempts, this is unpleasant as it means the system
> won't fail in the case where the election does not conclude within a
> reasonable time period.
> Extract of TRACE level logging from
> {{org.apache.qpid.jms.provider.failover.FailoverProvider}} for the case when
> a AMQP connection is closed gracefully ({{Close}} performative):
> {noformat}
> 2018-03-13 11:04:54,951 [lization thread] - DEBUG FailoverProvider
>- Failover: the provider reports failure: Connection closed by external
> action [condition = amqp:connection:forced]
> 2018-03-13 11:04:54,951 [lization thread] - DEBUG FailoverProvider
>- handling Provider failure: Connection closed by external action
> [condition = amqp:connection:forced]
> 2018-03-13 11:04:54,951 [lization thread] - TRACE FailoverProvider
>- stack
> java.io.IOException: Connection closed by external action [condition =
> amqp:connection:forced]
> at
> org.apache.qpid.jms.util.IOExceptionSupport.create(IOExceptionSupport.java:45)
> at
> org.apache.qpid.jms.provider.amqp.AmqpProvider.fireProviderException(AmqpProvider.java:1086)
> at
> org.apache.qpid.jms.provider.amqp.AmqpAbstractResource.closeResource(AmqpAbstractResource.java:182)
> at
> org.apache.qpid.jms.provider.amqp.AmqpAbstractResource.processRemoteClose(AmqpAbstractResource.java:262)
> at
> org.apache.qpid.jms.provider.amqp.AmqpProvider.processUpdates(AmqpProvider.java:949)
> at
> org.apache.qpid.jms.provider.amqp.AmqpProvider.access$1900(AmqpProvider.java:104)
> at
> org.apache.qpid.jms.provider.amqp.AmqpProvider$17.run(AmqpProvider.java:831)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: javax.jms.JMSException: Connection closed by external action
> [condition = amqp:connection:forced]
>
[jira] [Updated] (PROTON-1782) [ruby] implement idle_timeout and heartbeats
[ https://issues.apache.org/jira/browse/PROTON-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway updated PROTON-1782: Description: The container does not wake up to service transport ticks, which means heartbeat frames are not sent to respect the idle_timeout settings. All the heartbeat and idle timeout logic is already implemented by the C library, the ruby Container only needs to ensure it wakes up often enough to service connections on time. > [ruby] implement idle_timeout and heartbeats > > > Key: PROTON-1782 > URL: https://issues.apache.org/jira/browse/PROTON-1782 > Project: Qpid Proton > Issue Type: Improvement > Components: ruby-binding >Affects Versions: proton-c-0.21.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.22.0 > > > The container does not wake up to service transport ticks, which means > heartbeat frames are not sent to respect the idle_timeout settings. > All the heartbeat and idle timeout logic is already implemented by the C > library, the ruby Container only needs to ensure it wakes up often enough to > service connections on time. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1782) [ruby] implement for scheduled tasks and heartbeats
[ https://issues.apache.org/jira/browse/PROTON-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401246#comment-16401246 ] Alan Conway commented on PROTON-1782: - [~miha-plesko] Here's a preview of the fix for idle_timeout, let me know if it fixes your problem. https://github.com/apache/qpid-proton/compare/master...alanconway:ruby-heartbeat?expand=1 > [ruby] implement for scheduled tasks and heartbeats > --- > > Key: PROTON-1782 > URL: https://issues.apache.org/jira/browse/PROTON-1782 > Project: Qpid Proton > Issue Type: Improvement > Components: ruby-binding >Affects Versions: proton-c-0.21.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.22.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-925) Doc: Update anchor name format
[ https://issues.apache.org/jira/browse/DISPATCH-925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-925. Resolution: Fixed Fix Version/s: 1.1.0 > Doc: Update anchor name format > -- > > Key: DISPATCH-925 > URL: https://issues.apache.org/jira/browse/DISPATCH-925 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Documentation >Reporter: Ben Hardesty >Assignee: Ben Hardesty >Priority: Major > Fix For: 1.1.0 > > > In the QDR doc, the anchor names should use the [id='anchor-name'] format, > which is more versatile than the [[anchor-name]] format. This also involves > updating each "xref" and "link" that refers to an anchor name. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-925) Doc: Update anchor name format
[ https://issues.apache.org/jira/browse/DISPATCH-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401109#comment-16401109 ] ASF GitHub Bot commented on DISPATCH-925: - Github user asfgit closed the pull request at: https://github.com/apache/qpid-dispatch/pull/264 > Doc: Update anchor name format > -- > > Key: DISPATCH-925 > URL: https://issues.apache.org/jira/browse/DISPATCH-925 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Documentation >Reporter: Ben Hardesty >Assignee: Ben Hardesty >Priority: Major > > In the QDR doc, the anchor names should use the [id='anchor-name'] format, > which is more versatile than the [[anchor-name]] format. This also involves > updating each "xref" and "link" that refers to an anchor name. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #264: DISPATCH-925: Update anchor name format and...
Github user asfgit closed the pull request at: https://github.com/apache/qpid-dispatch/pull/264 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDJMS-365) [Failover] failover.reconnectDelay not applied between connection attempts if peer Closes gracefully
[
https://issues.apache.org/jira/browse/QPIDJMS-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401102#comment-16401102
]
ASF subversion and git services commented on QPIDJMS-365:
-
Commit 33978120535a45fa30ae3b01749cda886d56a7b4 in qpid-jms's branch
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-jms.git;h=3397812 ]
QPIDJMS-365 Prevent multiple reconnect tasks from being triggered
Ensure that the reconnect handler doesn't queue up a new attempt by
mistake when handling potential errors.
> [Failover] failover.reconnectDelay not applied between connection attempts if
> peer Closes gracefully
>
>
> Key: QPIDJMS-365
> URL: https://issues.apache.org/jira/browse/QPIDJMS-365
> Project: Qpid JMS
> Issue Type: Bug
> Components: qpid-jms-client
>Reporter: Keith Wall
>Assignee: Timothy Bish
>Priority: Major
>
> When using Broker-J's High Availability feature, the client's failover
> abilities are used to allow the client to discover which Broker in the HA
> group has the master role. The client tries each Broker on the failover list
> until until one successfully responds to the {{Open}} indicating that it is
> current master.
>
> When a node is not in the master role, it gracefully closes the AMQP
> connection by sending a {{Close}} performative. During election periods, it
> is normal for all nodes in the HA group to respond with the {{Close}} until
> the election concludes.
> {noformat}
> Close{error=Error{condition=amqp:not-found, description='Virtual host
> 'localhost' is not active', info=null}}
> {noformat}
> The QpidJMS Client failover options includes a {{failover.reconnectDelay}}
> which "Controls the delay between successive reconnection attempts".
> However it appears that the reconnection delay is only applied between
> attempts when a connection fails owing to a 'transport' level failure
> (connection refused etc). If the connection fails at the AMQP level, the
> delay is not applied.
> This is impactful to the HA use-case for Broker-J. It means that during
> periods of reelection, the client, tightly spins in the reconnection loop,
> excessively consuming system resources. It is also necessary to ensure that
> {{failover.maxReconnectAttempts}} is set sufficiently large to allow for an
> election period to conclude successfully. Whilst the user could use
> unlimited reconnection attempts, this is unpleasant as it means the system
> won't fail in the case where the election does not conclude within a
> reasonable time period.
> Extract of TRACE level logging from
> {{org.apache.qpid.jms.provider.failover.FailoverProvider}} for the case when
> a AMQP connection is closed gracefully ({{Close}} performative):
> {noformat}
> 2018-03-13 11:04:54,951 [lization thread] - DEBUG FailoverProvider
>- Failover: the provider reports failure: Connection closed by external
> action [condition = amqp:connection:forced]
> 2018-03-13 11:04:54,951 [lization thread] - DEBUG FailoverProvider
>- handling Provider failure: Connection closed by external action
> [condition = amqp:connection:forced]
> 2018-03-13 11:04:54,951 [lization thread] - TRACE FailoverProvider
>- stack
> java.io.IOException: Connection closed by external action [condition =
> amqp:connection:forced]
> at
> org.apache.qpid.jms.util.IOExceptionSupport.create(IOExceptionSupport.java:45)
> at
> org.apache.qpid.jms.provider.amqp.AmqpProvider.fireProviderException(AmqpProvider.java:1086)
> at
> org.apache.qpid.jms.provider.amqp.AmqpAbstractResource.closeResource(AmqpAbstractResource.java:182)
> at
> org.apache.qpid.jms.provider.amqp.AmqpAbstractResource.processRemoteClose(AmqpAbstractResource.java:262)
> at
> org.apache.qpid.jms.provider.amqp.AmqpProvider.processUpdates(AmqpProvider.java:949)
> at
> org.apache.qpid.jms.provider.amqp.AmqpProvider.access$1900(AmqpProvider.java:104)
> at
> org.apache.qpid.jms.provider.amqp.AmqpProvider$17.run(AmqpProvider.java:831)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
[jira] [Commented] (PROTON-1791) TCP sockets remain open in CLOSE_WAIT state
[ https://issues.apache.org/jira/browse/PROTON-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400982#comment-16400982 ] Alan Conway commented on PROTON-1791: - [~miha-plesko] your poke-drivers workaround is not safe. Proton connections are thread-unsafe - the Container ensures that all activity is serialized correctly, but poking them from another thread is bad. Jiri's workaround (set a smaller idle_timeout from your own side) should work, and I should have the proper fix today or tomorrow. Your connection-close workaround is good. I guess that your application is experiencing a close down sequence different from what I'm seeing - possibly because of the broker or something in the app. Closing a connection involves protocol close frames, TCP FIN/ACK packets and file descriptor closure so there are several different orders of events possible. I'll have a look at the wireshark, also the output of running the client with env. vars PN_TRACE_FRM=1 PN_TRACE_EVT=1 PN_TRACE_LOG=1 might help. Finally if you can give me detailed instructions to reproduce (I can set up ActiveMQ if necessary but will need instructions/config for that) I > TCP sockets remain open in CLOSE_WAIT state > --- > > Key: PROTON-1791 > URL: https://issues.apache.org/jira/browse/PROTON-1791 > Project: Qpid Proton > Issue Type: Bug > Components: ruby-binding >Affects Versions: proton-c-0.21.0 > Environment: Confirmed on Ubuntu 16.04 and RHEL 7.4 > Confirmed on qpid_proton 0.19.0 and 0.21.0 >Reporter: Miha Plesko >Assignee: Alan Conway >Priority: Major > Labels: bug > Fix For: proton-c-0.22.0 > > Attachments: idle-disconnect.png > > > Hi guys, > thanks for developing the awesome qpid_proton ruby gem, we're using it on > daily basis! > However, recently we noticed following error in our server log: > Too many open files - socket(2) for "172.16.117.189" port 5672 > After some research it turns out that qpid_proton process is having > increasingly > more and more following file descriptors open: > $ lsof -ap 108533 > ruby108533 miha 116u IPv4 562438 0t0 TCP > 172.16.117.189:53626->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 197u IPv4 561644 0t0 TCP > 172.16.117.189:53630->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 311u IPv4 560657 0t0 TCP > 172.16.117.189:53634->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 549u IPv4 565342 0t0 TCP > 172.16.117.189:53642->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 576u IPv4 565122 0t0 TCP > 172.16.117.189:53650->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 603u IPv4 565738 0t0 TCP > 172.16.117.189:53654->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 630u IPv4 563021 0t0 TCP > 172.16.117.189:53658->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 657u IPv4 568361 0t0 TCP > 172.16.117.189:53662->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 666u IPv4 563027 0t0 TCP > 172.16.117.189:53666->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 675u IPv4 567538 0t0 TCP > 172.16.117.189:53670->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 684u IPv4 567998 0t0 TCP > 172.16.117.189:53678->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 690u IPv4 574709 0t0 TCP > 172.16.117.189:53686->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 693u IPv4 578725 0t0 TCP > 172.16.117.189:53694->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 696u IPv4 576840 0t0 TCP > 172.16.117.189:53698->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 699u IPv4 577819 0t0 TCP > 172.16.117.189:53702->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 702u IPv4 582192 0t0 TCP > 172.16.117.189:53710->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 705u IPv4 582861 0t0 TCP > 172.16.117.189:53714->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 708u IPv4 577363 0t0 TCP > 172.16.117.189:53718->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 711u IPv4 578175 0t0 TCP > 172.16.117.189:53722->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 714u IPv4 587172 0t0 TCP > 172.16.117.189:53730->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 717u IPv4 584387 0t0 TCP > 172.16.117.189:53734->147.75.102.132:amqp (CLOSE_WAIT) >
[jira] [Commented] (QPID-8123) [Broker-J] [BDB Test] Remove compile time dependency on Qpid JMS Client AMQP 0-x
[ https://issues.apache.org/jira/browse/QPID-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400866#comment-16400866 ] ASF subversion and git services commented on QPID-8123: --- Commit 58e38f31214795e8cffa596979327b04b83de771 in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=58e38f3 ] QPID-8123: [System Tests] Minor test related changes > [Broker-J] [BDB Test] Remove compile time dependency on Qpid JMS Client AMQP > 0-x > > > Key: QPID-8123 > URL: https://issues.apache.org/jira/browse/QPID-8123 > Project: Qpid > Issue Type: Test > Components: Broker-J, Java Tests >Reporter: Keith Wall >Priority: Major > > Remove compile time dependency on Qpid JMS Client AMQP 0-x and enable the BDB > HA tests for the AMQP 1.0 profile. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8123) [Broker-J] [BDB Test] Remove compile time dependency on Qpid JMS Client AMQP 0-x
[ https://issues.apache.org/jira/browse/QPID-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400865#comment-16400865 ] ASF subversion and git services commented on QPID-8123: --- Commit 59f78b05dce8232208f53924e12778e58d2fdb2b in qpid-broker-j's branch refs/heads/master from [~alex.rufous] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=59f78b0 ] QPID-8123: [System Tests] Fix destination URL in BDBStoreUpgradeTestPreparer > [Broker-J] [BDB Test] Remove compile time dependency on Qpid JMS Client AMQP > 0-x > > > Key: QPID-8123 > URL: https://issues.apache.org/jira/browse/QPID-8123 > Project: Qpid > Issue Type: Test > Components: Broker-J, Java Tests >Reporter: Keith Wall >Priority: Major > > Remove compile time dependency on Qpid JMS Client AMQP 0-x and enable the BDB > HA tests for the AMQP 1.0 profile. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8134) qpid::client::amqp0_10::SenderImpl::sendImpl multiple memory leaks
[ https://issues.apache.org/jira/browse/QPID-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dan clark updated QPID-8134: Description: There may be multiple leaks of the outgoing message structure and associated fields when using the qpid::client::amqp0_10::SenderImpl::send function to publish messages under certain setups. I will concede that there may be options that are beyond my ken to ameliorate the leak of messages structures, especially since there is an indication that under prolonged runs (a demonized version of an application like spout) that the statistics for quidd indicate increased acquires with zero releases. Capturing the leaks using the test applications spout/drain required adding an 'exit()' prior to the close, as during normal operations of a daemon, the connection remains open for a sustained period of time, thus the leak of structures within the c++ client library are found as structures still tracked by the library and cleaned up on 'connection.close()', but they should be cleaned up as a result of the completion of the send/receive ack or the termination of the life of the message based on the TTL of the message, which ever comes first. I have witnessed growth of the leaked structures into the millions of messages lasting more than 24hours with short (300sec) TTL of the messages based on scenarios attached using spout/drain as test vehicle. The attached spout.log uses a short 10message test and the spout.log contains 5 sets of different structures leaked (found with the 'bytes in 10 blocks are still reachable' lines, that are in line with much more sustained leaks when running the application for multiple days with millions of messages. The leaks seem to be associated with structures allocation 'stdstrings' to save the "subject" and the "payload" for string based messages using send for amq.topic output. Suggested work arounds are welcome based on application level changes to spout/drain (if they are missing key components) or changes to the address/setup of the queues for amq.topic messages (see the 'gospout.sh and godrain.sh' test drivers providing the specific address structures being used. For example, the following is one of the 5 different categories of leaked data from 'spout.log' on a valgrind analysis of the output post the send and session.sync but prior connection.close(): ==3388== 3,680 bytes in 10 blocks are still reachable in loss record 233 of 234 ==3388== at 0x4C2A203: operator new(unsigned long) (vg_replace_malloc.c:334) ==3388== by 0x4EB046C: qpid::client::Message::Message(std::string const&, std::string const&) (Message.cpp:31) ==3388== by 0x51742C1: qpid::client::amqp0_10::OutgoingMessage::OutgoingMessage() (OutgoingMessage.cpp:167) ==3388== by 0x5186200: qpid::client::amqp0_10::SenderImpl::sendImpl(qpid::messaging::Message const&) (SenderImpl.cpp:140) ==3388== by 0x5186485: operator() (SenderImpl.h:114) ==3388== by 0x5186485: execute (SessionImpl.h:102) ==3388== by 0x5186485: qpid::client::amqp0_10::SenderImpl::send(qpid::messaging::Message const&, bool) (SenderImpl.cpp:49) ==3388== by 0x40438D: main (spout.cpp:185) was: There may be multiple leaks of the outgoing message structure and associated fields when using the qpid::client::amqp0_10::SenderImpl::send function to publish messages under certain setups. I will concede that there may be options that are beyond my ken to ameliorate the messages, especially since there is an indication that under prolonged longs (a demonized version of an application like spout) that the statistics for quidd indicate increased acquires with zero releases. Capturing the leaks using the test applications spout required adding an 'exit()' prior to the close, as during normal operations of a daemon, the connection remains open for a sustained period of time, thus the leak of structures within the c++ client library are found as structures still tracked by the library and cleaned up on exit, but they should be cleaned up as a result of the completion of the send or the termination of the TTL of the message which ever comes first. I have witnessed growth of the leaked structures into the millions of messages based on scenarios attached using spout/drain as test vehicle. The attached log uses a short 10message test and the spout.log contains 5 sets of different structures leaked (found with the 'bytes in 10 blocks are still reachable' lines.) The leaks seem to be associated with structures allocation 'strings' to save the "subject" and the "payload" for string based messages send for amq.topic output. Suggested work arounds are welcome for application level fixes to spout/drain (if they are missing key components) or changes to the address/setup of the queues for amq.topic messages. For example: ==3388== 3,680 bytes in 10 blocks are still reachable in
[jira] [Created] (QPID-8134) qpid::client::amqp0_10::SenderImpl::sendImpl multiple memory leaks
dan clark created QPID-8134: --- Summary: qpid::client::amqp0_10::SenderImpl::sendImpl multiple memory leaks Key: QPID-8134 URL: https://issues.apache.org/jira/browse/QPID-8134 Project: Qpid Issue Type: Bug Components: C++ Client Affects Versions: qpid-cpp-1.37.0 Environment: *CentOS* Linux release 7.4.1708 (Core) Linux localhost.novalocal 3.10.0-327.el7.x86_64 #1 SMP Thu Nov 19 22:10:57 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux *qpid*-qmf-1.37.0-1.el7.x86_64 *qpid*-dispatch-debuginfo-1.0.0-1.el7.x86_64 python-*qpid*-1.37.0-1.el7.noarch *qpid*-proton-c-0.18.1-1.el7.x86_64 python-*qpid*-qmf-1.37.0-1.el7.x86_64 *qpid*-proton-debuginfo-0.18.1-1.el7.x86_64 *qpid*-cpp-debuginfo-1.37.0-1.el7.x86_64 *qpid*-cpp-client-devel-1.37.0-1.el7.x86_64 *qpid*-cpp-server-1.37.0-1.el7.x86_64 *qpid*-cpp-client-1.37.0-1.el7.x86_64 Reporter: dan clark Attachments: drain.cpp, godrain.sh, gospout.sh, qpid-stat.out, spout.cpp, spout.log There may be multiple leaks of the outgoing message structure and associated fields when using the qpid::client::amqp0_10::SenderImpl::send function to publish messages under certain setups. I will concede that there may be options that are beyond my ken to ameliorate the messages, especially since there is an indication that under prolonged longs (a demonized version of an application like spout) that the statistics for quidd indicate increased acquires with zero releases. Capturing the leaks using the test applications spout required adding an 'exit()' prior to the close, as during normal operations of a daemon, the connection remains open for a sustained period of time, thus the leak of structures within the c++ client library are found as structures still tracked by the library and cleaned up on exit, but they should be cleaned up as a result of the completion of the send or the termination of the TTL of the message which ever comes first. I have witnessed growth of the leaked structures into the millions of messages based on scenarios attached using spout/drain as test vehicle. The attached log uses a short 10message test and the spout.log contains 5 sets of different structures leaked (found with the 'bytes in 10 blocks are still reachable' lines.) The leaks seem to be associated with structures allocation 'strings' to save the "subject" and the "payload" for string based messages send for amq.topic output. Suggested work arounds are welcome for application level fixes to spout/drain (if they are missing key components) or changes to the address/setup of the queues for amq.topic messages. For example: ==3388== 3,680 bytes in 10 blocks are still reachable in loss record 233 of 234 ==3388== at 0x4C2A203: operator new(unsigned long) (vg_replace_malloc.c:334) ==3388== by 0x4EB046C: qpid::client::Message::Message(std::string const&, std::string const&) (Message.cpp:31) ==3388== by 0x51742C1: qpid::client::amqp0_10::OutgoingMessage::OutgoingMessage() (OutgoingMessage.cpp:167) ==3388== by 0x5186200: qpid::client::amqp0_10::SenderImpl::sendImpl(qpid::messaging::Message const&) (SenderImpl.cpp:140) ==3388== by 0x5186485: operator() (SenderImpl.h:114) ==3388== by 0x5186485: execute (SessionImpl.h:102) ==3388== by 0x5186485: qpid::client::amqp0_10::SenderImpl::send(qpid::messaging::Message const&, bool) (SenderImpl.cpp:49) ==3388== by 0x40438D: main (spout.cpp:185) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8130) [Broker-J] IAE "Comparison method violates its general contract!" can be thrown whilst comparing log file details of file logger
[
https://issues.apache.org/jira/browse/QPID-8130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400761#comment-16400761
]
ASF subversion and git services commented on QPID-8130:
---
Commit e1b5f5ad965a81676842dcf62be10b73a4c4442f in qpid-broker-j's branch
refs/heads/6.1.x from Oleksandr Rudyy
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=e1b5f5a ]
QPID-8130: [Broker-J] Fix comparator for log file details
> [Broker-J] IAE "Comparison method violates its general contract!" can be
> thrown whilst comparing log file details of file logger
>
>
> Key: QPID-8130
> URL: https://issues.apache.org/jira/browse/QPID-8130
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.2, qpid-java-6.0.8,
> qpid-java-broker-7.0.0, qpid-java-6.1.5, qpid-java-broker-7.0.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-6.1.6, qpid-java-broker-7.0.3
>
>
> IllegalArgumentException "Comparison method violates its general contract!"
> can be thrown whilst comparing log file details of BrokerFileLogger or
> ViortualHostFileLogger
> {noformat}
> 2018-03-14 13:06:57,951 DEBUG [qtp127624166-218]
> (o.a.q.s.m.p.s.r.RestServlet) - IllegalArgumentException processing request
> java.lang.IllegalArgumentException: Comparison method violates its general
> contract!
> at java.util.TimSort.mergeHi(TimSort.java:899)
> at java.util.TimSort.mergeAt(TimSort.java:516)
> at java.util.TimSort.mergeForceCollapse(TimSort.java:457)
> at java.util.TimSort.sort(TimSort.java:254)
> at java.util.Arrays.sort(Arrays.java:1512)
> at java.util.ArrayList.sort(ArrayList.java:1454)
> at java.util.Collections.sort(Collections.java:175)
> at
> org.apache.qpid.server.logging.logback.RolloverWatcher.getLogFileDetails(RolloverWatcher.java:130)
> at
> org.apache.qpid.server.logging.logback.BrokerFileLoggerImpl.getLogFiles(BrokerFileLoggerImpl.java:156)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.qpid.server.model.ConfiguredObjectMethodAttributeOrStatistic.getValue(ConfiguredObjectMethodAttributeOrStatistic.java:68)
> at
> org.apache.qpid.server.model.ConfiguredObjectMethodAttribute.getValue(ConfiguredObjectMethodAttribute.java:26)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.getAttribute(AbstractConfiguredObject.java:1856)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.incorporateAttributesIntoMap(ConfiguredObjectToMapConverter.java:86)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.convertObjectToMap(ConfiguredObjectToMapConverter.java:64)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.incorporateChildrenIntoMap(ConfiguredObjectToMapConverter.java:271)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.convertObjectToMap(ConfiguredObjectToMapConverter.java:69)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.doGet(RestServlet.java:247)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet.doGet(AbstractServlet.java:128)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.service(RestServlet.java:341)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:841)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1634)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter$1.run(AuthenticationCheckFilter.java:157)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter$1.run(AuthenticationCheckFilter.java:153)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter.doFilterChainAs(AuthenticationCheckFilter.java:152)
> at
>
[jira] [Commented] (PROTON-1791) TCP sockets remain open in CLOSE_WAIT state
[ https://issues.apache.org/jira/browse/PROTON-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400553#comment-16400553 ] Alan Conway commented on PROTON-1791: - On investigation - the workaround proposed by [~jdanek] is good - if you request an idle timeout that is less than or equal to than the remote's idle-timeout, that forces the remote to send a heartbeat frame, which wakes up the local connection, which allows it to send it's own heartbeat frame in time. Proton automatically halves the idle timeout sent on the wire so actually the remote will be sending at twice the rate requested by the idle_timeout option - so that ensures we won't time out by accident. > TCP sockets remain open in CLOSE_WAIT state > --- > > Key: PROTON-1791 > URL: https://issues.apache.org/jira/browse/PROTON-1791 > Project: Qpid Proton > Issue Type: Bug > Components: ruby-binding >Affects Versions: proton-c-0.21.0 > Environment: Confirmed on Ubuntu 16.04 and RHEL 7.4 > Confirmed on qpid_proton 0.19.0 and 0.21.0 >Reporter: Miha Plesko >Assignee: Alan Conway >Priority: Major > Labels: bug > Fix For: proton-c-0.22.0 > > Attachments: idle-disconnect.png > > > Hi guys, > thanks for developing the awesome qpid_proton ruby gem, we're using it on > daily basis! > However, recently we noticed following error in our server log: > Too many open files - socket(2) for "172.16.117.189" port 5672 > After some research it turns out that qpid_proton process is having > increasingly > more and more following file descriptors open: > $ lsof -ap 108533 > ruby108533 miha 116u IPv4 562438 0t0 TCP > 172.16.117.189:53626->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 197u IPv4 561644 0t0 TCP > 172.16.117.189:53630->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 311u IPv4 560657 0t0 TCP > 172.16.117.189:53634->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 549u IPv4 565342 0t0 TCP > 172.16.117.189:53642->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 576u IPv4 565122 0t0 TCP > 172.16.117.189:53650->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 603u IPv4 565738 0t0 TCP > 172.16.117.189:53654->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 630u IPv4 563021 0t0 TCP > 172.16.117.189:53658->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 657u IPv4 568361 0t0 TCP > 172.16.117.189:53662->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 666u IPv4 563027 0t0 TCP > 172.16.117.189:53666->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 675u IPv4 567538 0t0 TCP > 172.16.117.189:53670->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 684u IPv4 567998 0t0 TCP > 172.16.117.189:53678->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 690u IPv4 574709 0t0 TCP > 172.16.117.189:53686->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 693u IPv4 578725 0t0 TCP > 172.16.117.189:53694->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 696u IPv4 576840 0t0 TCP > 172.16.117.189:53698->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 699u IPv4 577819 0t0 TCP > 172.16.117.189:53702->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 702u IPv4 582192 0t0 TCP > 172.16.117.189:53710->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 705u IPv4 582861 0t0 TCP > 172.16.117.189:53714->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 708u IPv4 577363 0t0 TCP > 172.16.117.189:53718->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 711u IPv4 578175 0t0 TCP > 172.16.117.189:53722->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 714u IPv4 587172 0t0 TCP > 172.16.117.189:53730->147.75.102.132:amqp (CLOSE_WAIT) > ruby108533 miha 717u IPv4 584387 0t0 TCP > 172.16.117.189:53734->147.75.102.132:amqp (CLOSE_WAIT) > ... > I think the CLOSE_WAIT status of file descriptor indicates that the TCP > connection has already been closed, but the file descriptor wasn't closed. > After 9 hours or so there are enough of such file descriptors for OS to > complain about it. > We did all we could to close connections gracefully: > connection.container.stop > connection.close > connection = nil > but nothing seems to help. A simple but expensive workaround is to manually > invoke Ruby's garbage collection,
[jira] [Assigned] (QPIDIT-118) Add char and decimal in amqpnetlite shim
[ https://issues.apache.org/jira/browse/QPIDIT-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kim van der Riet reassigned QPIDIT-118: --- Assignee: Chuck Rolke > Add char and decimal in amqpnetlite shim > > > Key: QPIDIT-118 > URL: https://issues.apache.org/jira/browse/QPIDIT-118 > Project: Apache QPID Interoperability Test Suite > Issue Type: Improvement > Components: .Net Lite Shim >Reporter: Xin Chen >Assignee: Chuck Rolke >Priority: Trivial > > Encoding support for char and decimal has been added in the .Net Lite > library. The decimal type is implemented by Amqp.Types.Decimal. It is not the > C# decimal type because .Net does not use the standard IEEE 754 > decimal32/64/128 encoding. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1791) TCP sockets remain open in CLOSE_WAIT state
[
https://issues.apache.org/jira/browse/PROTON-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400483#comment-16400483
]
Miha Plesko commented on PROTON-1791:
-
Hi again guys,
a) [~aconway] the patch you pointed me to regarding file descriptor leakage
unfortunately doesn't change anything. It seems like it's not the right place
to invoke `io.close` there although I don't know why. The stalled sockets
remain.
b) To workaround heartbeating problem we have to invoke _process_ function o
ConnectionDriver instance periodically (every 5 seconds):
{code:java}
connection_driver.process
{code}
Only then the connection is not closed with "local-idle-timeout expired" error
every 2 or 3 minutes. It didn't help if we were sending messages to the queue,
nor opening and closing dummy session on connection. In fact, we weren't even
able to send more than one message to the queue because _on_sendable_ callback
was only invoked once after _connection.open_receiver_. I'm not sure why this
happens (is it a bug? is it the ActiveMQ configuration?), but I didn't have
time to dive into.
To address both problems (i.e. socket leakage and heartbeat sending) we had to
implement it like this
[https://github.com/ManageIQ/manageiq-providers-nuage/pull/72/files] . If you
can, I'd kindly ask you guys for a review on that small PR. I realize you can't
really test it without access to ActiveMQ, but since you're much more familiar
with the qpid_proton internals than myself, I'd really value your thoughts.
Best Regards,
Miha
> TCP sockets remain open in CLOSE_WAIT state
> ---
>
> Key: PROTON-1791
> URL: https://issues.apache.org/jira/browse/PROTON-1791
> Project: Qpid Proton
> Issue Type: Bug
> Components: ruby-binding
>Affects Versions: proton-c-0.21.0
> Environment: Confirmed on Ubuntu 16.04 and RHEL 7.4
> Confirmed on qpid_proton 0.19.0 and 0.21.0
>Reporter: Miha Plesko
>Assignee: Alan Conway
>Priority: Major
> Labels: bug
> Fix For: proton-c-0.22.0
>
> Attachments: idle-disconnect.png
>
>
> Hi guys,
> thanks for developing the awesome qpid_proton ruby gem, we're using it on
> daily basis!
> However, recently we noticed following error in our server log:
> Too many open files - socket(2) for "172.16.117.189" port 5672
> After some research it turns out that qpid_proton process is having
> increasingly
> more and more following file descriptors open:
> $ lsof -ap 108533
> ruby108533 miha 116u IPv4 562438 0t0 TCP
> 172.16.117.189:53626->147.75.102.132:amqp (CLOSE_WAIT)
> ruby108533 miha 197u IPv4 561644 0t0 TCP
> 172.16.117.189:53630->147.75.102.132:amqp (CLOSE_WAIT)
> ruby108533 miha 311u IPv4 560657 0t0 TCP
> 172.16.117.189:53634->147.75.102.132:amqp (CLOSE_WAIT)
> ruby108533 miha 549u IPv4 565342 0t0 TCP
> 172.16.117.189:53642->147.75.102.132:amqp (CLOSE_WAIT)
> ruby108533 miha 576u IPv4 565122 0t0 TCP
> 172.16.117.189:53650->147.75.102.132:amqp (CLOSE_WAIT)
> ruby108533 miha 603u IPv4 565738 0t0 TCP
> 172.16.117.189:53654->147.75.102.132:amqp (CLOSE_WAIT)
> ruby108533 miha 630u IPv4 563021 0t0 TCP
> 172.16.117.189:53658->147.75.102.132:amqp (CLOSE_WAIT)
> ruby108533 miha 657u IPv4 568361 0t0 TCP
> 172.16.117.189:53662->147.75.102.132:amqp (CLOSE_WAIT)
> ruby108533 miha 666u IPv4 563027 0t0 TCP
> 172.16.117.189:53666->147.75.102.132:amqp (CLOSE_WAIT)
> ruby108533 miha 675u IPv4 567538 0t0 TCP
> 172.16.117.189:53670->147.75.102.132:amqp (CLOSE_WAIT)
> ruby108533 miha 684u IPv4 567998 0t0 TCP
> 172.16.117.189:53678->147.75.102.132:amqp (CLOSE_WAIT)
> ruby108533 miha 690u IPv4 574709 0t0 TCP
> 172.16.117.189:53686->147.75.102.132:amqp (CLOSE_WAIT)
> ruby108533 miha 693u IPv4 578725 0t0 TCP
> 172.16.117.189:53694->147.75.102.132:amqp (CLOSE_WAIT)
> ruby108533 miha 696u IPv4 576840 0t0 TCP
> 172.16.117.189:53698->147.75.102.132:amqp (CLOSE_WAIT)
> ruby108533 miha 699u IPv4 577819 0t0 TCP
> 172.16.117.189:53702->147.75.102.132:amqp (CLOSE_WAIT)
> ruby108533 miha 702u IPv4 582192 0t0 TCP
> 172.16.117.189:53710->147.75.102.132:amqp (CLOSE_WAIT)
> ruby108533 miha 705u IPv4 582861 0t0 TCP
> 172.16.117.189:53714->147.75.102.132:amqp (CLOSE_WAIT)
> ruby108533 miha 708u IPv4 577363 0t0 TCP
> 172.16.117.189:53718->147.75.102.132:amqp (CLOSE_WAIT)
>
[jira] [Created] (QPID-8132) Refresh Apache BCEL dependency to 6.2
Keith Wall created QPID-8132: Summary: Refresh Apache BCEL dependency to 6.2 Key: QPID-8132 URL: https://issues.apache.org/jira/browse/QPID-8132 Project: Qpid Issue Type: Improvement Components: Broker-J Reporter: Keith Wall The Apache BCEL dependency used by Broker-J is getting stale (5.2). 6.2 is the latest release. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8133) Refresh Commons-CLI dependency (1.4)
Keith Wall created QPID-8133: Summary: Refresh Commons-CLI dependency (1.4) Key: QPID-8133 URL: https://issues.apache.org/jira/browse/QPID-8133 Project: Qpid Issue Type: Improvement Components: Broker-J Reporter: Keith Wall The Commons CLI dependency used by Broker-J is getting stale. The latest release is 1.4. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (QPID-7541) [Java Broker] Close Consumers when a Queue is deleted
[ https://issues.apache.org/jira/browse/QPID-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400433#comment-16400433 ] Artyom Safronov edited comment on QPID-7541 at 3/15/18 1:59 PM: Here it is. [^proton-j_client.log] The important moment is that a queue have to be deleted within 10 seconds after a receiver/sender is attached to it. was (Author: artyom82): Here it is. [^proton-j_client.log] The important moment is a queue have to be deleted within 10 seconds after a receiver/sender is attached to it. > [Java Broker] Close Consumers when a Queue is deleted > - > > Key: QPID-7541 > URL: https://issues.apache.org/jira/browse/QPID-7541 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Lorenz Quack >Priority: Major > Fix For: qpid-java-broker-7.0.3 > > Attachments: proton-j_client.log > > > Currently when a Queue is deleted the associated Consumers are not closed. > This is essentially a resource leak. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7541) [Java Broker] Close Consumers when a Queue is deleted
[ https://issues.apache.org/jira/browse/QPID-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artyom Safronov updated QPID-7541: -- Attachment: proton-j_client.log > [Java Broker] Close Consumers when a Queue is deleted > - > > Key: QPID-7541 > URL: https://issues.apache.org/jira/browse/QPID-7541 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Lorenz Quack >Priority: Major > Fix For: qpid-java-broker-7.0.3 > > Attachments: proton-j_client.log > > > Currently when a Queue is deleted the associated Consumers are not closed. > This is essentially a resource leak. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7541) [Java Broker] Close Consumers when a Queue is deleted
[ https://issues.apache.org/jira/browse/QPID-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400433#comment-16400433 ] Artyom Safronov commented on QPID-7541: --- Here it is. [^proton-j_client.log] The important moment is a queue have to be deleted within 10 seconds after a receiver/sender is attached to it. > [Java Broker] Close Consumers when a Queue is deleted > - > > Key: QPID-7541 > URL: https://issues.apache.org/jira/browse/QPID-7541 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Lorenz Quack >Priority: Major > Fix For: qpid-java-broker-7.0.3 > > Attachments: proton-j_client.log > > > Currently when a Queue is deleted the associated Consumers are not closed. > This is essentially a resource leak. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7541) [Java Broker] Close Consumers when a Queue is deleted
[
https://issues.apache.org/jira/browse/QPID-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400365#comment-16400365
]
Keith Wall commented on QPID-7541:
--
> It looks like if a queue is deleted and recreated with the same name within a
> short period then an event about that is sent.
That sounds odd. There is a TODO in the Broker-J code related to this Jira
related to the handling of existing consumers when queues are deleted. What
event do you mean exactly? Can you repeat with environment variable
{{PN_TRACE_FRM}} set {{true}} on your application side and capture the protocol
trace written by the Proton library?
> [Java Broker] Close Consumers when a Queue is deleted
> -
>
> Key: QPID-7541
> URL: https://issues.apache.org/jira/browse/QPID-7541
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Reporter: Lorenz Quack
>Priority: Major
> Fix For: qpid-java-broker-7.0.3
>
>
> Currently when a Queue is deleted the associated Consumers are not closed.
> This is essentially a resource leak.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1793) [ruby] not sending heartbeat frames to respect idle-timeout
[ https://issues.apache.org/jira/browse/PROTON-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400315#comment-16400315 ] Jiri Daněk commented on PROTON-1793: I cannot update the Environment field in the Jira because it is closed. So I am posting as a comment. I am using ruby 2.5.0 on Linux, against Artemis 2.4.0 (AMQ Broker 7.1.0), with qpid-proton either 0.21 or (with the same behaviour) my build of master (at commit f1100fea2b67538b2 from Mar 7). The binary is from the following repo, master branch at the indicated commit https://github.com/rh-messaging/cli-proton-ruby/commit/54fe8bf8e906b701473987e8b471d580cd036bc9. > [ruby] not sending heartbeat frames to respect idle-timeout > --- > > Key: PROTON-1793 > URL: https://issues.apache.org/jira/browse/PROTON-1793 > Project: Qpid Proton > Issue Type: Bug > Components: ruby-binding >Affects Versions: proton-c-0.21.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.22.0 > > > The ruby library does not send heartbeat frames when the remote end of a > connection requests an idle-timeout. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1793) [ruby] not sending heartbeat frames to respect idle-timeout
[ https://issues.apache.org/jira/browse/PROTON-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400309#comment-16400309 ] Alan Conway commented on PROTON-1793: - Here's what's happening: the proton-c engine will generate heartbeat events correctly *if* it is woken up often enough. The bug in the ruby binding is that it is not waking up the engine as needed so that it can generate them. For some reason, requesting heartbeats is causing the engine to get woken up - which allows it to send heartbeats as well. Since there's no explicit code in the ruby binding to wake it up for heartbeats, I need to review what's happening here as part of the fix, to make sure we're not generating needless wake-ups. What client are you using in your test above? > [ruby] not sending heartbeat frames to respect idle-timeout > --- > > Key: PROTON-1793 > URL: https://issues.apache.org/jira/browse/PROTON-1793 > Project: Qpid Proton > Issue Type: Bug > Components: ruby-binding >Affects Versions: proton-c-0.21.0 >Reporter: Alan Conway >Assignee: Alan Conway >Priority: Major > Fix For: proton-c-0.22.0 > > > The ruby library does not send heartbeat frames when the remote end of a > connection requests an idle-timeout. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7541) [Java Broker] Close Consumers when a Queue is deleted
[ https://issues.apache.org/jira/browse/QPID-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400301#comment-16400301 ] Artyom Safronov commented on QPID-7541: --- It looks like if a queue is deleted and recreated with the same name within a short period then an event about that is sent. > [Java Broker] Close Consumers when a Queue is deleted > - > > Key: QPID-7541 > URL: https://issues.apache.org/jira/browse/QPID-7541 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Lorenz Quack >Priority: Major > Fix For: qpid-java-broker-7.0.3 > > > Currently when a Queue is deleted the associated Consumers are not closed. > This is essentially a resource leak. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7541) [Java Broker] Close Consumers when a Queue is deleted
[ https://issues.apache.org/jira/browse/QPID-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400296#comment-16400296 ] Artyom Safronov commented on QPID-7541: --- It is interesting but sometimes my client receives a notification if a queue was deleted. Is it possible? > [Java Broker] Close Consumers when a Queue is deleted > - > > Key: QPID-7541 > URL: https://issues.apache.org/jira/browse/QPID-7541 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Lorenz Quack >Priority: Major > Fix For: qpid-java-broker-7.0.3 > > > Currently when a Queue is deleted the associated Consumers are not closed. > This is essentially a resource leak. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7541) [Java Broker] Close Consumers when a Queue is deleted
[ https://issues.apache.org/jira/browse/QPID-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-7541: - Fix Version/s: qpid-java-broker-7.0.3 > [Java Broker] Close Consumers when a Queue is deleted > - > > Key: QPID-7541 > URL: https://issues.apache.org/jira/browse/QPID-7541 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Lorenz Quack >Priority: Major > Fix For: qpid-java-broker-7.0.3 > > > Currently when a Queue is deleted the associated Consumers are not closed. > This is essentially a resource leak. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Issue Comment Deleted] (QPID-7541) [Java Broker] Close Consumers when a Queue is deleted
[ https://issues.apache.org/jira/browse/QPID-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artyom Safronov updated QPID-7541: -- Comment: was deleted (was: It is interesting but sometimes my client receives a notification if a queue was deleted. Is it possible?) > [Java Broker] Close Consumers when a Queue is deleted > - > > Key: QPID-7541 > URL: https://issues.apache.org/jira/browse/QPID-7541 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Lorenz Quack >Priority: Major > > Currently when a Queue is deleted the associated Consumers are not closed. > This is essentially a resource leak. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7541) [Java Broker] Close Consumers when a Queue is deleted
[ https://issues.apache.org/jira/browse/QPID-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400275#comment-16400275 ] Artyom Safronov commented on QPID-7541: --- It is interesting but sometimes my client receives a notification if a queue was deleted. > [Java Broker] Close Consumers when a Queue is deleted > - > > Key: QPID-7541 > URL: https://issues.apache.org/jira/browse/QPID-7541 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Lorenz Quack >Priority: Major > > Currently when a Queue is deleted the associated Consumers are not closed. > This is essentially a resource leak. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (QPID-7541) [Java Broker] Close Consumers when a Queue is deleted
[ https://issues.apache.org/jira/browse/QPID-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400275#comment-16400275 ] Artyom Safronov edited comment on QPID-7541 at 3/15/18 11:42 AM: - It is interesting but sometimes my client receives a notification if a queue was deleted. Is it possible? was (Author: artyom82): It is interesting but sometimes my client receives a notification if a queue was deleted. > [Java Broker] Close Consumers when a Queue is deleted > - > > Key: QPID-7541 > URL: https://issues.apache.org/jira/browse/QPID-7541 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Lorenz Quack >Priority: Major > > Currently when a Queue is deleted the associated Consumers are not closed. > This is essentially a resource leak. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7197) [Broker-J] Prevent deletion of objects that are in use
[ https://issues.apache.org/jira/browse/QPID-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400253#comment-16400253 ] Keith Wall commented on QPID-7197: -- The change on the whole looks good to me. My comments are: * The exception message needs to be in language understood by the user. The term "Configured Object" has no currency. The message should be in expressed in terms of the objects' names and the category class names. I am relaxed about the camel casing. * Even though the current model doesn't need it (with the elimination of bindings as children), the code should still check that children of the object being deleted aren't referenced outside the subtree being deleted. I suggest extending the test hierarchy to give us a convenient test case. > [Broker-J] Prevent deletion of objects that are in use > -- > > Key: QPID-7197 > URL: https://issues.apache.org/jira/browse/QPID-7197 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Reporter: Keith Wall >Assignee: Keith Wall >Priority: Major > Fix For: qpid-java-broker-7.1.0 > > Attachments: > 0001-QPID-7197-Broker-J-Generalize-a-validation-of-refere.patch > > > Enhance the facilities of the CO framework to prevent the deletion of the > objects that are in use elsewhere in the model. Specifically this means > searching for other COs that have an attribute that refers to the object that > is about to be deleted,. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8114) [Broker-J] Attempting to use an unknown filter type incorrectly causes connection closure with a decode error
[
https://issues.apache.org/jira/browse/QPID-8114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-8114:
-
Fix Version/s: qpid-java-broker-7.1.0
> [Broker-J] Attempting to use an unknown filter type incorrectly causes
> connection closure with a decode error
> -
>
> Key: QPID-8114
> URL: https://issues.apache.org/jira/browse/QPID-8114
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Reporter: Rob Godfrey
>Priority: Major
> Fix For: qpid-java-broker-7.1.0
>
> Attachments:
> QPID-8114___[Broker-J]_Attempting_to_use_an_unknown_filter_type_incorrectly_causes_connect.patch
>
>
> As discovered in QPID-8113 if a client attempts to attach to a source using
> an unknown filter type (i.e. an unrecognised descriptor) the broker responds
> with a decode error similar to
> {{[0x555941994670]:0 <- @close(24) [error=@error(29)
> [condition=:"amqp:decode-error", description="Expected key type is 'Filter'
> but got 'DescribedType'"]]}}
> Instead the broker should simply fail to attach (i.e. attach with
> source=null) and then immediately detach with a {{not-implemented}} error.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8114) [Broker-J] Attempting to use an unknown filter type incorrectly causes connection closure with a decode error
[
https://issues.apache.org/jira/browse/QPID-8114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400232#comment-16400232
]
Keith Wall commented on QPID-8114:
--
Thanks Rob, we'll take a look
> [Broker-J] Attempting to use an unknown filter type incorrectly causes
> connection closure with a decode error
> -
>
> Key: QPID-8114
> URL: https://issues.apache.org/jira/browse/QPID-8114
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Reporter: Rob Godfrey
>Priority: Major
> Fix For: qpid-java-broker-7.1.0
>
> Attachments:
> QPID-8114___[Broker-J]_Attempting_to_use_an_unknown_filter_type_incorrectly_causes_connect.patch
>
>
> As discovered in QPID-8113 if a client attempts to attach to a source using
> an unknown filter type (i.e. an unrecognised descriptor) the broker responds
> with a decode error similar to
> {{[0x555941994670]:0 <- @close(24) [error=@error(29)
> [condition=:"amqp:decode-error", description="Expected key type is 'Filter'
> but got 'DescribedType'"]]}}
> Instead the broker should simply fail to attach (i.e. attach with
> source=null) and then immediately detach with a {{not-implemented}} error.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8113) [Broker-J] Incorrect symbolic descriptor used for (JMS) selector
[ https://issues.apache.org/jira/browse/QPID-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400221#comment-16400221 ] ASF subversion and git services commented on QPID-8113: --- Commit 1b860ff935b0384fd36d7b366e9a0b901f66dcf2 in qpid-broker-j's branch refs/heads/7.0.x from [~godfrer] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=1b860ff ] QPID-8113 : Incorrect symbolic descriptor used for (JMS) selector filter > [Broker-J] Incorrect symbolic descriptor used for (JMS) selector > > > Key: QPID-8113 > URL: https://issues.apache.org/jira/browse/QPID-8113 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.2, qpid-java-broker-7.0.0, > qpid-java-broker-7.0.1 >Reporter: Rob Godfrey >Assignee: Rob Godfrey >Priority: Major > Fix For: qpid-java-broker-7.0.3 > > > As per > [this|http://mail-archives.apache.org/mod_mbox/qpid-users/201802.mbox/%3CCACsaS95BJjm8e09xZGEPkp_Wsq801sdLd0fVnR9Tqy-JwJWnhg%40mail.gmail.com%3E] > message, the symbolic descriptor for JMS-style selector parsing is > incorrectly defined within Broker-J -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8130) [Broker-J] IAE "Comparison method violates its general contract!" can be thrown whilst comparing log file details of file logger
[
https://issues.apache.org/jira/browse/QPID-8130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400220#comment-16400220
]
ASF subversion and git services commented on QPID-8130:
---
Commit 0e956813b0909ed08c8aac3b0b259d0b63d2d474 in qpid-broker-j's branch
refs/heads/7.0.x from Oleksandr Rudyy
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=0e95681 ]
QPID-8130: [Broker-J] Fix comparator for log file details
> [Broker-J] IAE "Comparison method violates its general contract!" can be
> thrown whilst comparing log file details of file logger
>
>
> Key: QPID-8130
> URL: https://issues.apache.org/jira/browse/QPID-8130
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.2, qpid-java-6.0.8,
> qpid-java-broker-7.0.0, qpid-java-6.1.5, qpid-java-broker-7.0.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-6.1.6, qpid-java-broker-7.0.3
>
>
> IllegalArgumentException "Comparison method violates its general contract!"
> can be thrown whilst comparing log file details of BrokerFileLogger or
> ViortualHostFileLogger
> {noformat}
> 2018-03-14 13:06:57,951 DEBUG [qtp127624166-218]
> (o.a.q.s.m.p.s.r.RestServlet) - IllegalArgumentException processing request
> java.lang.IllegalArgumentException: Comparison method violates its general
> contract!
> at java.util.TimSort.mergeHi(TimSort.java:899)
> at java.util.TimSort.mergeAt(TimSort.java:516)
> at java.util.TimSort.mergeForceCollapse(TimSort.java:457)
> at java.util.TimSort.sort(TimSort.java:254)
> at java.util.Arrays.sort(Arrays.java:1512)
> at java.util.ArrayList.sort(ArrayList.java:1454)
> at java.util.Collections.sort(Collections.java:175)
> at
> org.apache.qpid.server.logging.logback.RolloverWatcher.getLogFileDetails(RolloverWatcher.java:130)
> at
> org.apache.qpid.server.logging.logback.BrokerFileLoggerImpl.getLogFiles(BrokerFileLoggerImpl.java:156)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.qpid.server.model.ConfiguredObjectMethodAttributeOrStatistic.getValue(ConfiguredObjectMethodAttributeOrStatistic.java:68)
> at
> org.apache.qpid.server.model.ConfiguredObjectMethodAttribute.getValue(ConfiguredObjectMethodAttribute.java:26)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.getAttribute(AbstractConfiguredObject.java:1856)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.incorporateAttributesIntoMap(ConfiguredObjectToMapConverter.java:86)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.convertObjectToMap(ConfiguredObjectToMapConverter.java:64)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.incorporateChildrenIntoMap(ConfiguredObjectToMapConverter.java:271)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.convertObjectToMap(ConfiguredObjectToMapConverter.java:69)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.doGet(RestServlet.java:247)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet.doGet(AbstractServlet.java:128)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.service(RestServlet.java:341)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:841)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1634)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter$1.run(AuthenticationCheckFilter.java:157)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter$1.run(AuthenticationCheckFilter.java:153)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter.doFilterChainAs(AuthenticationCheckFilter.java:152)
> at
>
[jira] [Commented] (QPID-8115) [Broker-J] Incorrect symbolic descriptor used for no-local filter
[
https://issues.apache.org/jira/browse/QPID-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400219#comment-16400219
]
Keith Wall commented on QPID-8115:
--
Change looks reasonable to me.
> [Broker-J] Incorrect symbolic descriptor used for no-local filter
> -
>
> Key: QPID-8115
> URL: https://issues.apache.org/jira/browse/QPID-8115
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.2, qpid-java-broker-7.0.0,
> qpid-java-broker-7.0.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.3
>
>
> [apache.org amp specification extension for
> filters|http://www.amqp.org/specification/1.0/filters] declares {{no local
> filter}} with symbolic descriptor {{apache.org:no-local-filter:list}}. The
> Broker-J uses incorrect symbolic descriptor
> {{"apache.org:jms-no-local-filter:list"}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8115) [Broker-J] Incorrect symbolic descriptor used for no-local filter
[
https://issues.apache.org/jira/browse/QPID-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400222#comment-16400222
]
ASF subversion and git services commented on QPID-8115:
---
Commit ce05c23a52ccfe539d75d05ab45f1bff0f668ef8 in qpid-broker-j's branch
refs/heads/7.0.x from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=ce05c23 ]
QPID-8115: [Broker-J][AMQP 1.0] Fix symbolic descriptor for 'no local filter'
> [Broker-J] Incorrect symbolic descriptor used for no-local filter
> -
>
> Key: QPID-8115
> URL: https://issues.apache.org/jira/browse/QPID-8115
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.2, qpid-java-broker-7.0.0,
> qpid-java-broker-7.0.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.3
>
>
> [apache.org amp specification extension for
> filters|http://www.amqp.org/specification/1.0/filters] declares {{no local
> filter}} with symbolic descriptor {{apache.org:no-local-filter:list}}. The
> Broker-J uses incorrect symbolic descriptor
> {{"apache.org:jms-no-local-filter:list"}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8115) [Broker-J] Incorrect symbolic descriptor used for no-local filter
[
https://issues.apache.org/jira/browse/QPID-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-8115:
-
Issue Type: Bug (was: Task)
> [Broker-J] Incorrect symbolic descriptor used for no-local filter
> -
>
> Key: QPID-8115
> URL: https://issues.apache.org/jira/browse/QPID-8115
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.2, qpid-java-broker-7.0.0,
> qpid-java-broker-7.0.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.0.3
>
>
> [apache.org amp specification extension for
> filters|http://www.amqp.org/specification/1.0/filters] declares {{no local
> filter}} with symbolic descriptor {{apache.org:no-local-filter:list}}. The
> Broker-J uses incorrect symbolic descriptor
> {{"apache.org:jms-no-local-filter:list"}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8115) [Broker-J] Incorrect symbolic descriptor used for no-local filter
[
https://issues.apache.org/jira/browse/QPID-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall resolved QPID-8115.
--
Resolution: Fixed
> [Broker-J] Incorrect symbolic descriptor used for no-local filter
> -
>
> Key: QPID-8115
> URL: https://issues.apache.org/jira/browse/QPID-8115
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.2, qpid-java-broker-7.0.0,
> qpid-java-broker-7.0.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.3
>
>
> [apache.org amp specification extension for
> filters|http://www.amqp.org/specification/1.0/filters] declares {{no local
> filter}} with symbolic descriptor {{apache.org:no-local-filter:list}}. The
> Broker-J uses incorrect symbolic descriptor
> {{"apache.org:jms-no-local-filter:list"}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8115) [Broker-J] Incorrect symbolic descriptor used for no-local filter
[
https://issues.apache.org/jira/browse/QPID-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-8115:
-
Priority: Minor (was: Major)
> [Broker-J] Incorrect symbolic descriptor used for no-local filter
> -
>
> Key: QPID-8115
> URL: https://issues.apache.org/jira/browse/QPID-8115
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.2, qpid-java-broker-7.0.0,
> qpid-java-broker-7.0.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.3
>
>
> [apache.org amp specification extension for
> filters|http://www.amqp.org/specification/1.0/filters] declares {{no local
> filter}} with symbolic descriptor {{apache.org:no-local-filter:list}}. The
> Broker-J uses incorrect symbolic descriptor
> {{"apache.org:jms-no-local-filter:list"}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8115) [Broker-J] Incorrect symbolic descriptor used for no-local filter
[
https://issues.apache.org/jira/browse/QPID-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-8115:
-
Fix Version/s: qpid-java-broker-7.0.3
> [Broker-J] Incorrect symbolic descriptor used for no-local filter
> -
>
> Key: QPID-8115
> URL: https://issues.apache.org/jira/browse/QPID-8115
> Project: Qpid
> Issue Type: Task
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.2, qpid-java-broker-7.0.0,
> qpid-java-broker-7.0.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.0.3
>
>
> [apache.org amp specification extension for
> filters|http://www.amqp.org/specification/1.0/filters] declares {{no local
> filter}} with symbolic descriptor {{apache.org:no-local-filter:list}}. The
> Broker-J uses incorrect symbolic descriptor
> {{"apache.org:jms-no-local-filter:list"}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-8113) [Broker-J] Incorrect symbolic descriptor used for (JMS) selector
[ https://issues.apache.org/jira/browse/QPID-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved QPID-8113. -- Resolution: Fixed > [Broker-J] Incorrect symbolic descriptor used for (JMS) selector > > > Key: QPID-8113 > URL: https://issues.apache.org/jira/browse/QPID-8113 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.2, qpid-java-broker-7.0.0, > qpid-java-broker-7.0.1 >Reporter: Rob Godfrey >Assignee: Rob Godfrey >Priority: Major > Fix For: qpid-java-broker-7.0.3 > > > As per > [this|http://mail-archives.apache.org/mod_mbox/qpid-users/201802.mbox/%3CCACsaS95BJjm8e09xZGEPkp_Wsq801sdLd0fVnR9Tqy-JwJWnhg%40mail.gmail.com%3E] > message, the symbolic descriptor for JMS-style selector parsing is > incorrectly defined within Broker-J -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (QPID-8113) [Broker-J] Incorrect symbolic descriptor used for (JMS) selector
[ https://issues.apache.org/jira/browse/QPID-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400203#comment-16400203 ] Keith Wall edited comment on QPID-8113 at 3/15/18 10:51 AM: I note that the definition for filter is [apache.org:selector-filter:string (0x468C:0x0004)|https://svn.apache.org/repos/asf/qpid/trunk/qpid/specs/apache-filters.xml#type-selector-filter] does not actually define an on the wire JMS selector but an AMQP 1.0 filter written in terms of AMQP 1.0 header names - which is currently the Broker does not support I expect that this will be superseded by the work of AMQP TC. Once the work of the TC is done, the Broker's implementation can be brought into line. was (Author: k-wall): I note that the definition for filter is [apache.org:selector-filter:string (0x468C:0x0004)|https://svn.apache.org/repos/asf/qpid/trunk/qpid/specs/apache-filters.xml#type-selector-filter] does not actually define an on the wire JMS selector but an AMQP 1.0 filter written in terms of AMQP 1.0 header names. I expect that this will be superseded by the work of AMQP TC. > [Broker-J] Incorrect symbolic descriptor used for (JMS) selector > > > Key: QPID-8113 > URL: https://issues.apache.org/jira/browse/QPID-8113 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.2, qpid-java-broker-7.0.0, > qpid-java-broker-7.0.1 >Reporter: Rob Godfrey >Assignee: Rob Godfrey >Priority: Major > Fix For: qpid-java-broker-7.0.3 > > > As per > [this|http://mail-archives.apache.org/mod_mbox/qpid-users/201802.mbox/%3CCACsaS95BJjm8e09xZGEPkp_Wsq801sdLd0fVnR9Tqy-JwJWnhg%40mail.gmail.com%3E] > message, the symbolic descriptor for JMS-style selector parsing is > incorrectly defined within Broker-J -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (QPID-8113) [Broker-J] Incorrect symbolic descriptor used for (JMS) selector
[ https://issues.apache.org/jira/browse/QPID-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400203#comment-16400203 ] Keith Wall edited comment on QPID-8113 at 3/15/18 10:51 AM: I note that the definition for filter is [apache.org:selector-filter:string (0x468C:0x0004)|https://svn.apache.org/repos/asf/qpid/trunk/qpid/specs/apache-filters.xml#type-selector-filter] does not actually define an on the wire JMS selector but an AMQP 1.0 filter written in terms of AMQP 1.0 header names - which is currently the Broker does not support I expect that this will be superseded by the work of AMQP TC. Once the work of the TC is done, the Broker's implementation can be brought into line. was (Author: k-wall): I note that the definition for filter is [apache.org:selector-filter:string (0x468C:0x0004)|https://svn.apache.org/repos/asf/qpid/trunk/qpid/specs/apache-filters.xml#type-selector-filter] does not actually define an on the wire JMS selector but an AMQP 1.0 filter written in terms of AMQP 1.0 header names - which is currently the Broker does not support I expect that this will be superseded by the work of AMQP TC. Once the work of the TC is done, the Broker's implementation can be brought into line. > [Broker-J] Incorrect symbolic descriptor used for (JMS) selector > > > Key: QPID-8113 > URL: https://issues.apache.org/jira/browse/QPID-8113 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.2, qpid-java-broker-7.0.0, > qpid-java-broker-7.0.1 >Reporter: Rob Godfrey >Assignee: Rob Godfrey >Priority: Major > Fix For: qpid-java-broker-7.0.3 > > > As per > [this|http://mail-archives.apache.org/mod_mbox/qpid-users/201802.mbox/%3CCACsaS95BJjm8e09xZGEPkp_Wsq801sdLd0fVnR9Tqy-JwJWnhg%40mail.gmail.com%3E] > message, the symbolic descriptor for JMS-style selector parsing is > incorrectly defined within Broker-J -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8113) [Broker-J] Incorrect symbolic descriptor used for (JMS) selector
[ https://issues.apache.org/jira/browse/QPID-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400203#comment-16400203 ] Keith Wall commented on QPID-8113: -- I note that the definition for filter is [apache.org:selector-filter:string (0x468C:0x0004)|https://svn.apache.org/repos/asf/qpid/trunk/qpid/specs/apache-filters.xml#type-selector-filter] does not actually define an on the wire JMS selector but an AMQP 1.0 filter written in terms of AMQP 1.0 header names. I expect that this will be superseded by the work of AMQP TC. > [Broker-J] Incorrect symbolic descriptor used for (JMS) selector > > > Key: QPID-8113 > URL: https://issues.apache.org/jira/browse/QPID-8113 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Affects Versions: qpid-java-broker-7.0.2, qpid-java-broker-7.0.0, > qpid-java-broker-7.0.1 >Reporter: Rob Godfrey >Assignee: Rob Godfrey >Priority: Major > Fix For: qpid-java-broker-7.0.3 > > > As per > [this|http://mail-archives.apache.org/mod_mbox/qpid-users/201802.mbox/%3CCACsaS95BJjm8e09xZGEPkp_Wsq801sdLd0fVnR9Tqy-JwJWnhg%40mail.gmail.com%3E] > message, the symbolic descriptor for JMS-style selector parsing is > incorrectly defined within Broker-J -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (QPID-7541) [Java Broker] Close Consumers when a Queue is deleted
[ https://issues.apache.org/jira/browse/QPID-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400133#comment-16400133 ] Artyom Safronov edited comment on QPID-7541 at 3/15/18 9:53 AM: My application uses Proton-J library. was (Author: artyom82): I am using Proton-J library. > [Java Broker] Close Consumers when a Queue is deleted > - > > Key: QPID-7541 > URL: https://issues.apache.org/jira/browse/QPID-7541 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Lorenz Quack >Priority: Major > > Currently when a Queue is deleted the associated Consumers are not closed. > This is essentially a resource leak. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7541) [Java Broker] Close Consumers when a Queue is deleted
[ https://issues.apache.org/jira/browse/QPID-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400133#comment-16400133 ] Artyom Safronov commented on QPID-7541: --- I am using Proton-J library. > [Java Broker] Close Consumers when a Queue is deleted > - > > Key: QPID-7541 > URL: https://issues.apache.org/jira/browse/QPID-7541 > Project: Qpid > Issue Type: Bug > Components: Broker-J >Reporter: Lorenz Quack >Priority: Major > > Currently when a Queue is deleted the associated Consumers are not closed. > This is essentially a resource leak. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (QPID-8130) [Broker-J] IAE "Comparison method violates its general contract!" can be thrown whilst comparing log file details of file logger
[
https://issues.apache.org/jira/browse/QPID-8130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400089#comment-16400089
]
Keith Wall edited comment on QPID-8130 at 3/15/18 8:54 AM:
---
As we are on Java 8, we can use:
{noformat}
Comparator.comparingLong(LogFileDetails::getLastModified){noformat}
For the record, I checked elsewhere in the Broker-J code base and did not find
other occasions where the same mistake is made.
was (Author: k-wall):
As we are on Java 8, we can use:
{noformat}
Comparator.comparingLong(LogFileDetails::getLastModified){noformat}
> [Broker-J] IAE "Comparison method violates its general contract!" can be
> thrown whilst comparing log file details of file logger
>
>
> Key: QPID-8130
> URL: https://issues.apache.org/jira/browse/QPID-8130
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.2, qpid-java-6.0.8,
> qpid-java-broker-7.0.0, qpid-java-6.1.5, qpid-java-broker-7.0.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-6.1.6, qpid-java-broker-7.0.3
>
>
> IllegalArgumentException "Comparison method violates its general contract!"
> can be thrown whilst comparing log file details of BrokerFileLogger or
> ViortualHostFileLogger
> {noformat}
> 2018-03-14 13:06:57,951 DEBUG [qtp127624166-218]
> (o.a.q.s.m.p.s.r.RestServlet) - IllegalArgumentException processing request
> java.lang.IllegalArgumentException: Comparison method violates its general
> contract!
> at java.util.TimSort.mergeHi(TimSort.java:899)
> at java.util.TimSort.mergeAt(TimSort.java:516)
> at java.util.TimSort.mergeForceCollapse(TimSort.java:457)
> at java.util.TimSort.sort(TimSort.java:254)
> at java.util.Arrays.sort(Arrays.java:1512)
> at java.util.ArrayList.sort(ArrayList.java:1454)
> at java.util.Collections.sort(Collections.java:175)
> at
> org.apache.qpid.server.logging.logback.RolloverWatcher.getLogFileDetails(RolloverWatcher.java:130)
> at
> org.apache.qpid.server.logging.logback.BrokerFileLoggerImpl.getLogFiles(BrokerFileLoggerImpl.java:156)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.qpid.server.model.ConfiguredObjectMethodAttributeOrStatistic.getValue(ConfiguredObjectMethodAttributeOrStatistic.java:68)
> at
> org.apache.qpid.server.model.ConfiguredObjectMethodAttribute.getValue(ConfiguredObjectMethodAttribute.java:26)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.getAttribute(AbstractConfiguredObject.java:1856)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.incorporateAttributesIntoMap(ConfiguredObjectToMapConverter.java:86)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.convertObjectToMap(ConfiguredObjectToMapConverter.java:64)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.incorporateChildrenIntoMap(ConfiguredObjectToMapConverter.java:271)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.convertObjectToMap(ConfiguredObjectToMapConverter.java:69)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.doGet(RestServlet.java:247)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet.doGet(AbstractServlet.java:128)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.service(RestServlet.java:341)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:841)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1634)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter$1.run(AuthenticationCheckFilter.java:157)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter$1.run(AuthenticationCheckFilter.java:153)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
>
[jira] [Commented] (QPID-8130) [Broker-J] IAE "Comparison method violates its general contract!" can be thrown whilst comparing log file details of file logger
[
https://issues.apache.org/jira/browse/QPID-8130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400089#comment-16400089
]
Keith Wall commented on QPID-8130:
--
As we are on Java 8, we can use:
{noformat}
Comparator.comparingLong(LogFileDetails::getLastModified){noformat}
> [Broker-J] IAE "Comparison method violates its general contract!" can be
> thrown whilst comparing log file details of file logger
>
>
> Key: QPID-8130
> URL: https://issues.apache.org/jira/browse/QPID-8130
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.2, qpid-java-6.0.8,
> qpid-java-broker-7.0.0, qpid-java-6.1.5, qpid-java-broker-7.0.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-6.1.6, qpid-java-broker-7.0.3
>
>
> IllegalArgumentException "Comparison method violates its general contract!"
> can be thrown whilst comparing log file details of BrokerFileLogger or
> ViortualHostFileLogger
> {noformat}
> 2018-03-14 13:06:57,951 DEBUG [qtp127624166-218]
> (o.a.q.s.m.p.s.r.RestServlet) - IllegalArgumentException processing request
> java.lang.IllegalArgumentException: Comparison method violates its general
> contract!
> at java.util.TimSort.mergeHi(TimSort.java:899)
> at java.util.TimSort.mergeAt(TimSort.java:516)
> at java.util.TimSort.mergeForceCollapse(TimSort.java:457)
> at java.util.TimSort.sort(TimSort.java:254)
> at java.util.Arrays.sort(Arrays.java:1512)
> at java.util.ArrayList.sort(ArrayList.java:1454)
> at java.util.Collections.sort(Collections.java:175)
> at
> org.apache.qpid.server.logging.logback.RolloverWatcher.getLogFileDetails(RolloverWatcher.java:130)
> at
> org.apache.qpid.server.logging.logback.BrokerFileLoggerImpl.getLogFiles(BrokerFileLoggerImpl.java:156)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.qpid.server.model.ConfiguredObjectMethodAttributeOrStatistic.getValue(ConfiguredObjectMethodAttributeOrStatistic.java:68)
> at
> org.apache.qpid.server.model.ConfiguredObjectMethodAttribute.getValue(ConfiguredObjectMethodAttribute.java:26)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.getAttribute(AbstractConfiguredObject.java:1856)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.incorporateAttributesIntoMap(ConfiguredObjectToMapConverter.java:86)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.convertObjectToMap(ConfiguredObjectToMapConverter.java:64)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.incorporateChildrenIntoMap(ConfiguredObjectToMapConverter.java:271)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.convertObjectToMap(ConfiguredObjectToMapConverter.java:69)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.doGet(RestServlet.java:247)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet.doGet(AbstractServlet.java:128)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.service(RestServlet.java:341)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:841)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1634)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter$1.run(AuthenticationCheckFilter.java:157)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter$1.run(AuthenticationCheckFilter.java:153)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter.doFilterChainAs(AuthenticationCheckFilter.java:152)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter.doFilter(AuthenticationCheckFilter.java:122)
> at
>
[jira] [Updated] (QPID-8130) [Broker-J] IAE "Comparison method violates its general contract!" can be thrown whilst comparing log file details of file logger
[
https://issues.apache.org/jira/browse/QPID-8130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-8130:
-
Description:
IllegalArgumentException "Comparison method violates its general contract!" can
be thrown whilst comparing log file details of BrokerFileLogger or
ViortualHostFileLogger
{noformat}
2018-03-14 13:06:57,951 DEBUG [qtp127624166-218] (o.a.q.s.m.p.s.r.RestServlet)
- IllegalArgumentException processing request
java.lang.IllegalArgumentException: Comparison method violates its general
contract!
at java.util.TimSort.mergeHi(TimSort.java:899)
at java.util.TimSort.mergeAt(TimSort.java:516)
at java.util.TimSort.mergeForceCollapse(TimSort.java:457)
at java.util.TimSort.sort(TimSort.java:254)
at java.util.Arrays.sort(Arrays.java:1512)
at java.util.ArrayList.sort(ArrayList.java:1454)
at java.util.Collections.sort(Collections.java:175)
at
org.apache.qpid.server.logging.logback.RolloverWatcher.getLogFileDetails(RolloverWatcher.java:130)
at
org.apache.qpid.server.logging.logback.BrokerFileLoggerImpl.getLogFiles(BrokerFileLoggerImpl.java:156)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.apache.qpid.server.model.ConfiguredObjectMethodAttributeOrStatistic.getValue(ConfiguredObjectMethodAttributeOrStatistic.java:68)
at
org.apache.qpid.server.model.ConfiguredObjectMethodAttribute.getValue(ConfiguredObjectMethodAttribute.java:26)
at
org.apache.qpid.server.model.AbstractConfiguredObject.getAttribute(AbstractConfiguredObject.java:1856)
at
org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.incorporateAttributesIntoMap(ConfiguredObjectToMapConverter.java:86)
at
org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.convertObjectToMap(ConfiguredObjectToMapConverter.java:64)
at
org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.incorporateChildrenIntoMap(ConfiguredObjectToMapConverter.java:271)
at
org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.convertObjectToMap(ConfiguredObjectToMapConverter.java:69)
at
org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.doGet(RestServlet.java:247)
at
org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet.doGet(AbstractServlet.java:128)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
at
org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.service(RestServlet.java:341)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
at
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:841)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1634)
at
org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter$1.run(AuthenticationCheckFilter.java:157)
at
org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter$1.run(AuthenticationCheckFilter.java:153)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:422)
at
org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter.doFilterChainAs(AuthenticationCheckFilter.java:152)
at
org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter.doFilter(AuthenticationCheckFilter.java:122)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1621)
at
org.apache.qpid.server.management.plugin.filter.LoggingFilter.doFilter(LoggingFilter.java:63)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1621)
at
org.apache.qpid.server.management.plugin.filter.ForbiddingTraceFilter.doFilter(ForbiddingTraceFilter.java:65)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1621)
at
org.eclipse.jetty.servlets.CrossOriginFilter.handle(CrossOriginFilter.java:308)
at
org.eclipse.jetty.servlets.CrossOriginFilter.doFilter(CrossOriginFilter.java:262)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1621)
at
org.apache.qpid.server.management.plugin.filter.ExceptionHandlingFilter.doFilter(ExceptionHandlingFilter.java:59)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1621)
at
[jira] [Updated] (QPID-8130) [Broker-J] IAE "Comparison method violates its general contract!" can be thrown whilst comparing log file details of file logger
[
https://issues.apache.org/jira/browse/QPID-8130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-8130:
-
Issue Type: Bug (was: Improvement)
> [Broker-J] IAE "Comparison method violates its general contract!" can be
> thrown whilst comparing log file details of file logger
>
>
> Key: QPID-8130
> URL: https://issues.apache.org/jira/browse/QPID-8130
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.2, qpid-java-6.0.8,
> qpid-java-broker-7.0.0, qpid-java-6.1.5, qpid-java-broker-7.0.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-6.1.6, qpid-java-broker-7.0.3
>
>
> IllegalArgumentException "Comparison method violates its general contract!"
> can be thrown whilst comparing log file details of BrokerFileLogger or
> ViortualHostFileLogger
> {noformat}
> 2018-03-14 13:06:57,951 DEBUG [qtp127624166-218]
> (o.a.q.s.m.p.s.r.RestServlet) - IllegalArgumentException processing request
> java.lang.IllegalArgumentException: Comparison method violates its general
> contract!
> at java.util.TimSort.mergeHi(TimSort.java:899)
> at java.util.TimSort.mergeAt(TimSort.java:516)
> at java.util.TimSort.mergeForceCollapse(TimSort.java:457)
> at java.util.TimSort.sort(TimSort.java:254)
> at java.util.Arrays.sort(Arrays.java:1512)
> at java.util.ArrayList.sort(ArrayList.java:1454)
> at java.util.Collections.sort(Collections.java:175)
> at
> org.apache.qpid.server.logging.logback.RolloverWatcher.getLogFileDetails(RolloverWatcher.java:130)
> at
> org.apache.qpid.server.logging.logback.BrokerFileLoggerImpl.getLogFiles(BrokerFileLoggerImpl.java:156)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.qpid.server.model.ConfiguredObjectMethodAttributeOrStatistic.getValue(ConfiguredObjectMethodAttributeOrStatistic.java:68)
> at
> org.apache.qpid.server.model.ConfiguredObjectMethodAttribute.getValue(ConfiguredObjectMethodAttribute.java:26)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.getAttribute(AbstractConfiguredObject.java:1856)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.incorporateAttributesIntoMap(ConfiguredObjectToMapConverter.java:86)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.convertObjectToMap(ConfiguredObjectToMapConverter.java:64)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.incorporateChildrenIntoMap(ConfiguredObjectToMapConverter.java:271)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.convertObjectToMap(ConfiguredObjectToMapConverter.java:69)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.doGet(RestServlet.java:247)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet.doGet(AbstractServlet.java:128)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.service(RestServlet.java:341)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:841)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1634)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter$1.run(AuthenticationCheckFilter.java:157)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter$1.run(AuthenticationCheckFilter.java:153)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter.doFilterChainAs(AuthenticationCheckFilter.java:152)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter.doFilter(AuthenticationCheckFilter.java:122)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1621)
> at
> org.apache.qpid.server.management.plugin.filter.LoggingFilter.doFilter(LoggingFilter.java:63)
>
[jira] [Updated] (QPID-8130) [Broker-J] IAE "Comparison method violates its general contract!" can be thrown whilst comparing log file details of file logger
[
https://issues.apache.org/jira/browse/QPID-8130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated QPID-8130:
-
Priority: Minor (was: Major)
> [Broker-J] IAE "Comparison method violates its general contract!" can be
> thrown whilst comparing log file details of file logger
>
>
> Key: QPID-8130
> URL: https://issues.apache.org/jira/browse/QPID-8130
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.2, qpid-java-6.0.8,
> qpid-java-broker-7.0.0, qpid-java-6.1.5, qpid-java-broker-7.0.1
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-6.1.6, qpid-java-broker-7.0.3
>
>
> IllegalArgumentException "Comparison method violates its general contract!"
> can be thrown whilst comparing log file details of BrokerFileLogger or
> ViortualHostFileLogger
> {noformat}
> 2018-03-14 13:06:57,951 DEBUG [qtp127624166-218]
> (o.a.q.s.m.p.s.r.RestServlet) - IllegalArgumentException processing request
> java.lang.IllegalArgumentException: Comparison method violates its general
> contract!
> at java.util.TimSort.mergeHi(TimSort.java:899)
> at java.util.TimSort.mergeAt(TimSort.java:516)
> at java.util.TimSort.mergeForceCollapse(TimSort.java:457)
> at java.util.TimSort.sort(TimSort.java:254)
> at java.util.Arrays.sort(Arrays.java:1512)
> at java.util.ArrayList.sort(ArrayList.java:1454)
> at java.util.Collections.sort(Collections.java:175)
> at
> org.apache.qpid.server.logging.logback.RolloverWatcher.getLogFileDetails(RolloverWatcher.java:130)
> at
> org.apache.qpid.server.logging.logback.BrokerFileLoggerImpl.getLogFiles(BrokerFileLoggerImpl.java:156)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.qpid.server.model.ConfiguredObjectMethodAttributeOrStatistic.getValue(ConfiguredObjectMethodAttributeOrStatistic.java:68)
> at
> org.apache.qpid.server.model.ConfiguredObjectMethodAttribute.getValue(ConfiguredObjectMethodAttribute.java:26)
> at
> org.apache.qpid.server.model.AbstractConfiguredObject.getAttribute(AbstractConfiguredObject.java:1856)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.incorporateAttributesIntoMap(ConfiguredObjectToMapConverter.java:86)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.convertObjectToMap(ConfiguredObjectToMapConverter.java:64)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.incorporateChildrenIntoMap(ConfiguredObjectToMapConverter.java:271)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.ConfiguredObjectToMapConverter.convertObjectToMap(ConfiguredObjectToMapConverter.java:69)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.doGet(RestServlet.java:247)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.AbstractServlet.doGet(AbstractServlet.java:128)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
> at
> org.apache.qpid.server.management.plugin.servlet.rest.RestServlet.service(RestServlet.java:341)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:841)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1634)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter$1.run(AuthenticationCheckFilter.java:157)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter$1.run(AuthenticationCheckFilter.java:153)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter.doFilterChainAs(AuthenticationCheckFilter.java:152)
> at
> org.apache.qpid.server.management.plugin.filter.AuthenticationCheckFilter.doFilter(AuthenticationCheckFilter.java:122)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1621)
> at
> org.apache.qpid.server.management.plugin.filter.LoggingFilter.doFilter(LoggingFilter.java:63)
> at
