[jira] [Commented] (DISPATCH-1087) qdstat and qdmanage dont run on environments that have only python3
[ https://issues.apache.org/jira/browse/DISPATCH-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556149#comment-16556149 ] ASF GitHub Bot commented on DISPATCH-1087: -- Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/347 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/347?src=pr&el=h1) Report > Merging [#347](https://codecov.io/gh/apache/qpid-dispatch/pull/347?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/ef4776e28499c09f40bb2b4c3be99075bf547d2f?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/347?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #347 +/- ## == + Coverage84.3% 84.32% +0.01% == Files 69 69 Lines 1567215674 +2 == + Hits1321313217 +4 + Misses 2459 2457 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/347?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/347/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `87.44% <0%> (-0.19%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/347/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.65% <0%> (+0.14%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/347/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.71% <0%> (+0.15%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/347/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `99.26% <0%> (+0.36%)` | :arrow_up: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/347/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.79% <0%> (+0.57%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/347?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/347?src=pr&el=footer). Last update [ef4776e...30ff7ff](https://codecov.io/gh/apache/qpid-dispatch/pull/347?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > qdstat and qdmanage dont run on environments that have only python3 > --- > > Key: DISPATCH-1087 > URL: https://issues.apache.org/jira/browse/DISPATCH-1087 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tools >Affects Versions: 1.2.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.3.0 > > > Indtall qpid dispatch router from source on F28. > > Dont make python point to python3 > > Run qdstat or qdmamnage. > You will see that it is complaining that "python" is not available. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #347: DISPATCH-1087 - Modified shebang line in some file...
Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/347 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/347?src=pr&el=h1) Report > Merging [#347](https://codecov.io/gh/apache/qpid-dispatch/pull/347?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/ef4776e28499c09f40bb2b4c3be99075bf547d2f?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/347?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #347 +/- ## == + Coverage84.3% 84.32% +0.01% == Files 69 69 Lines 1567215674 +2 == + Hits1321313217 +4 + Misses 2459 2457 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/347?src=pr&el=tree) | Coverage Π| | |---|---|---| | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/347/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `87.44% <0%> (-0.19%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/347/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.65% <0%> (+0.14%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/347/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.71% <0%> (+0.15%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/347/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `99.26% <0%> (+0.36%)` | :arrow_up: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/347/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.79% <0%> (+0.57%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/347?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/347?src=pr&el=footer). Last update [ef4776e...30ff7ff](https://codecov.io/gh/apache/qpid-dispatch/pull/347?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1087) qdstat and qdmanage dont run on environments that have only python3
[ https://issues.apache.org/jira/browse/DISPATCH-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-1087. - Resolution: Fixed > qdstat and qdmanage dont run on environments that have only python3 > --- > > Key: DISPATCH-1087 > URL: https://issues.apache.org/jira/browse/DISPATCH-1087 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tools >Affects Versions: 1.2.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.3.0 > > > Indtall qpid dispatch router from source on F28. > > Dont make python point to python3 > > Run qdstat or qdmamnage. > You will see that it is complaining that "python" is not available. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1087) qdstat and qdmanage dont run on environments that have only python3
[ https://issues.apache.org/jira/browse/DISPATCH-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556143#comment-16556143 ] ASF GitHub Bot commented on DISPATCH-1087: -- Github user asfgit closed the pull request at: https://github.com/apache/qpid-dispatch/pull/347 > qdstat and qdmanage dont run on environments that have only python3 > --- > > Key: DISPATCH-1087 > URL: https://issues.apache.org/jira/browse/DISPATCH-1087 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tools >Affects Versions: 1.2.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.3.0 > > > Indtall qpid dispatch router from source on F28. > > Dont make python point to python3 > > Run qdstat or qdmamnage. > You will see that it is complaining that "python" is not available. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1087) qdstat and qdmanage dont run on environments that have only python3
[ https://issues.apache.org/jira/browse/DISPATCH-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556141#comment-16556141 ] ASF subversion and git services commented on DISPATCH-1087: --- Commit 30ff7ff1d54b8f280b36f76dc8c340cb4c88567b in qpid-dispatch's branch refs/heads/master from [~ganeshmurthy] [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=30ff7ff ] DISPATCH-1087 - Modified shebang line in some files to put in the correct version of Python > qdstat and qdmanage dont run on environments that have only python3 > --- > > Key: DISPATCH-1087 > URL: https://issues.apache.org/jira/browse/DISPATCH-1087 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tools >Affects Versions: 1.2.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.3.0 > > > Indtall qpid dispatch router from source on F28. > > Dont make python point to python3 > > Run qdstat or qdmamnage. > You will see that it is complaining that "python" is not available. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #347: DISPATCH-1087 - Modified shebang line in so...
Github user asfgit closed the pull request at: https://github.com/apache/qpid-dispatch/pull/347 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1087) qdstat and qdmanage dont run on environments that have only python3
[ https://issues.apache.org/jira/browse/DISPATCH-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556140#comment-16556140 ] ASF GitHub Bot commented on DISPATCH-1087: -- GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/347 DISPATCH-1087 - Modified shebang line in some files to put in the cor… …rect version of Python You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1087-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/347.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #347 commit 30ff7ff1d54b8f280b36f76dc8c340cb4c88567b Author: Ganesh Murthy Date: 2018-07-25T15:38:40Z DISPATCH-1087 - Modified shebang line in some files to put in the correct version of Python > qdstat and qdmanage dont run on environments that have only python3 > --- > > Key: DISPATCH-1087 > URL: https://issues.apache.org/jira/browse/DISPATCH-1087 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tools >Affects Versions: 1.2.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.3.0 > > > Indtall qpid dispatch router from source on F28. > > Dont make python point to python3 > > Run qdstat or qdmamnage. > You will see that it is complaining that "python" is not available. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #347: DISPATCH-1087 - Modified shebang line in so...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/347 DISPATCH-1087 - Modified shebang line in some files to put in the cor⦠â¦rect version of Python You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1087-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/347.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #347 commit 30ff7ff1d54b8f280b36f76dc8c340cb4c88567b Author: Ganesh Murthy Date: 2018-07-25T15:38:40Z DISPATCH-1087 - Modified shebang line in some files to put in the correct version of Python --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1087) qdstat and qdmanage dont run on environments that have only python3
[ https://issues.apache.org/jira/browse/DISPATCH-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556130#comment-16556130 ] ASF GitHub Bot commented on DISPATCH-1087: -- Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/346 > qdstat and qdmanage dont run on environments that have only python3 > --- > > Key: DISPATCH-1087 > URL: https://issues.apache.org/jira/browse/DISPATCH-1087 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tools >Affects Versions: 1.2.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.3.0 > > > Indtall qpid dispatch router from source on F28. > > Dont make python point to python3 > > Run qdstat or qdmamnage. > You will see that it is complaining that "python" is not available. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #346: DISPATCH-1087 - Modified shebang line in so...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/346 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1071) Switching between traffic visualizations sometimes shows both
[ https://issues.apache.org/jira/browse/DISPATCH-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1679#comment-1679 ] ASF subversion and git services commented on DISPATCH-1071: --- Commit ef4776e28499c09f40bb2b4c3be99075bf547d2f in qpid-dispatch's branch refs/heads/master from [~eallen] [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=ef4776e ] DISPATCH-1071 Correct use of 'this' in callback function. > Switching between traffic visualizations sometimes shows both > -- > > Key: DISPATCH-1071 > URL: https://issues.apache.org/jira/browse/DISPATCH-1071 > Project: Qpid Dispatch > Issue Type: Bug > Components: Console >Affects Versions: 1.2.0 >Reporter: Ernest Allen >Assignee: Ernest Allen >Priority: Major > Fix For: 1.3.0 > > > On the console topology page, when you switch between the two visualizations > (message path and link utilization) sometimes both visualizations are > displayed at the same time. > Only the selected visualization should be displayed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1087) qdstat and qdmanage dont run on environments that have only python3
[ https://issues.apache.org/jira/browse/DISPATCH-1087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555849#comment-16555849 ] ASF GitHub Bot commented on DISPATCH-1087: -- GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/346 DISPATCH-1087 - Modified shebang line in some files to put in the cor… …rect version of Python You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1087 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/346.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #346 commit 82f3834cff17072ec5fef44fa1032cf72bd2ba54 Author: Ganesh Murthy Date: 2018-07-25T15:38:40Z DISPATCH-1087 - Modified shebang line in some files to put in the correct version of Python > qdstat and qdmanage dont run on environments that have only python3 > --- > > Key: DISPATCH-1087 > URL: https://issues.apache.org/jira/browse/DISPATCH-1087 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tools >Affects Versions: 1.2.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.3.0 > > > Indtall qpid dispatch router from source on F28. > > Dont make python point to python3 > > Run qdstat or qdmamnage. > You will see that it is complaining that "python" is not available. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #346: DISPATCH-1087 - Modified shebang line in so...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/346 DISPATCH-1087 - Modified shebang line in some files to put in the cor⦠â¦rect version of Python You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1087 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/346.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #346 commit 82f3834cff17072ec5fef44fa1032cf72bd2ba54 Author: Ganesh Murthy Date: 2018-07-25T15:38:40Z DISPATCH-1087 - Modified shebang line in some files to put in the correct version of Python --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1008) Router should preserve original connection information when attempting to make failover connections
[
https://issues.apache.org/jira/browse/DISPATCH-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555764#comment-16555764
]
ASF GitHub Bot commented on DISPATCH-1008:
--
Github user ganeshmurthy closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/341
> Router should preserve original connection information when attempting to
> make failover connections
> ---
>
> Key: DISPATCH-1008
> URL: https://issues.apache.org/jira/browse/DISPATCH-1008
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.2.0
>
> Attachments: broker-slave.xml, broker.xml, qdrouterd-failover.conf
>
>
> # Start artemis master and slave brokers and the router with the attached
> config files.
> # Notice that the router receives an open frame from the master broker with
> the following failover information
> #
> {noformat}
> 2018-05-22 22:11:11.830106 -0230 SERVER (trace) [1]:0 <- @open(16)
> [container-id="localhost", max-frame-size=4294967295, channel-max=65535,
> idle-time-out=3,
> offered-capabilities=@PN_SYMBOL[:"sole-connection-for-container",
> :"DELAYED_DELIVERY", :"SHARED-SUBS", :"ANONYMOUS-RELAY"],
> properties={:product="apache-activemq-artemis",
> :"failover-server-list"=[{:hostname="0.0.0.8", :scheme="amqp", :port=61617,
> :"network-host"="0.0.0.0"}]"}]{noformat}
>
> # Now, kill the master broker and notice that the router correctly fails
> over to the slave broker. But the slave broker does not provide any failover
> information in its open frame and hence the router erases its original master
> broker connection information
> # When the master broker is now restarted and the slave broker is killed,
> the router attempts to repeatedly connect only to the slave broker but never
> attempts a connection to the master broker.
> # If the router did not erase its failover list but preserved the original
> master connection information, it would have connected the master broker.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #341: DISPATCH-1008 - Back out previous change th...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/341 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1088) Add OpenTracing support
Carsten Lohmann created DISPATCH-1088: - Summary: Add OpenTracing support Key: DISPATCH-1088 URL: https://issues.apache.org/jira/browse/DISPATCH-1088 Project: Qpid Dispatch Issue Type: New Feature Reporter: Carsten Lohmann In order to get an overview of the lifetime of a message going through different messaging components, it would be good to have support for distributed tracing in the dispatch router. The [OpenTracing|http://opentracing.io/] standard defines an API for this, facilitating the use of different (OpenTracing-compatible) tracing systems (e.g. [Jaeger|https://jaegertracing.io/]). This will mean identifying the different steps of the message processing inside the router and creating/finishing corresponding (child-)_Span_s for it (see [OpenTracing semantic spec|https://github.com/opentracing/specification/blob/master/specification.md]). As for the implementation, there is an [OpenTracing API for C++|https://github.com/opentracing/opentracing-cpp]. Some more pointers: - [Example for loading the tracer library dynamically|https://github.com/opentracing/opentracing-cpp/blob/master/example/dynamic_load/dynamic_load-example.cpp] (corresponding [PR|https://github.com/opentracing/opentracing-cpp/pull/45]) This approach is supported by Jaeger now as well. - [Jaeger C++ OpenTracing binding|https://github.com/jaegertracing/jaeger-client-cpp] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
