[jira] [Commented] (QPIDJMS-388) Unhandled RuntimeException in MessageListener#onMessage does not increment AMQP delivery count in AUTO_ACK
[ https://issues.apache.org/jira/browse/QPIDJMS-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578874#comment-16578874 ] Dan Langford commented on QPIDJMS-388: -- what is particularly interesting about this behavior is that if i use Spring-JMS and throw an exception from my method annotated with @JmsListener the account does increase. so Spring-JMS must be juggling the consumer, session, and or connection in a way that behaves a little more as expected. as a result our current work around for our users that are required certain compliant behavior around redeliveries is to use Spring-JMS. i have on my TODO list to determine what Spring-JMS is doing to get the desired behavior for our java clients who dont want to use Spring. > Unhandled RuntimeException in MessageListener#onMessage does not increment > AMQP delivery count in AUTO_ACK > -- > > Key: QPIDJMS-388 > URL: https://issues.apache.org/jira/browse/QPIDJMS-388 > Project: Qpid JMS > Issue Type: Bug > Components: qpid-jms-client >Affects Versions: 0.32.0 >Reporter: Johan Stenberg >Priority: Minor > Attachments: QpidJms388_RuntimeExectionInOnMessageTest.java > > > The JMS spec states: "The result of a listener throwing a RuntimeException > depends on the session's acknowledgment mode. AUTO_ACKNOWLEDGE or > DUPS_OK_ACKNOWLEDGE: the message will be immediately redelivered. ... The > 'JMSRedelivered' message header field will be set, and the > 'JMSXDeliveryCount' message property incremented, for a message redelivered > under these circumstances." > Currently qpid-jms however is not incrementing the deliveryCount or setting > the redelivered message header to true when a listener throws a > runtimeexception while in AUTO_ACK. > This results in "jms.redeliveryPolicy.maxRedeliveries" being ignored and > endless redelivery attempts. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1099) Add a timer facility for the core thread
[ https://issues.apache.org/jira/browse/DISPATCH-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578506#comment-16578506 ] ASF GitHub Bot commented on DISPATCH-1099: -- Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/362 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/362?src=pr=h1) Report > Merging [#362](https://codecov.io/gh/apache/qpid-dispatch/pull/362?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/788fe2a4ee4b28cd88b0dbd0c7e21979f08d25fb?src=pr=desc) will **decrease** coverage by `0.21%`. > The diff coverage is `22.64%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/362?src=pr=tree) ```diff @@Coverage Diff@@ ## master#362 +/- ## = - Coverage 84.52% 84.3% -0.22% = Files 69 70 +1 Lines 15730 15784 +54 = + Hits13295 13307 +12 - Misses 24352477 +42 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/362?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/362/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.52% <100%> (-0.13%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/362/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.66% <100%> (+0.09%)` | :arrow_up: | | [src/router\_core/core\_timer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/362/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfdGltZXIuYw==) | `8.88% <8.88%> (ø)` | | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/362/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==) | `88% <0%> (-0.2%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/362/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.54% <0%> (+0.11%)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/362/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `86.8% <0%> (+0.19%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/362?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/362?src=pr=footer). Last update [788fe2a...98156cb](https://codecov.io/gh/apache/qpid-dispatch/pull/362?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > Add a timer facility for the core thread > > > Key: DISPATCH-1099 > URL: https://issues.apache.org/jira/browse/DISPATCH-1099 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.2.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Currently there is qd_router_timer_handler() in router_node.c which schedules > a timer every second/ Extend this to send the timer action into core so core > can execute some periodic actions. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch issue #362: DISPATCH-1099 - Added core timer API
Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/362 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/362?src=pr=h1) Report > Merging [#362](https://codecov.io/gh/apache/qpid-dispatch/pull/362?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/788fe2a4ee4b28cd88b0dbd0c7e21979f08d25fb?src=pr=desc) will **decrease** coverage by `0.21%`. > The diff coverage is `22.64%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/362?src=pr=tree) ```diff @@Coverage Diff@@ ## master#362 +/- ## = - Coverage 84.52% 84.3% -0.22% = Files 69 70 +1 Lines 15730 15784 +54 = + Hits13295 13307 +12 - Misses 24352477 +42 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/362?src=pr=tree) | Coverage Π| | |---|---|---| | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/362/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.52% <100%> (-0.13%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/362/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.66% <100%> (+0.09%)` | :arrow_up: | | [src/router\_core/core\_timer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/362/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfdGltZXIuYw==) | `8.88% <8.88%> (ø)` | | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/362/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==) | `88% <0%> (-0.2%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/362/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.54% <0%> (+0.11%)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/362/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `86.8% <0%> (+0.19%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/362?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Π= absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/362?src=pr=footer). Last update [788fe2a...98156cb](https://codecov.io/gh/apache/qpid-dispatch/pull/362?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-1103) auto-links should retry after detach
Ganesh Murthy created DISPATCH-1103: --- Summary: auto-links should retry after detach Key: DISPATCH-1103 URL: https://issues.apache.org/jira/browse/DISPATCH-1103 Project: Qpid Dispatch Issue Type: Improvement Components: Container Affects Versions: 1.3.0 Reporter: Ganesh Murthy Assignee: Ganesh Murthy When an auto-link is activated, it attempts to attach to a node on the remote container. If this attach fails, or succeeds and subsequently gets detached, the auto-link will remain in the failed state until it is later re-activated. Active auto-links that fail to attach or become detached should periodically attempt to reattach to the remote node. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1099) Add a timer facility for the core thread
[ https://issues.apache.org/jira/browse/DISPATCH-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578492#comment-16578492 ] ASF GitHub Bot commented on DISPATCH-1099: -- GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/362 DISPATCH-1099 - Added core timer API You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1099-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/362.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #362 commit 98156cb32eb7a2d5e40f0a898adc662e83669523 Author: Ganesh Murthy Date: 2018-08-13T15:46:52Z DISPATCH-1099 - Added core timer API > Add a timer facility for the core thread > > > Key: DISPATCH-1099 > URL: https://issues.apache.org/jira/browse/DISPATCH-1099 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.2.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Currently there is qd_router_timer_handler() in router_node.c which schedules > a timer every second/ Extend this to send the timer action into core so core > can execute some periodic actions. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #362: DISPATCH-1099 - Added core timer API
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/362 DISPATCH-1099 - Added core timer API You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1099-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/362.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #362 commit 98156cb32eb7a2d5e40f0a898adc662e83669523 Author: Ganesh Murthy Date: 2018-08-13T15:46:52Z DISPATCH-1099 - Added core timer API --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1099) Add a timer facility for the core thread
[ https://issues.apache.org/jira/browse/DISPATCH-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578255#comment-16578255 ] ASF GitHub Bot commented on DISPATCH-1099: -- Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/357 > Add a timer facility for the core thread > > > Key: DISPATCH-1099 > URL: https://issues.apache.org/jira/browse/DISPATCH-1099 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Container >Affects Versions: 1.2.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Currently there is qd_router_timer_handler() in router_node.c which schedules > a timer every second/ Extend this to send the timer action into core so core > can execute some periodic actions. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #357: DISPATCH-1099 - Added plumbing that sends t...
Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/357 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-8228) [JMS AMQP 0-x] Release Qpid JMS AMQP 0-x 6.3.3
Alex Rudyy created QPID-8228: Summary: [JMS AMQP 0-x] Release Qpid JMS AMQP 0-x 6.3.3 Key: QPID-8228 URL: https://issues.apache.org/jira/browse/QPID-8228 Project: Qpid Issue Type: Task Components: JMS AMQP 0-x Reporter: Alex Rudyy Fix For: qpid-java-client-0-x-6.3.3 Release Qpid JMS AMQP 0-x client following instructions [here|https://cwiki.apache.org/confluence/display/qpid/Releasing+Qpid+JMS+AMQP+0-x] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
