[jira] [Resolved] (QPID-8233) [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet active should use connection-forced error

2018-09-10 Thread Keith Wall (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall resolved QPID-8233.
--
Resolution: Fixed

> [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet 
> active should use connection-forced error
> ---
>
> Key: QPID-8233
> URL: https://issues.apache.org/jira/browse/QPID-8233
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.3, qpid-java-broker-7.0.2, 
> qpid-java-broker-7.0.0, qpid-java-broker-7.0.1, qpid-java-broker-7.0.4, 
> qpid-java-broker-7.0.5, qpid-java-broker-7.0.6
>Reporter: Rob Godfrey
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
> Attachments: QPID-8233.diff, apache-qpid-broker-j-7.0.3-bin.zip
>
>
> Currently if a connection is made to a broker where a virtual host is in the 
> process of activating, the client received a "not-found" error with a 
> description "virtual host is not active".  A client receiving this would not 
> expect that simply retrying is likely to lead to success.
> Instead of sending "not-found" the broker should send "connection-forced" 
> which, while still inaccurate, at least indicates that the client should retry



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8233) [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet active should use connection-forced error

2018-09-10 Thread Keith Wall (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609815#comment-16609815
 ] 

Keith Wall commented on QPID-8233:
--

Looks reasonable to me.

> [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet 
> active should use connection-forced error
> ---
>
> Key: QPID-8233
> URL: https://issues.apache.org/jira/browse/QPID-8233
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.3, qpid-java-broker-7.0.2, 
> qpid-java-broker-7.0.0, qpid-java-broker-7.0.1, qpid-java-broker-7.0.4, 
> qpid-java-broker-7.0.5, qpid-java-broker-7.0.6
>Reporter: Rob Godfrey
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
> Attachments: QPID-8233.diff, apache-qpid-broker-j-7.0.3-bin.zip
>
>
> Currently if a connection is made to a broker where a virtual host is in the 
> process of activating, the client received a "not-found" error with a 
> description "virtual host is not active".  A client receiving this would not 
> expect that simply retrying is likely to lead to success.
> Instead of sending "not-found" the broker should send "connection-forced" 
> which, while still inaccurate, at least indicates that the client should retry



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (QPID-8231) [Broker-J] [AMQP 0-8...0-9-1] Broker crashes on delivery of messages from queue having attribute 'messageGroupKeyOverride' set to an empty string

2018-09-10 Thread Keith Wall (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Wall resolved QPID-8231.
--
Resolution: Fixed

> [Broker-J] [AMQP 0-8...0-9-1] Broker crashes on delivery of messages from 
> queue having attribute 'messageGroupKeyOverride' set to an empty string
> -
>
> Key: QPID-8231
> URL: https://issues.apache.org/jira/browse/QPID-8231
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.1.6, 0.32, qpid-java-6.0.8, 
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
>
> Broker crashes on consumption of messages from queue having attribute 
> 'messageGroupKeyOverride' set to an empty string. The following stack trace 
> is generated:
> {noformat}
> 
> #
> # Unhandled Exception java.lang.IllegalArgumentException: Property name must 
> not be the empty string in Thread IO-/127.0.0.1:63421
> #
> # Exiting
> #
> 
> java.lang.IllegalArgumentException: Property name must not be the empty string
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.checkPropertyName(FieldTable.java:787)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.getProperty(FieldTable.java:98)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.getObject(FieldTable.java:428)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.get(FieldTable.java:1055)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.get(FieldTable.java:1050)
>   at 
> org.apache.qpid.server.protocol.v0_8.MessageMetaData$MessageHeaderAdapter.getHeader(MessageMetaData.java:283)
>   at 
> org.apache.qpid.server.queue.AssignedConsumerMessageGroupManager.getGroupValue(AssignedConsumerMessageGroupManager.java:83)
>   at 
> org.apache.qpid.server.queue.AssignedConsumerMessageGroupManager.mightAssign(AssignedConsumerMessageGroupManager.java:61)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.mightAssign(AbstractQueue.java:1335)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.getNextAvailableEntry(AbstractQueue.java:2087)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.consumerHasAvailableMessages(AbstractQueue.java:2234)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.notifyConsumer(AbstractQueue.java:2268)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.setNotifyWorkDesired(AbstractQueue.java:2245)
>   at 
> org.apache.qpid.server.queue.QueueConsumerImpl.setNotifyWorkDesired(QueueConsumerImpl.java:356)
>   at 
> org.apache.qpid.server.consumer.AbstractConsumerTarget.setNotifyWorkDesired(AbstractConsumerTarget.java:130)
>   at 
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.updateNotifyWorkDesired(ConsumerTarget_0_8.java:320)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.updateAllConsumerNotifyWorkDesired(AMQChannel.java:1495)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.receiveChannelFlow(AMQChannel.java:2319)
>   at 
> org.apache.qpid.server.protocol.v0_8.transport.ChannelFlowBody.process(ChannelFlowBody.java:98)
>   at 
> org.apache.qpid.server.protocol.v0_8.ServerDecoder.processMethod(ServerDecoder.java:126)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.processFrame(AMQDecoder.java:203)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.doProcessFrame(BrokerDecoder.java:141)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.processFrame(BrokerDecoder.java:65)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.processInput(AMQDecoder.java:185)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder$1.run(BrokerDecoder.java:104)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder$1.run(BrokerDecoder.java:97)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.processAMQPFrames(BrokerDecoder.java:96)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.decode(AMQDecoder.java:118)
>   at 
> org.apache.qpid.server.protocol.v0_8.ServerDecoder.decodeBuffer(ServerDecoder.java:44)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$1.run(AMQPConnection_0_8Impl.java:257)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$1.run(AMQPConnection_0_8Impl.java:249)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at 
> 

[jira] [Commented] (QPID-8231) [Broker-J] [AMQP 0-8...0-9-1] Broker crashes on delivery of messages from queue having attribute 'messageGroupKeyOverride' set to an empty string

2018-09-10 Thread Keith Wall (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609806#comment-16609806
 ] 

Keith Wall commented on QPID-8231:
--

Looks reasonable to me.

> [Broker-J] [AMQP 0-8...0-9-1] Broker crashes on delivery of messages from 
> queue having attribute 'messageGroupKeyOverride' set to an empty string
> -
>
> Key: QPID-8231
> URL: https://issues.apache.org/jira/browse/QPID-8231
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.1.6, 0.32, qpid-java-6.0.8, 
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
>
> Broker crashes on consumption of messages from queue having attribute 
> 'messageGroupKeyOverride' set to an empty string. The following stack trace 
> is generated:
> {noformat}
> 
> #
> # Unhandled Exception java.lang.IllegalArgumentException: Property name must 
> not be the empty string in Thread IO-/127.0.0.1:63421
> #
> # Exiting
> #
> 
> java.lang.IllegalArgumentException: Property name must not be the empty string
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.checkPropertyName(FieldTable.java:787)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.getProperty(FieldTable.java:98)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.getObject(FieldTable.java:428)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.get(FieldTable.java:1055)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.get(FieldTable.java:1050)
>   at 
> org.apache.qpid.server.protocol.v0_8.MessageMetaData$MessageHeaderAdapter.getHeader(MessageMetaData.java:283)
>   at 
> org.apache.qpid.server.queue.AssignedConsumerMessageGroupManager.getGroupValue(AssignedConsumerMessageGroupManager.java:83)
>   at 
> org.apache.qpid.server.queue.AssignedConsumerMessageGroupManager.mightAssign(AssignedConsumerMessageGroupManager.java:61)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.mightAssign(AbstractQueue.java:1335)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.getNextAvailableEntry(AbstractQueue.java:2087)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.consumerHasAvailableMessages(AbstractQueue.java:2234)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.notifyConsumer(AbstractQueue.java:2268)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.setNotifyWorkDesired(AbstractQueue.java:2245)
>   at 
> org.apache.qpid.server.queue.QueueConsumerImpl.setNotifyWorkDesired(QueueConsumerImpl.java:356)
>   at 
> org.apache.qpid.server.consumer.AbstractConsumerTarget.setNotifyWorkDesired(AbstractConsumerTarget.java:130)
>   at 
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.updateNotifyWorkDesired(ConsumerTarget_0_8.java:320)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.updateAllConsumerNotifyWorkDesired(AMQChannel.java:1495)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.receiveChannelFlow(AMQChannel.java:2319)
>   at 
> org.apache.qpid.server.protocol.v0_8.transport.ChannelFlowBody.process(ChannelFlowBody.java:98)
>   at 
> org.apache.qpid.server.protocol.v0_8.ServerDecoder.processMethod(ServerDecoder.java:126)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.processFrame(AMQDecoder.java:203)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.doProcessFrame(BrokerDecoder.java:141)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.processFrame(BrokerDecoder.java:65)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.processInput(AMQDecoder.java:185)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder$1.run(BrokerDecoder.java:104)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder$1.run(BrokerDecoder.java:97)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.processAMQPFrames(BrokerDecoder.java:96)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.decode(AMQDecoder.java:118)
>   at 
> org.apache.qpid.server.protocol.v0_8.ServerDecoder.decodeBuffer(ServerDecoder.java:44)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$1.run(AMQPConnection_0_8Impl.java:257)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$1.run(AMQPConnection_0_8Impl.java:249)
>   at java.security.AccessController.doPrivileged(Native Method)
>   

[jira] [Assigned] (DISPATCH-1109) use serving host and port as defaults for connect screen in console served by router

2018-09-10 Thread Ted Ross (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross reassigned DISPATCH-1109:
--

Assignee: Ted Ross

> use serving host and port as defaults for connect screen in console served by 
> router
> 
>
> Key: DISPATCH-1109
> URL: https://issues.apache.org/jira/browse/DISPATCH-1109
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Console
>Reporter: Gordon Sim
>Assignee: Ted Ross
>Priority: Major
>
> If you have a router serving up the console, and you have authentication 
> enabled, then when you go to the url to retrieve the console it loads up the 
> connect screen (because it can't connect without username and password). 
> However the connection defaults to localhost:5673. It would be much nicer if 
> it could default to the host/port from which the console was itself loaded.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1862) Idle timeout not working on Linux

2018-09-10 Thread Zafar (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609790#comment-16609790
 ] 

Zafar commented on PROTON-1862:
---

Great, thanks.
Regards,

> Idle timeout not working on Linux
> -
>
> Key: PROTON-1862
> URL: https://issues.apache.org/jira/browse/PROTON-1862
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: proton-c-0.22.0
>Reporter: Jeremy
>Priority: Critical
>  Labels: reproducer
> Attachments: proton_1862_tests.txt, test_case.cpp
>
>
> We faced an issue with the idle timeout on linux. On windows, it seems to 
> work.
> In our proton feature test suite, we test the idle timeout feature by doing a 
> sleep in the method on_session_open.
> This should trigger a connection timeout. It works on windows, and it used to 
> work with proton v0.16.0 on windows and linux.
> Removing the sleep from the on_session_open and putting it in 
> on_connection_open, yields the same result.
> See attached file to reproduce.
> Machines:
>  * Windows machine
>  ** OS: Windows 7
>  ** Compiler: MSVC 2013 Version 12 Update 5
>  * Linux machine
>  ** OS: Red Hat Enterprise Linux Server release 6.4 (Santiago)
>  ** Compiler: g++491 (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1107) Need info for logs to help disambiguate router connections

2018-09-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609767#comment-16609767
 ] 

ASF subversion and git services commented on DISPATCH-1107:
---

Commit df7667e8a9fa2ad6a2dd2ca91fe6f4a45b4d4f3c in qpid-dispatch's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=df7667e ]

DISPATCH-1107: Add router connection id interrouter Opens

This feature helps disambiguate interrouter connections.
Topology tests generate many connections and resulting logs have the
connection ids. There is nothing topology-specific about this feature.


> Need info for logs to help disambiguate router connections
> --
>
> Key: DISPATCH-1107
> URL: https://issues.apache.org/jira/browse/DISPATCH-1107
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Router Node
>Affects Versions: 1.3.0
>Reporter: Chuck Rolke
>Priority: Major
> Fix For: 1.4.0
>
>
> When connections are started by routers to other routers there is no reliable 
> way in the log files for telling the connections apart. Consider a pair of 
> routers where router A creates two connections and sends two Opens to router 
> B. A's log will show that connections [5] and [7] sent the Opens and B's log 
> will show that connections [4] and [6] received and replied to the Opens. But 
> there is no way to know if the connection pairs are '[A-5][B-4] and 
> [A-7][B-6]' or '[A-5][B-6] and [A-7][B-4]'.
> A simple solution to expose this relationship is for the routers to embed the 
> _connid_ in the Open properties. Then the connection relationships between 
> the two routers could be resolved from either router log file.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (PROTON-1929) [c] library prints directly to stderr/stdout

2018-09-10 Thread Alan Conway (JIRA)


 [ 
https://issues.apache.org/jira/browse/PROTON-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway resolved PROTON-1929.
-
Resolution: Fixed

> [c] library prints directly to stderr/stdout
> 
>
> Key: PROTON-1929
> URL: https://issues.apache.org/jira/browse/PROTON-1929
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: proton-c-0.25.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
> Fix For: proton-c-0.26.0
>
>
> The proton-c library sometimes prints directly to stderr/stdout.
> It should use the configured pn_logger for all logging output (which defaults 
> to stderr but can be redirected by the appliction)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (PROTON-1930) [cpp] Fix race condition in container_test.cpp

2018-09-10 Thread Alan Conway (JIRA)


 [ 
https://issues.apache.org/jira/browse/PROTON-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Conway resolved PROTON-1930.
-
Resolution: Fixed

> [cpp] Fix race condition in container_test.cpp
> --
>
> Key: PROTON-1930
> URL: https://issues.apache.org/jira/browse/PROTON-1930
> Project: Qpid Proton
>  Issue Type: Test
>  Components: cpp-binding
>Affects Versions: proton-c-0.25.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
> Fix For: proton-c-0.26.0
>
>
> Sporadic test failures in container_test.cpp  test_mt_stop, test crashes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1929) [c] library prints directly to stderr/stdout

2018-09-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609751#comment-16609751
 ] 

ASF subversion and git services commented on PROTON-1929:
-

Commit 6c765bc66461c17b02ce740804f4d9e171f0fe24 in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=6c765bc ]

PROTON-1929: [c] library prints directly to stderr/stdout

Replace direct use of stdout with pn_log calls.


> [c] library prints directly to stderr/stdout
> 
>
> Key: PROTON-1929
> URL: https://issues.apache.org/jira/browse/PROTON-1929
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: proton-c-0.25.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
> Fix For: proton-c-0.26.0
>
>
> The proton-c library sometimes prints directly to stderr/stdout.
> It should use the configured pn_logger for all logging output (which defaults 
> to stderr but can be redirected by the appliction)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1798) Installable tests for proton

2018-09-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609749#comment-16609749
 ] 

ASF subversion and git services commented on PROTON-1798:
-

Commit 27edd9aca3b2b1078089ceaa2a387f0016ac6f0a in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=27edd9a ]

PROTON-1798: cmake runtime-check improvements

Usage notes:
- new CMake variable: RUNTIME_CHECK, choose from [memcheck helgrind asan tsan 
OFF]
- defaults to 'memcheck' if available, else OFF
- old ENABLE_ variables for valgrind/sanitizers are deprecated
- example_test scripts check for stderr output including from killed processes

Implementation details:

- moved all runtime-check setup code to seprate runtime-check.cmake
- tool-agnostic internal CMake variables for running tests
- removed all valgrind-specific code outside of runtime-check.cmake
- example_test.py check stderr as well as exit status to catch broker issues.

NOTE: asan,tsan not yet working for python/ruby bindings, they are disabled in
san builds. See tests/preload_asan.sh for current status of the work.

NOTE: Some python soak tests for obscure messenger features were removed, they
have faulty start-up timing logic and can fail under valgrind. We can restore
them if needed but we'll need to fix the -X feature of msgr-recv to report ready
only after connections are remote open.


> Installable tests for proton
> 
>
> Key: PROTON-1798
> URL: https://issues.apache.org/jira/browse/PROTON-1798
> Project: Qpid Proton
>  Issue Type: Test
>Affects Versions: proton-c-0.21.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
>  Labels: testing
> Fix For: proton-c-0.26.0
>
>
> Install test scripts so that self-tests can be run on an installed package, 
> without access to the source tree. These tests will be a separate install 
> group.
>  
> Initially the tests will consist of automatically building and running 
> installed examples, in future we can add unit tests etc. to the installed set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1798) Installable tests for proton

2018-09-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609746#comment-16609746
 ] 

ASF subversion and git services commented on PROTON-1798:
-

Commit c6db635838f0abb67eb37bf565d4072870e1fe9d in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=c6db635 ]

PROTON-1798: [c] Fix benign race in broker.c example found by tsan


> Installable tests for proton
> 
>
> Key: PROTON-1798
> URL: https://issues.apache.org/jira/browse/PROTON-1798
> Project: Qpid Proton
>  Issue Type: Test
>Affects Versions: proton-c-0.21.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
>  Labels: testing
> Fix For: proton-c-0.26.0
>
>
> Install test scripts so that self-tests can be run on an installed package, 
> without access to the source tree. These tests will be a separate install 
> group.
>  
> Initially the tests will consist of automatically building and running 
> installed examples, in future we can add unit tests etc. to the installed set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1798) Installable tests for proton

2018-09-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609748#comment-16609748
 ] 

ASF subversion and git services commented on PROTON-1798:
-

Commit 7885bd3b558dcf801e92ea866090d1110cc36aa1 in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=7885bd3 ]

PROTON-1798: [cpp] add library destructors for main classes

Add library destructors to anchor vtables and typeinfo for connection, session,
sender, recever and delivery.

Without them, the ubsan sanitizer reports mismatched types due to different
weak vtable symbols in scope at library and executable link time.


> Installable tests for proton
> 
>
> Key: PROTON-1798
> URL: https://issues.apache.org/jira/browse/PROTON-1798
> Project: Qpid Proton
>  Issue Type: Test
>Affects Versions: proton-c-0.21.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
>  Labels: testing
> Fix For: proton-c-0.26.0
>
>
> Install test scripts so that self-tests can be run on an installed package, 
> without access to the source tree. These tests will be a separate install 
> group.
>  
> Initially the tests will consist of automatically building and running 
> installed examples, in future we can add unit tests etc. to the installed set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1798) Installable tests for proton

2018-09-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609747#comment-16609747
 ] 

ASF subversion and git services commented on PROTON-1798:
-

Commit e5aac0083bb1cc2a6e96a361ff6031066e4dc449 in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=e5aac00 ]

PROTON-1798: [cpp] C++ broker example, remove unused shutdown code.


> Installable tests for proton
> 
>
> Key: PROTON-1798
> URL: https://issues.apache.org/jira/browse/PROTON-1798
> Project: Qpid Proton
>  Issue Type: Test
>Affects Versions: proton-c-0.21.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
>  Labels: testing
> Fix For: proton-c-0.26.0
>
>
> Install test scripts so that self-tests can be run on an installed package, 
> without access to the source tree. These tests will be a separate install 
> group.
>  
> Initially the tests will consist of automatically building and running 
> installed examples, in future we can add unit tests etc. to the installed set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1930) [cpp] Fix race condition in container_test.cpp

2018-09-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609750#comment-16609750
 ] 

ASF subversion and git services commented on PROTON-1930:
-

Commit d3c113548146b56cdd8b2a31c2d4dd7ba5dddbfd in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=d3c1135 ]

PROTON-1930: [cpp] Fix race condition in container_test.cpp

Test was starting container, opening connection and then checking for
["start", "open"] sequence to be set by handlers.

Sometimes the sequence was instead ["open", "start"], which is legal since the
events are generated in different handler contexts.

Fixed by starting container, waiting for "start", opening connection, then
waiting for "open"


> [cpp] Fix race condition in container_test.cpp
> --
>
> Key: PROTON-1930
> URL: https://issues.apache.org/jira/browse/PROTON-1930
> Project: Qpid Proton
>  Issue Type: Test
>  Components: cpp-binding
>Affects Versions: proton-c-0.25.0
>Reporter: Alan Conway
>Assignee: Alan Conway
>Priority: Major
> Fix For: proton-c-0.26.0
>
>
> Sporadic test failures in container_test.cpp  test_mt_stop, test crashes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1118) Fix Valgrind errors in the tests

2018-09-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609714#comment-16609714
 ] 

ASF subversion and git services commented on DISPATCH-1118:
---

Commit 447937f374ec69802faf80fd4f0945f21076a287 in qpid-dispatch's branch 
refs/heads/master from [~tr...@redhat.com]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=447937f ]

DISPATCH-1118 - Code cleanup to remove valgrind errors.


> Fix Valgrind errors in the tests
> 
>
> Key: DISPATCH-1118
> URL: https://issues.apache.org/jira/browse/DISPATCH-1118
> Project: Qpid Dispatch
>  Issue Type: Bug
>Reporter: Ted Ross
>Assignee: Ted Ross
>Priority: Major
> Fix For: 1.4.0
>
>
> The following valgrind errors are being flagged while running the 
> system_tests_multi_tenancy tests:
> ==16718== Conditional jump or move depends on uninitialised value(s)
> ==16718== Conditional jump or move depends on uninitialised value(s)
> ==16718== Conditional jump or move depends on uninitialised value(s)
> ==16718== Conditional jump or move depends on uninitialised value(s)
> ==16718== Conditional jump or move depends on uninitialised value(s)
> ==16718== Conditional jump or move depends on uninitialised value(s)
> ==16718== Conditional jump or move depends on uninitialised value(s)
> ==16718== Syscall param write(buf) points to uninitialised byte(s)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-1118) Fix Valgrind errors in the tests

2018-09-10 Thread Ted Ross (JIRA)
Ted Ross created DISPATCH-1118:
--

 Summary: Fix Valgrind errors in the tests
 Key: DISPATCH-1118
 URL: https://issues.apache.org/jira/browse/DISPATCH-1118
 Project: Qpid Dispatch
  Issue Type: Bug
Reporter: Ted Ross
Assignee: Ted Ross
 Fix For: 1.4.0


The following valgrind errors are being flagged while running the 
system_tests_multi_tenancy tests:

==16718== Conditional jump or move depends on uninitialised value(s)
==16718== Conditional jump or move depends on uninitialised value(s)
==16718== Conditional jump or move depends on uninitialised value(s)
==16718== Conditional jump or move depends on uninitialised value(s)
==16718== Conditional jump or move depends on uninitialised value(s)
==16718== Conditional jump or move depends on uninitialised value(s)
==16718== Conditional jump or move depends on uninitialised value(s)
==16718== Syscall param write(buf) points to uninitialised byte(s)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (PROTON-1930) [cpp] Fix race condition in container_test.cpp

2018-09-10 Thread Alan Conway (JIRA)
Alan Conway created PROTON-1930:
---

 Summary: [cpp] Fix race condition in container_test.cpp
 Key: PROTON-1930
 URL: https://issues.apache.org/jira/browse/PROTON-1930
 Project: Qpid Proton
  Issue Type: Test
  Components: cpp-binding
Affects Versions: proton-c-0.25.0
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: proton-c-0.26.0


Sporadic test failures in container_test.cpp  test_mt_stop, test crashes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1096) support AMQP prioritized messages

2018-09-10 Thread Ted Ross (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609709#comment-16609709
 ] 

Ted Ross commented on DISPATCH-1096:


This issue can be resolved when the test is committed to master.

> support AMQP prioritized messages
> -
>
> Key: DISPATCH-1096
> URL: https://issues.apache.org/jira/browse/DISPATCH-1096
> Project: Qpid Dispatch
>  Issue Type: New Feature
>Reporter: michael goulish
>Assignee: michael goulish
>Priority: Major
> Fix For: 1.4.0
>
>
> Detect priority info from message header in the router code.
> Create separate inter-router links for the various priorities.
> Per connection (i.e. not globally across the router) service high-priority 
> inter-router links before low priority links.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (DISPATCH-1096) support AMQP prioritized messages

2018-09-10 Thread Ted Ross (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross updated DISPATCH-1096:
---
Fix Version/s: 1.4.0

> support AMQP prioritized messages
> -
>
> Key: DISPATCH-1096
> URL: https://issues.apache.org/jira/browse/DISPATCH-1096
> Project: Qpid Dispatch
>  Issue Type: New Feature
>Reporter: michael goulish
>Assignee: michael goulish
>Priority: Major
> Fix For: 1.4.0
>
>
> Detect priority info from message header in the router code.
> Create separate inter-router links for the various priorities.
> Per connection (i.e. not globally across the router) service high-priority 
> inter-router links before low priority links.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1096) support AMQP prioritized messages

2018-09-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609693#comment-16609693
 ] 

ASF GitHub Bot commented on DISPATCH-1096:
--

Github user mgoulish commented on the issue:

https://github.com/apache/qpid-dispatch/pull/374
  
Ted merged this.


> support AMQP prioritized messages
> -
>
> Key: DISPATCH-1096
> URL: https://issues.apache.org/jira/browse/DISPATCH-1096
> Project: Qpid Dispatch
>  Issue Type: New Feature
>Reporter: michael goulish
>Assignee: michael goulish
>Priority: Major
>
> Detect priority info from message header in the router code.
> Create separate inter-router links for the various priorities.
> Per connection (i.e. not globally across the router) service high-priority 
> inter-router links before low priority links.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1096) support AMQP prioritized messages

2018-09-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609694#comment-16609694
 ] 

ASF GitHub Bot commented on DISPATCH-1096:
--

Github user mgoulish closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/374


> support AMQP prioritized messages
> -
>
> Key: DISPATCH-1096
> URL: https://issues.apache.org/jira/browse/DISPATCH-1096
> Project: Qpid Dispatch
>  Issue Type: New Feature
>Reporter: michael goulish
>Assignee: michael goulish
>Priority: Major
>
> Detect priority info from message header in the router code.
> Create separate inter-router links for the various priorities.
> Per connection (i.e. not globally across the router) service high-priority 
> inter-router links before low priority links.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #374: DISPATCH-1096 - priority messaging support

2018-09-10 Thread mgoulish
Github user mgoulish commented on the issue:

https://github.com/apache/qpid-dispatch/pull/374
  
Ted merged this.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #374: DISPATCH-1096 - priority messaging support

2018-09-10 Thread mgoulish
Github user mgoulish closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/374


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #367: Priority 2

2018-09-10 Thread mgoulish
Github user mgoulish commented on the issue:

https://github.com/apache/qpid-dispatch/pull/367
  
superseded by PR 374


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #367: Priority 2

2018-09-10 Thread mgoulish
Github user mgoulish closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/367


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1096) support AMQP prioritized messages

2018-09-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609689#comment-16609689
 ] 

ASF subversion and git services commented on DISPATCH-1096:
---

Commit 710b7059b77a72337a25c79b1e4e01856ca484b7 in qpid-dispatch's branch 
refs/heads/master from Michael Goulish
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=710b705 ]

DISPATCH-1096 - priority messaging support


> support AMQP prioritized messages
> -
>
> Key: DISPATCH-1096
> URL: https://issues.apache.org/jira/browse/DISPATCH-1096
> Project: Qpid Dispatch
>  Issue Type: New Feature
>Reporter: michael goulish
>Assignee: michael goulish
>Priority: Major
>
> Detect priority info from message header in the router code.
> Create separate inter-router links for the various priorities.
> Per connection (i.e. not globally across the router) service high-priority 
> inter-router links before low priority links.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1090) Transfer/Disposition(state=release) loop forms when application disconnects abruptly from brokered queue until link credit is exhausted.

2018-09-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609587#comment-16609587
 ] 

ASF subversion and git services commented on DISPATCH-1090:
---

Commit 03ba19e6534a7779970c59c4c9fb2f9ee6e3a2c8 in qpid-dispatch's branch 
refs/heads/master from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=03ba19e ]

DISPATCH-1090 - Augmented drain test to reopen receiver and making sure the 
drained sender was re-issued credit this being  able to send to the receiver


> Transfer/Disposition(state=release) loop forms when application disconnects 
> abruptly from brokered queue until link credit is exhausted.
> 
>
> Key: DISPATCH-1090
> URL: https://issues.apache.org/jira/browse/DISPATCH-1090
> Project: Qpid Dispatch
>  Issue Type: Bug
> Environment: Version  1.3.0-SNAPSHOT
>  (30ff7ff1d54b8f280b36f76dc8c340cb4c88567b)
>Reporter: Keith Wall
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.4.0
>
> Attachments: DISPATCH-1090_dispatch_server.log
>
>
> I have configured a single Dispatch Router instance to route messages through 
> a broker queue (i.e. following section 7.2.5 of the 
> [docs|https://qpid.apache.org/releases/qpid-dispatch-1.2.0/user-guide/index.html#routing-messages-through-broker]).
> The application does the following:
> # Forms a sending links to the queue, sends a single message then disconnects.
> # Forms a receiving link to the same queue, receives the message without 
> settling then abruptly terminates the program.
> Inspecting the protocol trace, I see that after the Dispatch Router has sent 
> a {{Disposition state=modified}} for the message that was held by the 
> application when it terminated, a {{Transfer}}/{{Disposition state=release}} 
> loop forms between the Dispatch Router and Broker until the link credit is 
> exhausted.  
> Protocol trace attached to this issue demonstrates the problem.
> Dispatch Router was configured by the following commands:
> {noformat}
> qdmanage create --type org.apache.qpid.dispatch.connector host=oslo.local 
> port=5672 name=artemis-broker role=route-container
> qdmanage create --type org.apache.qpid.dispatch.router.config.autoLink 
> addr=queue direction=in connection=artemis-broker
> qdmanage create --type org.apache.qpid.dispatch.router.config.autoLink 
> addr=queue direction=out connection=artemis-broker
> qdmanage create --type=org.apache.qpid.dispatch.router.config.address 
> pattern=queue waypoint=true
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (PROTON-1929) [c] library prints directly to stderr/stdout

2018-09-10 Thread Alan Conway (JIRA)
Alan Conway created PROTON-1929:
---

 Summary: [c] library prints directly to stderr/stdout
 Key: PROTON-1929
 URL: https://issues.apache.org/jira/browse/PROTON-1929
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c
Affects Versions: proton-c-0.25.0
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: proton-c-0.26.0


The proton-c library sometimes prints directly to stderr/stdout.

It should use the configured pn_logger for all logging output (which defaults 
to stderr but can be redirected by the appliction)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1096) support AMQP prioritized messages

2018-09-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609429#comment-16609429
 ] 

ASF GitHub Bot commented on DISPATCH-1096:
--

GitHub user mgoulish opened a pull request:

https://github.com/apache/qpid-dispatch/pull/374

DISPATCH-1096 - priority messaging support

all the priority code in one commit...

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgoulish/qpid-dispatch priority-3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #374


commit 178085922c90934bd301762aa8d9bafada9b9134
Author: Michael Goulish 
Date:   2018-09-10T15:53:37Z

DISPATCH-1096 - priority messaging support




> support AMQP prioritized messages
> -
>
> Key: DISPATCH-1096
> URL: https://issues.apache.org/jira/browse/DISPATCH-1096
> Project: Qpid Dispatch
>  Issue Type: New Feature
>Reporter: michael goulish
>Assignee: michael goulish
>Priority: Major
>
> Detect priority info from message header in the router code.
> Create separate inter-router links for the various priorities.
> Per connection (i.e. not globally across the router) service high-priority 
> inter-router links before low priority links.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #374: DISPATCH-1096 - priority messaging support

2018-09-10 Thread mgoulish
GitHub user mgoulish opened a pull request:

https://github.com/apache/qpid-dispatch/pull/374

DISPATCH-1096 - priority messaging support

all the priority code in one commit...

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgoulish/qpid-dispatch priority-3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #374


commit 178085922c90934bd301762aa8d9bafada9b9134
Author: Michael Goulish 
Date:   2018-09-10T15:53:37Z

DISPATCH-1096 - priority messaging support




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1090) Transfer/Disposition(state=release) loop forms when application disconnects abruptly from brokered queue until link credit is exhausted.

2018-09-10 Thread Robbie Gemmell (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609311#comment-16609311
 ] 

Robbie Gemmell commented on DISPATCH-1090:
--

I may be misunderstanding, I don't know the router code, but reading the test 
it seems like the change operates only after a message arrives that is 
undeliverable? That could prevent a release->send loop forming until the credit 
is used in some cases, but it seems like in others it wouldn't be as effective 
as it could be?

There is obviously a race here in that even if the drain were performed 
immediately when the last receiver went away the sender might already have put 
lots of messages in flight using credit it had. However it seems a little odd 
potentially leaving the sender with that credit for an unknown amount of time 
until they use it to send something. In that regard, its just as likely a large 
number of small messages could end up being sent later if they become available 
at the sender and end up being sent+released.

One complication might be address-specific links vs anonymous sender links, 
though it isn't clear to me whether they are handled any different (again, 
don't know the router code). In some ways makes sense, stops them sending lots 
to the address, but in other ways could be questionable as the anonymous link 
then cant sent to other addresses either.

In any case, I'd perhaps say the tests could do with expanding to ensure credit 
is restored at the appropriate time and in the expected amount. Another useful 
case to test might be when a new receiver becomes available before the sender 
has completed draining after the original receivers went away. Distinct drain 
attempts cant really be correlated without allowing them to complete before 
then flowing more credit or attempting another drain, and failing to account 
for that might leave you thinking a link has credit when it doesnt.

> Transfer/Disposition(state=release) loop forms when application disconnects 
> abruptly from brokered queue until link credit is exhausted.
> 
>
> Key: DISPATCH-1090
> URL: https://issues.apache.org/jira/browse/DISPATCH-1090
> Project: Qpid Dispatch
>  Issue Type: Bug
> Environment: Version  1.3.0-SNAPSHOT
>  (30ff7ff1d54b8f280b36f76dc8c340cb4c88567b)
>Reporter: Keith Wall
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.4.0
>
> Attachments: DISPATCH-1090_dispatch_server.log
>
>
> I have configured a single Dispatch Router instance to route messages through 
> a broker queue (i.e. following section 7.2.5 of the 
> [docs|https://qpid.apache.org/releases/qpid-dispatch-1.2.0/user-guide/index.html#routing-messages-through-broker]).
> The application does the following:
> # Forms a sending links to the queue, sends a single message then disconnects.
> # Forms a receiving link to the same queue, receives the message without 
> settling then abruptly terminates the program.
> Inspecting the protocol trace, I see that after the Dispatch Router has sent 
> a {{Disposition state=modified}} for the message that was held by the 
> application when it terminated, a {{Transfer}}/{{Disposition state=release}} 
> loop forms between the Dispatch Router and Broker until the link credit is 
> exhausted.  
> Protocol trace attached to this issue demonstrates the problem.
> Dispatch Router was configured by the following commands:
> {noformat}
> qdmanage create --type org.apache.qpid.dispatch.connector host=oslo.local 
> port=5672 name=artemis-broker role=route-container
> qdmanage create --type org.apache.qpid.dispatch.router.config.autoLink 
> addr=queue direction=in connection=artemis-broker
> qdmanage create --type org.apache.qpid.dispatch.router.config.autoLink 
> addr=queue direction=out connection=artemis-broker
> qdmanage create --type=org.apache.qpid.dispatch.router.config.address 
> pattern=queue waypoint=true
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Resolved] (DISPATCH-1090) Transfer/Disposition(state=release) loop forms when application disconnects abruptly from brokered queue until link credit is exhausted.

2018-09-10 Thread Ganesh Murthy (JIRA)


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ganesh Murthy resolved DISPATCH-1090.
-
   Resolution: Fixed
Fix Version/s: (was: Backlog)
   1.4.0

> Transfer/Disposition(state=release) loop forms when application disconnects 
> abruptly from brokered queue until link credit is exhausted.
> 
>
> Key: DISPATCH-1090
> URL: https://issues.apache.org/jira/browse/DISPATCH-1090
> Project: Qpid Dispatch
>  Issue Type: Bug
> Environment: Version  1.3.0-SNAPSHOT
>  (30ff7ff1d54b8f280b36f76dc8c340cb4c88567b)
>Reporter: Keith Wall
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.4.0
>
> Attachments: DISPATCH-1090_dispatch_server.log
>
>
> I have configured a single Dispatch Router instance to route messages through 
> a broker queue (i.e. following section 7.2.5 of the 
> [docs|https://qpid.apache.org/releases/qpid-dispatch-1.2.0/user-guide/index.html#routing-messages-through-broker]).
> The application does the following:
> # Forms a sending links to the queue, sends a single message then disconnects.
> # Forms a receiving link to the same queue, receives the message without 
> settling then abruptly terminates the program.
> Inspecting the protocol trace, I see that after the Dispatch Router has sent 
> a {{Disposition state=modified}} for the message that was held by the 
> application when it terminated, a {{Transfer}}/{{Disposition state=release}} 
> loop forms between the Dispatch Router and Broker until the link credit is 
> exhausted.  
> Protocol trace attached to this issue demonstrates the problem.
> Dispatch Router was configured by the following commands:
> {noformat}
> qdmanage create --type org.apache.qpid.dispatch.connector host=oslo.local 
> port=5672 name=artemis-broker role=route-container
> qdmanage create --type org.apache.qpid.dispatch.router.config.autoLink 
> addr=queue direction=in connection=artemis-broker
> qdmanage create --type org.apache.qpid.dispatch.router.config.autoLink 
> addr=queue direction=out connection=artemis-broker
> qdmanage create --type=org.apache.qpid.dispatch.router.config.address 
> pattern=queue waypoint=true
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch pull request #371: DISPATCH-1090 - Draim excess credit if ther...

2018-09-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/371


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1090) Transfer/Disposition(state=release) loop forms when application disconnects abruptly from brokered queue until link credit is exhausted.

2018-09-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609230#comment-16609230
 ] 

ASF GitHub Bot commented on DISPATCH-1090:
--

Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/371


> Transfer/Disposition(state=release) loop forms when application disconnects 
> abruptly from brokered queue until link credit is exhausted.
> 
>
> Key: DISPATCH-1090
> URL: https://issues.apache.org/jira/browse/DISPATCH-1090
> Project: Qpid Dispatch
>  Issue Type: Bug
> Environment: Version  1.3.0-SNAPSHOT
>  (30ff7ff1d54b8f280b36f76dc8c340cb4c88567b)
>Reporter: Keith Wall
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: Backlog
>
> Attachments: DISPATCH-1090_dispatch_server.log
>
>
> I have configured a single Dispatch Router instance to route messages through 
> a broker queue (i.e. following section 7.2.5 of the 
> [docs|https://qpid.apache.org/releases/qpid-dispatch-1.2.0/user-guide/index.html#routing-messages-through-broker]).
> The application does the following:
> # Forms a sending links to the queue, sends a single message then disconnects.
> # Forms a receiving link to the same queue, receives the message without 
> settling then abruptly terminates the program.
> Inspecting the protocol trace, I see that after the Dispatch Router has sent 
> a {{Disposition state=modified}} for the message that was held by the 
> application when it terminated, a {{Transfer}}/{{Disposition state=release}} 
> loop forms between the Dispatch Router and Broker until the link credit is 
> exhausted.  
> Protocol trace attached to this issue demonstrates the problem.
> Dispatch Router was configured by the following commands:
> {noformat}
> qdmanage create --type org.apache.qpid.dispatch.connector host=oslo.local 
> port=5672 name=artemis-broker role=route-container
> qdmanage create --type org.apache.qpid.dispatch.router.config.autoLink 
> addr=queue direction=in connection=artemis-broker
> qdmanage create --type org.apache.qpid.dispatch.router.config.autoLink 
> addr=queue direction=out connection=artemis-broker
> qdmanage create --type=org.apache.qpid.dispatch.router.config.address 
> pattern=queue waypoint=true
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1090) Transfer/Disposition(state=release) loop forms when application disconnects abruptly from brokered queue until link credit is exhausted.

2018-09-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609217#comment-16609217
 ] 

ASF GitHub Bot commented on DISPATCH-1090:
--

Github user ganeshmurthy commented on the issue:

https://github.com/apache/qpid-dispatch/pull/371
  
Fixed "Draim" to "Drain". Thanks for testing.


> Transfer/Disposition(state=release) loop forms when application disconnects 
> abruptly from brokered queue until link credit is exhausted.
> 
>
> Key: DISPATCH-1090
> URL: https://issues.apache.org/jira/browse/DISPATCH-1090
> Project: Qpid Dispatch
>  Issue Type: Bug
> Environment: Version  1.3.0-SNAPSHOT
>  (30ff7ff1d54b8f280b36f76dc8c340cb4c88567b)
>Reporter: Keith Wall
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: Backlog
>
> Attachments: DISPATCH-1090_dispatch_server.log
>
>
> I have configured a single Dispatch Router instance to route messages through 
> a broker queue (i.e. following section 7.2.5 of the 
> [docs|https://qpid.apache.org/releases/qpid-dispatch-1.2.0/user-guide/index.html#routing-messages-through-broker]).
> The application does the following:
> # Forms a sending links to the queue, sends a single message then disconnects.
> # Forms a receiving link to the same queue, receives the message without 
> settling then abruptly terminates the program.
> Inspecting the protocol trace, I see that after the Dispatch Router has sent 
> a {{Disposition state=modified}} for the message that was held by the 
> application when it terminated, a {{Transfer}}/{{Disposition state=release}} 
> loop forms between the Dispatch Router and Broker until the link credit is 
> exhausted.  
> Protocol trace attached to this issue demonstrates the problem.
> Dispatch Router was configured by the following commands:
> {noformat}
> qdmanage create --type org.apache.qpid.dispatch.connector host=oslo.local 
> port=5672 name=artemis-broker role=route-container
> qdmanage create --type org.apache.qpid.dispatch.router.config.autoLink 
> addr=queue direction=in connection=artemis-broker
> qdmanage create --type org.apache.qpid.dispatch.router.config.autoLink 
> addr=queue direction=out connection=artemis-broker
> qdmanage create --type=org.apache.qpid.dispatch.router.config.address 
> pattern=queue waypoint=true
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #371: DISPATCH-1090 - Draim excess credit if there are n...

2018-09-10 Thread ganeshmurthy
Github user ganeshmurthy commented on the issue:

https://github.com/apache/qpid-dispatch/pull/371
  
Fixed "Draim" to "Drain". Thanks for testing.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (QPID-8233) [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet active should use connection-forced error

2018-09-10 Thread Alex Rudyy (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy reassigned QPID-8233:


Assignee: Alex Rudyy

> [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet 
> active should use connection-forced error
> ---
>
> Key: QPID-8233
> URL: https://issues.apache.org/jira/browse/QPID-8233
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.3, qpid-java-broker-7.0.2, 
> qpid-java-broker-7.0.0, qpid-java-broker-7.0.1, qpid-java-broker-7.0.4, 
> qpid-java-broker-7.0.5, qpid-java-broker-7.0.6
>Reporter: Rob Godfrey
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
> Attachments: QPID-8233.diff, apache-qpid-broker-j-7.0.3-bin.zip
>
>
> Currently if a connection is made to a broker where a virtual host is in the 
> process of activating, the client received a "not-found" error with a 
> description "virtual host is not active".  A client receiving this would not 
> expect that simply retrying is likely to lead to success.
> Instead of sending "not-found" the broker should send "connection-forced" 
> which, while still inaccurate, at least indicates that the client should retry



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-8233) [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet active should use connection-forced error

2018-09-10 Thread Alex Rudyy (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-8233:
-
Status: Reviewable  (was: In Progress)

> [Broker-J][AMQP 1.0] Failure on connecting to a virtual host which is not yet 
> active should use connection-forced error
> ---
>
> Key: QPID-8233
> URL: https://issues.apache.org/jira/browse/QPID-8233
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.3, qpid-java-broker-7.0.2, 
> qpid-java-broker-7.0.0, qpid-java-broker-7.0.1, qpid-java-broker-7.0.4, 
> qpid-java-broker-7.0.5, qpid-java-broker-7.0.6
>Reporter: Rob Godfrey
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
> Attachments: QPID-8233.diff, apache-qpid-broker-j-7.0.3-bin.zip
>
>
> Currently if a connection is made to a broker where a virtual host is in the 
> process of activating, the client received a "not-found" error with a 
> description "virtual host is not active".  A client receiving this would not 
> expect that simply retrying is likely to lead to success.
> Instead of sending "not-found" the broker should send "connection-forced" 
> which, while still inaccurate, at least indicates that the client should retry



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (QPID-8232) [Broker-J] Disabling logging using log level OFF is not respected by the logging framework

2018-09-10 Thread Alex Rudyy (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609089#comment-16609089
 ] 

Alex Rudyy commented on QPID-8232:
--

The committed change should resolve the issue, though, the logging performance 
might be impacted. The attached patch potentially can improve the logging 
performance.

> [Broker-J] Disabling logging using  log level OFF is not respected by the 
> logging framework
> ---
>
> Key: QPID-8232
> URL: https://issues.apache.org/jira/browse/QPID-8232
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
> Attachments: 
> 0003-QPID-8232-Broker-J-Optimise-logging-with-LoggerNameA.patch
>
>
> When two logging rules created where one rule allows logging  for the given 
> hierarchy and another rule disables specific logging for the logger from the 
> hierarchy declared in the first rule, the rule disabling the logging should 
> take precedence.
> For example, when the one rule allows 'info' logging for loggers matching 
> "qpid.message.*" and another rule is added to turn off logging of log event 
> from logger "qpid.message.exchange.discardmsg", the logs from logger 
> "qpid.message.exchange.discardmsg" should not be appended. The current 
> implementation allows logging from disabled loggers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-8232) [Broker-J] Disabling logging using log level OFF is not respected by the logging framework

2018-09-10 Thread Alex Rudyy (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-8232:
-
Attachment: 0003-QPID-8232-Broker-J-Optimise-logging-with-LoggerNameA.patch

> [Broker-J] Disabling logging using  log level OFF is not respected by the 
> logging framework
> ---
>
> Key: QPID-8232
> URL: https://issues.apache.org/jira/browse/QPID-8232
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
> Attachments: 
> 0003-QPID-8232-Broker-J-Optimise-logging-with-LoggerNameA.patch
>
>
> When two logging rules created where one rule allows logging  for the given 
> hierarchy and another rule disables specific logging for the logger from the 
> hierarchy declared in the first rule, the rule disabling the logging should 
> take precedence.
> For example, when the one rule allows 'info' logging for loggers matching 
> "qpid.message.*" and another rule is added to turn off logging of log event 
> from logger "qpid.message.exchange.discardmsg", the logs from logger 
> "qpid.message.exchange.discardmsg" should not be appended. The current 
> implementation allows logging from disabled loggers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-8232) [Broker-J] Disabling logging using log level OFF is not respected by the logging framework

2018-09-10 Thread Alex Rudyy (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-8232:
-
Status: Reviewable  (was: In Progress)

> [Broker-J] Disabling logging using  log level OFF is not respected by the 
> logging framework
> ---
>
> Key: QPID-8232
> URL: https://issues.apache.org/jira/browse/QPID-8232
> Project: Qpid
>  Issue Type: Improvement
>  Components: Broker-J
>Affects Versions: qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
>
> When two logging rules created where one rule allows logging  for the given 
> hierarchy and another rule disables specific logging for the logger from the 
> hierarchy declared in the first rule, the rule disabling the logging should 
> take precedence.
> For example, when the one rule allows 'info' logging for loggers matching 
> "qpid.message.*" and another rule is added to turn off logging of log event 
> from logger "qpid.message.exchange.discardmsg", the logs from logger 
> "qpid.message.exchange.discardmsg" should not be appended. The current 
> implementation allows logging from disabled loggers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-8231) [Broker-J] [AMQP 0-8...0-9-1] Broker crashes on delivery of messages from queue having attribute 'messageGroupKeyOverride' set to an empty string

2018-09-10 Thread Alex Rudyy (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-8231:
-
Status: Reviewable  (was: In Progress)

> [Broker-J] [AMQP 0-8...0-9-1] Broker crashes on delivery of messages from 
> queue having attribute 'messageGroupKeyOverride' set to an empty string
> -
>
> Key: QPID-8231
> URL: https://issues.apache.org/jira/browse/QPID-8231
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.1.6, 0.32, qpid-java-6.0.8, 
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
>
> Broker crashes on consumption of messages from queue having attribute 
> 'messageGroupKeyOverride' set to an empty string. The following stack trace 
> is generated:
> {noformat}
> 
> #
> # Unhandled Exception java.lang.IllegalArgumentException: Property name must 
> not be the empty string in Thread IO-/127.0.0.1:63421
> #
> # Exiting
> #
> 
> java.lang.IllegalArgumentException: Property name must not be the empty string
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.checkPropertyName(FieldTable.java:787)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.getProperty(FieldTable.java:98)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.getObject(FieldTable.java:428)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.get(FieldTable.java:1055)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.get(FieldTable.java:1050)
>   at 
> org.apache.qpid.server.protocol.v0_8.MessageMetaData$MessageHeaderAdapter.getHeader(MessageMetaData.java:283)
>   at 
> org.apache.qpid.server.queue.AssignedConsumerMessageGroupManager.getGroupValue(AssignedConsumerMessageGroupManager.java:83)
>   at 
> org.apache.qpid.server.queue.AssignedConsumerMessageGroupManager.mightAssign(AssignedConsumerMessageGroupManager.java:61)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.mightAssign(AbstractQueue.java:1335)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.getNextAvailableEntry(AbstractQueue.java:2087)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.consumerHasAvailableMessages(AbstractQueue.java:2234)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.notifyConsumer(AbstractQueue.java:2268)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.setNotifyWorkDesired(AbstractQueue.java:2245)
>   at 
> org.apache.qpid.server.queue.QueueConsumerImpl.setNotifyWorkDesired(QueueConsumerImpl.java:356)
>   at 
> org.apache.qpid.server.consumer.AbstractConsumerTarget.setNotifyWorkDesired(AbstractConsumerTarget.java:130)
>   at 
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.updateNotifyWorkDesired(ConsumerTarget_0_8.java:320)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.updateAllConsumerNotifyWorkDesired(AMQChannel.java:1495)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.receiveChannelFlow(AMQChannel.java:2319)
>   at 
> org.apache.qpid.server.protocol.v0_8.transport.ChannelFlowBody.process(ChannelFlowBody.java:98)
>   at 
> org.apache.qpid.server.protocol.v0_8.ServerDecoder.processMethod(ServerDecoder.java:126)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.processFrame(AMQDecoder.java:203)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.doProcessFrame(BrokerDecoder.java:141)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.processFrame(BrokerDecoder.java:65)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.processInput(AMQDecoder.java:185)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder$1.run(BrokerDecoder.java:104)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder$1.run(BrokerDecoder.java:97)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.processAMQPFrames(BrokerDecoder.java:96)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.decode(AMQDecoder.java:118)
>   at 
> org.apache.qpid.server.protocol.v0_8.ServerDecoder.decodeBuffer(ServerDecoder.java:44)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$1.run(AMQPConnection_0_8Impl.java:257)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$1.run(AMQPConnection_0_8Impl.java:249)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at 
> 

[jira] [Assigned] (QPID-8231) [Broker-J] [AMQP 0-8...0-9-1] Broker crashes on delivery of messages from queue having attribute 'messageGroupKeyOverride' set to an empty string

2018-09-10 Thread Alex Rudyy (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy reassigned QPID-8231:


Assignee: Alex Rudyy

> [Broker-J] [AMQP 0-8...0-9-1] Broker crashes on delivery of messages from 
> queue having attribute 'messageGroupKeyOverride' set to an empty string
> -
>
> Key: QPID-8231
> URL: https://issues.apache.org/jira/browse/QPID-8231
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.1.6, 0.32, qpid-java-6.0.8, 
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
>
> Broker crashes on consumption of messages from queue having attribute 
> 'messageGroupKeyOverride' set to an empty string. The following stack trace 
> is generated:
> {noformat}
> 
> #
> # Unhandled Exception java.lang.IllegalArgumentException: Property name must 
> not be the empty string in Thread IO-/127.0.0.1:63421
> #
> # Exiting
> #
> 
> java.lang.IllegalArgumentException: Property name must not be the empty string
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.checkPropertyName(FieldTable.java:787)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.getProperty(FieldTable.java:98)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.getObject(FieldTable.java:428)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.get(FieldTable.java:1055)
>   at 
> org.apache.qpid.server.protocol.v0_8.FieldTable.get(FieldTable.java:1050)
>   at 
> org.apache.qpid.server.protocol.v0_8.MessageMetaData$MessageHeaderAdapter.getHeader(MessageMetaData.java:283)
>   at 
> org.apache.qpid.server.queue.AssignedConsumerMessageGroupManager.getGroupValue(AssignedConsumerMessageGroupManager.java:83)
>   at 
> org.apache.qpid.server.queue.AssignedConsumerMessageGroupManager.mightAssign(AssignedConsumerMessageGroupManager.java:61)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.mightAssign(AbstractQueue.java:1335)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.getNextAvailableEntry(AbstractQueue.java:2087)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.consumerHasAvailableMessages(AbstractQueue.java:2234)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.notifyConsumer(AbstractQueue.java:2268)
>   at 
> org.apache.qpid.server.queue.AbstractQueue.setNotifyWorkDesired(AbstractQueue.java:2245)
>   at 
> org.apache.qpid.server.queue.QueueConsumerImpl.setNotifyWorkDesired(QueueConsumerImpl.java:356)
>   at 
> org.apache.qpid.server.consumer.AbstractConsumerTarget.setNotifyWorkDesired(AbstractConsumerTarget.java:130)
>   at 
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.updateNotifyWorkDesired(ConsumerTarget_0_8.java:320)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.updateAllConsumerNotifyWorkDesired(AMQChannel.java:1495)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.receiveChannelFlow(AMQChannel.java:2319)
>   at 
> org.apache.qpid.server.protocol.v0_8.transport.ChannelFlowBody.process(ChannelFlowBody.java:98)
>   at 
> org.apache.qpid.server.protocol.v0_8.ServerDecoder.processMethod(ServerDecoder.java:126)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.processFrame(AMQDecoder.java:203)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.doProcessFrame(BrokerDecoder.java:141)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.processFrame(BrokerDecoder.java:65)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.processInput(AMQDecoder.java:185)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder$1.run(BrokerDecoder.java:104)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder$1.run(BrokerDecoder.java:97)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at 
> org.apache.qpid.server.protocol.v0_8.BrokerDecoder.processAMQPFrames(BrokerDecoder.java:96)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQDecoder.decode(AMQDecoder.java:118)
>   at 
> org.apache.qpid.server.protocol.v0_8.ServerDecoder.decodeBuffer(ServerDecoder.java:44)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$1.run(AMQPConnection_0_8Impl.java:257)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$1.run(AMQPConnection_0_8Impl.java:249)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at 
> 

[jira] [Commented] (PROTON-1862) Idle timeout not working on Linux

2018-09-10 Thread Olivier VERMEULEN (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608919#comment-16608919
 ] 

Olivier VERMEULEN commented on PROTON-1862:
---

Hello Zafar,

I'll answer for Jeremy who's on vacation right now: feel free to work on this 
one, we're working on something else right now.

Regards,

Olivier

> Idle timeout not working on Linux
> -
>
> Key: PROTON-1862
> URL: https://issues.apache.org/jira/browse/PROTON-1862
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding
>Affects Versions: proton-c-0.22.0
>Reporter: Jeremy
>Priority: Critical
>  Labels: reproducer
> Attachments: proton_1862_tests.txt, test_case.cpp
>
>
> We faced an issue with the idle timeout on linux. On windows, it seems to 
> work.
> In our proton feature test suite, we test the idle timeout feature by doing a 
> sleep in the method on_session_open.
> This should trigger a connection timeout. It works on windows, and it used to 
> work with proton v0.16.0 on windows and linux.
> Removing the sleep from the on_session_open and putting it in 
> on_connection_open, yields the same result.
> See attached file to reproduce.
> Machines:
>  * Windows machine
>  ** OS: Windows 7
>  ** Compiler: MSVC 2013 Version 12 Update 5
>  * Linux machine
>  ** OS: Red Hat Enterprise Linux Server release 6.4 (Santiago)
>  ** Compiler: g++491 (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1090) Transfer/Disposition(state=release) loop forms when application disconnects abruptly from brokered queue until link credit is exhausted.

2018-09-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608843#comment-16608843
 ] 

ASF GitHub Bot commented on DISPATCH-1090:
--

Github user k-wall commented on the issue:

https://github.com/apache/qpid-dispatch/pull/371
  
I manually tested the patch 
https://github.com/apache/qpid-dispatch/pull/371 against Artemis 2.6.2, 
Broker-J 7.0.6 and CPP Broker (master).  The new behaviour looks good to me.

btw. There's a typo in the commit message "Draim" rather than "Drain".


> Transfer/Disposition(state=release) loop forms when application disconnects 
> abruptly from brokered queue until link credit is exhausted.
> 
>
> Key: DISPATCH-1090
> URL: https://issues.apache.org/jira/browse/DISPATCH-1090
> Project: Qpid Dispatch
>  Issue Type: Bug
> Environment: Version  1.3.0-SNAPSHOT
>  (30ff7ff1d54b8f280b36f76dc8c340cb4c88567b)
>Reporter: Keith Wall
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: Backlog
>
> Attachments: DISPATCH-1090_dispatch_server.log
>
>
> I have configured a single Dispatch Router instance to route messages through 
> a broker queue (i.e. following section 7.2.5 of the 
> [docs|https://qpid.apache.org/releases/qpid-dispatch-1.2.0/user-guide/index.html#routing-messages-through-broker]).
> The application does the following:
> # Forms a sending links to the queue, sends a single message then disconnects.
> # Forms a receiving link to the same queue, receives the message without 
> settling then abruptly terminates the program.
> Inspecting the protocol trace, I see that after the Dispatch Router has sent 
> a {{Disposition state=modified}} for the message that was held by the 
> application when it terminated, a {{Transfer}}/{{Disposition state=release}} 
> loop forms between the Dispatch Router and Broker until the link credit is 
> exhausted.  
> Protocol trace attached to this issue demonstrates the problem.
> Dispatch Router was configured by the following commands:
> {noformat}
> qdmanage create --type org.apache.qpid.dispatch.connector host=oslo.local 
> port=5672 name=artemis-broker role=route-container
> qdmanage create --type org.apache.qpid.dispatch.router.config.autoLink 
> addr=queue direction=in connection=artemis-broker
> qdmanage create --type org.apache.qpid.dispatch.router.config.autoLink 
> addr=queue direction=out connection=artemis-broker
> qdmanage create --type=org.apache.qpid.dispatch.router.config.address 
> pattern=queue waypoint=true
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-dispatch issue #371: DISPATCH-1090 - Draim excess credit if there are n...

2018-09-10 Thread k-wall
Github user k-wall commented on the issue:

https://github.com/apache/qpid-dispatch/pull/371
  
I manually tested the patch 
https://github.com/apache/qpid-dispatch/pull/371 against Artemis 2.6.2, 
Broker-J 7.0.6 and CPP Broker (master).  The new behaviour looks good to me.

btw. There's a typo in the commit message "Draim" rather than "Drain".


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org