[jira] [Commented] (PROTON-1992) [Python] Rework python binding to use only Proton Core library

2019-02-25 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777194#comment-16777194
 ] 

ASF subversion and git services commented on PROTON-1992:
-

Commit 8dc796d49934b2ea3b01dcc794461827696339ce in qpid-proton's branch 
refs/heads/master from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=8dc796d ]

PROTON-1992: [Python] Cope with select being interrupted.
- Ignore interrupted select syscalls
-- We do this as the dispatch systems tests use proton calls in a signal handler
-- It's not clear to me that uis actually allowed - it wouldn't be in raw C
- So it's not entirely clear this is the correct way to go or that the
  code that causes this issue doesn't need fixinf itself!


> [Python] Rework python binding to use only Proton Core library
> --
>
> Key: PROTON-1992
> URL: https://issues.apache.org/jira/browse/PROTON-1992
> Project: Qpid Proton
>  Issue Type: New Feature
>  Components: python-binding
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1467) [python] setup.py script fails to build C sources on Windows

2019-02-25 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777192#comment-16777192
 ] 

ASF subversion and git services commented on PROTON-1467:
-

Commit 16e5c35b1fec76dc65b9fbbfb6f6551e5e72723e in qpid-proton's branch 
refs/heads/master from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=16e5c35 ]

PROTON-1467: [Python] Get pip install working on Windows


> [python] setup.py script fails to build C sources on Windows
> 
>
> Key: PROTON-1467
> URL: https://issues.apache.org/jira/browse/PROTON-1467
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: python-binding
>Affects Versions: proton-c-0.17.0
>Reporter: Ken Giusti
>Assignee: Andrew Stitcher
>Priority: Major
>
> The setup.py script is unable to build the C extension under windows.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1992) [Python] Rework python binding to use only Proton Core library

2019-02-25 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777189#comment-16777189
 ] 

ASF subversion and git services commented on PROTON-1992:
-

Commit 1d6e14f8bb077f584afbe5419aab7ed78d422f9b in qpid-proton's branch 
refs/heads/master from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=1d6e14f ]

PROTON-1992: [Python] Remove dependency on Proton Reactor API
- Python binding now only uses APIs from Proton Core library.
  It uses Python APIs to do all IO and uses Proton purely to process
  the AMQP protocol.
- It is very compatible with the existing higher level Python APIs.
  [In modules proton, proton.reactor, proton.handlers, proton.utils]

- Passes the python tests as well as before
- Works with Python 2 and Python 3
- Works on Unix and Windows
- Runs all the python examples


> [Python] Rework python binding to use only Proton Core library
> --
>
> Key: PROTON-1992
> URL: https://issues.apache.org/jira/browse/PROTON-1992
> Project: Qpid Proton
>  Issue Type: New Feature
>  Components: python-binding
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1992) [Python] Rework python binding to use only Proton Core library

2019-02-25 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777190#comment-16777190
 ] 

ASF subversion and git services commented on PROTON-1992:
-

Commit b7571f03787aac9946c8719032668a7f959da3ed in qpid-proton's branch 
refs/heads/master from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=b7571f0 ]

PROTON-1992: [Python] Sort imports


> [Python] Rework python binding to use only Proton Core library
> --
>
> Key: PROTON-1992
> URL: https://issues.apache.org/jira/browse/PROTON-1992
> Project: Qpid Proton
>  Issue Type: New Feature
>  Components: python-binding
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1992) [Python] Rework python binding to use only Proton Core library

2019-02-25 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777193#comment-16777193
 ] 

ASF subversion and git services commented on PROTON-1992:
-

Commit 46979cfe2872eb2bc7f48a2d8ff5a9ee4a4b414e in qpid-proton's branch 
refs/heads/master from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=46979cf ]

PROTON-1992: [Python] Give on_timer_task event a valid container
- Fixes a problem with dispatch unit tests


> [Python] Rework python binding to use only Proton Core library
> --
>
> Key: PROTON-1992
> URL: https://issues.apache.org/jira/browse/PROTON-1992
> Project: Qpid Proton
>  Issue Type: New Feature
>  Components: python-binding
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1992) [Python] Rework python binding to use only Proton Core library

2019-02-25 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777191#comment-16777191
 ] 

ASF subversion and git services commented on PROTON-1992:
-

Commit e4aec3a53759e2caf3a5ba22efbc1aff5c662685 in qpid-proton's branch 
refs/heads/master from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=e4aec3a ]

PROTON-1992: [Python] move build dependencies to Proton-C Core
- Remove all swig bound APIs that are only in libqpid-proton
- Link Python extension lib to libqpid-proton-core


> [Python] Rework python binding to use only Proton Core library
> --
>
> Key: PROTON-1992
> URL: https://issues.apache.org/jira/browse/PROTON-1992
> Project: Qpid Proton
>  Issue Type: New Feature
>  Components: python-binding
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] asfgit merged pull request #173: Rework Python binding to use only core APIs

2019-02-25 Thread GitBox
asfgit merged pull request #173: Rework Python binding to use only core APIs
URL: https://github.com/apache/qpid-proton/pull/173
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1996) Proton Client is "stalled" during SASL handshake

2019-02-25 Thread Gordon Sim (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777158#comment-16777158
 ] 

Gordon Sim commented on PROTON-1996:


For the router, using the _initialHandshakeTimeoutSeconds_ property of a 
listener can help avoid this.

> Proton Client is "stalled" during SASL handshake
> 
>
> Key: PROTON-1996
> URL: https://issues.apache.org/jira/browse/PROTON-1996
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-j
>Affects Versions: proton-j-0.25.0, proton-j-0.31.0
>Reporter: Daniel Maier
>Priority: Major
>
> Hi,
> When I try to connect with proton vertx client to an AMQP server, the client 
> seems to come sporadically in some kind of "stalled" state. The logs, see 
> below, look like the server just not responds anymore which cause the client 
> to be stalled. There are no more logs regarding SASL handshake.
> Used server is qdrouter.
> Would it make sense from your point of view to introduce a timeout here? Or 
> is the responsibility for this in the calling application? 
> {code}
> 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG 
> o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output 
> Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512]
> 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG 
> o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output 
> Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512]
> 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG 
> o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output 
> Buffer : java.nio.HeapByteBuffer[pos=8 lim=512 cap=512]
> 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG 
> o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output 
> Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512]
> 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG 
> o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output 
> Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512]
> 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG 
> o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output 
> Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512]
> 08:32:49.412 [vert.x-eventloop-thread-0] DEBUG 
> io.netty.handler.ssl.SslHandler - [id: 0x429f2c43, L:/100.100.0.6:45982 - 
> R:xxx.com/xxx:443] HANDSHAKEN: TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
> 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG 
> o.a.qpid.proton.engine.impl.SaslImpl - SaslImpl [_outcome=PN_SASL_NONE, 
> state=PN_SASL_IDLE, done=false, role=CLIENT] about to call input.
> 08:32:49.418 [vert.x-eventloop-thread-0] TRACE 
> io.vertx.proton.impl.ProtonTransport - New Proton Event: CONNECTION_INIT
> 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG 
> o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output 
> Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512]
> 08:32:49.418 [vert.x-eventloop-thread-0] DEBUG 
> o.a.qpid.proton.engine.impl.SaslImpl - Finished writing SASL output. Output 
> Buffer : java.nio.HeapByteBuffer[pos=0 lim=512 cap=512]
> {code}
> Thanks
> Daniel



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (DISPATCH-1271) The LWS_CALLBACK_USER handler in http-libwebsockets.c is never triggered

2019-02-25 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiri Daněk updated DISPATCH-1271:
-
Description: 
{noformat}
lws_callback_all_protocol(hs->context, &protocols[1], 
LWS_CALLBACK_USER);
lws_callback_all_protocol(hs->context, &protocols[2], 
LWS_CALLBACK_USER);
{noformat}
The problem is that {{lws_callback_all_protocol}} compares pointers to protocol 
structs with {{protocol}} parameter. They are never equal, because early on in 
{{listener_start}}, {{lws_create_vhost}} gets called, and it allocates a copy 
of the {{protocols}} array only for that vhost.

I expected that this will cause dispatch not to send heartbeats to clients 
connected over amqpws (since {{pn_transport_tick}} is not called). I tested 
that with qpid-jms, and -it turned out that the heartbeats are flowing 
correctly. In other words, I am not aware of any user-visible bug caused by 
this. Is calling _tick unnecessary? What is it there for?- I saw that dispatch 
is not sending its own heartbeats on the amqpws connections.
{noformat}
LWS_VISIBLE int
lws_callback_all_protocol(struct lws_context *context,
  const struct lws_protocols *protocol, int reason)
{
struct lws_context_per_thread *pt = &context->pt[0];
unsigned int n, m = context->count_threads;
struct lws *wsi;

while (m--) {
for (n = 0; n < pt->fds_count; n++) {
wsi = wsi_from_fd(context, pt->fds[n].fd);
if (!wsi)
continue;
if (wsi->protocol == protocol)
protocol->callback(wsi, reason, wsi->user_space,
   NULL, 0);
}
pt++;
}

return 0;
}
{noformat}
{noformat}
LWS_VISIBLE struct lws_vhost *
lws_create_vhost(struct lws_context *context,
 const struct lws_context_creation_info *info)
{
[...]

/*
 * give the vhost a unified list of protocols including the
 * ones that came from plugins
 */
lwsp = lws_zalloc(sizeof(struct lws_protocols) * (vh->count_protocols +
   context->plugin_protocol_count + 1),
  "vhost-specific plugin table");
if (!lwsp) {
lwsl_err("OOM\n");
return NULL;
}

m = vh->count_protocols;
memcpy(lwsp, pcols, sizeof(struct lws_protocols) * m);

[...]

if (
#ifdef LWS_WITH_PLUGINS
(context->plugin_list) ||
#endif
context->options & LWS_SERVER_OPTION_EXPLICIT_VHOSTS)
vh->protocols = lwsp;
else {
vh->protocols = pcols;
lws_free(lwsp);
}

[...]
}
{noformat}

  was:
{noformat}
lws_callback_all_protocol(hs->context, &protocols[1], 
LWS_CALLBACK_USER);
lws_callback_all_protocol(hs->context, &protocols[2], 
LWS_CALLBACK_USER);
{noformat}

The problem is that {{lws_callback_all_protocol}} compares pointers to protocol 
structs with {{protocol}} parameter. They are never equal, because early on in 
{{listener_start}}, {{lws_create_vhost}} gets called, and it allocates a copy 
of the {{protocols}} array only for that vhost.

I expected that this will cause dispatch not to send heartbeats to clients 
connected over amqpws (since {{pn_transport_tick}} is not called). I tested 
that with qpid-jms, and it turned out that the heartbeats are flowing 
correctly. In other words, I am not aware of any user-visible bug caused by 
this. Is calling _tick unnecessary? What is it there for?

{noformat}
LWS_VISIBLE int
lws_callback_all_protocol(struct lws_context *context,
  const struct lws_protocols *protocol, int reason)
{
struct lws_context_per_thread *pt = &context->pt[0];
unsigned int n, m = context->count_threads;
struct lws *wsi;

while (m--) {
for (n = 0; n < pt->fds_count; n++) {
wsi = wsi_from_fd(context, pt->fds[n].fd);
if (!wsi)
continue;
if (wsi->protocol == protocol)
protocol->callback(wsi, reason, wsi->user_space,
   NULL, 0);
}
pt++;
}

return 0;
}
{noformat}

{noformat}
LWS_VISIBLE struct lws_vhost *
lws_create_vhost(struct lws_context *context,
 const struct lws_context_creation_info *info)
{
[...]

/*
 * give the vhost a unified list of protocols including the
 * ones that came from plugins
 */
lwsp = lws_zalloc(sizeof(struct lws_protocols) * (vh->count_protocols +

[jira] [Comment Edited] (QPIDJMS-444) Heartbeating is affected by changes to wall clock time

2019-02-25 Thread Robbie Gemmell (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776918#comment-16776918
 ] 

Robbie Gemmell edited comment on QPIDJMS-444 at 2/25/19 2:52 PM:
-

EDIT: the below related to a now-deleted comment, referencing DISPATCH-1271 and 
suggesting it wasn't ticking the transport.

I dont really follow that other JIRA but proton cant do heartbeating without 
the tick method being called, so unless Dispatch is explicitly performing 
heartbeating calculations and writing the empty frames onto the wire itself, it 
must be getting called somewhere.


was (Author: gemmellr):
I dont really follow that other JIRA but proton cant do heartbeating without 
the tick method being called, so unless Dispatch is explicitly performing 
heartbeating calculations and writing the empty frames onto the wire itself, it 
must be getting called somewhere.

> Heartbeating is affected by changes to wall clock time
> --
>
> Key: QPIDJMS-444
> URL: https://issues.apache.org/jira/browse/QPIDJMS-444
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.40.0
>Reporter: Jiri Daněk
>Priority: Minor
>
> Monotonic clock should be used, which will not be affected by changes to 
> system time.
> h3. reproducer
> Change the date like this
> {noformat}
> $ date --set "$(date -d '1 hour')"
> {noformat}
> while the client is in operation (example uses 
> https://github.com/rh-messaging/cli-java/tree/master/cli-qpid-jms)
> {noformat}
> $ PN_TRACE_FRM=1 java -jar 
> ~/Work/repos/cli-java/cli-qpid-jms/target/cli-qpid-jms-1.2.2-SNAPSHOT-LATEST.jar
>  sender amqpws://localhost:1126 --address address/0 --log-msgs=dict --count=2 
> --duration 999 --conn-heartbeat 1[1270504454:0] -> Open{ 
> containerId='ID:fae6a385-77b2-4f3c-8c67-1ade8d303ed7:1', 
> hostname='localhost', maxFrameSize=1048576, channelMax=32767, 
> idleTimeOut=500, outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=null, desiredCapabilities=[sole-connection-for-container, 
> DELAYED_DELIVERY, ANONYMOUS-RELAY, SHARED-SUBS], properties={product=QpidJMS, 
> version=0.40.0, platform=JVM: 11.0.1-internal, 
> 11.0.1-internal+0-adhoc..jdk11u-jdk-11.0.113, Oracle Corporation, OS: Linux, 
> 4.14.98, amd64}}
> [1270504454:0] <- Open{ containerId='Standalone_En6PorJudCHF9o6', 
> hostname='null', maxFrameSize=16384, channelMax=32767, idleTimeOut=8000, 
> outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=[ANONYMOUS-RELAY], desiredCapabilities=null, 
> properties={product=qpid-dispatch-router, version=1.6.0-SNAPSHOT, 
> qd.conn-id=1}}
> [1270504454:0] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:0] <- Begin{remoteChannel=0, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] <- Begin{remoteChannel=1, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=SENDER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=null, offeredCapabilities=null, 
> desiredCapabilities=[DELAYED_DELIVERY], properties=null}
> [1270504454:1] <- 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:lis

[jira] [Closed] (QPIDJMS-444) Heartbeating is affected by changes to wall clock time

2019-02-25 Thread Robbie Gemmell (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPIDJMS-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell closed QPIDJMS-444.
--
Assignee: Robbie Gemmell

> Heartbeating is affected by changes to wall clock time
> --
>
> Key: QPIDJMS-444
> URL: https://issues.apache.org/jira/browse/QPIDJMS-444
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.40.0
>Reporter: Jiri Daněk
>Assignee: Robbie Gemmell
>Priority: Minor
>
> Monotonic clock should be used, which will not be affected by changes to 
> system time.
> h3. reproducer
> Change the date like this
> {noformat}
> $ date --set "$(date -d '1 hour')"
> {noformat}
> while the client is in operation (example uses 
> https://github.com/rh-messaging/cli-java/tree/master/cli-qpid-jms)
> {noformat}
> $ PN_TRACE_FRM=1 java -jar 
> ~/Work/repos/cli-java/cli-qpid-jms/target/cli-qpid-jms-1.2.2-SNAPSHOT-LATEST.jar
>  sender amqpws://localhost:1126 --address address/0 --log-msgs=dict --count=2 
> --duration 999 --conn-heartbeat 1[1270504454:0] -> Open{ 
> containerId='ID:fae6a385-77b2-4f3c-8c67-1ade8d303ed7:1', 
> hostname='localhost', maxFrameSize=1048576, channelMax=32767, 
> idleTimeOut=500, outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=null, desiredCapabilities=[sole-connection-for-container, 
> DELAYED_DELIVERY, ANONYMOUS-RELAY, SHARED-SUBS], properties={product=QpidJMS, 
> version=0.40.0, platform=JVM: 11.0.1-internal, 
> 11.0.1-internal+0-adhoc..jdk11u-jdk-11.0.113, Oracle Corporation, OS: Linux, 
> 4.14.98, amd64}}
> [1270504454:0] <- Open{ containerId='Standalone_En6PorJudCHF9o6', 
> hostname='null', maxFrameSize=16384, channelMax=32767, idleTimeOut=8000, 
> outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=[ANONYMOUS-RELAY], desiredCapabilities=null, 
> properties={product=qpid-dispatch-router, version=1.6.0-SNAPSHOT, 
> qd.conn-id=1}}
> [1270504454:0] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:0] <- Begin{remoteChannel=0, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] <- Begin{remoteChannel=1, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=SENDER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=null, offeredCapabilities=null, 
> desiredCapabilities=[DELAYED_DELIVERY], properties=null}
> [1270504454:1] <- 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=0, offeredCapabilities=null, desiredCapabilities=null, 
> properties=null}
> [1270504454:0] <- Empty Frame
> [...]
> [1270504454:0] <- Empty Frame
> [1270504454:0] <- Empty Frame
> {noformat}
> When time changes, observe exception
> {noformat}
> [1270504454:0] <- Close{error=Error{condition=amqp:resource-limit-exceeded, 
> description='local-idle-timeout expired', info=null}}
> [1270504454:0] -

[jira] [Resolved] (QPIDJMS-444) Heartbeating is affected by changes to wall clock time

2019-02-25 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/QPIDJMS-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiri Daněk resolved QPIDJMS-444.

Resolution: Invalid

> Heartbeating is affected by changes to wall clock time
> --
>
> Key: QPIDJMS-444
> URL: https://issues.apache.org/jira/browse/QPIDJMS-444
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.40.0
>Reporter: Jiri Daněk
>Priority: Minor
>
> Monotonic clock should be used, which will not be affected by changes to 
> system time.
> h3. reproducer
> Change the date like this
> {noformat}
> $ date --set "$(date -d '1 hour')"
> {noformat}
> while the client is in operation (example uses 
> https://github.com/rh-messaging/cli-java/tree/master/cli-qpid-jms)
> {noformat}
> $ PN_TRACE_FRM=1 java -jar 
> ~/Work/repos/cli-java/cli-qpid-jms/target/cli-qpid-jms-1.2.2-SNAPSHOT-LATEST.jar
>  sender amqpws://localhost:1126 --address address/0 --log-msgs=dict --count=2 
> --duration 999 --conn-heartbeat 1[1270504454:0] -> Open{ 
> containerId='ID:fae6a385-77b2-4f3c-8c67-1ade8d303ed7:1', 
> hostname='localhost', maxFrameSize=1048576, channelMax=32767, 
> idleTimeOut=500, outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=null, desiredCapabilities=[sole-connection-for-container, 
> DELAYED_DELIVERY, ANONYMOUS-RELAY, SHARED-SUBS], properties={product=QpidJMS, 
> version=0.40.0, platform=JVM: 11.0.1-internal, 
> 11.0.1-internal+0-adhoc..jdk11u-jdk-11.0.113, Oracle Corporation, OS: Linux, 
> 4.14.98, amd64}}
> [1270504454:0] <- Open{ containerId='Standalone_En6PorJudCHF9o6', 
> hostname='null', maxFrameSize=16384, channelMax=32767, idleTimeOut=8000, 
> outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=[ANONYMOUS-RELAY], desiredCapabilities=null, 
> properties={product=qpid-dispatch-router, version=1.6.0-SNAPSHOT, 
> qd.conn-id=1}}
> [1270504454:0] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:0] <- Begin{remoteChannel=0, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] <- Begin{remoteChannel=1, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=SENDER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=null, offeredCapabilities=null, 
> desiredCapabilities=[DELAYED_DELIVERY], properties=null}
> [1270504454:1] <- 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=0, offeredCapabilities=null, desiredCapabilities=null, 
> properties=null}
> [1270504454:0] <- Empty Frame
> [...]
> [1270504454:0] <- Empty Frame
> [1270504454:0] <- Empty Frame
> {noformat}
> When time changes, observe exception
> {noformat}
> [1270504454:0] <- Close{error=Error{condition=amqp:resource-limit-exceeded, 
> description='local-idle-timeout expired', info=null}}
> [1270504454:0] -> Close{error=null}
> 11:08:49,009 ERROR Error 

[jira] [Commented] (QPIDJMS-444) Heartbeating is affected by changes to wall clock time

2019-02-25 Thread JIRA


[ 
https://issues.apache.org/jira/browse/QPIDJMS-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776942#comment-16776942
 ] 

Jiri Daněk commented on QPIDJMS-444:


It is proton-c, actually. There is still work for PROTON-985. For example, 
epoll.c is still feeding pn_transport_tick with CLOCK_REALTIME. Thanks for 
making me realize the series of things I was doing wrong... I'll move the 
ticket to PROTON project.

> Heartbeating is affected by changes to wall clock time
> --
>
> Key: QPIDJMS-444
> URL: https://issues.apache.org/jira/browse/QPIDJMS-444
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.40.0
>Reporter: Jiri Daněk
>Priority: Minor
>
> Monotonic clock should be used, which will not be affected by changes to 
> system time.
> h3. reproducer
> Change the date like this
> {noformat}
> $ date --set "$(date -d '1 hour')"
> {noformat}
> while the client is in operation (example uses 
> https://github.com/rh-messaging/cli-java/tree/master/cli-qpid-jms)
> {noformat}
> $ PN_TRACE_FRM=1 java -jar 
> ~/Work/repos/cli-java/cli-qpid-jms/target/cli-qpid-jms-1.2.2-SNAPSHOT-LATEST.jar
>  sender amqpws://localhost:1126 --address address/0 --log-msgs=dict --count=2 
> --duration 999 --conn-heartbeat 1[1270504454:0] -> Open{ 
> containerId='ID:fae6a385-77b2-4f3c-8c67-1ade8d303ed7:1', 
> hostname='localhost', maxFrameSize=1048576, channelMax=32767, 
> idleTimeOut=500, outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=null, desiredCapabilities=[sole-connection-for-container, 
> DELAYED_DELIVERY, ANONYMOUS-RELAY, SHARED-SUBS], properties={product=QpidJMS, 
> version=0.40.0, platform=JVM: 11.0.1-internal, 
> 11.0.1-internal+0-adhoc..jdk11u-jdk-11.0.113, Oracle Corporation, OS: Linux, 
> 4.14.98, amd64}}
> [1270504454:0] <- Open{ containerId='Standalone_En6PorJudCHF9o6', 
> hostname='null', maxFrameSize=16384, channelMax=32767, idleTimeOut=8000, 
> outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=[ANONYMOUS-RELAY], desiredCapabilities=null, 
> properties={product=qpid-dispatch-router, version=1.6.0-SNAPSHOT, 
> qd.conn-id=1}}
> [1270504454:0] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:0] <- Begin{remoteChannel=0, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] <- Begin{remoteChannel=1, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=SENDER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=null, offeredCapabilities=null, 
> desiredCapabilities=[DELAYED_DELIVERY], properties=null}
> [1270504454:1] <- 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=0, offeredCapabilities=null, desiredCapabilities=null, 
> properties=null}
> [1270504454:0] <- Empty Frame
> [...]
> [1270504454:0] <- Empty Frame
> [127050445

[jira] [Issue Comment Deleted] (QPIDJMS-444) Heartbeating is affected by changes to wall clock time

2019-02-25 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/QPIDJMS-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiri Daněk updated QPIDJMS-444:
---
Comment: was deleted

(was: edit: temporarily hidden)

> Heartbeating is affected by changes to wall clock time
> --
>
> Key: QPIDJMS-444
> URL: https://issues.apache.org/jira/browse/QPIDJMS-444
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.40.0
>Reporter: Jiri Daněk
>Priority: Minor
>
> Monotonic clock should be used, which will not be affected by changes to 
> system time.
> h3. reproducer
> Change the date like this
> {noformat}
> $ date --set "$(date -d '1 hour')"
> {noformat}
> while the client is in operation (example uses 
> https://github.com/rh-messaging/cli-java/tree/master/cli-qpid-jms)
> {noformat}
> $ PN_TRACE_FRM=1 java -jar 
> ~/Work/repos/cli-java/cli-qpid-jms/target/cli-qpid-jms-1.2.2-SNAPSHOT-LATEST.jar
>  sender amqpws://localhost:1126 --address address/0 --log-msgs=dict --count=2 
> --duration 999 --conn-heartbeat 1[1270504454:0] -> Open{ 
> containerId='ID:fae6a385-77b2-4f3c-8c67-1ade8d303ed7:1', 
> hostname='localhost', maxFrameSize=1048576, channelMax=32767, 
> idleTimeOut=500, outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=null, desiredCapabilities=[sole-connection-for-container, 
> DELAYED_DELIVERY, ANONYMOUS-RELAY, SHARED-SUBS], properties={product=QpidJMS, 
> version=0.40.0, platform=JVM: 11.0.1-internal, 
> 11.0.1-internal+0-adhoc..jdk11u-jdk-11.0.113, Oracle Corporation, OS: Linux, 
> 4.14.98, amd64}}
> [1270504454:0] <- Open{ containerId='Standalone_En6PorJudCHF9o6', 
> hostname='null', maxFrameSize=16384, channelMax=32767, idleTimeOut=8000, 
> outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=[ANONYMOUS-RELAY], desiredCapabilities=null, 
> properties={product=qpid-dispatch-router, version=1.6.0-SNAPSHOT, 
> qd.conn-id=1}}
> [1270504454:0] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:0] <- Begin{remoteChannel=0, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] <- Begin{remoteChannel=1, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=SENDER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=null, offeredCapabilities=null, 
> desiredCapabilities=[DELAYED_DELIVERY], properties=null}
> [1270504454:1] <- 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=0, offeredCapabilities=null, desiredCapabilities=null, 
> properties=null}
> [1270504454:0] <- Empty Frame
> [...]
> [1270504454:0] <- Empty Frame
> [1270504454:0] <- Empty Frame
> {noformat}
> When time changes, observe exception
> {noformat}
> [1270504454:0] <- Close{error=Error{condition=amqp:resource-limit-exceeded, 
> description='local-idle-timeout expired', info=null}}
> [1270504454:0] -> Close{error=n

[jira] [Updated] (QPIDJMS-444) Heartbeating is affected by changes to wall clock time

2019-02-25 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/QPIDJMS-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiri Daněk updated QPIDJMS-444:
---
Description: 
Monotonic clock should be used, which will not be affected by changes to system 
time.

h3. reproducer

Change the date like this

{noformat}
$ date --set "$(date -d '1 hour')"
{noformat}

while the client is in operation (example uses 
https://github.com/rh-messaging/cli-java/tree/master/cli-qpid-jms)

{noformat}
$ PN_TRACE_FRM=1 java -jar 
~/Work/repos/cli-java/cli-qpid-jms/target/cli-qpid-jms-1.2.2-SNAPSHOT-LATEST.jar
 sender amqpws://localhost:1126 --address address/0 --log-msgs=dict --count=2 
--duration 999 --conn-heartbeat 1[1270504454:0] -> Open{ 
containerId='ID:fae6a385-77b2-4f3c-8c67-1ade8d303ed7:1', hostname='localhost', 
maxFrameSize=1048576, channelMax=32767, idleTimeOut=500, outgoingLocales=null, 
incomingLocales=null, offeredCapabilities=null, 
desiredCapabilities=[sole-connection-for-container, DELAYED_DELIVERY, 
ANONYMOUS-RELAY, SHARED-SUBS], properties={product=QpidJMS, version=0.40.0, 
platform=JVM: 11.0.1-internal, 11.0.1-internal+0-adhoc..jdk11u-jdk-11.0.113, 
Oracle Corporation, OS: Linux, 4.14.98, amd64}}
[1270504454:0] <- Open{ containerId='Standalone_En6PorJudCHF9o6', 
hostname='null', maxFrameSize=16384, channelMax=32767, idleTimeOut=8000, 
outgoingLocales=null, incomingLocales=null, 
offeredCapabilities=[ANONYMOUS-RELAY], desiredCapabilities=null, 
properties={product=qpid-dispatch-router, version=1.6.0-SNAPSHOT, qd.conn-id=1}}
[1270504454:0] -> Begin{remoteChannel=null, nextOutgoingId=1, 
incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
offeredCapabilities=null, desiredCapabilities=null, properties=null}
[1270504454:0] <- Begin{remoteChannel=0, nextOutgoingId=0, 
incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
offeredCapabilities=null, desiredCapabilities=null, properties=null}
[1270504454:1] -> Begin{remoteChannel=null, nextOutgoingId=1, 
incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
offeredCapabilities=null, desiredCapabilities=null, properties=null}
[1270504454:1] <- Begin{remoteChannel=1, nextOutgoingId=0, 
incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
offeredCapabilities=null, desiredCapabilities=null, properties=null}
[1270504454:1] -> 
Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
 handle=0, role=SENDER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST, 
source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
dynamicNodeProperties=null, distributionMode=null, filter=null, 
defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
amqp:released:list, amqp:modified:list], capabilities=null}, 
target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
maxMessageSize=null, offeredCapabilities=null, 
desiredCapabilities=[DELAYED_DELIVERY], properties=null}
[1270504454:1] <- 
Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
 handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
dynamicNodeProperties=null, distributionMode=null, filter=null, 
defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
amqp:released:list, amqp:modified:list], capabilities=null}, 
target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
maxMessageSize=0, offeredCapabilities=null, desiredCapabilities=null, 
properties=null}
[1270504454:0] <- Empty Frame

[...]

[1270504454:0] <- Empty Frame
[1270504454:0] <- Empty Frame
{noformat}

When time changes, observe exception

{noformat}
[1270504454:0] <- Close{error=Error{condition=amqp:resource-limit-exceeded, 
description='local-idle-timeout expired', info=null}}
[1270504454:0] -> Close{error=null}
11:08:49,009 ERROR Error while sending a message!
javax.jms.ResourceAllocationException: local-idle-timeout expired [condition = 
amqp:resource-limit-exceeded]
at 
org.apache.qpid.jms.provider.amqp.AmqpSupport.convertToException(AmqpSupport.java:146)
at 
org.apache.qpid.jms.provider.amqp.AmqpSupport.convertToException(AmqpSupport.java:118)
at 
org.apache.qpid.jms.provider.amqp.AmqpConnection.processRemoteClose(AmqpConnection.java:150)
at 
org.apache.qpid.jms.provider.amqp.AmqpProvider.processUpdates(AmqpProvider.java:914)
at 
org.apache.qpid.jms.provid

[jira] [Comment Edited] (QPIDJMS-444) Heartbeating is affected by changes to wall clock time

2019-02-25 Thread JIRA


[ 
https://issues.apache.org/jira/browse/QPIDJMS-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776901#comment-16776901
 ] 

Jiri Daněk edited comment on QPIDJMS-444 at 2/25/19 2:09 PM:
-

edit: temporarily hidden


was (Author: jdanek):
I can reproduce this on two different machines, changing clock only on the 
qpid-jms machine and leaving qdrouterd be. I haven't realized I cannot simplify 
it on one machine, due to the possible interference.

bq. more likely something around the threading or when the first heartbeat is 
sent (your logs suggest one wasn't?).

There was, it was in the [...] elided section.

I'll go gather better logs, then.

About DISPATCH-1270 interacting. Maybe, maybe not, I later found DISPATCH-1271, 
which states my conclusion that the wrong {{pn_transport_tick}} code is not 
being executed at all, due to different bug.

> Heartbeating is affected by changes to wall clock time
> --
>
> Key: QPIDJMS-444
> URL: https://issues.apache.org/jira/browse/QPIDJMS-444
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.40.0
>Reporter: Jiri Daněk
>Priority: Minor
>
> Monotonic clock should be used, which will not be affected by changes to 
> system time.
> h3. reproducer
> Change the date like this. edit: you have to do it twice.
> {noformat}
> $ date --set "$(date -d '1 hour')"
> {noformat}
> while the client is in operation (example uses 
> https://github.com/rh-messaging/cli-java/tree/master/cli-qpid-jms)
> {noformat}
> $ PN_TRACE_FRM=1 java -jar 
> ~/Work/repos/cli-java/cli-qpid-jms/target/cli-qpid-jms-1.2.2-SNAPSHOT-LATEST.jar
>  sender amqpws://localhost:1126 --address address/0 --log-msgs=dict --count=2 
> --duration 999 --conn-heartbeat 1[1270504454:0] -> Open{ 
> containerId='ID:fae6a385-77b2-4f3c-8c67-1ade8d303ed7:1', 
> hostname='localhost', maxFrameSize=1048576, channelMax=32767, 
> idleTimeOut=500, outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=null, desiredCapabilities=[sole-connection-for-container, 
> DELAYED_DELIVERY, ANONYMOUS-RELAY, SHARED-SUBS], properties={product=QpidJMS, 
> version=0.40.0, platform=JVM: 11.0.1-internal, 
> 11.0.1-internal+0-adhoc..jdk11u-jdk-11.0.113, Oracle Corporation, OS: Linux, 
> 4.14.98, amd64}}
> [1270504454:0] <- Open{ containerId='Standalone_En6PorJudCHF9o6', 
> hostname='null', maxFrameSize=16384, channelMax=32767, idleTimeOut=8000, 
> outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=[ANONYMOUS-RELAY], desiredCapabilities=null, 
> properties={product=qpid-dispatch-router, version=1.6.0-SNAPSHOT, 
> qd.conn-id=1}}
> [1270504454:0] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:0] <- Begin{remoteChannel=0, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] <- Begin{remoteChannel=1, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=SENDER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=null, offeredCapabilities=null, 
> desiredCapabilities=[DELAYED_DELIVERY], properties=null}
> [1270504454:1] <- 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:lis

[jira] [Commented] (QPIDJMS-444) Heartbeating is affected by changes to wall clock time

2019-02-25 Thread Robbie Gemmell (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776918#comment-16776918
 ] 

Robbie Gemmell commented on QPIDJMS-444:


I dont really follow that other JIRA but proton cant do heartbeating without 
the tick method being called, so unless Dispatch is explicitly performing 
heartbeating calculations and writing the empty frames onto the wire itself, it 
must be getting called somewhere.

> Heartbeating is affected by changes to wall clock time
> --
>
> Key: QPIDJMS-444
> URL: https://issues.apache.org/jira/browse/QPIDJMS-444
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.40.0
>Reporter: Jiri Daněk
>Priority: Minor
>
> Monotonic clock should be used, which will not be affected by changes to 
> system time.
> h3. reproducer
> Change the date like this. edit: you have to do it twice.
> {noformat}
> $ date --set "$(date -d '1 hour')"
> {noformat}
> while the client is in operation (example uses 
> https://github.com/rh-messaging/cli-java/tree/master/cli-qpid-jms)
> {noformat}
> $ PN_TRACE_FRM=1 java -jar 
> ~/Work/repos/cli-java/cli-qpid-jms/target/cli-qpid-jms-1.2.2-SNAPSHOT-LATEST.jar
>  sender amqpws://localhost:1126 --address address/0 --log-msgs=dict --count=2 
> --duration 999 --conn-heartbeat 1[1270504454:0] -> Open{ 
> containerId='ID:fae6a385-77b2-4f3c-8c67-1ade8d303ed7:1', 
> hostname='localhost', maxFrameSize=1048576, channelMax=32767, 
> idleTimeOut=500, outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=null, desiredCapabilities=[sole-connection-for-container, 
> DELAYED_DELIVERY, ANONYMOUS-RELAY, SHARED-SUBS], properties={product=QpidJMS, 
> version=0.40.0, platform=JVM: 11.0.1-internal, 
> 11.0.1-internal+0-adhoc..jdk11u-jdk-11.0.113, Oracle Corporation, OS: Linux, 
> 4.14.98, amd64}}
> [1270504454:0] <- Open{ containerId='Standalone_En6PorJudCHF9o6', 
> hostname='null', maxFrameSize=16384, channelMax=32767, idleTimeOut=8000, 
> outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=[ANONYMOUS-RELAY], desiredCapabilities=null, 
> properties={product=qpid-dispatch-router, version=1.6.0-SNAPSHOT, 
> qd.conn-id=1}}
> [1270504454:0] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:0] <- Begin{remoteChannel=0, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] <- Begin{remoteChannel=1, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=SENDER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=null, offeredCapabilities=null, 
> desiredCapabilities=[DELAYED_DELIVERY], properties=null}
> [1270504454:1] <- 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=0, offeredCapabilities=null, desiredCapabilities=null, 
> properties=null}
> [1270504454:0] <- Empty Fra

[jira] [Updated] (QPIDJMS-444) Heartbeating is affected by changes to wall clock time

2019-02-25 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/QPIDJMS-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiri Daněk updated QPIDJMS-444:
---
Description: 
Monotonic clock should be used, which will not be affected by changes to system 
time.

h3. reproducer

Change the date like this. edit: you have to do it twice.

{noformat}
$ date --set "$(date -d '1 hour')"
{noformat}

while the client is in operation (example uses 
https://github.com/rh-messaging/cli-java/tree/master/cli-qpid-jms)

{noformat}
$ PN_TRACE_FRM=1 java -jar 
~/Work/repos/cli-java/cli-qpid-jms/target/cli-qpid-jms-1.2.2-SNAPSHOT-LATEST.jar
 sender amqpws://localhost:1126 --address address/0 --log-msgs=dict --count=2 
--duration 999 --conn-heartbeat 1[1270504454:0] -> Open{ 
containerId='ID:fae6a385-77b2-4f3c-8c67-1ade8d303ed7:1', hostname='localhost', 
maxFrameSize=1048576, channelMax=32767, idleTimeOut=500, outgoingLocales=null, 
incomingLocales=null, offeredCapabilities=null, 
desiredCapabilities=[sole-connection-for-container, DELAYED_DELIVERY, 
ANONYMOUS-RELAY, SHARED-SUBS], properties={product=QpidJMS, version=0.40.0, 
platform=JVM: 11.0.1-internal, 11.0.1-internal+0-adhoc..jdk11u-jdk-11.0.113, 
Oracle Corporation, OS: Linux, 4.14.98, amd64}}
[1270504454:0] <- Open{ containerId='Standalone_En6PorJudCHF9o6', 
hostname='null', maxFrameSize=16384, channelMax=32767, idleTimeOut=8000, 
outgoingLocales=null, incomingLocales=null, 
offeredCapabilities=[ANONYMOUS-RELAY], desiredCapabilities=null, 
properties={product=qpid-dispatch-router, version=1.6.0-SNAPSHOT, qd.conn-id=1}}
[1270504454:0] -> Begin{remoteChannel=null, nextOutgoingId=1, 
incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
offeredCapabilities=null, desiredCapabilities=null, properties=null}
[1270504454:0] <- Begin{remoteChannel=0, nextOutgoingId=0, 
incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
offeredCapabilities=null, desiredCapabilities=null, properties=null}
[1270504454:1] -> Begin{remoteChannel=null, nextOutgoingId=1, 
incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
offeredCapabilities=null, desiredCapabilities=null, properties=null}
[1270504454:1] <- Begin{remoteChannel=1, nextOutgoingId=0, 
incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
offeredCapabilities=null, desiredCapabilities=null, properties=null}
[1270504454:1] -> 
Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
 handle=0, role=SENDER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST, 
source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
dynamicNodeProperties=null, distributionMode=null, filter=null, 
defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
amqp:released:list, amqp:modified:list], capabilities=null}, 
target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
maxMessageSize=null, offeredCapabilities=null, 
desiredCapabilities=[DELAYED_DELIVERY], properties=null}
[1270504454:1] <- 
Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
 handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
dynamicNodeProperties=null, distributionMode=null, filter=null, 
defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
amqp:released:list, amqp:modified:list], capabilities=null}, 
target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
maxMessageSize=0, offeredCapabilities=null, desiredCapabilities=null, 
properties=null}
[1270504454:0] <- Empty Frame

[...]

[1270504454:0] <- Empty Frame
[1270504454:0] <- Empty Frame
{noformat}

When time changes, observe exception

{noformat}
[1270504454:0] <- Close{error=Error{condition=amqp:resource-limit-exceeded, 
description='local-idle-timeout expired', info=null}}
[1270504454:0] -> Close{error=null}
11:08:49,009 ERROR Error while sending a message!
javax.jms.ResourceAllocationException: local-idle-timeout expired [condition = 
amqp:resource-limit-exceeded]
at 
org.apache.qpid.jms.provider.amqp.AmqpSupport.convertToException(AmqpSupport.java:146)
at 
org.apache.qpid.jms.provider.amqp.AmqpSupport.convertToException(AmqpSupport.java:118)
at 
org.apache.qpid.jms.provider.amqp.AmqpConnection.processRemoteClose(AmqpConnection.java:150)
at 
org.apache.qpid.jms.provider.amqp.AmqpProvider.processUpdates(AmqpProvider.java:914)
  

[jira] [Comment Edited] (QPIDJMS-444) Heartbeating is affected by changes to wall clock time

2019-02-25 Thread JIRA


[ 
https://issues.apache.org/jira/browse/QPIDJMS-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776901#comment-16776901
 ] 

Jiri Daněk edited comment on QPIDJMS-444 at 2/25/19 2:03 PM:
-

I can reproduce this on two different machines, changing clock only on the 
qpid-jms machine and leaving qdrouterd be. I haven't realized I cannot simplify 
it on one machine, due to the possible interference.

bq. more likely something around the threading or when the first heartbeat is 
sent (your logs suggest one wasn't?).

There was, it was in the [...] elided section.

I'll go gather better logs, then.

About DISPATCH-1270 interacting. Maybe, maybe not, I later found DISPATCH-1271, 
which states my conclusion that the wrong {{pn_transport_tick}} code is not 
being executed at all, due to different bug.


was (Author: jdanek):
I can reproduce this on two different machines, changing clock only on the 
qpid-jms machine and leaving qdrouterd be. I haven't realized I cannot describe 
it on one machine, due to the possible interference.

bq. more likely something around the threading or when the first heartbeat is 
sent (your logs suggest one wasn't?).

There was, it was in the [...] elided section.

I'll go gather better logs, then.

About DISPATCH-1270 interacting. Maybe, maybe not, I later found DISPATCH-1271, 
which states my conclusion that the wrong {{pn_transport_tick}} code is not 
being executed at all, due to different bug.

> Heartbeating is affected by changes to wall clock time
> --
>
> Key: QPIDJMS-444
> URL: https://issues.apache.org/jira/browse/QPIDJMS-444
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.40.0
>Reporter: Jiri Daněk
>Priority: Minor
>
> Monotonic clock should be used, which will not be affected by changes to 
> system time.
> h3. reproducer
> Change the date like this. edit: you have to do it twice.
> {noformat}
> $ date --set "$(date -d '1 hour')"
> {noformat}
> while the client is in operation (example uses 
> https://github.com/rh-messaging/cli-java/tree/master/cli-qpid-jms)
> {noformat}
> $ PN_TRACE_FRM=1 java -jar 
> ~/Work/repos/cli-java/cli-qpid-jms/target/cli-qpid-jms-1.2.2-SNAPSHOT-LATEST.jar
>  sender amqpws://localhost:1126 --address address/0 --log-msgs=dict --count=2 
> --duration 999 --conn-heartbeat 1[1270504454:0] -> Open{ 
> containerId='ID:fae6a385-77b2-4f3c-8c67-1ade8d303ed7:1', 
> hostname='localhost', maxFrameSize=1048576, channelMax=32767, 
> idleTimeOut=500, outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=null, desiredCapabilities=[sole-connection-for-container, 
> DELAYED_DELIVERY, ANONYMOUS-RELAY, SHARED-SUBS], properties={product=QpidJMS, 
> version=0.40.0, platform=JVM: 11.0.1-internal, 
> 11.0.1-internal+0-adhoc..jdk11u-jdk-11.0.113, Oracle Corporation, OS: Linux, 
> 4.14.98, amd64}}
> [1270504454:0] <- Open{ containerId='Standalone_En6PorJudCHF9o6', 
> hostname='null', maxFrameSize=16384, channelMax=32767, idleTimeOut=8000, 
> outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=[ANONYMOUS-RELAY], desiredCapabilities=null, 
> properties={product=qpid-dispatch-router, version=1.6.0-SNAPSHOT, 
> qd.conn-id=1}}
> [1270504454:0] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:0] <- Begin{remoteChannel=0, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] <- Begin{remoteChannel=1, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=SENDER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUn

[jira] [Commented] (QPIDJMS-444) Heartbeating is affected by changes to wall clock time

2019-02-25 Thread JIRA


[ 
https://issues.apache.org/jira/browse/QPIDJMS-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776901#comment-16776901
 ] 

Jiri Daněk commented on QPIDJMS-444:


I can reproduce this on two different machines, changing clock only on the 
qpid-jms machine and leaving qdrouterd be. I haven't realized I cannot describe 
it on one machine, due to the possible interference.

bq. more likely something around the threading or when the first heartbeat is 
sent (your logs suggest one wasn't?).

There was, it was in the [...] elided section.

I'll go gather better logs, then.

About DISPATCH-1270 interacting. Maybe, maybe not, I later found DISPATCH-1271, 
which states my conclusion that the wrong {{pn_transport_tick}} code is not 
being executed at all, due to different bug.

> Heartbeating is affected by changes to wall clock time
> --
>
> Key: QPIDJMS-444
> URL: https://issues.apache.org/jira/browse/QPIDJMS-444
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.40.0
>Reporter: Jiri Daněk
>Priority: Minor
>
> Monotonic clock should be used, which will not be affected by changes to 
> system time.
> h3. reproducer
> Change the date like this
> {noformat}
> $ date --set "$(date -d '1 hour')"
> {noformat}
> while the client is in operation (example uses 
> https://github.com/rh-messaging/cli-java/tree/master/cli-qpid-jms)
> {noformat}
> $ PN_TRACE_FRM=1 java -jar 
> ~/Work/repos/cli-java/cli-qpid-jms/target/cli-qpid-jms-1.2.2-SNAPSHOT-LATEST.jar
>  sender amqpws://localhost:1126 --address address/0 --log-msgs=dict --count=2 
> --duration 999 --conn-heartbeat 1[1270504454:0] -> Open{ 
> containerId='ID:fae6a385-77b2-4f3c-8c67-1ade8d303ed7:1', 
> hostname='localhost', maxFrameSize=1048576, channelMax=32767, 
> idleTimeOut=500, outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=null, desiredCapabilities=[sole-connection-for-container, 
> DELAYED_DELIVERY, ANONYMOUS-RELAY, SHARED-SUBS], properties={product=QpidJMS, 
> version=0.40.0, platform=JVM: 11.0.1-internal, 
> 11.0.1-internal+0-adhoc..jdk11u-jdk-11.0.113, Oracle Corporation, OS: Linux, 
> 4.14.98, amd64}}
> [1270504454:0] <- Open{ containerId='Standalone_En6PorJudCHF9o6', 
> hostname='null', maxFrameSize=16384, channelMax=32767, idleTimeOut=8000, 
> outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=[ANONYMOUS-RELAY], desiredCapabilities=null, 
> properties={product=qpid-dispatch-router, version=1.6.0-SNAPSHOT, 
> qd.conn-id=1}}
> [1270504454:0] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:0] <- Begin{remoteChannel=0, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] <- Begin{remoteChannel=1, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=SENDER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=null, offeredCapabilities=null, 
> desiredCapabilities=[DELAYED_DELIVERY], properties=null}
> [1270504454:1] <- 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durab

[jira] [Commented] (PROTON-2006) Qpid Proton cannot connect to Azure Service Bus 'amqp:connection:framing-error'

2019-02-25 Thread Oskar Christensson (JIRA)


[ 
https://issues.apache.org/jira/browse/PROTON-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776845#comment-16776845
 ] 

Oskar Christensson commented on PROTON-2006:


It would be great if someone could look at this!

> Qpid Proton cannot connect to Azure Service Bus 
> 'amqp:connection:framing-error'
> ---
>
> Key: PROTON-2006
> URL: https://issues.apache.org/jira/browse/PROTON-2006
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding, examples
>Affects Versions: proton-c-0.28.0
>Reporter: Oskar Christensson
>Priority: Minor
>
>  
> {code:java}
> amqp:connection:framing-error: SASL header mismatch: Insufficient data to 
> determine protocol [''] (connection aborted){code}
> We're trying to get a C++ connection to Azure Service Bus using AMQP with 
> QPID proton, and trying out the examples under qpid-proton/cpp/examples it 
> fails.
> Steps to reproduce:
>  # Clone qpid-proton
>  # Follow installation and make README
>  # Create new Service Bus Namespace in azure
>  # Create new Service Bus Queue in Azure with Sessions enabled
>  # Create a policy with all permissions
>  # `./service_bus -n .servicebus.windows.net -p  -k 
>  -e 
> Expected results:
> It should work according to the docs in the cpp/examples/service_bus.cpp docs
> Actual results:
> {code:java}
> amqp:connection:framing-error: SASL header mismatch: Insufficient data to 
> determine protocol [''] (connection aborted){code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (PROTON-2006) Qpid Proton cannot connect to Azure Service Bus 'amqp:connection:framing-error'

2019-02-25 Thread Oskar Christensson (JIRA)


 [ 
https://issues.apache.org/jira/browse/PROTON-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oskar Christensson updated PROTON-2006:
---
Priority: Major  (was: Minor)

> Qpid Proton cannot connect to Azure Service Bus 
> 'amqp:connection:framing-error'
> ---
>
> Key: PROTON-2006
> URL: https://issues.apache.org/jira/browse/PROTON-2006
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: cpp-binding, examples
>Affects Versions: proton-c-0.28.0
>Reporter: Oskar Christensson
>Priority: Major
>
>  
> {code:java}
> amqp:connection:framing-error: SASL header mismatch: Insufficient data to 
> determine protocol [''] (connection aborted){code}
> We're trying to get a C++ connection to Azure Service Bus using AMQP with 
> QPID proton, and trying out the examples under qpid-proton/cpp/examples it 
> fails.
> Steps to reproduce:
>  # Clone qpid-proton
>  # Follow installation and make README
>  # Create new Service Bus Namespace in azure
>  # Create new Service Bus Queue in Azure with Sessions enabled
>  # Create a policy with all permissions
>  # `./service_bus -n .servicebus.windows.net -p  -k 
>  -e 
> Expected results:
> It should work according to the docs in the cpp/examples/service_bus.cpp docs
> Actual results:
> {code:java}
> amqp:connection:framing-error: SASL header mismatch: Insufficient data to 
> determine protocol [''] (connection aborted){code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Comment Edited] (QPIDJMS-444) Heartbeating is affected by changes to wall clock time

2019-02-25 Thread Robbie Gemmell (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776765#comment-16776765
 ] 

Robbie Gemmell edited comment on QPIDJMS-444 at 2/25/19 11:31 AM:
--

The heartbeating decisions are already ticked from a monotonic clock source so 
thats not the issue, more likely something around the threading or when the 
first heartbeat is sent (your logs suggest one wasnt?).

Alternatively, you seem to be connecting to localhost, so it could even be the 
peer in error since you changed the time for both sides. EDIT. Yeah, so I see 
you also raised DISPATCH-1270, which would interact here.


was (Author: gemmellr):
The heartbeating decisions are already ticked from a monotonic clock source so 
thats not the issue, more likely something around the threading or when the 
first heartbeat is sent (your logs suggest one wasnt?).

Alternatively, you seem to be connecting to localhost, so it could even be the 
peer in error since you changed the time for both sides.

> Heartbeating is affected by changes to wall clock time
> --
>
> Key: QPIDJMS-444
> URL: https://issues.apache.org/jira/browse/QPIDJMS-444
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.40.0
>Reporter: Jiri Daněk
>Priority: Minor
>
> Monotonic clock should be used, which will not be affected by changes to 
> system time.
> h3. reproducer
> Change the date like this
> {noformat}
> $ date --set "$(date -d '1 hour')"
> {noformat}
> while the client is in operation (example uses 
> https://github.com/rh-messaging/cli-java/tree/master/cli-qpid-jms)
> {noformat}
> $ PN_TRACE_FRM=1 java -jar 
> ~/Work/repos/cli-java/cli-qpid-jms/target/cli-qpid-jms-1.2.2-SNAPSHOT-LATEST.jar
>  sender amqpws://localhost:1126 --address address/0 --log-msgs=dict --count=2 
> --duration 999 --conn-heartbeat 1[1270504454:0] -> Open{ 
> containerId='ID:fae6a385-77b2-4f3c-8c67-1ade8d303ed7:1', 
> hostname='localhost', maxFrameSize=1048576, channelMax=32767, 
> idleTimeOut=500, outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=null, desiredCapabilities=[sole-connection-for-container, 
> DELAYED_DELIVERY, ANONYMOUS-RELAY, SHARED-SUBS], properties={product=QpidJMS, 
> version=0.40.0, platform=JVM: 11.0.1-internal, 
> 11.0.1-internal+0-adhoc..jdk11u-jdk-11.0.113, Oracle Corporation, OS: Linux, 
> 4.14.98, amd64}}
> [1270504454:0] <- Open{ containerId='Standalone_En6PorJudCHF9o6', 
> hostname='null', maxFrameSize=16384, channelMax=32767, idleTimeOut=8000, 
> outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=[ANONYMOUS-RELAY], desiredCapabilities=null, 
> properties={product=qpid-dispatch-router, version=1.6.0-SNAPSHOT, 
> qd.conn-id=1}}
> [1270504454:0] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:0] <- Begin{remoteChannel=0, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] <- Begin{remoteChannel=1, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=SENDER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=null, offeredCapabilities=null, 
> desiredCapabilities=[DELAYED_DELIVERY], properties=null}
> [1270504454:1] <- 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=fal

[jira] [Commented] (QPIDJMS-444) Heartbeating is affected by changes to wall clock time

2019-02-25 Thread Robbie Gemmell (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776767#comment-16776767
 ] 

Robbie Gemmell commented on QPIDJMS-444:


Timestamped logs from the client loggers (rather than PN_TRACE_FRM) would also 
be more useful in such situations, see 
http://qpid.apache.org/releases/qpid-jms-0.40.0/docs/index.html#logging

> Heartbeating is affected by changes to wall clock time
> --
>
> Key: QPIDJMS-444
> URL: https://issues.apache.org/jira/browse/QPIDJMS-444
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.40.0
>Reporter: Jiri Daněk
>Priority: Minor
>
> Monotonic clock should be used, which will not be affected by changes to 
> system time.
> h3. reproducer
> Change the date like this
> {noformat}
> $ date --set "$(date -d '1 hour')"
> {noformat}
> while the client is in operation (example uses 
> https://github.com/rh-messaging/cli-java/tree/master/cli-qpid-jms)
> {noformat}
> $ PN_TRACE_FRM=1 java -jar 
> ~/Work/repos/cli-java/cli-qpid-jms/target/cli-qpid-jms-1.2.2-SNAPSHOT-LATEST.jar
>  sender amqpws://localhost:1126 --address address/0 --log-msgs=dict --count=2 
> --duration 999 --conn-heartbeat 1[1270504454:0] -> Open{ 
> containerId='ID:fae6a385-77b2-4f3c-8c67-1ade8d303ed7:1', 
> hostname='localhost', maxFrameSize=1048576, channelMax=32767, 
> idleTimeOut=500, outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=null, desiredCapabilities=[sole-connection-for-container, 
> DELAYED_DELIVERY, ANONYMOUS-RELAY, SHARED-SUBS], properties={product=QpidJMS, 
> version=0.40.0, platform=JVM: 11.0.1-internal, 
> 11.0.1-internal+0-adhoc..jdk11u-jdk-11.0.113, Oracle Corporation, OS: Linux, 
> 4.14.98, amd64}}
> [1270504454:0] <- Open{ containerId='Standalone_En6PorJudCHF9o6', 
> hostname='null', maxFrameSize=16384, channelMax=32767, idleTimeOut=8000, 
> outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=[ANONYMOUS-RELAY], desiredCapabilities=null, 
> properties={product=qpid-dispatch-router, version=1.6.0-SNAPSHOT, 
> qd.conn-id=1}}
> [1270504454:0] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:0] <- Begin{remoteChannel=0, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] <- Begin{remoteChannel=1, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=SENDER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=null, offeredCapabilities=null, 
> desiredCapabilities=[DELAYED_DELIVERY], properties=null}
> [1270504454:1] <- 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=0, offeredCapabilities=null, desiredCapabilities=null, 
> properties=null}
> [1270504454:0] <- Empty Frame
> [...]
> [1270504454:0] <- Empty Frame
> [1270504454:0] <- Empty Frame
> {noformat}
> When time changes,

[jira] [Commented] (QPIDJMS-444) Heartbeating is affected by changes to wall clock time

2019-02-25 Thread Robbie Gemmell (JIRA)


[ 
https://issues.apache.org/jira/browse/QPIDJMS-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776765#comment-16776765
 ] 

Robbie Gemmell commented on QPIDJMS-444:


The heartbeating decisions are already ticked from a monotonic clock source so 
thats not the issue, more likely something around the threading or when the 
first heartbeat is sent (your logs suggest one wasnt?).

Alternatively, you seem to be connecting to localhost, so it could even be the 
peer in error since you changed the time for both sides.

> Heartbeating is affected by changes to wall clock time
> --
>
> Key: QPIDJMS-444
> URL: https://issues.apache.org/jira/browse/QPIDJMS-444
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.40.0
>Reporter: Jiri Daněk
>Priority: Minor
>
> Monotonic clock should be used, which will not be affected by changes to 
> system time.
> h3. reproducer
> Change the date like this
> {noformat}
> $ date --set "$(date -d '1 hour')"
> {noformat}
> while the client is in operation (example uses 
> https://github.com/rh-messaging/cli-java/tree/master/cli-qpid-jms)
> {noformat}
> $ PN_TRACE_FRM=1 java -jar 
> ~/Work/repos/cli-java/cli-qpid-jms/target/cli-qpid-jms-1.2.2-SNAPSHOT-LATEST.jar
>  sender amqpws://localhost:1126 --address address/0 --log-msgs=dict --count=2 
> --duration 999 --conn-heartbeat 1[1270504454:0] -> Open{ 
> containerId='ID:fae6a385-77b2-4f3c-8c67-1ade8d303ed7:1', 
> hostname='localhost', maxFrameSize=1048576, channelMax=32767, 
> idleTimeOut=500, outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=null, desiredCapabilities=[sole-connection-for-container, 
> DELAYED_DELIVERY, ANONYMOUS-RELAY, SHARED-SUBS], properties={product=QpidJMS, 
> version=0.40.0, platform=JVM: 11.0.1-internal, 
> 11.0.1-internal+0-adhoc..jdk11u-jdk-11.0.113, Oracle Corporation, OS: Linux, 
> 4.14.98, amd64}}
> [1270504454:0] <- Open{ containerId='Standalone_En6PorJudCHF9o6', 
> hostname='null', maxFrameSize=16384, channelMax=32767, idleTimeOut=8000, 
> outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=[ANONYMOUS-RELAY], desiredCapabilities=null, 
> properties={product=qpid-dispatch-router, version=1.6.0-SNAPSHOT, 
> qd.conn-id=1}}
> [1270504454:0] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:0] <- Begin{remoteChannel=0, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] <- Begin{remoteChannel=1, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=SENDER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=null, offeredCapabilities=null, 
> desiredCapabilities=[DELAYED_DELIVERY], properties=null}
> [1270504454:1] <- 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=0, offeredCapabilities=null, desiredCapabilities=null

[jira] [Commented] (DISPATCH-1155) dueling httpRootDirs

2019-02-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776724#comment-16776724
 ] 

ASF GitHub Bot commented on DISPATCH-1155:
--

codecov-io commented on issue #451: NO-JIRA - Update doc for httpRootDir 
default value removal (DISPATCH-1155)
URL: https://github.com/apache/qpid-dispatch/pull/451#issuecomment-466954539
 
 
   # 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=h1) 
Report
   > Merging 
[#451](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/8e4bd11915963354e106e654a48891c468dbbf27?src=pr&el=desc)
 will **decrease** coverage by `0.04%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-dispatch/pull/451/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #451  +/-   ##
   ==
   - Coverage   86.81%   86.77%   -0.05% 
   ==
 Files  85   85  
 Lines   1875418754  
   ==
   - Hits1628216274   -8 
   - Misses   2472 2480   +8
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==)
 | `92.67% <0%> (-1.28%)` | :arrow_down: |
   | 
[src/remote\_sasl.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JlbW90ZV9zYXNsLmM=)
 | `82.77% <0%> (-1.12%)` | :arrow_down: |
   | 
[src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j)
 | `91.57% <0%> (-0.37%)` | :arrow_down: |
   | 
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
 | `88.29% <0%> (-0.26%)` | :arrow_down: |
   | 
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
 | `93.96% <0%> (-0.13%)` | :arrow_down: |
   | 
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
 | `76.92% <0%> (+0.24%)` | :arrow_up: |
   | 
[...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j)
 | `84.21% <0%> (+1.16%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=footer).
 Last update 
[8e4bd11...7c7db02](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> dueling httpRootDirs
> 
>
> Key: DISPATCH-1155
> URL: https://issues.apache.org/jira/browse/DISPATCH-1155
> Project: Qpid Dispatch
>  Issue Type: Bug
>Reporter: michael goulish
>Assignee: michael goulish
>Priority: Major
> Fix For: 1.5.0
>
>
> New version of qpid-dispatch-router uses 
> "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir. 
> But when installing new qpid-dispatch-console package, the pages are 
> available at "/usr/share/qpid-dispatch/console".
> This forces the user to define httpRootDir on the listener to bypass this 
> issue.
> Ted suggests this fix:
>  
> Remove the default behavior for httpRootDir. If it is not specified in the 
> configuration for a listener, then HTTP requests shall be rejected on 
> connections to that listener. Such a listener would only be usable for AMQP 
> over websockets.



--
Th

[GitHub] codecov-io edited a comment on issue #451: NO-JIRA - Update doc for httpRootDir default value removal (DISPATCH-1155)

2019-02-25 Thread GitBox
codecov-io edited a comment on issue #451: NO-JIRA - Update doc for httpRootDir 
default value removal (DISPATCH-1155)
URL: https://github.com/apache/qpid-dispatch/pull/451#issuecomment-466954539
 
 
   # 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=h1) 
Report
   > Merging 
[#451](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/8e4bd11915963354e106e654a48891c468dbbf27?src=pr&el=desc)
 will **decrease** coverage by `0.04%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-dispatch/pull/451/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #451  +/-   ##
   ==
   - Coverage   86.81%   86.77%   -0.05% 
   ==
 Files  85   85  
 Lines   1875418754  
   ==
   - Hits1628216274   -8 
   - Misses   2472 2480   +8
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==)
 | `92.67% <0%> (-1.28%)` | :arrow_down: |
   | 
[src/remote\_sasl.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JlbW90ZV9zYXNsLmM=)
 | `82.77% <0%> (-1.12%)` | :arrow_down: |
   | 
[src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j)
 | `91.57% <0%> (-0.37%)` | :arrow_down: |
   | 
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
 | `88.29% <0%> (-0.26%)` | :arrow_down: |
   | 
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
 | `93.96% <0%> (-0.13%)` | :arrow_down: |
   | 
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
 | `76.92% <0%> (+0.24%)` | :arrow_up: |
   | 
[...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j)
 | `84.21% <0%> (+1.16%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=footer).
 Last update 
[8e4bd11...7c7db02](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1155) dueling httpRootDirs

2019-02-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776713#comment-16776713
 ] 

ASF GitHub Bot commented on DISPATCH-1155:
--

codecov-io commented on issue #451: NO-JIRA - Update doc for httpRootDir 
default value removal (DISPATCH-1155)
URL: https://github.com/apache/qpid-dispatch/pull/451#issuecomment-466954539
 
 
   # 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=h1) 
Report
   > Merging 
[#451](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/8e4bd11915963354e106e654a48891c468dbbf27?src=pr&el=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-dispatch/pull/451/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #451  +/-   ##
   ==
   + Coverage   86.81%   86.84%   +0.02% 
   ==
 Files  85   85  
 Lines   1875418754  
   ==
   + Hits1628216286   +4 
   + Misses   2472 2468   -4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
 | `63.84% <0%> (-0.57%)` | :arrow_down: |
   | 
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
 | `93.92% <0%> (+0.7%)` | :arrow_up: |
   | 
[...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j)
 | `84.21% <0%> (+1.16%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=footer).
 Last update 
[8e4bd11...7c7db02](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> dueling httpRootDirs
> 
>
> Key: DISPATCH-1155
> URL: https://issues.apache.org/jira/browse/DISPATCH-1155
> Project: Qpid Dispatch
>  Issue Type: Bug
>Reporter: michael goulish
>Assignee: michael goulish
>Priority: Major
> Fix For: 1.5.0
>
>
> New version of qpid-dispatch-router uses 
> "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir. 
> But when installing new qpid-dispatch-console package, the pages are 
> available at "/usr/share/qpid-dispatch/console".
> This forces the user to define httpRootDir on the listener to bypass this 
> issue.
> Ted suggests this fix:
>  
> Remove the default behavior for httpRootDir. If it is not specified in the 
> configuration for a listener, then HTTP requests shall be rejected on 
> connections to that listener. Such a listener would only be usable for AMQP 
> over websockets.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] codecov-io commented on issue #451: NO-JIRA - Update doc for httpRootDir default value removal (DISPATCH-1155)

2019-02-25 Thread GitBox
codecov-io commented on issue #451: NO-JIRA - Update doc for httpRootDir 
default value removal (DISPATCH-1155)
URL: https://github.com/apache/qpid-dispatch/pull/451#issuecomment-466954539
 
 
   # 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=h1) 
Report
   > Merging 
[#451](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/8e4bd11915963354e106e654a48891c468dbbf27?src=pr&el=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-dispatch/pull/451/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #451  +/-   ##
   ==
   + Coverage   86.81%   86.84%   +0.02% 
   ==
 Files  85   85  
 Lines   1875418754  
   ==
   + Hits1628216286   +4 
   + Misses   2472 2468   -4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
 | `63.84% <0%> (-0.57%)` | :arrow_down: |
   | 
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
 | `93.92% <0%> (+0.7%)` | :arrow_up: |
   | 
[...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j)
 | `84.21% <0%> (+1.16%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=footer).
 Last update 
[8e4bd11...7c7db02](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1155) dueling httpRootDirs

2019-02-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776700#comment-16776700
 ] 

ASF GitHub Bot commented on DISPATCH-1155:
--

jdanekrh commented on pull request #451: NO-JIRA - Update doc for httpRootDir 
default value removal (DISPATCH-1155)
URL: https://github.com/apache/qpid-dispatch/pull/451
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> dueling httpRootDirs
> 
>
> Key: DISPATCH-1155
> URL: https://issues.apache.org/jira/browse/DISPATCH-1155
> Project: Qpid Dispatch
>  Issue Type: Bug
>Reporter: michael goulish
>Assignee: michael goulish
>Priority: Major
> Fix For: 1.5.0
>
>
> New version of qpid-dispatch-router uses 
> "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir. 
> But when installing new qpid-dispatch-console package, the pages are 
> available at "/usr/share/qpid-dispatch/console".
> This forces the user to define httpRootDir on the listener to bypass this 
> issue.
> Ted suggests this fix:
>  
> Remove the default behavior for httpRootDir. If it is not specified in the 
> configuration for a listener, then HTTP requests shall be rejected on 
> connections to that listener. Such a listener would only be usable for AMQP 
> over websockets.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] jdanekrh opened a new pull request #451: NO-JIRA - Update doc for httpRootDir default value removal (DISPATCH-1155)

2019-02-25 Thread GitBox
jdanekrh opened a new pull request #451: NO-JIRA - Update doc for httpRootDir 
default value removal (DISPATCH-1155)
URL: https://github.com/apache/qpid-dispatch/pull/451
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (DISPATCH-1270) Inapropriate use of CLOCK_REALTIME for periodic timer

2019-02-25 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/DISPATCH-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiri Daněk updated DISPATCH-1270:
-
Priority: Trivial  (was: Major)

> Inapropriate use of CLOCK_REALTIME for periodic timer
> -
>
> Key: DISPATCH-1270
> URL: https://issues.apache.org/jira/browse/DISPATCH-1270
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Jiri Daněk
>Priority: Trivial
>
> Similarly to Qpid Cpp broker (QPID-5865, QPID-6698), Qpid Dispatch router 
> currently uses CLOCK_REALTIME where CLOCK_MONOTONIC would be more appropriate.
> This wrong usage was highlighted by PROTON-985 which clarified that 
> {{pn_transport_tick}} should be given monotonic timestamp.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (QPID-8239) [Broker-J] Release Qpid Broker-J 7.0.7

2019-02-25 Thread Alex Rudyy (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-8239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy reassigned QPID-8239:


Assignee: Alex Rudyy

> [Broker-J] Release Qpid Broker-J 7.0.7
> --
>
> Key: QPID-8239
> URL: https://issues.apache.org/jira/browse/QPID-8239
> Project: Qpid
>  Issue Type: Task
>  Components: Broker-J
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.0.7
>
>
> Release Qpid Broker-J following instructions provided at 
> [https://cwiki.apache.org/confluence/display/qpid/Releasing+Qpid+Broker-J]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Updated] (QPID-8273) [Broker-J][AMQP 0-8..0-91] Broker can crash with BufferOverflowException when sending message to consumer

2019-02-25 Thread Alex Rudyy (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-8273:
-
Status: Reviewable  (was: In Progress)

> [Broker-J][AMQP 0-8..0-91] Broker can crash with BufferOverflowException when 
> sending message to consumer
> -
>
> Key: QPID-8273
> URL: https://issues.apache.org/jira/browse/QPID-8273
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3, 
> qpid-java-broker-7.0.2, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2, 
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1, 
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7, 
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0, 
> qpid-java-6.1.5, qpid-java-broker-7.0.1, qpid-java-6.1.7, 
> qpid-java-broker-7.1.0, qpid-java-broker-7.0.4, qpid-java-broker-7.0.5, 
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Critical
> Fix For: qpid-java-broker-7.0.7, qpid-java-broker-7.1.1
>
>
> Broker can crash with BufferOverflowException when sending message to 
> consumer. The stack trace like the one below is reported into Qpid Broker 
> logs.
> {noformat}
> (o.a.q.s.Main) - Uncaught exception, shutting down.
> java.nio.BufferOverflowException: null
>   at java.nio.Buffer.nextPutIndex(Buffer.java:527)
>   at java.nio.DirectByteBuffer.putLong(DirectByteBuffer.java:797)
>   at 
> org.apache.qpid.bytebuffer.QpidByteBuffer.putLong(QpidByteBuffer.java:500)
>   at 
> org.apache.qpid.framing.BasicContentHeaderProperties.writePropertyListPayload(BasicContentHeaderProperties.java:293)
>   at 
> org.apache.qpid.framing.BasicContentHeaderProperties.writePropertyListPayload(BasicContentHeaderProperties.java:471)
>   at 
> org.apache.qpid.framing.ContentHeaderBody.writePayload(ContentHeaderBody.java:100)
>   at org.apache.qpid.framing.AMQFrame.writePayload(AMQFrame.java:69)
>   at 
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl$CompositeAMQBodyBlock.writePayload(ProtocolOutputConverterImpl.java:542)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl.writeFrame(AMQPConnection_0_8Impl.java:382)
>   at 
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeFrame(ProtocolOutputConverterImpl.java:501)
>   at 
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDeliveryUnchanged(ProtocolOutputConverterImpl.java:227)
>   at 
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDelivery(ProtocolOutputConverterImpl.java:138)
>   at 
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDelivery(ProtocolOutputConverterImpl.java:95)
>   at 
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeDeliver(ProtocolOutputConverterImpl.java:72)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$WriteDeliverMethod.deliverToClient(AMQPConnection_0_8Impl.java:1275)
>   at 
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.sendToClient(ConsumerTarget_0_8.java:452)
>   at 
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8$AckConsumer.doSend(ConsumerTarget_0_8.java:274)
>   at 
> org.apache.qpid.server.consumer.AbstractConsumerTarget.sendNextMessage(AbstractConsumerTarget.java:327)
>   at 
> org.apache.qpid.server.consumer.AbstractConsumerTarget.processPending(AbstractConsumerTarget.java:99)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.processPending(AMQChannel.java:3797)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$ProcessPendingIterator$1.run(AMQPConnection_0_8Impl.java:1447)
>   at 
> org.apache.qpid.server.transport.NonBlockingConnection.processPending(NonBlockingConnection.java:375)
>   at 
> org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:279)
>   at 
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:130)
>   at 
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:563)
>   at 
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.run(SelectorThread.java:551)
>   at 
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:521)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message wa

[jira] [Assigned] (QPID-8277) [Broker-J] Release Qpid Broker-J 7.1.1

2019-02-25 Thread Alex Rudyy (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-8277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy reassigned QPID-8277:


Assignee: Alex Rudyy

> [Broker-J] Release Qpid Broker-J 7.1.1
> --
>
> Key: QPID-8277
> URL: https://issues.apache.org/jira/browse/QPID-8277
> Project: Qpid
>  Issue Type: Task
>  Components: Broker-J
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Major
> Fix For: qpid-java-broker-7.1.1
>
>
> Release Qpid Broker-J following instructions provided at 
> [https://cwiki.apache.org/confluence/display/qpid/Releasing+Qpid+Broker-J]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Assigned] (QPID-8273) [Broker-J][AMQP 0-8..0-91] Broker can crash with BufferOverflowException when sending message to consumer

2019-02-25 Thread Alex Rudyy (JIRA)


 [ 
https://issues.apache.org/jira/browse/QPID-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy reassigned QPID-8273:


Assignee: Alex Rudyy

> [Broker-J][AMQP 0-8..0-91] Broker can crash with BufferOverflowException when 
> sending message to consumer
> -
>
> Key: QPID-8273
> URL: https://issues.apache.org/jira/browse/QPID-8273
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3, 
> qpid-java-broker-7.0.2, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2, 
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1, 
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7, 
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0, 
> qpid-java-6.1.5, qpid-java-broker-7.0.1, qpid-java-6.1.7, 
> qpid-java-broker-7.1.0, qpid-java-broker-7.0.4, qpid-java-broker-7.0.5, 
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Critical
> Fix For: qpid-java-broker-7.0.7, qpid-java-broker-7.1.1
>
>
> Broker can crash with BufferOverflowException when sending message to 
> consumer. The stack trace like the one below is reported into Qpid Broker 
> logs.
> {noformat}
> (o.a.q.s.Main) - Uncaught exception, shutting down.
> java.nio.BufferOverflowException: null
>   at java.nio.Buffer.nextPutIndex(Buffer.java:527)
>   at java.nio.DirectByteBuffer.putLong(DirectByteBuffer.java:797)
>   at 
> org.apache.qpid.bytebuffer.QpidByteBuffer.putLong(QpidByteBuffer.java:500)
>   at 
> org.apache.qpid.framing.BasicContentHeaderProperties.writePropertyListPayload(BasicContentHeaderProperties.java:293)
>   at 
> org.apache.qpid.framing.BasicContentHeaderProperties.writePropertyListPayload(BasicContentHeaderProperties.java:471)
>   at 
> org.apache.qpid.framing.ContentHeaderBody.writePayload(ContentHeaderBody.java:100)
>   at org.apache.qpid.framing.AMQFrame.writePayload(AMQFrame.java:69)
>   at 
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl$CompositeAMQBodyBlock.writePayload(ProtocolOutputConverterImpl.java:542)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl.writeFrame(AMQPConnection_0_8Impl.java:382)
>   at 
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeFrame(ProtocolOutputConverterImpl.java:501)
>   at 
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDeliveryUnchanged(ProtocolOutputConverterImpl.java:227)
>   at 
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDelivery(ProtocolOutputConverterImpl.java:138)
>   at 
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDelivery(ProtocolOutputConverterImpl.java:95)
>   at 
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeDeliver(ProtocolOutputConverterImpl.java:72)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$WriteDeliverMethod.deliverToClient(AMQPConnection_0_8Impl.java:1275)
>   at 
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.sendToClient(ConsumerTarget_0_8.java:452)
>   at 
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8$AckConsumer.doSend(ConsumerTarget_0_8.java:274)
>   at 
> org.apache.qpid.server.consumer.AbstractConsumerTarget.sendNextMessage(AbstractConsumerTarget.java:327)
>   at 
> org.apache.qpid.server.consumer.AbstractConsumerTarget.processPending(AbstractConsumerTarget.java:99)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.processPending(AMQChannel.java:3797)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$ProcessPendingIterator$1.run(AMQPConnection_0_8Impl.java:1447)
>   at 
> org.apache.qpid.server.transport.NonBlockingConnection.processPending(NonBlockingConnection.java:375)
>   at 
> org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:279)
>   at 
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:130)
>   at 
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:563)
>   at 
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.run(SelectorThread.java:551)
>   at 
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:521)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by A

[jira] [Commented] (QPID-8273) [Broker-J][AMQP 0-8..0-91] Broker can crash with BufferOverflowException when sending message to consumer

2019-02-25 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/QPID-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776674#comment-16776674
 ] 

ASF subversion and git services commented on QPID-8273:
---

Commit 9c6440805791e21b8c9d8982f6790b16763a593e in qpid-broker-j's branch 
refs/heads/7.0.x from Alex Rudyy
[ https://gitbox.apache.org/repos/asf?p=qpid-broker-j.git;h=9c64408 ]

QPID-8273: [Broker-J] Add missing changes


> [Broker-J][AMQP 0-8..0-91] Broker can crash with BufferOverflowException when 
> sending message to consumer
> -
>
> Key: QPID-8273
> URL: https://issues.apache.org/jira/browse/QPID-8273
> Project: Qpid
>  Issue Type: Bug
>  Components: Broker-J
>Affects Versions: qpid-java-6.1.6, qpid-java-broker-7.0.3, 
> qpid-java-broker-7.0.2, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2, 
> qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1, 
> qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-6.1.2, qpid-java-6.0.7, 
> qpid-java-6.1.3, qpid-java-6.0.8, qpid-java-6.1.4, qpid-java-broker-7.0.0, 
> qpid-java-6.1.5, qpid-java-broker-7.0.1, qpid-java-6.1.7, 
> qpid-java-broker-7.1.0, qpid-java-broker-7.0.4, qpid-java-broker-7.0.5, 
> qpid-java-broker-7.0.6
>Reporter: Alex Rudyy
>Priority: Critical
> Fix For: qpid-java-broker-7.0.7, qpid-java-broker-7.1.1
>
>
> Broker can crash with BufferOverflowException when sending message to 
> consumer. The stack trace like the one below is reported into Qpid Broker 
> logs.
> {noformat}
> (o.a.q.s.Main) - Uncaught exception, shutting down.
> java.nio.BufferOverflowException: null
>   at java.nio.Buffer.nextPutIndex(Buffer.java:527)
>   at java.nio.DirectByteBuffer.putLong(DirectByteBuffer.java:797)
>   at 
> org.apache.qpid.bytebuffer.QpidByteBuffer.putLong(QpidByteBuffer.java:500)
>   at 
> org.apache.qpid.framing.BasicContentHeaderProperties.writePropertyListPayload(BasicContentHeaderProperties.java:293)
>   at 
> org.apache.qpid.framing.BasicContentHeaderProperties.writePropertyListPayload(BasicContentHeaderProperties.java:471)
>   at 
> org.apache.qpid.framing.ContentHeaderBody.writePayload(ContentHeaderBody.java:100)
>   at org.apache.qpid.framing.AMQFrame.writePayload(AMQFrame.java:69)
>   at 
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl$CompositeAMQBodyBlock.writePayload(ProtocolOutputConverterImpl.java:542)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl.writeFrame(AMQPConnection_0_8Impl.java:382)
>   at 
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeFrame(ProtocolOutputConverterImpl.java:501)
>   at 
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDeliveryUnchanged(ProtocolOutputConverterImpl.java:227)
>   at 
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDelivery(ProtocolOutputConverterImpl.java:138)
>   at 
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeMessageDelivery(ProtocolOutputConverterImpl.java:95)
>   at 
> org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeDeliver(ProtocolOutputConverterImpl.java:72)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$WriteDeliverMethod.deliverToClient(AMQPConnection_0_8Impl.java:1275)
>   at 
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8.sendToClient(ConsumerTarget_0_8.java:452)
>   at 
> org.apache.qpid.server.protocol.v0_8.ConsumerTarget_0_8$AckConsumer.doSend(ConsumerTarget_0_8.java:274)
>   at 
> org.apache.qpid.server.consumer.AbstractConsumerTarget.sendNextMessage(AbstractConsumerTarget.java:327)
>   at 
> org.apache.qpid.server.consumer.AbstractConsumerTarget.processPending(AbstractConsumerTarget.java:99)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQChannel.processPending(AMQChannel.java:3797)
>   at 
> org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8Impl$ProcessPendingIterator$1.run(AMQPConnection_0_8Impl.java:1447)
>   at 
> org.apache.qpid.server.transport.NonBlockingConnection.processPending(NonBlockingConnection.java:375)
>   at 
> org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:279)
>   at 
> org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:130)
>   at 
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:563)
>   at 
> org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.run(SelectorThread.java:551)
>   at 
> org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:521)
>   at 
> java.util.co

[jira] [Updated] (QPIDJMS-444) Heartbeating is affected by changes to wall clock time

2019-02-25 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/QPIDJMS-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiri Daněk updated QPIDJMS-444:
---
Priority: Minor  (was: Major)

> Heartbeating is affected by changes to wall clock time
> --
>
> Key: QPIDJMS-444
> URL: https://issues.apache.org/jira/browse/QPIDJMS-444
> Project: Qpid JMS
>  Issue Type: Bug
>  Components: qpid-jms-client
>Affects Versions: 0.40.0
>Reporter: Jiri Daněk
>Priority: Minor
>
> Monotonic clock should be used, which will not be affected by changes to 
> system time.
> h3. reproducer
> Change the date like this
> {noformat}
> $ date --set "$(date -d '1 hour')"
> {noformat}
> while the client is in operation (example uses 
> https://github.com/rh-messaging/cli-java/tree/master/cli-qpid-jms)
> {noformat}
> $ PN_TRACE_FRM=1 java -jar 
> ~/Work/repos/cli-java/cli-qpid-jms/target/cli-qpid-jms-1.2.2-SNAPSHOT-LATEST.jar
>  sender amqpws://localhost:1126 --address address/0 --log-msgs=dict --count=2 
> --duration 999 --conn-heartbeat 1[1270504454:0] -> Open{ 
> containerId='ID:fae6a385-77b2-4f3c-8c67-1ade8d303ed7:1', 
> hostname='localhost', maxFrameSize=1048576, channelMax=32767, 
> idleTimeOut=500, outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=null, desiredCapabilities=[sole-connection-for-container, 
> DELAYED_DELIVERY, ANONYMOUS-RELAY, SHARED-SUBS], properties={product=QpidJMS, 
> version=0.40.0, platform=JVM: 11.0.1-internal, 
> 11.0.1-internal+0-adhoc..jdk11u-jdk-11.0.113, Oracle Corporation, OS: Linux, 
> 4.14.98, amd64}}
> [1270504454:0] <- Open{ containerId='Standalone_En6PorJudCHF9o6', 
> hostname='null', maxFrameSize=16384, channelMax=32767, idleTimeOut=8000, 
> outgoingLocales=null, incomingLocales=null, 
> offeredCapabilities=[ANONYMOUS-RELAY], desiredCapabilities=null, 
> properties={product=qpid-dispatch-router, version=1.6.0-SNAPSHOT, 
> qd.conn-id=1}}
> [1270504454:0] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:0] <- Begin{remoteChannel=0, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> Begin{remoteChannel=null, nextOutgoingId=1, 
> incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] <- Begin{remoteChannel=1, nextOutgoingId=0, 
> incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
> offeredCapabilities=null, desiredCapabilities=null, properties=null}
> [1270504454:1] -> 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=SENDER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=null, offeredCapabilities=null, 
> desiredCapabilities=[DELAYED_DELIVERY], properties=null}
> [1270504454:1] <- 
> Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
>  handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
> source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
> durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
> dynamicNodeProperties=null, distributionMode=null, filter=null, 
> defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
> amqp:released:list, amqp:modified:list], capabilities=null}, 
> target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
> timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
> unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
> maxMessageSize=0, offeredCapabilities=null, desiredCapabilities=null, 
> properties=null}
> [1270504454:0] <- Empty Frame
> [...]
> [1270504454:0] <- Empty Frame
> [1270504454:0] <- Empty Frame
> {noformat}
> When time changes, observe exception
> {noformat}
> [1270504454:0] <- Close{error=Error{condition=amqp:resource-limit-exceeded, 
> description='local-idle-timeout expired', info=null}}
> [1270504454:0] -> Close{error=null}
> 11:08:49,009 ERRO

[jira] [Created] (QPIDJMS-444) Heartbeating is affected by changes to wall clock time

2019-02-25 Thread JIRA
Jiri Daněk created QPIDJMS-444:
--

 Summary: Heartbeating is affected by changes to wall clock time
 Key: QPIDJMS-444
 URL: https://issues.apache.org/jira/browse/QPIDJMS-444
 Project: Qpid JMS
  Issue Type: Bug
  Components: qpid-jms-client
Affects Versions: 0.40.0
Reporter: Jiri Daněk


Monotonic clock should be used, which will not be affected by changes to system 
time.

h3. reproducer

Change the date like this

{noformat}
$ date --set "$(date -d '1 hour')"
{noformat}

while the client is in operation (example uses 
https://github.com/rh-messaging/cli-java/tree/master/cli-qpid-jms)

{noformat}
$ PN_TRACE_FRM=1 java -jar 
~/Work/repos/cli-java/cli-qpid-jms/target/cli-qpid-jms-1.2.2-SNAPSHOT-LATEST.jar
 sender amqpws://localhost:1126 --address address/0 --log-msgs=dict --count=2 
--duration 999 --conn-heartbeat 1[1270504454:0] -> Open{ 
containerId='ID:fae6a385-77b2-4f3c-8c67-1ade8d303ed7:1', hostname='localhost', 
maxFrameSize=1048576, channelMax=32767, idleTimeOut=500, outgoingLocales=null, 
incomingLocales=null, offeredCapabilities=null, 
desiredCapabilities=[sole-connection-for-container, DELAYED_DELIVERY, 
ANONYMOUS-RELAY, SHARED-SUBS], properties={product=QpidJMS, version=0.40.0, 
platform=JVM: 11.0.1-internal, 11.0.1-internal+0-adhoc..jdk11u-jdk-11.0.113, 
Oracle Corporation, OS: Linux, 4.14.98, amd64}}
[1270504454:0] <- Open{ containerId='Standalone_En6PorJudCHF9o6', 
hostname='null', maxFrameSize=16384, channelMax=32767, idleTimeOut=8000, 
outgoingLocales=null, incomingLocales=null, 
offeredCapabilities=[ANONYMOUS-RELAY], desiredCapabilities=null, 
properties={product=qpid-dispatch-router, version=1.6.0-SNAPSHOT, qd.conn-id=1}}
[1270504454:0] -> Begin{remoteChannel=null, nextOutgoingId=1, 
incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
offeredCapabilities=null, desiredCapabilities=null, properties=null}
[1270504454:0] <- Begin{remoteChannel=0, nextOutgoingId=0, 
incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
offeredCapabilities=null, desiredCapabilities=null, properties=null}
[1270504454:1] -> Begin{remoteChannel=null, nextOutgoingId=1, 
incomingWindow=2047, outgoingWindow=2147483647, handleMax=65535, 
offeredCapabilities=null, desiredCapabilities=null, properties=null}
[1270504454:1] <- Begin{remoteChannel=1, nextOutgoingId=0, 
incomingWindow=2147483647, outgoingWindow=2147483647, handleMax=4294967295, 
offeredCapabilities=null, desiredCapabilities=null, properties=null}
[1270504454:1] -> 
Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
 handle=0, role=SENDER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST, 
source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
dynamicNodeProperties=null, distributionMode=null, filter=null, 
defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
amqp:released:list, amqp:modified:list], capabilities=null}, 
target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
maxMessageSize=null, offeredCapabilities=null, 
desiredCapabilities=[DELAYED_DELIVERY], properties=null}
[1270504454:1] <- 
Attach{name='qpid-jms:sender:ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1:address/0',
 handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST, 
source=Source{address='ID:b7a729e4-202f-4822-9b04-a151539493db:1:1:1', 
durable=NONE, expiryPolicy=SESSION_END, timeout=0, dynamic=false, 
dynamicNodeProperties=null, distributionMode=null, filter=null, 
defaultOutcome=null, outcomes=[amqp:accepted:list, amqp:rejected:list, 
amqp:released:list, amqp:modified:list], capabilities=null}, 
target=Target{address='address/0', durable=NONE, expiryPolicy=SESSION_END, 
timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=[queue]}, 
unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0, 
maxMessageSize=0, offeredCapabilities=null, desiredCapabilities=null, 
properties=null}
[1270504454:0] <- Empty Frame

[...]

[1270504454:0] <- Empty Frame
[1270504454:0] <- Empty Frame
{noformat}

When time changes, observe exception

{noformat}
[1270504454:0] <- Close{error=Error{condition=amqp:resource-limit-exceeded, 
description='local-idle-timeout expired', info=null}}
[1270504454:0] -> Close{error=null}
11:08:49,009 ERROR Error while sending a message!
javax.jms.ResourceAllocationException: local-idle-timeout expired [condition = 
amqp:resource-limit-exceeded]
at 
org.apache.qpid.jms.provider.amqp.AmqpSupport.convertToException(AmqpSupport.java:146)
at 
org.apache.qpid.jms.provider.amqp.AmqpSupport.convertToException(AmqpSupport.java:118)
at 
org.apache.qpid.jms.provider.a

[jira] [Commented] (DISPATCH-1270) Inapropriate use of CLOCK_REALTIME for periodic timer

2019-02-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776643#comment-16776643
 ] 

ASF GitHub Bot commented on DISPATCH-1270:
--

jdanekrh commented on issue #450: DISPATCH-1270 - Use CLOCK_MONOTONIC for 
purpose of calling pn_transport_tick
URL: https://github.com/apache/qpid-dispatch/pull/450#issuecomment-466923363
 
 
   I've marked this as "draft" pending resolution of 
https://issues.apache.org/jira/browse/DISPATCH-1271 The LWS_CALLBACK_USER 
handler in http-libwebsockets.c is never triggered
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Inapropriate use of CLOCK_REALTIME for periodic timer
> -
>
> Key: DISPATCH-1270
> URL: https://issues.apache.org/jira/browse/DISPATCH-1270
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Jiri Daněk
>Priority: Major
>
> Similarly to Qpid Cpp broker (QPID-5865, QPID-6698), Qpid Dispatch router 
> currently uses CLOCK_REALTIME where CLOCK_MONOTONIC would be more appropriate.
> This wrong usage was highlighted by PROTON-985 which clarified that 
> {{pn_transport_tick}} should be given monotonic timestamp.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (DISPATCH-1270) Inapropriate use of CLOCK_REALTIME for periodic timer

2019-02-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/DISPATCH-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776642#comment-16776642
 ] 

ASF GitHub Bot commented on DISPATCH-1270:
--

jdanekrh commented on pull request #450: DISPATCH-1270 - Use CLOCK_MONOTONIC 
for purpose of calling pn_transport_tick
URL: https://github.com/apache/qpid-dispatch/pull/450
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Inapropriate use of CLOCK_REALTIME for periodic timer
> -
>
> Key: DISPATCH-1270
> URL: https://issues.apache.org/jira/browse/DISPATCH-1270
> Project: Qpid Dispatch
>  Issue Type: Bug
>Affects Versions: 1.5.0
>Reporter: Jiri Daněk
>Priority: Major
>
> Similarly to Qpid Cpp broker (QPID-5865, QPID-6698), Qpid Dispatch router 
> currently uses CLOCK_REALTIME where CLOCK_MONOTONIC would be more appropriate.
> This wrong usage was highlighted by PROTON-985 which clarified that 
> {{pn_transport_tick}} should be given monotonic timestamp.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] jdanekrh commented on issue #450: DISPATCH-1270 - Use CLOCK_MONOTONIC for purpose of calling pn_transport_tick

2019-02-25 Thread GitBox
jdanekrh commented on issue #450: DISPATCH-1270 - Use CLOCK_MONOTONIC for 
purpose of calling pn_transport_tick
URL: https://github.com/apache/qpid-dispatch/pull/450#issuecomment-466923363
 
 
   I've marked this as "draft" pending resolution of 
https://issues.apache.org/jira/browse/DISPATCH-1271 The LWS_CALLBACK_USER 
handler in http-libwebsockets.c is never triggered


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] jdanekrh opened a new pull request #450: DISPATCH-1270 - Use CLOCK_MONOTONIC for purpose of calling pn_transport_tick

2019-02-25 Thread GitBox
jdanekrh opened a new pull request #450: DISPATCH-1270 - Use CLOCK_MONOTONIC 
for purpose of calling pn_transport_tick
URL: https://github.com/apache/qpid-dispatch/pull/450
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Created] (DISPATCH-1271) The LWS_CALLBACK_USER handler in http-libwebsockets.c is never triggered

2019-02-25 Thread JIRA
Jiri Daněk created DISPATCH-1271:


 Summary: The LWS_CALLBACK_USER handler in http-libwebsockets.c is 
never triggered
 Key: DISPATCH-1271
 URL: https://issues.apache.org/jira/browse/DISPATCH-1271
 Project: Qpid Dispatch
  Issue Type: Bug
Affects Versions: 1.5.0
Reporter: Jiri Daněk


{noformat}
lws_callback_all_protocol(hs->context, &protocols[1], 
LWS_CALLBACK_USER);
lws_callback_all_protocol(hs->context, &protocols[2], 
LWS_CALLBACK_USER);
{noformat}

The problem is that {{lws_callback_all_protocol}} compares pointers to protocol 
structs with {{protocol}} parameter. They are never equal, because early on in 
{{listener_start}}, {{lws_create_vhost}} gets called, and it allocates a copy 
of the {{protocols}} array only for that vhost.

I expected that this will cause dispatch not to send heartbeats to clients 
connected over amqpws (since {{pn_transport_tick}} is not called). I tested 
that with qpid-jms, and it turned out that the heartbeats are flowing 
correctly. In other words, I am not aware of any user-visible bug caused by 
this. Is calling _tick unnecessary? What is it there for?

{noformat}
LWS_VISIBLE int
lws_callback_all_protocol(struct lws_context *context,
  const struct lws_protocols *protocol, int reason)
{
struct lws_context_per_thread *pt = &context->pt[0];
unsigned int n, m = context->count_threads;
struct lws *wsi;

while (m--) {
for (n = 0; n < pt->fds_count; n++) {
wsi = wsi_from_fd(context, pt->fds[n].fd);
if (!wsi)
continue;
if (wsi->protocol == protocol)
protocol->callback(wsi, reason, wsi->user_space,
   NULL, 0);
}
pt++;
}

return 0;
}
{noformat}

{noformat}
LWS_VISIBLE struct lws_vhost *
lws_create_vhost(struct lws_context *context,
 const struct lws_context_creation_info *info)
{
[...]

/*
 * give the vhost a unified list of protocols including the
 * ones that came from plugins
 */
lwsp = lws_zalloc(sizeof(struct lws_protocols) * (vh->count_protocols +
   context->plugin_protocol_count + 1),
  "vhost-specific plugin table");
if (!lwsp) {
lwsl_err("OOM\n");
return NULL;
}

m = vh->count_protocols;
memcpy(lwsp, pcols, sizeof(struct lws_protocols) * m);

[...]

if (
#ifdef LWS_WITH_PLUGINS
(context->plugin_list) ||
#endif
context->options & LWS_SERVER_OPTION_EXPLICIT_VHOSTS)
vh->protocols = lwsp;
else {
vh->protocols = pcols;
lws_free(lwsp);
}

[...]
}
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org